2021-10-15 22:12
ftp://ftp.de.debian.org/debian/pool/main/g/goaccess/goaccess_1.5.1.orig.tar.gz
cppcheck-options: --library=posix --library=gnu  --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp
platform: Linux-5.10.0-9-amd64-x86_64-with-glibc2.31
python: 3.9.2
client-version: 1.3.15
compiler: g++ (Debian 10.2.1-6) 10.2.1 20210110
cppcheck: head 2.6
head-info: d4a98dfaa (2021-10-15 22:50:29 +0200)
count: 83 83
elapsed-time: 3.5 3.1
head-timing-info:
 Overall time: 0s

old-timing-info:
 Overall time: 0s

head results:
goaccess-1.5.1/src/bin2c.c:120:3: portability: %lu in format string (no. 2) requires 'unsigned long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_uint]
goaccess-1.5.1/src/bin2c.c:138:3: portability: %lu in format string (no. 2) requires 'unsigned long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_uint]
goaccess-1.5.1/src/browsers.c:541:34: style:inconclusive: Function 'verify_browser' argument 2 names different: declaration 'browser_type' definition 'type'. [funcArgNamesDifferent]
goaccess-1.5.1/src/browsers.h:43:40: note: Function 'verify_browser' argument 2 names different: declaration 'browser_type' definition 'type'.
goaccess-1.5.1/src/browsers.c:541:34: note: Function 'verify_browser' argument 2 names different: declaration 'browser_type' definition 'type'.
goaccess-1.5.1/src/browsers.c:430:22: style: Parameter 'str' can be declared with const [constParameter]
goaccess-1.5.1/src/error.c:59:27: style:inconclusive: Function 'dbg_log_open' argument 1 names different: declaration 'file' definition 'path'. [funcArgNamesDifferent]
goaccess-1.5.1/src/error.h:85:32: note: Function 'dbg_log_open' argument 1 names different: declaration 'file' definition 'path'.
goaccess-1.5.1/src/error.c:59:27: note: Function 'dbg_log_open' argument 1 names different: declaration 'file' definition 'path'.
goaccess-1.5.1/src/geoip2.c:209:49: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB]
goaccess-1.5.1/src/geoip2.c:210:64: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB]
goaccess-1.5.1/src/geoip2.c:226:55: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB]
goaccess-1.5.1/src/geoip2.c:227:49: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB]
goaccess-1.5.1/src/geoip2.c:243:47: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB]
goaccess-1.5.1/src/csv.c:234:3: warning: fprintf format string requires 2 parameters but 4 are given. [wrongPrintfScanfArgNum]
goaccess-1.5.1/src/csv.c:239:3: warning: fprintf format string requires 2 parameters but 4 are given. [wrongPrintfScanfArgNum]
goaccess-1.5.1/src/csv.c:243:3: warning: fprintf format string requires 2 parameters but 4 are given. [wrongPrintfScanfArgNum]
goaccess-1.5.1/src/csv.c:253:3: warning: fprintf format string requires 2 parameters but 4 are given. [wrongPrintfScanfArgNum]
goaccess-1.5.1/src/csv.c:257:3: warning: fprintf format string requires 2 parameters but 4 are given. [wrongPrintfScanfArgNum]
goaccess-1.5.1/src/csv.c:261:3: warning: fprintf format string requires 2 parameters but 4 are given. [wrongPrintfScanfArgNum]
goaccess-1.5.1/src/csv.c:265:3: warning: fprintf format string requires 2 parameters but 4 are given. [wrongPrintfScanfArgNum]
goaccess-1.5.1/src/csv.c:269:3: warning: fprintf format string requires 2 parameters but 4 are given. [wrongPrintfScanfArgNum]
goaccess-1.5.1/src/csv.c:273:3: warning: fprintf format string requires 2 parameters but 4 are given. [wrongPrintfScanfArgNum]
goaccess-1.5.1/src/csv.c:281:3: warning: fprintf format string requires 2 parameters but 4 are given. [wrongPrintfScanfArgNum]
goaccess-1.5.1/src/gdns.c:234:25: style: Condition 'active_gdns' is always true [knownConditionTrueFalse]
goaccess-1.5.1/src/gmenu.c:90:56: style: Variable 'checked' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/websocket.h:88:0: error: #error Platform not supported! [preprocessorErrorDirective]
goaccess-1.5.1/src/gholder.c:400:14: style: Expression is always true because 'else if' condition is opposite to previous condition at line 398. [multiCondition]
goaccess-1.5.1/src/gholder.c:398:7: note: first condition
goaccess-1.5.1/src/gholder.c:400:14: note: else if condition is opposite to first condition
goaccess-1.5.1/src/gslist.c:168:23: style:inconclusive: Function 'list_count' argument 1 names different: declaration 'list' definition 'node'. [funcArgNamesDifferent]
goaccess-1.5.1/src/gslist.h:53:27: note: Function 'list_count' argument 1 names different: declaration 'list' definition 'node'.
goaccess-1.5.1/src/gslist.c:168:23: note: Function 'list_count' argument 1 names different: declaration 'list' definition 'node'.
goaccess-1.5.1/src/gslist.c:133:46: style: Parameter 'node' can be declared with const [constParameter]
goaccess-1.5.1/src/gdashboard.c:200:40: style:inconclusive: Function 'set_module_from_mouse_event' argument 1 names different: declaration 'scroll' definition 'gscroll'. [funcArgNamesDifferent]
goaccess-1.5.1/src/gdashboard.h:126:44: note: Function 'set_module_from_mouse_event' argument 1 names different: declaration 'scroll' definition 'gscroll'.
goaccess-1.5.1/src/gdashboard.c:200:40: note: Function 'set_module_from_mouse_event' argument 1 names different: declaration 'scroll' definition 'gscroll'.
goaccess-1.5.1/src/gdashboard.c:1107:56: style:inconclusive: Function 'display_content' argument 3 names different: declaration 'scroll' definition 'gscroll'. [funcArgNamesDifferent]
goaccess-1.5.1/src/gdashboard.h:128:61: note: Function 'display_content' argument 3 names different: declaration 'scroll' definition 'gscroll'.
goaccess-1.5.1/src/gdashboard.c:1107:56: note: Function 'display_content' argument 3 names different: declaration 'scroll' definition 'gscroll'.
goaccess-1.5.1/src/gdashboard.c:1137:33: style:inconclusive: Function 'reset_scroll_offsets' argument 1 names different: declaration 'scroll' definition 'gscroll'. [funcArgNamesDifferent]
goaccess-1.5.1/src/gdashboard.h:132:38: note: Function 'reset_scroll_offsets' argument 1 names different: declaration 'scroll' definition 'gscroll'.
goaccess-1.5.1/src/gdashboard.c:1137:33: note: Function 'reset_scroll_offsets' argument 1 names different: declaration 'scroll' definition 'gscroll'.
goaccess-1.5.1/src/gdashboard.c:1230:43: style:inconclusive: Function 'perform_next_find' argument 2 names different: declaration 'scroll' definition 'gscroll'. [funcArgNamesDifferent]
goaccess-1.5.1/src/gdashboard.h:124:47: note: Function 'perform_next_find' argument 2 names different: declaration 'scroll' definition 'gscroll'.
goaccess-1.5.1/src/gdashboard.c:1230:43: note: Function 'perform_next_find' argument 2 names different: declaration 'scroll' definition 'gscroll'.
goaccess-1.5.1/src/gdashboard.c:1306:50: style:inconclusive: Function 'render_find_dialog' argument 2 names different: declaration 'scroll' definition 'gscroll'. [funcArgNamesDifferent]
goaccess-1.5.1/src/gdashboard.h:125:54: note: Function 'render_find_dialog' argument 2 names different: declaration 'scroll' definition 'gscroll'.
goaccess-1.5.1/src/gdashboard.c:1306:50: note: Function 'render_find_dialog' argument 2 names different: declaration 'scroll' definition 'gscroll'.
goaccess-1.5.1/src/gdashboard.c:1415:73: style:inconclusive: Function 'load_data_to_dash' argument 4 names different: declaration 'scroll' definition 'gscroll'. [funcArgNamesDifferent]
goaccess-1.5.1/src/gdashboard.h:130:78: note: Function 'load_data_to_dash' argument 4 names different: declaration 'scroll' definition 'gscroll'.
goaccess-1.5.1/src/gdashboard.c:1415:73: note: Function 'load_data_to_dash' argument 4 names different: declaration 'scroll' definition 'gscroll'.
goaccess-1.5.1/src/gdashboard.c:1064:64: style: Parameter 'offset' can be declared with const [constParameter]
goaccess-1.5.1/src/gdashboard.c:1109:9: style: Variable 'j' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/gdashboard.c:1112:21: style: Variable 'offset' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/options.c:624:12: style: Condition '-1==o' is always false [knownConditionTrueFalse]
goaccess-1.5.1/src/options.c:623:73: note: Assuming that condition '(o=getopt_long(argc,argv,short_options,long_opts,&idx))>=0' is not redundant
goaccess-1.5.1/src/options.c:624:12: note: Condition '-1==o' is always false
goaccess-1.5.1/src/options.c:670:12: style: Condition '-1==o' is always false [knownConditionTrueFalse]
goaccess-1.5.1/src/options.c:669:73: note: Assuming that condition '(o=getopt_long(argc,argv,short_options,long_opts,&idx))>=0' is not redundant
goaccess-1.5.1/src/options.c:670:12: note: Condition '-1==o' is always false
goaccess-1.5.1/src/pdjson.c:389:12: style: Condition '0x80<=u' is always true [knownConditionTrueFalse]
goaccess-1.5.1/src/pdjson.c:386:9: note: Assuming that condition 'u<0x80' is not redundant
goaccess-1.5.1/src/pdjson.c:389:12: note: Condition '0x80<=u' is always true
goaccess-1.5.1/src/pdjson.c:956:46: style:inconclusive: Function 'json_set_streaming' argument 2 names different: declaration 'mode' definition 'streaming'. [funcArgNamesDifferent]
goaccess-1.5.1/src/pdjson.h:45:68: note: Function 'json_set_streaming' argument 2 names different: declaration 'mode' definition 'streaming'.
goaccess-1.5.1/src/pdjson.c:956:46: note: Function 'json_set_streaming' argument 2 names different: declaration 'mode' definition 'streaming'.
goaccess-1.5.1/src/pdjson.c:674:18: style: Local variable 'next' shadows outer function [shadowFunction]
goaccess-1.5.1/src/pdjson.c:625:1: note: Shadowed declaration
goaccess-1.5.1/src/pdjson.c:674:18: note: Shadow variable
goaccess-1.5.1/src/pdjson.c:689:20: style: Local variable 'next' shadows outer function [shadowFunction]
goaccess-1.5.1/src/pdjson.c:625:1: note: Shadowed declaration
goaccess-1.5.1/src/pdjson.c:689:20: note: Shadow variable
goaccess-1.5.1/src/pdjson.c:857:40: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
goaccess-1.5.1/src/pdjson.c:951:58: style: Parameter 'a' can be declared with const [constParameter]
goaccess-1.5.1/src/gstorage.c:1360:81: style: Condition 'logitem->status[0]=='4'' is always true [knownConditionTrueFalse]
goaccess-1.5.1/src/gstorage.c:1360:46: note: Assuming that condition 'logitem->status[0]!='4'' is not redundant
goaccess-1.5.1/src/gstorage.c:1360:81: note: Condition 'logitem->status[0]=='4'' is always true
goaccess-1.5.1/src/gstorage.c:1288:51: style: Parameter 'ftime' can be declared with const [constParameter]
goaccess-1.5.1/src/gkhash.c:752:21: style: Variable 'cnt' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/persistence.c:275:21: style: Variable 'ret' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/sha1.c:160:5: style: Variable 'a' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/persistence.c:306:21: style: Variable 'ret' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/sha1.c:160:9: style: Variable 'b' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/persistence.c:368:21: style: Variable 'ret' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/sha1.c:160:13: style: Variable 'c' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/persistence.c:432:21: style: Variable 'ret' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/sha1.c:160:17: style: Variable 'd' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/persistence.c:470:21: style: Variable 'ret' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/sha1.c:160:21: style: Variable 'e' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/persistence.c:532:21: style: Variable 'ret' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/sha1.c:222:5: style: Variable 'i' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/persistence.c:562:21: style: Variable 'ret' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/persistence.c:646:21: style: Variable 'ret' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/persistence.c:704:21: style: Variable 'ret' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/persistence.c:762:21: style: Variable 'ret' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/persistence.c:821:21: style: Variable 'ret' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/util.c:238:18: style: Redundant condition: If 'EXPR == '*'', the comparison 'EXPR' is always true. [redundantCondition]
goaccess-1.5.1/src/util.c:585:37: style: Checking if unsigned expression 'strftime(res,size,to,&tm)' is less than zero. [unsignedLessThanZero]
goaccess-1.5.1/src/util.c:263:29: style:inconclusive: Function 'ignore_referer' argument 1 names different: declaration 'ref' definition 'host'. [funcArgNamesDifferent]
goaccess-1.5.1/src/util.h:91:33: note: Function 'ignore_referer' argument 1 names different: declaration 'ref' definition 'host'.
goaccess-1.5.1/src/util.c:263:29: note: Function 'ignore_referer' argument 1 names different: declaration 'ref' definition 'host'.
goaccess-1.5.1/src/util.c:294:27: style:inconclusive: Function 'hide_referer' argument 1 names different: declaration 'ref' definition 'host'. [funcArgNamesDifferent]
goaccess-1.5.1/src/util.h:90:31: note: Function 'hide_referer' argument 1 names different: declaration 'ref' definition 'host'.
goaccess-1.5.1/src/util.c:294:27: note: Function 'hide_referer' argument 1 names different: declaration 'ref' definition 'host'.
goaccess-1.5.1/src/util.c:522:25: style: Variable 'ts' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/util.c:528:18: style: Variable 'seconds' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/settings.c:735:26: style:inconclusive: Function 'parse_json_string' argument 1 names different: declaration 'userdata' definition 'ptr_data'. [funcArgNamesDifferent]
goaccess-1.5.1/src/settings.h:222:30: note: Function 'parse_json_string' argument 1 names different: declaration 'userdata' definition 'ptr_data'.
goaccess-1.5.1/src/settings.c:735:26: note: Function 'parse_json_string' argument 1 names different: declaration 'userdata' definition 'ptr_data'.
goaccess-1.5.1/src/settings.c:852:34: style:inconclusive: Function 'set_date_format_str' argument 1 names different: declaration 'optarg' definition 'oarg'. [funcArgNamesDifferent]
goaccess-1.5.1/src/settings.h:224:39: note: Function 'set_date_format_str' argument 1 names different: declaration 'optarg' definition 'oarg'.
goaccess-1.5.1/src/settings.c:852:34: note: Function 'set_date_format_str' argument 1 names different: declaration 'optarg' definition 'oarg'.
goaccess-1.5.1/src/settings.c:879:34: style:inconclusive: Function 'set_time_format_str' argument 1 names different: declaration 'optarg' definition 'oarg'. [funcArgNamesDifferent]
goaccess-1.5.1/src/settings.h:227:39: note: Function 'set_time_format_str' argument 1 names different: declaration 'optarg' definition 'oarg'.
goaccess-1.5.1/src/settings.c:879:34: note: Function 'set_time_format_str' argument 1 names different: declaration 'optarg' definition 'oarg'.
goaccess-1.5.1/src/settings.c:923:33: style:inconclusive: Function 'set_log_format_str' argument 1 names different: declaration 'optarg' definition 'oarg'. [funcArgNamesDifferent]
goaccess-1.5.1/src/settings.h:225:38: note: Function 'set_log_format_str' argument 1 names different: declaration 'optarg' definition 'oarg'.
goaccess-1.5.1/src/settings.c:923:33: note: Function 'set_log_format_str' argument 1 names different: declaration 'optarg' definition 'oarg'.
goaccess-1.5.1/src/settings.c:652:12: style: Variable 'buflen' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/settings.c:725:25: style: Variable 'ptr' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/ui.c:761:16: style: Expression is always true because 'else if' condition is opposite to previous condition at line 759. [multiCondition]
goaccess-1.5.1/src/ui.c:759:11: note: first condition
goaccess-1.5.1/src/ui.c:761:16: note: else if condition is opposite to first condition
goaccess-1.5.1/src/tpl.c:2139:39: style: Checking if unsigned expression '((struct tpl_atyp*)(n->data))->num' is less than zero. [unsignedLessThanZero]
goaccess-1.5.1/src/tpl.c:1909:47: style:inconclusive: Function 'tpl_mmap_file' argument 2 names different: declaration 'map_rec' definition 'mr'. [funcArgNamesDifferent]
goaccess-1.5.1/src/tpl.c:186:58: note: Function 'tpl_mmap_file' argument 2 names different: declaration 'map_rec' definition 'mr'.
goaccess-1.5.1/src/tpl.c:1909:47: note: Function 'tpl_mmap_file' argument 2 names different: declaration 'map_rec' definition 'mr'.
goaccess-1.5.1/src/ui.c:773:17: style: Checking if unsigned expression 'pos' is less than zero. [unsignedLessThanZero]
goaccess-1.5.1/src/tpl.c:1608:10: style: Variable 'rc' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/ui.c:843:14: style: Variable 'newlen' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/ui.c:997:19: style: Variable 'tdiff' is assigned a value that is never used. [unreadVariable]
goaccess-1.5.1/src/ui.c:997:29: style: Variable 'psec' is assigned a value that is never used. [unreadVariable]
diff:
head goaccess-1.5.1/src/gdns.c:234:25: style: Condition 'active_gdns' is always true [knownConditionTrueFalse]
2.6 goaccess-1.5.1/src/gdns.c:234:25: style: Condition 'active_gdns' is always true [knownConditionTrueFalse]
     goaccess-1.5.1/src/gdns.c:227:9: note: Assuming that condition '!active_gdns' is not redundant
     goaccess-1.5.1/src/gdns.c:234:25: note: Condition 'active_gdns' is always true


DONE