2025-08-31 03:28 ftp://ftp.de.debian.org/debian/pool/main/g/gm-assistant/gm-assistant_1.2.4.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=bsd --library=qt --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.12.41+deb13-amd64-x86_64-with-glibc2.41 python: 3.13.5 client-version: 1.3.67 compiler: g++ (Debian 14.2.0-19) 14.2.0 cppcheck: head 2.18.0 head-info: 2ee39fe (2025-08-30 22:07:31 +0200) count: 273 269 elapsed-time: 0.5 0.5 head-timing-info: old-timing-info: head results: GM-Assistant-1.2.4/sources/engine/FileMapping.h:51:17: style: Class 'Iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/Branch.cpp:50:17: warning: Member variable 'Branch::pParent' is not assigned a value in 'Branch::operator='. [operatorEqVarError] GM-Assistant-1.2.4/sources/engine/FileMapping.cpp:79:5: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/FileMapping.cpp:86:5: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/IOConfig.h:65:9: style: Class 'IOConfig' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/Tree.h:97:9: style: Class 'Tree' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/Tree.h:59:17: style: Class 'iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/Tree.h:66:17: style: Class 'iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/Branch.h:33:9: style: Class 'Branch' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/IOConfig.h:70:28: performance: Function 'rootName()' should return member 'sRootName' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/IOConfig.h:80:28: performance: Function 'plotName()' should return member 'sPlotName' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/IOConfig.h:90:28: performance: Function 'propertiesName()' should return member 'sPropertiesName' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/IOConfig.h:100:28: performance: Function 'imageName()' should return member 'sImageName' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/IOConfig.h:110:28: performance: Function 'propertyName()' should return member 'sPropertyName' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/IOConfig.h:178:28: performance: Function 'temporaryDirectory()' should return member 'sTempDir' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/IOConfig.h:183:28: performance: Function 'descriptionName()' should return member 'sDescriptionName' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/IOConfig.h:309:36: style:inconclusive: Function 'setHasMetadata' argument 1 names different: declaration 'hadMetadata' definition 'hasMetadata'. [funcArgNamesDifferent] GM-Assistant-1.2.4/sources/engine/IOConfig.h:163:41: note: Function 'setHasMetadata' argument 1 names different: declaration 'hadMetadata' definition 'hasMetadata'. GM-Assistant-1.2.4/sources/engine/IOConfig.h:309:36: note: Function 'setHasMetadata' argument 1 names different: declaration 'hadMetadata' definition 'hasMetadata'. GM-Assistant-1.2.4/sources/engine/Character.h:41:17: style: Class 'PropertyIterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/Character.h:65:28: performance: Function 'name()' should return member 'sName' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/Character.h:75:28: performance: Function 'shortDescription()' should return member 'sShort' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/Character.cpp:113:12: style: Local variable 'property' shadows outer function [shadowFunction] GM-Assistant-1.2.4/sources/engine/Character.h:86:22: note: Shadowed declaration GM-Assistant-1.2.4/sources/engine/Character.cpp:113:12: note: Shadow variable GM-Assistant-1.2.4/sources/engine/Character.cpp:53:97: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/CharacterList.h:38:17: style: Class 'const_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/CharacterList.h:44:17: style: Class 'iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/CharacterList.h:45:17: style: Class 'iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/CharacterList.cpp:105:16: style: Variable 'character' can be declared as reference to const [constVariableReference] GM-Assistant-1.2.4/sources/engine/Metadata.cpp:112:28: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] GM-Assistant-1.2.4/sources/engine/CharacterList.cpp:35:95: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/Metadata.h:52:17: style: Class 'Date' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/Metadata.h:88:28: performance: Function 'title()' should return member 'sTitle' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/Metadata.h:98:28: performance: Function 'author()' should return member 'sAuthor' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/Metadata.h:118:28: performance: Function 'description()' should return member 'sDescription' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/Metadata.h:128:28: performance: Function 'rpg()' should return member 'sRpg' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/Metadata.h:138:28: performance: Function 'players()' should return member 'sPlayers' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/Metadata.cpp:112:16: style: Variable 'time_info' can be declared as pointer to const [constVariablePointer] GM-Assistant-1.2.4/sources/engine/IOConfig.cpp:64:13: style: Local variable 'version' shadows outer function [shadowFunction] GM-Assistant-1.2.4/sources/engine/IOConfig.h:140:24: note: Shadowed declaration GM-Assistant-1.2.4/sources/engine/IOConfig.cpp:64:13: note: Shadow variable GM-Assistant-1.2.4/sources/engine/Version.cpp:31:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable iMajor [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Version.cpp:41:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable iMajor [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Version.cpp:48:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable iMajor [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Version.cpp:54:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable iMajor [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Version.cpp:71:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable iMajor [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/PropertyList.h:39:17: style: Class 'iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/PropertyList.cpp:35:92: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/items/FileItem.h:91:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tFile [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Scenario.cpp:63:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable binary [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Scenario.cpp:269:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WRITE_XML_DECLARATION [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Scenario.cpp:337:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable uiFull [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Scenario.cpp:377:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable uiFull [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/items/ImageItem.h:49:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tImage [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/items/Item.h:55:9: style: Class 'Item' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/items/FileItem.h:50:9: style: Class 'FileItem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/items/FileItem.h:61:21: performance: Function 'fileName()' should return member 'sFileName' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/items/ImageItem.h:37:9: style: Class 'ImageItem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/items/ImageItem.h:42:14: style: The function 'type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/items/FileItem.h:56:14: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/items/ImageItem.h:42:14: note: Function in derived class GM-Assistant-1.2.4/sources/engine/items/ImageItem.h:44:21: style: The function 'subdirectory' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/items/FileItem.h:81:29: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/items/ImageItem.h:44:21: note: Function in derived class GM-Assistant-1.2.4/sources/engine/items/FileItem.cpp:74:17: style: Local variable 'fileName' shadows outer function [shadowFunction] GM-Assistant-1.2.4/sources/engine/items/FileItem.h:61:21: note: Shadowed declaration GM-Assistant-1.2.4/sources/engine/items/FileItem.cpp:74:17: note: Shadow variable GM-Assistant-1.2.4/sources/engine/items/SoundItem.h:48:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tSound [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/items/Item.h:61:21: performance: Function 'content()' should return member 'sContent' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/items/SoundItem.h:36:9: style: Class 'SoundItem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/items/Item.cpp:86:29: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] GM-Assistant-1.2.4/sources/engine/items/SoundItem.h:41:14: style: The function 'type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/items/FileItem.h:56:14: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/items/SoundItem.h:41:14: note: Function in derived class GM-Assistant-1.2.4/sources/engine/items/SoundItem.h:43:21: style: The function 'subdirectory' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/items/FileItem.h:81:29: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/items/SoundItem.h:43:21: note: Function in derived class GM-Assistant-1.2.4/sources/engine/Tree.cpp:84:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tImage [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Tree.cpp:101:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ELEMENT_NODE [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Tree.cpp:155:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sSuccess [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Tree.cpp:189:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sNone [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Tree.cpp:219:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable in [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Tree.cpp:583:77: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sSuccess [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Scenario.h:104:18: performance: Function 'configuration()' should return member 'ioConfig' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/modifications/MetadataModification.cpp:27:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tMetadata [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Scenario.cpp:55:21: style: Unused variable: fileType [unusedVariable] GM-Assistant-1.2.4/sources/engine/modifications/MetadataModification.h:39:14: style: The function 'type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:74:22: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/modifications/MetadataModification.h:39:14: note: Function in derived class GM-Assistant-1.2.4/sources/engine/modifications/MetadataModification.h:40:14: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:78:22: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/modifications/MetadataModification.h:40:14: note: Function in derived class GM-Assistant-1.2.4/sources/engine/modifications/MetadataModification.h:41:14: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:82:22: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/modifications/MetadataModification.h:41:14: note: Function in derived class GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:65:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tCharacter [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:23:24: warning: Member variable 'CharacterModification::iNewIndex' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:27:24: warning: Member variable 'CharacterModification::iNewIndex' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:31:24: warning: Member variable 'CharacterModification::iNewIndex' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:35:24: warning: Member variable 'CharacterModification::iNewIndex' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:39:24: warning: Member variable 'CharacterModification::iNewIndex' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:59:16: warning: Class 'CharacterModification' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:59:16: warning: Class 'CharacterModification' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.h:114:18: style: The destructor '~CharacterModification' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:64:18: note: Virtual destructor in base class GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.h:114:18: note: Destructor in derived class GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.h:116:14: style: The function 'type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:74:22: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.h:116:14: note: Function in derived class GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.h:118:14: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:78:22: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.h:118:14: note: Function in derived class GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.h:119:14: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:82:22: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.h:119:14: note: Function in derived class GM-Assistant-1.2.4/sources/engine/modifications/ModificationQueue.cpp:34:85: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:41:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tNote [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:100:137: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:113:137: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:131:137: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:181:137: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:193:137: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:210:137: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:23:19: warning: Member variable 'NoteModification::iNewIndex' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:23:19: warning: Member variable 'NoteModification::iLength' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:31:19: warning: Member variable 'NoteModification::iNewIndex' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:31:19: warning: Member variable 'NoteModification::iLength' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.h:58:18: style: The destructor '~NoteModification' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:64:18: note: Virtual destructor in base class GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.h:58:18: note: Destructor in derived class GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.h:60:14: style: The function 'type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:74:22: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.h:60:14: note: Function in derived class GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.h:61:14: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:78:22: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.h:61:14: note: Function in derived class GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.h:62:14: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:82:22: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.h:62:14: note: Function in derived class GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.h:82:21: performance: Function 'content()' should return member 'sContent' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.h:87:21: performance: Function 'newContent()' should return member 'sNewContent' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:51:37: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:55:37: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:58:33: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:60:33: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:62:33: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:74:37: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:78:37: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:81:33: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:83:33: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] GM-Assistant-1.2.4/sources/engine/modifications/NoteModification.cpp:85:33: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] GM-Assistant-1.2.4/sources/widgets/QCustomHeaderView.cpp:26:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ResizeToContents [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.h:189:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tTree [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomHeaderView.h:45:9: style: Class 'QCustomHeaderView' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.cpp:25:19: warning: Member variable 'TreeModification::etEditType' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.cpp:25:19: warning: Member variable 'TreeModification::pCurrentItem' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.cpp:29:19: warning: Member variable 'TreeModification::etEditType' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.cpp:29:19: warning: Member variable 'TreeModification::pCurrentItem' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.cpp:33:19: warning: Member variable 'TreeModification::pCurrentItem' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.cpp:37:19: warning: Member variable 'TreeModification::pCurrentItem' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.cpp:41:19: warning: Member variable 'TreeModification::pCurrentItem' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.cpp:45:19: warning: Member variable 'TreeModification::etEditType' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.cpp:45:19: warning: Member variable 'TreeModification::pCurrentItem' is not initialized in the constructor. [uninitMemberVar] GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.cpp:53:16: warning: Class 'TreeModification' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.cpp:53:16: warning: Class 'TreeModification' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.h:91:18: style: The destructor '~TreeModification' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:64:18: note: Virtual destructor in base class GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.h:91:18: note: Destructor in derived class GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.h:93:21: style: The function 'type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:74:22: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.h:93:21: note: Function in derived class GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.h:100:14: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:78:22: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.h:100:14: note: Function in derived class GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.h:101:14: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] GM-Assistant-1.2.4/sources/engine/modifications/Modification.h:82:22: note: Virtual function in base class GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.h:101:14: note: Function in derived class GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.h:106:28: performance: Function 'indices()' should return member 'sIndices' by const reference. [returnByReference] GM-Assistant-1.2.4/sources/engine/Tree.cpp:609:5: style: Exception should be caught by reference. [catchExceptionByValue] GM-Assistant-1.2.4/sources/engine/Tree.cpp:621:5: style: Exception should be caught by reference. [catchExceptionByValue] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:162:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ControlModifier [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:291:74: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ClearAndSelect [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:336:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LeftButton [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:366:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LeftButton [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:401:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:443:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:504:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ClearAndSelect [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:538:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ClearAndSelect [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:550:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:573:74: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:592:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SelectItems [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:767:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OtherFocusReason [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:796:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LanguageChange [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/engine/Tree.cpp:628:43: style:inconclusive: Function 'setItem' argument 2 names different: declaration 'newItem' definition 'item'. [funcArgNamesDifferent] GM-Assistant-1.2.4/sources/engine/Tree.h:164:50: note: Function 'setItem' argument 2 names different: declaration 'newItem' definition 'item'. GM-Assistant-1.2.4/sources/engine/Tree.cpp:628:43: note: Function 'setItem' argument 2 names different: declaration 'newItem' definition 'item'. GM-Assistant-1.2.4/sources/engine/Tree.cpp:58:17: style: Local variable 'branch' shadows outer function [shadowFunction] GM-Assistant-1.2.4/sources/engine/Tree.h:204:17: note: Shadowed declaration GM-Assistant-1.2.4/sources/engine/Tree.cpp:58:17: note: Shadow variable GM-Assistant-1.2.4/sources/engine/Tree.cpp:130:25: style: Local variable 'branch' shadows outer function [shadowFunction] GM-Assistant-1.2.4/sources/engine/Tree.h:204:17: note: Shadowed declaration GM-Assistant-1.2.4/sources/engine/Tree.cpp:130:25: note: Shadow variable GM-Assistant-1.2.4/sources/engine/Tree.cpp:304:13: style: Local variable 'branch' shadows outer function [shadowFunction] GM-Assistant-1.2.4/sources/engine/Tree.h:204:17: note: Shadowed declaration GM-Assistant-1.2.4/sources/engine/Tree.cpp:304:13: note: Shadow variable GM-Assistant-1.2.4/sources/engine/Tree.cpp:348:13: style: Local variable 'branch' shadows outer function [shadowFunction] GM-Assistant-1.2.4/sources/engine/Tree.h:204:17: note: Shadowed declaration GM-Assistant-1.2.4/sources/engine/Tree.cpp:348:13: note: Shadow variable GM-Assistant-1.2.4/sources/engine/Tree.cpp:359:13: style: Local variable 'branch' shadows outer function [shadowFunction] GM-Assistant-1.2.4/sources/engine/Tree.h:204:17: note: Shadowed declaration GM-Assistant-1.2.4/sources/engine/Tree.cpp:359:13: note: Shadow variable GM-Assistant-1.2.4/sources/engine/Tree.cpp:454:15: style: Local variable 'parent' shadows outer function [shadowFunction] GM-Assistant-1.2.4/sources/engine/Tree.h:140:17: note: Shadowed declaration GM-Assistant-1.2.4/sources/engine/Tree.cpp:454:15: note: Shadow variable GM-Assistant-1.2.4/sources/engine/Tree.cpp:477:15: style: Local variable 'parent' shadows outer function [shadowFunction] GM-Assistant-1.2.4/sources/engine/Tree.h:140:17: note: Shadowed declaration GM-Assistant-1.2.4/sources/engine/Tree.cpp:477:15: note: Shadow variable GM-Assistant-1.2.4/sources/engine/Tree.cpp:588:29: style: Local variable 'sState' shadows outer variable [shadowVariable] GM-Assistant-1.2.4/sources/engine/Tree.h:47:29: note: Shadowed declaration GM-Assistant-1.2.4/sources/engine/Tree.cpp:588:29: note: Shadow variable GM-Assistant-1.2.4/sources/engine/Tree.cpp:628:28: style: Parameter 'indices' can be declared as reference to const [constParameterReference] GM-Assistant-1.2.4/sources/engine/Tree.cpp:427:27: style: Parameter 'branch' can be declared as pointer to const [constParameterPointer] GM-Assistant-1.2.4/sources/engine/Tree.cpp:383:9: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] GM-Assistant-1.2.4/sources/engine/Tree.cpp:244:23: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] GM-Assistant-1.2.4/sources/engine/Tree.cpp:528:73: error: Iterators of different containers 'qIts' and 'it.qIts' are used together. [mismatchingContainers] GM-Assistant-1.2.4/sources/engine/Tree.cpp:546:68: error: Iterators of different containers 'qIts' and '(*(*(it+1)))->tree().vChildren' are used together. [mismatchingContainers] GM-Assistant-1.2.4/sources/engine/Tree.cpp:56:97: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/Tree.cpp:72:87: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/Tree.cpp:140:85: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/Tree.cpp:157:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/Tree.cpp:168:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/Tree.cpp:193:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/Tree.cpp:212:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/Tree.cpp:434:107: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/Tree.cpp:528:105: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/Tree.cpp:534:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/Tree.cpp:564:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/engine/Tree.cpp:636:83: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/widgets/QCustomTextEdit.cpp:48:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sMove [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTextEdit.cpp:73:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sMove [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTextEdit.cpp:174:99: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable aAddition [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTextEdit.cpp:193:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sMove [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTextEdit.cpp:212:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sMove [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTextEdit.cpp:224:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sMove [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTextEdit.cpp:319:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OtherFocusReason [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTextEdit.cpp:324:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sMove [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidgetItem.cpp:53:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tFile [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.h:58:9: style: Class 'QCustomTreeWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:94:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable pmNone [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:140:77: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable pmNone [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:240:102: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ItemIsEditable [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:431:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable in [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:473:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:653:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tSound [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:738:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LanguageChange [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:804:198: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DontUseNativeDialog [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:821:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tSound [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/AboutDialog.cpp:34:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LanguageChange [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/AboutDialog.h:36:9: style: Class 'AboutDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/windows/ChangeCharacterDialog.cpp:56:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LanguageChange [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/ChangeCharacterDialog.h:37:9: style: Class 'ChangeCharacterDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/windows/ChangeCharacterDialog.cpp:42:13: style: Local variable 'name' shadows outer function [shadowFunction] GM-Assistant-1.2.4/sources/windows/ChangeCharacterDialog.h:42:24: note: Shadowed declaration GM-Assistant-1.2.4/sources/windows/ChangeCharacterDialog.cpp:42:13: note: Shadow variable GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.h:185:9: style: Class 'QCustomTableWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/windows/ChangePropertyDialog.cpp:54:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LanguageChange [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/ChangePropertyDialog.h:36:9: style: Class 'ChangePropertyDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:75:9: style: The scope of the variable 'rowPosition' can be reduced. [variableScope] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:75:22: style: The scope of the variable 'columnPosition' can be reduced. [variableScope] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:109:46: style: Variable 'action' can be declared as pointer to const [constVariablePointer] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:348:18: style: Variable 'action' can be declared as pointer to const [constVariablePointer] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:378:18: style: Variable 'action' can be declared as pointer to const [constVariablePointer] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:255:86: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:262:87: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:454:93: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:517:95: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/widgets/QCustomTableWidget.cpp:631:91: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/windows/CombatDialog.cpp:27:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Fixed [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/CombatDialog.cpp:68:79: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ToolTipBase [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/CombatDialog.cpp:107:318: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/CombatDialog.cpp:125:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LanguageChange [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/CombatDialog.cpp:139:288: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/DiceDialog.cpp:78:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LanguageChange [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/DiceDialog.h:35:9: style: Class 'DiceDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/windows/CombatDialog.h:53:9: style: Class 'CombatDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/windows/CombatDialog.cpp:38:75: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/windows/ImageWindow.cpp:27:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AlignCenter [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/ImageWindow.cpp:76:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WindowMaximized [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/ImageWindow.cpp:110:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Format_ARGB32 [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/ImageWindow.h:82:9: style: Class 'ImageWindow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:321:13: style: The scope of the variable 'depth' can be reduced. [variableScope] GM-Assistant-1.2.4/sources/windows/ImageWindow.cpp:25:45: style:inconclusive: Function 'ImageWindow' argument 1 names different: declaration 'imageFileName' definition 'pictureFileName'. [funcArgNamesDifferent] GM-Assistant-1.2.4/sources/windows/ImageWindow.h:82:40: note: Function 'ImageWindow' argument 1 names different: declaration 'imageFileName' definition 'pictureFileName'. GM-Assistant-1.2.4/sources/windows/ImageWindow.cpp:25:45: note: Function 'ImageWindow' argument 1 names different: declaration 'imageFileName' definition 'pictureFileName'. GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:93:44: style: Variable 'soundItem' can be declared as pointer to const [constVariablePointer] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:163:46: style: Variable 'action' can be declared as pointer to const [constVariablePointer] GM-Assistant-1.2.4/sources/windows/ItemDialog.cpp:27:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ExistingFile [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/ItemDialog.cpp:35:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sNone [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/ItemDialog.cpp:52:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tSound [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/ItemDialog.cpp:145:279: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DontUseNativeDialog [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/ItemDialog.cpp:156:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tBasic [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/ItemDialog.cpp:206:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LanguageChange [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:321:18: style: Variable 'depth' is assigned a value that is never used. [unreadVariable] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:322:70: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/widgets/QCustomTreeWidget.cpp:825:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/windows/ItemDialog.h:40:9: style: Class 'ItemDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/windows/MetadataDialog.cpp:28:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LanguageChange [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MetadataDialog.h:46:9: style: Class 'MetadataDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/windows/SelectCharacterDialog.cpp:33:310: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/SelectCharacterDialog.cpp:74:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LanguageChange [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/SelectCharacterDialog.cpp:45:77: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:43:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable actionMusic [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:194:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable gbCharacter [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:213:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable gbMusic [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:224:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable gbPlot [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:243:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable gbPlot [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:256:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable gbPlot [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:269:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable gbPlot [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:295:256: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DontUseNativeDialog [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:341:370: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:372:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AcceptSave [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:415:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable uiFull [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:474:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tSound [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:486:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable StoppedState [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:578:254: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:758:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KeyPress [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:827:265: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Save [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:859:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LanguageChange [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:872:76: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TranslationsPath [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:878:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoError [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:888:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] GM-Assistant-1.2.4/sources/windows/MainWindow.h:136:9: style: Class 'MainWindow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:476:36: style: Variable 'sItem' can be declared as pointer to const [constVariablePointer] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:682:23: style: Variable 'adr' can be declared as pointer to const [constVariablePointer] GM-Assistant-1.2.4/sources/windows/MainWindow.cpp:626:75: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/widgets/QCustomTextEdit.h:38:9: style: Class 'QCustomTextEdit' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] GM-Assistant-1.2.4/sources/widgets/QCustomTextEdit.cpp:87:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/widgets/QCustomTextEdit.cpp:88:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/widgets/QCustomTextEdit.cpp:100:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] GM-Assistant-1.2.4/sources/widgets/QCustomTextEdit.cpp:101:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] diff: head GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:59:16: warning: Class 'CharacterModification' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] head GM-Assistant-1.2.4/sources/engine/modifications/CharacterModification.cpp:59:16: warning: Class 'CharacterModification' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] head GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.cpp:53:16: warning: Class 'TreeModification' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] head GM-Assistant-1.2.4/sources/engine/modifications/TreeModification.cpp:53:16: warning: Class 'TreeModification' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] DONE