2022-06-28 01:24
ftp://ftp.de.debian.org/debian/pool/main/g/glhack/glhack_1.2.orig.tar.gz
cppcheck-options: --library=posix --library=gnu  --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j2
platform: Linux-5.4.0-110-generic-x86_64-with-glibc2.29
python: 3.8.10
client-version: 1.3.24
compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
cppcheck: head 2.8
head-info: cdeebc1 (2022-06-27 20:55:09 +0200)
count: 667 663
elapsed-time: 56.8 71.1
head-timing-info:
 Overall time: 0s

old-timing-info:
 Overall time: 0s

head results:
glhack-1.2/src/detect.c:859:41: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/display.c:366:35: warning: Either the condition 'mon' is redundant or there is possible null pointer dereference: mon. [nullPointerRedundantCheck]
glhack-1.2/src/display.c:620:3: note: Assuming that condition 'mon' is not redundant
glhack-1.2/src/display.c:618:24: note: Calling function 'display_monster', 3rd argument 'mon' value is 0
glhack-1.2/src/display.c:366:35: note: Null pointer dereference
glhack-1.2/src/display.c:1945:33: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
glhack-1.2/src/display.c:2034:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
glhack-1.2/src/display.c:2037:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
glhack-1.2/src/display.c:2052:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
glhack-1.2/src/display.c:2055:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
glhack-1.2/src/display.c:2079:6: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
glhack-1.2/src/display.c:2082:6: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
glhack-1.2/src/display.c:2085:6: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
glhack-1.2/src/display.c:2088:6: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
glhack-1.2/src/display.c:2155:23: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
glhack-1.2/src/display.c:2157:23: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
glhack-1.2/src/dothrow.c:1010:6: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/dothrow.c:1265:11: style: Variable 'obj' is assigned a value that is never used. [unreadVariable]
glhack-1.2/src/drawing.c:650:39: warning: Possible null pointer dereference: graph_chars [nullPointer]
glhack-1.2/src/drawing.c:661:22: note: Calling function 'assign_graphics', 1st argument '(uchar*)0' value is 0
glhack-1.2/src/drawing.c:650:39: note: Null pointer dereference
glhack-1.2/src/drawing.c:651:10: warning: Possible null pointer dereference: graph_chars [nullPointer]
glhack-1.2/src/drawing.c:661:22: note: Calling function 'assign_graphics', 1st argument '(uchar*)0' value is 0
glhack-1.2/src/drawing.c:651:10: note: Null pointer dereference
glhack-1.2/src/dokick.c:495:8: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/dokick.c:1209:6: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/dokick.c:1329:10: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/dokick.c:771:20: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
glhack-1.2/src/end.c:310:1: error: Unmatched '}'. Configuration: '__GNUC__=1'. [syntaxError]
glhack-1.2/src/files.c:2176:0: error: #error "Where to write config file for this platform ??" [preprocessorErrorDirective]
glhack-1.2/src/fountain.c:96:6: style: Condition '!madepool' is always true [knownConditionTrueFalse]
glhack-1.2/src/fountain.c:93:17: note: Assignment 'madepool=0', assigned value is 0
glhack-1.2/src/fountain.c:96:6: note: Condition '!madepool' is always true
glhack-1.2/src/lock.c:12:14: style: struct member 'xlock_s::door' is never used. [unusedStructMember]
glhack-1.2/src/lock.c:13:14: style: struct member 'xlock_s::box' is never used. [unusedStructMember]
glhack-1.2/src/lock.c:14:6: style: struct member 'xlock_s::picktyp' is never used. [unusedStructMember]
glhack-1.2/src/lock.c:14:15: style: struct member 'xlock_s::chance' is never used. [unusedStructMember]
glhack-1.2/src/lock.c:14:23: style: struct member 'xlock_s::usedtime' is never used. [unusedStructMember]
glhack-1.2/src/mapglyph.c:159:24: style: Variable 'offset' is assigned a value that is never used. [unreadVariable]
glhack-1.2/src/mapglyph.c:179:24: style: Variable 'offset' is assigned a value that is never used. [unreadVariable]
glhack-1.2/src/mkobj.c:24:10: style: struct member 'icp::iprob' is never used. [unusedStructMember]
glhack-1.2/src/mkobj.c:25:10: style: struct member 'icp::iclass' is never used. [unusedStructMember]
glhack-1.2/src/mkmaze.c:480:31: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/mkmaze.c:813:6: style: Local variable 'xmin' shadows outer variable [shadowVariable]
glhack-1.2/src/mkmaze.c:922:12: note: Shadowed declaration
glhack-1.2/src/mkmaze.c:813:6: note: Shadow variable
glhack-1.2/src/mkmaze.c:813:11: style: Local variable 'xmax' shadows outer variable [shadowVariable]
glhack-1.2/src/mkmaze.c:922:24: note: Shadowed declaration
glhack-1.2/src/mkmaze.c:813:11: note: Shadow variable
glhack-1.2/src/mkmaze.c:813:16: style: Local variable 'ymin' shadows outer variable [shadowVariable]
glhack-1.2/src/mkmaze.c:922:18: note: Shadowed declaration
glhack-1.2/src/mkmaze.c:813:16: note: Shadow variable
glhack-1.2/src/mkmaze.c:813:21: style: Local variable 'ymax' shadows outer variable [shadowVariable]
glhack-1.2/src/mkmaze.c:922:30: note: Shadowed declaration
glhack-1.2/src/mkmaze.c:813:21: note: Shadow variable
glhack-1.2/src/mkmaze.c:134:15: style: Variable 'spine_array' can be declared as const array [constVariable]
glhack-1.2/src/mkmaze.c:1124:26: error: Uninitialized variable: n [uninitvar]
glhack-1.2/src/mkmaze.c:1121:6: note: Assuming condition is false
glhack-1.2/src/mkmaze.c:1124:26: note: Uninitialized variable: n
glhack-1.2/src/mkmaze.c:1119:6: style: Variable 'n' is not assigned a value. [unassignedVariable]
glhack-1.2/src/monst.c:2559:0: error: failed to expand 'MON', Wrong number of parameters for macro 'A'. [preprocessorErrorDirective]
glhack-1.2/src/o_init.c:395:10: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/muse.c:256:23: style: Local variable 'obj' shadows outer variable [shadowVariable]
glhack-1.2/src/muse.c:1180:13: note: Shadowed declaration
glhack-1.2/src/muse.c:256:23: note: Shadow variable
glhack-1.2/src/muse.c:968:23: style: Local variable 'obj' shadows outer variable [shadowVariable]
glhack-1.2/src/muse.c:1180:13: note: Shadowed declaration
glhack-1.2/src/muse.c:968:23: note: Shadow variable
glhack-1.2/src/muse.c:1569:23: style: Local variable 'obj' shadows outer variable [shadowVariable]
glhack-1.2/src/muse.c:1180:13: note: Shadowed declaration
glhack-1.2/src/muse.c:1569:23: note: Shadow variable
glhack-1.2/src/muse.c:1819:19: style: Local variable 'obj' shadows outer variable [shadowVariable]
glhack-1.2/src/muse.c:1180:13: note: Shadowed declaration
glhack-1.2/src/muse.c:1819:19: note: Shadow variable
glhack-1.2/src/muse.c:2107:14: style: Local variable 'obj' shadows outer variable [shadowVariable]
glhack-1.2/src/muse.c:1180:13: note: Shadowed declaration
glhack-1.2/src/muse.c:2107:14: note: Shadow variable
glhack-1.2/src/objects.c:7:30: style: struct member 'monst::dummy' is never used. [unusedStructMember]
glhack-1.2/src/objnam.c:20:6: style: struct member 'Jitem::item' is never used. [unusedStructMember]
glhack-1.2/src/objnam.c:21:14: style: struct member 'Jitem::name' is never used. [unusedStructMember]
glhack-1.2/src/objnam.c:1487:14: style: struct member 'o_range::name' is never used. [unusedStructMember]
glhack-1.2/src/objnam.c:1487:20: style: struct member 'o_range::oclass' is never used. [unusedStructMember]
glhack-1.2/src/objnam.c:1488:7: style: struct member 'o_range::f_o_range' is never used. [unusedStructMember]
glhack-1.2/src/objnam.c:1488:18: style: struct member 'o_range::l_o_range' is never used. [unusedStructMember]
glhack-1.2/src/pager.c:391:14: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pager.c:435:13: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pager.c:436:7: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pager.c:815:8: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pager.c:717:7: style: Condition '*firstmatch' is always true [knownConditionTrueFalse]
glhack-1.2/src/pager.c:380:13: warning: %lx in format string (no. 1) requires 'unsigned long *' but the argument type is 'signed long *'. [invalidScanfArgType_int]
glhack-1.2/src/pager.c:228:21: style: Variable 'ways_seen' is assigned a value that is never used. [unreadVariable]
glhack-1.2/src/pickup.c:223:8: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pickup.c:328:11: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pickup.c:329:3: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pickup.c:331:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pickup.c:334:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pickup.c:337:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pickup.c:340:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pickup.c:369:14: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pickup.c:548:37: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pickup.c:642:22: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pickup.c:654:19: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pickup.c:1391:11: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/pickup.c:421:14: style: Redundant condition: u.utrap. '!u.utrap || (u.utrap && u.utraptype!=TT_PIT)' is equivalent to '!u.utrap || u.utraptype!=TT_PIT' [redundantCondition]
glhack-1.2/src/pickup.c:1090:15: style: Variable 'obj->quan' is reassigned a value before the old one has been used. [redundantAssignment]
glhack-1.2/src/pickup.c:1045:13: note: obj->quan is assigned
glhack-1.2/src/pickup.c:1090:15: note: obj->quan is overwritten
glhack-1.2/src/pickup.c:167:6: style: Local variable 'itemcount' shadows outer variable [shadowVariable]
glhack-1.2/src/pickup.c:97:6: note: Shadowed declaration
glhack-1.2/src/pickup.c:167:6: note: Shadow variable
glhack-1.2/src/pickup.c:389:13: style: Local variable 'pick_list' shadows outer variable [shadowVariable]
glhack-1.2/src/pickup.c:689:13: note: Shadowed declaration
glhack-1.2/src/pickup.c:389:13: note: Shadow variable
glhack-1.2/src/pickup.c:1754:14: style: Local variable 'otmp' shadows outer variable [shadowVariable]
glhack-1.2/src/pickup.c:94:22: note: Shadowed declaration
glhack-1.2/src/pickup.c:1754:14: note: Shadow variable
glhack-1.2/src/pickup.c:1930:23: style: Local variable 'otmp' shadows outer variable [shadowVariable]
glhack-1.2/src/pickup.c:94:22: note: Shadowed declaration
glhack-1.2/src/pickup.c:1930:23: note: Shadow variable
glhack-1.2/src/pickup.c:2075:21: style: Local variable 'otmp' shadows outer variable [shadowVariable]
glhack-1.2/src/pickup.c:94:22: note: Shadowed declaration
glhack-1.2/src/pickup.c:2075:21: note: Shadow variable
glhack-1.2/src/pickup.c:2310:17: style: Local variable 'otmp' shadows outer variable [shadowVariable]
glhack-1.2/src/pickup.c:94:22: note: Shadowed declaration
glhack-1.2/src/pickup.c:2310:17: note: Shadow variable
glhack-1.2/src/pickup.c:2311:16: style: Local variable 'pick_list' shadows outer variable [shadowVariable]
glhack-1.2/src/pickup.c:689:13: note: Shadowed declaration
glhack-1.2/src/pickup.c:2311:16: note: Shadow variable
glhack-1.2/src/pickup.c:2381:16: style: Local variable 'pick_list' shadows outer variable [shadowVariable]
glhack-1.2/src/pickup.c:689:13: note: Shadowed declaration
glhack-1.2/src/pickup.c:2381:16: note: Shadow variable
glhack-1.2/src/pickup.c:309:13: style: Parameter 'obj' can be declared as pointer to const [constParameter]
glhack-1.2/src/pickup.c:1920:13: style: Parameter 'obj' can be declared as pointer to const [constParameter]
glhack-1.2/src/pickup.c:175:43: error: Uninitialized variable: itemcount [uninitvar]
glhack-1.2/src/pickup.c:184:18: style: Variable 'ilets[iletct]' is assigned a value that is never used. [unreadVariable]
glhack-1.2/src/pickup.c:1685:11: style: Variable 'c' is assigned a value that is never used. [unreadVariable]
glhack-1.2/src/quest.c:191:16: style: Variable 'otmp' is assigned a value that is never used. [unreadVariable]
glhack-1.2/src/region.c:675:31: error: Uninitialized variable: tmstamp [uninitvar]
glhack-1.2/src/restore.c:720:6: style: The if condition is the same as the previous if condition [duplicateCondition]
glhack-1.2/src/restore.c:711:6: note: First condition
glhack-1.2/src/restore.c:720:6: note: Second condition
glhack-1.2/src/restore.c:135:28: error: Uninitialized variable: cnt [uninitvar]
glhack-1.2/src/restore.c:158:28: error: Uninitialized variable: counter [uninitvar]
glhack-1.2/src/restore.c:255:27: error: Uninitialized variable: monbegin [uninitvar]
glhack-1.2/src/restore.c:366:28: error: Uninitialized variable: uid [uninitvar]
glhack-1.2/src/restore.c:723:28: error: Uninitialized variable: hpid [uninitvar]
glhack-1.2/src/restore.c:729:28: error: Uninitialized variable: dlvl [uninitvar]
glhack-1.2/src/restore.c:986:35: error: Uninitialized variable: oldid [uninitvar]
glhack-1.2/src/role.c:771:20: warning: Either the condition 'gendnum>=0' is redundant or the array 'genders[3]' is accessed at index 3, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/src/role.c:770:14: note: Assuming that condition 'gendnum>=0' is not redundant
glhack-1.2/src/role.c:771:20: note: Array index out of bounds
glhack-1.2/src/role.c:774:19: warning: Either the condition 'alignnum>=0' is redundant or the array 'aligns[4]' is accessed at index 4, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/src/role.c:773:15: note: Assuming that condition 'alignnum>=0' is not redundant
glhack-1.2/src/role.c:774:19: note: Array index out of bounds
glhack-1.2/src/role.c:784:24: warning: Either the condition 'gendnum>=0' is redundant or the array 'genders[3]' is accessed at index 3, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/src/role.c:783:18: note: Assuming that condition 'gendnum>=0' is not redundant
glhack-1.2/src/role.c:784:24: note: Array index out of bounds
glhack-1.2/src/role.c:787:23: warning: Either the condition 'alignnum>=0' is redundant or the array 'aligns[4]' is accessed at index 4, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/src/role.c:786:19: note: Assuming that condition 'alignnum>=0' is not redundant
glhack-1.2/src/role.c:787:23: note: Array index out of bounds
glhack-1.2/src/role.c:837:20: warning: Either the condition 'gendnum>=0' is redundant or the array 'genders[3]' is accessed at index 3, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/src/role.c:836:14: note: Assuming that condition 'gendnum>=0' is not redundant
glhack-1.2/src/role.c:837:20: note: Array index out of bounds
glhack-1.2/src/role.c:840:19: warning: Either the condition 'alignnum>=0' is redundant or the array 'aligns[4]' is accessed at index 4, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/src/role.c:839:15: note: Assuming that condition 'alignnum>=0' is not redundant
glhack-1.2/src/role.c:840:19: note: Array index out of bounds
glhack-1.2/src/role.c:850:24: warning: Either the condition 'gendnum>=0' is redundant or the array 'genders[3]' is accessed at index 3, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/src/role.c:849:18: note: Assuming that condition 'gendnum>=0' is not redundant
glhack-1.2/src/role.c:850:24: note: Array index out of bounds
glhack-1.2/src/role.c:853:23: warning: Either the condition 'alignnum>=0' is redundant or the array 'aligns[4]' is accessed at index 4, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/src/role.c:852:19: note: Assuming that condition 'alignnum>=0' is not redundant
glhack-1.2/src/role.c:853:23: note: Array index out of bounds
glhack-1.2/src/role.c:899:17: warning: Either the condition 'gendnum>=0' is redundant or the array 'genders[3]' is accessed at index 3, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/src/role.c:898:17: note: Assuming that condition 'gendnum>=0' is not redundant
glhack-1.2/src/role.c:899:17: note: Array index out of bounds
glhack-1.2/src/role.c:961:16: warning: Either the condition 'alignnum>=0' is redundant or the array 'aligns[4]' is accessed at index 4, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/src/role.c:960:18: note: Assuming that condition 'alignnum>=0' is not redundant
glhack-1.2/src/role.c:961:16: note: Array index out of bounds
glhack-1.2/src/role.c:1298:14: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/role.c:1303:18: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/role.c:1121:3: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch]
glhack-1.2/src/role.c:1125:5: note: Found duplicate branches for 'if' and 'else'.
glhack-1.2/src/role.c:1121:3: note: Found duplicate branches for 'if' and 'else'.
glhack-1.2/src/role.c:1219:13: style: Variable 'donefirst' is assigned a value that is never used. [unreadVariable]
glhack-1.2/src/rumors.c:122:15: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/rumors.c:274:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/rumors.c:48:6: warning: %lx in format string (no. 1) requires 'unsigned long *' but the argument type is 'signed long *'. [invalidScanfArgType_int]
glhack-1.2/src/rumors.c:198:10: warning: %lx in format string (no. 1) requires 'unsigned long *' but the argument type is 'signed long *'. [invalidScanfArgType_int]
glhack-1.2/src/sp_lev.c:776:25: warning: Either the condition 'm->align<=-11' is redundant or the array 'ralign[3]' is accessed at index 9, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/src/sp_lev.c:775:13: note: Assuming that condition 'm->align<=-11' is not redundant
glhack-1.2/src/sp_lev.c:776:25: note: Array index out of bounds
glhack-1.2/src/sp_lev.c:1817:24: error: Uninitialized variable: n [uninitvar]
glhack-1.2/src/sp_lev.c:1829:24: error: Uninitialized variable: nrooms [uninitvar]
glhack-1.2/src/sp_lev.c:2018:24: error: Uninitialized variable: ncorr [uninitvar]
glhack-1.2/src/sp_lev.c:2099:27: error: Uninitialized variable: filling [uninitvar]
glhack-1.2/src/sp_lev.c:2642:24: error: Uninitialized variable: vers_info [uninitvar]
glhack-1.2/src/sp_lev.c:2640:6: note: Assuming condition is false
glhack-1.2/src/sp_lev.c:2642:24: note: Uninitialized variable: vers_info
glhack-1.2/src/spell.c:564:7: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/spell.c:1013:28: style: Clarify calculation precedence for '+' and '?'. [clarifyCalculation]
glhack-1.2/src/spell.c:501:13: style: Parameter 'obj' can be declared as pointer to const [constParameter]
glhack-1.2/src/spell.c:511:13: style: Parameter 'old_obj' can be declared as pointer to const [constParameter]
glhack-1.2/src/teleport.c:1197:6: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/teleport.c:1199:8: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/teleport.c:902:26: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
glhack-1.2/src/topten.c:587:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/topten.c:718:34: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/topten.c:861:8: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/uhitm.c:913:6: error: syntax error [syntaxError]
glhack-1.2/src/version.c:166:14: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/version.c:112:37: error: Uninitialized variable: vers_info [uninitvar]
glhack-1.2/src/vision.c:2277:1: style: Label 'rside1' is not used. [unusedLabel]
glhack-1.2/src/vision.c:2328:1: style: Label 'rside2' is not used. [unusedLabel]
glhack-1.2/src/vision.c:2430:1: style: Label 'lside1' is not used. [unusedLabel]
glhack-1.2/src/vision.c:2459:1: style: Label 'lside2' is not used. [unusedLabel]
glhack-1.2/src/worm.c:518:28: error: Uninitialized variable: count [uninitvar]
glhack-1.2/src/worm.c:514:15: style: Variable 'count' is not assigned a value. [unassignedVariable]
glhack-1.2/src/worn.c:323:30: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
glhack-1.2/src/worn.c:506:27: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
glhack-1.2/src/worn.c:483:6: style: The if condition is the same as the previous if condition [duplicateCondition]
glhack-1.2/src/worn.c:480:6: note: First condition
glhack-1.2/src/worn.c:483:6: note: Second condition
glhack-1.2/sys/amiga/amidos.c:488:17: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/amiga/windefs.h:56:26: error: syntax error [syntaxError]
glhack-1.2/sys/amiga/amisnd.c:147:2: warning:inconclusive: The buffer 'name' may not be null-terminated after the call to strncpy(). [terminateStrncpy]
glhack-1.2/sys/amiga/amisnd.c:40:7: style: struct member 'VHDR::name' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/amisnd.c:41:7: style: struct member 'VHDR::len' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/amisnd.c:42:16: style: struct member 'VHDR::oneshot' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/amisnd.c:42:25: style: struct member 'VHDR::repeat' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/amisnd.c:42:33: style: struct member 'VHDR::samples' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/amisnd.c:50:7: style: struct member 'IFFHEAD::FORM' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/amisnd.c:51:7: style: struct member 'IFFHEAD::flen' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/amisnd.c:52:7: style: struct member 'IFFHEAD::_8SVX' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/amisnd.c:54:7: style: struct member 'IFFHEAD::NAME' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/amiwind.c:948:1: error: Unmatched '}'. Configuration: '__GNUC__=1'. [syntaxError]
glhack-1.2/sys/amiga/cvtsnd.c:12:10: style: struct member 'AIFF::misc' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/cvtsnd.c:13:10: style: struct member 'AIFF::FORM' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/cvtsnd.c:14:10: style: struct member 'AIFF::flen' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/cvtsnd.c:15:10: style: struct member 'AIFF::AIFF' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/cvtsnd.c:16:10: style: struct member 'AIFF::SSND' is never used. [unusedStructMember]
glhack-1.2/sys/amiga/txt2iff.c:384:5: style: Variable 'tmpmap' can be declared as const array [constVariable]
glhack-1.2/sys/amiga/txt2iff.c:438:9: error: Uninitialized variable: bestslot [uninitvar]
glhack-1.2/sys/amiga/txt2iff.c:430:15: note: Assuming condition is false
glhack-1.2/sys/amiga/txt2iff.c:438:9: note: Uninitialized variable: bestslot
glhack-1.2/sys/amiga/winchar.c:838:10: style: Local variable 'apen' shadows outer variable [shadowVariable]
glhack-1.2/sys/amiga/winchar.c:788:27: note: Shadowed declaration
glhack-1.2/sys/amiga/winchar.c:838:10: note: Shadow variable
glhack-1.2/sys/amiga/winchar.c:218:9: error: Uninitialized variable: bmhds [uninitvar]
glhack-1.2/sys/amiga/winkey.c:32:8: style: Variable 'rp' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/amiga/winfuncs.c:393:17: style: Local variable 'w' shadows outer variable [shadowVariable]
glhack-1.2/sys/amiga/winfuncs.c:320:29: note: Shadowed declaration
glhack-1.2/sys/amiga/winfuncs.c:393:17: note: Shadow variable
glhack-1.2/sys/amiga/winfuncs.c:196:10: style: Variable 'type' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/amiga/winfuncs.c:897:20: style: Unused variable: wbscr [unusedVariable]
glhack-1.2/sys/amiga/winfuncs.c:1570:6: style: Variable 'cnt' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/amiga/winmenu.c:907:23: style: Expression is always true because 'else if' condition is opposite to previous condition at line 898. [multiCondition]
glhack-1.2/sys/amiga/winmenu.c:898:25: note: first condition
glhack-1.2/sys/amiga/winmenu.c:907:23: note: else if condition is opposite to first condition
glhack-1.2/sys/amiga/winmenu.c:813:21: style: Redundant condition: !counting. 'counting || (!counting && code!='0')' is equivalent to 'counting || code!='0'' [redundantCondition]
glhack-1.2/sys/amiga/winmenu.c:824:8: warning: %d in format string (no. 1) requires 'int' but the argument type is 'signed long'. [invalidPrintfArgType_sint]
glhack-1.2/sys/amiga/winmenu.c:1551:13: style: Variable 'whichcolor' is reassigned a value before the old one has been used. [redundantAssignment]
glhack-1.2/sys/amiga/winmenu.c:1464:14: note: whichcolor is assigned
glhack-1.2/sys/amiga/winmenu.c:1551:13: note: whichcolor is overwritten
glhack-1.2/sys/amiga/winmenu.c:1551:13: style: Variable 'whichcolor' is reassigned a value before the old one has been used. [redundantAssignment]
glhack-1.2/sys/amiga/winmenu.c:1485:17: note: whichcolor is assigned
glhack-1.2/sys/amiga/winmenu.c:1551:13: note: whichcolor is overwritten
glhack-1.2/sys/amiga/winmenu.c:1310:9: style: Variable 'mip' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/amiga/winreq.c:213:11: style: Local variable 'once' shadows outer variable [shadowVariable]
glhack-1.2/sys/amiga/winreq.c:74:16: note: Shadowed declaration
glhack-1.2/sys/amiga/winreq.c:213:11: note: Shadow variable
glhack-1.2/sys/amiga/winreq.c:387:16: style: Variable 'sizes' can be declared as const array [constVariable]
glhack-1.2/sys/amiga/winreq.c:619:4: style: Variable 't' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/amiga/winreq.c:738:10: style: Variable 'incy' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/amiga/winreq.c:770:10: style: Variable 'incy' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/amiga/winreq.c:772:12: style: Variable 'bxxlen' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/amiga/winreq.c:773:12: style: Variable 'bxxlen' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/amiga/winreq.c:774:12: style: Variable 'bxxlen' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/amiga/winstr.c:129:10: style: Local variable 'i' shadows outer variable [shadowVariable]
glhack-1.2/sys/amiga/winstr.c:22:9: note: Shadowed declaration
glhack-1.2/sys/amiga/winstr.c:129:10: note: Shadow variable
glhack-1.2/sys/amiga/winstr.c:184:6: style: Variable 'len' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/amiga/winstr.c:496:8: style: Variable 'i' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/amiga/xpm2iff.c:321:11: warning: %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int]
glhack-1.2/sys/amiga/xpm2iff.c:321:11: warning: %x in format string (no. 3) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int]
glhack-1.2/sys/amiga/xpm2iff.c:321:11: warning: %x in format string (no. 4) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int]
glhack-1.2/sys/amiga/xpm2iff.c:109:14: style: Variable 'tiles' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/amiga/xpm2iff.c:105:12: style: Unused variable: cnt [unusedVariable]
glhack-1.2/sys/mac/macerrs.c:25:19: error: Uninitialized variable: buf [uninitvar]
glhack-1.2/sys/mac/macfile.c:412:14: warning: Either the condition 'size<0' is redundant or there is division by zero at line 412. [zerodivcond]
glhack-1.2/sys/mac/macfile.c:409:11: note: Assuming that condition 'size<0' is not redundant
glhack-1.2/sys/mac/macfile.c:412:14: note: Division by zero
glhack-1.2/sys/mac/macfile.c:229:12: style: Local variable 'name' shadows outer argument [shadowArgument]
glhack-1.2/sys/mac/macfile.c:210:22: note: Shadowed declaration
glhack-1.2/sys/mac/macfile.c:229:12: note: Shadow variable
glhack-1.2/sys/mac/macfile.c:216:13: error: Uninitialized variable: s [uninitvar]
glhack-1.2/sys/mac/macfile.c:232:17: error: Uninitialized variable: plnamep [uninitvar]
glhack-1.2/sys/mac/macfile.c:376:12: error: Uninitialized variable: pname [uninitvar]
glhack-1.2/sys/mac/macfile.c:397:12: error: Uninitialized variable: pname [uninitvar]
glhack-1.2/sys/mac/macsnd.c:64:8: style: Variable 'midi_note' can be declared as const array [constVariable]
glhack-1.2/sys/mac/macmenu.c:48:9: style: union member 'menuRefUnn::mresID' is never used. [unusedStructMember]
glhack-1.2/sys/mac/mactty.c:845:59: warning: Shifting 32-bit value by 63 bits is undefined behaviour. See condition at line 845. [shiftTooManyBits]
glhack-1.2/sys/mac/mactty.c:845:19: note: Assuming that condition 'ch<sizeof(long)*8' is not redundant
glhack-1.2/sys/mac/mactty.c:845:59: note: Shift
glhack-1.2/sys/mac/mactty.c:883:61: warning: Shifting 32-bit value by 63 bits is undefined behaviour. See condition at line 883. [shiftTooManyBits]
glhack-1.2/sys/mac/mactty.c:883:21: note: Assuming that condition 'ch<sizeof(long)*8' is not redundant
glhack-1.2/sys/mac/mactty.c:883:61: note: Shift
glhack-1.2/sys/mac/mactty.c:986:8: style: Variable 's_err' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/mac/macwin.c:1000:18: error: Using pointer to local variable 'any_str' that is out of scope. [invalidLifetime]
glhack-1.2/sys/mac/macwin.c:995:19: note: Array decayed to pointer here.
glhack-1.2/sys/mac/macwin.c:994:14: note: Variable created here.
glhack-1.2/sys/mac/macwin.c:1000:18: note: Using pointer to local variable 'any_str' that is out of scope.
glhack-1.2/sys/mac/macwin.c:1008:20: error: Using pointer to local variable 'any_str' that is out of scope. [invalidLifetime]
glhack-1.2/sys/mac/macwin.c:995:19: note: Array decayed to pointer here.
glhack-1.2/sys/mac/macwin.c:994:14: note: Variable created here.
glhack-1.2/sys/mac/macwin.c:1008:20: note: Using pointer to local variable 'any_str' that is out of scope.
glhack-1.2/sys/mac/macwin.c:1009:16: error: Using pointer to local variable 'any_str' that is out of scope. [invalidLifetime]
glhack-1.2/sys/mac/macwin.c:995:19: note: Array decayed to pointer here.
glhack-1.2/sys/mac/macwin.c:994:14: note: Variable created here.
glhack-1.2/sys/mac/macwin.c:1009:16: note: Using pointer to local variable 'any_str' that is out of scope.
glhack-1.2/sys/mac/macwin.c:1010:29: error: Using pointer to local variable 'any_str' that is out of scope. [invalidLifetime]
glhack-1.2/sys/mac/macwin.c:995:19: note: Array decayed to pointer here.
glhack-1.2/sys/mac/macwin.c:994:14: note: Variable created here.
glhack-1.2/sys/mac/macwin.c:1010:29: note: Using pointer to local variable 'any_str' that is out of scope.
glhack-1.2/sys/mac/macwin.c:1944:25: style:inconclusive: Boolean expression '0xff=='.'' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean]
glhack-1.2/sys/mac/macwin.c:1944:25: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
glhack-1.2/sys/mac/macwin.c:1944:25: style: Condition 'theEvent->message&0xff=='.'' is always false [knownConditionTrueFalse]
glhack-1.2/sys/mac/macwin.c:1695:32: style: Parameter 'theEvent' can be declared as pointer to const [constParameter]
glhack-1.2/sys/mac/macwin.c:1840:29: style: Parameter 'theEvent' can be declared as pointer to const [constParameter]
glhack-1.2/sys/mac/macwin.c:1911:30: error: Uninitialized variable: dir_bas [uninitvar]
glhack-1.2/sys/mac/macwin.c:1901:6: note: Assuming condition is true
glhack-1.2/sys/mac/macwin.c:1911:30: note: Uninitialized variable: dir_bas
glhack-1.2/sys/mac/macwin.c:1405:21: style: Variable 'currentRow' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/mac/mrecover.c:1289:22: error: Uninitialized variable: saveTemp [uninitvar]
glhack-1.2/sys/mac/mrecover.c:1286:9: note: Assuming condition is false
glhack-1.2/sys/mac/mrecover.c:1289:22: note: Uninitialized variable: saveTemp
glhack-1.2/sys/mac/mrecover.c:1300:16: error: Uninitialized variable: version_data [uninitvar]
glhack-1.2/sys/mac/mrecover.c:1289:18: note: Assuming condition is false
glhack-1.2/sys/mac/mrecover.c:1300:16: note: Uninitialized variable: version_data
glhack-1.2/sys/mac/mrecover.c:75:8: style: struct member 'memBytes::memReserved' is never used. [unusedStructMember]
glhack-1.2/sys/mac/mrecover.c:190:10: style: struct member 'versXRec::placeCode' is never used. [unusedStructMember]
glhack-1.2/sys/mac/mrecover.c:191:16: style: struct member 'versXRec::versStr' is never used. [unusedStructMember]
glhack-1.2/sys/mac/mttymain.c:364:6: style: Variable 'err' is reassigned a value before the old one has been used. [redundantAssignment]
glhack-1.2/sys/mac/mttymain.c:363:6: note: err is assigned
glhack-1.2/sys/mac/mttymain.c:364:6: note: err is overwritten
glhack-1.2/sys/mac/mttymain.c:452:6: style: Variable 'err' is reassigned a value before the old one has been used. [redundantAssignment]
glhack-1.2/sys/mac/mttymain.c:451:6: note: err is assigned
glhack-1.2/sys/mac/mttymain.c:452:6: note: err is overwritten
glhack-1.2/sys/mac/mttymain.c:364:6: style: Variable 'err' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/mac/mttymain.c:452:6: style: Variable 'err' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/msdos/tile2bin.c:123:12: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled]
glhack-1.2/sys/msdos/tile2bin.c:173:31: style: Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. [prohibitedasctimeCalled]
glhack-1.2/sys/msdos/tile2bin.c:280:7: style: Unused variable: fpos [unusedVariable]
glhack-1.2/src/options.c:458:22: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:459:15: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:654:21: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:658:21: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:665:20: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:668:15: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:671:11: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:743:10: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:744:11: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:795:10: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:806:4: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:815:7: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:994:12: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:1711:9: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:1792:10: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:1805:15: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:2326:19: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:3536:7: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/src/options.c:3426:13: style: Variable 'c' is reassigned a value before the old one has been used. [redundantAssignment]
glhack-1.2/src/options.c:3424:9: note: c is assigned
glhack-1.2/src/options.c:3426:13: note: c is overwritten
glhack-1.2/src/options.c:3858:25: style: Local variable 'fgp' shadows outer variable [shadowVariable]
glhack-1.2/src/options.c:3804:16: note: Shadowed declaration
glhack-1.2/src/options.c:3858:25: note: Shadow variable
glhack-1.2/src/options.c:3863:25: style: Local variable 'bgp' shadows outer variable [shadowVariable]
glhack-1.2/src/options.c:3810:16: note: Shadowed declaration
glhack-1.2/src/options.c:3863:25: note: Shadow variable
glhack-1.2/src/options.c:206:6: style: struct member 'Comp_Opt::size' is never used. [unusedStructMember]
glhack-1.2/src/options.c:1552:16: style: Variable 'op' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/share/dgn_lex.c:1048:3: style: Redundant initialization for 'c'. The initialized value is overwritten before it is read. [redundantInitialization]
glhack-1.2/sys/share/dgn_lex.c:1048:3: note: c is initialized
glhack-1.2/sys/share/dgn_lex.c:1048:3: note: c is overwritten
glhack-1.2/sys/share/dgn_yacc.c:716:16: warning: Either the condition 'yyn<=363' is redundant or the array 'yylen[49]' is accessed at index 364, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/sys/share/dgn_yacc.c:1032:17: note: Assuming that condition 'yyn<=363' is not redundant
glhack-1.2/sys/share/dgn_yacc.c:716:16: note: Array index out of bounds
glhack-1.2/sys/share/dgn_yacc.c:1003:16: warning: Either the condition 'yyn<=363' is redundant or the array 'yylhs[49]' is accessed at index 364, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/sys/share/dgn_yacc.c:1032:17: note: Assuming that condition 'yyn<=363' is not redundant
glhack-1.2/sys/share/dgn_yacc.c:1003:16: note: Array index out of bounds
glhack-1.2/sys/share/dgn_yacc.c:652:1: style: Label 'yynewerror' is not used. [unusedLabel]
glhack-1.2/sys/share/dgn_yacc.c:657:1: style: Label 'yyerrlab' is not used. [unusedLabel]
glhack-1.2/sys/share/lev_lex.c:1654:3: style: Redundant initialization for 'c'. The initialized value is overwritten before it is read. [redundantInitialization]
glhack-1.2/sys/share/lev_lex.c:1654:3: note: c is initialized
glhack-1.2/sys/share/lev_lex.c:1654:3: note: c is overwritten
glhack-1.2/sys/share/lev_yacc.c:1043:16: warning: Either the condition 'yyn<=900' is redundant or the array 'yylen[223]' is accessed at index 901, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/sys/share/lev_yacc.c:2396:17: note: Assuming that condition 'yyn<=900' is not redundant
glhack-1.2/sys/share/lev_yacc.c:1043:16: note: Array index out of bounds
glhack-1.2/sys/share/lev_yacc.c:2367:16: warning: Either the condition 'yyn<=900' is redundant or the array 'yylhs[223]' is accessed at index 901, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/sys/share/lev_yacc.c:2396:17: note: Assuming that condition 'yyn<=900' is not redundant
glhack-1.2/sys/share/lev_yacc.c:2367:16: note: Array index out of bounds
glhack-1.2/sys/share/pcsys.c:424:1: error: Unmatched '}'. Configuration: '__GNUC__=1'. [syntaxError]
glhack-1.2/sys/share/pctty.c:83:1: error: Unmatched '}'. Configuration: '__GNUC__=1'. [syntaxError]
glhack-1.2/sys/share/lev_yacc.c:1111:8: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/share/lev_yacc.c:1422:8: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/share/lev_yacc.c:979:1: style: Label 'yynewerror' is not used. [unusedLabel]
glhack-1.2/sys/share/lev_yacc.c:984:1: style: Label 'yyerrlab' is not used. [unusedLabel]
glhack-1.2/sys/share/random.c:221:42: warning: Return value of function random() is not used. [ignoredReturnValue]
glhack-1.2/sys/share/unixtty.c:449:1: error: Unmatched '}'. Configuration: '__GNUC__=1'. [syntaxError]
glhack-1.2/sys/share/tclib.c:106:50: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/share/tclib.c:109:17: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/share/tclib.c:175:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/share/tclib.c:202:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/share/tclib.c:205:13: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/share/tclib.c:255:14: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/share/tclib.c:303:11: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/share/tclib.c:312:15: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/share/tclib.c:370:15: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/share/tclib.c:81:6: error: Resource leak: fp [resourceLeak]
glhack-1.2/sys/share/tclib.c:82:2: error: Resource leak: fp [resourceLeak]
glhack-1.2/sys/share/uudecode.c:124:18: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData]
glhack-1.2/sys/share/uudecode.c:126:21: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData]
glhack-1.2/sys/share/uudecode.c:134:10: portability: Non reentrant function 'getpwnam' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwnam_r'. [prohibitedgetpwnamCalled]
glhack-1.2/sys/share/uudecode.c:118:8: warning: %o in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int]
glhack-1.2/sys/share/uudecode.c:118:8: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
glhack-1.2/sys/share/uudecode.c:214:7: style: Parameter 'p' can be declared as pointer to const [constParameter]
glhack-1.2/sys/share/uudecode.c:100:7: style: Variable 'argv' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/unix/unixmain.c:490:22: portability: Non reentrant function 'getlogin' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getlogin_r'. [prohibitedgetloginCalled]
glhack-1.2/sys/unix/unixunix.c:198:12: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/unix/unixunix.c:50:30: error: Uninitialized variable: lockedpid [uninitvar]
glhack-1.2/sys/vms/vmsfiles.c:120:9: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/vms/vmsfiles.c:175:15: style: Variable 'n1.nam$b_nop' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/vms/vmsfiles.c:175:30: style: Variable 'n2.nam$b_nop' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/vms/vmstty.c:491:1: error: Unmatched '}'. Configuration: '__GNUC__=1'. [syntaxError]
glhack-1.2/sys/vms/vmsunix.c:196:27: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData]
glhack-1.2/sys/vms/vmsunix.c:296:9: style: Condition '!tc' is always true [knownConditionTrueFalse]
glhack-1.2/sys/vms/vmsunix.c:295:9: note: Assuming that condition 'tc' is not redundant
glhack-1.2/sys/vms/vmsunix.c:296:9: note: Condition '!tc' is always true
glhack-1.2/sys/vms/vmsunix.c:54:31: error: Uninitialized variable: lockedpid [uninitvar]
glhack-1.2/sys/vms/vmsunix.c:193:33: style: struct member 'itm3::itmcode' is never used. [unusedStructMember]
glhack-1.2/sys/vms/vmsunix.c:193:69: style: struct member 'itm3::retlen' is never used. [unusedStructMember]
glhack-1.2/sys/wince/mhcolor.c:188:15: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/wince/mhcolor.c:190:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/wince/mhcolor.c:192:17: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/wince/mhcolor.c:194:18: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/wince/mhcolor.c:196:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/wince/mhcolor.c:198:17: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/wince/mhcmd.c:1030:56: style:inconclusive: Function 'CalculateCellSize' argument 3 names different: declaration 'windowSize' definition 'pWindowSize'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhcmd.c:109:63: note: Function 'CalculateCellSize' argument 3 names different: declaration 'windowSize' definition 'pWindowSize'.
glhack-1.2/sys/wince/mhcmd.c:1030:56: note: Function 'CalculateCellSize' argument 3 names different: declaration 'windowSize' definition 'pWindowSize'.
glhack-1.2/sys/wince/mhcmd.c:984:7: style: Local variable 'i' shadows outer variable [shadowVariable]
glhack-1.2/sys/wince/mhcmd.c:906:6: note: Shadowed declaration
glhack-1.2/sys/wince/mhcmd.c:984:7: note: Shadow variable
glhack-1.2/sys/wince/mhcmd.c:611:52: error: Uninitialized variable: bm [uninitvar]
glhack-1.2/sys/wince/mhdlg.c:553:39: style:inconclusive: Function 'plselAdjustLists' argument 2 names different: declaration 'changed_opt' definition 'changed_sel'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhdlg.c:307:47: note: Function 'plselAdjustLists' argument 2 names different: declaration 'changed_opt' definition 'changed_sel'.
glhack-1.2/sys/wince/mhdlg.c:553:39: note: Function 'plselAdjustLists' argument 2 names different: declaration 'changed_opt' definition 'changed_sel'.
glhack-1.2/sys/wince/mhdlg.c:143:9: style: Local variable 'wbuf' shadows outer variable [shadowVariable]
glhack-1.2/sys/wince/mhdlg.c:58:9: note: Shadowed declaration
glhack-1.2/sys/wince/mhdlg.c:143:9: note: Shadow variable
glhack-1.2/sys/wince/mhdlg.c:217:8: style: Variable 'data' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/wince/mhdlg.c:341:8: style: Variable 'data' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/wince/mhdlg.c:692:14: style: Variable 'initalign' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/wince/mhmain.c:1008:32: style:inconclusive: Function 'mswin_select_map_mode' argument 1 names different: declaration 'map_mode' definition 'mode'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhmain.h:14:32: note: Function 'mswin_select_map_mode' argument 1 names different: declaration 'map_mode' definition 'mode'.
glhack-1.2/sys/wince/mhmain.c:1008:32: note: Function 'mswin_select_map_mode' argument 1 names different: declaration 'map_mode' definition 'mode'.
glhack-1.2/sys/wince/mhmap.c:822:30: style:inconclusive: Function 'nhglyph2charcolor' argument 1 names different: declaration 'glyph' definition 'g'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhmap.c:43:37: note: Function 'nhglyph2charcolor' argument 1 names different: declaration 'glyph' definition 'g'.
glhack-1.2/sys/wince/mhmap.c:822:30: note: Function 'nhglyph2charcolor' argument 1 names different: declaration 'glyph' definition 'g'.
glhack-1.2/sys/wince/mhmap.c:477:10: style: Local variable 'rt' shadows outer variable [shadowVariable]
glhack-1.2/sys/wince/mhmap.c:404:7: note: Shadowed declaration
glhack-1.2/sys/wince/mhmap.c:477:10: note: Shadow variable
glhack-1.2/sys/wince/mhmap.c:571:14: style: Unused variable: special [unusedVariable]
glhack-1.2/sys/wince/mhmap.c:572:9: style: Unused variable: mgch [unusedVariable]
glhack-1.2/sys/wince/mhmap.c:573:12: style: Unused variable: back_brush [unusedVariable]
glhack-1.2/sys/wince/mhmap.c:862:21: style: Variable 'offset' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/wince/mhrip.c:13:37: style:inconclusive: Function 'mswin_display_RIP_window' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhrip.h:12:37: note: Function 'mswin_display_RIP_window' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhrip.c:13:37: note: Function 'mswin_display_RIP_window' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhmenu.c:985:45: warning: Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition]
glhack-1.2/sys/wince/mhmenu.c:983:41: note: outer condition: data->menu.items[lpdis->itemID].count>0
glhack-1.2/sys/wince/mhmenu.c:985:45: note: opposite inner condition: data->menu.items[lpdis->itemID].count==-1
glhack-1.2/sys/wince/mhmenu.c:102:41: style:inconclusive: Function 'mswin_menu_window_select_menu' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhmenu.h:14:41: note: Function 'mswin_menu_window_select_menu' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhmenu.c:102:41: note: Function 'mswin_menu_window_select_menu' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhmenu.c:629:22: style:inconclusive: Function 'LayoutMenu' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhmenu.c:75:29: note: Function 'LayoutMenu' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhmenu.c:629:22: note: Function 'LayoutMenu' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhmenu.c:685:23: style:inconclusive: Function 'SetMenuType' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhmenu.c:76:30: note: Function 'SetMenuType' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhmenu.c:685:23: note: Function 'SetMenuType' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhmenu.c:712:27: style:inconclusive: Function 'SetMenuListType' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhmenu.c:77:34: note: Function 'SetMenuListType' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhmenu.c:712:27: note: Function 'SetMenuListType' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhmenu.c:712:37: style:inconclusive: Function 'SetMenuListType' argument 2 names different: declaration 'now' definition 'how'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhmenu.c:77:44: note: Function 'SetMenuListType' argument 2 names different: declaration 'now' definition 'how'.
glhack-1.2/sys/wince/mhmenu.c:712:37: note: Function 'SetMenuListType' argument 2 names different: declaration 'now' definition 'how'.
glhack-1.2/sys/wince/mhmenu.c:810:26: style:inconclusive: Function 'GetMenuControl' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhmenu.c:78:33: note: Function 'GetMenuControl' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhmenu.c:810:26: note: Function 'GetMenuControl' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhmenu.c:1317:35: style:inconclusive: Function 'mswin_menu_window_size' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhmenu.h:15:35: note: Function 'mswin_menu_window_size' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhmenu.c:1317:35: note: Function 'mswin_menu_window_size' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhmenu.c:948:10: style: Local variable 'wbuf' shadows outer variable [shadowVariable]
glhack-1.2/sys/wince/mhmenu.c:861:8: note: Shadowed declaration
glhack-1.2/sys/wince/mhmenu.c:948:10: note: Shadow variable
glhack-1.2/sys/wince/mhmenu.c:966:9: style: Local variable 'wbuf' shadows outer variable [shadowVariable]
glhack-1.2/sys/wince/mhmenu.c:861:8: note: Shadowed declaration
glhack-1.2/sys/wince/mhmenu.c:966:9: note: Shadow variable
glhack-1.2/sys/wince/mhmenu.c:654:11: style: Variable 'pt_ok.x' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/wince/mhmenu.c:656:12: style: Variable 'sz_ok.cx' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/wince/mhmenu.c:656:23: style: Variable 'sz_ok.cy' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/wince/mhmenu.c:667:15: style: Variable 'pt_cancel.x' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/wince/mhmenu.c:669:16: style: Variable 'sz_cancel.cx' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/wince/mhmenu.c:669:31: style: Variable 'sz_cancel.cy' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/wince/mhmenu.c:801:9: style: Variable 'nItem' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/wince/mhmenu.c:834:7: style: Variable 'data' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/wince/mhtext.c:46:38: style:inconclusive: Function 'mswin_display_text_window' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhtext.h:12:38: note: Function 'mswin_display_text_window' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhtext.c:46:38: note: Function 'mswin_display_text_window' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhtext.c:160:22: style:inconclusive: Function 'LayoutText' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/mhtext.c:21:29: note: Function 'LayoutText' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/mhtext.c:160:22: note: Function 'LayoutText' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/sys/wince/winhack.c:288:1: error: Unmatched '}'. Configuration: '__GNUC__=1'. [syntaxError]
glhack-1.2/sys/wince/mswproc.c:875:32: warning: Either the condition 'wid!=-1' is redundant or the array 'GetNHApp()->windowlist[15]' is accessed at index -1, which is out of bounds. [negativeIndex]
glhack-1.2/sys/wince/mswproc.c:882:13: note: Assuming that condition 'wid!=-1' is not redundant
glhack-1.2/sys/wince/mswproc.c:875:32: note: Negative array index
glhack-1.2/sys/wince/winmain.c:66:17: style: Variable 'bQuoted' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/wince/mswproc.c:339:7: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/wince/mswproc.c:340:15: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/wince/mswproc.c:1378:13: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/wince/mswproc.c:1385:17: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/wince/mswproc.c:1386:6: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/wince/mswproc.c:1426:25: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/sys/wince/mswproc.c:944:69: style:inconclusive: Function 'mswin_putstr_ex' argument 4 names different: declaration 'append' definition 'app'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/winMS.h:127:69: note: Function 'mswin_putstr_ex' argument 4 names different: declaration 'append' definition 'app'.
glhack-1.2/sys/wince/mswproc.c:944:69: note: Function 'mswin_putstr_ex' argument 4 names different: declaration 'append' definition 'app'.
glhack-1.2/sys/wince/mswproc.c:1774:31: style:inconclusive: Function 'mswin_popup_display' argument 1 names different: declaration 'popup' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/winMS.h:170:31: note: Function 'mswin_popup_display' argument 1 names different: declaration 'popup' definition 'hWnd'.
glhack-1.2/sys/wince/mswproc.c:1774:31: note: Function 'mswin_popup_display' argument 1 names different: declaration 'popup' definition 'hWnd'.
glhack-1.2/sys/wince/mswproc.c:1814:31: style:inconclusive: Function 'mswin_popup_destroy' argument 1 names different: declaration 'popup' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/sys/wince/winMS.h:171:31: note: Function 'mswin_popup_destroy' argument 1 names different: declaration 'popup' definition 'hWnd'.
glhack-1.2/sys/wince/mswproc.c:1814:31: note: Function 'mswin_popup_destroy' argument 1 names different: declaration 'popup' definition 'hWnd'.
glhack-1.2/sys/wince/mswproc.c:1440:14: error: Uninitialized variable: ch [uninitvar]
glhack-1.2/sys/wince/mswproc.c:1422:18: note: Assuming condition is false
glhack-1.2/sys/wince/mswproc.c:1440:14: note: Uninitialized variable: ch
glhack-1.2/sys/winnt/nh340key.c:102:16: style: Variable 'metaflags' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/winnt/nh340key.c:102:23: style: Variable 'k' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/winnt/nh340key.c:104:31: style: Variable 'mk' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/winnt/nh340key.c:111:14: style: Variable 'pre_ch' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/winnt/nhdefkey.c:110:23: style: Variable 'k' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/winnt/nhdefkey.c:110:6: style: Variable 'metaflags' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/winnt/nhdefkey.c:112:28: style: Variable 'mk' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/winnt/nhraykey.c:289:16: style: Variable 'metaflags' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/winnt/nhraykey.c:289:23: style: Variable 'k' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/winnt/nhraykey.c:291:31: style: Variable 'mk' is assigned a value that is never used. [unreadVariable]
glhack-1.2/sys/winnt/nhraykey.c:299:14: style: Variable 'pre_ch' is assigned a value that is never used. [unreadVariable]
glhack-1.2/tools/edtile/z_file.h:38:3: style: Struct 'Filename' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
glhack-1.2/tools/edtile/z_file.h:39:3: style: Struct 'Filename' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
glhack-1.2/tools/edtile/z_file.h:76:43: style:inconclusive: Function 'Filename' argument 1 names different: declaration 'fname' definition 'src'. [funcArgNamesDifferent]
glhack-1.2/tools/edtile/z_file.h:41:28: note: Function 'Filename' argument 1 names different: declaration 'fname' definition 'src'.
glhack-1.2/tools/edtile/z_file.h:76:43: note: Function 'Filename' argument 1 names different: declaration 'fname' definition 'src'.
glhack-1.2/tools/edtile/z_file.h:79:55: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'fname' definition 'src'. [funcArgNamesDifferent]
glhack-1.2/tools/edtile/z_file.h:42:40: note: Function 'operator=' argument 1 names different: declaration 'fname' definition 'src'.
glhack-1.2/tools/edtile/z_file.h:79:55: note: Function 'operator=' argument 1 names different: declaration 'fname' definition 'src'.
glhack-1.2/tools/edtile/z_rgb.h:43:3: style: Struct 'PackCol' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
glhack-1.2/tools/edtile/z_hsv.h:43:3: style: Struct 'HsvCol' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
glhack-1.2/tools/edtile/z_rgb.h:107:39: style:inconclusive: Function 'ClampSet' argument 1 names different: declaration 'r' definition '_r'. [funcArgNamesDifferent]
glhack-1.2/tools/edtile/z_rgb.h:57:25: note: Function 'ClampSet' argument 1 names different: declaration 'r' definition '_r'.
glhack-1.2/tools/edtile/z_rgb.h:107:39: note: Function 'ClampSet' argument 1 names different: declaration 'r' definition '_r'.
glhack-1.2/tools/edtile/z_rgb.h:107:47: style:inconclusive: Function 'ClampSet' argument 2 names different: declaration 'g' definition '_g'. [funcArgNamesDifferent]
glhack-1.2/tools/edtile/z_rgb.h:57:32: note: Function 'ClampSet' argument 2 names different: declaration 'g' definition '_g'.
glhack-1.2/tools/edtile/z_rgb.h:107:47: note: Function 'ClampSet' argument 2 names different: declaration 'g' definition '_g'.
glhack-1.2/tools/edtile/z_rgb.h:107:55: style:inconclusive: Function 'ClampSet' argument 3 names different: declaration 'b' definition '_b'. [funcArgNamesDifferent]
glhack-1.2/tools/edtile/z_rgb.h:57:39: note: Function 'ClampSet' argument 3 names different: declaration 'b' definition '_b'.
glhack-1.2/tools/edtile/z_rgb.h:107:55: note: Function 'ClampSet' argument 3 names different: declaration 'b' definition '_b'.
glhack-1.2/tools/edtile/z_rgb.h:107:63: style:inconclusive: Function 'ClampSet' argument 4 names different: declaration 'a' definition '_a'. [funcArgNamesDifferent]
glhack-1.2/tools/edtile/z_rgb.h:57:46: note: Function 'ClampSet' argument 4 names different: declaration 'a' definition '_a'.
glhack-1.2/tools/edtile/z_rgb.h:107:63: note: Function 'ClampSet' argument 4 names different: declaration 'a' definition '_a'.
glhack-1.2/tools/edtile/create_md2.c:404:31: warning: Either the condition 'i<str_size' is redundant or the array 'str[5]' is accessed at index 8, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/tools/edtile/create_md2.c:442:13: note: Calling function 'AddString', 1st argument '"tris0.ppm"' value is "tris0.ppm"
glhack-1.2/tools/edtile/create_md2.c:400:24: note: Assignment 'str_size=strlen(str)', assigned value is 9
glhack-1.2/tools/edtile/create_md2.c:404:15: note: Assuming that condition 'i<str_size' is not redundant
glhack-1.2/tools/edtile/create_md2.c:404:31: note: Array index out of bounds
glhack-1.2/tools/edtile/create_md2.c:230:48: style: Parameter 'vert_list' can be declared as pointer to const [constParameter]
glhack-1.2/tools/edtile/create_md2.c:258:46: style: Parameter 'vert_list' can be declared as pointer to const [constParameter]
glhack-1.2/tools/edtile/t_colmap.h:160:16: warning: Either the condition 'pix!=((unsigned short)0x7FFF)' is redundant or the array 'm_arr[4096]' is accessed at index 32767, which is out of bounds. [arrayIndexOutOfBoundsCond]
glhack-1.2/tools/edtile/t_colmap.h:158:3: note: Assuming that condition 'pix!=((unsigned short)0x7FFF)' is not redundant
glhack-1.2/tools/edtile/t_colmap.h:160:16: note: Array index out of bounds
glhack-1.2/tools/edtile/t_colmap.h:58:5: style: Class 'ColorMapping' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
glhack-1.2/tools/edtile/t_hue.h:36:3: style: Struct 'HueSet' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
glhack-1.2/tools/edtile/w_browse.h:75:17: style: The function 'Name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
glhack-1.2/tools/edtile/w_tab.h:36:25: note: Virtual function in base class
glhack-1.2/tools/edtile/w_browse.h:75:17: note: Function in derived class
glhack-1.2/tools/edtile/w_browse.h:95:9: style: The function 'handle_key' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
glhack-1.2/tools/edtile/w_tab.h:40:17: note: Virtual function in base class
glhack-1.2/tools/edtile/w_browse.h:95:9: note: Function in derived class
glhack-1.2/tools/edtile/w_compact.h:92:17: style: The function 'Name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
glhack-1.2/tools/edtile/w_tab.h:36:25: note: Virtual function in base class
glhack-1.2/tools/edtile/w_compact.h:92:17: note: Function in derived class
glhack-1.2/tools/edtile/w_compact.h:107:9: style: The function 'handle_key' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
glhack-1.2/tools/edtile/w_tab.h:40:17: note: Virtual function in base class
glhack-1.2/tools/edtile/w_compact.h:107:9: note: Function in derived class
glhack-1.2/tools/edtile/w_edit.h:69:17: style: The function 'Name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
glhack-1.2/tools/edtile/w_tab.h:36:25: note: Virtual function in base class
glhack-1.2/tools/edtile/w_edit.h:69:17: note: Function in derived class
glhack-1.2/tools/edtile/w_shades.h:69:17: style: The function 'Name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
glhack-1.2/tools/edtile/w_tab.h:36:25: note: Virtual function in base class
glhack-1.2/tools/edtile/w_shades.h:69:17: note: Function in derived class
glhack-1.2/tools/edtile/w_browse.h:80:7: warning: Either the condition '!t_brow' is redundant or there is possible null pointer dereference: t_brow. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/w_browse.h:79:7: note: Assuming that condition '!t_brow' is not redundant
glhack-1.2/tools/edtile/w_browse.h:80:7: note: Null pointer dereference
glhack-1.2/tools/edtile/w_browse.h:86:7: warning: Either the condition '!t_brow' is redundant or there is possible null pointer dereference: t_brow. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/w_browse.h:85:7: note: Assuming that condition '!t_brow' is not redundant
glhack-1.2/tools/edtile/w_browse.h:86:7: note: Null pointer dereference
glhack-1.2/tools/edtile/w_compact.h:97:7: warning: Either the condition '!t_brow' is redundant or there is possible null pointer dereference: t_brow. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/w_compact.h:96:7: note: Assuming that condition '!t_brow' is not redundant
glhack-1.2/tools/edtile/w_compact.h:97:7: note: Null pointer dereference
glhack-1.2/tools/edtile/w_compact.h:103:7: warning: Either the condition '!t_brow' is redundant or there is possible null pointer dereference: t_brow. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/w_compact.h:102:7: note: Assuming that condition '!t_brow' is not redundant
glhack-1.2/tools/edtile/w_compact.h:103:7: note: Null pointer dereference
glhack-1.2/tools/edtile/w_edit.h:74:7: warning: Either the condition '!t_edit' is redundant or there is possible null pointer dereference: t_edit. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/w_edit.h:73:7: note: Assuming that condition '!t_edit' is not redundant
glhack-1.2/tools/edtile/w_edit.h:74:7: note: Null pointer dereference
glhack-1.2/tools/edtile/w_edit.h:80:7: warning: Either the condition '!t_edit' is redundant or there is possible null pointer dereference: t_edit. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/w_edit.h:79:7: note: Assuming that condition '!t_edit' is not redundant
glhack-1.2/tools/edtile/w_edit.h:80:7: note: Null pointer dereference
glhack-1.2/tools/edtile/w_shades.h:74:7: warning: Either the condition '!s_brow' is redundant or there is possible null pointer dereference: s_brow. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/w_shades.h:73:7: note: Assuming that condition '!s_brow' is not redundant
glhack-1.2/tools/edtile/w_shades.h:74:7: note: Null pointer dereference
glhack-1.2/tools/edtile/import3D.cpp:62:12: style: C-style pointer casting [cstyleCast]
glhack-1.2/tools/edtile/import3D.cpp:220:21: style: Variable 'threeddir' is assigned a value that is never used. [unreadVariable]
glhack-1.2/tools/edtile/loadppm.cpp:83:14: warning: Either the condition '(fp=fopen(filename,"r"))<0' is redundant or there is possible null pointer dereference: fp. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/loadppm.cpp:75:35: note: Assuming that condition '(fp=fopen(filename,"r"))<0' is not redundant
glhack-1.2/tools/edtile/loadppm.cpp:83:14: note: Null pointer dereference
glhack-1.2/tools/edtile/loadppm.cpp:128:20: style: C-style pointer casting [cstyleCast]
glhack-1.2/tools/edtile/loadppm.cpp:75:35: style: A pointer can not be negative so it is either pointless or an error to check if it is. [pointerLessThanZero]
glhack-1.2/tools/edtile/makeset.cpp:322:27: style: Variable 'cmap_font' is assigned a value that is never used. [unreadVariable]
glhack-1.2/tools/edtile/renumber.cpp:71:18: style: Variable 'aj_dir' is assigned a value that is never used. [unreadVariable]
glhack-1.2/tools/edtile/t_alias.cpp:173:11: style: Condition 'C==A.end()' is always false [knownConditionTrueFalse]
glhack-1.2/tools/edtile/t_alias.cpp:176:11: style: Condition 'D==B.end()' is always false [knownConditionTrueFalse]
glhack-1.2/tools/edtile/t_alias.cpp:181:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/t_alias.cpp:186:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/t_alias.cpp:192:5: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/t_alias.cpp:204:41: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/t_hue.cpp:95:24: style: C-style pointer casting [cstyleCast]
glhack-1.2/tools/edtile/t_hue.cpp:96:24: style: C-style pointer casting [cstyleCast]
glhack-1.2/tools/edtile/t_hue.cpp:56:9: error: Memory is allocated but not initialized: hue_map [uninitdata]
glhack-1.2/tools/edtile/t_colmap.cpp:38:15: warning: Member variable 'ColorMapping::m_arr' is not initialized in the constructor. [uninitMemberVar]
glhack-1.2/tools/edtile/t_colmap.cpp:304:16: style: C-style pointer casting [cstyleCast]
glhack-1.2/tools/edtile/t_colmap.cpp:305:16: style: C-style pointer casting [cstyleCast]
glhack-1.2/tools/edtile/t_pair.cpp:30:10: warning: Member variable 'PairSet::p_array' is not initialized in the constructor. [uninitMemberVar]
glhack-1.2/tools/edtile/t_specs.cpp:33:3: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat]
glhack-1.2/tools/edtile/t_specs.cpp:35:3: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat]
glhack-1.2/tools/edtile/t_specs.cpp:45:3: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat]
glhack-1.2/tools/edtile/t_specs.cpp:114:3: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat]
glhack-1.2/tools/edtile/t_specs.h:96:10: performance:inconclusive: Technically the member function 'SpecGroup::WriteSpec' can be static (but you may consider moving to unnamed namespace). [functionStatic]
glhack-1.2/tools/edtile/t_specs.cpp:375:17: note: Technically the member function 'SpecGroup::WriteSpec' can be static (but you may consider moving to unnamed namespace).
glhack-1.2/tools/edtile/t_specs.h:96:10: note: Technically the member function 'SpecGroup::WriteSpec' can be static (but you may consider moving to unnamed namespace).
glhack-1.2/tools/edtile/t_specs.cpp:191:7: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
glhack-1.2/tools/edtile/t_specs.cpp:381:7: warning: Either the condition '!spec' is redundant or there is possible null pointer dereference: spec. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/t_specs.cpp:377:3: note: Assuming that condition '!spec' is not redundant
glhack-1.2/tools/edtile/t_specs.cpp:381:7: note: Null pointer dereference
glhack-1.2/tools/edtile/t_tiles.cpp:659:34: portability: Undefined behaviour, when 'src' is -1 the pointer arithmetic 'src_set->tiles+src' is out of bounds. [pointerOutOfBoundsCond]
glhack-1.2/tools/edtile/t_tiles.cpp:656:3: note: Assuming that condition '0<=src' is not redundant
glhack-1.2/tools/edtile/t_tiles.cpp:659:34: note: Pointer arithmetic overflow
glhack-1.2/tools/edtile/t_tiles.cpp:688:15: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData]
glhack-1.2/tools/edtile/t_tiles.h:191:10: style:inconclusive: Technically the member function 'Tileset::WriteTile' can be const. [functionConst]
glhack-1.2/tools/edtile/t_tiles.cpp:1018:15: note: Technically the member function 'Tileset::WriteTile' can be const.
glhack-1.2/tools/edtile/t_tiles.h:191:10: note: Technically the member function 'Tileset::WriteTile' can be const.
glhack-1.2/tools/edtile/t_tiles.cpp:1021:3: warning: Either the condition '!tile' is redundant or there is possible null pointer dereference: tile. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/t_tiles.cpp:1020:3: note: Assuming that condition '!tile' is not redundant
glhack-1.2/tools/edtile/t_tiles.cpp:1021:3: note: Null pointer dereference
glhack-1.2/tools/edtile/t_tiles.cpp:44:12: style: C-style pointer casting [cstyleCast]
glhack-1.2/tools/edtile/t_tiles.cpp:820:17: style: C-style pointer casting [cstyleCast]
glhack-1.2/tools/edtile/t_tiles.cpp:469:9: style: The scope of the variable 'val2' can be reduced. [variableScope]
glhack-1.2/tools/edtile/w_base.cpp:87:17: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled]
glhack-1.2/tools/edtile/w_base.cpp:88:17: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled]
glhack-1.2/tools/edtile/w_base.cpp:101:3: warning: Either the condition '!w' is redundant or there is possible null pointer dereference: base. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/w_base.cpp:97:3: note: Assuming that condition '!w' is not redundant
glhack-1.2/tools/edtile/w_base.cpp:99:20: note: base is assigned 'static_cast<WindowBase*>(w)' here.
glhack-1.2/tools/edtile/w_base.cpp:101:3: note: Null pointer dereference
glhack-1.2/tools/edtile/t_tiles.cpp:138:50: style:inconclusive: Function 'StoreRGB' argument 2 names different: declaration 'rgba' definition 'rgb'. [funcArgNamesDifferent]
glhack-1.2/tools/edtile/t_tiles.h:69:46: note: Function 'StoreRGB' argument 2 names different: declaration 'rgba' definition 'rgb'.
glhack-1.2/tools/edtile/t_tiles.cpp:138:50: note: Function 'StoreRGB' argument 2 names different: declaration 'rgba' definition 'rgb'.
glhack-1.2/tools/edtile/w_browse.cpp:48:40: style:inconclusive: Function 'ChangeTiles' argument 1 names different: declaration 'set' definition 'new_set'. [funcArgNamesDifferent]
glhack-1.2/tools/edtile/w_browse.h:36:31: note: Function 'ChangeTiles' argument 1 names different: declaration 'set' definition 'new_set'.
glhack-1.2/tools/edtile/w_browse.cpp:48:40: note: Function 'ChangeTiles' argument 1 names different: declaration 'set' definition 'new_set'.
glhack-1.2/tools/edtile/w_compact.cpp:49:43: style:inconclusive: Function 'ChangeTiles' argument 1 names different: declaration 'set' definition 'new_set'. [funcArgNamesDifferent]
glhack-1.2/tools/edtile/w_compact.h:36:31: note: Function 'ChangeTiles' argument 1 names different: declaration 'set' definition 'new_set'.
glhack-1.2/tools/edtile/w_compact.cpp:49:43: note: Function 'ChangeTiles' argument 1 names different: declaration 'set' definition 'new_set'.
glhack-1.2/tools/edtile/w_edit.cpp:33:13: warning: Member variable 'TileEditor::set' is not initialized in the constructor. [uninitMemberVar]
glhack-1.2/tools/edtile/w_license.cpp:33:3: warning: Either the condition '!data' is redundant or there is possible null pointer dereference: licw. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/w_license.cpp:29:3: note: Assuming that condition '!data' is not redundant
glhack-1.2/tools/edtile/w_license.cpp:31:20: note: licw is assigned 'static_cast<LicenseWin*>(data)' here.
glhack-1.2/tools/edtile/w_license.cpp:33:3: note: Null pointer dereference
glhack-1.2/tools/edtile/w_license.cpp:56:18: style: C-style pointer casting [cstyleCast]
glhack-1.2/tools/edtile/w_panel.cpp:109:14: style: C-style pointer casting [cstyleCast]
glhack-1.2/tools/edtile/w_shades.cpp:66:15: style: Variable 'pix' is assigned a value that is never used. [unreadVariable]
glhack-1.2/tools/edtile/z_args.cpp:121:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/w_tlinfo.cpp:106:7: warning: Comparison is wrong. Result of 'pixel_buf+16384' can't be 0 unless there is pointer overflow, and pointer overflow is undefined behaviour. [pointerAdditionResultNotNull]
glhack-1.2/tools/edtile/w_tlinfo.cpp:96:15: style: Local variable 'dest' shadows outer variable [shadowVariable]
glhack-1.2/tools/edtile/w_tlinfo.cpp:92:13: note: Shadowed declaration
glhack-1.2/tools/edtile/w_tlinfo.cpp:96:15: note: Shadow variable
glhack-1.2/tools/edtile/z_file.cpp:269:35: warning: Either the condition '!mode' is redundant or there is possible null pointer dereference: mode. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/z_file.cpp:268:3: note: Assuming that condition '!mode' is not redundant
glhack-1.2/tools/edtile/z_file.cpp:269:35: note: Null pointer dereference
glhack-1.2/tools/edtile/z_file.cpp:275:10: warning: Either the condition '!fp' is redundant or there is possible null pointer dereference: fp. [nullPointerRedundantCheck]
glhack-1.2/tools/edtile/z_file.cpp:274:3: note: Assuming that condition '!fp' is not redundant
glhack-1.2/tools/edtile/z_file.cpp:275:10: note: Null pointer dereference
glhack-1.2/tools/edtile/z_file.cpp:75:27: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/z_file.cpp:86:5: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/z_file.cpp:95:27: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/z_file.cpp:111:27: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/z_file.cpp:128:27: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/z_file.cpp:144:27: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/z_file.cpp:198:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/z_file.cpp:224:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/z_hsv.cpp:161:22: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS]
glhack-1.2/tools/edtile/z_hsv.cpp:162:20: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS]
glhack-1.2/tools/edtile/z_hsv.cpp:168:17: error: Signed integer overflow for expression 'seed*1103515245'. [integerOverflow]
glhack-1.2/tools/edtile/z_hsv.cpp:157:14: note: Assignment 'seed=123456789', assigned value is 123456789
glhack-1.2/tools/edtile/z_hsv.cpp:168:17: note: Integer overflow
glhack-1.2/tools/edtile/z_hsv.cpp:168:30: error: Signed integer overflow for expression 'seed*1103515245+12345'. [integerOverflow]
glhack-1.2/tools/edtile/z_hsv.cpp:157:14: note: Assignment 'seed=123456789', assigned value is 123456789
glhack-1.2/tools/edtile/z_hsv.cpp:168:30: note: Integer overflow
glhack-1.2/tools/edtile/z_string.cpp:43:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/z_string.cpp:51:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/z_string.cpp:91:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/z_string.cpp:106:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/tools/edtile/z_string.cpp:123:41: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
glhack-1.2/util/makedefs.c:1166:8: style: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
glhack-1.2/util/makedefs.c:1168:15: warning: %lx in format string (no. 1) requires 'unsigned long *' but the argument type is 'signed long *'. [invalidScanfArgType_int]
glhack-1.2/util/makedefs.c:1030:9: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
glhack-1.2/util/makedefs.c:1541:12: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
glhack-1.2/util/makedefs.c:1930:5: error: Resource handle 'ofp' freed twice. [doubleFree]
glhack-1.2/util/makedefs.c:1894:5: note: Resource handle 'ofp' freed twice.
glhack-1.2/util/makedefs.c:1930:5: note: Resource handle 'ofp' freed twice.
glhack-1.2/util/makedefs.c:893:11: style: Parameter 'line' can be declared as pointer to const [constParameter]
glhack-1.2/util/makedefs.c:1463:8: style: Parameter 's' can be declared as pointer to const [constParameter]
glhack-1.2/util/makedefs.c:1510:8: style: Parameter 's' can be declared as pointer to const [constParameter]
glhack-1.2/util/makedefs.c:336:14: style: Variable 'buf' is not assigned a value. [unassignedVariable]
glhack-1.2/util/panic.c:46:1: error: Unmatched '}'. Configuration: '__GNUC__=1'. [syntaxError]
glhack-1.2/util/recover.c:153:7: style: Obsolescent function 'rindex' called. It is recommended to use 'strrchr' instead. [prohibitedrindexCalled]
glhack-1.2/util/recover.c:75:6: style: Condition '!dir' is always true [knownConditionTrueFalse]
glhack-1.2/util/recover.c:69:20: note: Assignment 'dir=(char*)0', assigned value is 0
glhack-1.2/util/recover.c:75:6: note: Condition '!dir' is always true
glhack-1.2/util/recover.c:237:32: error: Uninitialized variable: hpid [uninitvar]
glhack-1.2/util/recover.c:223:10: note: Assuming condition is false
glhack-1.2/util/recover.c:237:32: note: Uninitialized variable: hpid
glhack-1.2/util/lev_main.c:529:8: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/util/lev_main.c:543:8: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/util/lev_main.c:1029:6: warning: Identical inner 'if' condition is always true. [identicalInnerCondition]
glhack-1.2/util/lev_main.c:1028:6: note: outer condition: *monsters_p
glhack-1.2/util/lev_main.c:1029:6: note: identical inner condition: *monsters_p
glhack-1.2/util/lev_main.c:1063:6: warning: Identical inner 'if' condition is always true. [identicalInnerCondition]
glhack-1.2/util/lev_main.c:1062:6: note: outer condition: *objects_p
glhack-1.2/util/lev_main.c:1063:6: note: identical inner condition: *objects_p
glhack-1.2/util/lev_main.c:1095:6: warning: Identical inner 'if' condition is always true. [identicalInnerCondition]
glhack-1.2/util/lev_main.c:1094:6: note: outer condition: *engravings_p
glhack-1.2/util/lev_main.c:1095:6: note: identical inner condition: *engravings_p
glhack-1.2/win/Qt/tileedit.cpp:404:1: error: syntax error [syntaxError]
glhack-1.2/win/Qt/qt_win.cpp:4931:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/Qt/qt_win.cpp:4938:20: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/Qt/qt_win.cpp:4939:9: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/Qt/qt_win.cpp:4971:29: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/Qt/qt_win.cpp:929:5: style: Class 'NhPSListView' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
glhack-1.2/win/Qt/qt_win.cpp:1831:5: style: Class 'NetHackQtScrollText' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
glhack-1.2/win/Qt/qt_win.cpp:3146:5: style: Class 'NetHackQtTextListBox' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
glhack-1.2/win/Qt/qt_win.cpp:1221:12: style: C-style pointer casting [cstyleCast]
glhack-1.2/win/Qt/qt_win.cpp:1226:7: style: C-style pointer casting [cstyleCast]
glhack-1.2/win/Qt/qt_win.cpp:1231:12: style: C-style pointer casting [cstyleCast]
glhack-1.2/win/Qt/qt_win.cpp:1236:7: style: C-style pointer casting [cstyleCast]
glhack-1.2/win/Qt/qt_win.cpp:2776:19: style: C-style pointer casting [cstyleCast]
glhack-1.2/win/Qt/qt_win.cpp:2917:14: style: C-style pointer casting [cstyleCast]
glhack-1.2/win/Qt/qt_win.cpp:2929:14: style: C-style pointer casting [cstyleCast]
glhack-1.2/win/Qt/qt_win.cpp:3822:7: style: C-style pointer casting [cstyleCast]
glhack-1.2/win/Qt/qt_win.cpp:4606:36: style: C-style pointer casting [cstyleCast]
glhack-1.2/win/Qt/qt_win.cpp:4793:38: style: C-style pointer casting [cstyleCast]
glhack-1.2/win/Qt/qt_win.cpp:5136:10: style: C-style pointer casting [cstyleCast]
glhack-1.2/win/Qt/qt_win.cpp:5141:23: style: C-style pointer casting [cstyleCast]
glhack-1.2/win/Qt/qt_win.cpp:2363:6: style: Variable 'x' is reassigned a value before the old one has been used. [redundantAssignment]
glhack-1.2/win/Qt/qt_win.cpp:2362:34: note: x is assigned
glhack-1.2/win/Qt/qt_win.cpp:2363:6: note: x is overwritten
glhack-1.2/win/Qt/qt_win.cpp:2376:6: style: Variable 'x' is reassigned a value before the old one has been used. [redundantAssignment]
glhack-1.2/win/Qt/qt_win.cpp:2375:34: note: x is assigned
glhack-1.2/win/Qt/qt_win.cpp:2376:6: note: x is overwritten
glhack-1.2/win/Qt/qt_win.cpp:2385:6: style: Variable 'x' is reassigned a value before the old one has been used. [redundantAssignment]
glhack-1.2/win/Qt/qt_win.cpp:2384:36: note: x is assigned
glhack-1.2/win/Qt/qt_win.cpp:2385:6: note: x is overwritten
glhack-1.2/win/Qt/qt_win.cpp:2398:6: style: Variable 'x' is reassigned a value before the old one has been used. [redundantAssignment]
glhack-1.2/win/Qt/qt_win.cpp:2397:39: note: x is assigned
glhack-1.2/win/Qt/qt_win.cpp:2398:6: note: x is overwritten
glhack-1.2/win/Qt/qt_win.cpp:3312:15: style: The scope of the variable 'i' can be reduced. [variableScope]
glhack-1.2/win/Qt/qt_win.cpp:4171:15: style: The scope of the variable 'button' can be reduced. [variableScope]
glhack-1.2/win/Qt/qt_win.cpp:4191:10: style: The scope of the variable 'lb' can be reduced. [variableScope]
glhack-1.2/win/Qt/qt_win.cpp:4213:8: style: The scope of the variable 'ch_esc' can be reduced. [variableScope]
glhack-1.2/win/Qt/qt_win.cpp:4213:8: style: Local variable 'ch_esc' shadows outer variable [shadowVariable]
glhack-1.2/win/Qt/qt_win.cpp:4204:7: note: Shadowed declaration
glhack-1.2/win/Qt/qt_win.cpp:4213:8: note: Shadow variable
glhack-1.2/win/Qt/qt_win.cpp:4168:7: style: Variable 'x' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/Qt/qt_win.cpp:4168:17: style: Variable 'y' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/Qt/qt_win.cpp:4182:4: style: Variable 'x' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/Qt/qt_win.cpp:4183:4: style: Variable 'y' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/Qt/qt_win.cpp:4185:4: style: Variable 'x' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/Qt/qt_win.cpp:4191:12: style: Variable 'lb' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/Qt/qt_win.cpp:4196:8: style: Variable 'lb' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/X11/winX.c:1541:13: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winX.c:1543:13: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winX.c:1611:12: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winX.c:1619:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winX.c:1620:9: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winX.c:336:11: style: Parameter 'num_args' can be declared as pointer to const [constParameter]
glhack-1.2/win/X11/winX.c:433:11: style: Parameter 'num_args' can be declared as pointer to const [constParameter]
glhack-1.2/win/X11/winX.c:1019:36: error: Uninitialized variable: hints [uninitvar]
glhack-1.2/win/X11/winmap.c:540:12: style: Variable 'tile_info' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/X11/winmisc.c:131:6: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:139:12: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:140:23: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:141:23: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:143:6: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:145:11: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:172:6: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:180:12: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:181:23: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:182:23: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:184:6: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:186:11: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:213:12: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:214:23: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:216:6: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:218:11: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:245:12: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:246:23: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:248:6: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:250:11: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmisc.c:659:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/wintext.c:381:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/wintext.c:395:21: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmenu.c:233:7: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmenu.c:273:13: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmenu.c:724:27: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/X11/winmenu.c:959:18: style: Variable 'viewport_widget' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/gem/xpm2img.c:130:12: warning: %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int]
glhack-1.2/win/gem/xpm2img.c:130:12: warning: %x in format string (no. 3) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int]
glhack-1.2/win/gem/xpm2img.c:130:12: warning: %x in format string (no. 4) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int]
glhack-1.2/win/gem/xpm2img.c:32:16: style: Unused variable: planeno [unusedVariable]
glhack-1.2/win/gem/xpm2img.c:54:7: style: Unused variable: plane_offset [unusedVariable]
glhack-1.2/win/gem/wingem1.c:1369:3: error: Common realloc mistake: 'text_lines' nulled but not freed upon failure [memleakOnRealloc]
glhack-1.2/win/gem/wingem1.c:1382:16: warning: Either the condition 'str' is redundant or there is possible null pointer dereference: str. [nullPointerRedundantCheck]
glhack-1.2/win/gem/wingem1.c:1377:5: note: Assuming that condition 'str' is not redundant
glhack-1.2/win/gem/wingem1.c:1382:16: note: Null pointer dereference
glhack-1.2/win/gem/wingem1.c:544:7: warning: Redundant assignment of 'first' to itself. [selfAssignment]
glhack-1.2/win/gem/wingem1.c:1198:5: warning: Redundant assignment of 'xev' to itself. [selfAssignment]
glhack-1.2/win/gem/wingem1.c:1207:5: warning: Redundant assignment of 'xev' to itself. [selfAssignment]
glhack-1.2/win/gem/wingem1.c:1216:5: warning: Redundant assignment of 'xev' to itself. [selfAssignment]
glhack-1.2/win/gem/wingem1.c:1280:5: warning: Redundant assignment of 'win' to itself. [selfAssignment]
glhack-1.2/win/gem/wingem1.c:1302:5: warning: Redundant assignment of 'win' to itself. [selfAssignment]
glhack-1.2/win/gem/wingem1.c:1363:8: warning: Redundant assignment of 'window' to itself. [selfAssignment]
glhack-1.2/win/gem/wingem1.c:2673:14: style: Variable 'gem_color' can be declared as const array [constVariable]
glhack-1.2/win/gem/wingem1.c:517:8: style: Variable 'todo' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/gem/wingem1.c:544:7: style: Variable 'first' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/gem/wingem1.c:704:22: style: Unused variable: starty [unusedVariable]
glhack-1.2/win/gem/wingem1.c:1198:5: style: Variable 'xev' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/gem/wingem1.c:1207:5: style: Variable 'xev' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/gem/wingem1.c:1216:5: style: Variable 'xev' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/gem/wingem1.c:1280:5: style: Variable 'win' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/gem/wingem1.c:1302:5: style: Variable 'win' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/gem/wingem1.c:1363:8: style: Variable 'window' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/gem/wingem1.c:1664:29: style: Unused variable: y_wo [unusedVariable]
glhack-1.2/win/gem/wingem1.c:1664:35: style: Unused variable: i [unusedVariable]
glhack-1.2/win/gem/wingem1.c:1935:11: style: Unused variable: z_ob [unusedVariable]
glhack-1.2/win/gnome/gnbind.c:104:0: error: #error HACKDIR is not defined! [preprocessorErrorDirective]
glhack-1.2/win/gnome/gnmap.c:411:9: style: Variable 'group' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/gnome/gnyesno.c:10:38: style:inconclusive: Function 'ghack_yes_no_dialog' argument 1 names different: declaration 'szQuestionStr' definition 'question'. [funcArgNamesDifferent]
glhack-1.2/win/gnome/gnyesno.h:8:38: note: Function 'ghack_yes_no_dialog' argument 1 names different: declaration 'szQuestionStr' definition 'question'.
glhack-1.2/win/gnome/gnyesno.c:10:38: note: Function 'ghack_yes_no_dialog' argument 1 names different: declaration 'szQuestionStr' definition 'question'.
glhack-1.2/win/gnome/gnyesno.c:11:21: style:inconclusive: Function 'ghack_yes_no_dialog' argument 2 names different: declaration 'szChoicesStr' definition 'choices'. [funcArgNamesDifferent]
glhack-1.2/win/gnome/gnyesno.h:9:14: note: Function 'ghack_yes_no_dialog' argument 2 names different: declaration 'szChoicesStr' definition 'choices'.
glhack-1.2/win/gnome/gnyesno.c:11:21: note: Function 'ghack_yes_no_dialog' argument 2 names different: declaration 'szChoicesStr' definition 'choices'.
glhack-1.2/win/gnome/gnyesno.c:11:34: style:inconclusive: Function 'ghack_yes_no_dialog' argument 3 names different: declaration 'nDefault' definition 'def'. [funcArgNamesDifferent]
glhack-1.2/win/gnome/gnyesno.h:9:32: note: Function 'ghack_yes_no_dialog' argument 3 names different: declaration 'nDefault' definition 'def'.
glhack-1.2/win/gnome/gnyesno.c:11:34: note: Function 'ghack_yes_no_dialog' argument 3 names different: declaration 'nDefault' definition 'def'.
glhack-1.2/win/gnome/gntext.c:150:48: style:inconclusive: Function 'ghack_text_window_rip_string' argument 1 names different: declaration 'ripString' definition 'string'. [funcArgNamesDifferent]
glhack-1.2/win/gnome/gntext.h:19:48: note: Function 'ghack_text_window_rip_string' argument 1 names different: declaration 'ripString' definition 'string'.
glhack-1.2/win/gnome/gntext.c:150:48: note: Function 'ghack_text_window_rip_string' argument 1 names different: declaration 'ripString' definition 'string'.
glhack-1.2/win/gnome/gnmenu.c:282:22: style: Variable 'nCurrentRow' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/share/gifread.c:80:7: error: Uninitialized variable: count [uninitvar]
glhack-1.2/win/share/gifread.c:135:7: style: Variable 'str' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/share/gifread.c:141:7: style: Variable 'str' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/share/thintile.c:35:9: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf]
glhack-1.2/win/share/thintile.c:51:6: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf]
glhack-1.2/win/share/tile2bmp.c:283:19: style: Assignment 'cClrBits=1' is redundant with condition 'cClrBits==1'. [duplicateConditionalAssign]
glhack-1.2/win/share/tile2bmp.c:282:15: note: Condition 'cClrBits==1'
glhack-1.2/win/share/tile2bmp.c:283:19: note: Assignment 'cClrBits=1' is redundant
glhack-1.2/win/share/tile2bmp.c:282:15: style: Condition 'cClrBits==1' is always false [knownConditionTrueFalse]
glhack-1.2/win/share/tile2bmp.c:280:13: note: Assignment 'cClrBits=8', assigned value is 8
glhack-1.2/win/share/tile2bmp.c:282:15: note: Condition 'cClrBits==1' is always false
glhack-1.2/win/share/tile2bmp.c:284:20: style: Condition 'cClrBits<=4' is always false [knownConditionTrueFalse]
glhack-1.2/win/share/tile2bmp.c:280:13: note: Assignment 'cClrBits=8', assigned value is 8
glhack-1.2/win/share/tile2bmp.c:284:20: note: Condition 'cClrBits<=4' is always false
glhack-1.2/win/share/tile2bmp.c:286:20: style: Condition 'cClrBits<=8' is always true [knownConditionTrueFalse]
glhack-1.2/win/share/tile2bmp.c:280:13: note: Assignment 'cClrBits=8', assigned value is 8
glhack-1.2/win/share/tile2bmp.c:286:20: note: Condition 'cClrBits<=8' is always true
glhack-1.2/win/share/tile2bmp.c:271:28: style: Argument 'w=640' to function lelong is always 640. It does not matter what value 'w' has. [knownArgument]
glhack-1.2/win/share/tile2bmp.c:273:29: style: Argument 'h=480' to function lelong is always 480. It does not matter what value 'h' has. [knownArgument]
glhack-1.2/win/share/tile2bmp.c:283:19: style: Variable 'cClrBits' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/share/tile2bmp.c:285:12: style: Variable 'cClrBits' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/share/tile2bmp.c:287:12: style: Variable 'cClrBits' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/share/tile2bmp.c:289:12: style: Variable 'cClrBits' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/share/tile2bmp.c:291:12: style: Variable 'cClrBits' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/share/tile2bmp.c:292:16: style: Variable 'cClrBits' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/share/tilemap.c:476:19: error: Array 'substitutes[4]' accessed at index -1, which is out of bounds. [negativeIndex]
glhack-1.2/win/share/tilemap.c:445:7: note: Assignment 'j=-1', assigned value is -1
glhack-1.2/win/share/tilemap.c:448:16: note: Assuming condition is false
glhack-1.2/win/share/tilemap.c:476:19: note: Negative array index
glhack-1.2/win/share/tilemap.c:477:19: error: Array 'substitutes[4]' accessed at index -1, which is out of bounds. [negativeIndex]
glhack-1.2/win/share/tilemap.c:445:7: note: Assignment 'j=-1', assigned value is -1
glhack-1.2/win/share/tilemap.c:448:16: note: Assuming condition is false
glhack-1.2/win/share/tilemap.c:477:19: note: Negative array index
glhack-1.2/win/share/tilemap.c:479:25: error: Array 'substitutes[4]' accessed at index -1, which is out of bounds. [negativeIndex]
glhack-1.2/win/share/tilemap.c:445:7: note: Assignment 'j=-1', assigned value is -1
glhack-1.2/win/share/tilemap.c:448:16: note: Assuming condition is false
glhack-1.2/win/share/tilemap.c:479:25: note: Negative array index
glhack-1.2/win/share/tiletext.c:272:6: style: Obsolescent function 'rindex' called. It is recommended to use 'strrchr' instead. [prohibitedrindexCalled]
glhack-1.2/win/share/tiletext.c:47:9: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf]
glhack-1.2/win/win32/mhfont.c:25:12: style: Variable 'fnt' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/win32/mhdlg.c:527:39: style:inconclusive: Function 'plselAdjustLists' argument 2 names different: declaration 'changed_opt' definition 'changed_sel'. [funcArgNamesDifferent]
glhack-1.2/win/win32/mhdlg.c:284:47: note: Function 'plselAdjustLists' argument 2 names different: declaration 'changed_opt' definition 'changed_sel'.
glhack-1.2/win/win32/mhdlg.c:527:39: note: Function 'plselAdjustLists' argument 2 names different: declaration 'changed_opt' definition 'changed_sel'.
glhack-1.2/win/win32/mhdlg.c:138:9: style: Local variable 'wbuf' shadows outer variable [shadowVariable]
glhack-1.2/win/win32/mhdlg.c:55:9: note: Shadowed declaration
glhack-1.2/win/win32/mhdlg.c:138:9: note: Shadow variable
glhack-1.2/win/win32/mhdlg.c:204:8: style: Variable 'data' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/win32/mhdlg.c:318:8: style: Variable 'data' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/win32/mhdlg.c:664:14: style: Variable 'initalign' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/win32/mhmain.c:412:21: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mhmain.c:879:32: style:inconclusive: Function 'mswin_select_map_mode' argument 1 names different: declaration 'map_mode' definition 'mode'. [funcArgNamesDifferent]
glhack-1.2/win/win32/mhmain.h:13:32: note: Function 'mswin_select_map_mode' argument 1 names different: declaration 'map_mode' definition 'mode'.
glhack-1.2/win/win32/mhmain.c:879:32: note: Function 'mswin_select_map_mode' argument 1 names different: declaration 'map_mode' definition 'mode'.
glhack-1.2/win/win32/mhmap.c:813:30: style:inconclusive: Function 'nhglyph2charcolor' argument 1 names different: declaration 'glyph' definition 'g'. [funcArgNamesDifferent]
glhack-1.2/win/win32/mhmap.c:44:37: note: Function 'nhglyph2charcolor' argument 1 names different: declaration 'glyph' definition 'g'.
glhack-1.2/win/win32/mhmap.c:813:30: note: Function 'nhglyph2charcolor' argument 1 names different: declaration 'glyph' definition 'g'.
glhack-1.2/win/win32/mhmap.c:471:10: style: Local variable 'rt' shadows outer variable [shadowVariable]
glhack-1.2/win/win32/mhmap.c:398:7: note: Shadowed declaration
glhack-1.2/win/win32/mhmap.c:471:10: note: Shadow variable
glhack-1.2/win/win32/mhmap.c:565:14: style: Unused variable: special [unusedVariable]
glhack-1.2/win/win32/mhmap.c:566:9: style: Unused variable: mgch [unusedVariable]
glhack-1.2/win/win32/mhmap.c:567:12: style: Unused variable: back_brush [unusedVariable]
glhack-1.2/win/win32/mhmap.c:853:21: style: Variable 'offset' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/win32/mhmenu.c:817:25: warning:inconclusive: The buffer 'wbuf' may not be null-terminated after the call to strncpy(). [terminateStrncpy]
glhack-1.2/win/win32/mhmsgwnd.c:541:15: style: Local variable 'oldFont' shadows outer variable [shadowVariable]
glhack-1.2/win/win32/mhmsgwnd.c:463:10: note: Shadowed declaration
glhack-1.2/win/win32/mhmsgwnd.c:541:15: note: Shadow variable
glhack-1.2/win/win32/mhrip.c:52:37: style:inconclusive: Function 'mswin_display_RIP_window' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/win/win32/mhrip.h:13:37: note: Function 'mswin_display_RIP_window' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhrip.c:52:37: note: Function 'mswin_display_RIP_window' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhsplash.c:51:33: style: Variable 'mapWnd' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/win32/mhsplash.c:224:11: style: Variable 'OldFont' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/win32/mhtext.c:45:38: style:inconclusive: Function 'mswin_display_text_window' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/win/win32/mhtext.h:12:38: note: Function 'mswin_display_text_window' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhtext.c:45:38: note: Function 'mswin_display_text_window' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhtext.c:178:22: style:inconclusive: Function 'LayoutText' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/win/win32/mhtext.c:23:29: note: Function 'LayoutText' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhtext.c:178:22: note: Function 'LayoutText' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/winhack.c:143:4: style: Variable 'p' is reassigned a value before the old one has been used. [redundantAssignment]
glhack-1.2/win/win32/winhack.c:142:4: note: p is assigned
glhack-1.2/win/win32/winhack.c:143:4: note: p is overwritten
glhack-1.2/win/win32/winhack.c:119:14: style: Local variable 'buf' shadows outer variable [shadowVariable]
glhack-1.2/win/win32/winhack.c:86:7: note: Shadowed declaration
glhack-1.2/win/win32/winhack.c:119:14: note: Shadow variable
glhack-1.2/win/win32/winhack.c:128:14: style: Local variable 'buf' shadows outer variable [shadowVariable]
glhack-1.2/win/win32/winhack.c:86:7: note: Shadowed declaration
glhack-1.2/win/win32/winhack.c:128:14: note: Shadow variable
glhack-1.2/win/win32/winhack.c:208:25: style: Variable 'bQuoted' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/win32/mhmenu.c:104:41: style:inconclusive: Function 'mswin_menu_window_select_menu' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/win/win32/mhmenu.h:15:41: note: Function 'mswin_menu_window_select_menu' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhmenu.c:104:41: note: Function 'mswin_menu_window_select_menu' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhmenu.c:550:22: style:inconclusive: Function 'LayoutMenu' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/win/win32/mhmenu.c:78:29: note: Function 'LayoutMenu' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhmenu.c:550:22: note: Function 'LayoutMenu' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhmenu.c:589:23: style:inconclusive: Function 'SetMenuType' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/win/win32/mhmenu.c:79:30: note: Function 'SetMenuType' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhmenu.c:589:23: note: Function 'SetMenuType' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhmenu.c:616:27: style:inconclusive: Function 'SetMenuListType' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/win/win32/mhmenu.c:80:34: note: Function 'SetMenuListType' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhmenu.c:616:27: note: Function 'SetMenuListType' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhmenu.c:616:37: style:inconclusive: Function 'SetMenuListType' argument 2 names different: declaration 'now' definition 'how'. [funcArgNamesDifferent]
glhack-1.2/win/win32/mhmenu.c:80:44: note: Function 'SetMenuListType' argument 2 names different: declaration 'now' definition 'how'.
glhack-1.2/win/win32/mhmenu.c:616:37: note: Function 'SetMenuListType' argument 2 names different: declaration 'now' definition 'how'.
glhack-1.2/win/win32/mhmenu.c:714:26: style:inconclusive: Function 'GetMenuControl' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/win/win32/mhmenu.c:81:33: note: Function 'GetMenuControl' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhmenu.c:714:26: note: Function 'GetMenuControl' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhmenu.c:1238:35: style:inconclusive: Function 'mswin_menu_window_size' argument 1 names different: declaration 'hwnd' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/win/win32/mhmenu.h:16:35: note: Function 'mswin_menu_window_size' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhmenu.c:1238:35: note: Function 'mswin_menu_window_size' argument 1 names different: declaration 'hwnd' definition 'hWnd'.
glhack-1.2/win/win32/mhmenu.c:851:9: style: Local variable 'wbuf' shadows outer variable [shadowVariable]
glhack-1.2/win/win32/mhmenu.c:764:8: note: Shadowed declaration
glhack-1.2/win/win32/mhmenu.c:851:9: note: Shadow variable
glhack-1.2/win/win32/mhmenu.c:559:7: style: Variable 'data' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/win32/mhmenu.c:706:9: style: Variable 'nItem' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/win32/mhmenu.c:737:7: style: Variable 'data' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/win32/mswproc.c:883:32: warning: Either the condition 'wid!=-1' is redundant or the array 'GetNHApp()->windowlist[15]' is accessed at index -1, which is out of bounds. [negativeIndex]
glhack-1.2/win/win32/mswproc.c:890:13: note: Assuming that condition 'wid!=-1' is not redundant
glhack-1.2/win/win32/mswproc.c:883:32: note: Negative array index
glhack-1.2/win/win32/mswproc.c:343:7: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:344:15: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:1413:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:1416:13: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:1423:17: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:1424:5: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:1448:8: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:1450:13: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:1455:17: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:1458:15: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:1482:28: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:2314:15: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:2316:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:2318:17: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:2320:18: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:2322:16: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:2324:17: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled]
glhack-1.2/win/win32/mswproc.c:1493:15: style: Condition 'z!='\n'' is always true [knownConditionTrueFalse]
glhack-1.2/win/win32/mswproc.c:1485:18: note: Assuming that condition 'z=='\b'' is not redundant
glhack-1.2/win/win32/mswproc.c:1493:15: note: Condition 'z!='\n'' is always true
glhack-1.2/win/win32/mswproc.c:2008:31: style:inconclusive: Function 'mswin_popup_display' argument 1 names different: declaration 'popup' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/win/win32/winMS.h:147:31: note: Function 'mswin_popup_display' argument 1 names different: declaration 'popup' definition 'hWnd'.
glhack-1.2/win/win32/mswproc.c:2008:31: note: Function 'mswin_popup_display' argument 1 names different: declaration 'popup' definition 'hWnd'.
glhack-1.2/win/win32/mswproc.c:2052:31: style:inconclusive: Function 'mswin_popup_destroy' argument 1 names different: declaration 'popup' definition 'hWnd'. [funcArgNamesDifferent]
glhack-1.2/win/win32/winMS.h:148:31: note: Function 'mswin_popup_destroy' argument 1 names different: declaration 'popup' definition 'hWnd'.
glhack-1.2/win/win32/mswproc.c:2052:31: note: Function 'mswin_popup_destroy' argument 1 names different: declaration 'popup' definition 'hWnd'.
glhack-1.2/win/win32/mswproc.c:2008:42: style: Parameter 'done_indicator' can be declared as pointer to const [constParameter]
glhack-1.2/win/win32/mswproc.c:1387:20: style: Variable 'yn_esc_map' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/win32/mswproc.c:1423:14: style: Variable 'yn_esc_map' is assigned a value that is never used. [unreadVariable]
glhack-1.2/win/win32/mswproc.c:1497:73: style: Variable 'n_len' is assigned a value that is never used. [unreadVariable]
diff:
head glhack-1.2/src/mkmaze.c:134:15: style: Variable 'spine_array' can be declared as const array [constVariable]
2.8 glhack-1.2/src/mkmaze.c:134:15: style: Variable 'spine_array' can be declared with const [constVariable]
head glhack-1.2/src/pickup.c:1920:13: style: Parameter 'obj' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/src/pickup.c:1920:13: style: Parameter 'obj' can be declared with const [constParameter]
head glhack-1.2/src/pickup.c:309:13: style: Parameter 'obj' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/src/pickup.c:309:13: style: Parameter 'obj' can be declared with const [constParameter]
head glhack-1.2/src/spell.c:501:13: style: Parameter 'obj' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/src/spell.c:501:13: style: Parameter 'obj' can be declared with const [constParameter]
head glhack-1.2/src/spell.c:511:13: style: Parameter 'old_obj' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/src/spell.c:511:13: style: Parameter 'old_obj' can be declared with const [constParameter]
head glhack-1.2/sys/amiga/txt2iff.c:384:5: style: Variable 'tmpmap' can be declared as const array [constVariable]
2.8 glhack-1.2/sys/amiga/txt2iff.c:384:5: style: Variable 'tmpmap' can be declared with const [constVariable]
head glhack-1.2/sys/amiga/winreq.c:387:16: style: Variable 'sizes' can be declared as const array [constVariable]
2.8 glhack-1.2/sys/amiga/winreq.c:387:16: style: Variable 'sizes' can be declared with const [constVariable]
head glhack-1.2/sys/mac/macsnd.c:64:8: style: Variable 'midi_note' can be declared as const array [constVariable]
2.8 glhack-1.2/sys/mac/macsnd.c:64:8: style: Variable 'midi_note' can be declared with const [constVariable]
head glhack-1.2/sys/mac/macwin.c:1695:32: style: Parameter 'theEvent' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/sys/mac/macwin.c:1695:32: style: Parameter 'theEvent' can be declared with const [constParameter]
head glhack-1.2/sys/mac/macwin.c:1840:29: style: Parameter 'theEvent' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/sys/mac/macwin.c:1840:29: style: Parameter 'theEvent' can be declared with const [constParameter]
head glhack-1.2/sys/share/uudecode.c:214:7: style: Parameter 'p' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/sys/share/uudecode.c:214:7: style: Parameter 'p' can be declared with const [constParameter]
head glhack-1.2/tools/edtile/create_md2.c:230:48: style: Parameter 'vert_list' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/tools/edtile/create_md2.c:230:48: style: Parameter 'vert_list' can be declared with const [constParameter]
head glhack-1.2/tools/edtile/create_md2.c:258:46: style: Parameter 'vert_list' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/tools/edtile/create_md2.c:258:46: style: Parameter 'vert_list' can be declared with const [constParameter]
head glhack-1.2/tools/edtile/create_md2.c:404:31: warning: Either the condition 'i<str_size' is redundant or the array 'str[5]' is accessed at index 8, which is out of bounds. [arrayIndexOutOfBoundsCond]
     glhack-1.2/tools/edtile/create_md2.c:442:13: note: Calling function 'AddString', 1st argument '"tris0.ppm"' value is "tris0.ppm"
     glhack-1.2/tools/edtile/create_md2.c:400:24: note: Assignment 'str_size=strlen(str)', assigned value is 9
     glhack-1.2/tools/edtile/create_md2.c:404:15: note: Assuming that condition 'i<str_size' is not redundant
     glhack-1.2/tools/edtile/create_md2.c:404:31: note: Array index out of bounds
2.8 glhack-1.2/tools/edtile/makeset.cpp:322:17: style: Variable 'cmap_font' is assigned a value that is never used. [unreadVariable]
head glhack-1.2/tools/edtile/makeset.cpp:322:27: style: Variable 'cmap_font' is assigned a value that is never used. [unreadVariable]
head glhack-1.2/tools/edtile/t_colmap.h:58:5: style: Class 'ColorMapping' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
head glhack-1.2/tools/edtile/z_hsv.cpp:161:22: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS]
head glhack-1.2/tools/edtile/z_hsv.cpp:162:20: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS]
head glhack-1.2/util/makedefs.c:1463:8: style: Parameter 's' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/util/makedefs.c:1463:8: style: Parameter 's' can be declared with const [constParameter]
head glhack-1.2/util/makedefs.c:1510:8: style: Parameter 's' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/util/makedefs.c:1510:8: style: Parameter 's' can be declared with const [constParameter]
head glhack-1.2/util/makedefs.c:893:11: style: Parameter 'line' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/util/makedefs.c:893:11: style: Parameter 'line' can be declared with const [constParameter]
head glhack-1.2/win/X11/winX.c:336:11: style: Parameter 'num_args' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/win/X11/winX.c:336:11: style: Parameter 'num_args' can be declared with const [constParameter]
head glhack-1.2/win/X11/winX.c:433:11: style: Parameter 'num_args' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/win/X11/winX.c:433:11: style: Parameter 'num_args' can be declared with const [constParameter]
head glhack-1.2/win/gem/wingem1.c:2673:14: style: Variable 'gem_color' can be declared as const array [constVariable]
2.8 glhack-1.2/win/gem/wingem1.c:2673:14: style: Variable 'gem_color' can be declared with const [constVariable]
2.8 glhack-1.2/win/win32/mswproc.c:1443:7: style: Condition 'choices' is always true [knownConditionTrueFalse]
head glhack-1.2/win/win32/mswproc.c:1493:15: style: Condition 'z!='\n'' is always true [knownConditionTrueFalse]
     glhack-1.2/win/win32/mswproc.c:1485:18: note: Assuming that condition 'z=='\b'' is not redundant
     glhack-1.2/win/win32/mswproc.c:1493:15: note: Condition 'z!='\n'' is always true
head glhack-1.2/win/win32/mswproc.c:2008:42: style: Parameter 'done_indicator' can be declared as pointer to const [constParameter]
2.8 glhack-1.2/win/win32/mswproc.c:2008:42: style: Parameter 'done_indicator' can be declared with const [constParameter]


DONE