2024-04-24 20:01 ftp://ftp.de.debian.org/debian/pool/main/g/gimp-dds/gimp-dds_3.0.1.orig.tar.bz2 cppcheck-options: --library=posix --library=gnu --library=bsd --library=gtk --library=openmp --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.5.0-28-generic-x86_64-with-glibc2.35 python: 3.10.12 client-version: 1.3.57 compiler: g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 cppcheck: head 2.14.0 head-info: 94f28a2 (2024-04-24 20:47:54 +0200) count: 79 79 elapsed-time: 8.9 8.9 head-timing-info: old-timing-info: head results: gimp-dds-3.0.1/dds.c:106:1: error: There is an unknown macro here somewhere. Configuration is required. If MAIN is a macro then please configure it. [unknownMacro] gimp-dds-3.0.1/dxt.c:577:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FLT_MAX [valueFlowBailoutIncompleteVar] gimp-dds-3.0.1/dxt.c:616:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FLT_MAX [valueFlowBailoutIncompleteVar] gimp-dds-3.0.1/dxt.c:674:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable t [valueFlowBailoutIncompleteVar] gimp-dds-3.0.1/mipmap.c:862:26: style:inconclusive: Function 'generate_mipmaps' argument 10 names different: declaration 'gamma_correct' definition 'gc'. [funcArgNamesDifferent] gimp-dds-3.0.1/mipmap.h:39:26: note: Function 'generate_mipmaps' argument 10 names different: declaration 'gamma_correct' definition 'gc'. gimp-dds-3.0.1/mipmap.c:862:26: note: Function 'generate_mipmaps' argument 10 names different: declaration 'gamma_correct' definition 'gc'. gimp-dds-3.0.1/mipmap.c:863:26: style:inconclusive: Function 'generate_mipmaps' argument 12 names different: declaration 'preserve_alpha_test_coverage' definition 'preserve_alpha_coverage'. [funcArgNamesDifferent] gimp-dds-3.0.1/mipmap.h:40:26: note: Function 'generate_mipmaps' argument 12 names different: declaration 'preserve_alpha_test_coverage' definition 'preserve_alpha_coverage'. gimp-dds-3.0.1/mipmap.c:863:26: note: Function 'generate_mipmaps' argument 12 names different: declaration 'preserve_alpha_test_coverage' definition 'preserve_alpha_coverage'. gimp-dds-3.0.1/mipmap.c:946:33: style:inconclusive: Function 'generate_volume_mipmaps' argument 11 names different: declaration 'gamma_correct' definition 'gc'. [funcArgNamesDifferent] gimp-dds-3.0.1/mipmap.h:45:33: note: Function 'generate_volume_mipmaps' argument 11 names different: declaration 'gamma_correct' definition 'gc'. gimp-dds-3.0.1/mipmap.c:946:33: note: Function 'generate_volume_mipmaps' argument 11 names different: declaration 'gamma_correct' definition 'gc'. gimp-dds-3.0.1/mipmap.c:349:48: style: Parameter 'src' can be declared as pointer to const. However it seems that 'scale_image_nearest' is a callback function, if 'src' is declared with const you might also need to cast function pointer(s). [constParameterCallback] gimp-dds-3.0.1/mipmap.c:877:21: note: You might need to cast the function pointer here gimp-dds-3.0.1/mipmap.c:349:48: note: Parameter 'src' can be declared as pointer to const gimp-dds-3.0.1/mipmap.c:388:23: style: Variable 'row' can be declared as pointer to const [constVariablePointer] gimp-dds-3.0.1/mipmap.c:388:29: style: Variable 'col' can be declared as pointer to const [constVariablePointer] gimp-dds-3.0.1/mipmap.c:513:55: style: Parameter 'src' can be declared as pointer to const. However it seems that 'scale_volume_image_nearest' is a callback function, if 'src' is declared with const you might also need to cast function pointer(s). [constParameterCallback] gimp-dds-3.0.1/mipmap.c:959:21: note: You might need to cast the function pointer here gimp-dds-3.0.1/mipmap.c:513:55: note: Parameter 'src' can be declared as pointer to const gimp-dds-3.0.1/mipmap.c:563:23: style: Variable 'row' can be declared as pointer to const [constVariablePointer] gimp-dds-3.0.1/mipmap.c:563:29: style: Variable 'col' can be declared as pointer to const [constVariablePointer] gimp-dds-3.0.1/mipmap.c:563:35: style: Variable 'slice' can be declared as pointer to const [constVariablePointer] gimp-dds-3.0.1/mipmap.c:768:47: style: Parameter 'src' can be declared as pointer to const [constParameterPointer] gimp-dds-3.0.1/mipmap.c:942:64: style: Parameter 'src' can be declared as pointer to const [constParameterPointer] gimp-dds-3.0.1/ddsread.c:94:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GIMP_PDB_CANCEL [valueFlowBailoutIncompleteVar] gimp-dds-3.0.1/ddsread.c:804:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GIMP_RGBA_IMAGE [valueFlowBailoutIncompleteVar] gimp-dds-3.0.1/ddsread.c:1169:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_RESPONSE_CANCEL [valueFlowBailoutIncompleteVar] gimp-dds-3.0.1/dxt.c:124:59: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] gimp-dds-3.0.1/dxt.c:124:77: style: Parameter 'b' can be declared as pointer to const [constParameterPointer] gimp-dds-3.0.1/dxt.c:650:67: style: Parameter 'block' can be declared as pointer to const [constParameterPointer] gimp-dds-3.0.1/dxt.c:1266:73: style: Parameter 'src' can be declared as pointer to const [constParameterPointer] gimp-dds-3.0.1/dxt.c:1340:58: style: Parameter 'block' can be declared as pointer to const [constParameterPointer] gimp-dds-3.0.1/ddswrite.c:371:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GIMP_RGB_IMAGE [valueFlowBailoutIncompleteVar] gimp-dds-3.0.1/ddswrite.c:480:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GIMP_PDB_CANCEL [valueFlowBailoutIncompleteVar] gimp-dds-3.0.1/ddswrite.c:755:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GIMP_INDEXED [valueFlowBailoutIncompleteVar] gimp-dds-3.0.1/ddswrite.c:1003:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GIMP_INDEXED [valueFlowBailoutIncompleteVar] gimp-dds-3.0.1/ddswrite.c:1141:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GIMP_INDEXED [valueFlowBailoutIncompleteVar] gimp-dds-3.0.1/ddswrite.c:1699:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_RESPONSE_CANCEL [valueFlowBailoutIncompleteVar] gimp-dds-3.0.1/ddsread.c:1173:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddsread.c:1176:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddsread.c:1180:11: style: gtk_vbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_VERTICAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_vbox_newCalled] gimp-dds-3.0.1/ddsread.c:1187:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddsread.c:1194:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddsread.c:1201:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddsread.c:93:10: style: Condition '!load_dialog()' is always true [knownConditionTrueFalse] gimp-dds-3.0.1/ddsread.c:1208:12: note: Assignment 'runme=0', assigned value is 0 gimp-dds-3.0.1/ddsread.c:93:22: note: Calling function 'load_dialog' returns 0 gimp-dds-3.0.1/ddsread.c:93:10: note: Condition '!load_dialog()' is always true gimp-dds-3.0.1/ddsread.c:366:18: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] gimp-dds-3.0.1/ddsread.c:387:24: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] gimp-dds-3.0.1/ddsread.c:407:17: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] gimp-dds-3.0.1/ddsread.c:790:13: portability: %d in format string (no. 1) requires 'int' but the argument type is 'DXGI_FORMAT {aka signed long}'. [invalidPrintfArgType_sint] gimp-dds-3.0.1/ddsread.c:842:27: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] gimp-dds-3.0.1/ddsread.c:268:10: error: Memory leak: d.palette [memleak] gimp-dds-3.0.1/ddsread.c:362:20: style: Local variable 'i' shadows outer variable [shadowVariable] gimp-dds-3.0.1/ddsread.c:89:8: note: Shadowed declaration gimp-dds-3.0.1/ddsread.c:362:20: note: Shadow variable gimp-dds-3.0.1/ddsread.c:402:20: style: Local variable 'i' shadows outer variable [shadowVariable] gimp-dds-3.0.1/ddsread.c:89:8: note: Shadowed declaration gimp-dds-3.0.1/ddsread.c:402:20: note: Shadow variable gimp-dds-3.0.1/ddsread.c:639:68: style: Parameter 'dx10hdr' can be declared as pointer to const [constParameterPointer] gimp-dds-3.0.1/ddsread.c:798:69: style: Parameter 'd' can be declared as pointer to const [constParameterPointer] gimp-dds-3.0.1/ddsread.c:799:63: style: Parameter 'prefix' can be declared as pointer to const [constParameterPointer] gimp-dds-3.0.1/ddswrite.c:1703:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1706:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1712:11: style: gtk_vbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_VERTICAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_vbox_newCalled] gimp-dds-3.0.1/ddswrite.c:1737:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1755:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1776:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1799:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1807:11: style: gtk_hbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_HORIZONTAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_hbox_newCalled] gimp-dds-3.0.1/ddswrite.c:1813:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1821:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1853:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1859:12: style: gtk_vbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_VERTICAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_vbox_newCalled] gimp-dds-3.0.1/ddswrite.c:1879:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1910:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1930:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1941:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1952:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1970:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1981:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:1999:4: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] gimp-dds-3.0.1/ddswrite.c:479:10: style: Condition '!save_dialog(image_id,drawable_id)' is always true [knownConditionTrueFalse] gimp-dds-3.0.1/ddswrite.c:2018:12: note: Assignment 'runme=0', assigned value is 0 gimp-dds-3.0.1/ddswrite.c:479:22: note: Calling function 'save_dialog' returns 0 gimp-dds-3.0.1/ddswrite.c:479:10: note: Condition '!save_dialog(image_id,drawable_id)' is always true gimp-dds-3.0.1/ddswrite.c:529:11: style: Condition 'rc' is always true [knownConditionTrueFalse] gimp-dds-3.0.1/ddswrite.c:525:20: note: Calling function 'write_image' returns 1 gimp-dds-3.0.1/ddswrite.c:525:20: note: Assignment 'rc=write_image(fp,image_id,drawable_id)', assigned value is 1 gimp-dds-3.0.1/ddswrite.c:529:11: note: Condition 'rc' is always true gimp-dds-3.0.1/ddswrite.c:1836:38: style: Condition 'dds_write_vals.transindex>=0' is always true [knownConditionTrueFalse] gimp-dds-3.0.1/ddswrite.c:1832:38: note: Assuming that condition 'dds_write_vals.transindex<0' is not redundant gimp-dds-3.0.1/ddswrite.c:1836:38: note: Condition 'dds_write_vals.transindex>=0' is always true gimp-dds-3.0.1/ddswrite.c:1679:49: style:inconclusive: Function 'save_dialog' argument 2 names different: declaration 'drawable' definition 'drawable_id'. [funcArgNamesDifferent] gimp-dds-3.0.1/ddswrite.c:41:49: note: Function 'save_dialog' argument 2 names different: declaration 'drawable' definition 'drawable_id'. gimp-dds-3.0.1/ddswrite.c:1679:49: note: Function 'save_dialog' argument 2 names different: declaration 'drawable' definition 'drawable_id'. gimp-dds-3.0.1/ddswrite.c:453:36: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] gimp-dds-3.0.1/ddswrite.c:579:63: style: Parameter 'src' can be declared as pointer to const [constParameterPointer] gimp-dds-3.0.1/ddswrite.c:581:43: style: Parameter 'palette' can be declared as pointer to const [constParameterPointer] gimp-dds-3.0.1/ddswrite.c:1094:12: style: Variable 'cmap' can be declared as pointer to const [constVariablePointer] gimp-dds-3.0.1/ddswrite.c:1096:18: style: Variable 'zero' can be declared as const array [constVariable] gimp-dds-3.0.1/ddswrite.c:1399:14: error: Uninitialized variable: hdr10 [uninitvar] gimp-dds-3.0.1/ddswrite.c:745:14: style: Variable 'flags' is assigned a value that is never used. [unreadVariable] diff: DONE