2022-06-27 13:16 ftp://ftp.de.debian.org/debian/pool/main/f/flac/flac_1.3.4.orig.tar.xz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j2 platform: Linux-5.4.0-110-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 cppcheck: head 2.8 head-info: 88bf11a (2022-06-27 14:19:19 +0200) count: 154 155 elapsed-time: 46.8 71.0 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: flac-1.3.4/examples/cpp/decode/file/main.cpp:68:2: style: Class 'OurDecoder' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] flac-1.3.4/microbench/util.c:189:9: error: Uninitialized variable: times [uninitvar] flac-1.3.4/microbench/util.c:186:17: note: Assuming condition is false flac-1.3.4/microbench/util.c:189:9: note: Uninitialized variable: times flac-1.3.4/oss-fuzz/fuzzing/datasource/datasource.hpp:121:21: warning: Member variable 'Datasource::data' is not assigned a value in 'Datasource::operator='. [operatorEqVarError] flac-1.3.4/oss-fuzz/fuzzing/datasource/datasource.hpp:121:21: warning: Member variable 'Datasource::idx' is not assigned a value in 'Datasource::operator='. [operatorEqVarError] flac-1.3.4/oss-fuzz/fuzzing/datasource/datasource.hpp:121:21: warning: Member variable 'Datasource::left' is not assigned a value in 'Datasource::operator='. [operatorEqVarError] flac-1.3.4/oss-fuzz/fuzz-encoder.cc:21:17: style: Class 'FuzzerStream' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] flac-1.3.4/oss-fuzz/fuzz-decoder.cc:41:17: style: Class 'FuzzerStream' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] flac-1.3.4/src/flac/decode.c:289:56: style:inconclusive: Function 'DecoderSession_init_decoder' argument 1 names different: declaration 'd' definition 'decoder_session'. [funcArgNamesDifferent] flac-1.3.4/src/flac/decode.c:103:63: note: Function 'DecoderSession_init_decoder' argument 1 names different: declaration 'd' definition 'decoder_session'. flac-1.3.4/src/flac/decode.c:289:56: note: Function 'DecoderSession_init_decoder' argument 1 names different: declaration 'd' definition 'decoder_session'. flac-1.3.4/src/flac/encode.c:1292:37: portability: Undefined behaviour, when 'lookahead_length' is 65537 the pointer arithmetic 'ubuffer.u8+lookahead_length' is out of bounds. [pointerOutOfBoundsCond] flac-1.3.4/src/flac/encode.c:1289:27: note: Assuming that condition 'lookahead_length>0' is not redundant flac-1.3.4/src/flac/encode.c:1292:37: note: Pointer arithmetic overflow flac-1.3.4/src/flac/encode.c:2361:184: style: Parameter 'channel_map' can be declared as pointer to const [constParameter] flac-1.3.4/src/flac/encode.c:1637:37: style: Variable 'fse_state' is assigned a value that is never used. [unreadVariable] flac-1.3.4/src/flac/encode.c:2682:27: style: Variable 'state_string' is assigned a value that is never used. [unreadVariable] flac-1.3.4/src/flac/utils.c:194:12: style: The comparison 'width <= 0' is always true. [knownConditionTrueFalse] flac-1.3.4/src/flac/utils.c:182:14: note: 'width' is assigned value '0' here. flac-1.3.4/src/flac/utils.c:194:12: note: The comparison 'width <= 0' is always true. flac-1.3.4/src/libFLAC++/stream_decoder.cpp:176:207: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/libFLAC++/stream_decoder.cpp:182:211: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/libFLAC++/stream_decoder.cpp:350:130: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/libFLAC++/stream_decoder.cpp:356:134: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/libFLAC++/stream_decoder.cpp:367:134: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/libFLAC++/stream_decoder.cpp:373:138: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/libFLAC++/stream_encoder.cpp:346:141: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/libFLAC++/stream_encoder.cpp:352:161: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/libFLAC++/stream_encoder.cpp:458:96: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/libFLAC++/stream_encoder.cpp:464:100: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/libFLAC++/stream_encoder.cpp:475:100: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/libFLAC++/stream_encoder.cpp:481:104: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/libFLAC/bitreader.c:318:84: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] flac-1.3.4/src/libFLAC/bitreader.c:327:76: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] flac-1.3.4/src/libFLAC/bitwriter.c:204:83: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] flac-1.3.4/src/libFLAC/bitwriter.c:210:68: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] flac-1.3.4/src/libFLAC/fixed.c:222:33: error: Array 'data[0]' accessed at index -1, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:223:33: error: Array 'data[0]' accessed at index -1, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:223:44: error: Array 'data[0]' accessed at index -2, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:224:49: error: Array 'data[0]' accessed at index -2, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:224:60: error: Array 'data[0]' accessed at index -3, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:225:49: error: Array 'data[0]' accessed at index -2, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:225:62: error: Array 'data[0]' accessed at index -3, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:225:73: error: Array 'data[0]' accessed at index -4, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:280:33: error: Array 'data[0]' accessed at index -1, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:281:33: error: Array 'data[0]' accessed at index -1, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:281:44: error: Array 'data[0]' accessed at index -2, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:282:49: error: Array 'data[0]' accessed at index -2, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:282:60: error: Array 'data[0]' accessed at index -3, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:283:49: error: Array 'data[0]' accessed at index -2, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:283:62: error: Array 'data[0]' accessed at index -3, which is out of bounds. [negativeIndex] flac-1.3.4/src/libFLAC/fixed.c:283:73: error: Array 'data[0]' accessed at index -4, which is out of bounds. [negativeIndex] flac-1.3.4/src/flac/main.c:663:18: warning: Possible null pointer dereference: long_option [nullPointer] flac-1.3.4/src/flac/main.c:633:46: note: Calling function 'parse_option', 2nd argument '0' value is 0 flac-1.3.4/src/flac/main.c:663:18: note: Null pointer dereference flac-1.3.4/src/libFLAC/metadata_iterators.c:658:94: error: There is an unknown macro here somewhere. Configuration is required. If ; is a macro then please configure it. [unknownMacro] flac-1.3.4/src/libFLAC/metadata_object.c:1361:23: warning: Either the condition 'eq==NULL' is redundant or there is overflow in pointer subtraction. [nullPointerArithmeticRedundantCheck] flac-1.3.4/src/libFLAC/metadata_object.c:1364:10: note: Assuming that condition 'eq==NULL' is not redundant flac-1.3.4/src/libFLAC/metadata_object.c:1361:23: note: Null pointer subtraction flac-1.3.4/src/libFLAC/metadata_object.c:1056:119: style: Parameter 'sample_numbers' can be declared as const array [constParameter] flac-1.3.4/src/libFLAC/ogg_encoder_aspect.c:213:44: style: Same expression 'is_metadata' found multiple times in chain of '&&' operators because 'is_metadata' and 'samples==0' represent the same value. [knownConditionTrueFalse] flac-1.3.4/src/libFLAC/ogg_encoder_aspect.c:118:42: note: 'is_metadata' is assigned value 'samples==0' here. flac-1.3.4/src/libFLAC/ogg_encoder_aspect.c:213:44: note: Same expression 'is_metadata' found multiple times in chain of '&&' operators because 'is_metadata' and 'samples==0' represent the same value. flac-1.3.4/src/libFLAC/stream_decoder.c:3032:18: style: Variable 'pos' is assigned a value that is never used. [unreadVariable] flac-1.3.4/src/libFLAC/stream_encoder.c:3274:5: style: The if condition is the same as the previous if condition [duplicateCondition] flac-1.3.4/src/libFLAC/stream_encoder.c:3248:5: note: First condition flac-1.3.4/src/libFLAC/stream_encoder.c:3274:5: note: Second condition flac-1.3.4/src/libFLAC/stream_encoder.c:2871:7: style: Variable 'xx' is reassigned a value before the old one has been used. [redundantAssignment] flac-1.3.4/src/libFLAC/stream_encoder.c:2870:30: note: xx is assigned flac-1.3.4/src/libFLAC/stream_encoder.c:2871:7: note: xx is overwritten flac-1.3.4/src/libFLAC/stream_encoder.c:2214:27: style: The comparison 'OVERREAD_ == 1' is always true. [knownConditionTrueFalse] flac-1.3.4/src/libFLAC/stream_encoder.c:497:35: note: 'OVERREAD_' is assigned value '1' here. flac-1.3.4/src/libFLAC/stream_encoder.c:2214:27: note: The comparison 'OVERREAD_ == 1' is always true. flac-1.3.4/src/libFLAC/stream_encoder.c:2273:28: style: The comparison 'OVERREAD_ == 1' is always true. [knownConditionTrueFalse] flac-1.3.4/src/libFLAC/stream_encoder.c:497:35: note: 'OVERREAD_' is assigned value '1' here. flac-1.3.4/src/libFLAC/stream_encoder.c:2273:28: note: The comparison 'OVERREAD_ == 1' is always true. flac-1.3.4/src/libFLAC/stream_encoder.c:2302:28: style: The comparison 'OVERREAD_ == 1' is always true. [knownConditionTrueFalse] flac-1.3.4/src/libFLAC/stream_encoder.c:497:35: note: 'OVERREAD_' is assigned value '1' here. flac-1.3.4/src/libFLAC/stream_encoder.c:2302:28: note: The comparison 'OVERREAD_ == 1' is always true. flac-1.3.4/src/libFLAC/stream_encoder.c:91:20: style: struct member 'verify_output::data' is never used. [unusedStructMember] flac-1.3.4/src/libFLAC/stream_encoder.c:92:11: style: struct member 'verify_output::capacity' is never used. [unusedStructMember] flac-1.3.4/src/libFLAC/stream_encoder.c:93:11: style: struct member 'verify_output::bytes' is never used. [unusedStructMember] flac-1.3.4/src/libFLAC/stream_encoder.c:410:24: style: struct member 'Anonymous0::decoder' is never used. [unusedStructMember] flac-1.3.4/src/libFLAC/stream_encoder.c:411:20: style: struct member 'Anonymous0::state_hint' is never used. [unusedStructMember] flac-1.3.4/src/libFLAC/stream_encoder.c:414:17: style: struct member 'Anonymous0::output' is never used. [unusedStructMember] flac-1.3.4/src/libFLAC/stream_encoder.c:417:13: style: struct member 'Anonymous1::frame_number' is never used. [unusedStructMember] flac-1.3.4/src/libFLAC/stream_encoder.c:418:13: style: struct member 'Anonymous1::channel' is never used. [unusedStructMember] flac-1.3.4/src/libFLAC/stream_encoder.c:419:13: style: struct member 'Anonymous1::sample' is never used. [unusedStructMember] flac-1.3.4/src/libFLAC/stream_encoder.c:2879:30: style: Variable 'xx' is assigned a value that is never used. [unreadVariable] flac-1.3.4/src/libFLAC/stream_encoder.c:2882:29: style: Variable 'x' is assigned a value that is never used. [unreadVariable] flac-1.3.4/src/libFLAC/stream_encoder.c:4240:35: style: Variable 'residual_sample' is assigned a value that is never used. [unreadVariable] flac-1.3.4/src/libFLAC/windows_unicode_filenames.c:135:10: style: Obsolescent function 'utime' called. It is recommended to use 'utimensat' instead. [prohibitedutimeCalled] flac-1.3.4/src/metaflac/operations.c:507:2: warning: Either the condition '0==padding' is redundant or there is possible null pointer dereference: padding. [nullPointerRedundantCheck] flac-1.3.4/src/metaflac/operations.c:504:7: note: Assuming that condition '0==padding' is not redundant flac-1.3.4/src/metaflac/operations.c:507:2: note: Null pointer dereference flac-1.3.4/src/metaflac/operations_shorthand_vorbiscomment.c:208:3: warning: Either the condition '0==(data=malloc(size+1))' is redundant or there is possible null pointer dereference: data. [nullPointerRedundantCheck] flac-1.3.4/src/metaflac/operations_shorthand_vorbiscomment.c:206:8: note: Assuming that condition '0==(data=malloc(size+1))' is not redundant flac-1.3.4/src/metaflac/operations_shorthand_vorbiscomment.c:208:3: note: Null pointer dereference flac-1.3.4/src/plugin_xmms/configure.c:225:42: style:inconclusive: Function 'configure_destroy' argument 1 names different: declaration 'w' definition 'widget'. [funcArgNamesDifferent] flac-1.3.4/src/plugin_xmms/configure.c:133:43: note: Function 'configure_destroy' argument 1 names different: declaration 'w' definition 'widget'. flac-1.3.4/src/plugin_xmms/configure.c:225:42: note: Function 'configure_destroy' argument 1 names different: declaration 'w' definition 'widget'. flac-1.3.4/src/plugin_xmms/http.c:395:14: style: Obsolescent function 'gethostbyname' called. It is recommended to use 'getaddrinfo' instead. [prohibitedgethostbynameCalled] flac-1.3.4/src/plugin_xmms/http.c:88:15: style: Variable 'tbl' can be declared as const array [constVariable] flac-1.3.4/src/plugin_xmms/plugin.c:170:12: portability: Non reentrant function 'getpwent' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwent_r'. [prohibitedgetpwentCalled] flac-1.3.4/src/plugin_xmms/plugin.c:394:66: style:inconclusive: Function 'FLAC_XMMS__get_song_info' argument 3 names different: declaration 'length' definition 'length_in_msec'. [funcArgNamesDifferent] flac-1.3.4/src/plugin_xmms/plugin.c:89:73: note: Function 'FLAC_XMMS__get_song_info' argument 3 names different: declaration 'length' definition 'length_in_msec'. flac-1.3.4/src/plugin_xmms/plugin.c:394:66: note: Function 'FLAC_XMMS__get_song_info' argument 3 names different: declaration 'length' definition 'length_in_msec'. flac-1.3.4/src/plugin_xmms/tag.c:122:2: warning:inconclusive: Possible null pointer dereference: input [nullPointer] flac-1.3.4/src/plugin_xmms/tag.c:105:22: note: Assignment 'input=NULL', assigned value is 0 flac-1.3.4/src/plugin_xmms/tag.c:122:2: note: Null pointer dereference flac-1.3.4/src/plugin_xmms/tag.c:123:6: warning:inconclusive: Possible null pointer dereference: input [nullPointer] flac-1.3.4/src/plugin_xmms/tag.c:105:22: note: Assignment 'input=NULL', assigned value is 0 flac-1.3.4/src/plugin_xmms/tag.c:123:6: note: Null pointer dereference flac-1.3.4/src/metaflac/options.c:131:20: warning: Comparison of a boolean expression with an integer other than 0 or 1. [compareBoolExpressionWithInt] flac-1.3.4/src/metaflac/options.c:131:23: style: Comparing expression of type 'bool' against value 2. Condition is always true. [compareValueOutOfTypeRangeError] flac-1.3.4/src/share/replaygain_synthesis/replaygain_synthesis.c:205:17: style: Variable 'default_dither' can be declared as const array [constVariable] flac-1.3.4/src/share/replaygain_synthesis/replaygain_synthesis.c:254:15: style: Variable 'Sum' is assigned a value that is never used. [unreadVariable] flac-1.3.4/src/share/replaygain_analysis/replaygain_analysis.c:428:17: warning: Either the condition 'num_samples==0' is redundant or there is division by zero at line 428. [zerodivcond] flac-1.3.4/src/share/replaygain_analysis/replaygain_analysis.c:430:22: note: Assuming that condition 'num_samples==0' is not redundant flac-1.3.4/src/share/replaygain_analysis/replaygain_analysis.c:428:20: note: Assignment to 'num_samples/=downsample' flac-1.3.4/src/share/replaygain_analysis/replaygain_analysis.c:419:50: note: Assignment to 'downsample=replaygainfilter->downsample' flac-1.3.4/src/share/replaygain_analysis/replaygain_analysis.c:419:32: note: downsample is assigned 'replaygainfilter->downsample' here. flac-1.3.4/src/share/replaygain_analysis/replaygain_analysis.c:428:17: note: Division by zero flac-1.3.4/src/share/replaygain_analysis/replaygain_analysis.c:520:27: style: Parameter 'Array' can be declared as pointer to const [constParameter] flac-1.3.4/src/share/utf8/charset.c:130:30: style:inconclusive: Function 'utf8_wctomb' argument 2 names different: declaration 'wc' definition 'wc1'. [funcArgNamesDifferent] flac-1.3.4/src/share/utf8/charset.h:28:30: note: Function 'utf8_wctomb' argument 2 names different: declaration 'wc' definition 'wc1'. flac-1.3.4/src/share/utf8/charset.c:130:30: note: Function 'utf8_wctomb' argument 2 names different: declaration 'wc' definition 'wc1'. flac-1.3.4/src/share/utf8/utf8.c:140:7: style: Condition '!c' is always true [knownConditionTrueFalse] flac-1.3.4/src/share/utf8/utf8.c:135:19: note: Assignment 'c=0', assigned value is 0 flac-1.3.4/src/share/utf8/utf8.c:140:7: note: Condition '!c' is always true flac-1.3.4/src/test_libFLAC++/decoders.cpp:129:35: style:inconclusive: Technically the member function 'DecoderCommon::common_write_callback_' can be const. [functionConst] flac-1.3.4/src/test_libFLAC++/decoders.cpp:134:49: note: Technically the member function 'DecoderCommon::common_write_callback_' can be const. flac-1.3.4/src/test_libFLAC++/decoders.cpp:129:35: note: Technically the member function 'DecoderCommon::common_write_callback_' can be const. flac-1.3.4/src/test_libFLAC++/decoders.cpp:127:2: style: Class 'DecoderCommon' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] flac-1.3.4/src/test_libFLAC++/decoders.cpp:183:2: style: Class 'StreamDecoder' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] flac-1.3.4/src/test_libFLAC++/decoders.cpp:347:2: style: Class 'FileDecoder' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] flac-1.3.4/src/test_libFLAC++/encoders.cpp:105:2: style: Class 'StreamEncoder' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] flac-1.3.4/src/test_libFLAC++/encoders.cpp:176:2: style: Class 'FileEncoder' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:132:39: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:139:59: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:144:57: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:147:57: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:184:36: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:191:47: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:202:47: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:223:38: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:224:29: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:229:31: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:230:46: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:1307:31: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:1313:13: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:1975:29: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:1981:18: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:2039:22: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_object.cpp:70:11: style: The scope of the variable 'i' can be reduced. [variableScope] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:59:9: style: Class 'OurFileDecoder' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:207:18: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:307:16: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:312:16: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:317:14: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:533:59: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:571:38: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:572:29: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:577:31: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:578:46: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:925:15: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:1111:15: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:1127:15: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:1138:15: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:1150:15: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:1162:15: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:1175:15: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:1210:15: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:1586:15: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:948:23: style: Variable 'our_current_position' is reassigned a value before the old one has been used. [redundantAssignment] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:879:22: note: our_current_position is assigned flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:948:23: note: our_current_position is overwritten flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:406:112: style: Parameter 'current_block' can be declared as pointer to const [constParameter] flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:2018:23: style: Variable 'our_current_position' is assigned a value that is never used. [unreadVariable] flac-1.3.4/src/test_libFLAC/bitreader.c:53:10: style: struct member 'FLAC__BitReader::buffer' is never used. [unusedStructMember] flac-1.3.4/src/test_libFLAC/bitreader.c:55:11: style: struct member 'FLAC__BitReader::words' is never used. [unusedStructMember] flac-1.3.4/src/test_libFLAC/bitreader.c:56:11: style: struct member 'FLAC__BitReader::bytes' is never used. [unusedStructMember] flac-1.3.4/src/test_libFLAC/bitreader.c:59:11: style: struct member 'FLAC__BitReader::read_crc16' is never used. [unusedStructMember] flac-1.3.4/src/test_libFLAC/bitreader.c:60:11: style: struct member 'FLAC__BitReader::crc16_offset' is never used. [unusedStructMember] flac-1.3.4/src/test_libFLAC/bitreader.c:61:11: style: struct member 'FLAC__BitReader::crc16_align' is never used. [unusedStructMember] flac-1.3.4/src/test_libFLAC/bitreader.c:63:8: style: struct member 'FLAC__BitReader::client_data' is never used. [unusedStructMember] flac-1.3.4/src/test_libFLAC/crc.c:198:3: warning: %i in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] flac-1.3.4/src/test_libFLAC/crc.c:238:3: warning: %i in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] flac-1.3.4/src/test_libFLAC/decoders.c:566:37: style: Variable 'decoder_client_data.ignore_errors' is reassigned a value before the old one has been used. [redundantAssignment] flac-1.3.4/src/test_libFLAC/decoders.c:561:37: note: decoder_client_data.ignore_errors is assigned flac-1.3.4/src/test_libFLAC/decoders.c:566:37: note: decoder_client_data.ignore_errors is overwritten flac-1.3.4/src/test_libFLAC/metadata_manip.c:900:23: style: Variable 'our_current_position' is reassigned a value before the old one has been used. [redundantAssignment] flac-1.3.4/src/test_libFLAC/metadata_manip.c:841:22: note: our_current_position is assigned flac-1.3.4/src/test_libFLAC/metadata_manip.c:900:23: note: our_current_position is overwritten flac-1.3.4/src/test_libFLAC/metadata_manip.c:1913:23: style: Variable 'our_current_position' is assigned a value that is never used. [unreadVariable] flac-1.3.4/src/test_seeking/main.c:306:29: style: Variable 'decoder_client_data.quiet' is reassigned a value before the old one has been used. [redundantAssignment] flac-1.3.4/src/test_seeking/main.c:303:29: note: decoder_client_data.quiet is assigned flac-1.3.4/src/test_seeking/main.c:306:29: note: decoder_client_data.quiet is overwritten flac-1.3.4/src/test_seeking/main.c:376:30: style: Variable 'decoder_client_data.quiet' is reassigned a value before the old one has been used. [redundantAssignment] flac-1.3.4/src/test_seeking/main.c:373:30: note: decoder_client_data.quiet is assigned flac-1.3.4/src/test_seeking/main.c:376:30: note: decoder_client_data.quiet is overwritten flac-1.3.4/src/utils/flacdiff/main.cpp:62:13: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/utils/flacdiff/main.cpp:64:31: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/utils/flacdiff/main.cpp:81:21: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/utils/flacdiff/main.cpp:169:11: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/utils/flacdiff/main.cpp:173:11: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/utils/flacdiff/main.cpp:177:11: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/utils/flactimer/main.cpp:41:34: style: Assignment of function parameter has no effect outside the function. [uselessAssignmentArg] flac-1.3.4/src/utils/flactimer/main.cpp:104:15: style: C-style pointer casting [cstyleCast] flac-1.3.4/src/utils/flactimer/main.cpp:41:39: style: Variable 'nsec' is assigned a value that is never used. [unreadVariable] diff: head flac-1.3.4/src/flac/encode.c:2361:184: style: Parameter 'channel_map' can be declared as pointer to const [constParameter] 2.8 flac-1.3.4/src/flac/encode.c:2361:184: style: Parameter 'channel_map' can be declared with const [constParameter] 2.8 flac-1.3.4/src/flac/encode.c:2361:38: style: Parameter 'dest' can be declared with const [constParameter] head flac-1.3.4/src/libFLAC/metadata_object.c:1056:119: style: Parameter 'sample_numbers' can be declared as const array [constParameter] 2.8 flac-1.3.4/src/libFLAC/metadata_object.c:1056:119: style: Parameter 'sample_numbers' can be declared with const [constParameter] head flac-1.3.4/src/plugin_xmms/http.c:88:15: style: Variable 'tbl' can be declared as const array [constVariable] 2.8 flac-1.3.4/src/plugin_xmms/http.c:88:15: style: Variable 'tbl' can be declared with const [constVariable] head flac-1.3.4/src/share/replaygain_analysis/replaygain_analysis.c:520:27: style: Parameter 'Array' can be declared as pointer to const [constParameter] 2.8 flac-1.3.4/src/share/replaygain_analysis/replaygain_analysis.c:520:27: style: Parameter 'Array' can be declared with const [constParameter] head flac-1.3.4/src/share/replaygain_synthesis/replaygain_synthesis.c:205:17: style: Variable 'default_dither' can be declared as const array [constVariable] 2.8 flac-1.3.4/src/share/replaygain_synthesis/replaygain_synthesis.c:205:17: style: Variable 'default_dither' can be declared with const [constVariable] head flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:406:112: style: Parameter 'current_block' can be declared as pointer to const [constParameter] 2.8 flac-1.3.4/src/test_libFLAC++/metadata_manip.cpp:406:112: style: Parameter 'current_block' can be declared with const [constParameter] DONE