2022-06-27 10:07 ftp://ftp.de.debian.org/debian/pool/main/e/etherape/etherape_0.9.20.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --inline-suppr --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j4 platform: Linux-5.10.0-15-amd64-x86_64-with-glibc2.31 python: 3.9.2 client-version: 1.3.25 compiler: g++ (Debian 10.2.1-6) 10.2.1 20210110 cppcheck: head 2.8 head-info: 242afc3 (2022-06-25 21:42:55 +0200) count: 44 44 elapsed-time: 1.3 1.1 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: etherape-0.9.20/src/export.c:50:11: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] etherape-0.9.20/src/datastructs.c:382:17: portability: Non reentrant function 'getservent' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getservent_r'. [prohibitedgetserventCalled] etherape-0.9.20/src/datastructs.c:299:13: style: Variable 'cur' is assigned a value that is never used. [unreadVariable] etherape-0.9.20/src/capture/capctl.c:139:8: portability: Non reentrant function 'getpwnam' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwnam_r'. [prohibitedgetpwnamCalled] etherape-0.9.20/src/names/dns.c:56:35: style:inconclusive: Function 'dns_lookup' argument 1 names different: declaration 'address' definition 'addr'. [funcArgNamesDifferent] etherape-0.9.20/src/names/dns.h:31:35: note: Function 'dns_lookup' argument 1 names different: declaration 'address' definition 'addr'. etherape-0.9.20/src/names/dns.c:56:35: note: Function 'dns_lookup' argument 1 names different: declaration 'address' definition 'addr'. etherape-0.9.20/src/info_windows.c:622:62: style:inconclusive: Function 'on_delete_protocol_window' argument 2 names different: declaration 'e' definition 'evt'. [funcArgNamesDifferent] etherape-0.9.20/src/info_windows.h:37:62: note: Function 'on_delete_protocol_window' argument 2 names different: declaration 'e' definition 'evt'. etherape-0.9.20/src/info_windows.c:622:62: note: Function 'on_delete_protocol_window' argument 2 names different: declaration 'e' definition 'evt'. etherape-0.9.20/src/info_windows.c:652:75: style:inconclusive: Function 'on_prot_list_select_row' argument 3 names different: declaration 'ud' definition 'user_data'. [funcArgNamesDifferent] etherape-0.9.20/src/info_windows.h:36:43: note: Function 'on_prot_list_select_row' argument 3 names different: declaration 'ud' definition 'user_data'. etherape-0.9.20/src/info_windows.c:652:75: note: Function 'on_prot_list_select_row' argument 3 names different: declaration 'ud' definition 'user_data'. etherape-0.9.20/src/info_windows.c:920:53: style:inconclusive: Function 'update_node_protocols_window' argument 1 names different: declaration 'node_window' definition 'window'. [funcArgNamesDifferent] etherape-0.9.20/src/info_windows.c:82:53: note: Function 'update_node_protocols_window' argument 1 names different: declaration 'node_window' definition 'window'. etherape-0.9.20/src/info_windows.c:920:53: note: Function 'update_node_protocols_window' argument 1 names different: declaration 'node_window' definition 'window'. etherape-0.9.20/src/names/names_netbios.c:190:62: style:inconclusive: Function 'process_netbios_name' argument 2 names different: declaration 'name_ret' definition 'outname'. [funcArgNamesDifferent] etherape-0.9.20/src/names/names_netbios.c:91:62: note: Function 'process_netbios_name' argument 2 names different: declaration 'name_ret' definition 'outname'. etherape-0.9.20/src/names/names_netbios.c:190:62: note: Function 'process_netbios_name' argument 2 names different: declaration 'name_ret' definition 'outname'. etherape-0.9.20/src/names/names_netbios.c:190:78: style:inconclusive: Function 'process_netbios_name' argument 3 names different: declaration 'maxname' definition 'outname_size'. [funcArgNamesDifferent] etherape-0.9.20/src/names/names_netbios.c:91:79: note: Function 'process_netbios_name' argument 3 names different: declaration 'maxname' definition 'outname_size'. etherape-0.9.20/src/names/names_netbios.c:190:78: note: Function 'process_netbios_name' argument 3 names different: declaration 'maxname' definition 'outname_size'. etherape-0.9.20/src/names/thread_resolve.c:112:9: style: Condition '!request_stop_thread' is always true [knownConditionTrueFalse] etherape-0.9.20/src/names/thread_resolve.c:109:10: note: Assuming that condition '!request_stop_thread' is not redundant etherape-0.9.20/src/names/thread_resolve.c:112:9: note: Condition '!request_stop_thread' is always true etherape-0.9.20/src/names/thread_resolve.c:307:38: style:inconclusive: Function 'thread_lookup' argument 1 names different: declaration 'address' definition 'ip'. [funcArgNamesDifferent] etherape-0.9.20/src/names/thread_resolve.h:27:38: note: Function 'thread_lookup' argument 1 names different: declaration 'address' definition 'ip'. etherape-0.9.20/src/names/thread_resolve.c:307:38: note: Function 'thread_lookup' argument 1 names different: declaration 'address' definition 'ip'. etherape-0.9.20/src/diagram.c:1648:18: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] etherape-0.9.20/src/diagram.c:1694:18: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] etherape-0.9.20/src/diagram.c:1489:12: style: Variable 'sig_id' is reassigned a value before the old one has been used. [redundantAssignment] etherape-0.9.20/src/diagram.c:1484:12: note: sig_id is assigned etherape-0.9.20/src/diagram.c:1489:12: note: sig_id is overwritten etherape-0.9.20/src/diagram.c:243:30: style:inconclusive: Function 'ask_reposition' argument 1 names different: declaration 'refresh_font' definition 'r_font'. [funcArgNamesDifferent] etherape-0.9.20/src/diagram.h:36:30: note: Function 'ask_reposition' argument 1 names different: declaration 'refresh_font' definition 'r_font'. etherape-0.9.20/src/diagram.c:243:30: note: Function 'ask_reposition' argument 1 names different: declaration 'refresh_font' definition 'r_font'. etherape-0.9.20/src/diagram.c:495:47: style:inconclusive: Function 'canvas_node_delete' argument 1 names different: declaration 'cn' definition 'canvas_node'. [funcArgNamesDifferent] etherape-0.9.20/src/diagram.c:70:47: note: Function 'canvas_node_delete' argument 1 names different: declaration 'cn' definition 'canvas_node'. etherape-0.9.20/src/diagram.c:495:47: note: Function 'canvas_node_delete' argument 1 names different: declaration 'cn' definition 'canvas_node'. etherape-0.9.20/src/diagram.c:996:43: style:inconclusive: Function 'canvas_node_update' argument 1 names different: declaration 'ether_addr' definition 'node_id'. [funcArgNamesDifferent] etherape-0.9.20/src/diagram.c:71:44: note: Function 'canvas_node_update' argument 1 names different: declaration 'ether_addr' definition 'node_id'. etherape-0.9.20/src/diagram.c:996:43: note: Function 'canvas_node_update' argument 1 names different: declaration 'ether_addr' definition 'node_id'. etherape-0.9.20/src/diagram.c:1159:65: style:inconclusive: Function 'add_ordered_node' argument 2 names different: declaration 'canvas_node' definition 'node'. [funcArgNamesDifferent] etherape-0.9.20/src/diagram.c:180:45: note: Function 'add_ordered_node' argument 2 names different: declaration 'canvas_node' definition 'node'. etherape-0.9.20/src/diagram.c:1159:65: note: Function 'add_ordered_node' argument 2 names different: declaration 'canvas_node' definition 'node'. etherape-0.9.20/src/diagram.c:1281:61: style:inconclusive: Function 'reposition_canvas_nodes_prep' argument 3 names different: declaration 'data' definition 'rdata'. [funcArgNamesDifferent] etherape-0.9.20/src/diagram.c:190:61: note: Function 'reposition_canvas_nodes_prep' argument 3 names different: declaration 'data' definition 'rdata'. etherape-0.9.20/src/diagram.c:1281:61: note: Function 'reposition_canvas_nodes_prep' argument 3 names different: declaration 'data' definition 'rdata'. etherape-0.9.20/src/diagram.c:1596:52: style:inconclusive: Function 'draw_oneside_link' argument 5 names different: declaration 'link_data' definition 'link_stats'. [funcArgNamesDifferent] etherape-0.9.20/src/diagram.c:209:52: note: Function 'draw_oneside_link' argument 5 names different: declaration 'link_data' definition 'link_stats'. etherape-0.9.20/src/diagram.c:1596:52: note: Function 'draw_oneside_link' argument 5 names different: declaration 'link_data' definition 'link_stats'. etherape-0.9.20/src/names/names.c:535:19: style: Array index 'i' is used before limits check. [arrayIndexThenCheck] etherape-0.9.20/src/names/names.c:590:19: style: Array index 'i' is used before limits check. [arrayIndexThenCheck] etherape-0.9.20/src/names/names.c:609:35: style:inconclusive: Function 'add_name' argument 1 names different: declaration 'numeric' definition 'numeric_name'. [funcArgNamesDifferent] etherape-0.9.20/src/names/names.c:117:35: note: Function 'add_name' argument 1 names different: declaration 'numeric' definition 'numeric_name'. etherape-0.9.20/src/names/names.c:609:35: note: Function 'add_name' argument 1 names different: declaration 'numeric' definition 'numeric_name'. etherape-0.9.20/src/names/names.c:609:62: style:inconclusive: Function 'add_name' argument 2 names different: declaration 'resolved' definition 'resolved_name'. [funcArgNamesDifferent] etherape-0.9.20/src/names/names.c:117:57: note: Function 'add_name' argument 2 names different: declaration 'resolved' definition 'resolved_name'. etherape-0.9.20/src/names/names.c:609:62: note: Function 'add_name' argument 2 names different: declaration 'resolved' definition 'resolved_name'. etherape-0.9.20/src/names/names.c:583:9: style: Variable 'len' is assigned a value that is never used. [unreadVariable] etherape-0.9.20/src/node_windows.c:407:14: style: Local variable 'nodes_check' shadows outer variable [shadowVariable] etherape-0.9.20/src/node_windows.c:43:26: note: Shadowed declaration etherape-0.9.20/src/node_windows.c:407:14: note: Shadow variable etherape-0.9.20/src/preferences.c:387:38: style:inconclusive: Function 'free_config' argument 1 names different: declaration 't' definition 'p'. [funcArgNamesDifferent] etherape-0.9.20/src/preferences.h:102:38: note: Function 'free_config' argument 1 names different: declaration 't' definition 'p'. etherape-0.9.20/src/preferences.c:387:38: note: Function 'free_config' argument 1 names different: declaration 't' definition 'p'. etherape-0.9.20/src/stats/node_id.c:40:39: style:inconclusive: Function 'node_id_compare' argument 1 names different: declaration 'a' definition 'na'. [funcArgNamesDifferent] etherape-0.9.20/src/stats/node_id.h:38:39: note: Function 'node_id_compare' argument 1 names different: declaration 'a' definition 'na'. etherape-0.9.20/src/stats/node_id.c:40:39: note: Function 'node_id_compare' argument 1 names different: declaration 'a' definition 'na'. etherape-0.9.20/src/stats/node_id.c:40:60: style:inconclusive: Function 'node_id_compare' argument 2 names different: declaration 'b' definition 'nb'. [funcArgNamesDifferent] etherape-0.9.20/src/stats/node_id.h:38:59: note: Function 'node_id_compare' argument 2 names different: declaration 'b' definition 'nb'. etherape-0.9.20/src/stats/node_id.c:40:60: note: Function 'node_id_compare' argument 2 names different: declaration 'b' definition 'nb'. etherape-0.9.20/src/stats/node.c:661:45: style:inconclusive: Function 'parse_nodeset_spec_list' argument 1 names different: declaration 's' definition 'orig_s'. [funcArgNamesDifferent] etherape-0.9.20/src/stats/node.h:81:45: note: Function 'parse_nodeset_spec_list' argument 1 names different: declaration 's' definition 'orig_s'. etherape-0.9.20/src/stats/node.c:661:45: note: Function 'parse_nodeset_spec_list' argument 1 names different: declaration 's' definition 'orig_s'. etherape-0.9.20/src/stats/traffic_stats.c:164:65: style:inconclusive: Function 'traffic_stats_update' argument 2 names different: declaration 'pkt_expire_time' definition 'avg_time'. [funcArgNamesDifferent] etherape-0.9.20/src/stats/traffic_stats.h:42:65: note: Function 'traffic_stats_update' argument 2 names different: declaration 'pkt_expire_time' definition 'avg_time'. etherape-0.9.20/src/stats/traffic_stats.c:164:65: note: Function 'traffic_stats_update' argument 2 names different: declaration 'pkt_expire_time' definition 'avg_time'. etherape-0.9.20/src/ui_utils.c:146:11: portability: Non reentrant function 'getpwuid' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwuid_r'. [prohibitedgetpwuidCalled] etherape-0.9.20/src/ui_utils.c:42:33: style:inconclusive: Function 'update_gtklabel' argument 1 names different: declaration 'wnd' definition 'window'. [funcArgNamesDifferent] etherape-0.9.20/src/ui_utils.h:42:33: note: Function 'update_gtklabel' argument 1 names different: declaration 'wnd' definition 'window'. etherape-0.9.20/src/ui_utils.c:42:33: note: Function 'update_gtklabel' argument 1 names different: declaration 'wnd' definition 'window'. etherape-0.9.20/src/ui_utils.c:53:29: style:inconclusive: Function 'show_widget' argument 1 names different: declaration 'wnd' definition 'window'. [funcArgNamesDifferent] etherape-0.9.20/src/ui_utils.h:45:29: note: Function 'show_widget' argument 1 names different: declaration 'wnd' definition 'window'. etherape-0.9.20/src/ui_utils.c:53:29: note: Function 'show_widget' argument 1 names different: declaration 'wnd' definition 'window'. etherape-0.9.20/src/ui_utils.c:58:29: style:inconclusive: Function 'hide_widget' argument 1 names different: declaration 'wnd' definition 'window'. [funcArgNamesDifferent] etherape-0.9.20/src/ui_utils.h:46:29: note: Function 'hide_widget' argument 1 names different: declaration 'wnd' definition 'window'. etherape-0.9.20/src/ui_utils.c:58:29: note: Function 'hide_widget' argument 1 names different: declaration 'wnd' definition 'window'. etherape-0.9.20/src/stats/protocols.c:161:53: style:inconclusive: Function 'protocol_stack_avg' argument 2 names different: declaration 'avg_usecs' definition 'avgtime'. [funcArgNamesDifferent] etherape-0.9.20/src/stats/protocols.h:57:53: note: Function 'protocol_stack_avg' argument 2 names different: declaration 'avg_usecs' definition 'avgtime'. etherape-0.9.20/src/stats/protocols.c:161:53: note: Function 'protocol_stack_avg' argument 2 names different: declaration 'avg_usecs' definition 'avgtime'. etherape-0.9.20/src/stats/decode_proto.c:1584:9: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] etherape-0.9.20/src/stats/decode_proto.c:1587:11: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] etherape-0.9.20/src/stats/decode_proto.c:1591:9: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] etherape-0.9.20/src/stats/decode_proto.c:1597:9: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] etherape-0.9.20/src/stats/decode_proto.c:248:30: style:inconclusive: Function 'packet_acquired' argument 1 names different: declaration 'packet' definition 'cap_bytes'. [funcArgNamesDifferent] etherape-0.9.20/src/stats/decode_proto.h:27:30: note: Function 'packet_acquired' argument 1 names different: declaration 'packet' definition 'cap_bytes'. etherape-0.9.20/src/stats/decode_proto.c:248:30: note: Function 'packet_acquired' argument 1 names different: declaration 'packet' definition 'cap_bytes'. etherape-0.9.20/src/stats/decode_proto.c:248:47: style:inconclusive: Function 'packet_acquired' argument 2 names different: declaration 'raw_size' definition 'cap_size'. [funcArgNamesDifferent] etherape-0.9.20/src/stats/decode_proto.h:27:44: note: Function 'packet_acquired' argument 2 names different: declaration 'raw_size' definition 'cap_size'. etherape-0.9.20/src/stats/decode_proto.c:248:47: note: Function 'packet_acquired' argument 2 names different: declaration 'raw_size' definition 'cap_size'. etherape-0.9.20/src/stats/decode_proto.c:248:63: style:inconclusive: Function 'packet_acquired' argument 3 names different: declaration 'pkt_size' definition 'orig_size'. [funcArgNamesDifferent] etherape-0.9.20/src/stats/decode_proto.h:27:60: note: Function 'packet_acquired' argument 3 names different: declaration 'pkt_size' definition 'orig_size'. etherape-0.9.20/src/stats/decode_proto.c:248:63: note: Function 'packet_acquired' argument 3 names different: declaration 'pkt_size' definition 'orig_size'. diff: DONE