2025-08-30 12:02 ftp://ftp.de.debian.org/debian/pool/main/e/endless-sky/endless-sky_0.10.14.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=bsd --library=sdl --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j1 platform: Linux-6.8.0-79-generic-x86_64-with-glibc2.39 python: 3.12.3 client-version: 1.3.67 compiler: g++ (Ubuntu 14.2.0-4ubuntu2~24.04) 14.2.0 cppcheck: head 2.18.0 head-info: d9a054c (2025-08-30 13:09:31 +0200) count: 838 849 elapsed-time: 276.3 286.5 head-timing-info: old-timing-info: head results: endless-sky-0.10.14/source/WeightedList.h:90:41: debug: Function::addArguments found argument 't' with varid 0. [varid0] endless-sky-0.10.14/source/AI.cpp:4340:40: debug: Function::addArguments found argument 'other' with varid 0. [varid0] endless-sky-0.10.14/source/AI.cpp:4347:49: debug: Function::addArguments found argument 'other' with varid 0. [varid0] endless-sky-0.10.14/source/AI.cpp:4357:36: debug: Function::addArguments found argument 'other' with varid 0. [varid0] endless-sky-0.10.14/source/AI.cpp:4417:33: debug: Function::addArguments found argument 'lhs' with varid 0. [varid0] endless-sky-0.10.14/source/WeightedList.h:90:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable T [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/WeightedList.h:153:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable choices [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/WeightedList.h:169:2: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable total [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:450:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable type [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:467:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ATTACK [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:478:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MINE [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:489:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MOVE_TO [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:557:72: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ATTACK [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:1367:103: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable HARVEST [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:1457:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ATTACK [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:1718:95: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MOVE_TO [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:1877:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MOVE_TO [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:2572:83: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:3842:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FINISH_OFF [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:4340:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable other [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:4986:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MOVE_TO [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:5092:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MOVE_TO [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/AI.cpp:3843:40: style:inconclusive: Boolean expression 'disabledOverride' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] endless-sky-0.10.14/source/Ship.h:77:3: warning:inconclusive: Member variable 'Bay::ship' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] endless-sky-0.10.14/source/Messages.h:45:3: warning: Member variable 'Entry::step' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/Messages.h:45:3: warning: Member variable 'Entry::importance' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/Minable.h:117:2: warning: Member variable 'Minable::theta' is not initialized. [uninitMemberVarPrivate] endless-sky-0.10.14/source/Minable.h:119:2: warning: Member variable 'Minable::eccentricity' is not initialized. [uninitMemberVarPrivate] endless-sky-0.10.14/source/Minable.h:122:2: warning: Member variable 'Minable::angularMomentum' is not initialized. [uninitMemberVarPrivate] endless-sky-0.10.14/source/Minable.h:125:2: warning: Member variable 'Minable::orbitScale' is not initialized. [uninitMemberVarPrivate] endless-sky-0.10.14/source/Minable.h:127:2: warning: Member variable 'Minable::rotation' is not initialized. [uninitMemberVarPrivate] endless-sky-0.10.14/source/Minable.h:133:2: warning: Member variable 'Minable::radius' is not initialized. [uninitMemberVarPrivate] endless-sky-0.10.14/source/ConditionAssignments.h:47:2: warning: Member variable 'ConditionAssignments::conditions' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/PlayerInfo.h:75:2: warning: Member variable 'PlayerInfo::availableSortType' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/AI.cpp:2305:10: performance:inconclusive: Technically the member function 'AI::ShouldDock' can be static (but you may consider moving to unnamed namespace). [functionStatic] endless-sky-0.10.14/source/AI.h:116:7: note: Technically the member function 'AI::ShouldDock' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/AI.cpp:2305:10: note: Technically the member function 'AI::ShouldDock' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/AI.cpp:3396:10: performance:inconclusive: Technically the member function 'AI::DoPatrol' can be static (but you may consider moving to unnamed namespace). [functionStatic] endless-sky-0.10.14/source/AI.h:145:7: note: Technically the member function 'AI::DoPatrol' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/AI.cpp:3396:10: note: Technically the member function 'AI::DoPatrol' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/StellarObject.h:43:7: warning: The class 'StellarObject' defines member function with name 'HasSprite' also defined in its parent class 'Body'. [duplInheritedMember] endless-sky-0.10.14/source/Body.h:44:7: note: Parent function 'Body::HasSprite' endless-sky-0.10.14/source/StellarObject.h:43:7: note: Derived function 'StellarObject::HasSprite' endless-sky-0.10.14/source/StellarObject.h:53:9: warning: The class 'StellarObject' defines member function with name 'Radius' also defined in its parent class 'Body'. [duplInheritedMember] endless-sky-0.10.14/source/Body.h:51:9: note: Parent function 'Body::Radius' endless-sky-0.10.14/source/StellarObject.h:53:9: note: Derived function 'StellarObject::Radius' endless-sky-0.10.14/source/Angle.h:40:2: style: Class 'Angle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/RouteEdge.h:31:2: style: Class 'RouteEdge' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/Ship.h:739:3: style: Class 'Leak' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/Minable.h:44:3: style: Class 'Payload' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/Minable.h:100:3: style: Class 'LiveEffect' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/Mortgage.h:48:2: style: Class 'Mortgage' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/GameAction.h:80:3: style: Struct 'Debt' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/MissionAction.h:89:3: style: Class 'MissionDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/MissionAction.h:90:3: style: Class 'MissionDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/Fleet.h:51:2: style: Class 'Fleet' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/AI.cpp:1718:5: style: Condition 'parent' is always true [knownConditionTrueFalse] endless-sky-0.10.14/source/AI.cpp:2670:9: style: The scope of the variable 'mass' can be reduced. [variableScope] endless-sky-0.10.14/source/AI.cpp:2899:9: style: The scope of the variable 'squareDistance' can be reduced. [variableScope] endless-sky-0.10.14/source/AI.cpp:5013:7: style: The scope of the variable 'gaveOrder' can be reduced. [variableScope] endless-sky-0.10.14/source/AI.cpp:500:56: style:inconclusive: Function 'UpdateKeys' argument 2 names different: declaration 'clickCommands' definition 'activeCommands'. [funcArgNamesDifferent] endless-sky-0.10.14/source/AI.h:67:53: note: Function 'UpdateKeys' argument 2 names different: declaration 'clickCommands' definition 'activeCommands'. endless-sky-0.10.14/source/AI.cpp:500:56: note: Function 'UpdateKeys' argument 2 names different: declaration 'clickCommands' definition 'activeCommands'. endless-sky-0.10.14/source/WeightedList.h:146:40: style:inconclusive: Function 'Average' argument 1 names different: declaration 'c' definition 'fn'. [funcArgNamesDifferent] endless-sky-0.10.14/source/WeightedList.h:53:21: note: Function 'Average' argument 1 names different: declaration 'c' definition 'fn'. endless-sky-0.10.14/source/WeightedList.h:146:40: note: Function 'Average' argument 1 names different: declaration 'c' definition 'fn'. endless-sky-0.10.14/source/AI.cpp:4376:10: style: Local variable 'ships' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/AI.h:224:20: note: Shadowed declaration endless-sky-0.10.14/source/AI.cpp:4376:10: note: Shadow variable endless-sky-0.10.14/source/AI.cpp:4947:23: style: Local variable 'ships' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/AI.h:224:20: note: Shadowed declaration endless-sky-0.10.14/source/AI.cpp:4947:23: note: Shadow variable endless-sky-0.10.14/source/AI.cpp:4621:3: style: Clarify calculation precedence for '^' and '?'. [clarifyCalculation] endless-sky-0.10.14/source/AI.cpp:1082:12: style: Variable 'npcs' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/AI.cpp:416:12: style: Variable 'ship' can be declared as pointer to const [constVariablePointer] endless-sky-0.10.14/source/AI.cpp:121:3: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/AI.cpp:140:3: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/AI.cpp:261:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/AI.cpp:301:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/AI.cpp:528:4: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/AI.cpp:884:6: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/AI.cpp:1695:12: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/AI.cpp:3132:19: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/AI.cpp:4694:4: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/AI.cpp:4909:17: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/DataWriter.h:134:10: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/DataWriter.h:146:10: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Account.cpp:75:13: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Account.cpp:458:10: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/text/Font.h:39:2: warning: Member variable 'Font::shader' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/AmmoDisplay.cpp:76:63: style:inconclusive: Function 'Draw' argument 2 names different: declaration 'iconDimensions' definition 'iconDim'. [funcArgNamesDifferent] endless-sky-0.10.14/source/AmmoDisplay.h:37:51: note: Function 'Draw' argument 2 names different: declaration 'iconDimensions' definition 'iconDim'. endless-sky-0.10.14/source/AmmoDisplay.cpp:76:63: note: Function 'Draw' argument 2 names different: declaration 'iconDimensions' definition 'iconDim'. endless-sky-0.10.14/source/AmmoDisplay.cpp:129:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Angle.cpp:73:15: style: Condition 'mod' is always true [knownConditionTrueFalse] endless-sky-0.10.14/source/Angle.cpp:72:72: note: Assignment 'mod=static_cast(std::fabs(range)*DEG_TO_STEP)+1', assigned value is greater than 0 endless-sky-0.10.14/source/Angle.cpp:73:15: note: Condition 'mod' is always true endless-sky-0.10.14/source/Armament.cpp:201:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/CollisionSet.h:69:3: warning: Member variable 'Entry::body' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/CollisionSet.h:69:3: warning: Member variable 'Entry::seenIndex' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/CollisionSet.h:69:3: warning: Member variable 'Entry::x' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/CollisionSet.h:69:3: warning: Member variable 'Entry::y' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/Interface.h:128:2: debug: SymbolDatabase couldn't resolve all user defined types. [debug] endless-sky-0.10.14/source/EsUuid.h:91:1: debug: SymbolDatabase couldn't resolve all user defined types. [debug] endless-sky-0.10.14/source/BankPanel.cpp:334:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_RETURN [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Layout.h:28:2: style: Class 'Layout' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/text/Layout.h:29:2: style: Class 'Layout' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/text/Layout.h:30:2: style: Class 'Layout' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/Dialog.h:161:14: performance: Function parameter 'initialValue' should be passed by const reference. [passedByValue] endless-sky-0.10.14/source/Dialog.h:173:65: performance: Function parameter 'initialValue' should be passed by const reference. [passedByValue] endless-sky-0.10.14/source/Panel.h:178:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Bitset.cpp:94:6: style: Consider using std::fill or std::generate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Bitset.cpp:102:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/InfoPanelState.h:33:2: debug: Failed to parse 'using ShipComparator = bool ( const std :: shared_ptr < Ship > & , const std :: shared_ptr < Ship > & ) ;'. The checking continues anyway. [simplifyUsing] endless-sky-0.10.14/source/BoardingPanel.cpp:224:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_ESCAPE [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/BoardingPanel.cpp:695:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_PAGEUP [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/ShipInfoPanel.h:63:7: warning: The class 'ShipInfoPanel' defines member function with name 'ClearZones' also defined in its parent class 'Panel'. [duplInheritedMember] endless-sky-0.10.14/source/Panel.h:68:7: note: Parent function 'Panel::ClearZones' endless-sky-0.10.14/source/ShipInfoPanel.h:63:7: note: Derived function 'ShipInfoPanel::ClearZones' endless-sky-0.10.14/source/ClickZone.h:36:7: performance: Function 'Value()' should return member 'value' by const reference. [returnByReference] endless-sky-0.10.14/source/BoardingPanel.cpp:265:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/BoardingPanel.cpp:598:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/CaptureOdds.cpp:32:2: performance: Variable 'powerA' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] endless-sky-0.10.14/source/CargoHold.cpp:208:6: style: Local variable 'size' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/CargoHold.h:121:6: note: Shadowed declaration endless-sky-0.10.14/source/CargoHold.cpp:208:6: note: Shadow variable endless-sky-0.10.14/source/CargoHold.cpp:226:9: style: Local variable 'size' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/CargoHold.h:121:6: note: Shadowed declaration endless-sky-0.10.14/source/CargoHold.cpp:226:9: note: Shadow variable endless-sky-0.10.14/source/CargoHold.cpp:252:6: style: Local variable 'size' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/CargoHold.h:121:6: note: Shadowed declaration endless-sky-0.10.14/source/CargoHold.cpp:252:6: note: Shadow variable endless-sky-0.10.14/source/CargoHold.cpp:39:18: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/CargoHold.cpp:210:8: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/CargoHold.cpp:228:8: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/CargoHold.cpp:240:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/CargoHold.cpp:254:8: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/CargoHold.cpp:300:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/CargoHold.cpp:574:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/CargoHold.cpp:578:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/CargoHold.cpp:651:10: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/CargoHold.cpp:656:10: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/CategoryList.cpp:48:27: debug: Function::addArguments found argument 'c' with varid 0. [varid0] endless-sky-0.10.14/source/CategoryList.cpp:71:27: debug: Function::addArguments found argument 'c' with varid 0. [varid0] endless-sky-0.10.14/source/CategoryList.cpp:80:27: debug: Function::addArguments found argument 'c' with varid 0. [varid0] endless-sky-0.10.14/source/CategoryList.cpp:48:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable c [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/CategoryList.cpp:71:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable c [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/CategoryList.cpp:80:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable c [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/CollisionSet.cpp:155:80: style:inconclusive: Function 'Line' argument 3 names different: declaration 'result' definition 'lineResult'. [funcArgNamesDifferent] endless-sky-0.10.14/source/CollisionSet.h:53:72: note: Function 'Line' argument 3 names different: declaration 'result' definition 'lineResult'. endless-sky-0.10.14/source/CollisionSet.cpp:155:80: note: Function 'Line' argument 3 names different: declaration 'result' definition 'lineResult'. endless-sky-0.10.14/source/CollisionSet.cpp:321:90: style:inconclusive: Function 'Ring' argument 4 names different: declaration 'result' definition 'circleResult'. [funcArgNamesDifferent] endless-sky-0.10.14/source/CollisionSet.h:60:82: note: Function 'Ring' argument 4 names different: declaration 'result' definition 'circleResult'. endless-sky-0.10.14/source/CollisionSet.cpp:321:90: note: Function 'Ring' argument 4 names different: declaration 'result' definition 'circleResult'. endless-sky-0.10.14/source/Color.cpp:132:38: performance: Function parameter 'c1' should be passed by const reference. [passedByValue] endless-sky-0.10.14/source/Color.cpp:132:58: performance: Function parameter 'c2' should be passed by const reference. [passedByValue] endless-sky-0.10.14/source/Command.cpp:129:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_SHIFT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/ConditionAssignments.cpp:218:15: performance: Function parameter 'expressionToEvaluate' should be passed by const reference. [passedByValue] endless-sky-0.10.14/source/ConditionEntry.cpp:162:22: performance:inconclusive: Technically the member function 'ConditionEntry::NotifyUpdate' can be static (but you may consider moving to unnamed namespace). [functionStatic] endless-sky-0.10.14/source/ConditionEntry.h:71:7: note: Technically the member function 'ConditionEntry::NotifyUpdate' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/ConditionEntry.cpp:162:22: note: Technically the member function 'ConditionEntry::NotifyUpdate' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/ConditionSet.cpp:44:59: debug: Function::addArguments found argument 'b' with varid 0. [varid0] endless-sky-0.10.14/source/ConditionSet.cpp:45:59: debug: Function::addArguments found argument 'b' with varid 0. [varid0] endless-sky-0.10.14/source/ConditionSet.cpp:46:59: debug: Function::addArguments found argument 'b' with varid 0. [varid0] endless-sky-0.10.14/source/ConditionSet.cpp:47:59: debug: Function::addArguments found argument 'b' with varid 0. [varid0] endless-sky-0.10.14/source/ConditionSet.cpp:48:59: debug: Function::addArguments found argument 'b' with varid 0. [varid0] endless-sky-0.10.14/source/ConditionSet.cpp:49:59: debug: Function::addArguments found argument 'b' with varid 0. [varid0] endless-sky-0.10.14/source/ConditionSet.cpp:50:60: debug: Function::addArguments found argument 'b' with varid 0. [varid0] endless-sky-0.10.14/source/ConditionSet.cpp:51:60: debug: Function::addArguments found argument 'b' with varid 0. [varid0] endless-sky-0.10.14/source/ConditionSet.cpp:52:60: debug: Function::addArguments found argument 'b' with varid 0. [varid0] endless-sky-0.10.14/source/ConditionSet.cpp:53:60: debug: Function::addArguments found argument 'b' with varid 0. [varid0] endless-sky-0.10.14/source/ConditionSet.cpp:54:60: debug: Function::addArguments found argument 'b' with varid 0. [varid0] endless-sky-0.10.14/source/ConditionSet.cpp:44:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable b [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/ConditionSet.cpp:659:7: style: Condition '!PushDownFull(node)' is always false [knownConditionTrueFalse] endless-sky-0.10.14/source/ConditionSet.cpp:659:20: note: Calling function 'PushDownFull' returns 1 endless-sky-0.10.14/source/ConditionSet.cpp:659:7: note: Condition '!PushDownFull(node)' is always false endless-sky-0.10.14/source/ConditionSet.cpp:731:9: style: Condition '!PushDownFull(node)' is always false [knownConditionTrueFalse] endless-sky-0.10.14/source/ConditionSet.cpp:731:22: note: Calling function 'PushDownFull' returns 1 endless-sky-0.10.14/source/ConditionSet.cpp:731:9: note: Condition '!PushDownFull(node)' is always false endless-sky-0.10.14/source/Conversation.cpp:338:59: debug: Function::addArguments found argument 'node' with varid 0. [varid0] endless-sky-0.10.14/source/Conversation.cpp:262:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable next [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Conversation.cpp:338:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable node [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Conversation.cpp:386:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable isChoice [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Conversation.cpp:397:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable isChoice [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Conversation.cpp:423:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable isChoice [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Conversation.cpp:457:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable conditions [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Conversation.cpp:469:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable actions [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Conversation.cpp:482:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable elements [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Conversation.cpp:493:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable scene [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Conversation.cpp:504:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable elements [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Conversation.cpp:529:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable elements [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Conversation.cpp:641:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable elements [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Conversation.cpp:660:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable elements [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Conversation.cpp:616:20: performance:inconclusive: Technically the member function 'Conversation::HasDisplayRestriction' can be static (but you may consider moving to unnamed namespace). [functionStatic] endless-sky-0.10.14/source/Conversation.h:177:7: note: Technically the member function 'Conversation::HasDisplayRestriction' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/Conversation.cpp:616:20: note: Technically the member function 'Conversation::HasDisplayRestriction' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/Conversation.cpp:52:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Conversation.cpp:404:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Conversation.cpp:618:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/ConversationPanel.h:165:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable _1 [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/ConversationPanel.cpp:209:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_RETURN [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/ConversationPanel.cpp:262:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_RETURN [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/ScrollVar.h:183:29: warning: The class 'ScrollVar < double >' defines member function with name 'operator=' also defined in its parent class 'Animate < double >'. [duplInheritedMember] endless-sky-0.10.14/source/Animate.h:126:25: note: Parent function 'Animate < double >::operator=' endless-sky-0.10.14/source/ScrollVar.h:183:29: note: Derived function 'ScrollVar < double >::operator=' endless-sky-0.10.14/source/ConversationPanel.cpp:310:11: style: Local variable 'name' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/ConversationPanel.cpp:281:11: note: Shadowed declaration endless-sky-0.10.14/source/ConversationPanel.cpp:310:11: note: Shadow variable endless-sky-0.10.14/source/ConversationPanel.cpp:405:7: style: Local variable 'choice' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/ConversationPanel.h:133:6: note: Shadowed declaration endless-sky-0.10.14/source/ConversationPanel.cpp:405:7: note: Shadow variable endless-sky-0.10.14/source/ConversationPanel.cpp:153:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/ConversationPanel.cpp:394:12: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/DamageProfile.cpp:123:16: style: Local variable 'weapon' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/DamageProfile.h:57:16: note: Shadowed declaration endless-sky-0.10.14/source/DamageProfile.cpp:123:16: note: Shadow variable endless-sky-0.10.14/source/DataFile.cpp:218:33: style:inconclusive: Redundant condition: The condition 'c != '#'' is redundant since 'c <= ' '' is sufficient. [redundantCondition] endless-sky-0.10.14/source/DataFile.cpp:111:9: style: Local variable 'end' shadows outer function [shadowFunction] endless-sky-0.10.14/source/DataFile.h:45:38: note: Shadowed declaration endless-sky-0.10.14/source/DataFile.cpp:111:9: note: Shadow variable endless-sky-0.10.14/source/DataNode.cpp:166:11: style: Local variable 'sign' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/DataNode.cpp:142:9: note: Shadowed declaration endless-sky-0.10.14/source/DataNode.cpp:166:11: note: Shadow variable endless-sky-0.10.14/source/DataWriter.cpp:151:45: style:inconclusive: Function 'Quote' argument 1 names different: declaration 'text' definition 'a'. [funcArgNamesDifferent] endless-sky-0.10.14/source/DataWriter.h:81:46: note: Function 'Quote' argument 1 names different: declaration 'text' definition 'a'. endless-sky-0.10.14/source/DataWriter.cpp:151:45: note: Function 'Quote' argument 1 names different: declaration 'text' definition 'a'. endless-sky-0.10.14/source/Depreciation.cpp:363:22: performance:inconclusive: Technically the member function 'Depreciation::Depreciate' can be static (but you may consider moving to unnamed namespace). [functionStatic] endless-sky-0.10.14/source/Depreciation.h:71:9: note: Technically the member function 'Depreciation::Depreciate' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/Depreciation.cpp:363:22: note: Technically the member function 'Depreciation::Depreciate' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/Depreciation.cpp:249:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Depreciation.cpp:251:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Depreciation.cpp:262:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Dialog.cpp:267:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_ESCAPE [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Dialog.cpp:351:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_RETURN [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/TextArea.h:40:2: style: Class 'TextArea' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/TextArea.h:41:11: style: The destructor '~TextArea' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] endless-sky-0.10.14/source/Panel.h:50:11: note: Virtual destructor in base class endless-sky-0.10.14/source/TextArea.h:41:11: note: Destructor in derived class endless-sky-0.10.14/source/Dictionary.cpp:40:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Dictionary.cpp:59:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable second [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/StringInterner.h:29:46: performance: Function parameter 'key' should be passed by const reference. [passedByValue] endless-sky-0.10.14/source/DistanceMap.cpp:103:42: style:inconclusive: Function 'HasRoute' argument 1 names different: declaration 'system' definition 'target'. [funcArgNamesDifferent] endless-sky-0.10.14/source/DistanceMap.h:55:30: note: Function 'HasRoute' argument 1 names different: declaration 'system' definition 'target'. endless-sky-0.10.14/source/DistanceMap.cpp:103:42: note: Function 'HasRoute' argument 1 names different: declaration 'system' definition 'target'. endless-sky-0.10.14/source/DistanceMap.cpp:111:37: style:inconclusive: Function 'Days' argument 1 names different: declaration 'system' definition 'target'. [funcArgNamesDifferent] endless-sky-0.10.14/source/DistanceMap.h:57:25: note: Function 'Days' argument 1 names different: declaration 'system' definition 'target'. endless-sky-0.10.14/source/DistanceMap.cpp:111:37: note: Function 'Days' argument 1 names different: declaration 'system' definition 'target'. endless-sky-0.10.14/source/DistanceMap.cpp:131:56: style:inconclusive: Function 'Plan' argument 1 names different: declaration 'system' definition 'target'. [funcArgNamesDifferent] endless-sky-0.10.14/source/DistanceMap.h:59:49: note: Function 'Plan' argument 1 names different: declaration 'system' definition 'target'. endless-sky-0.10.14/source/DistanceMap.cpp:131:56: note: Function 'Plan' argument 1 names different: declaration 'system' definition 'target'. endless-sky-0.10.14/source/DistanceMap.cpp:175:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Engine.cpp:2341:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_BUTTON_RMASK [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/StarField.h:56:2: warning: Member variable 'StarField::widthMod' is not initialized. [uninitMemberVarPrivate] endless-sky-0.10.14/source/shader/StarField.h:57:2: warning: Member variable 'StarField::tileCols' is not initialized. [uninitMemberVarPrivate] endless-sky-0.10.14/source/shader/StarField.h:67:2: warning: Member variable 'StarField::minZoom' is not initialized. [uninitMemberVarPrivate] endless-sky-0.10.14/source/shader/StarField.h:68:2: warning: Member variable 'StarField::zoomClamp' is not initialized. [uninitMemberVarPrivate] endless-sky-0.10.14/source/shader/StarField.h:69:2: warning: Member variable 'StarField::clampSlope' is not initialized. [uninitMemberVarPrivate] endless-sky-0.10.14/source/shader/StarField.h:72:8: warning: Member variable 'StarField::lastSprite' is not initialized. [uninitMemberVarPrivate] endless-sky-0.10.14/source/shader/StarField.h:76:8: warning: Member variable 'StarField::shader' is not initialized. [uninitMemberVarPrivate] endless-sky-0.10.14/source/Engine.cpp:1885:24: warning: Logical conjunction always evaluates to false: ship->IsDisabled() && !(wasDisabled). [incorrectLogicOperator] endless-sky-0.10.14/source/Engine.cpp:1881:37: note: 'wasDisabled' is assigned value 'ship->IsDisabled()' here. endless-sky-0.10.14/source/Engine.cpp:1885:24: note: Logical conjunction always evaluates to false: ship->IsDisabled() && !(wasDisabled). endless-sky-0.10.14/source/Engine.cpp:1913:34: warning: Logical conjunction always evaluates to false: !wasHyperspacing && ship->IsHyperspacing(). [incorrectLogicOperator] endless-sky-0.10.14/source/Engine.cpp:2359:5: style: Condition 'isMouseTurningEnabled' is always true [knownConditionTrueFalse] endless-sky-0.10.14/source/Engine.cpp:2354:5: note: Assuming that condition '!isMouseTurningEnabled' is not redundant endless-sky-0.10.14/source/Engine.cpp:2359:5: note: Condition 'isMouseTurningEnabled' is always true endless-sky-0.10.14/source/Engine.cpp:2893:5: warning: Either the condition '!target' is redundant or there is possible null pointer dereference: target. [nullPointerRedundantCheck] endless-sky-0.10.14/source/Engine.cpp:2897:5: note: Assuming that condition '!target' is not redundant endless-sky-0.10.14/source/Engine.cpp:2893:5: note: Null pointer dereference endless-sky-0.10.14/source/Engine.cpp:1885:24: style: Opposite expression on both sides of '&&'. [oppositeExpression] endless-sky-0.10.14/source/Engine.cpp:1881:37: note: 'wasDisabled' is assigned value 'ship->IsDisabled()' here. endless-sky-0.10.14/source/Engine.cpp:1885:24: note: Opposite expression on both sides of '&&'. endless-sky-0.10.14/source/Engine.cpp:1878:7: style: The scope of the variable 'isJump' can be reduced. [variableScope] endless-sky-0.10.14/source/Engine.cpp:1880:7: style: The scope of the variable 'wasHyperspacing' can be reduced. [variableScope] endless-sky-0.10.14/source/Engine.cpp:2976:15: style: The scope of the variable 'FLAGSHIP' can be reduced. [variableScope] endless-sky-0.10.14/source/Engine.cpp:2977:15: style: The scope of the variable 'FRIENDLY' can be reduced. [variableScope] endless-sky-0.10.14/source/Engine.cpp:2978:15: style: The scope of the variable 'HOSTILE' can be reduced. [variableScope] endless-sky-0.10.14/source/Engine.cpp:2979:15: style: The scope of the variable 'NEUTRAL' can be reduced. [variableScope] endless-sky-0.10.14/source/Engine.cpp:2994:59: style:inconclusive: Function 'EmplaceStatusOverlay' argument 1 names different: declaration 'ship' definition 'it'. [funcArgNamesDifferent] endless-sky-0.10.14/source/Engine.h:210:57: note: Function 'EmplaceStatusOverlay' argument 1 names different: declaration 'ship' definition 'it'. endless-sky-0.10.14/source/Engine.cpp:2994:59: note: Function 'EmplaceStatusOverlay' argument 1 names different: declaration 'ship' definition 'it'. endless-sky-0.10.14/source/Engine.cpp:277:27: style: Local variable 'object' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Engine.cpp:268:23: note: Shadowed declaration endless-sky-0.10.14/source/Engine.cpp:277:27: note: Shadow variable endless-sky-0.10.14/source/Engine.cpp:361:25: style: Local variable 'object' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Engine.cpp:339:23: note: Shadowed declaration endless-sky-0.10.14/source/Engine.cpp:361:25: note: Shadow variable endless-sky-0.10.14/source/Engine.cpp:517:29: style: Local variable 'object' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Engine.cpp:504:23: note: Shadowed declaration endless-sky-0.10.14/source/Engine.cpp:517:29: note: Shadow variable endless-sky-0.10.14/source/Engine.cpp:626:28: style: Local variable 'object' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Engine.cpp:504:23: note: Shadowed declaration endless-sky-0.10.14/source/Engine.cpp:626:28: note: Shadow variable endless-sky-0.10.14/source/Engine.cpp:788:24: style: Local variable 'object' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Engine.cpp:504:23: note: Shadowed declaration endless-sky-0.10.14/source/Engine.cpp:788:24: note: Shadow variable endless-sky-0.10.14/source/Engine.cpp:1580:15: style: Local variable 'zoom' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Engine.h:322:7: note: Shadowed declaration endless-sky-0.10.14/source/Engine.cpp:1580:15: note: Shadow variable endless-sky-0.10.14/source/Engine.cpp:2108:12: style: Variable 'it' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/Engine.cpp:2265:24: style: Variable 'ship' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/Engine.cpp:2742:24: style: Variable 'ship' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/Engine.cpp:2776:18: style: Variable 'projectile' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/Engine.cpp:1317:10: style: Variable 'dx' can be declared as const array [constVariable] endless-sky-0.10.14/source/Engine.cpp:2130:8: style: Variable 'flagship' can be declared as pointer to const [constVariablePointer] endless-sky-0.10.14/source/Engine.cpp:323:9: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Engine.cpp:686:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Engine.cpp:2033:7: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Engine.cpp:2110:11: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Engine.cpp:2677:10: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/EsUuid.cpp:147:14: style:inconclusive: Technically the member function 'EsUuid::clone' can be const. [functionConst] endless-sky-0.10.14/source/EsUuid.h:71:7: note: Technically the member function 'EsUuid::clone' can be const. endless-sky-0.10.14/source/EsUuid.cpp:147:14: note: Technically the member function 'EsUuid::clone' can be const. endless-sky-0.10.14/source/EscortDisplay.cpp:163:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Files.cpp:51:0: error: failed to evaluate #if condition, undefined function-like macro invocation: SDL_VERSION_ATLEAST( ... ) [preprocessorErrorDirective] endless-sky-0.10.14/source/Files.cpp:51:2: error: failed to evaluate #if condition, undefined function-like macro invocation: SDL_VERSION_ATLEAST( ... ) [preprocessorErrorDirective] endless-sky-0.10.14/source/FireCommand.cpp:64:6: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Fleet.cpp:158:22: debug: Function::addArguments found argument 'v' with varid 0. [varid0] endless-sky-0.10.14/source/Fleet.cpp:169:51: debug: Function::addArguments found argument 'v' with varid 0. [varid0] endless-sky-0.10.14/source/Fleet.cpp:158:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable v [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Fleet.cpp:169:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable v [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Fleet.cpp:540:13: performance:inconclusive: Technically the member function 'Fleet::PlaceFighter' can be static (but you may consider moving to unnamed namespace). [functionStatic] endless-sky-0.10.14/source/Fleet.h:81:7: note: Technically the member function 'Fleet::PlaceFighter' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/Fleet.cpp:540:13: note: Technically the member function 'Fleet::PlaceFighter' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/Fleet.cpp:255:29: style: Local variable 'object' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Fleet.cpp:207:23: note: Shadowed declaration endless-sky-0.10.14/source/Fleet.cpp:255:29: note: Shadow variable endless-sky-0.10.14/source/Fleet.cpp:267:29: style: Local variable 'object' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Fleet.cpp:207:23: note: Shadowed declaration endless-sky-0.10.14/source/Fleet.cpp:267:29: note: Shadow variable endless-sky-0.10.14/source/Fleet.cpp:308:20: style: Local variable 'object' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Fleet.cpp:207:23: note: Shadowed declaration endless-sky-0.10.14/source/Fleet.cpp:308:20: note: Shadow variable endless-sky-0.10.14/source/Fleet.cpp:296:12: style: Variable 'ship' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/Fleet.cpp:540:85: style: Parameter 'placed' can be declared as reference to const [constParameterReference] endless-sky-0.10.14/source/Fleet.cpp:450:17: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Fleet.cpp:545:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/FleetCargo.cpp:108:5: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Flotsam.cpp:76:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable point [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Flotsam.cpp:83:15: style:inconclusive: Technically the member function 'Flotsam::Place' can be const. [functionConst] endless-sky-0.10.14/source/Flotsam.h:56:7: note: Technically the member function 'Flotsam::Place' can be const. endless-sky-0.10.14/source/Flotsam.cpp:83:15: note: Technically the member function 'Flotsam::Place' can be const. endless-sky-0.10.14/source/FormationPattern.cpp:333:15: style:inconclusive: Function 'Position' argument 4 names different: declaration 'lineRepeatPosition' definition 'linePosition'. [funcArgNamesDifferent] endless-sky-0.10.14/source/FormationPattern.h:107:16: note: Function 'Position' argument 4 names different: declaration 'lineRepeatPosition' definition 'linePosition'. endless-sky-0.10.14/source/FormationPattern.cpp:333:15: note: Function 'Position' argument 4 names different: declaration 'lineRepeatPosition' definition 'linePosition'. endless-sky-0.10.14/source/FormationPattern.cpp:74:15: style: Local variable 'lines' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/FormationPattern.h:163:20: note: Shadowed declaration endless-sky-0.10.14/source/FormationPattern.cpp:74:15: note: Shadow variable endless-sky-0.10.14/source/FormationPositioner.cpp:76:20: style: The statement 'if (status.second!=tickTock) status.second=tickTock' is logically equivalent to 'status.second=tickTock'. [duplicateConditionalAssign] endless-sky-0.10.14/source/FormationPositioner.cpp:77:18: note: Assignment 'status.second=tickTock' endless-sky-0.10.14/source/FormationPositioner.cpp:76:20: note: Condition 'status.second!=tickTock' is redundant endless-sky-0.10.14/source/FormationPositioner.cpp:191:12: style: Variable 'deltaDir' is assigned a value that is never used. [unreadVariable] endless-sky-0.10.14/source/FrameTimer.cpp:34:2: performance: Variable 'next' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] endless-sky-0.10.14/source/FrameTimer.cpp:46:2: performance: Variable 'next' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] endless-sky-0.10.14/source/GameAction.cpp:154:9: style: The scope of the variable 'type' can be reduced. [variableScope] endless-sky-0.10.14/source/GameAction.cpp:325:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/GameAction.cpp:333:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/GameAction.cpp:336:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/GameData.cpp:308:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/GameData.cpp:393:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable name [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/image/ImageBuffer.h:41:2: style: Class 'ImageBuffer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/image/ImageFileData.h:29:2: style: Class 'ImageFileData' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/RenderBuffer.h:52:2: style: Class 'RenderBuffer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/GameData.cpp:614:47: style: Parameter 'names' can be declared as reference to const [constParameterReference] endless-sky-0.10.14/source/GameEvent.cpp:58:60: debug: Function::addArguments found argument 'child' with varid 0. [varid0] endless-sky-0.10.14/source/GameEvent.cpp:58:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable child [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/GameLoadingPanel.cpp:96:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_COLOR_BUFFER_BIT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MenuPanel.h:35:11: style: The destructor '~MenuPanel' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] endless-sky-0.10.14/source/Panel.h:50:11: note: Virtual destructor in base class endless-sky-0.10.14/source/MenuPanel.h:35:11: note: Destructor in derived class endless-sky-0.10.14/source/GameWindow.cpp:92:0: error: failed to evaluate #if condition, undefined function-like macro invocation: SDL_VERSION_ATLEAST( ... ) [preprocessorErrorDirective] endless-sky-0.10.14/source/GameWindow.cpp:92:2: error: failed to evaluate #if condition, undefined function-like macro invocation: SDL_VERSION_ATLEAST( ... ) [preprocessorErrorDirective] endless-sky-0.10.14/source/Government.cpp:254:8: style: Condition 'gov' is always true [knownConditionTrueFalse] endless-sky-0.10.14/source/Government.cpp:530:43: style:inconclusive: Function 'Trusts' argument 1 names different: declaration 'other' definition 'government'. [funcArgNamesDifferent] endless-sky-0.10.14/source/Government.h:82:32: note: Function 'Trusts' argument 1 names different: declaration 'other' definition 'government'. endless-sky-0.10.14/source/Government.cpp:530:43: note: Function 'Trusts' argument 1 names different: declaration 'other' definition 'government'. endless-sky-0.10.14/source/Government.cpp:241:10: style: Local variable 'remove' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Government.cpp:118:8: note: Shadowed declaration endless-sky-0.10.14/source/Government.cpp:241:10: note: Shadow variable endless-sky-0.10.14/source/Government.cpp:242:10: style: Local variable 'add' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Government.cpp:119:8: note: Shadowed declaration endless-sky-0.10.14/source/Government.cpp:242:10: note: Shadow variable endless-sky-0.10.14/source/Government.cpp:499:12: style: Local variable 'id' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Government.h:152:11: note: Shadowed declaration endless-sky-0.10.14/source/Government.cpp:499:12: note: Shadow variable endless-sky-0.10.14/source/Government.cpp:73:13: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Government.cpp:541:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Government.cpp:553:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Government.cpp:688:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Government.cpp:702:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/HailPanel.cpp:310:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_ESCAPE [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/HailPanel.cpp:155:4: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/HailPanel.cpp:432:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Hardpoint.cpp:440:15: style: Local variable 'minArc' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Hardpoint.h:145:8: note: Shadowed declaration endless-sky-0.10.14/source/Hardpoint.cpp:440:15: note: Shadow variable endless-sky-0.10.14/source/Hardpoint.cpp:441:15: style: Local variable 'maxArc' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Hardpoint.h:146:8: note: Shadowed declaration endless-sky-0.10.14/source/Hardpoint.cpp:441:15: note: Shadow variable endless-sky-0.10.14/source/HiringPanel.cpp:123:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_EQUALS [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/InfoPanelState.cpp:218:53: style:inconclusive: Function 'SetCurrentSort' argument 1 names different: declaration 's' definition 'newSort'. [funcArgNamesDifferent] endless-sky-0.10.14/source/InfoPanelState.h:59:38: note: Function 'SetCurrentSort' argument 1 names different: declaration 's' definition 'newSort'. endless-sky-0.10.14/source/InfoPanelState.cpp:218:53: note: Function 'SetCurrentSort' argument 1 names different: declaration 's' definition 'newSort'. endless-sky-0.10.14/source/Interface.cpp:437:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACTIVE [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Interface.cpp:465:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INACTIVE [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Interface.cpp:560:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACTIVE [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Interface.cpp:601:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACTIVE [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Interface.cpp:601:21: debug: CheckClass::isMemberVar found used member variable 'ACTIVE' with varid 0 [varid0] endless-sky-0.10.14/source/Interface.cpp:481:16: style: Local variable 'sprite' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Interface.h:149:17: note: Shadowed declaration endless-sky-0.10.14/source/Interface.cpp:481:16: note: Shadow variable endless-sky-0.10.14/source/Interface.cpp:502:16: style: Local variable 'sprite' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Interface.h:149:17: note: Shadowed declaration endless-sky-0.10.14/source/Interface.cpp:502:16: note: Shadow variable endless-sky-0.10.14/source/Interface.cpp:113:10: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/LoadPanel.cpp:140:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_COLOR_BUFFER_BIT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/LoadPanel.cpp:305:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/LoadPanel.cpp:441:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/LoadPanel.cpp:527:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/LoadPanel.cpp:578:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/LoadPanel.cpp:679:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/LoadPanel.cpp:84:20: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] endless-sky-0.10.14/source/LoadPanel.cpp:96:4: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/LocationFilter.cpp:143:29: debug: Function::addArguments found argument 'f' with varid 0. [varid0] endless-sky-0.10.14/source/LocationFilter.cpp:143:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable f [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/LocationFilter.cpp:120:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/LocationFilter.cpp:153:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/LocationFilter.cpp:154:4: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/LocationFilter.cpp:365:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/LocationFilter.cpp:369:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/LocationFilter.cpp:374:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/LocationFilter.cpp:414:3: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/LocationFilter.cpp:430:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/LocationFilter.cpp:434:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/LocationFilter.cpp:660:4: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/LocationFilter.cpp:672:3: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/LogbookPanel.cpp:170:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_ESCAPE [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/LogbookPanel.h:35:2: style: Class 'LogbookPanel' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/LogbookPanel.cpp:225:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Logger.cpp:41:2: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MainPanel.cpp:146:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_COLOR_BUFFER_BIT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MainPanel.cpp:240:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_MINUS [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MainPanel.cpp:266:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_SHIFT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MainPanel.cpp:442:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_SHIFT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MainPanel.cpp:327:17: style:inconclusive: Technically the member function 'MainPanel::ShowScanDialog' can be const. [functionConst] endless-sky-0.10.14/source/MainPanel.h:64:7: note: Technically the member function 'MainPanel::ShowScanDialog' can be const. endless-sky-0.10.14/source/MainPanel.cpp:327:17: note: Technically the member function 'MainPanel::ShowScanDialog' can be const. endless-sky-0.10.14/source/MainPanel.cpp:375:15: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MapDetailPanel.cpp:218:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_TAB [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MapDetailPanel.cpp:778:10: style: Local variable 'bottom' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/MapDetailPanel.cpp:762:17: note: Shadowed declaration endless-sky-0.10.14/source/MapDetailPanel.cpp:778:10: note: Shadow variable endless-sky-0.10.14/source/MapPanel.cpp:295:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_COLOR_BUFFER_BIT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MapPanel.cpp:572:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_ESCAPE [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MapPanel.cpp:825:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_SHIFT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MapPanel.cpp:751:29: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] endless-sky-0.10.14/source/MapPanel.cpp:1297:16: style:inconclusive: Technically the member function 'MapPanel::DrawEscorts' can be const. [functionConst] endless-sky-0.10.14/source/MapPanel.h:205:7: note: Technically the member function 'MapPanel::DrawEscorts' can be const. endless-sky-0.10.14/source/MapPanel.cpp:1297:16: note: Technically the member function 'MapPanel::DrawEscorts' can be const. endless-sky-0.10.14/source/MapPanel.cpp:1334:16: style:inconclusive: Technically the member function 'MapPanel::DrawWormholes' can be const. [functionConst] endless-sky-0.10.14/source/MapPanel.h:206:7: note: Technically the member function 'MapPanel::DrawWormholes' can be const. endless-sky-0.10.14/source/MapPanel.cpp:1334:16: note: Technically the member function 'MapPanel::DrawWormholes' can be const. endless-sky-0.10.14/source/MapPanel.cpp:1398:16: style:inconclusive: Technically the member function 'MapPanel::DrawLinks' can be const. [functionConst] endless-sky-0.10.14/source/MapPanel.h:207:7: note: Technically the member function 'MapPanel::DrawLinks' can be const. endless-sky-0.10.14/source/MapPanel.cpp:1398:16: note: Technically the member function 'MapPanel::DrawLinks' can be const. endless-sky-0.10.14/source/MapPanel.cpp:1479:16: style:inconclusive: Technically the member function 'MapPanel::DrawNames' can be const. [functionConst] endless-sky-0.10.14/source/MapPanel.h:210:7: note: Technically the member function 'MapPanel::DrawNames' can be const. endless-sky-0.10.14/source/MapPanel.cpp:1479:16: note: Technically the member function 'MapPanel::DrawNames' can be const. endless-sky-0.10.14/source/MapPanel.cpp:1103:12: style: The scope of the variable 'reputation' can be reduced. [variableScope] endless-sky-0.10.14/source/MapPanel.cpp:283:10: style: Local variable 'step' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/MapPanel.h:144:6: note: Shadowed declaration endless-sky-0.10.14/source/MapPanel.cpp:283:10: note: Shadow variable endless-sky-0.10.14/source/MapPanel.cpp:487:10: style: Local variable 'color' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/MapPanel.cpp:465:9: note: Shadowed declaration endless-sky-0.10.14/source/MapPanel.cpp:487:10: note: Shadow variable endless-sky-0.10.14/source/MapPanel.cpp:1465:11: style: Local variable 'distance' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/MapPanel.h:127:14: note: Shadowed declaration endless-sky-0.10.14/source/MapPanel.cpp:1465:11: note: Shadow variable endless-sky-0.10.14/source/MapPanel.cpp:204:12: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MapPanel.cpp:388:10: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MapPanel.cpp:1055:13: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MapPanel.cpp:1063:13: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MapSalesPanel.cpp:103:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_PAGEUP [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MapSalesPanel.cpp:151:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_SHIFT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MapSalesPanel.cpp:460:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_SHIFT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MapSalesPanel.cpp:277:21: performance:inconclusive: Technically the member function 'MapSalesPanel::DrawPanel' can be static (but you may consider moving to unnamed namespace). [functionStatic] endless-sky-0.10.14/source/MapSalesPanel.h:67:7: note: Technically the member function 'MapSalesPanel::DrawPanel' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/MapSalesPanel.cpp:277:21: note: Technically the member function 'MapSalesPanel::DrawPanel' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/MapSalesPanel.cpp:365:21: performance:inconclusive: Technically the member function 'MapSalesPanel::DrawSprite' can be static (but you may consider moving to unnamed namespace). [functionStatic] endless-sky-0.10.14/source/MapSalesPanel.h:71:7: note: Technically the member function 'MapSalesPanel::DrawSprite' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/MapSalesPanel.cpp:365:21: note: Technically the member function 'MapSalesPanel::DrawSprite' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/MapSalesPanel.cpp:143:29: performance: Function parameter 'zone' should be passed by const reference. [passedByValue] endless-sky-0.10.14/source/MapShipyardPanel.cpp:226:6: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MenuPanel.cpp:143:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_COLOR_BUFFER_BIT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MenuPanel.cpp:213:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_DOWN [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PreferencesPanel.h:39:2: style: Class 'PreferencesPanel' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/PreferencesPanel.h:40:11: style: The destructor '~PreferencesPanel' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] endless-sky-0.10.14/source/Panel.h:50:11: note: Virtual destructor in base class endless-sky-0.10.14/source/PreferencesPanel.h:40:11: note: Destructor in derived class endless-sky-0.10.14/source/MessageLogPanel.cpp:113:63: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_ESCAPE [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Messages.cpp:52:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Minable.cpp:117:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:363:51: debug: Function::addArguments found argument 'color' with varid 0. [varid0] endless-sky-0.10.14/source/Mission.cpp:416:55: debug: Function::addArguments found argument 'color' with varid 0. [varid0] endless-sky-0.10.14/source/Mission.cpp:363:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable color [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Mission.h:120:14: performance: Function 'FineMessage()' should return member 'fineMessage' by const reference. [returnByReference] endless-sky-0.10.14/source/Mission.cpp:1042:9: style: Local variable 'cargo' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Mission.h:248:14: note: Shadowed declaration endless-sky-0.10.14/source/Mission.cpp:1042:9: note: Shadow variable endless-sky-0.10.14/source/Mission.cpp:1571:10: style: Local variable 'stopovers' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Mission.h:276:27: note: Shadowed declaration endless-sky-0.10.14/source/Mission.cpp:1571:10: note: Shadow variable endless-sky-0.10.14/source/Mission.cpp:1579:12: style: Local variable 'result' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Mission.cpp:1403:10: note: Shadowed declaration endless-sky-0.10.14/source/Mission.cpp:1579:12: note: Shadow variable endless-sky-0.10.14/source/Mission.cpp:635:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:638:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:643:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:646:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:649:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:652:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:664:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:671:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:1026:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:1032:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:1057:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:1173:4: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:1277:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:1306:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:1307:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:1488:5: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:1494:5: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:1698:16: style: Consider using std::copy algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Mission.cpp:1700:16: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MissionAction.cpp:146:48: style:inconclusive: Function 'LoadSingle' argument 1 names different: declaration 'node' definition 'child'. [funcArgNamesDifferent] endless-sky-0.10.14/source/MissionAction.h:54:34: note: Function 'LoadSingle' argument 1 names different: declaration 'node' definition 'child'. endless-sky-0.10.14/source/MissionAction.cpp:146:48: note: Function 'LoadSingle' argument 1 names different: declaration 'node' definition 'child'. endless-sky-0.10.14/source/MissionAction.cpp:161:11: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MissionAction.cpp:306:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MissionAction.cpp:361:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MissionPanel.cpp:333:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_CTRL [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/MissionPanel.cpp:71:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MissionPanel.cpp:75:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MissionPanel.cpp:79:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MissionPanel.cpp:154:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MissionPanel.cpp:198:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MissionPanel.cpp:499:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MissionPanel.cpp:1146:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MissionPanel.cpp:1160:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/MissionPanel.cpp:1163:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/NPC.h:99:41: performance: Function 'Ships()' should return member 'ships' by const reference. [returnByReference] endless-sky-0.10.14/source/NPC.cpp:736:9: style: Local variable 'dialogText' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/NPC.h:143:14: note: Shadowed declaration endless-sky-0.10.14/source/NPC.cpp:736:9: note: Shadow variable endless-sky-0.10.14/source/NPC.cpp:407:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/NPC.cpp:410:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/NPC.cpp:471:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/NPC.cpp:605:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/News.cpp:91:16: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Outfit.cpp:530:12: style: Boolean value assigned to floating point variable. [assignBoolToFloat] endless-sky-0.10.14/source/Outfit.cpp:579:40: style:inconclusive: Function 'AddLicenses' argument 1 names different: declaration 'outfit' definition 'other'. [funcArgNamesDifferent] endless-sky-0.10.14/source/Outfit.h:86:33: note: Function 'AddLicenses' argument 1 names different: declaration 'outfit' definition 'other'. endless-sky-0.10.14/source/Outfit.cpp:579:40: note: Function 'AddLicenses' argument 1 names different: declaration 'outfit' definition 'other'. endless-sky-0.10.14/source/OutfitInfoDisplay.cpp:457:71: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/OutfitInfoDisplay.cpp:380:56: performance: Function parameter 'label' should be passed by const reference. [passedByValue] endless-sky-0.10.14/source/ClickZone.h:64:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/OutfitterPanel.cpp:881:38: style:inconclusive: Boolean expression 'isSelected' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] endless-sky-0.10.14/source/OutfitterPanel.cpp:886:22: performance:inconclusive: Technically the member function 'OutfitterPanel::IsLicense' can be static (but you may consider moving to unnamed namespace). [functionStatic] endless-sky-0.10.14/source/OutfitterPanel.h:73:7: note: Technically the member function 'OutfitterPanel::IsLicense' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/OutfitterPanel.cpp:886:22: note: Technically the member function 'OutfitterPanel::IsLicense' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/OutfitterPanel.cpp:900:24: performance:inconclusive: Technically the member function 'OutfitterPanel::LicenseRoot' can be static (but you may consider moving to unnamed namespace). [functionStatic] endless-sky-0.10.14/source/OutfitterPanel.h:75:14: note: Technically the member function 'OutfitterPanel::LicenseRoot' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/OutfitterPanel.cpp:900:24: note: Technically the member function 'OutfitterPanel::LicenseRoot' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/ShopPanel.h:58:3: style: Class 'BuyResult' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/ShopPanel.h:59:3: style: Class 'BuyResult' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/ShopPanel.h:60:3: style: Class 'BuyResult' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/OutfitterPanel.cpp:170:7: style: The scope of the variable 'highlightDifferences' can be reduced. [variableScope] endless-sky-0.10.14/source/OutfitterPanel.cpp:90:12: style: Variable 'ship' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/OutfitterPanel.cpp:781:8: style: Variable 'color' can be declared as const array [constVariable] endless-sky-0.10.14/source/OutfitterPanel.cpp:92:6: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/OutfitterPanel.cpp:139:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/OutfitterPanel.cpp:434:4: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/OutfitterPanel.cpp:609:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/OutfitterPanel.cpp:725:4: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/OutfitterPanel.cpp:739:8: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Panel.cpp:338:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_ALT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Panel.cpp:377:51: style:inconclusive: Technically the member function 'Panel::GetChildren' can be const. [functionConst] endless-sky-0.10.14/source/Panel.h:116:45: note: Technically the member function 'Panel::GetChildren' can be const. endless-sky-0.10.14/source/Panel.cpp:377:51: note: Technically the member function 'Panel::GetChildren' can be const. endless-sky-0.10.14/source/Panel.cpp:117:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Panel.cpp:121:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Paragraphs.cpp:30:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Paragraphs.cpp:56:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Person.cpp:66:14: style:inconclusive: Technically the member function 'Person::FinishLoading' can be const. [functionConst] endless-sky-0.10.14/source/Person.h:40:7: note: Technically the member function 'Person::FinishLoading' can be const. endless-sky-0.10.14/source/Person.cpp:66:14: note: Technically the member function 'Person::FinishLoading' can be const. endless-sky-0.10.14/source/Person.cpp:142:14: style:inconclusive: Technically the member function 'Person::Destroy' can be const. [functionConst] endless-sky-0.10.14/source/Person.h:57:7: note: Technically the member function 'Person::Destroy' can be const. endless-sky-0.10.14/source/Person.cpp:142:14: note: Technically the member function 'Person::Destroy' can be const. endless-sky-0.10.14/source/Person.cpp:151:14: style:inconclusive: Technically the member function 'Person::Restore' can be const. [functionConst] endless-sky-0.10.14/source/Person.h:59:7: note: Technically the member function 'Person::Restore' can be const. endless-sky-0.10.14/source/Person.cpp:151:14: note: Technically the member function 'Person::Restore' can be const. endless-sky-0.10.14/source/Person.cpp:166:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Personality.cpp:239:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DISABLES [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Phrase.cpp:34:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Phrase.cpp:69:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Phrase.cpp:171:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Phrase.cpp:128:45: style:inconclusive: Function 'ReferencesPhrase' argument 1 names different: declaration 'phrase' definition 'other'. [funcArgNamesDifferent] endless-sky-0.10.14/source/Phrase.h:51:38: note: Function 'ReferencesPhrase' argument 1 names different: declaration 'phrase' definition 'other'. endless-sky-0.10.14/source/Phrase.cpp:128:45: note: Function 'ReferencesPhrase' argument 1 names different: declaration 'phrase' definition 'other'. endless-sky-0.10.14/source/Phrase.cpp:137:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Planet.cpp:277:7: style: Variable 'autoValues' can be declared as const array [constVariable] endless-sky-0.10.14/source/Planet.cpp:406:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Planet.cpp:725:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlanetLabel.cpp:231:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlanetLabel.cpp:235:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/TradingPanel.h:32:3: style: The destructor '~TradingPanel' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] endless-sky-0.10.14/source/Panel.h:50:11: note: Virtual destructor in base class endless-sky-0.10.14/source/TradingPanel.h:32:3: note: Destructor in derived class endless-sky-0.10.14/source/PlanetPanel.cpp:428:8: style: The scope of the variable 'otherUniquesCount' can be reduced. [variableScope] endless-sky-0.10.14/source/PlanetPanel.cpp:200:9: style: Variable 'oldPanel' can be declared as pointer to const [constVariablePointer] endless-sky-0.10.14/source/PlanetPanel.cpp:408:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:126:41: debug: Function::addArguments found argument 'm' with varid 0. [varid0] endless-sky-0.10.14/source/PlayerInfo.cpp:2719:45: debug: Function::addArguments found argument 'm' with varid 0. [varid0] endless-sky-0.10.14/source/PlayerInfo.cpp:3492:44: debug: Function::addArguments found argument 'm' with varid 0. [varid0] endless-sky-0.10.14/source/PlayerInfo.cpp:3403:76: debug: Function::addArguments found argument 'ship' with varid 0. [varid0] endless-sky-0.10.14/source/PlayerInfo.cpp:126:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PlayerInfo.cpp:2719:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PlayerInfo.cpp:3403:76: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ship [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PlayerInfo.cpp:3745:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PlayerInfo.cpp:4145:6: style: Condition '!gov' is always false [knownConditionTrueFalse] endless-sky-0.10.14/source/PlayerInfo.cpp:4152:6: style: Condition '!gov' is always false [knownConditionTrueFalse] endless-sky-0.10.14/source/PlayerInfo.cpp:1376:57: style:inconclusive: Function 'RaidFleetAttraction' argument 1 names different: declaration 'raidFleet' definition 'raid'. [funcArgNamesDifferent] endless-sky-0.10.14/source/PlayerInfo.h:188:46: note: Function 'RaidFleetAttraction' argument 1 names different: declaration 'raidFleet' definition 'raid'. endless-sky-0.10.14/source/PlayerInfo.cpp:1376:57: note: Function 'RaidFleetAttraction' argument 1 names different: declaration 'raidFleet' definition 'raid'. endless-sky-0.10.14/source/PlayerInfo.cpp:4340:37: style:inconclusive: Function 'Save' argument 1 names different: declaration 'path' definition 'filePath'. [funcArgNamesDifferent] endless-sky-0.10.14/source/PlayerInfo.h:385:31: note: Function 'Save' argument 1 names different: declaration 'path' definition 'filePath'. endless-sky-0.10.14/source/PlayerInfo.cpp:4340:37: note: Function 'Save' argument 1 names different: declaration 'path' definition 'filePath'. endless-sky-0.10.14/source/PlayerInfo.cpp:612:21: style: Local variable 'system' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.h:420:16: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:612:21: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:925:14: style: Local variable 'flagship' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.h:433:24: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:925:14: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:1217:21: style: Local variable 'it' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.cpp:1199:11: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:1217:21: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:1222:21: style: Local variable 'it' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.cpp:1199:11: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:1222:21: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:1246:21: style: Local variable 'it' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.cpp:1240:11: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:1246:21: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:1523:20: style: Local variable 'cargo' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.h:437:12: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:1523:20: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:1591:18: style: Local variable 'it' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.cpp:1516:37: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:1591:18: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:1957:10: style: Local variable 'entry' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.h:418:14: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:1957:10: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:2409:22: style: Local variable 'mission' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.cpp:2405:17: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:2409:22: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:2674:16: style: Local variable 'planet' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.h:421:16: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:2674:16: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:2855:20: style: Local variable 'system' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.h:420:16: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:2855:20: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:2874:20: style: Local variable 'system' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.h:420:16: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:2874:20: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:3364:22: style: Local variable 'planet' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.h:421:16: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:3364:22: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:4210:19: style: Local variable 'missions' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.h:445:21: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:4210:19: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:4374:20: style: Local variable 'system' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.h:420:16: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:4374:20: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:4522:19: style: Local variable 'cargo' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.h:437:12: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:4522:19: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:4698:16: style: Local variable 'planet' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.h:421:16: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:4698:16: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:4802:9: style: Local variable 'flagship' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PlayerInfo.h:433:24: note: Shadowed declaration endless-sky-0.10.14/source/PlayerInfo.cpp:4802:9: note: Shadow variable endless-sky-0.10.14/source/PlayerInfo.cpp:1749:14: style: Variable 'ship' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PlayerInfo.cpp:2027:82: style: Parameter 'here' can be declared as reference to const [constParameterReference] endless-sky-0.10.14/source/PlayerInfo.cpp:3373:12: style: Variable 'it' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PlayerInfo.cpp:3562:28: style: Parameter 'ce' can be declared as reference to const [constParameterReference] endless-sky-0.10.14/source/PlayerInfo.cpp:3575:28: style: Parameter 'ce' can be declared as reference to const [constParameterReference] endless-sky-0.10.14/source/PlayerInfo.cpp:3581:28: style: Parameter 'ce' can be declared as reference to const [constParameterReference] endless-sky-0.10.14/source/PlayerInfo.cpp:4148:24: style: Parameter 'ce' can be declared as reference to const [constParameterReference] endless-sky-0.10.14/source/PlayerInfo.cpp:4182:24: style: Parameter 'ce' can be declared as reference to const [constParameterReference] endless-sky-0.10.14/source/PlayerInfo.cpp:4301:12: style: Variable 'mission' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PlayerInfo.cpp:241:14: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] endless-sky-0.10.14/source/PlayerInfo.cpp:399:17: style: Consider using std::copy algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:932:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:1463:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:1752:6: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:2287:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:2315:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:2389:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:2409:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:2546:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:2568:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:2788:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:2792:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:3776:12: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:3782:12: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:3788:12: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:3794:12: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:3822:7: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:3830:7: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:3839:7: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:3847:7: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:3854:7: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:3861:7: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:3910:11: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:3962:12: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:4007:12: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:4050:11: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:4383:4: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:4708:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfo.cpp:4893:10: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfoPanel.cpp:63:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable second [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PlayerInfoPanel.cpp:288:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_CTRL [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PlayerInfoPanel.cpp:529:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_SHIFT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PlayerInfoPanel.cpp:332:35: style: Condition '!panelState.AllSelected().empty()' is always true [knownConditionTrueFalse] endless-sky-0.10.14/source/PlayerInfoPanel.cpp:319:36: note: Assuming that condition 'panelState.AllSelected().empty()' is not redundant endless-sky-0.10.14/source/PlayerInfoPanel.cpp:332:35: note: Condition '!panelState.AllSelected().empty()' is always true endless-sky-0.10.14/source/PlayerInfoPanel.cpp:178:69: performance: Function parameter 'panelState' should be passed by const reference. [passedByValue] endless-sky-0.10.14/source/PlayerInfoPanel.cpp:142:88: style: Parameter 'f' can be declared as reference to const [constParameterReference] endless-sky-0.10.14/source/PlayerInfoPanel.cpp:518:12: style: Variable 'zone' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PlayerInfoPanel.cpp:479:14: style: Variable 'ship' can be declared as pointer to const [constVariablePointer] endless-sky-0.10.14/source/PlayerInfoPanel.cpp:518:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfoPanel.cpp:675:10: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfoPanel.cpp:681:11: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PlayerInfoPanel.cpp:688:12: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Plugins.cpp:260:5: style: Condition 'plugin' is always true [knownConditionTrueFalse] endless-sky-0.10.14/source/Plugins.cpp:332:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Point.cpp:66:13: style:inconclusive: Boolean expression '!x' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] endless-sky-0.10.14/source/Point.cpp:66:13: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] endless-sky-0.10.14/source/Port.cpp:58:43: debug: Function::addArguments found argument 'valueNode' with varid 0. [varid0] endless-sky-0.10.14/source/Port.cpp:58:68: debug: Function::addArguments found argument 'value' with varid 0. [varid0] endless-sky-0.10.14/source/Port.cpp:79:43: debug: Function::addArguments found argument 'valueNode' with varid 0. [varid0] endless-sky-0.10.14/source/Port.cpp:79:68: debug: Function::addArguments found argument 'value' with varid 0. [varid0] endless-sky-0.10.14/source/Port.cpp:58:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable string [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Port.cpp:120:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable All [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Port.cpp:130:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable All [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Preferences.cpp:81:3: style: Class 'OverlaySetting' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] endless-sky-0.10.14/source/PreferencesPanel.cpp:156:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_COLOR_BUFFER_BIT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PreferencesPanel.cpp:226:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_DOWN [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PreferencesPanel.cpp:111:19: warning: Member variable 'PreferencesPanel::oldSelected' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/PreferencesPanel.cpp:111:19: warning: Member variable 'PreferencesPanel::oldHover' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/PreferencesPanel.cpp:111:19: warning: Member variable 'PreferencesPanel::latest' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/PreferencesPanel.cpp:585:6: style: Local variable 'page' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PreferencesPanel.h:91:7: note: Shadowed declaration endless-sky-0.10.14/source/PreferencesPanel.cpp:585:6: note: Shadow variable endless-sky-0.10.14/source/PreferencesPanel.cpp:779:6: style: Local variable 'page' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/PreferencesPanel.h:91:7: note: Shadowed declaration endless-sky-0.10.14/source/PreferencesPanel.cpp:779:6: note: Shadow variable endless-sky-0.10.14/source/PreferencesPanel.cpp:117:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PreferencesPanel.cpp:136:21: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PreferencesPanel.cpp:319:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/PrintData.cpp:57:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PrintData.cpp:78:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PrintData.cpp:94:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PrintData.cpp:104:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PrintData.cpp:121:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PrintData.cpp:148:4: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PrintData.cpp:353:4: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PrintData.cpp:600:4: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PrintData.cpp:662:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cin [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PrintData.cpp:765:2: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/PrintData.cpp:67:14: style: Variable 'saleName' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PrintData.cpp:105:13: style: Variable 'it' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PrintData.cpp:123:13: style: Variable 'it' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PrintData.cpp:133:14: style: Variable 'it' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PrintData.cpp:187:15: style: Variable 'hardpoint' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PrintData.cpp:280:15: style: Variable 'hardpoint' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PrintData.cpp:510:14: style: Variable 'it' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PrintData.cpp:522:14: style: Variable 'it' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PrintData.cpp:601:14: style: Variable 'it' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PrintData.cpp:605:15: style: Variable 'whenText' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/PrintData.cpp:608:15: style: Variable 'whenText' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/Projectile.cpp:51:13: warning: Member variable 'Projectile::phasedShip' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/Projectile.cpp:83:13: warning: Member variable 'Projectile::phasedShip' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/Projectile.cpp:114:13: warning: Member variable 'Projectile::phasedShip' is not initialized in the constructor. [uninitMemberVar] endless-sky-0.10.14/source/RaidFleet.cpp:39:48: debug: Function::addArguments found argument 'raidFleet' with varid 0. [varid0] endless-sky-0.10.14/source/RaidFleet.cpp:39:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable raidFleet [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Random.cpp:66:31: style:inconclusive: Function 'Int' argument 1 names different: declaration 'modulus' definition 'upper_bound'. [funcArgNamesDifferent] endless-sky-0.10.14/source/Random.h:32:31: note: Function 'Int' argument 1 names different: declaration 'modulus' definition 'upper_bound'. endless-sky-0.10.14/source/Random.cpp:66:31: note: Function 'Int' argument 1 names different: declaration 'modulus' definition 'upper_bound'. endless-sky-0.10.14/source/Rectangle.cpp:197:39: style:inconclusive: Function 'Overlaps' argument 1 names different: declaration 'center' definition 'circle'. [funcArgNamesDifferent] endless-sky-0.10.14/source/Rectangle.h:68:29: note: Function 'Overlaps' argument 1 names different: declaration 'center' definition 'circle'. endless-sky-0.10.14/source/Rectangle.cpp:197:39: note: Function 'Overlaps' argument 1 names different: declaration 'center' definition 'circle'. endless-sky-0.10.14/source/RenderBuffer.cpp:59:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/RenderBuffer.cpp:107:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_FRAMEBUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/RenderBuffer.cpp:162:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_VIEWPORT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/RenderBuffer.cpp:181:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_FRAMEBUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/RenderBuffer.cpp:199:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TEXTURE_2D [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/RenderBuffer.cpp:272:41: warning: Function 'SetFadePadding' argument order different: declaration 'top, bottom, right, left' definition 'top, bottom, left, right' [funcArgOrderDifferent] endless-sky-0.10.14/source/RenderBuffer.h:75:28: note: Function 'SetFadePadding' argument order different: declaration 'top, bottom, right, left' definition 'top, bottom, left, right' endless-sky-0.10.14/source/RenderBuffer.cpp:272:41: note: Function 'SetFadePadding' argument order different: declaration 'top, bottom, right, left' definition 'top, bottom, left, right' endless-sky-0.10.14/source/RoutePlan.cpp:70:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/RoutePlan.cpp:81:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable days [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/RoutePlan.cpp:92:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable fuel [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/RoutePlan.cpp:102:9: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/RoutePlan.cpp:113:9: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/SavedGame.cpp:78:5: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/ScrollBar.cpp:54:17: style:inconclusive: Technically the member function 'ScrollBar::DrawAt' can be const. [functionConst] endless-sky-0.10.14/source/ScrollBar.h:46:7: note: Technically the member function 'ScrollBar::DrawAt' can be const. endless-sky-0.10.14/source/ScrollBar.cpp:54:17: note: Technically the member function 'ScrollBar::DrawAt' can be const. endless-sky-0.10.14/source/ScrollVar.h:183:29: warning: The class 'ScrollVar' defines member function with name 'operator=' also defined in its parent class 'Animate'. [duplInheritedMember] endless-sky-0.10.14/source/Animate.h:126:25: note: Parent function 'Animate::operator=' endless-sky-0.10.14/source/ScrollVar.h:183:29: note: Derived function 'ScrollVar::operator=' endless-sky-0.10.14/source/Ship.cpp:888:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/Ship.cpp:1326:20: style: Boolean value assigned to floating point variable. [assignBoolToFloat] endless-sky-0.10.14/source/Ship.cpp:1327:19: style: Boolean value assigned to floating point variable. [assignBoolToFloat] endless-sky-0.10.14/source/Ship.cpp:1473:7: style: Boolean value assigned to floating point variable. [assignBoolToFloat] endless-sky-0.10.14/source/Ship.cpp:3367:17: style: Redundant condition: IsYours(). '!IsYours() || (IsYours() && escort->IsYours())' is equivalent to '!IsYours() || escort->IsYours()' [redundantCondition] endless-sky-0.10.14/source/Ship.cpp:310:6: style: Condition 'reverse' is always true [knownConditionTrueFalse] endless-sky-0.10.14/source/Ship.cpp:309:52: note: Assuming that condition '!reverse' is not redundant endless-sky-0.10.14/source/Ship.cpp:310:6: note: Condition 'reverse' is always true endless-sky-0.10.14/source/Ship.cpp:1682:5: style: Condition '!isBeingDestroyed' is always true [knownConditionTrueFalse] endless-sky-0.10.14/source/Ship.cpp:1676:19: note: Assuming that condition 'destroyResult>0' is not redundant endless-sky-0.10.14/source/Ship.cpp:1679:32: note: Assignment 'isBeingDestroyed=destroyResult', assigned value is less than 1 endless-sky-0.10.14/source/Ship.cpp:1682:5: note: Condition '!isBeingDestroyed' is always true endless-sky-0.10.14/source/Ship.cpp:1696:5: style: Condition '!isBeingDestroyed' is always true [knownConditionTrueFalse] endless-sky-0.10.14/source/Ship.cpp:1676:19: note: Assuming that condition 'destroyResult>0' is not redundant endless-sky-0.10.14/source/Ship.cpp:1679:32: note: Assignment 'isBeingDestroyed=destroyResult', assigned value is less than 1 endless-sky-0.10.14/source/Ship.cpp:1689:22: note: Assuming container is not empty endless-sky-0.10.14/source/Ship.cpp:1696:5: note: Condition '!isBeingDestroyed' is always true endless-sky-0.10.14/source/Ship.cpp:679:9: style:inconclusive: Same expression used in consecutive assignments of 'nextGun' and 'nextTurret'. [duplicateAssignExpression] endless-sky-0.10.14/source/Ship.cpp:680:9: note: Same expression used in consecutive assignments of 'nextGun' and 'nextTurret'. endless-sky-0.10.14/source/Ship.cpp:679:9: note: Same expression used in consecutive assignments of 'nextGun' and 'nextTurret'. endless-sky-0.10.14/source/Ship.cpp:1321:9: style: The scope of the variable 'thrustEnergy' can be reduced. [variableScope] endless-sky-0.10.14/source/Ship.cpp:1322:9: style: The scope of the variable 'thrustHeat' can be reduced. [variableScope] endless-sky-0.10.14/source/Ship.cpp:1324:9: style: The scope of the variable 'turnEnergy' can be reduced. [variableScope] endless-sky-0.10.14/source/Ship.cpp:1325:9: style: The scope of the variable 'turnHeat' can be reduced. [variableScope] endless-sky-0.10.14/source/Ship.cpp:1326:9: style: The scope of the variable 'hyperDrive' can be reduced. [variableScope] endless-sky-0.10.14/source/Ship.cpp:1327:9: style: The scope of the variable 'jumpDrive' can be reduced. [variableScope] endless-sky-0.10.14/source/Ship.cpp:3860:56: style:inconclusive: Function 'SetFormationPattern' argument 1 names different: declaration 'formation' definition 'formationToSet'. [funcArgNamesDifferent] endless-sky-0.10.14/source/Ship.h:525:51: note: Function 'SetFormationPattern' argument 1 names different: declaration 'formation' definition 'formationToSet'. endless-sky-0.10.14/source/Ship.cpp:3860:56: note: Function 'SetFormationPattern' argument 1 names different: declaration 'formation' definition 'formationToSet'. endless-sky-0.10.14/source/Ship.cpp:358:30: style: Local variable 'attributes' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Ship.h:666:9: note: Shadowed declaration endless-sky-0.10.14/source/Ship.cpp:358:30: note: Shadow variable endless-sky-0.10.14/source/Ship.cpp:1093:16: style: Local variable 'attributes' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Ship.h:666:9: note: Shadowed declaration endless-sky-0.10.14/source/Ship.cpp:1093:16: note: Shadow variable endless-sky-0.10.14/source/Ship.cpp:1160:27: style: Local variable 'parent' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Ship.h:769:22: note: Shadowed declaration endless-sky-0.10.14/source/Ship.cpp:1160:27: note: Shadow variable endless-sky-0.10.14/source/Ship.cpp:1314:9: style: Local variable 'energy' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Ship.h:688:9: note: Shadowed declaration endless-sky-0.10.14/source/Ship.cpp:1314:9: note: Shadow variable endless-sky-0.10.14/source/Ship.cpp:1317:9: style: Local variable 'fuel' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Ship.h:687:9: note: Shadowed declaration endless-sky-0.10.14/source/Ship.cpp:1317:9: note: Shadow variable endless-sky-0.10.14/source/Ship.cpp:1927:9: style: Local variable 'outfits' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Ship.h:670:32: note: Shadowed declaration endless-sky-0.10.14/source/Ship.cpp:1927:9: note: Shadow variable endless-sky-0.10.14/source/Ship.cpp:1928:9: style: Local variable 'cargo' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Ship.h:671:12: note: Shadowed declaration endless-sky-0.10.14/source/Ship.cpp:1928:9: note: Shadow variable endless-sky-0.10.14/source/Ship.cpp:2807:9: style: Local variable 'hull' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Ship.h:686:9: note: Shadowed declaration endless-sky-0.10.14/source/Ship.cpp:2807:9: note: Shadow variable endless-sky-0.10.14/source/Ship.cpp:4515:20: style: Local variable 'parent' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/Ship.h:769:22: note: Shadowed declaration endless-sky-0.10.14/source/Ship.cpp:4515:20: note: Shadow variable endless-sky-0.10.14/source/Ship.cpp:4366:81: style: Parameter 'flotsam' can be declared as reference to const [constParameterReference] endless-sky-0.10.14/source/Ship.cpp:830:16: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Ship.cpp:1371:4: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Ship.cpp:1804:13: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Ship.cpp:3329:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Ship.cpp:3340:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Ship.cpp:3398:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Ship.cpp:3973:13: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Ship.cpp:4542:6: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/Ship.cpp:5071:7: style: Variable 'it' is assigned a value that is never used. [unreadVariable] endless-sky-0.10.14/source/ShipInfoPanel.cpp:151:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_CTRL [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/ShipInfoPanel.cpp:689:21: performance:inconclusive: Technically the member function 'ShipInfoPanel::DrawLine' can be static (but you may consider moving to unnamed namespace). [functionStatic] endless-sky-0.10.14/source/ShipInfoPanel.h:72:7: note: Technically the member function 'ShipInfoPanel::DrawLine' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/ShipInfoPanel.cpp:689:21: note: Technically the member function 'ShipInfoPanel::DrawLine' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/ShipInfoPanel.cpp:351:21: warning: The class 'ShipInfoPanel' defines member function with name 'ClearZones' also defined in its parent class 'Panel'. [duplInheritedMember] endless-sky-0.10.14/source/Panel.h:68:7: note: Parent function 'Panel::ClearZones' endless-sky-0.10.14/source/ShipInfoPanel.cpp:351:21: note: Derived function 'ShipInfoPanel::ClearZones' endless-sky-0.10.14/source/ShipInfoPanel.cpp:610:45: style: Condition 'table.GetRowBounds().Bottom()=0.' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] endless-sky-0.10.14/source/image/Mask.cpp:484:34: style:inconclusive: Boolean expression 'uA>=0.' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] endless-sky-0.10.14/source/image/Mask.cpp:445:10: style: Local variable 'radius' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/image/Mask.h:76:9: note: Shadowed declaration endless-sky-0.10.14/source/image/Mask.cpp:445:10: note: Shadow variable endless-sky-0.10.14/source/image/Mask.cpp:276:11: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/image/Mask.cpp:383:2: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/image/Mask.cpp:384:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/image/Mask.cpp:415:10: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/image/Mask.cpp:444:6: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/image/MaskManager.cpp:100:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable second [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/image/MaskManager.cpp:85:11: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/image/Sprite.cpp:39:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TEXTURE_2D_ARRAY [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/image/SpriteSet.cpp:61:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/main.cpp:201:4: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/main.cpp:317:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_MOUSEMOTION [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/main.cpp:519:2: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/main.cpp:544:2: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/main.cpp:560:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cin [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/main.cpp:600:4: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/main.cpp:288:7: style: The scope of the variable 'showCursor' can be reduced. [variableScope] endless-sky-0.10.14/source/main.cpp:270:17: style:inconclusive: Function 'GameLoop' argument 4 names different: declaration 'testToRun' definition 'testToRunName'. [funcArgNamesDifferent] endless-sky-0.10.14/source/main.cpp:72:16: note: Function 'GameLoop' argument 4 names different: declaration 'testToRun' definition 'testToRunName'. endless-sky-0.10.14/source/main.cpp:270:17: note: Function 'GameLoop' argument 4 names different: declaration 'testToRun' definition 'testToRunName'. endless-sky-0.10.14/source/main.cpp:563:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/opengl.cpp:62:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GLX_EXT_swap_control_tear [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/BatchShader.cpp:65:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/BatchShader.cpp:93:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/BatchShader.cpp:109:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TEXTURE_2D_ARRAY [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/BatchShader.cpp:125:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/FillShader.cpp:54:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/FillShader.cpp:93:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TRIANGLE_STRIP [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/FogShader.cpp:83:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/FogShader.cpp:189:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TEXTURE_2D [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/FogShader.cpp:178:10: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/shader/LineShader.cpp:62:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/LineShader.cpp:136:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TRIANGLE_STRIP [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/OutlineShader.cpp:65:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/OutlineShader.cpp:123:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TEXTURE_2D_ARRAY [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/PointerShader.cpp:60:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/PointerShader.cpp:121:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TRIANGLES [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/RingShader.cpp:65:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/RingShader.cpp:141:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TRIANGLE_STRIP [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/Shader.cpp:32:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_VERTEX_SHADER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/Shader.cpp:103:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_SHADING_LANGUAGE_VERSION [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/Shader.cpp:93:16: performance:inconclusive: Technically the member function 'Shader::Compile' can be static (but you may consider moving to unnamed namespace). [functionStatic] endless-sky-0.10.14/source/shader/Shader.h:38:9: note: Technically the member function 'Shader::Compile' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/shader/Shader.cpp:93:16: note: Technically the member function 'Shader::Compile' can be static (but you may consider moving to unnamed namespace). endless-sky-0.10.14/source/shader/Shader.cpp:144:11: style: Local variable 'length' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/shader/Shader.cpp:125:9: note: Shadowed declaration endless-sky-0.10.14/source/shader/Shader.cpp:144:11: note: Shadow variable endless-sky-0.10.14/source/shader/SpriteShader.cpp:77:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/SpriteShader.cpp:160:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_FALSE [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/StarField.cpp:253:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TRIANGLES [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/StarField.cpp:304:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/StarField.cpp:412:81: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_STATIC_DRAW [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/shader/StarField.cpp:215:10: style: Local variable 'baseZoom' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/shader/StarField.h:65:9: note: Shadowed declaration endless-sky-0.10.14/source/shader/StarField.cpp:215:10: note: Shadow variable endless-sky-0.10.14/source/shader/StarField.cpp:381:7: style: Local variable 'x' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/shader/StarField.cpp:352:6: note: Shadowed declaration endless-sky-0.10.14/source/shader/StarField.cpp:381:7: note: Shadow variable endless-sky-0.10.14/source/shader/StarField.cpp:382:7: style: Local variable 'y' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/shader/StarField.cpp:353:6: note: Shadowed declaration endless-sky-0.10.14/source/shader/StarField.cpp:382:7: note: Shadow variable endless-sky-0.10.14/source/test/Test.cpp:86:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_KEYDOWN [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/test/Test.cpp:99:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_QUIT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/test/Test.cpp:142:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_SHIFT [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/test/Test.cpp:351:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/test/Test.cpp:497:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/test/Test.cpp:609:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stepType [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/test/Test.cpp:561:22: style: Local variable 'name' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/test/Test.h:136:14: note: Shadowed declaration endless-sky-0.10.14/source/test/Test.cpp:561:22: note: Shadow variable endless-sky-0.10.14/source/test/Test.cpp:567:22: style: Local variable 'name' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/test/Test.h:136:14: note: Shadowed declaration endless-sky-0.10.14/source/test/Test.cpp:567:22: note: Shadow variable endless-sky-0.10.14/source/test/Test.cpp:577:22: style: Local variable 'name' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/test/Test.h:136:14: note: Shadowed declaration endless-sky-0.10.14/source/test/Test.cpp:577:22: note: Shadow variable endless-sky-0.10.14/source/test/TestData.cpp:59:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SAVEGAME [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/test/TestData.cpp:98:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] endless-sky-0.10.14/source/text/Clipboard.cpp:29:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_CTRL [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Clipboard.cpp:67:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Clipboard.cpp:50:35: style:inconclusive: Function 'Set' argument 1 names different: declaration 'inputBuffer' definition 'text'. [funcArgNamesDifferent] endless-sky-0.10.14/source/text/Clipboard.h:35:37: note: Function 'Set' argument 1 names different: declaration 'inputBuffer' definition 'text'. endless-sky-0.10.14/source/text/Clipboard.cpp:50:35: note: Function 'Set' argument 1 names different: declaration 'inputBuffer' definition 'text'. endless-sky-0.10.14/source/text/Font.cpp:110:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TEXTURE_2D [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Font.cpp:233:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TEXTURE_2D [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Font.cpp:326:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Font.cpp:263:8: style: Local variable 'glyphWidth' shadows outer variable [shadowVariable] endless-sky-0.10.14/source/text/Font.h:88:10: note: Shadowed declaration endless-sky-0.10.14/source/text/Font.cpp:263:8: note: Shadow variable endless-sky-0.10.14/source/text/Font.cpp:269:15: style: Variable 'pit' can be declared as pointer to const [constVariablePointer] endless-sky-0.10.14/source/text/Font.cpp:280:16: style: Variable 'nend' can be declared as pointer to const [constVariablePointer] endless-sky-0.10.14/source/text/Format.cpp:104:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable second [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Format.cpp:154:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Format.cpp:186:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Format.cpp:241:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Format.cpp:660:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable string [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Format.cpp:696:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Format.cpp:750:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Format.cpp:765:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] endless-sky-0.10.14/source/text/Format.cpp:697:17: style: Redundant initialization for 'findPos'. The initialized value is overwritten before it is read. [redundantInitialization] endless-sky-0.10.14/source/text/Format.cpp:696:17: note: findPos is initialized endless-sky-0.10.14/source/text/Format.cpp:697:17: note: findPos is overwritten endless-sky-0.10.14/source/text/Format.cpp:68:14: style: Variable 'nameValue' can be declared as reference to const [constVariableReference] endless-sky-0.10.14/source/text/Format.cpp:377:63: warning: Either the condition 'i