2025-07-07 19:44 ftp://ftp.de.debian.org/debian/pool/main/e/edtsurf/edtsurf_0.2009.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=bsd --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j1 platform: Linux-6.8.0-63-generic-x86_64-with-glibc2.39 python: 3.12.3 client-version: 1.3.67 compiler: g++ (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0 cppcheck: head 2.17.0 head-info: 8833e3e (2025-07-07 13:50:36 +0200) count: 176 176 elapsed-time: 1198.0 1366.1 head-timing-info: old-timing-info: head results: EDTSurf.cpp:348:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CLOCKS_PER_SEC [valueFlowBailoutIncompleteVar] EDTSurf.cpp:157:12: error: Array 'flagopt[7]' accessed at index 7, which is out of bounds. [arrayIndexOutOfBounds] EDTSurf.cpp:228:12: warning: Either the condition 'lpre>=0' is redundant or the array 'inname[200]' is accessed at index -1, which is out of bounds. [negativeIndex] EDTSurf.cpp:226:13: note: Assuming that condition 'lpre>=0' is not redundant EDTSurf.cpp:228:12: note: Negative array index EDTSurf.cpp:357:11: warning: If resource allocation fails, then there is a possible null pointer dereference: file [nullPointerOutOfResources] EDTSurf.cpp:356:13: note: Assuming allocation function fails EDTSurf.cpp:356:13: note: Assignment 'file=fopen(filename,"wt")', assigned value is 0 EDTSurf.cpp:357:11: note: Null pointer dereference EDTSurf.cpp:360:12: warning: If resource allocation fails, then there is a possible null pointer dereference: file [nullPointerOutOfResources] EDTSurf.cpp:356:13: note: Assuming allocation function fails EDTSurf.cpp:356:13: note: Assignment 'file=fopen(filename,"wt")', assigned value is 0 EDTSurf.cpp:360:12: note: Null pointer dereference EDTSurf.cpp:362:10: warning: If resource allocation fails, then there is a possible null pointer dereference: file [nullPointerOutOfResources] EDTSurf.cpp:356:13: note: Assuming allocation function fails EDTSurf.cpp:356:13: note: Assignment 'file=fopen(filename,"wt")', assigned value is 0 EDTSurf.cpp:362:10: note: Null pointer dereference EDTSurf.cpp:365:11: warning: If resource allocation fails, then there is a possible null pointer dereference: file [nullPointerOutOfResources] EDTSurf.cpp:364:13: note: Assuming allocation function fails EDTSurf.cpp:364:13: note: Assignment 'file=fopen(filename,"wt")', assigned value is 0 EDTSurf.cpp:365:11: note: Null pointer dereference EDTSurf.cpp:376:12: warning: If resource allocation fails, then there is a possible null pointer dereference: file [nullPointerOutOfResources] EDTSurf.cpp:364:13: note: Assuming allocation function fails EDTSurf.cpp:364:13: note: Assignment 'file=fopen(filename,"wt")', assigned value is 0 EDTSurf.cpp:376:12: note: Null pointer dereference EDTSurf.cpp:378:10: warning: If resource allocation fails, then there is a possible null pointer dereference: file [nullPointerOutOfResources] EDTSurf.cpp:364:13: note: Assuming allocation function fails EDTSurf.cpp:364:13: note: Assignment 'file=fopen(filename,"wt")', assigned value is 0 EDTSurf.cpp:378:10: note: Null pointer dereference ParsePDB.cpp:149:11: warning: Member variable 'ParsePDB::pdbname' is not initialized in the constructor. [uninitMemberVar] ParsePDB.cpp:149:11: warning: Member variable 'ParsePDB::headidchain' is not initialized in the constructor. [uninitMemberVar] ParsePDB.cpp:149:11: warning: Member variable 'ParsePDB::numinchain' is not initialized in the constructor. [uninitMemberVar] ParsePDB.cpp:149:11: warning: Member variable 'ParsePDB::effbb' is not initialized in the constructor. [uninitMemberVar] ParsePDB.cpp:1572:15: performance:inconclusive: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). [functionStatic] ParsePDB.h:51:6: note: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). ParsePDB.cpp:1572:15: note: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). ParsePDB.cpp:1551:15: performance:inconclusive: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). [functionStatic] ParsePDB.h:52:6: note: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). ParsePDB.cpp:1551:15: note: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). ParsePDB.cpp:472:4: error: Common realloc mistake: 'helixl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:540:4: error: Common realloc mistake: 'sheetl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:636:4: error: Common realloc mistake: 'turnl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:685:4: error: Common realloc mistake: 'linkl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:739:4: error: Common realloc mistake: 'ssbondl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:774:4: error: Common realloc mistake: 'hydbndl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:830:4: error: Common realloc mistake: 'sltbrgl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:886:4: error: Common realloc mistake: 'cispepl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:936:4: error: Common realloc mistake: 'sitel' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:997:4: error: Common realloc mistake: 'promod' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1084:4: error: Common realloc mistake: 'proseq' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1474:2: error: Common realloc mistake: 'helixl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1475:2: error: Common realloc mistake: 'sheetl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1476:2: error: Common realloc mistake: 'turnl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1477:2: error: Common realloc mistake: 'linkl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1479:2: error: Common realloc mistake: 'ssbondl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1480:2: error: Common realloc mistake: 'hydbndl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1481:2: error: Common realloc mistake: 'sltbrgl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1482:2: error: Common realloc mistake: 'cispepl' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1483:2: error: Common realloc mistake: 'sitel' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1485:2: error: Common realloc mistake: 'proseq' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1486:2: error: Common realloc mistake: 'promod' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1666:5: error: Common realloc mistake: 'bb' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1670:3: error: Common realloc mistake: 'bb' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1712:5: error: Common realloc mistake: 'bb' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:1717:3: error: Common realloc mistake: 'bb' nulled but not freed upon failure [memleakOnRealloc] ParsePDB.cpp:36:3: warning: If memory allocation fails, then there is a possible null pointer dereference: b [nullPointerOutOfMemory] ParsePDB.cpp:19:23: note: Assuming allocation function fails ParsePDB.cpp:19:7: note: Assignment 'b=(double*)calloc(n,sizeof(double))', assigned value is 0 ParsePDB.cpp:36:3: note: Null pointer dereference ParsePDB.cpp:37:3: warning: If memory allocation fails, then there is a possible null pointer dereference: z [nullPointerOutOfMemory] ParsePDB.cpp:21:23: note: Assuming allocation function fails ParsePDB.cpp:21:7: note: Assignment 'z=(double*)calloc(n,sizeof(double))', assigned value is 0 ParsePDB.cpp:37:3: note: Null pointer dereference ParsePDB.cpp:1546:12: warning: If resource allocation fails, then there is a possible null pointer dereference: outfile [nullPointerOutOfResources] ParsePDB.cpp:1528:18: note: Assuming allocation function fails ParsePDB.cpp:1528:18: note: Assignment 'outfile=fopen(tmpname,"wr")', assigned value is 0 ParsePDB.cpp:1546:12: note: Null pointer dereference ParsePDB.cpp:19:7: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:21:7: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:472:13: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:540:13: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:636:12: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:685:12: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:739:14: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:774:14: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:830:14: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:886:14: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:936:12: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:997:13: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1084:13: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1474:11: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1475:11: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1476:10: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1477:10: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1479:12: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1480:12: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1481:12: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1482:12: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1483:10: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1485:11: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1486:11: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1666:10: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1670:8: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1712:10: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1717:8: style: C-style pointer casting [cstyleCast] ParsePDB.cpp:1133:29: style: Variable 'proseq[numproseq].detail' is reassigned a value before the old one has been used. [redundantAssignment] ParsePDB.cpp:1128:27: note: proseq[numproseq].detail is assigned ParsePDB.cpp:1133:29: note: proseq[numproseq].detail is overwritten ParsePDB.cpp:18:12: style: The scope of the variable 'sm' can be reduced. [variableScope] ParsePDB.cpp:265:7: style: The scope of the variable 'tmpstr' can be reduced. [variableScope] ParsePDB.cpp:312:8: style: The scope of the variable 'aminum' can be reduced. [variableScope] ParsePDB.cpp:348:8: style: The scope of the variable 'aminum' can be reduced. [variableScope] ParsePDB.cpp:954:7: style: The scope of the variable 'temamii' can be reduced. [variableScope] ParsePDB.cpp:954:15: style: The scope of the variable 'temseqi' can be reduced. [variableScope] ParsePDB.cpp:1001:13: style: Local variable 'j' shadows outer variable [shadowVariable] ParsePDB.cpp:264:8: note: Shadowed declaration ParsePDB.cpp:1001:13: note: Shadow variable ParsePDB.cpp:262:30: style: Parameter 'string' can be declared as pointer to const [constParameterPointer] ParsePDB.cpp:1352:30: style: Parameter 'pdbfile' can be declared as pointer to const [constParameterPointer] ParsePDB.cpp:1572:29: style: Parameter 'aminoname' can be declared as pointer to const [constParameterPointer] ParsePDB.cpp:987:11: style: Variable 'tempnumi' is assigned a value that is never used. [unreadVariable] ParsePDB.cpp:1031:11: style: Variable 'tempnumi' is assigned a value that is never used. [unreadVariable] ParsePDB.cpp:1034:14: style: Variable 'tempami[i]' is assigned a value that is never used. [unreadVariable] ParsePDB.cpp:1036:9: style: Variable 'tempid' is assigned a value that is never used. [unreadVariable] ParsePDB.cpp:1042:13: style: Variable 'tempindexi' is assigned a value that is never used. [unreadVariable] ParsePDB.cpp:1338:27: style: Variable 'd[2]' is assigned a value that is never used. [unreadVariable] ParsePDB.cpp:1342:12: style: Variable 'pcamat[i]' is assigned a value that is never used. [unreadVariable] ProteinSurface.cpp:1320:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] ProteinSurface.cpp:20:17: warning: Member variable 'ProteinSurface::ptran' is not initialized in the constructor. [uninitMemberVar] ProteinSurface.cpp:20:17: warning: Member variable 'ProteinSurface::pmin' is not initialized in the constructor. [uninitMemberVar] ProteinSurface.cpp:20:17: warning: Member variable 'ProteinSurface::pmax' is not initialized in the constructor. [uninitMemberVar] ProteinSurface.cpp:20:17: warning: Member variable 'ProteinSurface::widxz' is not initialized in the constructor. [uninitMemberVar] ProteinSurface.cpp:20:17: warning: Member variable 'ProteinSurface::cutradis' is not initialized in the constructor. [uninitMemberVar] ProteinSurface.cpp:20:17: warning: Member variable 'ProteinSurface::inarray' is not initialized in the constructor. [uninitMemberVar] ProteinSurface.cpp:20:17: warning: Member variable 'ProteinSurface::outarray' is not initialized in the constructor. [uninitMemberVar] ProteinSurface.cpp:20:17: warning: Member variable 'ProteinSurface::totalsurfacevox' is not initialized in the constructor. [uninitMemberVar] ProteinSurface.cpp:20:17: warning: Member variable 'ProteinSurface::totalinnervox' is not initialized in the constructor. [uninitMemberVar] ProteinSurface.cpp:20:17: warning: Member variable 'ProteinSurface::numdep' is not initialized in the constructor. [uninitMemberVar] ProteinSurface.cpp:754:22: performance:inconclusive: Technically the member function 'ProteinSurface::boundbox' can be static (but you may consider moving to unnamed namespace). [functionStatic] ProteinSurface.h:585:7: note: Technically the member function 'ProteinSurface::boundbox' can be static (but you may consider moving to unnamed namespace). ProteinSurface.cpp:754:22: note: Technically the member function 'ProteinSurface::boundbox' can be static (but you may consider moving to unnamed namespace). ProteinSurface.cpp:783:22: style:inconclusive: Technically the member function 'ProteinSurface::atomsinout' can be const. [functionConst] ProteinSurface.h:628:7: note: Technically the member function 'ProteinSurface::atomsinout' can be const. ProteinSurface.cpp:783:22: note: Technically the member function 'ProteinSurface::atomsinout' can be const. ProteinSurface.cpp:1261:22: style:inconclusive: Technically the member function 'ProteinSurface::outsas' can be const. [functionConst] ProteinSurface.h:631:7: note: Technically the member function 'ProteinSurface::outsas' can be const. ProteinSurface.cpp:1261:22: note: Technically the member function 'ProteinSurface::outsas' can be const. ProteinSurface.cpp:1997:8: style: Redundant condition: vp[i][j][k].isdone. '!A || (A && B)' is equivalent to '!A || B' [redundantCondition] ProteinSurface.cpp:1596:35: style: Condition 'vp[si][sj][sk].inout' is always true [knownConditionTrueFalse] ProteinSurface.cpp:1589:33: note: Assuming that condition 'vp[si][sj][sk].inout==false' is not redundant ProteinSurface.cpp:1596:35: note: Condition 'vp[si][sj][sk].inout' is always true ProteinSurface.cpp:1786:35: style: Condition 'vp[si][sj][sk].isdone' is always true [knownConditionTrueFalse] ProteinSurface.cpp:1779:34: note: Assuming that condition 'vp[si][sj][sk].isdone==false' is not redundant ProteinSurface.cpp:1786:35: note: Condition 'vp[si][sj][sk].isdone' is always true ProteinSurface.cpp:344:5: error: Common realloc mistake: 'dupvert' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:523:2: error: Common realloc mistake: 'verts' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:1922:5: error: Common realloc mistake: 'inarray' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:2045:4: error: Common realloc mistake: 'outarray' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:2113:4: error: Common realloc mistake: 'outarray' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:2180:4: error: Common realloc mistake: 'outarray' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:2697:6: error: Common realloc mistake: 'verts' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:2702:6: error: Common realloc mistake: 'faces' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:2752:2: error: Common realloc mistake: 'verts' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:2753:2: error: Common realloc mistake: 'faces' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:2841:6: error: Common realloc mistake: 'verts' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:2846:6: error: Common realloc mistake: 'faces' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:2976:2: error: Common realloc mistake: 'verts' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:2977:2: error: Common realloc mistake: 'faces' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:4157:6: error: Common realloc mistake: 'verts' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:4162:6: error: Common realloc mistake: 'faces' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:5926:2: error: Common realloc mistake: 'verts' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:5927:2: error: Common realloc mistake: 'faces' nulled but not freed upon failure [memleakOnRealloc] ProteinSurface.cpp:1309:10: warning: If resource allocation fails, then there is a possible null pointer dereference: stream [nullPointerOutOfResources] ProteinSurface.cpp:1308:15: note: Assuming allocation function fails ProteinSurface.cpp:1308:15: note: Assignment 'stream=fopen(filename,"w+t")', assigned value is 0 ProteinSurface.cpp:1309:10: note: Null pointer dereference ProteinSurface.cpp:1322:9: warning: If resource allocation fails, then there is a possible null pointer dereference: stream [nullPointerOutOfResources] ProteinSurface.cpp:1308:15: note: Assuming allocation function fails ProteinSurface.cpp:1308:15: note: Assignment 'stream=fopen(filename,"w+t")', assigned value is 0 ProteinSurface.cpp:1322:9: note: Null pointer dereference ProteinSurface.cpp:344:13: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:523:8: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:1922:13: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:2045:13: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:2113:13: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:2180:13: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:2697:12: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:2702:12: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:2752:8: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:2753:8: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:2841:12: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:2846:12: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:2976:8: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:2977:8: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:4157:12: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:4162:12: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:5926:8: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:5927:8: style: C-style pointer casting [cstyleCast] ProteinSurface.cpp:290:10: style: Variable 'k' is reassigned a value before the old one has been used. [redundantAssignment] ProteinSurface.cpp:289:6: note: k is assigned ProteinSurface.cpp:290:10: note: k is overwritten ProteinSurface.cpp:50:8: style: The scope of the variable 'j' can be reduced. [variableScope] ProteinSurface.cpp:94:8: style: The scope of the variable 'tind' can be reduced. [variableScope] ProteinSurface.cpp:146:6: style: The scope of the variable 'ia' can be reduced. [variableScope] ProteinSurface.cpp:146:9: style: The scope of the variable 'ib' can be reduced. [variableScope] ProteinSurface.cpp:146:12: style: The scope of the variable 'ic' can be reduced. [variableScope] ProteinSurface.cpp:573:7: style: The scope of the variable 'flagvert' can be reduced. [variableScope] ProteinSurface.cpp:807:10: style: The scope of the variable 'ia' can be reduced. [variableScope] ProteinSurface.cpp:807:13: style: The scope of the variable 'ib' can be reduced. [variableScope] ProteinSurface.cpp:807:16: style: The scope of the variable 'ic' can be reduced. [variableScope] ProteinSurface.cpp:833:13: style: The scope of the variable 'narrout' can be reduced. [variableScope] ProteinSurface.cpp:1140:6: style: The scope of the variable 'outnum' can be reduced. [variableScope] ProteinSurface.cpp:1425:19: style: The scope of the variable 'sradius' can be reduced. [variableScope] ProteinSurface.cpp:1426:6: style: The scope of the variable 'indx' can be reduced. [variableScope] ProteinSurface.cpp:1467:6: style: The scope of the variable 'i' can be reduced. [variableScope] ProteinSurface.cpp:1467:8: style: The scope of the variable 'j' can be reduced. [variableScope] ProteinSurface.cpp:2396:7: style: The scope of the variable 'flaginner' can be reduced. [variableScope] ProteinSurface.cpp:2479:9: style: The scope of the variable 'pnorm' can be reduced. [variableScope] ProteinSurface.cpp:1136:10: style: Local variable 'inarray' shadows outer variable [shadowVariable] ProteinSurface.h:606:10: note: Shadowed declaration ProteinSurface.cpp:1136:10: note: Shadow variable ProteinSurface.cpp:1136:19: style: Local variable 'outarray' shadows outer variable [shadowVariable] ProteinSurface.h:607:10: note: Shadowed declaration ProteinSurface.cpp:1136:19: note: Shadow variable ProteinSurface.cpp:2278:9: style: Local variable 'inarray' shadows outer variable [shadowVariable] ProteinSurface.h:606:10: note: Shadowed declaration ProteinSurface.cpp:2278:9: note: Shadow variable ProteinSurface.cpp:2278:18: style: Local variable 'outarray' shadows outer variable [shadowVariable] ProteinSurface.h:607:10: note: Shadowed declaration ProteinSurface.cpp:2278:18: note: Shadow variable ProteinSurface.cpp:877:38: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] ProteinSurface.cpp:1066:38: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] ProteinSurface.cpp:1261:71: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] ProteinSurface.cpp:1327:70: style: Parameter 'proseq' can be declared as pointer to const [constParameterPointer] ProteinSurface.cpp:1327:83: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] ProteinSurface.cpp:2026:40: style: Parameter 'innum' can be declared as pointer to const [constParameterPointer] ProteinSurface.cpp:2280:11: style: Variable 'innum' is assigned a value that is never used. [unreadVariable] ProteinSurface.cpp:2687:12: style: Variable 'totind' is assigned a value that is never used. [unreadVariable] ProteinSurface.cpp:2830:12: style: Variable 'totind' is assigned a value that is never used. [unreadVariable] diff: head ParsePDB.cpp:1084:13: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1084:14: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1474:11: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1474:12: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1475:11: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1475:12: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1476:10: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1476:11: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1477:10: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1477:11: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1479:12: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1479:13: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1480:12: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1480:13: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1481:12: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1481:13: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1482:12: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1482:13: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1483:10: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1483:11: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1485:11: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1485:12: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1486:11: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1486:12: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1551:15: performance:inconclusive: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). [functionStatic] ParsePDB.h:52:6: note: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). ParsePDB.cpp:1551:15: note: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). head ParsePDB.cpp:1572:15: performance:inconclusive: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). [functionStatic] ParsePDB.h:51:6: note: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). ParsePDB.cpp:1572:15: note: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). head ParsePDB.cpp:1666:10: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1666:11: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1670:8: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1670:9: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1712:10: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1712:11: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:1717:8: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:1717:9: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:472:13: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:472:14: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:540:13: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:540:14: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:636:12: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:636:13: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:685:12: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:685:13: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:739:14: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:739:15: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:774:14: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:774:15: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:830:14: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:830:15: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:886:14: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:886:15: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:936:12: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:936:13: style: C-style pointer casting [cstyleCast] head ParsePDB.cpp:997:13: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.cpp:997:14: style: C-style pointer casting [cstyleCast] 2.17.0 ParsePDB.h:51:6: performance:inconclusive: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). [functionStatic] ParsePDB.cpp:1572:15: note: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). ParsePDB.h:51:6: note: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). 2.17.0 ParsePDB.h:52:6: performance:inconclusive: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). [functionStatic] ParsePDB.cpp:1551:15: note: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). ParsePDB.h:52:6: note: Technically the member function 'ParsePDB::aminoid' can be static (but you may consider moving to unnamed namespace). head ProteinSurface.cpp:1261:22: style:inconclusive: Technically the member function 'ProteinSurface::outsas' can be const. [functionConst] ProteinSurface.h:631:7: note: Technically the member function 'ProteinSurface::outsas' can be const. ProteinSurface.cpp:1261:22: note: Technically the member function 'ProteinSurface::outsas' can be const. head ProteinSurface.cpp:1922:13: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:1922:14: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:2045:13: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:2045:14: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:2113:13: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:2113:14: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:2180:13: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:2180:14: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:2697:12: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:2697:13: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:2702:12: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:2702:13: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:2752:8: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:2752:9: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:2753:8: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:2753:9: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:2841:12: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:2841:13: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:2846:12: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:2846:13: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:2976:8: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:2976:9: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:2977:8: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:2977:9: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:344:13: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:344:14: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:4157:12: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:4157:13: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:4162:12: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:4162:13: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:523:8: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:523:9: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:5926:8: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:5926:9: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:5927:8: style: C-style pointer casting [cstyleCast] 2.17.0 ProteinSurface.cpp:5927:9: style: C-style pointer casting [cstyleCast] head ProteinSurface.cpp:754:22: performance:inconclusive: Technically the member function 'ProteinSurface::boundbox' can be static (but you may consider moving to unnamed namespace). [functionStatic] ProteinSurface.h:585:7: note: Technically the member function 'ProteinSurface::boundbox' can be static (but you may consider moving to unnamed namespace). ProteinSurface.cpp:754:22: note: Technically the member function 'ProteinSurface::boundbox' can be static (but you may consider moving to unnamed namespace). head ProteinSurface.cpp:783:22: style:inconclusive: Technically the member function 'ProteinSurface::atomsinout' can be const. [functionConst] ProteinSurface.h:628:7: note: Technically the member function 'ProteinSurface::atomsinout' can be const. ProteinSurface.cpp:783:22: note: Technically the member function 'ProteinSurface::atomsinout' can be const. 2.17.0 ProteinSurface.h:585:7: performance:inconclusive: Technically the member function 'ProteinSurface::boundbox' can be static (but you may consider moving to unnamed namespace). [functionStatic] ProteinSurface.cpp:754:22: note: Technically the member function 'ProteinSurface::boundbox' can be static (but you may consider moving to unnamed namespace). ProteinSurface.h:585:7: note: Technically the member function 'ProteinSurface::boundbox' can be static (but you may consider moving to unnamed namespace). 2.17.0 ProteinSurface.h:628:7: style:inconclusive: Technically the member function 'ProteinSurface::atomsinout' can be const. [functionConst] ProteinSurface.cpp:783:22: note: Technically the member function 'ProteinSurface::atomsinout' can be const. ProteinSurface.h:628:7: note: Technically the member function 'ProteinSurface::atomsinout' can be const. 2.17.0 ProteinSurface.h:631:7: style:inconclusive: Technically the member function 'ProteinSurface::outsas' can be const. [functionConst] ProteinSurface.cpp:1261:22: note: Technically the member function 'ProteinSurface::outsas' can be const. ProteinSurface.h:631:7: note: Technically the member function 'ProteinSurface::outsas' can be const. DONE