2026-05-01 14:39 ftp://ftp.de.debian.org/debian/pool/main/d/davegnukem/davegnukem_1.0.3.orig.tar.xz cppcheck-options: --library=posix --library=gnu --library=bsd --library=sdl --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j6 platform: Linux-7.0.3+deb14-amd64-x86_64-with-glibc2.42 python: 3.13.12 client-version: 1.4.0 compiler: g++ (Debian 15.2.0-17) 15.2.0 cppcheck: head 2.20.0 head-info: e5c4a734 (2026-05-01 11:10:43 +0200) count: 274 273 elapsed-time: 0.8 0.7 head-timing-info: old-timing-info: head results: dave_gnukem-1.0.3/src/djfile.cpp:57:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/djgraph.h:148:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/djgraph.h:51:3: performance: Variable 'colorfore' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] dave_gnukem-1.0.3/src/menu.h:22:2: style: Struct 'SMenuItem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] dave_gnukem-1.0.3/src/menu.h:50:2: style: Class 'CMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] dave_gnukem-1.0.3/src/menu.h:53:68: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/djstring.cpp:227:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/ed.cpp:96:5: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] dave_gnukem-1.0.3/src/djstring.cpp:67:38: style: Array index 'pos' is used before limits check. [arrayIndexThenCheck] dave_gnukem-1.0.3/src/djstring.cpp:253:37: warning: If memory allocation fails, then there is a possible null pointer dereference: pp [nullPointerOutOfMemory] dave_gnukem-1.0.3/src/djstring.cpp:249:35: note: Assuming allocation function fails dave_gnukem-1.0.3/src/djstring.cpp:249:35: note: Assignment 'copypath=strdup(path)', assigned value is 0 dave_gnukem-1.0.3/src/djstring.cpp:252:7: note: Assignment 'pp=copypath', assigned value is 0 dave_gnukem-1.0.3/src/djstring.cpp:253:37: note: Null pointer dereference dave_gnukem-1.0.3/src/djstring.cpp:246:18: style: Variable 'pp' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/thing.h:297:6: style:inconclusive: Technically the member function 'CThing::ID' can be const. [functionConst] dave_gnukem-1.0.3/src/thing.h:311:14: style:inconclusive: Technically the member function 'CThing::HeroInsideActionBounds' can be const. [functionConst] dave_gnukem-1.0.3/src/mission.h:119:8: warning: The class 'CLevel' defines member variable with name 'm_szName' also defined in its parent class 'CNamed'. [duplInheritedMember] dave_gnukem-1.0.3/src/mixins.h:22:9: note: Parent variable 'CNamed::m_szName' dave_gnukem-1.0.3/src/mission.h:119:8: note: Derived variable 'CLevel::m_szName' dave_gnukem-1.0.3/src/thing.h:567:6: warning: The class 'CFloatingScore' defines member variable with name 'm_height' also defined in its parent class 'CThing'. [duplInheritedMember] dave_gnukem-1.0.3/src/thing.h:303:7: note: Parent variable 'CThing::m_height' dave_gnukem-1.0.3/src/thing.h:567:6: note: Derived variable 'CFloatingScore::m_height' dave_gnukem-1.0.3/src/mission.h:75:3: style: The destructor '~CMission' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] dave_gnukem-1.0.3/src/mixins.h:16:11: note: Virtual destructor in base class dave_gnukem-1.0.3/src/mission.h:75:3: note: Destructor in derived class dave_gnukem-1.0.3/src/mission.h:113:3: style: The destructor '~CLevel' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] dave_gnukem-1.0.3/src/mixins.h:16:11: note: Virtual destructor in base class dave_gnukem-1.0.3/src/mission.h:113:3: note: Destructor in derived class dave_gnukem-1.0.3/src/mission.h:97:14: performance: Function 'GetFilename()' should return member 'm_sFilename' by const reference. [returnByReference] dave_gnukem-1.0.3/src/djimage.cpp:106:14: style: The member function 'djImage::CalculatePixelWidth' can be static. [functionStatic] dave_gnukem-1.0.3/src/djimage.h:31:6: note: The member function 'djImage::CalculatePixelWidth' can be static. dave_gnukem-1.0.3/src/djimage.cpp:106:14: note: The member function 'djImage::CalculatePixelWidth' can be static. dave_gnukem-1.0.3/src/djimage.cpp:78:2: warning: Class 'djImage' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] dave_gnukem-1.0.3/src/djimage.cpp:78:2: warning: Class 'djImage' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] dave_gnukem-1.0.3/src/djimage.cpp:81:11: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/djimage.cpp:103:11: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/ed_common.cpp:179:21: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/djimage.cpp:264:5: style: Variable 'pBuf' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/djimage.cpp:287:5: style: Variable 'pBuf' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/djimage.cpp:317:5: style: Variable 'pBuf' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_common.cpp:289:28: style:inconclusive: Function 'ED_SetSpriteSet' argument 1 names different: declaration 'ispritesetnew' definition 'new_spriteset'. [funcArgNamesDifferent] dave_gnukem-1.0.3/src/ed_common.h:77:28: note: Function 'ED_SetSpriteSet' argument 1 names different: declaration 'ispritesetnew' definition 'new_spriteset'. dave_gnukem-1.0.3/src/ed_common.cpp:289:28: note: Function 'ED_SetSpriteSet' argument 1 names different: declaration 'ispritesetnew' definition 'new_spriteset'. dave_gnukem-1.0.3/src/ed_macros.cpp:119:21: style:inconclusive: Function 'PlaceMacro' argument 1 names different: declaration 'x' definition '_x'. [funcArgNamesDifferent] dave_gnukem-1.0.3/src/ed_macros.h:26:21: note: Function 'PlaceMacro' argument 1 names different: declaration 'x' definition '_x'. dave_gnukem-1.0.3/src/ed_macros.cpp:119:21: note: Function 'PlaceMacro' argument 1 names different: declaration 'x' definition '_x'. dave_gnukem-1.0.3/src/ed_macros.cpp:119:29: style:inconclusive: Function 'PlaceMacro' argument 2 names different: declaration 'y' definition '_y'. [funcArgNamesDifferent] dave_gnukem-1.0.3/src/ed_macros.h:26:28: note: Function 'PlaceMacro' argument 2 names different: declaration 'y' definition '_y'. dave_gnukem-1.0.3/src/ed_macros.cpp:119:29: note: Function 'PlaceMacro' argument 2 names different: declaration 'y' definition '_y'. dave_gnukem-1.0.3/src/ed_macros.cpp:165:12: style: Variable 'pMac' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/gameending.cpp:143:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_SPACE [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/effect_viewportshadow.h:49:17: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/effect_viewportshadow.cpp:162:15: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/effect_viewportshadow.cpp:60:6: style: The scope of the variable 'nIntensity' can be reduced. [variableScope] dave_gnukem-1.0.3/src/effect_viewportshadow.cpp:61:8: style: The scope of the variable 'fDistance' can be reduced. [variableScope] dave_gnukem-1.0.3/src/effect_viewportshadow.cpp:38:12: style: Local variable 'nHIGH' shadows outer variable [shadowVariable] dave_gnukem-1.0.3/src/effect_viewportshadow.h:72:6: note: Shadowed declaration dave_gnukem-1.0.3/src/effect_viewportshadow.cpp:38:12: note: Shadow variable dave_gnukem-1.0.3/src/effect_viewportshadow.cpp:39:14: style: Local variable 'fFADEOVERNUMBLOCKS' shadows outer variable [shadowVariable] dave_gnukem-1.0.3/src/effect_viewportshadow.h:73:8: note: Shadowed declaration dave_gnukem-1.0.3/src/effect_viewportshadow.cpp:39:14: note: Shadow variable dave_gnukem-1.0.3/src/effect_viewportshadow.cpp:41:14: style: Local variable 'fLOWRANGEEXTENT' shadows outer variable [shadowVariable] dave_gnukem-1.0.3/src/effect_viewportshadow.h:74:8: note: Shadowed declaration dave_gnukem-1.0.3/src/effect_viewportshadow.cpp:41:14: note: Shadow variable dave_gnukem-1.0.3/src/effect_viewportshadow.cpp:42:12: style: Local variable 'SHADSIZE' shadows outer variable [shadowVariable] dave_gnukem-1.0.3/src/effect_viewportshadow.h:76:21: note: Shadowed declaration dave_gnukem-1.0.3/src/effect_viewportshadow.cpp:42:12: note: Shadow variable dave_gnukem-1.0.3/src/effect_viewportshadow.cpp:60:17: style: Variable 'nIntensity' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/effect_viewportshadow.cpp:61:18: style: Variable 'fDistance' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/gameending.cpp:109:6: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/gameending.cpp:117:17: style: Variable 'fTimeNow' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/graph.cpp:169:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_INIT_VIDEO [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/graph.cpp:102:48: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/graph.cpp:121:52: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/graph.cpp:354:35: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/graph.cpp:218:6: style: The scope of the variable 'max_w' can be reduced. [variableScope] dave_gnukem-1.0.3/src/graph.cpp:219:6: style: The scope of the variable 'max_h' can be reduced. [variableScope] dave_gnukem-1.0.3/src/graph.cpp:118:16: style: Unsigned expression 'uTimeNow' can't be negative so it is unnecessary to test it. [unsignedPositive] dave_gnukem-1.0.3/src/graph.cpp:218:12: style: Variable 'max_w' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/graph.cpp:219:12: style: Variable 'max_h' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/hiscores.cpp:102:84: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/hiscores.cpp:103:84: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/hiscores.cpp:105:84: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/hiscores.cpp:211:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] dave_gnukem-1.0.3/src/instructions.cpp:283:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_SPACE [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/hero.cpp:217:58: style:inconclusive: Boolean expression 'g_Player.hero_dir==1' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] dave_gnukem-1.0.3/src/hero.cpp:217:103: style:inconclusive: Boolean expression 'g_Player.hero_dir==0' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] dave_gnukem-1.0.3/src/hero.cpp:241:46: style:inconclusive: Boolean expression '!bsolid' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] dave_gnukem-1.0.3/src/hero.cpp:279:20: style:inconclusive: Boolean expression '!bsolid' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] dave_gnukem-1.0.3/src/hero.cpp:52:2: style: Struct 'SJumpInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] dave_gnukem-1.0.3/src/hero.cpp:241:46: warning: Result of operator '|' is always true if one operand is non-zero. Did you intend to use '&'? [badBitmaskCheck] dave_gnukem-1.0.3/src/hero.cpp:207:13: style: Variable 'bsolid' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/keys.cpp:99:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_BACKSPACE [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/ed_spred.cpp:318:13: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/ed_spred.cpp:321:40: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/ed_spred.cpp:174:6: style: The scope of the variable 'ax' can be reduced. [variableScope] dave_gnukem-1.0.3/src/ed_spred.cpp:385:6: style: The scope of the variable 'xoffset' can be reduced. [variableScope] dave_gnukem-1.0.3/src/ed_spred.cpp:385:17: style: The scope of the variable 'yoffset' can be reduced. [variableScope] dave_gnukem-1.0.3/src/ed_spred.cpp:310:31: style: Variable 'c' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_spred.cpp:385:13: style: Variable 'xoffset' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_spred.cpp:385:24: style: Variable 'yoffset' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/inventory.cpp:96:12: style: Variable 'pThing' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/inventory.cpp:110:13: style: Variable 'pThing' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/inventory.cpp:116:13: style: Variable 'pThing' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/inventory.cpp:133:24: style: Parameter 'pThing' can be declared as pointer to const [constParameterPointer] dave_gnukem-1.0.3/src/inventory.cpp:163:12: style: Variable 'pItem' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/inventory.cpp:138:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] dave_gnukem-1.0.3/src/inventory.cpp:154:6: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] dave_gnukem-1.0.3/src/instructions.cpp:184:6: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/instructions.cpp:36:14: style: Unused variable: sBuildWord [unusedVariable] dave_gnukem-1.0.3/src/instructions.cpp:192:17: style: Variable 'fTimeNow' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/instructions.cpp:313:3: style: Variable 'pImgFont' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/instructions.cpp:318:3: style: Variable 'pImgFontS' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/level.cpp:90:17: style: Variable 'level' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/m_misc.cpp:44:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/level.cpp:75:7: style: Variable 'pIn' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/level.cpp:151:2: style: Variable 'level' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/m_misc.cpp:439:9: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/m_misc.cpp:508:35: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] dave_gnukem-1.0.3/src/m_misc.cpp:521:8: style: Variable 'ptr' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/keys.cpp:238:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] dave_gnukem-1.0.3/src/menu.cpp:226:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_7 [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/sdl/djgraph.cpp:262:3: error: syntax error [syntaxError] dave_gnukem-1.0.3/src/game.cpp:1356:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KMOD_LSHIFT [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/main.cpp:816:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_RETURN [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/main.cpp:999:63: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_z [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/sdl/djinput.cpp:274:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_KEYDOWN [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/sdl/djsound.cpp:99:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MIX_INIT_FLAC [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/sdl/djsound.cpp:155:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Mix_Chunk [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/sdl/djsound.cpp:155:14: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/sdl/djsound.cpp:169:32: style:inconclusive: Function 'djSoundPlay' argument 1 names different: declaration 'iHandle' definition 'i'. [funcArgNamesDifferent] dave_gnukem-1.0.3/src/djsound.h:23:47: note: Function 'djSoundPlay' argument 1 names different: declaration 'iHandle' definition 'i'. dave_gnukem-1.0.3/src/sdl/djsound.cpp:169:32: note: Function 'djSoundPlay' argument 1 names different: declaration 'iHandle' definition 'i'. dave_gnukem-1.0.3/src/mission.cpp:278:15: style: The member function 'CMission::LoadSprites' can be static. [functionStatic] dave_gnukem-1.0.3/src/mission.h:89:7: note: The member function 'CMission::LoadSprites' can be static. dave_gnukem-1.0.3/src/mission.cpp:278:15: note: The member function 'CMission::LoadSprites' can be static. dave_gnukem-1.0.3/src/mission.cpp:308:15: style: The member function 'CMission::SaveSprites' can be static. [functionStatic] dave_gnukem-1.0.3/src/mission.h:90:7: note: The member function 'CMission::SaveSprites' can be static. dave_gnukem-1.0.3/src/mission.cpp:308:15: note: The member function 'CMission::SaveSprites' can be static. dave_gnukem-1.0.3/src/sdl/djtime.cpp:48:2: error: failed to evaluate #if condition, undefined function-like macro invocation: SDL_VERSION_ATLEAST( ... ) [syntaxError] dave_gnukem-1.0.3/src/mission.cpp:141:11: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] dave_gnukem-1.0.3/src/mission.cpp:192:5: style: Variable 'szFilename' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/mission.cpp:193:5: style: Variable 'szName' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/mission.cpp:194:5: style: Variable 'szAuthor' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/mission.cpp:195:5: style: Variable 'szBackground' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/mission.cpp:223:5: style: Variable 'szID' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/mission.cpp:224:5: style: Variable 'szImgFilename' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/mission.cpp:225:5: style: Variable 'szDatafile' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/settings.cpp:65:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable szKey [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/menu.cpp:177:88: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/settings.cpp:88:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable szKey [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/settings.cpp:105:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable szKey [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/settings.cpp:121:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable szKey [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/settings.cpp:151:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable szKey [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/menu.cpp:91:11: style: Local variable 'i' shadows outer variable [shadowVariable] dave_gnukem-1.0.3/src/menu.cpp:78:6: note: Shadowed declaration dave_gnukem-1.0.3/src/menu.cpp:91:11: note: Shadow variable dave_gnukem-1.0.3/src/menu.cpp:278:16: style: Local variable 'i' shadows outer variable [shadowVariable] dave_gnukem-1.0.3/src/menu.cpp:78:6: note: Shadowed declaration dave_gnukem-1.0.3/src/menu.cpp:278:16: note: Shadow variable dave_gnukem-1.0.3/src/menu.cpp:23:24: style: Parameter 'pMenu' can be declared as pointer to const [constParameterPointer] dave_gnukem-1.0.3/src/main.cpp:1147:4: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] dave_gnukem-1.0.3/src/main.cpp:1145:20: note: outer condition: pMenuItems[i].m_szText dave_gnukem-1.0.3/src/main.cpp:1147:4: note: identical inner condition: pMenuItems[i].m_szText dave_gnukem-1.0.3/src/menu.cpp:193:17: style: Variable 'fTimeNow' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/settings.cpp:83:24: style:inconclusive: Technically the member function 'CSettings::FindSetting' can be const. [functionConst] dave_gnukem-1.0.3/src/settings.h:32:14: note: Technically the member function 'CSettings::FindSetting' can be const. dave_gnukem-1.0.3/src/settings.cpp:83:24: note: Technically the member function 'CSettings::FindSetting' can be const. dave_gnukem-1.0.3/src/main.cpp:640:78: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:642:123: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:854:56: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:857:61: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:861:62: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:864:65: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:865:65: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:873:62: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:879:62: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:883:49: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:884:49: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:887:51: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:889:51: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:1051:52: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:1052:52: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/main.cpp:1060:57: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/settings.cpp:88:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] dave_gnukem-1.0.3/src/settings.cpp:106:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] dave_gnukem-1.0.3/src/settings.cpp:122:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] dave_gnukem-1.0.3/src/main.cpp:573:19: style: Variable 'SettingsMenuItems' can be declared as const array [constVariable] dave_gnukem-1.0.3/src/main.cpp:587:16: style: Variable 'MenuCursor' can be declared as const array [constVariable] dave_gnukem-1.0.3/src/main.cpp:770:21: style: Parameter 'anKeys' can be declared as pointer to const [constParameterPointer] dave_gnukem-1.0.3/src/main.cpp:1063:18: style: Variable 'szCursor' can be declared as const array [constVariable] dave_gnukem-1.0.3/src/main.cpp:1105:16: style: Variable 'menuMissionCursor' can be declared as const array [constVariable] dave_gnukem-1.0.3/src/main.cpp:710:10: style: Variable 'pMusic' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/main.cpp:1151:2: style: Variable 'pMenuItems' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/sys_log.cpp:100:20: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] dave_gnukem-1.0.3/src/sys_log.cpp:104:3: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] dave_gnukem-1.0.3/src/sys_log.cpp:173:15: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/sys_log.cpp:128:34: style:inconclusive: Function 'DisposeLog' argument 1 names different: declaration 'lg_id' definition 'log_id'. [funcArgNamesDifferent] dave_gnukem-1.0.3/src/sys_log.h:27:33: note: Function 'DisposeLog' argument 1 names different: declaration 'lg_id' definition 'log_id'. dave_gnukem-1.0.3/src/sys_log.cpp:128:34: note: Function 'DisposeLog' argument 1 names different: declaration 'lg_id' definition 'log_id'. dave_gnukem-1.0.3/src/sys_log.cpp:143:32: style:inconclusive: Function 'LogStr' argument 1 names different: declaration 'szStr' definition 'szPlainString'. [funcArgNamesDifferent] dave_gnukem-1.0.3/src/sys_log.h:46:33: note: Function 'LogStr' argument 1 names different: declaration 'szStr' definition 'szPlainString'. dave_gnukem-1.0.3/src/sys_log.cpp:143:32: note: Function 'LogStr' argument 1 names different: declaration 'szStr' definition 'szPlainString'. dave_gnukem-1.0.3/src/sys_log.cpp:100:13: style: Variable 'tme' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/sys_log.cpp:76:12: style: int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] dave_gnukem-1.0.3/src/thing.cpp:77:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable pPerLevelInitProc [valueFlowBailoutIncompleteVar] dave_gnukem-1.0.3/src/thing_monsters.h:194:11: style: The destructor '~CDrProton' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] dave_gnukem-1.0.3/src/thing.h:175:11: note: Virtual destructor in base class dave_gnukem-1.0.3/src/thing_monsters.h:194:11: note: Destructor in derived class dave_gnukem-1.0.3/src/thing_monsters.h:106:14: style: The function 'Tick' overrides a function in a base class but just delegates back to the base class. [uselessOverride] dave_gnukem-1.0.3/src/thing_monsters.h:22:14: note: Virtual function in base class dave_gnukem-1.0.3/src/thing_monsters.h:106:14: note: Function in derived class dave_gnukem-1.0.3/src/ed_lvled.cpp:321:5: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] dave_gnukem-1.0.3/src/ed_lvled.cpp:321:5: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] dave_gnukem-1.0.3/src/thing_monsters.cpp:163:25: style:inconclusive: Function 'Draw' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. [funcArgNamesDifferent] dave_gnukem-1.0.3/src/thing_monsters.h:47:26: note: Function 'Draw' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:163:25: note: Function 'Draw' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:175:24: style:inconclusive: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. [funcArgNamesDifferent] dave_gnukem-1.0.3/src/thing_monsters.h:48:25: note: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:175:24: note: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:374:30: style:inconclusive: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. [funcArgNamesDifferent] dave_gnukem-1.0.3/src/thing_monsters.h:62:25: note: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:374:30: note: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:534:25: style:inconclusive: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. [funcArgNamesDifferent] dave_gnukem-1.0.3/src/thing_monsters.h:86:25: note: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:534:25: note: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:635:30: style:inconclusive: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. [funcArgNamesDifferent] dave_gnukem-1.0.3/src/thing_monsters.h:106:25: note: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:635:30: note: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:689:25: style:inconclusive: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. [funcArgNamesDifferent] dave_gnukem-1.0.3/src/thing_monsters.h:118:25: note: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:689:25: note: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:829:26: style:inconclusive: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. [funcArgNamesDifferent] dave_gnukem-1.0.3/src/thing_monsters.h:135:25: note: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:829:26: note: Function 'Tick' argument 1 names different: declaration 'fDeltaTime' definition 'fDeltaTime_ms'. dave_gnukem-1.0.3/src/thing_monsters.cpp:223:13: style: Variable 'nXOffset' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_lvled.cpp:736:13: style: Redundant initialization for 'fTimeNow'. The initialized value is overwritten before it is read. [redundantInitialization] dave_gnukem-1.0.3/src/ed_lvled.cpp:733:18: note: fTimeNow is initialized dave_gnukem-1.0.3/src/ed_lvled.cpp:736:13: note: fTimeNow is overwritten dave_gnukem-1.0.3/src/ed_lvled.cpp:240:14: style: The scope of the variable 'Block' can be reduced. [variableScope] dave_gnukem-1.0.3/src/ed_lvled.cpp:405:16: style: The scope of the variable 'pData' can be reduced. [variableScope] dave_gnukem-1.0.3/src/ed_lvled.cpp:1131:6: style: The scope of the variable 'xoffset' can be reduced. [variableScope] dave_gnukem-1.0.3/src/ed_lvled.cpp:1131:17: style: The scope of the variable 'yoffset' can be reduced. [variableScope] dave_gnukem-1.0.3/src/ed_lvled.cpp:1227:6: style: The scope of the variable 'a' can be reduced. [variableScope] dave_gnukem-1.0.3/src/ed_lvled.cpp:1227:13: style: The scope of the variable 'b' can be reduced. [variableScope] dave_gnukem-1.0.3/src/ed_lvled.cpp:1232:7: style: The scope of the variable 'bHighlightBack' can be reduced. [variableScope] dave_gnukem-1.0.3/src/ed_lvled.cpp:1233:7: style: The scope of the variable 'bHighlightBackMouseOver' can be reduced. [variableScope] dave_gnukem-1.0.3/src/ed_lvled.cpp:440:32: style: Local variable 'apLevels' shadows outer variable [shadowVariable] dave_gnukem-1.0.3/src/level.h:17:38: note: Shadowed declaration dave_gnukem-1.0.3/src/ed_lvled.cpp:440:32: note: Shadow variable dave_gnukem-1.0.3/src/ed_lvled.cpp:268:38: style: Parameter 'Stats' can be declared as reference to const [constParameterReference] dave_gnukem-1.0.3/src/ed_lvled.cpp:405:16: style: Variable 'pData' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/ed_lvled.cpp:405:21: style: Variable 'pData' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_lvled.cpp:702:8: style: Variable 'pOut' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_lvled.cpp:984:8: style: Variable 'ax' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_lvled.cpp:984:14: style: Variable 'ay' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_lvled.cpp:1131:13: style: Variable 'xoffset' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_lvled.cpp:1131:24: style: Variable 'yoffset' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_lvled.cpp:1226:15: style: Variable 'j' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_lvled.cpp:1227:8: style: Variable 'a' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_lvled.cpp:1227:15: style: Variable 'b' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_lvled.cpp:1232:22: style: Variable 'bHighlightBack' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/ed_lvled.cpp:1233:31: style: Variable 'bHighlightBackMouseOver' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/thing.cpp:1395:12: warning: Member variable 'CConveyor::m_nDir' is not initialized in the constructor. [uninitMemberVar] dave_gnukem-1.0.3/src/thing.cpp:1212:13: style:inconclusive: Technically the member function 'CAcme::CreateOnDestroyedEffects' can be const. [functionConst] dave_gnukem-1.0.3/src/thing.h:796:7: note: Technically the member function 'CAcme::CreateOnDestroyedEffects' can be const. dave_gnukem-1.0.3/src/thing.cpp:1212:13: note: Technically the member function 'CAcme::CreateOnDestroyedEffects' can be const. dave_gnukem-1.0.3/src/thing.h:394:15: style: The function 'OnAdded' overrides a function in a base class but is identical to the overridden function [uselessOverride] dave_gnukem-1.0.3/src/thing.h:202:15: note: Virtual function in base class dave_gnukem-1.0.3/src/thing.h:394:15: note: Function in derived class dave_gnukem-1.0.3/src/thing.cpp:585:8: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/thing.cpp:652:12: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/thing.cpp:653:32: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/thing.cpp:781:9: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] dave_gnukem-1.0.3/src/thing.cpp:793:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] dave_gnukem-1.0.3/src/thing.cpp:35:92: style:inconclusive: Function 'Register' argument 3 names different: declaration '' definition 'pPerLevelInitProc'. [funcArgNamesDifferentUnnamed] dave_gnukem-1.0.3/src/thing.cpp:726:13: style: Local variable 'anim4_count' shadows outer variable [shadowVariable] dave_gnukem-1.0.3/src/game.h:59:12: note: Shadowed declaration dave_gnukem-1.0.3/src/thing.cpp:726:13: note: Shadow variable dave_gnukem-1.0.3/src/thing.cpp:814:13: style: Local variable 'anim4_count' shadows outer variable [shadowVariable] dave_gnukem-1.0.3/src/game.h:59:12: note: Shadowed declaration dave_gnukem-1.0.3/src/thing.cpp:814:13: note: Shadow variable dave_gnukem-1.0.3/src/thing.cpp:263:14: style: Variable 'anBounceOffsets' can be declared as const array [constVariable] dave_gnukem-1.0.3/src/thing.cpp:52:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] dave_gnukem-1.0.3/src/thing.cpp:1536:14: style: Variable 'nOffset' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:344:57: style:inconclusive: Boolean expression '(g_Player.x-g_Viewport.xo)==VIEW_WIDTH-5' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] dave_gnukem-1.0.3/src/game.cpp:376:14: style:inconclusive: Boolean expression 'bEven' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] dave_gnukem-1.0.3/src/game.cpp:1231:3: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] dave_gnukem-1.0.3/src/game.cpp:1229:6: note: outer condition: g_pLevelShadowMap dave_gnukem-1.0.3/src/game.cpp:1231:3: note: identical inner condition: g_pLevelShadowMap dave_gnukem-1.0.3/src/game.cpp:408:69: style: Condition 'g_Player.hero_mode==MODE_JUMPING' is always false [knownConditionTrueFalse] dave_gnukem-1.0.3/src/game.cpp:3007:6: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] dave_gnukem-1.0.3/src/game.cpp:3010:7: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] dave_gnukem-1.0.3/src/game.cpp:1178:9: warning: If memory allocation fails, then there is a possible null pointer dereference: bg [nullPointerOutOfMemory] dave_gnukem-1.0.3/src/game.cpp:1177:28: note: Assuming allocation function fails dave_gnukem-1.0.3/src/game.cpp:1177:13: note: Assignment 'bg=(char*)malloc((strlen(djDataDir())+strlen(g_pCurMission->GetLevel(g_nLevel)->m_szBackground)+1)*sizeof(char))', assigned value is 0 dave_gnukem-1.0.3/src/game.cpp:1178:9: note: Null pointer dereference dave_gnukem-1.0.3/src/game.cpp:1179:9: warning: If memory allocation fails, then there is a possible null pointer dereference: bg [nullPointerOutOfMemory] dave_gnukem-1.0.3/src/game.cpp:1177:28: note: Assuming allocation function fails dave_gnukem-1.0.3/src/game.cpp:1177:13: note: Assignment 'bg=(char*)malloc((strlen(djDataDir())+strlen(g_pCurMission->GetLevel(g_nLevel)->m_szBackground)+1)*sizeof(char))', assigned value is 0 dave_gnukem-1.0.3/src/game.cpp:1179:9: note: Null pointer dereference dave_gnukem-1.0.3/src/game.cpp:1177:13: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:1774:48: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:2084:51: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:2149:105: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:2151:62: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:2204:139: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:2211:60: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:2282:23: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:2455:64: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:2732:48: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:2735:48: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:2737:48: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:2739:48: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:2744:49: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:2749:48: style: C-style pointer casting [cstyleCast] dave_gnukem-1.0.3/src/game.cpp:1646:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] dave_gnukem-1.0.3/src/game.cpp:486:10: style: The scope of the variable 'pThing' can be reduced. [variableScope] dave_gnukem-1.0.3/src/game.cpp:503:10: style: The scope of the variable 'pThing' can be reduced. [variableScope] dave_gnukem-1.0.3/src/game.cpp:535:11: style: The scope of the variable 'pBullet' can be reduced. [variableScope] dave_gnukem-1.0.3/src/game.cpp:2008:12: style: The scope of the variable 'pThing' can be reduced. [variableScope] dave_gnukem-1.0.3/src/game.cpp:2226:10: style: The scope of the variable 'pThing' can be reduced. [variableScope] dave_gnukem-1.0.3/src/game.cpp:2238:14: style: The scope of the variable 'a' can be reduced. [variableScope] dave_gnukem-1.0.3/src/game.cpp:2238:18: style: The scope of the variable 'b' can be reduced. [variableScope] dave_gnukem-1.0.3/src/game.cpp:2238:22: style: The scope of the variable 'nXOffset' can be reduced. [variableScope] dave_gnukem-1.0.3/src/game.cpp:2239:6: style: The scope of the variable 'anim_offset' can be reduced. [variableScope] dave_gnukem-1.0.3/src/game.cpp:2375:6: style: The scope of the variable 'yoff' can be reduced. [variableScope] dave_gnukem-1.0.3/src/game.cpp:2672:10: style: The scope of the variable 'pThing' can be reduced. [variableScope] dave_gnukem-1.0.3/src/game.cpp:2783:6: style: The scope of the variable 'i' can be reduced. [variableScope] dave_gnukem-1.0.3/src/game.cpp:2804:11: style: The scope of the variable 'pThing' can be reduced. [variableScope] dave_gnukem-1.0.3/src/game.cpp:305:14: style: Variable 'pDrProton' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/game.cpp:1646:15: style: Variable 'pKey' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/game.cpp:2641:12: style: Variable 'pBullet' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/game.cpp:2804:11: style: Variable 'pThing' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/game.cpp:2835:62: style: Parameter 'pBullet' can be declared as pointer to const [constParameterPointer] dave_gnukem-1.0.3/src/game.cpp:2911:17: style: Variable 'pSpriteData' can be declared as pointer to const [constVariablePointer] dave_gnukem-1.0.3/src/game.cpp:3110:19: style: Variable 'gameMenuItems' can be declared as const array [constVariable] dave_gnukem-1.0.3/src/game.cpp:222:6: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] dave_gnukem-1.0.3/src/game.cpp:1998:6: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] dave_gnukem-1.0.3/src/game.cpp:3045:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] dave_gnukem-1.0.3/src/game.cpp:443:16: style: Variable 'pThing' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:486:17: style: Variable 'pThing' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:503:17: style: Variable 'pThing' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:535:18: style: Variable 'pBullet' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:546:4: style: Variable 'pBullet' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:607:18: style: Variable 'pBullet' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:648:18: style: Variable 'pThing' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:1292:17: style: Variable 'fTimeNow' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:2008:18: style: Variable 'pThing' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:2238:11: style: Variable 'j' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:2238:15: style: Variable 'a' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:2238:19: style: Variable 'b' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:2238:30: style: Variable 'nXOffset' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:2239:18: style: Variable 'anim_offset' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:2375:10: style: Variable 'yoff' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:2762:18: style: Variable 'pBullet' is assigned a value that is never used. [unreadVariable] dave_gnukem-1.0.3/src/game.cpp:2804:18: style: Variable 'pThing' is assigned a value that is never used. [unreadVariable] diff: head dave_gnukem-1.0.3/src/thing.cpp:35:92: style:inconclusive: Function 'Register' argument 3 names different: declaration '' definition 'pPerLevelInitProc'. [funcArgNamesDifferentUnnamed] DONE