2026-05-01 13:33 ftp://ftp.de.debian.org/debian/pool/main/c/crawl/crawl_0.34.1.orig.tar.xz cppcheck-options: --library=posix --library=gnu --library=bsd --library=sdl --library=lua --library=sqlite3 --library=zlib --library=pcre --library=bsd --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j6 platform: Linux-7.0.3+deb14-amd64-x86_64-with-glibc2.42 python: 3.13.12 client-version: 1.4.0 compiler: g++ (Debian 15.2.0-17) 15.2.0 cppcheck: head 2.20.0 head-info: e5c4a734 (2026-05-01 11:10:43 +0200) count: 3304 3167 elapsed-time: 117.8 114.4 head-timing-info: old-timing-info: head results: stone_soup-0.34.1/source/enum.h:27:30: debug: Failed to instantiate template "_enum_bitfield_exponent_base". The checking continues anyway. [templateInstantiation] stone_soup-0.34.1/source/bitary.h:149:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIZEX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/bitary.h:174:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIZEX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/rltiles/tiledef_defines.h:81:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/bitary.h:175:17: error: Boolean value assigned to pointer. [assignBoolToPointer] stone_soup-0.34.1/source/tags.h:64:5: warning: Member variable 'writer::_pbuf' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/geom2d.h:66:5: warning:inconclusive: Member variable 'line::val' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/geom2d.h:80:5: warning:inconclusive: Member variable 'lineseq::offset' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/geom2d.h:80:5: warning:inconclusive: Member variable 'lineseq::dist' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/tiles.h:27:5: warning: Member variable 'VColour::r' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/tiles.h:27:5: warning: Member variable 'VColour::g' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/tiles.h:27:5: warning: Member variable 'VColour::b' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/tiles.h:27:5: warning: Member variable 'VColour::a' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < spell_type , MAX_KNOWN_SPELLS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , 52 >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < run_check_dir , 3 >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/level-id.h:130:10: style:inconclusive: Technically the member function 'level_pos::is_on' can be const. [functionConst] stone_soup-0.34.1/source/package.h:87:12: style:inconclusive: Technically the member function 'package::get_filename' can be const. [functionConst] stone_soup-0.34.1/source/externs.h:75:5: style:inconclusive: Technically the member function 'tile_fg_store::operatortileidx_t' can be const. [functionConst] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < bool , 3 , 3 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < bool , 3 , 3 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < bool , 3 , 3 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < bool , 3 , 3 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < spell_type , MAX_KNOWN_SPELLS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < spell_type , MAX_KNOWN_SPELLS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , 52 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , 52 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < run_check_dir , 3 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < run_check_dir , 3 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < bool , 3 > , 3 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < bool , 3 > , 3 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < mon_spell_slot_flag , 12 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/tags.h:72:36: warning: Class 'writer' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] stone_soup-0.34.1/source/tags.h:72:36: warning: Class 'writer' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] stone_soup-0.34.1/source/bitary.h:23:5: style: Class 'bit_vector' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/bitary.h:137:5: style: Class 'FixedBitArray' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/pattern.h:55:5: style: Class 'text_pattern' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/pattern.h:129:5: style: Class 'plaintext_pattern' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/level-id.h:37:5: style: Class 'level_id' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/level-id.h:101:5: style: Struct 'level_pos' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/tags.h:61:5: style: Class 'writer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/tags.h:116:5: style: Class 'reader' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/tags.h:117:5: style: Class 'reader' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/tags.h:120:5: style: Class 'reader' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:85:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:86:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:87:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:88:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:89:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:90:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:91:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:92:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:93:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:94:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:95:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:96:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:97:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:98:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:99:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:100:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:232:5: style: Class 'CrawlStoreValue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:289:5: style: Class 'CrawlVector' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/store.h:290:5: style: Class 'CrawlVector' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/geom2d.h:34:5: style: Struct 'form' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/ray.h:21:5: style: Struct 'ray_def' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/externs.h:74:5: style: Class 'tile_fg_store' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/externs.h:292:5: style: Struct 'item_comparator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/externs.h:311:5: style: Struct 'menu_sort_condition' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/externs.h:312:5: style: Struct 'menu_sort_condition' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/externs.h:327:5: style: Struct 'cglyph_t' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/tiles.h:54:5: style: Struct 'tile_def' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:128:5: style: Class 'SquareArray < bool , 1 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < bool , 3 , 3 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < spell_type , MAX_KNOWN_SPELLS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , 52 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < run_check_dir , 3 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < bool , 3 > , 3 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < mon_spell_slot_flag , 12 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:128:19: style: Struct 'range' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:107:23: style: Class 'iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/pattern.h:76:6: style: The destructor '~text_pattern' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/pattern.h:44:14: note: Virtual destructor in base class stone_soup-0.34.1/source/pattern.h:76:6: note: Destructor in derived class stone_soup-0.34.1/source/package.h:87:12: performance: Function 'get_filename()' should return member 'filename' by const reference. [returnByReference] stone_soup-0.34.1/source/tags.h:137:12: performance: Function 'filename()' should return member '_filename' by const reference. [returnByReference] stone_soup-0.34.1/source/fixedarray.h:135:43: style: Return value 'data.empty()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/fixedarray.h:135:43: note: Calling function 'empty' returns 0 stone_soup-0.34.1/source/fixedarray.h:135:43: note: Return value 'data.empty()' is always false stone_soup-0.34.1/source/geom2d.h:92:30: performance: Function parameter 'l2' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/coordit.h:21:41: error: syntax error [syntaxError] stone_soup-0.34.1/source/spl-cast.h:121:1: debug: Failed to parse 'typedef function < vector < string > ( const monster_info & mi ) > ( desc_filter ) ;'. The checking continues anyway. [simplifyTypedef] stone_soup-0.34.1/source/random.h:187:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIZE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/random.h:244:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable adder [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/random.h:256:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable mult_num [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/random.h:266:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable mult_num [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/kills.h:26:5: warning:inconclusive: Member variable 'kill_monster_desc::monnum' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/kills.h:26:5: warning:inconclusive: Member variable 'kill_monster_desc::modifier' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/kills.h:86:5: warning:inconclusive: Member variable 'kill_ghost::exp' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , ARTP_NUM_PROPERTIES >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_EQUIP_SLOTS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < uint8_t , NUM_REAL_SPECIAL_ARMOURS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < bool , NUM_GIZMOS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int8_t , NUM_STATS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_GEM_TYPES >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_DURATIONS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_ATTRIBUTES >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_TIMERS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < uint8_t , NUM_SKILLS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < training_status , NUM_SKILLS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < unsigned int , NUM_SKILLS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_GODS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < unique_item_status_type , 150 >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < uint8_t , NUM_GODS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < short , NUM_GODS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < uint8_t , NUM_MUTATIONS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < uint8_t , NUM_ABILITIES >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_BANES >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < uint32_t , NUM_WEAPONS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < uint32_t , NUM_ARMOURS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < ability_type , 52 >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , 27 >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < bool , NUM_STATS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_PLAYER_TRIGGER_TYPES >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , MAX_KNOWN_SPELLS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/pcg.h:24:18: style:inconclusive: Technically the member function 'rng::PcgRNG::get_state' can be const. [functionConst] stone_soup-0.34.1/source/pcg.h:25:18: style:inconclusive: Technically the member function 'rng::PcgRNG::get_inc' can be const. [functionConst] stone_soup-0.34.1/source/pcg.h:26:18: style:inconclusive: Technically the member function 'rng::PcgRNG::get_count' can be const. [functionConst] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < int , 19 , 19 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < int , 19 , 19 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < int , 19 , 19 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < int , 19 , 19 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < int , NUM_OBJECT_CLASSES , 60 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < int , NUM_OBJECT_CLASSES , 60 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < int , NUM_OBJECT_CLASSES , 60 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < int , NUM_OBJECT_CLASSES , 60 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < uint32_t , 6 , 60 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < uint32_t , 6 , 60 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < uint32_t , 6 , 60 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < uint32_t , 6 , 60 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < bool , NUM_OBJECT_CLASSES , 60 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < bool , NUM_OBJECT_CLASSES , 60 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < bool , NUM_OBJECT_CLASSES , 60 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < bool , NUM_OBJECT_CLASSES , 60 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , ARTP_NUM_PROPERTIES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , ARTP_NUM_PROPERTIES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_EQUIP_SLOTS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_EQUIP_SLOTS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < uint8_t , NUM_REAL_SPECIAL_ARMOURS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < uint8_t , NUM_REAL_SPECIAL_ARMOURS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < bool , NUM_GIZMOS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < bool , NUM_GIZMOS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int8_t , NUM_STATS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int8_t , NUM_STATS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < item_def , 128 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < item_def , 128 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_GEM_TYPES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_GEM_TYPES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_DURATIONS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_DURATIONS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_ATTRIBUTES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_ATTRIBUTES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_TIMERS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_TIMERS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < uint8_t , NUM_SKILLS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < uint8_t , NUM_SKILLS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < training_status , NUM_SKILLS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < training_status , NUM_SKILLS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < unsigned int , NUM_SKILLS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < unsigned int , NUM_SKILLS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_GODS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_GODS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < unique_item_status_type , 150 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < unique_item_status_type , 150 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < uint8_t , NUM_GODS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < uint8_t , NUM_GODS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < short , NUM_GODS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < short , NUM_GODS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < uint8_t , NUM_MUTATIONS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < uint8_t , NUM_MUTATIONS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < uint8_t , NUM_ABILITIES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < uint8_t , NUM_ABILITIES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_BANES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_BANES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < uint32_t , NUM_WEAPONS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < uint32_t , NUM_WEAPONS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < uint32_t , NUM_ARMOURS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < uint32_t , NUM_ARMOURS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < ability_type , 52 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < ability_type , 52 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , 27 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , 27 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < bool , NUM_STATS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < bool , NUM_STATS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_PLAYER_TRIGGER_TYPES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_PLAYER_TRIGGER_TYPES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < PlaceInfo , NUM_BRANCHES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < PlaceInfo , NUM_BRANCHES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , MAX_KNOWN_SPELLS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , MAX_KNOWN_SPELLS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < int , 19 > , 19 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < int , 19 > , 19 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < int , 60 > , NUM_OBJECT_CLASSES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < int , 60 > , NUM_OBJECT_CLASSES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < uint32_t , 60 > , 6 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < uint32_t , 60 > , 6 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < bool , 60 > , NUM_OBJECT_CLASSES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < bool , 60 > , NUM_OBJECT_CLASSES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < mon_holy_type_flags , 5 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < movement_type_flags , 6 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < spflag , -1 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < monclass_flag_type , -1 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < monster_flag_type , -1 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < species_flag , -1 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/pcg.h:11:9: style: Class 'PcgRNG' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/pcg.h:12:9: style: Class 'PcgRNG' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/random.h:21:9: style: Class 'generator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/random.h:22:9: style: Class 'generator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/random.h:32:9: style: Class 'subgenerator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/kills.h:24:5: style: Struct 'kill_monster_desc' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/kills.h:25:5: style: Struct 'kill_monster_desc' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/kills.h:55:5: style: Class 'kill_def' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/kills.h:85:5: style: Class 'kill_ghost' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/kills.h:118:5: style: Struct 'kill_exp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/maybe-bool.h:63:15: style: Class 'maybe_bool' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/maybe-bool.h:72:15: style: Class 'maybe_bool' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/place-info.h:55:5: style: Class 'LevelXPInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/format.h:83:9: style: Struct 'fs_op' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/format.h:88:9: style: Struct 'fs_op' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/quiver.h:153:9: style: Struct 'action_cycler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/hiscores.h:48:5: style: Class 'xlog_fields' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/end.h:24:5: style: Struct 'game_ended_condition' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/state.h:264:5: style: Class 'god_acting' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/state.h:269:5: style: Class 'god_acting' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/state.h:285:5: style: Class 'mon_acting' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < int , 19 , 19 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < int , NUM_OBJECT_CLASSES , 60 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < uint32_t , 6 , 60 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < bool , NUM_OBJECT_CLASSES , 60 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , ARTP_NUM_PROPERTIES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_EQUIP_SLOTS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < uint8_t , NUM_REAL_SPECIAL_ARMOURS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < bool , NUM_GIZMOS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int8_t , NUM_STATS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < item_def , 128 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_GEM_TYPES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_DURATIONS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_ATTRIBUTES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_TIMERS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < uint8_t , NUM_SKILLS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < training_status , NUM_SKILLS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < unsigned int , NUM_SKILLS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_GODS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < unique_item_status_type , 150 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < uint8_t , NUM_GODS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < short , NUM_GODS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < uint8_t , NUM_MUTATIONS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < uint8_t , NUM_ABILITIES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_BANES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < uint32_t , NUM_WEAPONS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < uint32_t , NUM_ARMOURS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < ability_type , 52 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , 27 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < bool , NUM_STATS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_PLAYER_TRIGGER_TYPES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < PlaceInfo , NUM_BRANCHES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , MAX_KNOWN_SPELLS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < int , 19 > , 19 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < int , 60 > , NUM_OBJECT_CLASSES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < uint32_t , 60 > , 6 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < bool , 60 > , NUM_OBJECT_CLASSES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < mon_holy_type_flags , 5 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < movement_type_flags , 6 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < spflag , -1 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < monclass_flag_type , -1 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < monster_flag_type , -1 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < species_flag , -1 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/player.h:547:14: style: The destructor '~player' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/actor.h:30:14: note: Virtual destructor in base class stone_soup-0.34.1/source/player.h:547:14: note: Destructor in derived class stone_soup-0.34.1/source/player.h:904:10: style: The function 'incapacitated' overrides a function in a base class but just delegates back to the base class. [uselessOverride] stone_soup-0.34.1/source/actor.h:354:18: note: Virtual function in base class stone_soup-0.34.1/source/player.h:904:10: note: Function in derived class stone_soup-0.34.1/source/hiscores.h:189:12: performance: Function 'get_name()' should return member 'name' by const reference. [returnByReference] stone_soup-0.34.1/source/actor-los.cc:16:39: style:inconclusive: Function 'see_cell' argument 1 names different: declaration 'c' definition 'p'. [funcArgNamesDifferent] stone_soup-0.34.1/source/actor.h:143:44: note: Function 'see_cell' argument 1 names different: declaration 'c' definition 'p'. stone_soup-0.34.1/source/actor-los.cc:16:39: note: Function 'see_cell' argument 1 names different: declaration 'c' definition 'p'. stone_soup-0.34.1/source/actor-los.cc:44:48: style:inconclusive: Function 'see_cell_no_trans' argument 1 names different: declaration 'c' definition 'p'. [funcArgNamesDifferent] stone_soup-0.34.1/source/actor.h:144:53: note: Function 'see_cell_no_trans' argument 1 names different: declaration 'c' definition 'p'. stone_soup-0.34.1/source/actor-los.cc:44:48: note: Function 'see_cell_no_trans' argument 1 names different: declaration 'c' definition 'p'. stone_soup-0.34.1/source/actor-los.cc:49:51: style:inconclusive: Function 'trans_wall_blocking' argument 1 names different: declaration 'c' definition 'p'. [funcArgNamesDifferent] stone_soup-0.34.1/source/player.h:597:47: note: Function 'trans_wall_blocking' argument 1 names different: declaration 'c' definition 'p'. stone_soup-0.34.1/source/actor-los.cc:49:51: note: Function 'trans_wall_blocking' argument 1 names different: declaration 'c' definition 'p'. stone_soup-0.34.1/source/quiver.h:126:32: performance: Function parameter 'key' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/end.h:24:49: performance: Function parameter 'msg' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/fixedvector.h:42:22: performance: Function parameter 'def' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/random.h:155:15: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/random.h:183:19: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/bitary.cc:14:5: warning: Class 'bit_vector' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] stone_soup-0.34.1/source/bitary.cc:10:38: style:inconclusive: Function 'bit_vector' argument 1 names different: declaration 'size' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/bitary.h:23:30: note: Function 'bit_vector' argument 1 names different: declaration 'size' definition 's'. stone_soup-0.34.1/source/bitary.cc:10:38: note: Function 'bit_vector' argument 1 names different: declaration 'size' definition 's'. stone_soup-0.34.1/source/bitary.h:115:51: debug: SymbolDatabase couldn't resolve all user defined types. [debug] stone_soup-0.34.1/source/enum.h:19:1: debug: SymbolDatabase couldn't resolve all user defined types. [debug] stone_soup-0.34.1/source/random.h:229:1: debug: SymbolDatabase couldn't resolve all user defined types. [debug] stone_soup-0.34.1/source/random.h:239:1: debug: SymbolDatabase couldn't resolve all user defined types. [debug] stone_soup-0.34.1/source/random.h:251:1: debug: SymbolDatabase couldn't resolve all user defined types. [debug] stone_soup-0.34.1/source/random.h:261:1: debug: SymbolDatabase couldn't resolve all user defined types. [debug] stone_soup-0.34.1/source/libutil.h:145:1: debug: SymbolDatabase couldn't resolve all user defined types. [debug] stone_soup-0.34.1/source/ui.h:231:1: debug: SymbolDatabase couldn't resolve all user defined types. [debug] stone_soup-0.34.1/source/ui.h:528:12: debug: SymbolDatabase couldn't resolve all user defined types. [debug] stone_soup-0.34.1/source/fixedp.h:79:1: debug: SymbolDatabase couldn't resolve all user defined types. [debug] stone_soup-0.34.1/source/fixedp.h:765:5: debug: SymbolDatabase couldn't resolve all user defined types. [debug] stone_soup-0.34.1/source/fixedp.h:200:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Scale [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fixedp.h:218:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OtherScale [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fixedp.h:247:68: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Scale [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fixedp.h:256:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Scale [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fixedp.h:267:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Scale [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fixedp.h:347:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Scale [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fixedp.h:352:71: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Scale [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fixedp.h:435:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Scale [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fixedp.h:446:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Scale [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fixedp.h:489:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Scale [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fixedp.h:507:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Scale [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ui.h:704:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable HORZ [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/adjust.cc:236:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable slot [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info::i_ghost' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::type' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::base_type' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::number' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::num_heads' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::slime_size' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::is_active' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::_colour' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::ghost_colour' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::attitude' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::threat' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::dam' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::fire_blocker' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::mintel' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::hd' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::ac' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::ev' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::base_ev' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::sh' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::wl' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::slay' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::mresists' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::mitemuse' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::mbase_speed' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::menergy' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::attack' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::can_go_frenzy' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::can_feel_fear' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::sleepwalking' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::backlit' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::umbraed' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::last_seen_at_turn' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::threat_range' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:340:5: warning: Member variable 'monster_info_base::summoner_id' is not initialized in the constructor. Maybe it should be initialized directly in the class monster_info_base? [uninitDerivedMemberVar] stone_soup-0.34.1/source/mon-info.h:345:5: warning:inconclusive: Member variable 'monster_info::inv' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] stone_soup-0.34.1/source/shopping.h:71:5: warning: Member variable 'shop_struct::num' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < char32_t , 2 >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < char32_t , NUM_DCHAR_TYPES >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , MDAM_DEAD >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < char , NUM_POTIONS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < char , NUM_SCROLLS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < char , NUM_WANDS + NUM_MISCELLANY + NUM_BAUBLES >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < bool , NUM_MONSTERS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int8_t , NUM_FEATURES >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_MLC >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < short , NUM_MONSTER_SLOTS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < uint8_t , 3 >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < monster_type , 20 >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/cio.h:448:5: warning: Member variable 'resumable_line_reader::key' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/ui.h:517:5: warning: Member variable 'Widget::cached_sr' is not initialized. [uninitMemberVarPrivate] stone_soup-0.34.1/source/ui.h:518:5: warning: Member variable 'Widget::cached_sr_pw' is not initialized. [uninitMemberVarPrivate] stone_soup-0.34.1/source/ui.h:545:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:545:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:552:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:552:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:559:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:559:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:607:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:607:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:702:14: warning: Member variable 'Widget::cached_sr' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/ui.h:702:14: warning: Member variable 'Widget::cached_sr_pw' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/ui.h:815:5: warning:inconclusive: Member variable 'Widget::cached_sr' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/ui.h:815:5: warning:inconclusive: Member variable 'Widget::cached_sr_pw' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/ui.h:840:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:840:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:854:1: warning: Member variable 'Switcher::m_current' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:854:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:854:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:874:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:874:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:923:23: warning: Member variable 'track_info::size' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:923:23: warning: Member variable 'track_info::offset' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:923:23: warning: Member variable 'track_info::sr' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:979:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:979:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.h:1048:5: warning: Member variable 'Widget::cached_sr' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/ui.h:1048:5: warning: Member variable 'Widget::cached_sr_pw' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_OBJECT_CLASSES >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < item_def * , NUM_MISCELLANY >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/options.h:324:6: warning:inconclusive: Class 'base_game_options' which has virtual members does not have a virtual destructor. [virtualDestructor] stone_soup-0.34.1/source/act-iter.cc:114:29: style:inconclusive: Technically the member function 'monster_near_iterator::operator==' can be const. [functionConst] stone_soup-0.34.1/source/act-iter.h:44:10: note: Technically the member function 'monster_near_iterator::operator==' can be const. stone_soup-0.34.1/source/act-iter.cc:114:29: note: Technically the member function 'monster_near_iterator::operator==' can be const. stone_soup-0.34.1/source/act-iter.cc:210:26: style:inconclusive: Technically the member function 'far_to_near_sorter::operator()' can be const. [functionConst] stone_soup-0.34.1/source/act-iter.h:83:10: note: Technically the member function 'far_to_near_sorter::operator()' can be const. stone_soup-0.34.1/source/act-iter.cc:210:26: note: Technically the member function 'far_to_near_sorter::operator()' can be const. stone_soup-0.34.1/source/act-iter.cc:215:26: style:inconclusive: Technically the member function 'near_to_far_sorter::operator()' can be const. [functionConst] stone_soup-0.34.1/source/act-iter.h:90:10: note: Technically the member function 'near_to_far_sorter::operator()' can be const. stone_soup-0.34.1/source/act-iter.cc:215:26: note: Technically the member function 'near_to_far_sorter::operator()' can be const. stone_soup-0.34.1/source/fixedp.h:108:47: style: The member function 'fixedp::_safe_abs' can be static. [functionStatic] stone_soup-0.34.1/source/libutil.h:147:10: style:inconclusive: Technically the member function 'greater_second::operator()' can be const. [functionConst] stone_soup-0.34.1/source/env.h:148:14: style: The member function 'menv_range_proxy::begin' can be static. [functionStatic] stone_soup-0.34.1/source/env.h:149:14: style: The member function 'menv_range_proxy::end' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < dungeon_feature_type , 80 , 70 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < dungeon_feature_type , 80 , 70 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < dungeon_feature_type , 80 , 70 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < dungeon_feature_type , 80 , 70 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < enum_bitfield < feature_property_type , -1 > , 80 , 70 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < enum_bitfield < feature_property_type , -1 > , 80 , 70 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < enum_bitfield < feature_property_type , -1 > , 80 , 70 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < enum_bitfield < feature_property_type , -1 > , 80 , 70 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < unsigned short , 80 , 70 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < unsigned short , 80 , 70 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < unsigned short , 80 , 70 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < unsigned short , 80 , 70 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < int , 80 , 70 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < int , 80 , 70 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < int , 80 , 70 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < int , 80 , 70 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < unsigned int , 80 , 70 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < unsigned int , 80 , 70 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < unsigned int , 80 , 70 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < unsigned int , 80 , 70 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < short , 80 , 70 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < short , 80 , 70 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < short , 80 , 70 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < short , 80 , 70 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < map_cell , 80 , 70 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < map_cell , 80 , 70 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < map_cell , 80 , 70 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < map_cell , 80 , 70 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < char32_t , 2 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < char32_t , 2 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < char32_t , NUM_DCHAR_TYPES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < char32_t , NUM_DCHAR_TYPES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , MDAM_DEAD >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , MDAM_DEAD >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < char , NUM_POTIONS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < char , NUM_POTIONS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < char , NUM_SCROLLS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < char , NUM_SCROLLS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < char , NUM_WANDS + NUM_MISCELLANY + NUM_BAUBLES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < char , NUM_WANDS + NUM_MISCELLANY + NUM_BAUBLES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < bool , NUM_MONSTERS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < bool , NUM_MONSTERS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int8_t , NUM_FEATURES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int8_t , NUM_FEATURES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_MLC >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_MLC >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < short , NUM_MONSTER_SLOTS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < short , NUM_MONSTER_SLOTS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < uint8_t , 3 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < uint8_t , 3 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < item_def , 2000 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < item_def , 2000 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < monster , MAX_MONSTERS + 2 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < monster , MAX_MONSTERS + 2 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < monster_type , 20 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < monster_type , 20 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < dungeon_feature_type , 70 > , 80 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < dungeon_feature_type , 70 > , 80 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < enum_bitfield < feature_property_type , -1 > , 70 > , 80 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < enum_bitfield < feature_property_type , -1 > , 70 > , 80 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < unsigned short , 70 > , 80 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < unsigned short , 70 > , 80 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < int , 70 > , 80 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < int , 70 > , 80 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < unsigned int , 70 > , 80 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < unsigned int , 70 > , 80 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < short , 70 > , 80 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < short , 70 > , 80 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < map_cell , 70 > , 80 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < map_cell , 70 > , 80 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < feature_property_type , -1 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < Layer , 5 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < use_animation_type , -1 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < spschool , 10 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/act-iter.h:13:5: style: Class 'actor_near_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/act-iter.h:14:5: style: Class 'actor_near_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/act-iter.h:36:5: style: Class 'monster_near_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/act-iter.h:37:5: style: Class 'monster_near_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/show.h:60:5: style: Struct 'show_type' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/show.h:61:5: style: Struct 'show_type' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/show.h:62:5: style: Struct 'show_type' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/show.h:63:5: style: Struct 'show_type' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/feature.h:34:5: style: Struct 'feature_def' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:131:15: style: Class 'fixedp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:135:15: style: Class 'fixedp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:139:15: style: Class 'fixedp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:143:15: style: Class 'fixedp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:147:15: style: Class 'fixedp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:155:15: style: Class 'fixedp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:160:15: style: Class 'fixedp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/options.h:79:5: style: Struct 'message_filter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/options.h:81:5: style: Struct 'message_filter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/options.h:104:5: style: Struct 'sound_mapping' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/options.h:125:5: style: Struct 'colour_mapping' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/options.h:150:5: style: Struct 'message_colour_mapping' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/options.h:172:5: style: Struct 'mlc_mapping' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/clua.h:25:5: style: Class 'lua_stack_cleaner' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/clua.h:35:5: style: Class 'lua_call_throttle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/clua.h:60:5: style: Class 'lua_datum' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/clua.h:92:5: style: Class 'CLua' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/clua.h:215:5: style: Class 'lua_text_pattern' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/dgn-event.h:56:5: style: Class 'dgn_event' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapmark.h:86:5: style: Class 'map_feature_marker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapmark.h:104:5: style: Class 'map_corruption_marker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapmark.h:121:5: style: Class 'map_tomb_marker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapmark.h:138:5: style: Class 'map_malign_gateway_marker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapmark.h:165:5: style: Class 'map_phoenix_marker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapmark.h:192:5: style: Class 'map_door_seal_marker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapmark.h:214:5: style: Class 'map_terrain_change_marker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapmark.h:244:5: style: Class 'map_cloud_spreader_marker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapmark.h:273:5: style: Class 'map_lua_marker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapmark.h:309:5: style: Class 'map_wiz_props_marker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapmark.h:329:5: style: Class 'map_position_marker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mon-ench.h:36:5: style: Class 'mon_enchant' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/libutil.h:302:5: style: Class 'mouse_control' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < dungeon_feature_type , 80 , 70 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < enum_bitfield < feature_property_type , -1 > , 80 , 70 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < unsigned short , 80 , 70 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < int , 80 , 70 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < unsigned int , 80 , 70 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < short , 80 , 70 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < map_cell , 80 , 70 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < char32_t , 2 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < char32_t , NUM_DCHAR_TYPES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , MDAM_DEAD >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < char , NUM_POTIONS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < char , NUM_SCROLLS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < char , NUM_WANDS + NUM_MISCELLANY + NUM_BAUBLES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < bool , NUM_MONSTERS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int8_t , NUM_FEATURES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_MLC >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < short , NUM_MONSTER_SLOTS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < uint8_t , 3 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < item_def , 2000 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < monster , MAX_MONSTERS + 2 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < monster_type , 20 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < dungeon_feature_type , 70 > , 80 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < enum_bitfield < feature_property_type , -1 > , 70 > , 80 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < unsigned short , 70 > , 80 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < int , 70 > , 80 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < unsigned int , 70 > , 80 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < short , 70 > , 80 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < map_cell , 70 > , 80 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < feature_property_type , -1 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < Layer , 5 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < use_animation_type , -1 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < spschool , 10 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/bitary.h:137:5: style: Class 'FixedBitArray < 80 , 70 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/clua.h:67:6: style: The destructor '~lua_datum' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/clua.h:50:14: note: Virtual destructor in base class stone_soup-0.34.1/source/clua.h:67:6: note: Destructor in derived class stone_soup-0.34.1/source/clua.h:216:6: style: The destructor '~lua_text_pattern' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/pattern.h:44:14: note: Virtual destructor in base class stone_soup-0.34.1/source/clua.h:216:6: note: Destructor in derived class stone_soup-0.34.1/source/mapmark.h:276:6: style: The destructor '~map_lua_marker' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/mapmark.h:55:14: note: Virtual destructor in base class stone_soup-0.34.1/source/mapmark.h:276:6: note: Destructor in derived class stone_soup-0.34.1/source/monster.h:55:6: style: The destructor '~monster' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/actor.h:30:14: note: Virtual destructor in base class stone_soup-0.34.1/source/monster.h:55:6: note: Destructor in derived class stone_soup-0.34.1/source/options.h:349:25: performance: Function 'get_option_behaviour()' should return member 'option_behaviour' by const reference. [returnByReference] stone_soup-0.34.1/source/fixedp.h:573:14: style:inconclusive: Variable 'test' is reassigned a value before the old one has been used if variable is no semaphore variable. [redundantAssignment] stone_soup-0.34.1/source/fixedp.h:570:14: note: test is assigned stone_soup-0.34.1/source/fixedp.h:573:14: note: test is overwritten stone_soup-0.34.1/source/fixedp.h:585:14: style:inconclusive: Variable 'test' is reassigned a value before the old one has been used if variable is no semaphore variable. [redundantAssignment] stone_soup-0.34.1/source/fixedp.h:573:14: note: test is assigned stone_soup-0.34.1/source/fixedp.h:585:14: note: test is overwritten stone_soup-0.34.1/source/fixedp.h:685:14: style:inconclusive: Variable 'test' is reassigned a value before the old one has been used if variable is no semaphore variable. [redundantAssignment] stone_soup-0.34.1/source/fixedp.h:585:14: note: test is assigned stone_soup-0.34.1/source/fixedp.h:685:14: note: test is overwritten stone_soup-0.34.1/source/ui.h:394:10: style: Either there is a missing 'override', or the member function 'ui::Widget::set_margin_for_sdl' can be static. [functionStatic] stone_soup-0.34.1/source/ui.h:461:19: style:inconclusive: Either there is a missing 'override', or the member function 'ui::Widget::sync_id' can be const. [functionConst] stone_soup-0.34.1/source/ui.h:500:10: style:inconclusive: Either there is a missing 'override', or the member function 'ui::Widget::focusable' can be const. [functionConst] stone_soup-0.34.1/source/ui.h:589:14: style:inconclusive: Technically the member function 'ui::Bin::iterator::operator==' can be const. [functionConst] stone_soup-0.34.1/source/ui.h:663:14: style:inconclusive: Technically the member function 'ui::ContainerVec::iterator::operator==' can be const. [functionConst] stone_soup-0.34.1/source/ui.h:964:14: style:inconclusive: Technically the member function 'ui::Grid::iterator::operator==' can be const. [functionConst] stone_soup-0.34.1/source/ui.h:1167:13: style:inconclusive: Technically the member function 'ui::TextEntry::LineReader::get_cursor_position' can be const. [functionConst] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_OBJECT_CLASSES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_OBJECT_CLASSES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < item_def * , NUM_MISCELLANY >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < item_def * , NUM_MISCELLANY >::size' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < abflag , -1 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < invprompt_flag , -1 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/cio.h:31:5: style: Class 'input_history' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/cio.h:109:5: style: Struct 'c_mouse_event' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/cio.h:324:5: style: Class 'cursor_control' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unwind.h:68:5: style: Class 'unwinder' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/ui.h:219:5: style: Class 'FocusEvent' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/menu.h:42:5: style: Struct 'menu_letter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/menu.h:69:5: style: Struct 'menu_letter2' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/menu.h:116:5: style: Class 'MenuEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/menu.h:204:5: style: Class 'ToggleableMenuEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/menu.h:310:5: style: Class 'Menu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/menu.h:498:5: style: Class 'ToggleableMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/menu.h:541:9: style: Struct 'column' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/invent.h:97:5: style: Class 'InvEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/invent.h:127:5: style: Class 'InvMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/macro.h:89:5: style: Class 'key_recorder_raii' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/message.h:120:9: style: Class 'tee' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/message.h:135:9: style: Class 'force_stderr' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/message.h:145:9: style: Class 'suppress' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/message.h:146:9: style: Class 'suppress' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/message.h:184:9: style: Struct 'setparam' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/message.h:190:9: style: Struct 'capitalisation' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/message.h:197:9: style: Struct 'mute' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/message.h:204:9: style: Class 'mpr_stream_buf' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/prompt.h:44:5: style: Class 'PromptMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < bool >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_OBJECT_CLASSES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < item_def * , NUM_MISCELLANY >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < abflag , -1 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < invprompt_flag , -1 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/ui.h:554:14: style: The destructor '~Container' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:292:14: note: Virtual destructor in base class stone_soup-0.34.1/source/ui.h:554:14: note: Destructor in derived class stone_soup-0.34.1/source/ui.h:555:18: style: The function 'for_each_child' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:366:18: note: Virtual function in base class stone_soup-0.34.1/source/ui.h:555:18: note: Function in derived class stone_soup-0.34.1/source/ui.h:561:14: style: The destructor '~Bin' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:554:14: note: Virtual destructor in base class stone_soup-0.34.1/source/ui.h:561:14: note: Destructor in derived class stone_soup-0.34.1/source/ui.h:609:14: style: The destructor '~ContainerVec' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:554:14: note: Virtual destructor in base class stone_soup-0.34.1/source/ui.h:609:14: note: Destructor in derived class stone_soup-0.34.1/source/ui.h:709:14: style: The destructor '~Box' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:609:14: note: Virtual destructor in base class stone_soup-0.34.1/source/ui.h:709:14: note: Destructor in derived class stone_soup-0.34.1/source/ui.h:743:14: style: The destructor '~Text' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:292:14: note: Virtual destructor in base class stone_soup-0.34.1/source/ui.h:743:14: note: Destructor in derived class stone_soup-0.34.1/source/ui.h:820:14: style: The destructor '~Image' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:292:14: note: Virtual destructor in base class stone_soup-0.34.1/source/ui.h:820:14: note: Destructor in derived class stone_soup-0.34.1/source/ui.h:842:14: style: The destructor '~Stack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:609:14: note: Virtual destructor in base class stone_soup-0.34.1/source/ui.h:842:14: note: Destructor in derived class stone_soup-0.34.1/source/ui.h:856:14: style: The destructor '~Switcher' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:609:14: note: Virtual destructor in base class stone_soup-0.34.1/source/ui.h:856:14: note: Destructor in derived class stone_soup-0.34.1/source/ui.h:876:14: style: The destructor '~Grid' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:554:14: note: Virtual destructor in base class stone_soup-0.34.1/source/ui.h:876:14: note: Destructor in derived class stone_soup-0.34.1/source/ui.h:981:14: style: The destructor '~Scroller' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:561:14: note: Virtual destructor in base class stone_soup-0.34.1/source/ui.h:981:14: note: Destructor in derived class stone_soup-0.34.1/source/ui.h:1105:12: performance: Function 'get_text()' should return member 'm_text' by const reference. [returnByReference] stone_soup-0.34.1/source/adjust.cc:151:29: warning:inconclusive: Logical disjunction always evaluates to true: keyin < 'a' || keyin > 'Z'. [incorrectLogicOperator] stone_soup-0.34.1/source/mon-util.h:187:26: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] stone_soup-0.34.1/source/stringutil.h:96:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/stringutil.h:244:68: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/adjust.cc:219:46: style:inconclusive: Function 'swap_inv_slots' argument 2 names different: declaration 'new_letter' definition 'to_slot'. [funcArgNamesDifferent] stone_soup-0.34.1/source/adjust.h:14:46: note: Function 'swap_inv_slots' argument 2 names different: declaration 'new_letter' definition 'to_slot'. stone_soup-0.34.1/source/adjust.cc:219:46: note: Function 'swap_inv_slots' argument 2 names different: declaration 'new_letter' definition 'to_slot'. stone_soup-0.34.1/source/ui.h:1106:26: performance: Function parameter 's' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/menu.h:342:49: performance: Function parameter 'filter' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/message.h:93:63: performance: Function parameter 'prompt' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_BRANCHES >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/json-wrapper.h:22:10: style:inconclusive: Technically the member function 'JsonWrapper::check' can be const. [functionConst] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < level_id , NUM_BRANCHES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < level_id , NUM_BRANCHES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_BRANCHES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_BRANCHES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < brflag , -1 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/json-wrapper.h:8:5: style: Struct 'JsonWrapper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/branch.h:87:5: style: Class 'branch_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < level_id , NUM_BRANCHES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_BRANCHES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < brflag , -1 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4616:51: debug: simplifyOperatorName: found unsimplified operator name [debug] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2193:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Clock [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2254:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Clock [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2448:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable iterations [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2453:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable result [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2470:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable elapsed [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2673:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Clock [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2961:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable E [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3169:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SZ [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3177:79: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SZ [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3185:79: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SZ [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3500:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable num [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5505:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5512:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5519:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5526:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5533:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5540:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5547:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5554:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5718:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5725:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:7592:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Gs [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8025:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8100:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8106:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8421:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable N [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8436:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable N [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8758:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable is_iec559 [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10462:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable N [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10470:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable N [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10478:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable N [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10519:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Idx [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10530:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Idx [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10538:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Idx [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11050:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12297:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable shouldRedirectStdOut [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12348:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable shouldReportAllAssertions [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12392:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable shouldRedirectStdOut [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_branch.cc:15:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BRANCH_SLIME [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4770:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4772:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4782:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4794:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4712:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4722:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4731:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1278:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable args [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/acquire.cc:1154:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_TROG [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/acquire.cc:1411:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable props [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/acquire.cc:1484:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable show_background [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/acquire.cc:1496:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACT_EXECUTE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/acquire.cc:1542:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable base_type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/acquire.cc:1598:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACT_EXECUTE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/enum.h:135:28: style: The member function 'enum_bitfield < mgen_flag , -1 >::range::begin' can be static. [functionStatic] stone_soup-0.34.1/source/mgen-data.h:126:5: style: Struct 'mgen_data' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/enum.h:45:15: style: Class 'enum_bitfield < mgen_flag , -1 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/initfile.h:103:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/arena.cc:528:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Long [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/arena.cc:563:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_HUMAN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/arena.cc:693:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable speed_increment [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/arena.cc:1020:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable expand_h [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/arena.cc:1151:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable active_members [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/arena.cc:1175:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable active_members [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/arena.cc:1259:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable active_members [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5468:9: warning: Member variable 'ITransientExpression::m_isBinaryExpression' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5468:9: warning: Member variable 'ITransientExpression::m_result' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3911:9: warning: Member variable 'Optional < ColourMode >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: warning: Member variable 'Optional < ColourMode >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3915:9: warning: Member variable 'Optional < ColourMode >::storage' is not initialized in the copy constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3911:9: warning: Member variable 'Optional < std :: string >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: warning: Member variable 'Optional < std :: string >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3915:9: warning: Member variable 'Optional < std :: string >::storage' is not initialized in the copy constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3911:9: warning: Member variable 'Optional < ReporterSpec >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: warning: Member variable 'Optional < ReporterSpec >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3915:9: warning: Member variable 'Optional < ReporterSpec >::storage' is not initialized in the copy constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3911:9: warning: Member variable 'Optional < unsigned int >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: warning: Member variable 'Optional < unsigned int >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3915:9: warning: Member variable 'Optional < unsigned int >::storage' is not initialized in the copy constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3911:9: warning: Member variable 'Optional < AssertionResult >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: warning: Member variable 'Optional < AssertionResult >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3915:9: warning: Member variable 'Optional < AssertionResult >::storage' is not initialized in the copy constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3911:9: warning: Member variable 'Optional < AssertionStats >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: warning: Member variable 'Optional < AssertionStats >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3915:9: warning: Member variable 'Optional < AssertionStats >::storage' is not initialized in the copy constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3911:9: warning: Member variable 'Optional < BenchmarkStats < std :: chrono :: duration < double , std :: nano > > >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: warning: Member variable 'Optional < BenchmarkStats < std :: chrono :: duration < double , std :: nano > > >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3915:9: warning: Member variable 'Optional < BenchmarkStats < std :: chrono :: duration < double , std :: nano > > >::storage' is not initialized in the copy constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4708:17: warning: Member variable 'ResultValueBase < ParseResultType >::m_value' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/behold.cc:66:48: style:inconclusive: Function 'get_beholder' argument 1 names different: declaration 'pos' definition 'target'. [funcArgNamesDifferent] stone_soup-0.34.1/source/player.h:611:44: note: Function 'get_beholder' argument 1 names different: declaration 'pos' definition 'target'. stone_soup-0.34.1/source/behold.cc:66:48: note: Function 'get_beholder' argument 1 names different: declaration 'pos' definition 'target'. stone_soup-0.34.1/source/mgen-data.h:142:46: performance: Function parameter 'nas' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/behold.cc:96:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/behold.cc:183:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2700:22: style:inconclusive: Technically the member function 'Catch::Benchmark::Benchmark::operatorbool' can be const. [functionConst] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2770:22: style:inconclusive: Technically the member function 'Catch::Benchmark::Detail::ObjectStorage::construct' can be const. [functionConst] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2787:22: style: The member function 'Catch::Benchmark::Detail::ObjectStorage::destruct_on_exit' can be static. [functionStatic] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10740:18: style: The member function 'Catch::Matchers::IsEmptyMatcher::match' can be static. [functionStatic] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11145:18: style: The member function 'Catch::Matchers::AllTrueMatcher::match' can be static. [functionStatic] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11161:18: style: The member function 'Catch::Matchers::NoneTrueMatcher::match' can be static. [functionStatic] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11177:18: style: The member function 'Catch::Matchers::AnyTrueMatcher::match' can be static. [functionStatic] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4770:28: debug: CheckClass::isMemberVar found used member variable 'm_type' with varid 0 [varid0] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4772:58: debug: CheckClass::isMemberVar found used member variable 'm_type' with varid 0 [varid0] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:117:9: style: Class 'StringRef' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:124:9: style: Class 'StringRef' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:990:9: style: Class 'LazyExpression' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1376:19: style: Struct 'TestRunInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2058:17: style: Struct 'BenchmarkFunction' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2066:21: style: Struct 'BenchmarkFunction' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2632:13: style: Struct 'Benchmark' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4304:9: style: Class 'Config' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5210:13: style: Struct 'Help' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5992:9: style: Class 'Section' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:6094:5: style: Class 'TestInvokerAsMethod' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:6110:15: style: Struct 'NameAndTags' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:7074:19: style: Struct 'Tag' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:7240:9: style: Class 'ExceptionTranslatorRegistrar' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:7214:13: style: Class 'ExceptionTranslator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:7353:9: style: Class 'GeneratorException' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:7496:9: style: Class 'GeneratorWrapper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:7498:9: style: Class 'GeneratorWrapper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:7514:9: style: Class 'SingleValueGenerator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:7517:9: style: Class 'SingleValueGenerator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8686:9: style: Class 'FatalConditionHandlerGuard' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:9614:9: style: Class 'TestCaseInfoHasher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:9676:9: style: Class 'TestInvokerAsFunction' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:9723:9: style: Class 'TestSpecParser' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:9988:9: style: Class 'XmlEncode' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10036:9: style: Class 'XmlWriter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10553:13: style: Class 'MatchAllOfGeneric' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10608:13: style: Class 'MatchAnyOfGeneric' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10856:13: style: Class 'ContainsMatcherMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10920:5: style: Class 'ExceptionMessageMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11072:13: style: Class 'AllMatchMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11096:13: style: Class 'NoneMatchMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11120:13: style: Class 'AnyMatchMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11250:9: style: Class 'StringEqualsMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11255:9: style: Class 'StringContainsMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11260:9: style: Class 'StartsWithMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11265:9: style: Class 'EndsWithMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11310:9: style: Class 'VectorContainsElementMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11333:9: style: Class 'ContainsMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11365:9: style: Class 'EqualsMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11392:9: style: Class 'ApproxMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11429:9: style: Class 'UnorderedEqualsMatcher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11547:9: style: Class 'ReporterBase' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11594:9: style: Class 'StreamingReporterBase' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11655:9: style: Class 'AutomakeReporter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11719:9: style: Class 'ConsoleReporter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11786:13: style: Class 'AssertionOrBenchmarkResult' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11787:13: style: Class 'AssertionOrBenchmarkResult' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11987:19: style: Struct 'lineOfChars' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12059:9: style: Class 'JunitReporter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12249:9: style: Class 'ListenerRegistrar' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12232:13: style: Class 'TypedListenerFactory' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12294:9: style: Class 'SonarQubeReporter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12346:9: style: Class 'TAPReporter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12389:9: style: Class 'TeamCityReporter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12442:9: style: Class 'XmlReporter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: style: Class 'Optional < ColourMode >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: style: Class 'Optional < std :: string >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: style: Class 'Optional < ReporterSpec >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: style: Class 'Optional < unsigned int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: style: Class 'Optional < AssertionResult >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: style: Class 'Optional < AssertionStats >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: style: Class 'Optional < BenchmarkStats < std :: chrono :: duration < double , std :: nano > > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2035:21: style: Struct 'model < do_nothing >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2036:21: style: Struct 'model < do_nothing >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < IStream >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < IReporterFactory >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < EventListenerFactory >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < TestCaseInfo >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < ITestInvoker >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < IExceptionTranslator >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < callable >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < Pattern >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < ColourImpl >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < Config >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < IExceptionTranslator const >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < GeneratorUntypedBase >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < IEventListener >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < EnumInfo >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < TestCaseTracking :: ITracker >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < TablePrinter >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < SectionNode >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < Node < TestRunStats , Node < TestCaseStats , SectionNode > > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < Node < TestCaseStats , SectionNode > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4708:17: style: Class 'ResultValueBase < ParseResultType >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4708:17: style: Class 'ResultValueBase < ParseState >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8773:43: style: Assignment 'lhs=positive_zero' is redundant with condition 'lhs==positive_zero'. [duplicateConditionalAssign] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8773:18: note: Condition 'lhs==positive_zero' stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8773:43: note: Assignment 'lhs=positive_zero' is redundant stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8774:43: style: Assignment 'rhs=positive_zero' is redundant with condition 'rhs==positive_zero'. [duplicateConditionalAssign] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8774:18: note: Condition 'rhs==positive_zero' stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8774:43: note: Assignment 'rhs=positive_zero' is redundant stone_soup-0.34.1/source/branch.cc:312:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable branch [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8773:39: style: Variable 'lhs' is assigned an expression that holds the same value. [redundantAssignment] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8773:18: note: Assuming that condition 'lhs==positive_zero' is not redundant stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8773:39: note: Variable 'lhs' is assigned an expression that holds the same value. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8774:39: style: Variable 'rhs' is assigned an expression that holds the same value. [redundantAssignment] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8774:18: note: Assuming that condition 'rhs==positive_zero' is not redundant stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8774:39: note: Variable 'rhs' is assigned an expression that holds the same value. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:6105:61: style:inconclusive: Function 'makeTestInvoker' argument 1 names different: declaration 'testAsFunction' definition 'testAsMethod'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:6102:57: note: Function 'makeTestInvoker' argument 1 names different: declaration 'testAsFunction' definition 'testAsMethod'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:6105:61: note: Function 'makeTestInvoker' argument 1 names different: declaration 'testAsFunction' definition 'testAsMethod'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2502:22: style: Local variable 'resolution' shadows outer function [shadowFunction] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2421:33: note: Shadowed declaration stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2502:22: note: Shadow variable stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2600:30: style: Local variable 'mean' shadows outer function [shadowFunction] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2324:20: note: Shadowed declaration stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2600:30: note: Shadow variable stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2247:105: performance: Function parameter 'env' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2640:111: performance: Function parameter 'env' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3585:22: style: Variable 'timeInfo' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2965:27: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10249:17: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:10301:17: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11146:17: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11162:17: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11178:17: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11315:13: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11344:43: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_DACTION_COUNTERS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < bool , 17 , 17 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < bool , 17 , 17 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < bool , 17 , 17 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < bool , 17 , 17 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_DACTION_COUNTERS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_DACTION_COUNTERS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < coord_def , 5600 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < coord_def , 5600 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < bool , 17 > , 17 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < bool , 17 > , 17 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/losparam.h:94:5: style: Class 'opacity_mons_immob' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/losparam.h:129:5: style: Class 'opacity_monmove' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/los-def.h:14:5: style: Class 'los_def' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/exclude.h:37:5: style: Class 'travel_exclude' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:128:5: style: Class 'SquareArray < bool , 8 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < bool , 17 , 17 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_DACTION_COUNTERS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < coord_def , 5600 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < bool , 17 > , 17 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/colour.h:103:14: style: The destructor '~element_colour_calc' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/colour.h:80:14: note: Virtual destructor in base class stone_soup-0.34.1/source/colour.h:103:14: note: Destructor in derived class stone_soup-0.34.1/source/branch.cc:212:22: style: Return value 'branch!=BRANCH_VESTIBULE' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/branch.cc:210:19: note: Assuming that condition 'branch>=BRANCH_FIRST_HELL' is not redundant stone_soup-0.34.1/source/branch.cc:212:22: note: Return value 'branch!=BRANCH_VESTIBULE' is always true stone_soup-0.34.1/source/notes.h:81:5: warning:inconclusive: Member variable 'Note::type' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/notes.h:81:5: warning:inconclusive: Member variable 'Note::first' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/notes.h:81:5: warning:inconclusive: Member variable 'Note::second' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/colour.h:78:49: performance: Function parameter '_name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/colour.h:100:52: performance: Function parameter '_name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/travel.h:180:40: performance: Function parameter 't' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_RECITE_TYPES >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < int , NUM_SKILLS >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/mapdef.h:1203:15: style: The member function 'map_def::size' can be static. [functionStatic] stone_soup-0.34.1/source/random-pick.h:116:28: style: The member function 'random_picker < monster_type , NUM_MONSTERS >::rarity_at' can be static. [functionStatic] stone_soup-0.34.1/source/random-pick.h:38:9: note: The member function 'random_picker < monster_type , NUM_MONSTERS >::rarity_at' can be static. stone_soup-0.34.1/source/random-pick.h:116:28: note: The member function 'random_picker < monster_type , NUM_MONSTERS >::rarity_at' can be static. stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < std :: set < std :: string > , NUM_BRANCHES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < std :: set < std :: string > , NUM_BRANCHES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/dlua.h:48:5: style: Class 'dlua_chunk' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/dlua.h:49:5: style: Class 'dlua_chunk' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:64:5: style: Struct 'map_load_exception' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:65:5: style: Struct 'map_load_exception' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:108:5: style: Struct 'level_range' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:110:5: style: Struct 'level_range' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:685:5: style: Class 'mons_spec' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:727:9: style: Struct 'mons_spec_slot' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:803:5: style: Struct 'shop_spec' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:820:5: style: Struct 'trap_spec' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:844:5: style: Struct 'feature_spec' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:928:5: style: Class 'dlua_set_map' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:943:5: style: Struct 'map_file_place' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:959:5: style: Struct 'map_chance' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:1317:9: style: Struct 'map_feature_finder' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:1329:9: style: Struct 'map_bounds_check' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/dungeon.h:73:5: style: Struct 'dgn_veto_exception' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/dungeon.h:74:5: style: Struct 'dgn_veto_exception' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/dungeon.h:172:5: style: Class 'vault_place_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/dungeon.h:188:5: style: Class 'unwind_vault_placement_mask' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unicode.h:79:5: style: Class 'FileLineInput' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unicode.h:93:5: style: Class 'UTF8FileLineInput' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/initfile.h:91:5: style: Class 'StringLineInput' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/maps.h:89:5: style: Class 'dgn_map_parameters' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/maps.h:90:5: style: Class 'dgn_map_parameters' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mon-pick.h:58:5: style: Class 'positioned_monster_picker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/terrain.h:28:5: style: Class 'unwind_slime_wall_precomputer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/viewgeom.h:23:5: style: Class 'crawl_view_buffer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/arena.cc:62:9: style: Class 'arena_tee' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/arena.cc:152:9: style: Struct 'faction' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < std :: vector < std :: string > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < std :: set < std :: string > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < unique_creature_list >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < game_type >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < coord_def >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:1028:5: style: Class 'depth_ranges_X < map_chance >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mapdef.h:1028:5: style: Class 'depth_ranges_X < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < std :: set < std :: string > , NUM_BRANCHES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unicode.h:80:6: style: The destructor '~FileLineInput' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/unicode.h:58:14: note: Virtual destructor in base class stone_soup-0.34.1/source/unicode.h:80:6: note: Destructor in derived class stone_soup-0.34.1/source/unicode.h:94:6: style: The destructor '~UTF8FileLineInput' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/unicode.h:58:14: note: Virtual destructor in base class stone_soup-0.34.1/source/unicode.h:94:6: note: Destructor in derived class stone_soup-0.34.1/source/arena.cc:64:10: style: The destructor '~arena_tee' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/message.h:122:18: note: Virtual destructor in base class stone_soup-0.34.1/source/arena.cc:64:10: note: Destructor in derived class stone_soup-0.34.1/source/arena.cc:70:14: style: The function 'append' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/message.h:123:22: note: Virtual function in base class stone_soup-0.34.1/source/arena.cc:70:14: note: Function in derived class stone_soup-0.34.1/source/unwind.h:39:7: performance: Function 'value()' should return member 'val' by const reference. [returnByReference] stone_soup-0.34.1/source/unwind.h:45:7: performance: Function 'original_value()' should return member 'oldval' by const reference. [returnByReference] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_RECITE_TYPES >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_RECITE_TYPES >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < int , NUM_SKILLS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < int , NUM_SKILLS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/sqldbm.h:26:5: style: Class 'sql_datum' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/sqldbm.h:50:5: style: Class 'SQL_DBM' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/notes.h:82:5: style: Struct 'Note' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/acquire.cc:1482:5: style: Class 'AcquireEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < uint32_t >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_RECITE_TYPES >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < int , NUM_SKILLS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/arena.cc:1051:17: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] stone_soup-0.34.1/source/arena.cc:954:9: portability:inconclusive: Array 'banned_glyphs' might be filled incompletely. Did you forget to multiply the size given to 'memset()' with 'sizeof(*banned_glyphs)'? [incompleteArrayFill] stone_soup-0.34.1/source/arena.cc:249:21: style: Local variable 'items' shadows outer function [shadowFunction] stone_soup-0.34.1/source/makeitem.h:19:5: note: Shadowed declaration stone_soup-0.34.1/source/arena.cc:249:21: note: Shadow variable stone_soup-0.34.1/source/arena.cc:1370:17: style: Local variable 'items' shadows outer function [shadowFunction] stone_soup-0.34.1/source/makeitem.h:19:5: note: Shadowed declaration stone_soup-0.34.1/source/arena.cc:1370:17: note: Shadow variable stone_soup-0.34.1/source/arena.cc:381:53: performance: Function parameter 'spec' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/unwind.h:20:27: performance: Function parameter 'newval' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/unwind.h:28:27: performance: Function parameter 'newval' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/unwind.h:28:37: performance: Function parameter 'reset_to' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/arena.cc:261:23: style: Variable 'item' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/arena.cc:1239:35: style: Parameter 'split_from' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/arena.cc:1239:56: style: Parameter 'split_to' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/arena.cc:252:22: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/acquire.cc:135:52: style:inconclusive: Function '_acquirement_armour_slot' argument 1 names different: declaration '' definition 'agent'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/acquire.cc:172:64: style:inconclusive: Function '_acquirement_armour_for_slot' argument 1 names different: declaration '' definition 'slot_type'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/acquire.cc:1073:46: style:inconclusive: Function '_armour_slot_seen' argument 1 names different: declaration '' definition 'slot'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/acquire.cc:1453:29: style:inconclusive: Function 'get_keyhelp' argument 1 names different: declaration 'unused' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/acquire.cc:579:16: style: Variable 'p' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/acquire.cc:1600:15: style: Variable 'entry' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/acquire.cc:579:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/arena.cc:80:32: style: Variable 'prefix' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:315:100: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable iterator [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:730:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable out [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1101:86: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1105:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable left [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1128:72: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1172:87: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1210:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1717:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable fixed [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1782:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable hex [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1870:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable hexThreshold [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1885:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable hexThreshold [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1918:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable precision [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1924:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable precision [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2370:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2503:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_hint [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2604:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3247:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable out [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3542:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3656:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3921:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIGSTKSZ [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3942:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SA_ONSTACK [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4085:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable unitbuf [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4239:92: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5082:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Executing [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5394:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable shouldRedirectStdOut [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5701:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5702:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5703:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable clog [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5731:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5752:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5770:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5887:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5900:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable second [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6117:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable location [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6128:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CompletedSuccessfully [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6148:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_rootTracker [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6165:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Executing [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6175:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_currentTracker [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6188:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CompletedSuccessfully [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6192:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Executing [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6209:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CompletedSuccessfully [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6228:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Failed [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6308:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_filters [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6711:76: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6732:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6974:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable uppercase [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:7197:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:7251:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:7267:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:7399:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable scientific [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:7436:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable max [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:7658:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ECMAScript [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8025:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8031:117: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8037:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8340:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8434:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8452:79: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8468:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8519:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8577:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8873:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8886:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DBL_MAX_10_EXP [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8972:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:9004:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:9026:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:9066:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:9222:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable fixed [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:9485:68: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable shouldRedirectStdOut [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:9572:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable shouldReportAllAssertions [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:9589:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:10030:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:10038:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flush [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:10060:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4048:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EOF [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_mon-util.cc:15:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MONS_BUMBLEBEE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_mon-util.cc:40:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable HT_LAND [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3087:53: warning: Assert statement calls a function which may have desired side effects: 'stream'. [assertWithSideEffect] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4545:9: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] stone_soup-0.34.1/source/catch2-tests/test_items.cc:25:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OBJ_SCROLLS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_items.cc:31:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ENDOFPACK [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_items.cc:60:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ENDOFPACK [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_items.cc:81:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OSEL_ANY [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_items.cc:100:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SK_ARMOUR [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_items.cc:113:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OSEL_ANY [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_items.cc:193:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OBJ_POTIONS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_items.cc:203:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OBJ_WEAPONS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3911:9: warning: Member variable 'Optional < bazelShardingOptions >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: warning: Member variable 'Optional < bazelShardingOptions >::storage' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3915:9: warning: Member variable 'Optional < bazelShardingOptions >::storage' is not initialized in the copy constructor. [uninitMemberVar] stone_soup-0.34.1/source/catch2-tests/test_ng-init-branches.cc:33:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BRANCH_SWAMP [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_player_fixture.cc:26:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable you [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_player_fixture.cc:60:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ENDOFPACK [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3082:41: style:inconclusive: Technically the member function 'Catch::ColourImpl::guardColour' can be const. [functionConst] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4137:21: note: Technically the member function 'Catch::ColourImpl::guardColour' can be const. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3082:41: note: Technically the member function 'Catch::ColourImpl::guardColour' can be const. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2502:18: debug: CheckClass::isMemberVar found used member variable 'm_hint' with varid 0 [varid0] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1103:19: style: The member function 'Catch::Session::libIdentify' can be static. [functionStatic] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5257:14: note: The member function 'Catch::Session::libIdentify' can be static. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1103:19: note: The member function 'Catch::Session::libIdentify' can be static. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2251:28: style: The member function 'Catch::AssertionHandler::allowThrows' can be static. [functionStatic] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:5808:14: note: The member function 'Catch::AssertionHandler::allowThrows' can be static. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2251:28: note: The member function 'Catch::AssertionHandler::allowThrows' can be static. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3721:46: style: The member function 'Catch::ExceptionTranslatorRegistry::tryTranslators' can be static. [functionStatic] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8628:21: note: The member function 'Catch::ExceptionTranslatorRegistry::tryTranslators' can be static. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3721:46: note: The member function 'Catch::ExceptionTranslatorRegistry::tryTranslators' can be static. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3933:33: style: The member function 'Catch::FatalConditionHandler::engage_platform' can be static. [functionStatic] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8662:14: note: The member function 'Catch::FatalConditionHandler::engage_platform' can be static. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3933:33: note: The member function 'Catch::FatalConditionHandler::engage_platform' can be static. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3953:33: style: The member function 'Catch::FatalConditionHandler::disengage_platform' can be static. [functionStatic] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8663:14: note: The member function 'Catch::FatalConditionHandler::disengage_platform' can be static. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3953:33: note: The member function 'Catch::FatalConditionHandler::disengage_platform' can be static. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5532:22: style:inconclusive: Technically the member function 'Catch::RunContext::populateReaction' can be const. [functionConst] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:9371:14: note: Technically the member function 'Catch::RunContext::populateReaction' can be const. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5532:22: note: Technically the member function 'Catch::RunContext::populateReaction' can be const. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4070:18: style:inconclusive: Technically the member function 'Catch::Detail::::OutputDebugWriter::operator()' can be const. [functionConst] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3138:13: style: Class 'NoColourImpl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3222:9: style: Class 'ANSIColourImpl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4082:13: style: Class 'FileStream' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8672:13: style: Struct 'BySectionInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3912:9: style: Class 'Optional < bazelShardingOptions >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < StreamBufImpl < OutputDebugWriter , 256 > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < std :: ostringstream >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1202:9: style: Class 'unique_ptr < CumulativeReporterBase :: SectionNode >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11726:14: style: The function 'assertionStarting' overrides a function in a base class but is identical to the overridden function [uselessOverride] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11618:14: note: Virtual function in base class stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11726:14: note: Function in derived class stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12460:14: style: The function 'assertionStarting' overrides a function in a base class but is identical to the overridden function [uselessOverride] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11618:14: note: Virtual function in base class stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12460:14: note: Function in derived class stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1039:19: performance: Function 'getMessage()' should return member 'message' by const reference. [returnByReference] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:9262:19: performance: Function 'trimmedName()' should return member 'm_trimmed_name' by const reference. [returnByReference] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8458:9: style: The statement 'if (m_headerPrinted) m_headerPrinted=false' is logically equivalent to 'm_headerPrinted=false'. [duplicateConditionalAssign] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8459:25: note: Assignment 'm_headerPrinted=false' stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8458:9: note: Condition 'm_headerPrinted' is redundant stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:773:14: style: Condition '!uncaught_exceptions()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:773:34: note: Calling function 'uncaught_exceptions' returns 0 stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:773:14: note: Condition '!uncaught_exceptions()' is always true stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:837:14: style: Condition '!uncaught_exceptions()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:837:34: note: Calling function 'uncaught_exceptions' returns 0 stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:837:14: note: Condition '!uncaught_exceptions()' is always true stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1705:24: style: Condition 'value' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1701:27: note: Assignment 'one=1', assigned value is 1 stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1704:30: note: Assignment 'value=*reinterpret_cast(&one)', assigned value is 1 stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1705:24: note: Condition 'value' is always true stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1775:33: style: Condition 'Endianness::which()==Endianness::Little' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1775:30: note: Calling function 'which' returns 1 stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1775:33: note: Condition 'Endianness::which()==Endianness::Little' is always true stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5598:36: style: Condition 'uncaught_exceptions()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5598:36: note: Calling function 'uncaught_exceptions' returns 0 stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5598:36: note: Condition 'uncaught_exceptions()' is always false stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:7084:27: style: Condition '0x80<=value' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:7083:28: note: Assuming that condition 'value<0x80' is not redundant stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:7084:27: note: Condition '0x80<=value' is always true stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5047:30: warning: Either the condition 'parent' is redundant or there is possible null pointer dereference: parent. [nullPointerRedundantCheck] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5050:29: note: Assuming that condition 'parent' is not redundant stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5047:30: note: Null pointer dereference stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1413:16: style: The scope of the variable 'tagEnd' can be reduced. [variableScope] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1774:20: style: The scope of the variable 'end' can be reduced. [variableScope] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5392:15: style: The scope of the variable 'timer' can be reduced. [variableScope] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:382:35: style:inconclusive: Function 'setMargin' argument 1 names different: declaration 'margin' definition 'newMargin'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3629:31: note: Function 'setMargin' argument 1 names different: declaration 'margin' definition 'newMargin'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:382:35: note: Function 'setMargin' argument 1 names different: declaration 'margin' definition 'newMargin'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:389:36: style:inconclusive: Function 'setEpsilon' argument 1 names different: declaration 'epsilon' definition 'newEpsilon'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3631:32: note: Function 'setEpsilon' argument 1 names different: declaration 'epsilon' definition 'newEpsilon'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:389:36: note: Function 'setEpsilon' argument 1 names different: declaration 'epsilon' definition 'newEpsilon'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1391:36: style:inconclusive: Function 'makeTestCaseInfo' argument 1 names different: declaration 'className' definition '_className'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:7159:33: note: Function 'makeTestCaseInfo' argument 1 names different: declaration 'className' definition '_className'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1391:36: note: Function 'makeTestCaseInfo' argument 1 names different: declaration 'className' definition '_className'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1393:48: style:inconclusive: Function 'makeTestCaseInfo' argument 3 names different: declaration 'lineInfo' definition '_lineInfo'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:7161:45: note: Function 'makeTestCaseInfo' argument 3 names different: declaration 'lineInfo' definition '_lineInfo'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1393:48: note: Function 'makeTestCaseInfo' argument 3 names different: declaration 'lineInfo' definition '_lineInfo'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1398:51: style:inconclusive: Function 'TestCaseInfo' argument 2 names different: declaration '_tags' definition '_nameAndTags'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:7107:41: note: Function 'TestCaseInfo' argument 2 names different: declaration '_tags' definition '_nameAndTags'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1398:51: note: Function 'TestCaseInfo' argument 2 names different: declaration '_tags' definition '_nameAndTags'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1495:52: style:inconclusive: Function 'internalAppendTag' argument 1 names different: declaration 'tagString' definition 'tagStr'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:7131:42: note: Function 'internalAppendTag' argument 1 names different: declaration 'tagString' definition 'tagStr'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1495:52: note: Function 'internalAppendTag' argument 1 names different: declaration 'tagString' definition 'tagStr'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1730:58: style:inconclusive: Function 'convertIntoString' argument 2 names different: declaration 'escapeInvisibles' definition 'escape_invisibles'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3005:63: note: Function 'convertIntoString' argument 2 names different: declaration 'escapeInvisibles' definition 'escape_invisibles'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1730:58: note: Function 'convertIntoString' argument 2 names different: declaration 'escapeInvisibles' definition 'escape_invisibles'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2400:48: style:inconclusive: Function 'TokenStream' argument 1 names different: declaration 'it' definition 'it_'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4653:39: note: Function 'TokenStream' argument 1 names different: declaration 'it' definition 'it_'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2400:48: note: Function 'TokenStream' argument 1 names different: declaration 'it' definition 'it_'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2400:62: style:inconclusive: Function 'TokenStream' argument 2 names different: declaration 'itEnd' definition 'itEnd_'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4653:52: note: Function 'TokenStream' argument 2 names different: declaration 'itEnd' definition 'itEnd_'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2400:62: note: Function 'TokenStream' argument 2 names different: declaration 'itEnd' definition 'itEnd_'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3281:63: style:inconclusive: Function 'makeColourImpl' argument 1 names different: declaration 'colourSelection' definition 'implSelection'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4144:63: note: Function 'makeColourImpl' argument 1 names different: declaration 'colourSelection' definition 'implSelection'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3281:63: note: Function 'makeColourImpl' argument 1 names different: declaration 'colourSelection' definition 'implSelection'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3640:89: style:inconclusive: Function 'registerEnum' argument 2 names different: declaration 'allEnums' definition 'allValueNames'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:8580:73: note: Function 'registerEnum' argument 2 names different: declaration 'allEnums' definition 'allValueNames'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3640:89: note: Function 'registerEnum' argument 2 names different: declaration 'allEnums' definition 'allValueNames'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6015:69: style:inconclusive: Function 'enforceNoDuplicateTestCases' argument 1 names different: declaration 'functions' definition 'tests'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:9643:74: note: Function 'enforceNoDuplicateTestCases' argument 1 names different: declaration 'functions' definition 'tests'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6015:69: note: Function 'enforceNoDuplicateTestCases' argument 1 names different: declaration 'functions' definition 'tests'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11692:50: style:inconclusive: Function 'testRunStarting' argument 1 names different: declaration '_testInfo' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8522:58: style:inconclusive: Function 'testRunStarting' argument 1 names different: declaration '_testRunInfo' definition '_testInfo'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11740:49: note: Function 'testRunStarting' argument 1 names different: declaration '_testRunInfo' definition '_testInfo'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8522:58: note: Function 'testRunStarting' argument 1 names different: declaration '_testRunInfo' definition '_testInfo'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11927:47: style:inconclusive: Function 'fatalErrorEncountered' argument 1 names different: declaration 'error' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11929:44: style:inconclusive: Function 'benchmarkPreparing' argument 1 names different: declaration 'name' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11930:54: style:inconclusive: Function 'benchmarkStarting' argument 1 names different: declaration 'benchmarkInfo' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11931:54: style:inconclusive: Function 'benchmarkEnded' argument 1 names different: declaration 'benchmarkStats' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11932:41: style:inconclusive: Function 'benchmarkFailed' argument 1 names different: declaration 'error' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11934:54: style:inconclusive: Function 'assertionStarting' argument 1 names different: declaration 'assertionInfo' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11935:52: style:inconclusive: Function 'assertionEnded' argument 1 names different: declaration 'assertionStats' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11938:53: style:inconclusive: Function 'listReporters' argument 1 names different: declaration 'descriptions' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11940:53: style:inconclusive: Function 'listListeners' argument 1 names different: declaration 'descriptions' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11941:60: style:inconclusive: Function 'listTests' argument 1 names different: declaration 'tests' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11942:52: style:inconclusive: Function 'listTags' argument 1 names different: declaration 'tagInfos' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11944:45: style:inconclusive: Function 'noMatchingTestCases' argument 1 names different: declaration 'unmatchedSpec' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11926:47: style:inconclusive: Function 'reportInvalidTestSpec' argument 1 names different: declaration 'unmatchedSpec' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11945:50: style:inconclusive: Function 'testRunStarting' argument 1 names different: declaration 'testRunInfo' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11946:52: style:inconclusive: Function 'testCaseStarting' argument 1 names different: declaration 'testInfo' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11947:59: style:inconclusive: Function 'testCasePartialStarting' argument 1 names different: declaration 'testInfo' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11948:48: style:inconclusive: Function 'testCasePartialStarting' argument 2 names different: declaration 'partNumber' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11949:50: style:inconclusive: Function 'sectionStarting' argument 1 names different: declaration 'sectionInfo' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11950:48: style:inconclusive: Function 'sectionEnded' argument 1 names different: declaration 'sectionStats' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11951:57: style:inconclusive: Function 'testCasePartialEnded' argument 1 names different: declaration 'testCaseStats' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11952:45: style:inconclusive: Function 'testCasePartialEnded' argument 2 names different: declaration 'partNumber' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11953:50: style:inconclusive: Function 'testCaseEnded' argument 1 names different: declaration 'testCaseStats' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11954:48: style:inconclusive: Function 'testRunEnded' argument 1 names different: declaration 'testRunStats' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11955:44: style:inconclusive: Function 'skipTest' argument 1 names different: declaration 'testInfo' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:9584:68: style:inconclusive: Function 'testCasePartialEnded' argument 1 names different: declaration 'testInfo' definition 'testStats'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12147:56: note: Function 'testCasePartialEnded' argument 1 names different: declaration 'testInfo' definition 'testStats'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:9584:68: note: Function 'testCasePartialEnded' argument 1 names different: declaration 'testInfo' definition 'testStats'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:9698:58: style:inconclusive: Function 'writeRun' argument 1 names different: declaration 'groupNode' definition 'runNode'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12316:43: note: Function 'writeRun' argument 1 names different: declaration 'groupNode' definition 'runNode'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:9698:58: note: Function 'writeRun' argument 1 names different: declaration 'groupNode' definition 'runNode'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12357:50: style:inconclusive: Function 'testRunStarting' argument 1 names different: declaration 'testInfo' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:10084:64: style:inconclusive: Function 'testRunStarting' argument 1 names different: declaration 'groupInfo' definition 'runInfo'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12402:50: note: Function 'testRunStarting' argument 1 names different: declaration 'groupInfo' definition 'runInfo'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:10084:64: note: Function 'testRunStarting' argument 1 names different: declaration 'groupInfo' definition 'runInfo'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:10089:62: style:inconclusive: Function 'testRunEnded' argument 1 names different: declaration 'testGroupStats' definition 'runStats'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12403:48: note: Function 'testRunEnded' argument 1 names different: declaration 'testGroupStats' definition 'runStats'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:10089:62: note: Function 'testRunEnded' argument 1 names different: declaration 'testGroupStats' definition 'runStats'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:10408:62: style:inconclusive: Function 'benchmarkStarting' argument 1 names different: declaration '' definition 'info'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:10417:62: style:inconclusive: Function 'benchmarkEnded' argument 1 names different: declaration '' definition 'benchmarkStats'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:296:22: style: Local variable 'mean' shadows outer function [shadowFunction] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2324:20: note: Shadowed declaration stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:296:22: note: Shadow variable stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:326:24: style: Local variable 'outlier_variance' shadows outer function [shadowFunction] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:2397:20: note: Shadowed declaration stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:326:24: note: Shadow variable stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1625:17: style: Local variable 'matches' shadows outer function [shadowFunction] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:3873:14: note: Shadowed declaration stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1625:17: note: Shadow variable stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:261:54: performance: Function parameter 'mean' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:261:77: performance: Function parameter 'stddev' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2132:44: performance: Function parameter 'customOptions' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4872:44: performance: Function parameter 'customOptions' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8312:61: performance: Function parameter 'columnInfos' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4245:24: style: Variable 'tagc' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5250:27: style: Variable 'tracker' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1724:21: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5772:19: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5888:37: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6571:21: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6908:25: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:7185:20: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1483:23: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1582:9: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2509:13: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2665:26: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2705:28: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2708:28: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:2919:25: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3611:24: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3620:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:3905:32: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4246:23: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4258:30: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4271:30: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4288:18: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5061:21: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5979:31: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5996:28: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6039:25: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6415:44: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6793:29: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6803:29: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:8916:29: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:9695:42: warning: Conversion of char literal '1' to bool always evaluates to true. [incorrectCharBooleanError] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1776:17: error: Uninitialized variable: end [legacyUninitvar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:6408:59: error: failed to expand 'TEMPLATE_TEST_CASE', Wrong number of parameters for macro 'CATCH_REC_LIST1'. [syntaxError] stone_soup-0.34.1/source/catch2-tests/test_randbook.cc:21:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SPELL_LIST_KEY [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_player.cc:22:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MUT_ICY_BLUE_SCALES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_player.cc:27:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MUT_ICY_BLUE_SCALES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_player.cc:35:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MUT_ICY_BLUE_SCALES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_player.cc:45:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MUT_ICY_BLUE_SCALES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_player.cc:52:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MUT_GELATINOUS_BODY [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_player.cc:60:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MUT_IRIDESCENT_SCALES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_player.cc:68:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MUT_NO_POTION_HEAL [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_player.cc:76:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MUT_RUGGED_BROWN_SCALES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_player.cc:84:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MUT_MOLTEN_SCALES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_player.cc:92:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MUT_PHYSICAL_VULNERABILITY [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_species.cc:19:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_BASE_DRACONIAN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1413:23: style: Variable 'tagEnd' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:1777:17: style: Variable 'end' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5750:32: style: Unused variable: end [unusedVariable] stone_soup-0.34.1/source/catch2-tests/test_spl-util.cc:14:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SPELL_FIRST_SPELL [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_spl-util.cc:40:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SPELL_FIRST_SPELL [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_tags.cc:21:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TAG_MINOR_SHORT_SPELL_TYPE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_tags.cc:88:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TAG_MINOR_SHORT_SPELL_TYPE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_tags.cc:130:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SPELL_STRIKING [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_tags.cc:162:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TAG_MINOR_TRACK_REGEN_ITEMS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_tags.cc:194:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map_cell [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/cluautil.cc:34:0: debug: Function::addArguments found argument 'map' with varid 0. [varid0] stone_soup-0.34.1/source/delay.h:557:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable unsafe_once [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/catch2-tests/test_viewmap.cc:20:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable command_type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/delay.h:25:5: style: Class 'interrupt_block' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/delay.h:71:5: style: Struct 'activity_interrupt_data' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/delay.h:75:5: style: Struct 'activity_interrupt_data' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/delay.h:79:5: style: Struct 'activity_interrupt_data' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/delay.h:84:5: style: Struct 'activity_interrupt_data' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/delay.h:88:5: style: Struct 'activity_interrupt_data' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/delay.h:412:5: style: Class 'AscendingStairsDelay' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/delay.h:432:5: style: Class 'DescendingStairsDelay' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/delay.h:555:5: style: Class 'TravelDelay' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/delay.h:624:5: style: Class 'ShaftSelfDelay' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/cluautil.cc:34:0: style:inconclusive: Function 'clua_push_map' argument 2 names different: declaration '' definition 'map'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/delay.h:722:10: style: Local variable 'delay' shadows outer function [shadowFunction] stone_soup-0.34.1/source/libconsole.h:36:6: note: Shadowed declaration stone_soup-0.34.1/source/delay.h:722:10: note: Shadow variable stone_soup-0.34.1/source/cluautil.h:128:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable T [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:114:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_REGISTRYINDEX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:124:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_REGISTRYINDEX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:130:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_REGISTRYINDEX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:140:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_GCCOLLECT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:301:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:815:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable luaopen_base [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:908:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_REGISTRYINDEX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:976:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:1058:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:1240:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_MULTRET [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:1324:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_MULTRET [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:1392:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_REGISTRYINDEX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:1410:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_REGISTRYINDEX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:1428:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_REGISTRYINDEX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/clua.cc:1452:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_REGISTRYINDEX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/cio.cc:458:19: style:inconclusive: Technically the member function 'draw_colour::set' can be const. [functionConst] stone_soup-0.34.1/source/cio.h:348:10: note: Technically the member function 'draw_colour::set' can be const. stone_soup-0.34.1/source/cio.cc:458:19: note: Technically the member function 'draw_colour::set' can be const. stone_soup-0.34.1/source/cio.cc:448:19: style:inconclusive: Technically the member function 'draw_colour::reset' can be const. [functionConst] stone_soup-0.34.1/source/cio.h:349:10: note: Technically the member function 'draw_colour::reset' can be const. stone_soup-0.34.1/source/cio.cc:448:19: note: Technically the member function 'draw_colour::reset' can be const. stone_soup-0.34.1/source/cio.cc:531:24: style:inconclusive: Technically the member function 'line_reader::get_edit_mode' can be const. [functionConst] stone_soup-0.34.1/source/cio.h:375:15: note: Technically the member function 'line_reader::get_edit_mode' can be const. stone_soup-0.34.1/source/cio.cc:531:24: note: Technically the member function 'line_reader::get_edit_mode' can be const. stone_soup-0.34.1/source/cio.cc:516:21: style:inconclusive: Technically the member function 'line_reader::get_prompt' can be const. [functionConst] stone_soup-0.34.1/source/cio.h:380:12: note: Technically the member function 'line_reader::get_prompt' can be const. stone_soup-0.34.1/source/cio.cc:516:21: note: Technically the member function 'line_reader::get_prompt' can be const. stone_soup-0.34.1/source/cio.cc:792:19: style: The member function 'line_reader::is_wordchar' can be static. [functionStatic] stone_soup-0.34.1/source/cio.h:402:10: note: The member function 'line_reader::is_wordchar' can be static. stone_soup-0.34.1/source/cio.cc:792:19: note: The member function 'line_reader::is_wordchar' can be static. stone_soup-0.34.1/source/coord.cc:85:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/cio.h:380:12: performance: Function 'get_prompt()' should return member 'prompt' by const reference. [returnByReference] stone_soup-0.34.1/source/clua.cc:610:18: style: The member function 'CLua::callmbooleanfn' can be static. [functionStatic] stone_soup-0.34.1/source/clua.h:131:16: note: The member function 'CLua::callmbooleanfn' can be static. stone_soup-0.34.1/source/clua.cc:610:18: note: The member function 'CLua::callmbooleanfn' can be static. stone_soup-0.34.1/source/clua.cc:638:18: style: The member function 'CLua::callmaybefn' can be static. [functionStatic] stone_soup-0.34.1/source/clua.h:132:16: note: The member function 'CLua::callmaybefn' can be static. stone_soup-0.34.1/source/clua.cc:638:18: note: The member function 'CLua::callmaybefn' can be static. stone_soup-0.34.1/source/clua.cc:656:12: style: The member function 'CLua::proc_returns' can be static. [functionStatic] stone_soup-0.34.1/source/clua.h:190:10: note: The member function 'CLua::proc_returns' can be static. stone_soup-0.34.1/source/clua.cc:656:12: note: The member function 'CLua::proc_returns' can be static. stone_soup-0.34.1/source/clua.cc:1025:24: style: The member function 'lua_text_pattern::pre_pattern' can be static. [functionStatic] stone_soup-0.34.1/source/clua.h:234:10: note: The member function 'lua_text_pattern::pre_pattern' can be static. stone_soup-0.34.1/source/clua.cc:1025:24: note: The member function 'lua_text_pattern::pre_pattern' can be static. stone_soup-0.34.1/source/clua.cc:1037:24: style: The member function 'lua_text_pattern::post_pattern' can be static. [functionStatic] stone_soup-0.34.1/source/clua.h:235:10: note: The member function 'lua_text_pattern::post_pattern' can be static. stone_soup-0.34.1/source/clua.cc:1037:24: note: The member function 'lua_text_pattern::post_pattern' can be static. stone_soup-0.34.1/source/misc.h:32:5: style: Struct 'counted_monster_list' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/cio.cc:700:15: style: Checking if unsigned expression 'bufsz' is less than zero. [unsignedLessThanZero] stone_soup-0.34.1/source/clua.cc:167:22: style: Condition 'persist.empty()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/clua.cc:160:16: note: Assuming condition is false stone_soup-0.34.1/source/clua.cc:167:22: note: Condition 'persist.empty()' is always true stone_soup-0.34.1/source/cio.cc:236:37: style:inconclusive: Function 'nowrap_eol_cprintf' argument 1 names different: declaration 'format' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/cio.h:57:25: note: Function 'nowrap_eol_cprintf' argument 1 names different: declaration 'format' definition 's'. stone_soup-0.34.1/source/cio.cc:236:37: note: Function 'nowrap_eol_cprintf' argument 1 names different: declaration 'format' definition 's'. stone_soup-0.34.1/source/cio.cc:352:74: style:inconclusive: Function 'cancellable_get_line' argument 5 names different: declaration '' definition 'fill'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/cio.cc:353:39: style:inconclusive: Function 'cancellable_get_line' argument 6 names different: declaration '' definition 'tag'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/cio.cc:469:32: style:inconclusive: Function 'line_reader' argument 1 names different: declaration 'buffer' definition 'buf'. [funcArgNamesDifferent] stone_soup-0.34.1/source/cio.h:359:23: note: Function 'line_reader' argument 1 names different: declaration 'buffer' definition 'buf'. stone_soup-0.34.1/source/cio.cc:469:32: note: Function 'line_reader' argument 1 names different: declaration 'buffer' definition 'buf'. stone_soup-0.34.1/source/cio.cc:469:44: style:inconclusive: Function 'line_reader' argument 2 names different: declaration 'bufsz' definition 'sz'. [funcArgNamesDifferent] stone_soup-0.34.1/source/cio.h:359:38: note: Function 'line_reader' argument 2 names different: declaration 'bufsz' definition 'sz'. stone_soup-0.34.1/source/cio.cc:469:44: note: Function 'line_reader' argument 2 names different: declaration 'bufsz' definition 'sz'. stone_soup-0.34.1/source/cio.cc:469:52: style:inconclusive: Function 'line_reader' argument 3 names different: declaration 'wrap_col' definition 'wrap'. [funcArgNamesDifferent] stone_soup-0.34.1/source/cio.h:360:21: note: Function 'line_reader' argument 3 names different: declaration 'wrap_col' definition 'wrap'. stone_soup-0.34.1/source/cio.cc:469:52: note: Function 'line_reader' argument 3 names different: declaration 'wrap_col' definition 'wrap'. stone_soup-0.34.1/source/cio.cc:487:35: style:inconclusive: Function 'set_text' argument 1 names different: declaration 's' definition 'text'. [funcArgNamesDifferent] stone_soup-0.34.1/source/cio.h:369:26: note: Function 'set_text' argument 1 names different: declaration 's' definition 'text'. stone_soup-0.34.1/source/cio.cc:487:35: note: Function 'set_text' argument 1 names different: declaration 's' definition 'text'. stone_soup-0.34.1/source/cio.cc:495:52: style:inconclusive: Function 'set_input_history' argument 1 names different: declaration 'ih' definition 'i'. [funcArgNamesDifferent] stone_soup-0.34.1/source/cio.h:371:43: note: Function 'set_input_history' argument 1 names different: declaration 'ih' definition 'i'. stone_soup-0.34.1/source/cio.cc:495:52: note: Function 'set_input_history' argument 1 names different: declaration 'ih' definition 'i'. stone_soup-0.34.1/source/cio.cc:543:32: style:inconclusive: Function 'cursorto' argument 1 names different: declaration 'newcpos' definition 'ncx'. [funcArgNamesDifferent] stone_soup-0.34.1/source/cio.h:393:31: note: Function 'cursorto' argument 1 names different: declaration 'newcpos' definition 'ncx'. stone_soup-0.34.1/source/cio.cc:543:32: note: Function 'cursorto' argument 1 names different: declaration 'newcpos' definition 'ncx'. stone_soup-0.34.1/source/cio.cc:487:35: performance: Function parameter 'text' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/cio.cc:521:37: performance: Function parameter 'p' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/cio.cc:429:40: style: Parameter 'ch' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/clua.cc:1361:19: style: Variable 'error.message' is reassigned a value before the old one has been used. [redundantAssignment] stone_soup-0.34.1/source/clua.cc:1357:23: note: error.message is assigned stone_soup-0.34.1/source/clua.cc:1361:19: note: error.message is overwritten stone_soup-0.34.1/source/clua.cc:495:13: style: Statements following noreturn function 'die()' will never be executed. [unreachableCode] stone_soup-0.34.1/source/cio.cc:776:11: style: Variable 'c' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/clua.cc:127:36: style:inconclusive: Function '_getregistry' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/clua.cc:282:34: style:inconclusive: Function 'loadstring' argument 1 names different: declaration 'str' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:120:32: note: Function 'loadstring' argument 1 names different: declaration 'str' definition 's'. stone_soup-0.34.1/source/clua.cc:282:34: note: Function 'loadstring' argument 1 names different: declaration 'str' definition 's'. stone_soup-0.34.1/source/clua.cc:287:34: style:inconclusive: Function 'execstring' argument 1 names different: declaration 'str' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:121:32: note: Function 'execstring' argument 1 names different: declaration 'str' definition 's'. stone_soup-0.34.1/source/clua.cc:287:34: note: Function 'execstring' argument 1 names different: declaration 'str' definition 's'. stone_soup-0.34.1/source/clua.cc:298:32: style:inconclusive: Function 'is_path_safe' argument 1 names different: declaration 'file' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:148:37: note: Function 'is_path_safe' argument 1 names different: declaration 'file' definition 's'. stone_soup-0.34.1/source/clua.cc:298:32: note: Function 'is_path_safe' argument 1 names different: declaration 'file' definition 's'. stone_soup-0.34.1/source/clua.cc:306:47: style:inconclusive: Function 'loadfile' argument 2 names different: declaration 'file' definition 'filename'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:146:52: note: Function 'loadfile' argument 2 names different: declaration 'file' definition 'filename'. stone_soup-0.34.1/source/clua.cc:306:47: note: Function 'loadfile' argument 2 names different: declaration 'file' definition 'filename'. stone_soup-0.34.1/source/clua.cc:394:34: style:inconclusive: Function 'fnreturns' argument 1 names different: declaration 'params' definition 'format'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:136:32: note: Function 'fnreturns' argument 1 names different: declaration 'params' definition 'format'. stone_soup-0.34.1/source/clua.cc:394:34: note: Function 'fnreturns' argument 1 names different: declaration 'params' definition 'format'. stone_soup-0.34.1/source/clua.cc:405:35: style:inconclusive: Function 'vfnreturns' argument 1 names different: declaration 'par' definition 'format'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:188:33: note: Function 'vfnreturns' argument 1 names different: declaration 'par' definition 'format'. stone_soup-0.34.1/source/clua.cc:405:35: note: Function 'vfnreturns' argument 1 names different: declaration 'par' definition 'format'. stone_soup-0.34.1/source/clua.cc:405:51: style:inconclusive: Function 'vfnreturns' argument 2 names different: declaration 'va' definition 'args'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:188:46: note: Function 'vfnreturns' argument 2 names different: declaration 'va' definition 'args'. stone_soup-0.34.1/source/clua.cc:405:51: note: Function 'vfnreturns' argument 2 names different: declaration 'va' definition 'args'. stone_soup-0.34.1/source/clua.cc:452:64: style:inconclusive: Function 'push_args' argument 3 names different: declaration 'cpto' definition 'targ'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:199:62: note: Function 'push_args' argument 3 names different: declaration 'cpto' definition 'targ'. stone_soup-0.34.1/source/clua.cc:452:64: note: Function 'push_args' argument 3 names different: declaration 'cpto' definition 'targ'. stone_soup-0.34.1/source/clua.cc:578:34: style:inconclusive: Function 'calltopfn' argument 1 names different: declaration 'format' definition 'params'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:192:32: note: Function 'calltopfn' argument 1 names different: declaration 'format' definition 'params'. stone_soup-0.34.1/source/clua.cc:578:34: note: Function 'calltopfn' argument 1 names different: declaration 'format' definition 'params'. stone_soup-0.34.1/source/clua.cc:579:31: style:inconclusive: Function 'calltopfn' argument 4 names different: declaration 'fnr' definition 'copyto'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:193:29: note: Function 'calltopfn' argument 4 names different: declaration 'fnr' definition 'copyto'. stone_soup-0.34.1/source/clua.cc:579:31: note: Function 'calltopfn' argument 4 names different: declaration 'fnr' definition 'copyto'. stone_soup-0.34.1/source/clua.cc:647:31: style:inconclusive: Function 'callbooleanfn' argument 1 names different: declaration 'defval' definition 'def'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:133:29: note: Function 'callbooleanfn' argument 1 names different: declaration 'defval' definition 'def'. stone_soup-0.34.1/source/clua.cc:647:31: note: Function 'callbooleanfn' argument 1 names different: declaration 'defval' definition 'def'. stone_soup-0.34.1/source/clua.cc:894:31: style:inconclusive: Function 'get_vm' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/clua.cc:912:57: style:inconclusive: Function 'add_shutdown_listener' argument 1 names different: declaration '' definition 'listener'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/clua.cc:921:60: style:inconclusive: Function 'remove_shutdown_listener' argument 1 names different: declaration '' definition 'listener'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/clua.cc:979:50: style:inconclusive: Function 'lua_text_pattern' argument 1 names different: declaration 'pattern' definition '_pattern'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:215:36: note: Function 'lua_text_pattern' argument 1 names different: declaration 'pattern' definition '_pattern'. stone_soup-0.34.1/source/clua.cc:979:50: note: Function 'lua_text_pattern' argument 1 names different: declaration 'pattern' definition '_pattern'. stone_soup-0.34.1/source/clua.cc:1130:35: style:inconclusive: Function '_clua_panic' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/clua.cc:1165:44: style:inconclusive: Function '_clua_throttle_hook' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/clua.cc:1165:59: style:inconclusive: Function '_clua_throttle_hook' argument 2 names different: declaration '' definition 'dbg'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/clua.cc:1200:44: style:inconclusive: Function 'lua_call_throttle' argument 1 names different: declaration 'handle' definition '_lua'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:35:29: note: Function 'lua_call_throttle' argument 1 names different: declaration 'handle' definition '_lua'. stone_soup-0.34.1/source/clua.cc:1200:44: note: Function 'lua_call_throttle' argument 1 names different: declaration 'handle' definition '_lua'. stone_soup-0.34.1/source/clua.cc:1237:43: style:inconclusive: Function '_clua_guarded_pcall' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/clua.cc:1269:38: style:inconclusive: Function '_clua_loadfile' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/clua.cc:1293:37: style:inconclusive: Function '_clua_require' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/clua.cc:1314:36: style:inconclusive: Function '_clua_dofile' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/clua.cc:1384:28: style:inconclusive: Function 'lua_datum' argument 1 names different: declaration 'lua' definition '_lua'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:60:21: note: Function 'lua_datum' argument 1 names different: declaration 'lua' definition '_lua'. stone_soup-0.34.1/source/clua.cc:1384:28: note: Function 'lua_datum' argument 1 names different: declaration 'lua' definition '_lua'. stone_soup-0.34.1/source/clua.cc:1400:39: style:inconclusive: Function 'lua_datum' argument 1 names different: declaration 'other' definition 'o'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:61:32: note: Function 'lua_datum' argument 1 names different: declaration 'other' definition 'o'. stone_soup-0.34.1/source/clua.cc:1400:39: note: Function 'lua_datum' argument 1 names different: declaration 'other' definition 'o'. stone_soup-0.34.1/source/clua.cc:1415:58: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'other' definition 'o'. [funcArgNamesDifferent] stone_soup-0.34.1/source/clua.h:63:51: note: Function 'operator=' argument 1 names different: declaration 'other' definition 'o'. stone_soup-0.34.1/source/clua.cc:1415:58: note: Function 'operator=' argument 1 names different: declaration 'other' definition 'o'. stone_soup-0.34.1/source/clua.h:65:25: style:inconclusive: Function 'shutdown' argument 1 names different: declaration 'lua' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/clua.cc:333:15: error: Out of bounds access in expression 'script[0]' because 'script' is empty. [containerOutOfBounds] stone_soup-0.34.1/source/clua.cc:330:12: note: Assuming condition is false stone_soup-0.34.1/source/clua.cc:333:15: note: Access out of bounds stone_soup-0.34.1/source/cio.cc:273:20: style: Variable 'linebreak' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/clua.cc:719:45: error: va_list 'fnret' used before va_start() was called. [va_list_usedBeforeStarted] stone_soup-0.34.1/source/clua.cc:724:32: error: va_list 'fnret' used before va_start() was called. [va_list_usedBeforeStarted] stone_soup-0.34.1/source/clua.cc:727:5: error: va_list 'fnret' used before va_start() was called. [va_list_usedBeforeStarted] stone_soup-0.34.1/source/coord.cc:74:40: style:inconclusive: Function 'grid2player' argument 1 names different: declaration 'pc' definition 'gc'. [funcArgNamesDifferent] stone_soup-0.34.1/source/coord.h:65:40: note: Function 'grid2player' argument 1 names different: declaration 'pc' definition 'gc'. stone_soup-0.34.1/source/coord.cc:74:40: note: Function 'grid2player' argument 1 names different: declaration 'pc' definition 'gc'. stone_soup-0.34.1/source/colour.cc:34:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable rand_max [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/colour.cc:79:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable second [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < std :: unique_ptr < base_colour_calc > , NUM_COLOURS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < std :: unique_ptr < base_colour_calc > , NUM_COLOURS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < std :: unique_ptr < base_colour_calc > , NUM_COLOURS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/colour.h:107:21: style:inconclusive: Function 'get_nth' argument 1 names different: declaration 'n' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/colour.cc:308:36: style:inconclusive: Function 'dam_colour' argument 1 names different: declaration '' definition 'mi'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/colour.cc:30:59: performance: Function parameter '_name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/colour.cc:31:57: performance: Function parameter '_rand_vals' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/colour.cc:834:29: performance: Function parameter 'base' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/colour.cc:72:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/command.cc:174:76: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/threads.h:24:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PTHREAD_MUTEX_RECURSIVE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/crash.cc:126:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/crash.cc:324:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/crash.cc:413:68: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/crash.cc:463:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ITIMER_VIRTUAL [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/database.cc:200:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_RDONLY [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/database.cc:315:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_RDWR [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/database.cc:390:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/database.cc:420:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/database.cc:440:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/database.cc:475:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/database.cc:698:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/command.cc:0:0: debug: ValueFlow maximum iterations exceeded [valueFlowMaxIterations] stone_soup-0.34.1/source/crash.cc:431:36: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/crash.cc:436:9: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] stone_soup-0.34.1/source/fixedvector.h:40:5: warning:inconclusive: Member variable 'FixedVector < bool , HINT_EVENTS_NUM >::mData' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/database.cc:58:17: style:inconclusive: Technically the member function 'TextDB::lang' can be const. [functionConst] stone_soup-0.34.1/source/database.cc:37:40: warning: Class 'TextDB' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] stone_soup-0.34.1/source/database.cc:37:40: warning: Class 'TextDB' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] stone_soup-0.34.1/source/database.cc:36:5: style: Class 'TextDB' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/database.cc:365:18: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/database.cc:387:20: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/database.cc:414:20: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/database.cc:417:21: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/database.cc:502:16: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/database.cc:505:18: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/database.cc:659:25: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/database.cc:759:16: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/database.cc:321:14: style: The scope of the variable 'buf' can be reduced. [variableScope] stone_soup-0.34.1/source/database.cc:639:22: style: Checking if unsigned expression 'result.dsize' is less than zero. [unsignedLessThanZero] stone_soup-0.34.1/source/database.cc:642:22: style: Checking if unsigned expression 'result.dsize' is less than zero. [unsignedLessThanZero] stone_soup-0.34.1/source/database.cc:651:26: style: Checking if unsigned expression 'result.dsize' is less than zero. [unsignedLessThanZero] stone_soup-0.34.1/source/database.cc:654:26: style: Checking if unsigned expression 'result.dsize' is less than zero. [unsignedLessThanZero] stone_soup-0.34.1/source/database.cc:753:22: style: Checking if unsigned expression 'result.dsize' is less than zero. [unsignedLessThanZero] stone_soup-0.34.1/source/database.cc:756:22: style: Checking if unsigned expression 'result.dsize' is less than zero. [unsignedLessThanZero] stone_soup-0.34.1/source/database.cc:442:27: style: Local variable 'end' shadows outer function [shadowFunction] stone_soup-0.34.1/source/end.h:14:15: note: Shadowed declaration stone_soup-0.34.1/source/database.cc:442:27: note: Shadow variable stone_soup-0.34.1/source/database.cc:477:27: style: Local variable 'end' shadows outer function [shadowFunction] stone_soup-0.34.1/source/end.h:14:15: note: Shadowed declaration stone_soup-0.34.1/source/database.cc:477:27: note: Shadow variable stone_soup-0.34.1/source/database.cc:707:27: style: Local variable 'end' shadows outer function [shadowFunction] stone_soup-0.34.1/source/end.h:14:15: note: Shadowed declaration stone_soup-0.34.1/source/database.cc:707:27: note: Shadow variable stone_soup-0.34.1/source/scroller.h:34:9: style:inconclusive: Technically the member function 'formatted_scroller::get_lastch' can be const. [functionConst] stone_soup-0.34.1/source/scroller.h:47:29: style:inconclusive: Technically the member function 'formatted_scroller::get_contents' can be const. [functionConst] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < bool , HINT_EVENTS_NUM >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < bool , HINT_EVENTS_NUM >::size' can be static. [functionStatic] stone_soup-0.34.1/source/scroller.h:30:18: style: Virtual function 'add_text' is called from constructor 'formatted_scroller(int flags,const std::string&text="")' at line 25. Dynamic binding is not used. [virtualCallInConstructor] stone_soup-0.34.1/source/scroller.h:25:9: note: Calling add_text stone_soup-0.34.1/source/scroller.h:30:18: note: add_text is a virtual function stone_soup-0.34.1/source/scroller.h:30:18: style: Virtual function 'add_text' is called from constructor 'formatted_scroller(const std::string&text="")' at line 27. Dynamic binding is not used. [virtualCallInConstructor] stone_soup-0.34.1/source/scroller.h:27:51: note: Calling formatted_scroller stone_soup-0.34.1/source/scroller.h:25:9: note: Calling add_text stone_soup-0.34.1/source/scroller.h:30:18: note: add_text is a virtual function stone_soup-0.34.1/source/command.cc:1397:16: style: Virtual function 'process_key' is called from constructor 'help_popup(int key)' at line 1394. Dynamic binding is not used. [virtualCallInConstructor] stone_soup-0.34.1/source/command.cc:1394:9: note: Calling process_key stone_soup-0.34.1/source/command.cc:1397:16: note: process_key is a virtual function stone_soup-0.34.1/source/scroller.h:21:5: style: Class 'formatted_scroller' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/scroller.h:27:5: style: Class 'formatted_scroller' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/command.cc:1392:5: style: Class 'help_popup' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < bool , HINT_EVENTS_NUM >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/command.cc:713:9: style: Condition '!suppress_unix_stuff' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/command.cc:709:9: note: Assignment 'suppress_unix_stuff=webtiles_client', assigned value is 0 stone_soup-0.34.1/source/command.cc:713:9: note: Condition '!suppress_unix_stuff' is always true stone_soup-0.34.1/source/command.cc:725:9: style: Condition '!suppress_unix_stuff' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/command.cc:709:9: note: Assignment 'suppress_unix_stuff=webtiles_client', assigned value is 0 stone_soup-0.34.1/source/command.cc:725:9: note: Condition '!suppress_unix_stuff' is always true stone_soup-0.34.1/source/command.cc:765:14: style: Condition '!suppress_unix_stuff' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/command.cc:709:9: note: Assignment 'suppress_unix_stuff=webtiles_client', assigned value is 0 stone_soup-0.34.1/source/command.cc:765:14: note: Condition '!suppress_unix_stuff' is always true stone_soup-0.34.1/source/command.cc:489:28: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/command.cc:521:47: performance: Function parameter 'keys' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/command.cc:1472:36: performance: Function parameter 'highlight_string' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/command.cc:354:67: performance: Concatenating the result of c_str() and a std::string is slow and redundant. [stlcstrConcat] stone_soup-0.34.1/source/command.cc:627:10: performance: Passing the result of c_str() to a function that takes std::string as argument no. 2 is slow and redundant. [stlcstrParam] stone_soup-0.34.1/source/command.cc:649:10: performance: Passing the result of c_str() to a function that takes std::string as argument no. 2 is slow and redundant. [stlcstrParam] stone_soup-0.34.1/source/command.cc:532:29: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/command.cc:600:29: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/command.cc:605:29: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/command.cc:438:10: style: struct member 'help_file::auto_hotkey' is never used. [unusedStructMember] stone_soup-0.34.1/source/command.cc:274:12: style: Unused variable: jstr [unusedVariable] stone_soup-0.34.1/source/death-curse.cc:173:17: debug: Scope::checkVariable found variable 'dmg' with varid 0. [varid0] stone_soup-0.34.1/source/death-curse.cc:174:20: debug: Scope::checkVariable found variable 'punct' with varid 0. [varid0] stone_soup-0.34.1/source/death-curse.cc:172:34: debug: Function::addArguments found argument 'source' with varid 0. [varid0] stone_soup-0.34.1/source/death-curse.cc:172:49: debug: Function::addArguments found argument 'cause' with varid 0. [varid0] stone_soup-0.34.1/source/death-curse.cc:172:60: debug: Function::addArguments found argument 'severity' with varid 0. [varid0] stone_soup-0.34.1/source/death-curse.cc:184:68: debug: Function::addArguments found argument 'severity' with varid 0. [varid0] stone_soup-0.34.1/source/death-curse.cc:194:34: debug: Function::addArguments found argument 'source' with varid 0. [varid0] stone_soup-0.34.1/source/death-curse.cc:194:64: debug: Function::addArguments found argument 'severity' with varid 0. [varid0] stone_soup-0.34.1/source/death-curse.cc:205:34: debug: Function::addArguments found argument 'source' with varid 0. [varid0] stone_soup-0.34.1/source/death-curse.cc:205:64: debug: Function::addArguments found argument 'severity' with varid 0. [varid0] stone_soup-0.34.1/source/death-curse.cc:216:34: debug: Function::addArguments found argument 'source' with varid 0. [varid0] stone_soup-0.34.1/source/death-curse.cc:42:43: performance: Function parameter 'player_msg' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/death-curse.cc:42:62: performance: Function parameter 'mon_seen_msg' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/death-curse.cc:43:28: performance: Function parameter 'mon_unseen_msg' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/death-curse.cc:61:32: performance: Function parameter 'cause' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/death-curse.cc:105:35: style: Parameter 'target' can be declared as reference to const. However it seems that '_curse_message' is a callback function, if 'target' is declared with const you might also need to cast function pointer(s). [constParameterCallback] stone_soup-0.34.1/source/death-curse.cc:167:9: note: You might need to cast the function pointer here stone_soup-0.34.1/source/death-curse.cc:105:35: note: Parameter 'target' can be declared as reference to const stone_soup-0.34.1/source/death-curse.cc:126:18: performance: Assigning the result of c_str() to a std::string is slow and redundant. [stlcstrAssignment] stone_soup-0.34.1/source/death-curse.cc:98:12: style: struct member 'curse_effect::name' is never used. [unusedStructMember] stone_soup-0.34.1/source/dbg-util.cc:54:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable name [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/dbg-util.cc:200:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/dbg-util.cc:209:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/dbg-util.cc:447:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/dgn-event.cc:83:28: style:inconclusive: Technically the member function 'dgn_event_dispatcher::fire_event' can be const. [functionConst] stone_soup-0.34.1/source/dgn-event.h:119:10: note: Technically the member function 'dgn_event_dispatcher::fire_event' can be const. stone_soup-0.34.1/source/dgn-event.cc:83:28: note: Technically the member function 'dgn_event_dispatcher::fire_event' can be const. stone_soup-0.34.1/source/describe-god.cc:290:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable left [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/describe-spells.h:28:5: style: Struct 'spellbook_contents' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/dgn-event.cc:51:22: style:inconclusive: Function 'fire_vetoable_position_event' argument 1 names different: declaration 'e' definition 'et'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dgn-event.h:110:56: note: Function 'fire_vetoable_position_event' argument 1 names different: declaration 'e' definition 'et'. stone_soup-0.34.1/source/dgn-event.cc:51:22: note: Function 'fire_vetoable_position_event' argument 1 names different: declaration 'e' definition 'et'. stone_soup-0.34.1/source/dgn-event.cc:65:20: style:inconclusive: Function 'fire_position_event' argument 1 names different: declaration 'et' definition 'event'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dgn-event.h:116:45: note: Function 'fire_position_event' argument 1 names different: declaration 'et' definition 'event'. stone_soup-0.34.1/source/dgn-event.cc:65:20: note: Function 'fire_position_event' argument 1 names different: declaration 'et' definition 'event'. stone_soup-0.34.1/source/dgn-event.cc:72:22: style:inconclusive: Function 'fire_position_event' argument 1 names different: declaration 'e' definition 'et'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dgn-event.h:117:47: note: Function 'fire_position_event' argument 1 names different: declaration 'e' definition 'et'. stone_soup-0.34.1/source/dgn-event.cc:72:22: note: Function 'fire_position_event' argument 1 names different: declaration 'e' definition 'et'. stone_soup-0.34.1/source/dgn-event.cc:104:55: style:inconclusive: Function 'register_listener' argument 1 names different: declaration 'evmask' definition 'mask'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dgn-event.h:121:37: note: Function 'register_listener' argument 1 names different: declaration 'evmask' definition 'mask'. stone_soup-0.34.1/source/dgn-event.cc:104:55: note: Function 'register_listener' argument 1 names different: declaration 'evmask' definition 'mask'. stone_soup-0.34.1/source/dgn-event.cc:105:66: style:inconclusive: Function 'register_listener' argument 2 names different: declaration '' definition 'listener'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/dgn-event.cc:126:66: style:inconclusive: Function 'register_listener_at' argument 2 names different: declaration 'pos' definition 'c'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dgn-event.h:126:63: note: Function 'register_listener_at' argument 2 names different: declaration 'pos' definition 'c'. stone_soup-0.34.1/source/dgn-event.cc:126:66: note: Function 'register_listener_at' argument 2 names different: declaration 'pos' definition 'c'. stone_soup-0.34.1/source/dgn-event.cc:127:69: style:inconclusive: Function 'register_listener_at' argument 3 names different: declaration 'l' definition 'listener'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dgn-event.h:127:51: note: Function 'register_listener_at' argument 3 names different: declaration 'l' definition 'listener'. stone_soup-0.34.1/source/dgn-event.cc:127:69: note: Function 'register_listener_at' argument 3 names different: declaration 'l' definition 'listener'. stone_soup-0.34.1/source/dgn-event.cc:141:64: style:inconclusive: Function 'remove_listener' argument 1 names different: declaration '' definition 'listener'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/dgn-event.cc:160:67: style:inconclusive: Function 'remove_listener_at' argument 2 names different: declaration 'l' definition 'listener'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dgn-event.h:128:71: note: Function 'remove_listener_at' argument 2 names different: declaration 'l' definition 'listener'. stone_soup-0.34.1/source/dgn-event.cc:160:67: note: Function 'remove_listener_at' argument 2 names different: declaration 'l' definition 'listener'. stone_soup-0.34.1/source/dgn-event.cc:74:23: style: Variable 'alarm' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/dgn-event.cc:58:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/dgn-event.cc:116:13: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/dgn-event.cc:151:13: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/dgn-event.cc:171:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/directn.h:25:5: style: Class 'range_view_annotator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/directn.h:32:5: style: Class 'monster_view_annotator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/directn.h:40:5: style: Class 'targeting_behaviour' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/directn.h:116:5: style: Class 'direction_chooser_renderer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/directn.h:117:10: style: The function 'render' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/view.h:73:18: note: Virtual function in base class stone_soup-0.34.1/source/directn.h:117:10: note: Function in derived class stone_soup-0.34.1/source/describe-spells.cc:744:15: performance: Range variable 'book' should be declared as const reference. [iterateByValue] stone_soup-0.34.1/source/describe-spells.cc:262:16: style: Variable 'book' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/describe-spells.cc:268:16: style: Variable 'book' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/describe-spells.cc:357:13: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/describe-spells.cc:843:21: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/dbg-util.cc:76:21: style: The scope of the variable 'props' can be reduced. [variableScope] stone_soup-0.34.1/source/dbg-util.cc:479:74: performance: Function parameter 'name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/dbg-util.cc:46:16: style: Variable 'vault' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/dbg-util.cc:117:20: style: Variable 'vname' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/dbg-util.cc:171:25: style: Variable 'mons' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/dgn-irregular-box.cc:421:0: debug: Function::addArguments found argument 'map' with varid 0. [varid0] stone_soup-0.34.1/source/dgn-irregular-box.cc:19:0: debug: Function::addArguments found argument 'map' with varid 0. [varid0] stone_soup-0.34.1/source/dgn-irregular-box.cc:171:0: debug: Function::addArguments found argument 'map' with varid 0. [varid0] stone_soup-0.34.1/source/dgn-irregular-box.cc:206:0: debug: Function::addArguments found argument 'map' with varid 0. [varid0] stone_soup-0.34.1/source/dgn-irregular-box.cc:242:0: debug: Function::addArguments found argument 'map' with varid 0. [varid0] stone_soup-0.34.1/source/dgn-irregular-box.cc:277:0: debug: Function::addArguments found argument 'map' with varid 0. [varid0] stone_soup-0.34.1/source/dgn-irregular-box.cc:317:0: debug: Function::addArguments found argument 'map' with varid 0. [varid0] stone_soup-0.34.1/source/dgn-irregular-box.cc:376:0: debug: Function::addArguments found argument 'map' with varid 0. [varid0] stone_soup-0.34.1/source/describe-god.cc:481:72: error: Invalid bind() argument nr 3. A non-boolean value is required. [invalidFunctionArgBool] stone_soup-0.34.1/source/describe-god.cc:490:72: error: Invalid bind() argument nr 3. A non-boolean value is required. [invalidFunctionArgBool] stone_soup-0.34.1/source/describe-god.cc:493:72: error: Invalid bind() argument nr 3. A non-boolean value is required. [invalidFunctionArgBool] stone_soup-0.34.1/source/mon-transit.h:20:5: warning: Member variable 'follower::transit_start_time' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/god-companions.h:24:5: warning: Member variable 'companion::timestamp' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/domino.cc:58:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable uint32_t [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/domino.cc:120:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/domino.cc:160:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/domino.h:206:9: warning: Member variable 'CornerDomino::colours_' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/domino.h:215:9: warning: Member variable 'Domino::id_' is not initialized in the constructor. Maybe it should be initialized directly in the class Domino? [uninitDerivedMemberVar] stone_soup-0.34.1/source/domino.h:219:9: warning: Member variable 'Domino::id_' is not initialized in the constructor. Maybe it should be initialized directly in the class Domino? [uninitDerivedMemberVar] stone_soup-0.34.1/source/domino.h:253:9: warning: Member variable 'EdgeDomino::colours_' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/domino.h:257:9: warning: Member variable 'Domino::id_' is not initialized in the constructor. Maybe it should be initialized directly in the class Domino? [uninitDerivedMemberVar] stone_soup-0.34.1/source/domino.h:260:9: warning: Member variable 'Domino::id_' is not initialized in the constructor. Maybe it should be initialized directly in the class Domino? [uninitDerivedMemberVar] stone_soup-0.34.1/source/domino.h:298:9: warning: Member variable 'OrientedDomino::colours_' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/domino.h:303:9: warning: Member variable 'Domino::id_' is not initialized in the constructor. Maybe it should be initialized directly in the class Domino? [uninitDerivedMemberVar] stone_soup-0.34.1/source/domino.h:307:9: warning: Member variable 'Domino::id_' is not initialized in the constructor. Maybe it should be initialized directly in the class Domino? [uninitDerivedMemberVar] stone_soup-0.34.1/source/domino.h:312:9: warning: Member variable 'Domino::id_' is not initialized in the constructor. Maybe it should be initialized directly in the class Domino? [uninitDerivedMemberVar] stone_soup-0.34.1/source/domino.h:195:18: style:inconclusive: Technically the member function 'domino::Domino::id' can be const. [functionConst] stone_soup-0.34.1/source/domino.h:406:18: style:inconclusive: Technically the member function 'domino::DominoSet::size' can be const. [functionConst] stone_soup-0.34.1/source/domino.h:215:9: style: Class 'CornerDomino' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/domino.h:257:9: style: Class 'EdgeDomino' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/domino.h:303:9: style: Class 'OrientedDomino' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/domino.cc:105:50: style:inconclusive: Function 'intersect' argument 1 names different: declaration 'other' definition 'o'. [funcArgNamesDifferent] stone_soup-0.34.1/source/domino.h:213:44: note: Function 'intersect' argument 1 names different: declaration 'other' definition 'o'. stone_soup-0.34.1/source/domino.cc:105:50: note: Function 'intersect' argument 1 names different: declaration 'other' definition 'o'. stone_soup-0.34.1/source/domino.cc:105:69: style:inconclusive: Function 'intersect' argument 2 names different: declaration 'directions' definition 'result'. [funcArgNamesDifferent] stone_soup-0.34.1/source/domino.h:213:72: note: Function 'intersect' argument 2 names different: declaration 'directions' definition 'result'. stone_soup-0.34.1/source/domino.cc:105:69: note: Function 'intersect' argument 2 names different: declaration 'directions' definition 'result'. stone_soup-0.34.1/source/domino.cc:117:69: style:inconclusive: Function 'operator<<' argument 2 names different: declaration 'dir' definition 'd'. [funcArgNamesDifferent] stone_soup-0.34.1/source/domino.h:248:69: note: Function 'operator<<' argument 2 names different: declaration 'dir' definition 'd'. stone_soup-0.34.1/source/domino.cc:117:69: note: Function 'operator<<' argument 2 names different: declaration 'dir' definition 'd'. stone_soup-0.34.1/source/domino.cc:145:46: style:inconclusive: Function 'intersect' argument 1 names different: declaration 'other' definition 'o'. [funcArgNamesDifferent] stone_soup-0.34.1/source/domino.h:266:42: note: Function 'intersect' argument 1 names different: declaration 'other' definition 'o'. stone_soup-0.34.1/source/domino.cc:145:46: note: Function 'intersect' argument 1 names different: declaration 'other' definition 'o'. stone_soup-0.34.1/source/domino.cc:145:65: style:inconclusive: Function 'intersect' argument 2 names different: declaration 'directions' definition 'result'. [funcArgNamesDifferent] stone_soup-0.34.1/source/domino.h:266:70: note: Function 'intersect' argument 2 names different: declaration 'directions' definition 'result'. stone_soup-0.34.1/source/domino.cc:145:65: note: Function 'intersect' argument 2 names different: declaration 'directions' definition 'result'. stone_soup-0.34.1/source/domino.cc:157:67: style:inconclusive: Function 'operator<<' argument 2 names different: declaration 'dir' definition 'd'. [funcArgNamesDifferent] stone_soup-0.34.1/source/domino.h:293:67: note: Function 'operator<<' argument 2 names different: declaration 'dir' definition 'd'. stone_soup-0.34.1/source/domino.cc:157:67: note: Function 'operator<<' argument 2 names different: declaration 'dir' definition 'd'. stone_soup-0.34.1/source/domino.cc:189:54: style:inconclusive: Function 'intersect' argument 1 names different: declaration 'other' definition 'o'. [funcArgNamesDifferent] stone_soup-0.34.1/source/domino.h:346:46: note: Function 'intersect' argument 1 names different: declaration 'other' definition 'o'. stone_soup-0.34.1/source/domino.cc:189:54: note: Function 'intersect' argument 1 names different: declaration 'other' definition 'o'. stone_soup-0.34.1/source/domino.cc:189:73: style:inconclusive: Function 'intersect' argument 2 names different: declaration 'directions' definition 'result'. [funcArgNamesDifferent] stone_soup-0.34.1/source/domino.h:346:74: note: Function 'intersect' argument 2 names different: declaration 'directions' definition 'result'. stone_soup-0.34.1/source/domino.cc:189:73: note: Function 'intersect' argument 2 names different: declaration 'directions' definition 'result'. stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < item_def , NUM_MONSTER_SLOTS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < item_def , NUM_MONSTER_SLOTS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/domino.h:303:46: performance: Function parameter 'colours' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/domino.h:566:44: performance: Function parameter 'pts' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/domino.h:376:22: style: Parameter 'dominoes' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/domino.h:554:28: style: Consider using std::copy algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/mon-transit.h:21:5: style: Struct 'follower' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/god-companions.h:25:5: style: Struct 'companion' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/god-companions.h:52:5: style: Struct 'apostle_data' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/god-conduct.h:21:5: style: Struct 'god_conduct_trigger' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < item_def , NUM_MONSTER_SLOTS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/describe-god.cc:744:17: style: Redundant initialization for 'how'. The initialized value is overwritten before it is read. [redundantInitialization] stone_soup-0.34.1/source/describe-god.cc:740:25: note: how is initialized stone_soup-0.34.1/source/describe-god.cc:744:17: note: how is overwritten stone_soup-0.34.1/source/english.cc:38:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/english.cc:251:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/describe-god.cc:297:20: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/describe-god.cc:424:15: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/english.cc:30:57: style:inconclusive: Function 'pluralise' argument 2 names different: declaration 'stock_plural_quals' definition 'qualifiers'. [funcArgNamesDifferent] stone_soup-0.34.1/source/english.h:20:37: note: Function 'pluralise' argument 2 names different: declaration 'stock_plural_quals' definition 'qualifiers'. stone_soup-0.34.1/source/english.cc:30:57: note: Function 'pluralise' argument 2 names different: declaration 'stock_plural_quals' definition 'qualifiers'. stone_soup-0.34.1/source/english.cc:31:37: style:inconclusive: Function 'pluralise' argument 3 names different: declaration 'no_of' definition 'no_qualifier'. [funcArgNamesDifferent] stone_soup-0.34.1/source/english.h:22:37: note: Function 'pluralise' argument 3 names different: declaration 'no_of' definition 'no_qualifier'. stone_soup-0.34.1/source/english.cc:31:37: note: Function 'pluralise' argument 3 names different: declaration 'no_of' definition 'no_qualifier'. stone_soup-0.34.1/source/english.cc:370:33: style:inconclusive: Function 'number_in_words' argument 1 names different: declaration 'number' definition 'num'. [funcArgNamesDifferent] stone_soup-0.34.1/source/english.h:29:33: note: Function 'number_in_words' argument 1 names different: declaration 'number' definition 'num'. stone_soup-0.34.1/source/english.cc:370:33: note: Function 'number_in_words' argument 1 names different: declaration 'number' definition 'num'. stone_soup-0.34.1/source/english.cc:410:45: style:inconclusive: Function 'apply_description' argument 4 names different: declaration 'num_in_words' definition 'in_words'. [funcArgNamesDifferent] stone_soup-0.34.1/source/english.h:37:49: note: Function 'apply_description' argument 4 names different: declaration 'num_in_words' definition 'in_words'. stone_soup-0.34.1/source/english.cc:410:45: note: Function 'apply_description' argument 4 names different: declaration 'num_in_words' definition 'in_words'. stone_soup-0.34.1/source/english.cc:298:36: performance: Function parameter 'verb' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/english.cc:427:62: performance: Function parameter 'desc' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/dgn-irregular-box.cc:421:0: style:inconclusive: Function 'make_irregular_box' argument 1 names different: declaration '' definition 'map'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/dgn-irregular-box.cc:422:29: style:inconclusive: Function 'make_irregular_box' argument 6 names different: declaration 'div_x' definition 'di_x'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dgn-irregular-box.h:73:29: note: Function 'make_irregular_box' argument 6 names different: declaration 'div_x' definition 'di_x'. stone_soup-0.34.1/source/dgn-irregular-box.cc:422:29: note: Function 'make_irregular_box' argument 6 names different: declaration 'div_x' definition 'di_x'. stone_soup-0.34.1/source/dgn-irregular-box.cc:422:39: style:inconclusive: Function 'make_irregular_box' argument 7 names different: declaration 'div_y' definition 'di_y'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dgn-irregular-box.h:73:47: note: Function 'make_irregular_box' argument 7 names different: declaration 'div_y' definition 'di_y'. stone_soup-0.34.1/source/dgn-irregular-box.cc:422:39: note: Function 'make_irregular_box' argument 7 names different: declaration 'div_y' definition 'di_y'. stone_soup-0.34.1/source/errors.cc:37:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/errors.cc:64:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/errors.h:13:5: style: Struct 'ext_fail_exception' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/errors.h:14:5: style: Struct 'ext_fail_exception' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/errors.h:19:5: style: Struct 'corrupted_save' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/errors.h:20:5: style: Struct 'corrupted_save' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/errors.cc:17:32: style:inconclusive: Function 'fail' argument 1 names different: declaration 'format' definition 'msg'. [funcArgNamesDifferent] stone_soup-0.34.1/source/errors.h:6:20: note: Function 'fail' argument 1 names different: declaration 'format' definition 'msg'. stone_soup-0.34.1/source/errors.cc:17:32: note: Function 'fail' argument 1 names different: declaration 'format' definition 'msg'. stone_soup-0.34.1/source/errors.cc:29:35: style:inconclusive: Function 'sysfail' argument 1 names different: declaration 'format' definition 'msg'. [funcArgNamesDifferent] stone_soup-0.34.1/source/errors.h:7:23: note: Function 'sysfail' argument 1 names different: declaration 'format' definition 'msg'. stone_soup-0.34.1/source/errors.cc:29:35: note: Function 'sysfail' argument 1 names different: declaration 'format' definition 'msg'. stone_soup-0.34.1/source/errors.cc:42:37: style:inconclusive: Function 'corrupted' argument 1 names different: declaration 'format' definition 'msg'. [funcArgNamesDifferent] stone_soup-0.34.1/source/errors.h:8:25: note: Function 'corrupted' argument 1 names different: declaration 'format' definition 'msg'. stone_soup-0.34.1/source/errors.cc:42:37: note: Function 'corrupted' argument 1 names different: declaration 'format' definition 'msg'. stone_soup-0.34.1/source/errors.cc:59:29: performance: Function parameter 'fails' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/errors.cc:59:43: performance: Function parameter 'name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/dlua.cc:218:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/dlua.cc:259:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/dlua.cc:145:17: style:inconclusive: Technically the member function 'dlua_chunk::check_op' can be const. [functionConst] stone_soup-0.34.1/source/dlua.h:40:9: note: Technically the member function 'dlua_chunk::check_op' can be const. stone_soup-0.34.1/source/dlua.cc:145:17: note: Technically the member function 'dlua_chunk::check_op' can be const. stone_soup-0.34.1/source/format.cc:148:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/format.cc:329:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/format.cc:351:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/format.cc:363:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/format.cc:426:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/format.cc:440:66: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable text [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/format.cc:479:66: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable text [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/format.cc:499:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/format.cc:632:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/format.cc:559:24: style: The member function 'formatted_string::cprintf' can be static. [functionStatic] stone_soup-0.34.1/source/format.h:31:10: note: The member function 'formatted_string::cprintf' can be static. stone_soup-0.34.1/source/format.cc:559:24: note: The member function 'formatted_string::cprintf' can be static. stone_soup-0.34.1/source/format.cc:519:30: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/format.cc:153:14: style: Redundant initialization for 'tag'. The initialized value is overwritten before it is read. [redundantInitialization] stone_soup-0.34.1/source/format.cc:148:30: note: tag is initialized stone_soup-0.34.1/source/format.cc:153:14: note: tag is overwritten stone_soup-0.34.1/source/format.cc:341:39: style:inconclusive: Function 'tostring' argument 1 names different: declaration 'start' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/format.h:28:25: note: Function 'tostring' argument 1 names different: declaration 'start' definition 's'. stone_soup-0.34.1/source/format.cc:341:39: note: Function 'tostring' argument 1 names different: declaration 'start' definition 's'. stone_soup-0.34.1/source/format.cc:341:46: style:inconclusive: Function 'tostring' argument 2 names different: declaration 'end' definition 'e'. [funcArgNamesDifferent] stone_soup-0.34.1/source/format.h:28:40: note: Function 'tostring' argument 2 names different: declaration 'end' definition 'e'. stone_soup-0.34.1/source/format.cc:341:46: note: Function 'tostring' argument 2 names different: declaration 'end' definition 'e'. stone_soup-0.34.1/source/format.cc:408:36: style:inconclusive: Function 'display' argument 1 names different: declaration 'start' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/format.h:27:22: note: Function 'display' argument 1 names different: declaration 'start' definition 's'. stone_soup-0.34.1/source/format.cc:408:36: note: Function 'display' argument 1 names different: declaration 'start' definition 's'. stone_soup-0.34.1/source/format.cc:408:43: style:inconclusive: Function 'display' argument 2 names different: declaration 'end' definition 'e'. [funcArgNamesDifferent] stone_soup-0.34.1/source/format.h:27:37: note: Function 'display' argument 2 names different: declaration 'end' definition 'e'. stone_soup-0.34.1/source/format.cc:408:43: note: Function 'display' argument 2 names different: declaration 'end' definition 'e'. stone_soup-0.34.1/source/format.cc:559:44: style:inconclusive: Function 'cprintf' argument 1 names different: declaration 'format' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/format.h:31:18: note: Function 'cprintf' argument 1 names different: declaration 'format' definition 's'. stone_soup-0.34.1/source/format.cc:559:44: note: Function 'cprintf' argument 1 names different: declaration 'format' definition 's'. stone_soup-0.34.1/source/format.cc:479:21: style: Variable 'new_string' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/format.cc:114:17: warning:inconclusive: Access of moved variable 'lines'. [accessMoved] stone_soup-0.34.1/source/format.cc:109:36: note: Calling std::move(lines) stone_soup-0.34.1/source/format.cc:110:29: note: Assuming container is not empty stone_soup-0.34.1/source/format.cc:114:17: note: Access of moved variable 'lines'. stone_soup-0.34.1/source/format.cc:309:17: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/format.cc:426:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/format.cc:611:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/dlua.cc:53:50: style:inconclusive: Function 'precompiled' argument 1 names different: declaration 'compiled' definition '_chunk'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dlua.h:51:49: note: Function 'precompiled' argument 1 names different: declaration 'compiled' definition '_chunk'. stone_soup-0.34.1/source/dlua.cc:53:50: note: Function 'precompiled' argument 1 names different: declaration 'compiled' definition '_chunk'. stone_soup-0.34.1/source/dlua.cc:60:43: style:inconclusive: Function 'describe' argument 1 names different: declaration 'chunkname' definition 'name'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dlua.h:53:35: note: Function 'describe' argument 1 names different: declaration 'chunkname' definition 'name'. stone_soup-0.34.1/source/dlua.cc:60:43: note: Function 'describe' argument 1 names different: declaration 'chunkname' definition 'name'. stone_soup-0.34.1/source/dlua.cc:68:32: style:inconclusive: Function 'write' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/dlua.cc:91:31: style:inconclusive: Function 'read' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/dlua.cc:124:46: style:inconclusive: Function 'add' argument 2 names different: declaration 'line2' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dlua.h:55:38: note: Function 'add' argument 2 names different: declaration 'line2' definition 's'. stone_soup-0.34.1/source/dlua.cc:124:46: note: Function 'add' argument 2 names different: declaration 'line2' definition 's'. stone_soup-0.34.1/source/dlua.cc:145:32: style:inconclusive: Function 'check_op' argument 1 names different: declaration '' definition 'interp'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/dlua.cc:145:44: style:inconclusive: Function 'check_op' argument 2 names different: declaration '' definition 'err'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/dlua.cc:191:53: style:inconclusive: Function 'load_call' argument 2 names different: declaration 'function' definition 'fn'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dlua.h:60:45: note: Function 'load_call' argument 2 names different: declaration 'function' definition 'fn'. stone_soup-0.34.1/source/dlua.cc:191:53: note: Function 'load_call' argument 2 names different: declaration 'function' definition 'fn'. stone_soup-0.34.1/source/dlua.cc:213:47: style:inconclusive: Function 'rewrite_chunk_errors' argument 1 names different: declaration 'err' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dlua.h:65:39: note: Function 'rewrite_chunk_errors' argument 1 names different: declaration 'err' definition 's'. stone_soup-0.34.1/source/dlua.cc:213:47: note: Function 'rewrite_chunk_errors' argument 1 names different: declaration 'err' definition 's'. stone_soup-0.34.1/source/dlua.cc:279:51: style:inconclusive: Function 'get_chunk_prefix' argument 1 names different: declaration 's' definition 'sorig'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dlua.h:42:43: note: Function 'get_chunk_prefix' argument 1 names different: declaration 's' definition 'sorig'. stone_soup-0.34.1/source/dlua.cc:279:51: note: Function 'get_chunk_prefix' argument 1 names different: declaration 's' definition 'sorig'. stone_soup-0.34.1/source/dlua.cc:145:32: style: Parameter 'interp' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/dlua.cc:269:13: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/feature.cc:161:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable minimap [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/dgn-overview.cc:945:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/dgn-overview.cc:1084:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < feature_def , NUM_SHOW_ITEMS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < feature_def , NUM_SHOW_ITEMS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < feature_def , NUM_SHOW_ITEMS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/feature.cc:182:46: performance: Function parameter 'object' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/geom2d.cc:114:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fearmonger.cc:57:50: style:inconclusive: Function 'get_fearmonger' argument 1 names different: declaration 'pos' definition 'target'. [funcArgNamesDifferent] stone_soup-0.34.1/source/player.h:623:46: note: Function 'get_fearmonger' argument 1 names different: declaration 'pos' definition 'target'. stone_soup-0.34.1/source/fearmonger.cc:57:50: note: Function 'get_fearmonger' argument 1 names different: declaration 'pos' definition 'target'. stone_soup-0.34.1/source/stash.h:23:5: style: Class 'Stash' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/stash.h:86:5: style: Class 'ShopInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/dgn-overview.cc:722:5: style: Class 'dgn_overview' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fearmonger.cc:87:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/fearmonger.cc:132:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/dgn-overview.cc:339:34: style: Condition 'bzot==0' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/dgn-overview.cc:805:47: style:inconclusive: Function '_seen_portal' argument 1 names different: declaration 'feat' definition 'which_thing'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dgn-overview.cc:78:47: note: Function '_seen_portal' argument 1 names different: declaration 'feat' definition 'which_thing'. stone_soup-0.34.1/source/dgn-overview.cc:805:47: note: Function '_seen_portal' argument 1 names different: declaration 'feat' definition 'which_thing'. stone_soup-0.34.1/source/dgn-overview.cc:1080:34: style:inconclusive: Function 'level_annotation_has' argument 1 names different: declaration 'str' definition 'find'. [funcArgNamesDifferent] stone_soup-0.34.1/source/dgn-overview.h:38:34: note: Function 'level_annotation_has' argument 1 names different: declaration 'str' definition 'find'. stone_soup-0.34.1/source/dgn-overview.cc:1080:34: note: Function 'level_annotation_has' argument 1 names different: declaration 'str' definition 'find'. stone_soup-0.34.1/source/dgn-overview.cc:265:30: performance: Function parameter 'colour_string' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/dgn-overview.cc:1030:44: performance: Function parameter 'str' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/dgn-overview.cc:1153:56: performance: Function parameter 'brs' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/dgn-overview.cc:362:16: style: Variable 'cell' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/dgn-overview.cc:963:36: style: Parameter 'mons' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/dgn-overview.cc:1055:21: style: Variable 'excl' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/dgn-overview.cc:1063:21: style: Variable 'uniq' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/dgn-overview.cc:123:22: performance: Assigning the result of c_str() to a std::string is slow and redundant. [stlcstrAssignment] stone_soup-0.34.1/source/dgn-overview.cc:187:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/dgn-overview.cc:201:13: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/dgn-overview.cc:516:13: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/dgn-overview.cc:1218:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/end.cc:152:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/end.cc:271:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_scroll [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/end.cc:361:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable VERT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/game-options.h:566:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable choices [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/game-options.h:574:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/end.cc:263:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/end.cc:263:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/game-options.h:383:25: style:inconclusive: Technically the member function 'OptFunctor::operator()' can be const. [functionConst] stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/game-options.h:88:5: style: Class 'DisabledGameOption' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:131:15: style: Class 'fixedp < int , 100 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:135:15: style: Class 'fixedp < int , 100 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:139:15: style: Class 'fixedp < int , 100 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:143:15: style: Class 'fixedp < int , 100 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:147:15: style: Class 'fixedp < int , 100 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:155:15: style: Class 'fixedp < int , 100 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:160:15: style: Class 'fixedp < int , 100 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:131:15: style: Class 'fixedp < char , 127 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:135:15: style: Class 'fixedp < char , 127 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:139:15: style: Class 'fixedp < char , 127 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:143:15: style: Class 'fixedp < char , 127 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:147:15: style: Class 'fixedp < char , 127 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:155:15: style: Class 'fixedp < char , 127 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:160:15: style: Class 'fixedp < char , 127 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:131:15: style: Class 'fixedp < unsigned char , 255 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:135:15: style: Class 'fixedp < unsigned char , 255 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:139:15: style: Class 'fixedp < unsigned char , 255 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:143:15: style: Class 'fixedp < unsigned char , 255 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:147:15: style: Class 'fixedp < unsigned char , 255 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:155:15: style: Class 'fixedp < unsigned char , 255 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedp.h:160:15: style: Class 'fixedp < unsigned char , 255 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/game-options.h:93:10: style: The function 'reset' overrides a function in a base class but just delegates back to the base class. [uselessOverride] stone_soup-0.34.1/source/game-options.h:51:18: note: Virtual function in base class stone_soup-0.34.1/source/game-options.h:93:10: note: Function in derived class stone_soup-0.34.1/source/game-options.cc:185:9: style: Condition '!error.empty()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/fixedp.h:246:41: style: Unsigned expression 'content' can't be negative so it is unnecessary to test it. [unsignedPositive] stone_soup-0.34.1/source/fixedp.h:273:43: style: Unsigned expression 'content' can't be negative so it is unnecessary to test it. [unsignedPositive] stone_soup-0.34.1/source/fixedp.h:290:28: style: Unsigned expression 'n.content' can't be negative so it is unnecessary to test it. [unsignedPositive] stone_soup-0.34.1/source/fixedp.h:295:28: style: Unsigned expression 'n.content' can't be negative so it is unnecessary to test it. [unsignedPositive] stone_soup-0.34.1/source/fixedp.h:511:32: style: Unsigned expression 'content' can't be negative so it is unnecessary to test it. [unsignedPositive] stone_soup-0.34.1/source/game-options.cc:96:73: style:inconclusive: Function 'loadFromString' argument 2 names different: declaration '' definition 'ltyp'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/game-options.cc:110:75: style:inconclusive: Function 'loadFromString' argument 2 names different: declaration '' definition 'ltyp'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/game-options.cc:120:75: style:inconclusive: Function 'loadFromString' argument 2 names different: declaration '' definition 'ltyp'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/game-options.cc:144:72: style:inconclusive: Function 'loadFromString' argument 2 names different: declaration '' definition 'ltyp'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/game-options.cc:157:75: style:inconclusive: Function 'loadFromString' argument 2 names different: declaration '' definition 'ltyp'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/game-options.cc:174:75: style:inconclusive: Function 'loadFromString' argument 2 names different: declaration '' definition 'ltyp'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/game-options.h:88:46: performance: Function parameter '_names' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.h:119:53: performance: Function parameter '_names' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.h:148:59: performance: Function parameter '_names' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.h:178:59: performance: Function parameter '_names' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.h:207:51: performance: Function parameter '_names' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.h:238:59: performance: Function parameter '_names' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.h:269:57: performance: Function parameter '_names' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.h:270:29: performance: Function parameter '_default' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.h:332:73: performance: Function parameter '_names' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.h:333:34: performance: Function parameter '_default' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.h:403:59: performance: Function parameter '_names' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.h:404:30: performance: Function parameter '_default' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.h:557:65: performance: Function parameter '_names' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.h:558:53: performance: Function parameter 'extra_maybe' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/game-options.cc:214:17: performance: Range variable 'pair_str' should be declared as const reference. [iterateByValue] stone_soup-0.34.1/source/game-options.h:488:61: performance: Function parameter '_names' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/fixedp.h:743:9: style: Instance of 'fixedp < char , 127 >' object is destroyed immediately. [unusedScopedObject] stone_soup-0.34.1/source/fixedp.h:744:9: style: Instance of 'fixedp < unsigned char , 255 >' object is destroyed immediately. [unusedScopedObject] stone_soup-0.34.1/source/transform.h:35:5: style: Class 'FormAttackVerbs' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/transform.h:66:5: style: Class 'Form' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/end.cc:265:18: style: The function '_allocate_region' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:997:10: note: Virtual function in base class stone_soup-0.34.1/source/end.cc:265:18: note: Function in derived class stone_soup-0.34.1/source/game-options.h:100:33: style: Variable 'other_casted' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/end.cc:443:38: style: Condition '!crawl_should_restart(game_exit::crash)' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/end.cc:443:59: note: Calling function 'crawl_should_restart' returns 0 stone_soup-0.34.1/source/end.cc:443:38: note: Condition '!crawl_should_restart(game_exit::crash)' is always true stone_soup-0.34.1/source/game-options.cc:98:12: style: Unused variable: error [unusedVariable] stone_soup-0.34.1/source/end.cc:146:39: style:inconclusive: Function 'end' argument 2 names different: declaration 'print_err' definition 'print_error'. [funcArgNamesDifferent] stone_soup-0.34.1/source/end.h:14:39: note: Function 'end' argument 2 names different: declaration 'print_err' definition 'print_error'. stone_soup-0.34.1/source/end.cc:146:39: note: Function 'end' argument 2 names different: declaration 'print_err' definition 'print_error'. stone_soup-0.34.1/source/end.cc:220:38: performance: Function parameter 'text' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/end.cc:275:41: style: Parameter 'se' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/jobs.h:36:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NUM_JOBS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ghost.cc:127:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hash.cc:22:24: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/hash.cc:26:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] stone_soup-0.34.1/source/god-conduct.cc:703:27: debug: Scope::checkVariable found variable 'level' with varid 0. [varid0] stone_soup-0.34.1/source/god-conduct.cc:836:27: debug: Scope::checkVariable found variable 'mons_speed' with varid 0. [varid0] stone_soup-0.34.1/source/god-conduct.cc:697:52: debug: Function::addArguments found argument 'denom' with varid 0. [varid0] stone_soup-0.34.1/source/god-conduct.cc:859:34: debug: Function::addArguments found argument 'denom' with varid 0. [varid0] stone_soup-0.34.1/source/god-conduct.cc:897:34: debug: Function::addArguments found argument 'denom' with varid 0. [varid0] stone_soup-0.34.1/source/god-conduct.cc:913:55: debug: Function::addArguments found argument 'denom' with varid 0. [varid0] stone_soup-0.34.1/source/god-conduct.cc:931:38: debug: Function::addArguments found argument 'denom' with varid 0. [varid0] stone_soup-0.34.1/source/ghost.cc:1114:25: style: The member function 'ghost_demon::translate_spell' can be static. [functionStatic] stone_soup-0.34.1/source/ghost.h:111:16: note: The member function 'ghost_demon::translate_spell' can be static. stone_soup-0.34.1/source/ghost.cc:1114:25: note: The member function 'ghost_demon::translate_spell' can be static. stone_soup-0.34.1/source/random-pick.h:116:28: style: The member function 'random_picker < spell_type , NUM_SPELLS >::rarity_at' can be static. [functionStatic] stone_soup-0.34.1/source/random-pick.h:38:9: note: The member function 'random_picker < spell_type , NUM_SPELLS >::rarity_at' can be static. stone_soup-0.34.1/source/random-pick.h:116:28: note: The member function 'random_picker < spell_type , NUM_SPELLS >::rarity_at' can be static. stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < transformation >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < player_equip_set >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/ghost.cc:1114:52: style:inconclusive: Function 'translate_spell' argument 1 names different: declaration 'playerspell' definition 'spell'. [funcArgNamesDifferent] stone_soup-0.34.1/source/ghost.h:111:43: note: Function 'translate_spell' argument 1 names different: declaration 'playerspell' definition 'spell'. stone_soup-0.34.1/source/ghost.cc:1114:52: note: Function 'translate_spell' argument 1 names different: declaration 'playerspell' definition 'spell'. stone_soup-0.34.1/source/ghost.cc:1198:58: style:inconclusive: Function 'find_extra_ghosts' argument 1 names different: declaration 'ghosts' definition 'gs'. [funcArgNamesDifferent] stone_soup-0.34.1/source/ghost.h:105:56: note: Function 'find_extra_ghosts' argument 1 names different: declaration 'ghosts' definition 'gs'. stone_soup-0.34.1/source/ghost.cc:1198:58: note: Function 'find_extra_ghosts' argument 1 names different: declaration 'ghosts' definition 'gs'. stone_soup-0.34.1/source/ghost.cc:1007:9: style: Local variable 'delay' shadows outer function [shadowFunction] stone_soup-0.34.1/source/libconsole.h:36:6: note: Shadowed declaration stone_soup-0.34.1/source/ghost.cc:1007:9: note: Shadow variable stone_soup-0.34.1/source/ghost.cc:535:39: performance: Function parameter 'name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/ghost.cc:1339:46: style: Parameter 'ghosts' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/ghost.cc:538:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/ghost.cc:1329:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/ghost.cc:1344:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/god-item.cc:306:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_LIGHTNING_SCALES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/god-item.cc:326:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_WUCAD_MU [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ghost.cc:758:30: style: Variable 'spell' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/god-blessing.cc:215:23: style: Condition 'blessing.empty()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/god-blessing.cc:152:42: performance: Function parameter 'blessing' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/god-blessing.cc:151:44: style: Parameter 'follower' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/god-prayer.cc:185:21: style: Variable 'quant' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/hiscores.cc:361:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:530:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_region [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:603:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdin [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:942:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:984:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NUM_SPECIES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:1006:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NUM_SPECIES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:1016:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:1333:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:1526:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:1793:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable description [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:1902:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:1923:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:2245:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:3032:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:3049:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/invent.cc:873:0: debug: Function::addArguments found argument 'set' with varid 0. [varid0] stone_soup-0.34.1/source/item-prop.cc:1786:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_GYRE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-prop.cc:1978:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_LOCHABER_AXE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-prop.cc:2011:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_ELEMENTAL_STAFF [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-prop.cc:2025:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_WUCAD_MU [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-prop.cc:2102:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_LOCHABER_AXE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-prop.cc:2191:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_DAMNATION [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-prop.cc:2325:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_RIFT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-prop.cc:2650:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_SEVEN_LEAGUE_BOOTS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-prop.cc:2786:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_SLICK_SLIPPERS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-prop.cc:2881:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_DISPATER [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-prop.cc:3054:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_LEAR [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-prop.cc:3333:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable base_type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/invent.cc:300:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACT_EXAMINE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/invent.cc:308:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACT_EXECUTE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/invent.cc:660:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TILE_ITEM_SLOT_EQUIP_CURSED [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/invent.cc:759:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/invent.cc:769:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable method [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/invent.cc:783:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable method [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/invent.cc:789:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable method [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:563:22: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] stone_soup-0.34.1/source/hiscores.cc:568:22: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] stone_soup-0.34.1/source/hiscores.cc:575:23: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] stone_soup-0.34.1/source/hiscores.cc:716:18: warning:inconclusive: Member variable 'scorefile_entry::fields' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] stone_soup-0.34.1/source/hiscores.cc:721:35: warning:inconclusive: Member variable 'scorefile_entry::fields' is not assigned a value in 'scorefile_entry::operator='. [operatorEqVarError] stone_soup-0.34.1/source/hiscores.cc:416:5: performance: Variable 'm_root' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] stone_soup-0.34.1/source/item-name.cc:1389:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_WOE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-name.cc:1505:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_ZEALOT_SWORD [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-name.cc:2969:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_CHARLATANS_ORB [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-name.cc:3284:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-name.cc:3692:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/hiscores.cc:1877:25: style: The member function 'scorefile_entry::strip_article_a' can be static. [functionStatic] stone_soup-0.34.1/source/hiscores.h:202:12: note: The member function 'scorefile_entry::strip_article_a' can be static. stone_soup-0.34.1/source/hiscores.cc:1877:25: note: The member function 'scorefile_entry::strip_article_a' can be static. stone_soup-0.34.1/source/hiscores.cc:1284:25: style: The member function 'scorefile_entry::make_oneline' can be static. [functionStatic] stone_soup-0.34.1/source/hiscores.h:219:12: note: The member function 'scorefile_entry::make_oneline' can be static. stone_soup-0.34.1/source/hiscores.cc:1284:25: note: The member function 'scorefile_entry::make_oneline' can be static. stone_soup-0.34.1/source/outer-menu.h:82:32: style:inconclusive: Either there is a missing 'override', or the member function 'OuterMenu::get_buttons' can be const. [functionConst] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < std :: string >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/hiscores.h:208:12: performance: Function 'death_source_desc()' should return member 'death_source_name' by const reference. [returnByReference] stone_soup-0.34.1/source/item-prop.cc:2039:40: style:inconclusive: Function 'staff_type_name' argument 1 names different: declaration 'staff' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/item-prop.h:98:40: note: Function 'staff_type_name' argument 1 names different: declaration 'staff' definition 's'. stone_soup-0.34.1/source/item-prop.cc:2039:40: note: Function 'staff_type_name' argument 1 names different: declaration 'staff' definition 's'. stone_soup-0.34.1/source/item-prop.cc:2047:35: style:inconclusive: Function 'staff_skill' argument 1 names different: declaration 'staff' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/item-prop.h:99:35: note: Function 'staff_skill' argument 1 names different: declaration 'staff' definition 's'. stone_soup-0.34.1/source/item-prop.cc:2047:35: note: Function 'staff_skill' argument 1 names different: declaration 'staff' definition 's'. stone_soup-0.34.1/source/item-prop.cc:2053:40: style:inconclusive: Function 'staff_damage_type' argument 1 names different: declaration 'staff' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/item-prop.h:100:40: note: Function 'staff_damage_type' argument 1 names different: declaration 'staff' definition 's'. stone_soup-0.34.1/source/item-prop.cc:2053:40: note: Function 'staff_damage_type' argument 1 names different: declaration 'staff' definition 's'. stone_soup-0.34.1/source/item-prop.cc:2059:34: style:inconclusive: Function 'staff_damage_mult' argument 1 names different: declaration 'staff' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/item-prop.h:101:34: note: Function 'staff_damage_mult' argument 1 names different: declaration 'staff' definition 's'. stone_soup-0.34.1/source/item-prop.cc:2059:34: note: Function 'staff_damage_mult' argument 1 names different: declaration 'staff' definition 's'. stone_soup-0.34.1/source/item-prop.cc:2065:35: style:inconclusive: Function 'staff_ac_check' argument 1 names different: declaration 'staff' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/item-prop.h:102:35: note: Function 'staff_ac_check' argument 1 names different: declaration 'staff' definition 's'. stone_soup-0.34.1/source/item-prop.cc:2065:35: note: Function 'staff_ac_check' argument 1 names different: declaration 'staff' definition 's'. stone_soup-0.34.1/source/item-prop.cc:2345:34: style:inconclusive: Function 'item_is_orb' argument 1 names different: declaration 'orb' definition 'item'. [funcArgNamesDifferent] stone_soup-0.34.1/source/item-prop.h:200:34: note: Function 'item_is_orb' argument 1 names different: declaration 'orb' definition 'item'. stone_soup-0.34.1/source/item-prop.cc:2345:34: note: Function 'item_is_orb' argument 1 names different: declaration 'orb' definition 'item'. stone_soup-0.34.1/source/item-prop.cc:3163:31: style:inconclusive: Function 'talisman_type_name' argument 1 names different: declaration 'sub_type' definition 'type'. [funcArgNamesDifferent] stone_soup-0.34.1/source/item-prop.h:263:31: note: Function 'talisman_type_name' argument 1 names different: declaration 'sub_type' definition 'type'. stone_soup-0.34.1/source/item-prop.cc:3163:31: note: Function 'talisman_type_name' argument 1 names different: declaration 'sub_type' definition 'type'. stone_soup-0.34.1/source/item-prop.cc:3579:42: style:inconclusive: Function 'force_item_set_choice' argument 1 names different: declaration 'typ' definition 'iset'. [funcArgNamesDifferent] stone_soup-0.34.1/source/item-prop.h:268:42: note: Function 'force_item_set_choice' argument 1 names different: declaration 'typ' definition 'iset'. stone_soup-0.34.1/source/item-prop.cc:3579:42: note: Function 'force_item_set_choice' argument 1 names different: declaration 'typ' definition 'iset'. stone_soup-0.34.1/source/item-prop.cc:1402:22: style: Local variable '_hide_armour_set' shadows outer variable [shadowVariable] stone_soup-0.34.1/source/item-prop.cc:1408:25: note: Shadowed declaration stone_soup-0.34.1/source/item-prop.cc:1402:22: note: Shadow variable stone_soup-0.34.1/source/item-prop.cc:1444:36: style: Local variable 'hide_to_mons' shadows outer variable [shadowVariable] stone_soup-0.34.1/source/item-prop.cc:1459:39: note: Shadowed declaration stone_soup-0.34.1/source/item-prop.cc:1444:36: note: Shadow variable stone_soup-0.34.1/source/item-prop.cc:3478:26: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] stone_soup-0.34.1/source/item-prop.cc:3286:43: performance: Function parameter 'name_nospace' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/item-prop.cc:3672:39: performance: Function parameter 'name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/item-prop.cc:1471:19: style: Variable 'mon' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/item-prop.cc:2493:23: style: Variable 'rarity' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/item-prop.cc:3236:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/hiscores.cc:106:47: style:inconclusive: Function 'hiscores_new_entry' argument 1 names different: declaration 'se' definition 'ne'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:20:47: note: Function 'hiscores_new_entry' argument 1 names different: declaration 'se' definition 'ne'. stone_soup-0.34.1/source/hiscores.cc:106:47: note: Function 'hiscores_new_entry' argument 1 names different: declaration 'se' definition 'ne'. stone_soup-0.34.1/source/hiscores.cc:195:47: style:inconclusive: Function 'logfile_new_entry' argument 1 names different: declaration 'se' definition 'ne'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:22:47: note: Function 'logfile_new_entry' argument 1 names different: declaration 'se' definition 'ne'. stone_soup-0.34.1/source/hiscores.cc:195:47: note: Function 'logfile_new_entry' argument 1 names different: declaration 'se' definition 'ne'. stone_soup-0.34.1/source/hiscores.cc:599:55: style:inconclusive: Function '_hs_open' argument 2 names different: declaration 'filename' definition 'scores'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.cc:75:55: note: Function '_hs_open' argument 2 names different: declaration 'filename' definition 'scores'. stone_soup-0.34.1/source/hiscores.cc:599:55: note: Function '_hs_open' argument 2 names different: declaration 'filename' definition 'scores'. stone_soup-0.34.1/source/hiscores.cc:653:54: style:inconclusive: Function '_hs_write' argument 2 names different: declaration 'entry' definition 'se'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.cc:78:55: note: Function '_hs_write' argument 2 names different: declaration 'entry' definition 'se'. stone_soup-0.34.1/source/hiscores.cc:653:54: note: Function '_hs_write' argument 2 names different: declaration 'entry' definition 'se'. stone_soup-0.34.1/source/hiscores.cc:699:38: style:inconclusive: Function 'scorefile_entry' argument 1 names different: declaration 'damage' definition 'dam'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:156:25: note: Function 'scorefile_entry' argument 1 names different: declaration 'damage' definition 'dam'. stone_soup-0.34.1/source/hiscores.cc:699:38: note: Function 'scorefile_entry' argument 1 names different: declaration 'damage' definition 'dam'. stone_soup-0.34.1/source/hiscores.cc:699:49: style:inconclusive: Function 'scorefile_entry' argument 2 names different: declaration 'death_source' definition 'dsource'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:156:39: note: Function 'scorefile_entry' argument 2 names different: declaration 'death_source' definition 'dsource'. stone_soup-0.34.1/source/hiscores.cc:699:49: note: Function 'scorefile_entry' argument 2 names different: declaration 'death_source' definition 'dsource'. stone_soup-0.34.1/source/hiscores.cc:699:62: style:inconclusive: Function 'scorefile_entry' argument 3 names different: declaration 'death_type' definition 'dtype'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:156:57: note: Function 'scorefile_entry' argument 3 names different: declaration 'death_type' definition 'dtype'. stone_soup-0.34.1/source/hiscores.cc:699:62: note: Function 'scorefile_entry' argument 3 names different: declaration 'death_type' definition 'dtype'. stone_soup-0.34.1/source/hiscores.cc:701:46: style:inconclusive: Function 'scorefile_entry' argument 6 names different: declaration 'death_source_name' definition 'dsource_name'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:158:33: note: Function 'scorefile_entry' argument 6 names different: declaration 'death_source_name' definition 'dsource_name'. stone_soup-0.34.1/source/hiscores.cc:701:46: note: Function 'scorefile_entry' argument 6 names different: declaration 'death_source_name' definition 'dsource_name'. stone_soup-0.34.1/source/hiscores.cc:701:67: style:inconclusive: Function 'scorefile_entry' argument 7 names different: declaration 'death_time' definition 'dt'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:159:28: note: Function 'scorefile_entry' argument 7 names different: declaration 'death_time' definition 'dt'. stone_soup-0.34.1/source/hiscores.cc:701:67: note: Function 'scorefile_entry' argument 7 names different: declaration 'death_time' definition 'dt'. stone_soup-0.34.1/source/hiscores.cc:721:70: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'other' definition 'se'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:162:57: note: Function 'operator=' argument 1 names different: declaration 'other' definition 'se'. stone_soup-0.34.1/source/hiscores.cc:721:70: note: Function 'operator=' argument 1 names different: declaration 'other' definition 'se'. stone_soup-0.34.1/source/hiscores.cc:727:56: style:inconclusive: Function 'init_from' argument 1 names different: declaration 'other' definition 'se'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:221:43: note: Function 'init_from' argument 1 names different: declaration 'other' definition 'se'. stone_soup-0.34.1/source/hiscores.cc:727:56: note: Function 'init_from' argument 1 names different: declaration 'other' definition 'se'. stone_soup-0.34.1/source/hiscores.cc:1284:52: style:inconclusive: Function 'make_oneline' argument 1 names different: declaration 's' definition 'ml'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:219:39: note: Function 'make_oneline' argument 1 names different: declaration 's' definition 'ml'. stone_soup-0.34.1/source/hiscores.cc:1284:52: note: Function 'make_oneline' argument 1 names different: declaration 's' definition 'ml'. stone_soup-0.34.1/source/hiscores.cc:1341:44: style:inconclusive: Function 'init_death_cause' argument 1 names different: declaration 'damage' definition 'dam'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:164:31: note: Function 'init_death_cause' argument 1 names different: declaration 'damage' definition 'dam'. stone_soup-0.34.1/source/hiscores.cc:1341:44: note: Function 'init_death_cause' argument 1 names different: declaration 'damage' definition 'dam'. stone_soup-0.34.1/source/hiscores.cc:1341:55: style:inconclusive: Function 'init_death_cause' argument 2 names different: declaration 'death_source' definition 'dsrc'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:164:45: note: Function 'init_death_cause' argument 2 names different: declaration 'death_source' definition 'dsrc'. stone_soup-0.34.1/source/hiscores.cc:1341:55: note: Function 'init_death_cause' argument 2 names different: declaration 'death_source' definition 'dsrc'. stone_soup-0.34.1/source/hiscores.cc:1342:44: style:inconclusive: Function 'init_death_cause' argument 3 names different: declaration 'death_type' definition 'dtype'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:164:63: note: Function 'init_death_cause' argument 3 names different: declaration 'death_type' definition 'dtype'. stone_soup-0.34.1/source/hiscores.cc:1342:44: note: Function 'init_death_cause' argument 3 names different: declaration 'death_type' definition 'dtype'. stone_soup-0.34.1/source/hiscores.cc:1343:52: style:inconclusive: Function 'init_death_cause' argument 5 names different: declaration 'death_source_name' definition 'dsrc_name'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:165:56: note: Function 'init_death_cause' argument 5 names different: declaration 'death_source_name' definition 'dsrc_name'. stone_soup-0.34.1/source/hiscores.cc:1343:52: note: Function 'init_death_cause' argument 5 names different: declaration 'death_source_name' definition 'dsrc_name'. stone_soup-0.34.1/source/hiscores.cc:1622:35: style:inconclusive: Function 'init' argument 1 names different: declaration 'death_time' definition 'dt'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:166:22: note: Function 'init' argument 1 names different: declaration 'death_time' definition 'dt'. stone_soup-0.34.1/source/hiscores.cc:1622:35: note: Function 'init' argument 1 names different: declaration 'death_time' definition 'dt'. stone_soup-0.34.1/source/hiscores.cc:1841:56: style:inconclusive: Function 'game_time' argument 1 names different: declaration '' definition 'verbosity'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/hiscores.cc:2034:61: style:inconclusive: Function 'character_description' argument 1 names different: declaration '' definition 'verbosity'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/hiscores.cc:2134:58: style:inconclusive: Function 'death_place' argument 1 names different: declaration '' definition 'verbosity'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/hiscores.cc:2173:64: style:inconclusive: Function 'death_description' argument 1 names different: declaration '' definition 'verbosity'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/hiscores.cc:3070:45: style:inconclusive: Function 'str_field' argument 1 names different: declaration '' definition 's'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/hiscores.cc:3075:42: style:inconclusive: Function 'int_field' argument 1 names different: declaration '' definition 's'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/hiscores.cc:3157:56: style:inconclusive: Function 'mark_milestone' argument 4 names different: declaration 't' definition 'milestone_time'. [funcArgNamesDifferent] stone_soup-0.34.1/source/hiscores.h:35:61: note: Function 'mark_milestone' argument 4 names different: declaration 't' definition 'milestone_time'. stone_soup-0.34.1/source/hiscores.cc:3157:56: note: Function 'mark_milestone' argument 4 names different: declaration 't' definition 'milestone_time'. stone_soup-0.34.1/source/hiscores.cc:1901:27: style: Local variable 'end' shadows outer function [shadowFunction] stone_soup-0.34.1/source/end.h:14:15: note: Shadowed declaration stone_soup-0.34.1/source/hiscores.cc:1901:27: note: Shadow variable stone_soup-0.34.1/source/hiscores.cc:3029:34: style: Local variable 'end' shadows outer function [shadowFunction] stone_soup-0.34.1/source/end.h:14:15: note: Shadowed declaration stone_soup-0.34.1/source/hiscores.cc:3029:34: note: Shadow variable stone_soup-0.34.1/source/hiscores.cc:338:43: style: Parameter 'se' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/hiscores.cc:484:56: style: Parameter 'se' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/hiscores.cc:653:54: style: Parameter 'se' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/hiscores.cc:563:16: style: Variable 'd1' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/hiscores.cc:568:16: style: Variable 'd2' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/invent.cc:283:16: style: The member function 'InvEntry::set_show_glyph' can be static. [functionStatic] stone_soup-0.34.1/source/invent.h:98:10: note: The member function 'InvEntry::set_show_glyph' can be static. stone_soup-0.34.1/source/invent.cc:283:16: note: The member function 'InvEntry::set_show_glyph' can be static. stone_soup-0.34.1/source/invent.cc:289:16: style: The member function 'InvEntry::set_show_coordinates' can be static. [functionStatic] stone_soup-0.34.1/source/invent.h:99:10: note: The member function 'InvEntry::set_show_coordinates' can be static. stone_soup-0.34.1/source/invent.cc:289:16: note: The member function 'InvEntry::set_show_coordinates' can be static. stone_soup-0.34.1/source/invent.cc:928:15: style: The member function 'InvMenu::sort_menu' can be static. [functionStatic] stone_soup-0.34.1/source/invent.h:167:10: note: The member function 'InvMenu::sort_menu' can be static. stone_soup-0.34.1/source/invent.cc:928:15: note: The member function 'InvMenu::sort_menu' can be static. stone_soup-0.34.1/source/invent.cc:1077:15: style:inconclusive: Technically the member function 'InvMenu::do_preselect' can be const. [functionConst] stone_soup-0.34.1/source/invent.h:173:10: note: Technically the member function 'InvMenu::do_preselect' can be const. stone_soup-0.34.1/source/invent.cc:1077:15: note: Technically the member function 'InvMenu::do_preselect' can be const. stone_soup-0.34.1/source/hiscores.cc:1459:28: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < tile_flavour , 80 , 70 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < tile_flavour , 80 , 70 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < tile_flavour , 80 , 70 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < tile_flavour , 80 , 70 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < tile_flavour , 70 > , 80 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < tile_flavour , 70 > , 80 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/invent.cc:860:5: style: Struct 'menu_entry_comparator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < tile_flavour , 80 , 70 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < tile_flavour , 70 > , 80 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/invent.cc:1827:13: style: Condition 'need_redraw' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/invent.cc:1813:24: note: Assignment 'need_redraw=false', assigned value is 0 stone_soup-0.34.1/source/invent.cc:1827:13: note: Condition 'need_redraw' is always false stone_soup-0.34.1/source/invent.cc:311:54: style:inconclusive: Function 'set_title_annotator' argument 1 names different: declaration 'fn' definition 'afn'. [funcArgNamesDifferent] stone_soup-0.34.1/source/invent.h:138:49: note: Function 'set_title_annotator' argument 1 names different: declaration 'fn' definition 'afn'. stone_soup-0.34.1/source/invent.cc:311:54: note: Function 'set_title_annotator' argument 1 names different: declaration 'fn' definition 'afn'. stone_soup-0.34.1/source/invent.cc:316:36: style:inconclusive: Function 'set_title' argument 1 names different: declaration 'title' definition 't'. [funcArgNamesDifferent] stone_soup-0.34.1/source/invent.h:141:31: note: Function 'set_title' argument 1 names different: declaration 'title' definition 't'. stone_soup-0.34.1/source/invent.cc:316:36: note: Function 'set_title' argument 1 names different: declaration 'title' definition 't'. stone_soup-0.34.1/source/invent.h:177:40: style:inconclusive: Function 'get_select_count_string' argument 1 names different: declaration 'count' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/invent.h:118:46: style:inconclusive: Function 'get_tiles' argument 1 names different: declaration 'tiles' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/invent.cc:873:0: style:inconclusive: Function 'init_item_sort_comparators' argument 2 names different: declaration '' definition 'set'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/invent.cc:928:44: style:inconclusive: Function 'sort_menu' argument 1 names different: declaration 'items' definition 'invitems'. [funcArgNamesDifferent] stone_soup-0.34.1/source/invent.h:167:39: note: Function 'sort_menu' argument 1 names different: declaration 'items' definition 'invitems'. stone_soup-0.34.1/source/invent.cc:928:44: note: Function 'sort_menu' argument 1 names different: declaration 'items' definition 'invitems'. stone_soup-0.34.1/source/invent.cc:964:57: style:inconclusive: Function 'load_items' argument 1 names different: declaration 'items' definition 'mitems'. [funcArgNamesDifferent] stone_soup-0.34.1/source/invent.h:153:52: note: Function 'load_items' argument 1 names different: declaration 'items' definition 'mitems'. stone_soup-0.34.1/source/invent.cc:964:57: note: Function 'load_items' argument 1 names different: declaration 'items' definition 'mitems'. stone_soup-0.34.1/source/invent.cc:974:64: style:inconclusive: Function 'load_items' argument 1 names different: declaration 'items' definition 'mitems'. [funcArgNamesDifferent] stone_soup-0.34.1/source/invent.h:147:59: note: Function 'load_items' argument 1 names different: declaration 'items' definition 'mitems'. stone_soup-0.34.1/source/invent.cc:974:64: note: Function 'load_items' argument 1 names different: declaration 'items' definition 'mitems'. stone_soup-0.34.1/source/invent.cc:1255:39: style:inconclusive: Function 'item_is_selected' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] stone_soup-0.34.1/source/invent.h:198:39: note: Function 'item_is_selected' argument 1 names different: declaration 'item' definition 'i'. stone_soup-0.34.1/source/invent.cc:1255:39: note: Function 'item_is_selected' argument 1 names different: declaration 'item' definition 'i'. stone_soup-0.34.1/source/invent.cc:1393:28: style:inconclusive: Function 'any_items_of_type' argument 1 names different: declaration 'type_expect' definition 'selector'. [funcArgNamesDifferent] stone_soup-0.34.1/source/invent.h:199:28: note: Function 'any_items_of_type' argument 1 names different: declaration 'type_expect' definition 'selector'. stone_soup-0.34.1/source/invent.cc:1393:28: note: Function 'any_items_of_type' argument 1 names different: declaration 'type_expect' definition 'selector'. stone_soup-0.34.1/source/invent.cc:1791:34: style:inconclusive: Function 'prompt_invent_item' argument 2 names different: declaration 'type' definition 'mtype'. [funcArgNamesDifferent] stone_soup-0.34.1/source/invent.h:205:34: note: Function 'prompt_invent_item' argument 2 names different: declaration 'type' definition 'mtype'. stone_soup-0.34.1/source/invent.cc:1791:34: note: Function 'prompt_invent_item' argument 2 names different: declaration 'type' definition 'mtype'. stone_soup-0.34.1/source/item-prop.cc:898:17: style: struct member 'food_def::name' is never used. [unusedStructMember] stone_soup-0.34.1/source/item-prop.cc:899:17: style: struct member 'food_def::normal_nutr' is never used. [unusedStructMember] stone_soup-0.34.1/source/item-prop.cc:900:17: style: struct member 'food_def::carn_nutr' is never used. [unusedStructMember] stone_soup-0.34.1/source/invent.cc:427:19: style: Variable 'sel_item' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/invent.cc:1521:54: style: Parameter 'item' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/invent.cc:431:23: style: Variable 'inv' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/invent.cc:753:19: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/invent.cc:879:7: style: Variable 'cmp_map' can be declared as const array [constVariable] stone_soup-0.34.1/source/invent.cc:1854:19: style: Variable 'chosen' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/invent.cc:1921:23: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/item-prop.cc:901:17: style: struct member 'food_def::herb_nutr' is never used. [unusedStructMember] stone_soup-0.34.1/source/invent.cc:544:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/invent.cc:909:13: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/invent.cc:970:19: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/invent.cc:1084:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/initfile.cc:443:26: debug: Scope::checkVariable found variable 'tmp_seed' with varid 0. [varid0] stone_soup-0.34.1/source/game-options.h:381:1: debug: SymbolDatabase couldn't resolve all user defined types. [debug] stone_soup-0.34.1/source/item-prop.cc:1546:25: style: Variable 'min' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/item-prop.cc:1547:25: style: Variable 'max' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/json.cc:45:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/json.cc:63:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/json.cc:85:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/json.cc:524:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/jobs.cc:27:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/jobs.cc:34:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable job_data [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/jobs.cc:43:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/jobs.cc:51:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/jobs.cc:138:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_FIGHTER [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/jobs.cc:154:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NUM_JOBS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/json.cc:1418:49: style: Condition 'node->bool_!=true' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/json.cc:1418:25: note: Assuming that condition 'node->bool_!=false' is not redundant stone_soup-0.34.1/source/json.cc:1418:49: note: Condition 'node->bool_!=true' is always false stone_soup-0.34.1/source/json.cc:43:17: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/json.cc:61:17: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/json.cc:83:17: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/json.cc:241:30: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/json.cc:287:24: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/json.cc:522:21: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/json.cc:1248:17: style: Statements following noreturn function 'die()' will never be executed. [unreachableCode] stone_soup-0.34.1/source/json.cc:1362:10: style: The scope of the variable 'c' can be reduced. [variableScope] stone_soup-0.34.1/source/json.cc:499:64: style:inconclusive: Function 'json_find_member' argument 2 names different: declaration 'key' definition 'name'. [funcArgNamesDifferent] stone_soup-0.34.1/source/json.h:87:70: note: Function 'json_find_member' argument 2 names different: declaration 'key' definition 'name'. stone_soup-0.34.1/source/json.cc:499:64: note: Function 'json_find_member' argument 2 names different: declaration 'key' definition 'name'. stone_soup-0.34.1/source/json.cc:553:32: performance: Function parameter 's' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/json.cc:1431:19: style: Variable 'tail' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/json.cc:1443:23: style: Variable 'last' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-colour.cc:24:21: style:inconclusive: Function 'get_nth' argument 1 names different: declaration 'n' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/l-colour.cc:18:56: performance: Function parameter '_name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/jobs.cc:95:15: style: Local variable 'items' shadows outer function [shadowFunction] stone_soup-0.34.1/source/makeitem.h:19:5: note: Shadowed declaration stone_soup-0.34.1/source/jobs.cc:95:15: note: Shadow variable stone_soup-0.34.1/source/jobs.cc:34:16: style: Variable 'entry' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/jobs.cc:55:16: style: Variable 'entry' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/jobs.cc:159:16: style: Variable 'entry' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/jobs.cc:35:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/initfile.cc:443:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tmp_seed [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:1279:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_RANDOM [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:1291:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_RANDOM [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:1314:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_RANDOM [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:1325:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_RANDOM [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:2120:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:2138:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:2494:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:2912:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:3118:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:3468:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:3554:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:3591:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:3723:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:4186:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:4959:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:5035:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:5213:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:5296:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:5319:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:5360:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:5620:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdout [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:5631:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:5726:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/initfile.cc:6313:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/item-name.cc:2277:18: style: The member function 'RuneMenu::gem_title' can be static. [functionStatic] stone_soup-0.34.1/source/item-name.cc:2222:12: note: The member function 'RuneMenu::gem_title' can be static. stone_soup-0.34.1/source/item-name.cc:2277:18: note: The member function 'RuneMenu::gem_title' can be static. stone_soup-0.34.1/source/item-name.cc:2304:16: style: The member function 'RuneMenu::can_show_gems' can be static. [functionStatic] stone_soup-0.34.1/source/item-name.cc:2231:10: note: The member function 'RuneMenu::can_show_gems' can be static. stone_soup-0.34.1/source/item-name.cc:2304:16: note: The member function 'RuneMenu::can_show_gems' can be static. stone_soup-0.34.1/source/item-name.cc:2309:16: style:inconclusive: Technically the member function 'RuneMenu::can_show_more_gems' can be const. [functionConst] stone_soup-0.34.1/source/item-name.cc:2232:10: note: Technically the member function 'RuneMenu::can_show_more_gems' can be const. stone_soup-0.34.1/source/item-name.cc:2309:16: note: Technically the member function 'RuneMenu::can_show_more_gems' can be const. stone_soup-0.34.1/source/item-name.cc:1471:36: style: Condition 'testbits(weap.flags,ISFLAG_REPLICA)' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/item-name.cc:1471:36: note: Calling function 'testbits' returns 0 stone_soup-0.34.1/source/item-name.cc:1471:36: note: Condition 'testbits(weap.flags,ISFLAG_REPLICA)' is always false stone_soup-0.34.1/source/item-name.cc:1721:56: style: Condition 'pcolour>=PDC_NCOLOURS' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/item-name.cc:1695:33: note: Assignment 'pcolour=(subtype_rnd)%PDC_NCOLOURS', assigned value is less than 23 stone_soup-0.34.1/source/item-name.cc:1721:56: note: Condition 'pcolour>=PDC_NCOLOURS' is always false stone_soup-0.34.1/source/item-name.cc:2544:29: style: Condition 'name.length()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/item-name.cc:2532:28: note: Assuming that condition 'name.empty()' is not redundant stone_soup-0.34.1/source/item-name.cc:2544:29: note: Condition 'name.length()' is always true stone_soup-0.34.1/source/item-name.cc:2558:39: style: Condition 'prev_char==' '' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/item-name.cc:2588:41: style: Condition 'name.empty()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/item-name.cc:2532:28: note: Assuming that condition 'name.empty()' is not redundant stone_soup-0.34.1/source/item-name.cc:2588:41: note: Condition 'name.empty()' is always false stone_soup-0.34.1/source/item-name.cc:2588:57: style: Condition 'prev_char==' '' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/item-name.cc:2592:29: style: Condition '!name.empty()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/item-name.cc:2532:28: note: Assuming that condition 'name.empty()' is not redundant stone_soup-0.34.1/source/item-name.cc:2592:29: note: Condition '!name.empty()' is always true stone_soup-0.34.1/source/item-name.cc:2594:21: style: Condition '!beg' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/item-name.cc:2532:28: note: Assuming that condition 'name.empty()' is not redundant stone_soup-0.34.1/source/item-name.cc:2588:28: note: beg is assigned 'name.empty()||prev_char==' '' here. stone_soup-0.34.1/source/item-name.cc:2594:21: note: Condition '!beg' is always true stone_soup-0.34.1/source/item-name.cc:2596:36: style: Condition 'beg' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/item-name.cc:2532:28: note: Assuming that condition 'name.empty()' is not redundant stone_soup-0.34.1/source/item-name.cc:2588:28: note: beg is assigned 'name.empty()||prev_char==' '' here. stone_soup-0.34.1/source/item-name.cc:2596:36: note: Condition 'beg' is always false stone_soup-0.34.1/source/item-name.cc:2597:36: style: Condition 'beg' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/item-name.cc:2532:28: note: Assuming that condition 'name.empty()' is not redundant stone_soup-0.34.1/source/item-name.cc:2588:28: note: beg is assigned 'name.empty()||prev_char==' '' here. stone_soup-0.34.1/source/item-name.cc:2597:36: note: Condition 'beg' is always false stone_soup-0.34.1/source/item-name.cc:1731:9: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] stone_soup-0.34.1/source/item-name.cc:1057:35: style:inconclusive: Function 'gizmo_effect_name' argument 1 names different: declaration 'gizmotype' definition 'type'. [funcArgNamesDifferent] stone_soup-0.34.1/source/item-name.h:177:35: note: Function 'gizmo_effect_name' argument 1 names different: declaration 'gizmotype' definition 'type'. stone_soup-0.34.1/source/item-name.cc:1057:35: note: Function 'gizmo_effect_name' argument 1 names different: declaration 'gizmotype' definition 'type'. stone_soup-0.34.1/source/item-name.cc:2712:44: style:inconclusive: Function '_random_consonant_set' argument 1 names different: declaration 'seed' definition 'c'. [funcArgNamesDifferent] stone_soup-0.34.1/source/item-name.cc:65:44: note: Function '_random_consonant_set' argument 1 names different: declaration 'seed' definition 'c'. stone_soup-0.34.1/source/item-name.cc:2712:44: note: Function '_random_consonant_set' argument 1 names different: declaration 'seed' definition 'c'. stone_soup-0.34.1/source/item-name.cc:2589:24: style: Local variable 'end' shadows outer function [shadowFunction] stone_soup-0.34.1/source/end.h:14:15: note: Shadowed declaration stone_soup-0.34.1/source/item-name.cc:2589:24: note: Shadow variable stone_soup-0.34.1/source/item-name.cc:2444:32: performance: Function parameter 'name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/item-name.cc:2624:32: warning: Either the condition 'name.empty()' is redundant or expression 'name[name.length()-1]' causes access out of bounds. [containerOutOfBounds] stone_soup-0.34.1/source/item-name.cc:2625:20: note: Assuming that condition 'name.empty()' is not redundant stone_soup-0.34.1/source/item-name.cc:2624:32: note: Access out of bounds stone_soup-0.34.1/source/item-name.cc:2049:13: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/item-name.cc:2820:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/item-name.cc:3386:13: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/kills.cc:863:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_REGISTRYINDEX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/kills.cc:893:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_REGISTRYINDEX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/known-items.cc:189:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable hotkeys [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/l-dgnevt.cc:17:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-dgnevt.cc:23:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-dgnevt.cc:31:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-dgnevt.cc:39:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-dgnevt.cc:45:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-dgnevt.cc:51:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-dgnevt.cc:17:5: style: Variable 'dev' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-dgnevt.cc:23:5: style: Variable 'dev' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-dgnevt.cc:31:5: style: Variable 'dev' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-dgnevt.cc:39:5: style: Variable 'dev' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-dgnevt.cc:45:5: style: Variable 'dev' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-dgnevt.cc:51:5: style: Variable 'dev' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/kills.cc:467:18: style: The member function 'kill_def::base_name' can be static. [functionStatic] stone_soup-0.34.1/source/kills.h:70:12: note: The member function 'kill_def::base_name' can be static. stone_soup-0.34.1/source/kills.cc:467:18: note: The member function 'kill_def::base_name' can be static. stone_soup-0.34.1/source/kills.cc:46:25: style: The member function 'KillMaster::category_name' can be static. [functionStatic] stone_soup-0.34.1/source/kills.h:178:17: note: The member function 'KillMaster::category_name' can be static. stone_soup-0.34.1/source/kills.cc:46:25: note: The member function 'KillMaster::category_name' can be static. stone_soup-0.34.1/source/kills.cc:181:18: style: The member function 'KillMaster::add_kill_info' can be static. [functionStatic] stone_soup-0.34.1/source/kills.h:182:10: note: The member function 'KillMaster::add_kill_info' can be static. stone_soup-0.34.1/source/kills.cc:181:18: note: The member function 'KillMaster::add_kill_info' can be static. stone_soup-0.34.1/source/initfile.cc:2620:39: warning:inconclusive: Member variable 'base_game_options::named_options' is not assigned a value in 'base_game_options::operator='. [operatorEqVarError] stone_soup-0.34.1/source/initfile.cc:2620:39: warning:inconclusive: Member variable 'base_game_options::terp_files' is not assigned a value in 'base_game_options::operator='. [operatorEqVarError] stone_soup-0.34.1/source/initfile.cc:2620:39: warning:inconclusive: Member variable 'base_game_options::additional_macro_files' is not assigned a value in 'base_game_options::operator='. [operatorEqVarError] stone_soup-0.34.1/source/initfile.cc:2620:39: warning:inconclusive: Member variable 'base_game_options::option_behaviour' is not assigned a value in 'base_game_options::operator='. [operatorEqVarError] stone_soup-0.34.1/source/initfile.cc:2620:39: warning:inconclusive: Member variable 'base_game_options::options_by_name' is not assigned a value in 'base_game_options::operator='. [operatorEqVarError] stone_soup-0.34.1/source/kills.cc:61:31: style:inconclusive: Function 'save' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:70:31: style:inconclusive: Function 'load' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:181:40: style:inconclusive: Function 'add_kill_info' argument 1 names different: declaration '' definition 'killtext'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:182:50: style:inconclusive: Function 'add_kill_info' argument 2 names different: declaration '' definition 'kills'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:184:44: style:inconclusive: Function 'add_kill_info' argument 4 names different: declaration 'c' definition 'category'. [funcArgNamesDifferent] stone_soup-0.34.1/source/kills.h:183:47: note: Function 'add_kill_info' argument 4 names different: declaration 'c' definition 'category'. stone_soup-0.34.1/source/kills.cc:184:44: note: Function 'add_kill_info' argument 4 names different: declaration 'c' definition 'category'. stone_soup-0.34.1/source/kills.cc:300:40: style:inconclusive: Function 'get_kills' argument 1 names different: declaration 'v' definition 'all_kills'. [funcArgNamesDifferent] stone_soup-0.34.1/source/kills.h:142:37: note: Function 'get_kills' argument 1 names different: declaration 'v' definition 'all_kills'. stone_soup-0.34.1/source/kills.cc:300:40: note: Function 'get_kills' argument 1 names different: declaration 'v' definition 'all_kills'. stone_soup-0.34.1/source/kills.cc:321:26: style:inconclusive: Function 'save' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:338:26: style:inconclusive: Function 'load' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:439:46: style:inconclusive: Function 'merge' argument 2 names different: declaration 'unique_monster' definition 'uniq'. [funcArgNamesDifferent] stone_soup-0.34.1/source/kills.h:67:40: note: Function 'merge' argument 2 names different: declaration 'unique_monster' definition 'uniq'. stone_soup-0.34.1/source/kills.cc:439:46: note: Function 'merge' argument 2 names different: declaration 'unique_monster' definition 'uniq'. stone_soup-0.34.1/source/kills.cc:551:29: style:inconclusive: Function 'save' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:561:29: style:inconclusive: Function 'load' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:611:31: style:inconclusive: Function 'save' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:618:31: style:inconclusive: Function 'load' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:630:53: style:inconclusive: Function 'kill_monster_desc' argument 1 names different: declaration '' definition 'mon'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:659:58: style:inconclusive: Function 'kill_monster_desc' argument 1 names different: declaration '' definition 'mon'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:687:38: style:inconclusive: Function 'save' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:693:38: style:inconclusive: Function 'load' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/kills.cc:737:15: style: Variable 'ke' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/kills.cc:776:15: style: Variable 'ke' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/kills.cc:793:15: style: Variable 'ke' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/kills.cc:829:15: style: Variable 'ke' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/kills.cc:889:15: style: Variable 'ke' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/kills.cc:935:19: style: Variable 'ke' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/kills.cc:314:19: style: Consider using std::copy algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/known-items.cc:187:5: style: Class 'KnownEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/known-items.cc:294:5: style: Class 'UnknownEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/known-items.cc:294:28: style: Parameter 'inv' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/known-items.cc:531:12: style: Variable 'ml' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/initfile.cc:4666:25: style:inconclusive: Technically the member function 'base_game_options::report_error' can be const. [functionConst] stone_soup-0.34.1/source/options.h:383:10: note: Technically the member function 'base_game_options::report_error' can be const. stone_soup-0.34.1/source/initfile.cc:4666:25: note: Technically the member function 'base_game_options::report_error' can be const. stone_soup-0.34.1/source/initfile.cc:1016:45: style: The member function 'base_game_options::build_options_map' can be static. [functionStatic] stone_soup-0.34.1/source/options.h:398:30: note: The member function 'base_game_options::build_options_map' can be static. stone_soup-0.34.1/source/initfile.cc:1016:45: note: The member function 'base_game_options::build_options_map' can be static. stone_soup-0.34.1/source/initfile.cc:2012:24: style: The member function 'game_options::parse_mon_glyph' can be static. [functionStatic] stone_soup-0.34.1/source/options.h:1013:14: note: The member function 'game_options::parse_mon_glyph' can be static. stone_soup-0.34.1/source/initfile.cc:2012:24: note: The member function 'game_options::parse_mon_glyph' can be static. stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption < std :: string , std :: string >::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption < species_type , OptFunctor < decltype ( & _str_to_species ) , & _str_to_species > >::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption < job_type , OptFunctor < decltype ( & str_to_job ) , & str_to_job > >::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption < weapon_type , OptFunctor < decltype ( & str_to_weapon ) , & str_to_weapon > >::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption < text_pattern , text_pattern >::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption < message_filter , message_filter >::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption < message_colour_mapping , message_colour_mapping >::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption < colour_mapping , colour_mapping >::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption < std :: pair < text_pattern , std :: string > , OptFunctor < decltype ( & _slot_mapping ) , & _slot_mapping > >::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption < std :: pair < std :: string , char > , OptFunctor < decltype ( & _consumable_mapping ) , & _consumable_mapping > >::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption < mlc_mapping , mlc_mapping >::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption < sound_mapping , sound_mapping >::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/game-options.h:437:7: style: The member function 'ListGameOption < sound_mapping , OptFunctor < decltype ( & _interrupt_sound_mapping ) , & _interrupt_sound_mapping > >::element_from_string' can be static. [functionStatic] stone_soup-0.34.1/source/options.h:414:10: style: Virtual function 'reset_options' is called from constructor 'game_options()' at line 2652. Dynamic binding is not used. [virtualCallInConstructor] stone_soup-0.34.1/source/initfile.cc:2652:5: note: Calling reset_options stone_soup-0.34.1/source/options.h:414:10: note: reset_options is a virtual function stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < newgame_def >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < std :: map < std :: string , std :: string > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/initfile.cc:4486:11: style: Condition 'lc[0]' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/initfile.cc:5159:17: portability: %d in format string (no. 2) requires 'int' but the argument type is 'plen_t {aka unsigned int}'. [invalidPrintfArgType_sint] stone_soup-0.34.1/source/initfile.cc:5159:17: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] stone_soup-0.34.1/source/initfile.cc:6089:13: style: Statements following noreturn function 'print_save_json()' will never be executed. [unreachableCode] stone_soup-0.34.1/source/initfile.cc:5694:10: style: The scope of the variable 'nextUsed' can be reduced. [variableScope] stone_soup-0.34.1/source/initfile.cc:1017:32: style:inconclusive: Function 'build_options_map' argument 1 names different: declaration 'opts' definition 'options'. [funcArgNamesDifferent] stone_soup-0.34.1/source/options.h:398:75: note: Function 'build_options_map' argument 1 names different: declaration 'opts' definition 'options'. stone_soup-0.34.1/source/initfile.cc:1017:32: note: Function 'build_options_map' argument 1 names different: declaration 'opts' definition 'options'. stone_soup-0.34.1/source/initfile.cc:1118:34: style:inconclusive: Function 'str_to_channel' argument 1 names different: declaration '' definition 'str'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/initfile.cc:1137:27: style:inconclusive: Function 'channel_to_str' argument 1 names different: declaration 'ch' definition 'channel'. [funcArgNamesDifferent] stone_soup-0.34.1/source/initfile.h:83:27: note: Function 'channel_to_str' argument 1 names different: declaration 'ch' definition 'channel'. stone_soup-0.34.1/source/initfile.cc:1137:27: note: Function 'channel_to_str' argument 1 names different: declaration 'ch' definition 'channel'. stone_soup-0.34.1/source/initfile.cc:1858:49: style:inconclusive: Function 'set_fire_order' argument 1 names different: declaration 'full' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/options.h:995:39: note: Function 'set_fire_order' argument 1 names different: declaration 'full' definition 's'. stone_soup-0.34.1/source/initfile.cc:1858:49: note: Function 'set_fire_order' argument 1 names different: declaration 'full' definition 's'. stone_soup-0.34.1/source/options.h:1020:57: style:inconclusive: Function 'add_force_spell_targeter' argument 2 names different: declaration 'prepend' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/options.h:1022:59: style:inconclusive: Function 'add_force_ability_targeter' argument 2 names different: declaration 'prepend' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/options.h:1024:58: style:inconclusive: Function 'add_force_scroll_targeter' argument 2 names different: declaration 'prepend' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/initfile.cc:2028:60: style:inconclusive: Function 'remove_mon_glyph_override' argument 1 names different: declaration '' definition 'text'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/initfile.cc:2049:57: style:inconclusive: Function 'add_mon_glyph_override' argument 1 names different: declaration '' definition 'text'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/options.h:1011:54: style:inconclusive: Function 'add_mon_glyph_override' argument 2 names different: declaration 'prepend' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/initfile.cc:2087:61: style:inconclusive: Function 'remove_item_glyph_override' argument 1 names different: declaration '' definition 'text'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/initfile.cc:2097:58: style:inconclusive: Function 'add_item_glyph_override' argument 1 names different: declaration '' definition 'text'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/initfile.cc:2116:58: style:inconclusive: Function 'remove_feature_override' argument 1 names different: declaration '' definition 'text'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/initfile.cc:2135:55: style:inconclusive: Function 'add_feature_override' argument 1 names different: declaration '' definition 'text'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/options.h:982:52: style:inconclusive: Function 'add_feature_override' argument 2 names different: declaration 'prepend' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/initfile.cc:2287:26: style:inconclusive: Function 'read_init_file' argument 1 names different: declaration 'runscript' definition 'runscripts'. [funcArgNamesDifferent] stone_soup-0.34.1/source/initfile.h:26:26: note: Function 'read_init_file' argument 1 names different: declaration 'runscript' definition 'runscripts'. stone_soup-0.34.1/source/initfile.cc:2287:26: note: Function 'read_init_file' argument 1 names different: declaration 'runscript' definition 'runscripts'. stone_soup-0.34.1/source/initfile.cc:2582:41: style:inconclusive: Function 'read_options' argument 2 names different: declaration 'runscript' definition 'runscripts'. [funcArgNamesDifferent] stone_soup-0.34.1/source/initfile.h:31:41: note: Function 'read_options' argument 2 names different: declaration 'runscript' definition 'runscripts'. stone_soup-0.34.1/source/initfile.cc:2582:41: note: Function 'read_options' argument 2 names different: declaration 'runscript' definition 'runscripts'. stone_soup-0.34.1/source/initfile.cc:2679:49: style:inconclusive: Function 'read_options' argument 1 names different: declaration '' definition 'il'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/initfile.cc:2880:49: style:inconclusive: Function 'add_alias' argument 1 names different: declaration 'alias' definition 'key'. [funcArgNamesDifferent] stone_soup-0.34.1/source/options.h:402:34: note: Function 'add_alias' argument 1 names different: declaration 'alias' definition 'key'. stone_soup-0.34.1/source/initfile.cc:2880:49: note: Function 'add_alias' argument 1 names different: declaration 'alias' definition 'key'. stone_soup-0.34.1/source/initfile.cc:2880:68: style:inconclusive: Function 'add_alias' argument 2 names different: declaration 'name' definition 'val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/options.h:402:55: note: Function 'add_alias' argument 2 names different: declaration 'name' definition 'val'. stone_soup-0.34.1/source/initfile.cc:2880:68: note: Function 'add_alias' argument 2 names different: declaration 'name' definition 'val'. stone_soup-0.34.1/source/initfile.cc:3372:46: style:inconclusive: Function 'message_filter' argument 1 names different: declaration 's' definition 'filter'. [funcArgNamesDifferent] stone_soup-0.34.1/source/options.h:81:34: note: Function 'message_filter' argument 1 names different: declaration 's' definition 'filter'. stone_soup-0.34.1/source/initfile.cc:3372:46: note: Function 'message_filter' argument 1 names different: declaration 's' definition 'filter'. stone_soup-0.34.1/source/options.h:403:52: style:inconclusive: Function 'set_option_fragment' argument 2 names different: declaration 'prepend' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/initfile.cc:3776:42: style:inconclusive: Function 'split_parse' argument 4 names different: declaration '' definition 'remove'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/initfile.cc:3777:26: style:inconclusive: Function 'split_parse' argument 5 names different: declaration '' definition 'case_sensitive'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/initfile.cc:3835:56: style:inconclusive: Function 'read_option_line' argument 1 names different: declaration 's' definition 'str'. [funcArgNamesDifferent] stone_soup-0.34.1/source/options.h:333:41: note: Function 'read_option_line' argument 1 names different: declaration 's' definition 'str'. stone_soup-0.34.1/source/initfile.cc:3835:56: note: Function 'read_option_line' argument 1 names different: declaration 's' definition 'str'. stone_soup-0.34.1/source/options.h:334:54: style:inconclusive: Function 'read_custom_option' argument 1 names different: declaration 'state' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/options.h:334:66: style:inconclusive: Function 'read_custom_option' argument 2 names different: declaration 'runscripts' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/initfile.cc:4478:41: style:inconclusive: Function 'set_lang' argument 1 names different: declaration 's' definition 'lc'. [funcArgNamesDifferent] stone_soup-0.34.1/source/options.h:1016:31: note: Function 'set_lang' argument 1 names different: declaration 's' definition 'lc'. stone_soup-0.34.1/source/initfile.cc:4478:41: note: Function 'set_lang' argument 1 names different: declaration 's' definition 'lc'. stone_soup-0.34.1/source/initfile.cc:4572:50: style:inconclusive: Function 'resolve_include' argument 1 names different: declaration 'including_file' definition 'parent_file'. [funcArgNamesDifferent] stone_soup-0.34.1/source/options.h:379:42: note: Function 'resolve_include' argument 1 names different: declaration 'including_file' definition 'parent_file'. stone_soup-0.34.1/source/initfile.cc:4572:50: note: Function 'resolve_include' argument 1 names different: declaration 'including_file' definition 'parent_file'. stone_soup-0.34.1/source/initfile.cc:4640:47: style:inconclusive: Function 'include' argument 1 names different: declaration 'file' definition 'rawfilename'. [funcArgNamesDifferent] stone_soup-0.34.1/source/options.h:376:32: note: Function 'include' argument 1 names different: declaration 'file' definition 'rawfilename'. stone_soup-0.34.1/source/initfile.cc:4640:47: note: Function 'include' argument 1 names different: declaration 'file' definition 'rawfilename'. stone_soup-0.34.1/source/initfile.cc:6260:52: style:inconclusive: Function 'menu_sort_condition' argument 1 names different: declaration 'mt' definition '_mt'. [funcArgNamesDifferent] stone_soup-0.34.1/source/externs.h:311:35: note: Function 'menu_sort_condition' argument 1 names different: declaration 'mt' definition '_mt'. stone_soup-0.34.1/source/initfile.cc:6260:52: note: Function 'menu_sort_condition' argument 1 names different: declaration 'mt' definition '_mt'. stone_soup-0.34.1/source/initfile.cc:6260:61: style:inconclusive: Function 'menu_sort_condition' argument 2 names different: declaration 'sort' definition '_sort'. [funcArgNamesDifferent] stone_soup-0.34.1/source/externs.h:311:64: note: Function 'menu_sort_condition' argument 2 names different: declaration 'sort' definition '_sort'. stone_soup-0.34.1/source/initfile.cc:6260:61: note: Function 'menu_sort_condition' argument 2 names different: declaration 'sort' definition '_sort'. stone_soup-0.34.1/source/initfile.cc:4659:37: style: Local variable 'unalias' shadows outer function [shadowFunction] stone_soup-0.34.1/source/options.h:400:12: note: Shadowed declaration stone_soup-0.34.1/source/initfile.cc:4659:37: note: Shadow variable stone_soup-0.34.1/source/initfile.cc:5315:14: style: Local variable 'end' shadows outer function [shadowFunction] stone_soup-0.34.1/source/end.h:14:15: note: Shadowed declaration stone_soup-0.34.1/source/initfile.cc:5315:14: note: Shadow variable stone_soup-0.34.1/source/initfile.cc:1021:21: performance: Range variable 'name' should be declared as const reference. [iterateByValue] stone_soup-0.34.1/source/initfile.cc:1509:48: performance: Function parameter 'suffix' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/initfile.cc:1518:37: performance: Function parameter 'subdir' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/initfile.cc:2221:27: performance: Range variable 'rc_fn' should be declared as const reference. [iterateByValue] stone_soup-0.34.1/source/initfile.cc:3586:29: performance: Function parameter 'field' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/initfile.cc:4473:47: performance: Function parameter 'ld' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/initfile.cc:5192:70: performance: Function parameter 'ghosts' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/initfile.cc:5209:60: performance: Function parameter 'name_match' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/initfile.cc:5268:41: performance: Function parameter 'filename' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/initfile.cc:5268:64: performance: Function parameter 'remove' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/initfile.cc:5278:15: performance: Range variable 'g' should be declared as const reference. [iterateByValue] stone_soup-0.34.1/source/initfile.cc:5309:47: performance: Function parameter 'files' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/initfile.cc:5309:67: performance: Function parameter 'out_name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/initfile.cc:5312:15: performance: Range variable 'filename' should be declared as const reference. [iterateByValue] stone_soup-0.34.1/source/initfile.cc:1432:50: style: Variable 'refints' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/initfile.cc:3171:23: style: Variable 'pattern' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/initfile.cc:3203:18: style: Variable 'str' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/initfile.cc:6324:51: style: Parameter 's' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/initfile.cc:2275:21: style: Variable 'other_o' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/initfile.cc:6285:7: style: Variable 'menu_type_map' can be declared as const array [constVariable] stone_soup-0.34.1/source/initfile.cc:4472:42: error: Out of bounds access of data, index 'data.size()' is out of bounds. [containerOutOfBoundsIndexExpression] stone_soup-0.34.1/source/initfile.cc:2741:23: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/initfile.cc:2760:19: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/initfile.cc:2785:23: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/initfile.cc:3692:19: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/initfile.cc:3698:19: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/initfile.cc:3704:19: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/initfile.cc:3709:19: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/initfile.cc:1130:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/initfile.cc:1873:15: style: Consider using std::any_of, std::all_of, std::none_of, or std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/initfile.cc:3539:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/initfile.cc:4493:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/initfile.cc:2866:32: style: Variable 'clua_error_printed' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/initfile.cc:5694:19: style: Variable 'nextUsed' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/l-file.cc:25:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_TNIL [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/l-file.cc:241:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_TNIL [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/l-file.cc:56:13: style: Variable 'th' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/l-file.cc:91:12: performance: Assigning the result of c_str() to a std::string is slow and redundant. [stlcstrAssignment] stone_soup-0.34.1/source/l-dgnmon.cc:173:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable random_mons [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/l-los.cc:57:5: error: Invalid lua_pushinteger() argument nr 2. A non-boolean value is required. [invalidFunctionArgBool] stone_soup-0.34.1/source/l-los.cc:75:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-los.cc:83:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-los.cc:91:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-los.cc:98:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-los.cc:75:5: style: Variable 'ray' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-los.cc:83:5: style: Variable 'ray' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-los.cc:98:5: style: Variable 'ray' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-dgntil.cc:42:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable rock_tile [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/l-dgntil.cc:50:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable floor_tile [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/l-dgntil.cc:40:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-dgntil.cc:48:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-global.cc:62:19: style: Variable 'tp' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/l-mapgrd.cc:19:21: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-mapgrd.cc:39:23: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-mapgrd.cc:56:11: style: Variable 'gly' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-item.cc:410:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_TSTRING [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/l-item.cc:557:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_LOCHABER_AXE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/l-item.cc:1297:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable base_type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/l-option.cc:102:17: style: Variable 'value' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-option.cc:88:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/l-mapmrk.cc:11:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-mapmrk.cc:19:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-mapmrk.cc:27:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-mapmrk.cc:34:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-mapmrk.cc:11:5: style: Variable 'mark' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-mapmrk.cc:34:5: style: Variable 'mark' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/mon-act.h:20:10: style:inconclusive: Technically the member function 'MonsterActionQueueCompare::operator()' can be const. [functionConst] stone_soup-0.34.1/source/l-mons.cc:575:5: style: Variable '___mw' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-mons.cc:582:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/l-item.cc:1545:28: style: Local variable 'items' shadows outer function [shadowFunction] stone_soup-0.34.1/source/makeitem.h:19:5: note: Shadowed declaration stone_soup-0.34.1/source/l-item.cc:1545:28: note: Shadow variable stone_soup-0.34.1/source/l-item.cc:1567:18: style: Local variable 'shop' shadows outer function [shadowFunction] stone_soup-0.34.1/source/shopping.h:30:6: note: Shadowed declaration stone_soup-0.34.1/source/l-item.cc:1567:18: note: Shadow variable stone_soup-0.34.1/source/l-item.cc:1574:28: style: Local variable 'items' shadows outer function [shadowFunction] stone_soup-0.34.1/source/makeitem.h:19:5: note: Shadowed declaration stone_soup-0.34.1/source/l-item.cc:1574:28: note: Shadow variable stone_soup-0.34.1/source/l-item.cc:1613:34: style: Local variable 'items' shadows outer function [shadowFunction] stone_soup-0.34.1/source/makeitem.h:19:5: note: Shadowed declaration stone_soup-0.34.1/source/l-item.cc:1613:34: note: Shadow variable stone_soup-0.34.1/source/l-item.cc:1657:11: style: Variable 'acq_items' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/l-item.cc:77:19: style: Variable 'iwrap' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-item.cc:191:5: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-item.cc:298:5: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-item.cc:345:5: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-item.cc:366:5: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-item.cc:407:51: style: Parameter 'item' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/l-item.cc:491:14: style: Variable 'second' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-item.cc:881:5: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-item.cc:1046:5: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-item.cc:1065:5: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-item.cc:1086:5: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-item.cc:1114:5: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-item.cc:1336:38: style: Parameter 'item' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/l-item.cc:1567:18: style: Variable 'shop' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/l-item.cc:1842:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/l-subvault.cc:10:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-subvault.cc:18:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-subvault.cc:26:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/l-subvault.cc:37:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/lang-fake.cc:245:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/lang-fake.cc:432:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/wiz-fsim.h:14:5: style: Struct 'fight_damage_stats' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/libutil.cc:128:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libutil.cc:177:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libutil.cc:200:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libutil.cc:310:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libutil.cc:685:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdin [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libutil.cc:699:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIG_IGN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libutil.cc:731:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIG_DFL [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libutil.cc:254:9: style: The scope of the variable 'res' can be reduced. [variableScope] stone_soup-0.34.1/source/los-def.cc:22:33: style:inconclusive: Function 'los_def' argument 1 names different: declaration 'l' definition 'los'. [funcArgNamesDifferent] stone_soup-0.34.1/source/los-def.h:16:28: note: Function 'los_def' argument 1 names different: declaration 'l' definition 'los'. stone_soup-0.34.1/source/los-def.cc:22:33: note: Function 'los_def' argument 1 names different: declaration 'l' definition 'los'. stone_soup-0.34.1/source/los-def.cc:28:44: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'l' definition 'los'. [funcArgNamesDifferent] stone_soup-0.34.1/source/los-def.h:18:39: note: Function 'operator=' argument 1 names different: declaration 'l' definition 'los'. stone_soup-0.34.1/source/los-def.cc:28:44: note: Function 'operator=' argument 1 names different: declaration 'l' definition 'los'. stone_soup-0.34.1/source/los-def.cc:38:37: style:inconclusive: Function 'init' argument 1 names different: declaration 'center' definition 'c'. [funcArgNamesDifferent] stone_soup-0.34.1/source/los-def.h:19:32: note: Function 'init' argument 1 names different: declaration 'center' definition 'c'. stone_soup-0.34.1/source/los-def.cc:38:37: note: Function 'init' argument 1 names different: declaration 'center' definition 'c'. stone_soup-0.34.1/source/los-def.cc:57:43: style:inconclusive: Function 'set_center' argument 1 names different: declaration 'center' definition 'c'. [funcArgNamesDifferent] stone_soup-0.34.1/source/los-def.h:21:38: note: Function 'set_center' argument 1 names different: declaration 'center' definition 'c'. stone_soup-0.34.1/source/los-def.cc:57:43: note: Function 'set_center' argument 1 names different: declaration 'center' definition 'c'. stone_soup-0.34.1/source/libutil.cc:44:33: style:inconclusive: Function 'isqrt' argument 1 names different: declaration 'x' definition 'a'. [funcArgNamesDifferent] stone_soup-0.34.1/source/libutil.h:255:33: note: Function 'isqrt' argument 1 names different: declaration 'x' definition 'a'. stone_soup-0.34.1/source/libutil.cc:44:33: note: Function 'isqrt' argument 1 names different: declaration 'x' definition 'a'. stone_soup-0.34.1/source/libutil.cc:116:51: style:inconclusive: Function 'strip_tag' argument 3 names different: declaration 'nopad' definition 'skip_padding'. [funcArgNamesDifferent] stone_soup-0.34.1/source/libutil.h:102:51: note: Function 'strip_tag' argument 3 names different: declaration 'nopad' definition 'skip_padding'. stone_soup-0.34.1/source/libutil.cc:116:51: note: Function 'strip_tag' argument 3 names different: declaration 'nopad' definition 'skip_padding'. stone_soup-0.34.1/source/libutil.cc:293:36: style:inconclusive: Function 'version_is_stable' argument 1 names different: declaration 'ver' definition 'v'. [funcArgNamesDifferent] stone_soup-0.34.1/source/libutil.h:98:36: note: Function 'version_is_stable' argument 1 names different: declaration 'ver' definition 'v'. stone_soup-0.34.1/source/libutil.cc:293:36: note: Function 'version_is_stable' argument 1 names different: declaration 'ver' definition 'v'. stone_soup-0.34.1/source/libutil.cc:344:29: performance: Function parameter 'in' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/libutil.cc:145:16: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] stone_soup-0.34.1/source/libunix.cc:337:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WA_STANDOUT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:352:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COLOR_BLACK [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:439:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable VINTR [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:875:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ESCDELAY [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:910:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TCSAFLUSH [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:1001:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdscr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:1032:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LINES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:1040:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COLS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:1153:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WA_BOLD [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:1290:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COLOR_BLACK [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:1317:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COLORS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:1411:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COLOR_WHITE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:1490:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COLOR_WHITE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:1580:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COLOR_BLACK [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:1698:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COLOR_WHITE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:1733:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COLOR_WHITE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:1822:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdscr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libunix.cc:1830:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdscr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/libutil.cc:402:18: style: Variable 'pos' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/libunix.cc:1849:9: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] stone_soup-0.34.1/source/libunix.cc:1529:31: style: The comparison 'default_colors_loaded == ERR' is always true because 'default_colors_loaded' and 'ERR' represent the same value. [knownConditionTrueFalse] stone_soup-0.34.1/source/libunix.cc:1493:33: note: 'default_colors_loaded' is assigned value 'ERR' here. stone_soup-0.34.1/source/libunix.cc:1529:31: note: The comparison 'default_colors_loaded == ERR' is always true because 'default_colors_loaded' and 'ERR' represent the same value. stone_soup-0.34.1/source/libunix.cc:943:22: style:inconclusive: Function 'putwch' argument 1 names different: declaration 'c' definition 'chr'. [funcArgNamesDifferent] stone_soup-0.34.1/source/libconsole.h:33:22: note: Function 'putwch' argument 1 names different: declaration 'c' definition 'chr'. stone_soup-0.34.1/source/libunix.cc:943:22: note: Function 'putwch' argument 1 names different: declaration 'c' definition 'chr'. stone_soup-0.34.1/source/libunix.cc:977:18: style:inconclusive: Function 'puttext' argument 1 names different: declaration 'x' definition 'x1'. [funcArgNamesDifferent] stone_soup-0.34.1/source/libconsole.h:37:18: note: Function 'puttext' argument 1 names different: declaration 'x' definition 'x1'. stone_soup-0.34.1/source/libunix.cc:977:18: note: Function 'puttext' argument 1 names different: declaration 'x' definition 'x1'. stone_soup-0.34.1/source/libunix.cc:977:26: style:inconclusive: Function 'puttext' argument 2 names different: declaration 'y' definition 'y1'. [funcArgNamesDifferent] stone_soup-0.34.1/source/libconsole.h:37:25: note: Function 'puttext' argument 2 names different: declaration 'y' definition 'y1'. stone_soup-0.34.1/source/libunix.cc:977:26: note: Function 'puttext' argument 2 names different: declaration 'y' definition 'y1'. stone_soup-0.34.1/source/libunix.cc:1601:21: style:inconclusive: Function 'textcolour' argument 1 names different: declaration 'c' definition 'col'. [funcArgNamesDifferent] stone_soup-0.34.1/source/libconsole.h:18:21: note: Function 'textcolour' argument 1 names different: declaration 'c' definition 'col'. stone_soup-0.34.1/source/libunix.cc:1601:21: note: Function 'textcolour' argument 1 names different: declaration 'c' definition 'col'. stone_soup-0.34.1/source/libunix.cc:1630:25: style:inconclusive: Function 'textbackground' argument 1 names different: declaration 'c' definition 'col'. [funcArgNamesDifferent] stone_soup-0.34.1/source/libconsole.h:19:25: note: Function 'textbackground' argument 1 names different: declaration 'c' definition 'col'. stone_soup-0.34.1/source/libunix.cc:1630:25: note: Function 'textbackground' argument 1 names different: declaration 'c' definition 'col'. stone_soup-0.34.1/source/libunix.cc:1833:25: style:inconclusive: Function 'delay' argument 1 names different: declaration 'ms' definition 'time'. [funcArgNamesDifferent] stone_soup-0.34.1/source/libconsole.h:36:25: note: Function 'delay' argument 1 names different: declaration 'ms' definition 'time'. stone_soup-0.34.1/source/libunix.cc:1833:25: note: Function 'delay' argument 1 names different: declaration 'ms' definition 'time'. stone_soup-0.34.1/source/nearby-danger.h:107:1: debug: SymbolDatabase couldn't resolve all user defined types. [debug] stone_soup-0.34.1/source/libunix.cc:425:19: style: Unused variable: pair [unusedVariable] stone_soup-0.34.1/source/libunix.cc:1261:11: style: Unused variable: pair [unusedVariable] stone_soup-0.34.1/source/libunix.cc:1280:10: style: Unused variable: pair [unusedVariable] stone_soup-0.34.1/source/l-you.cc:1601:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_TNIL [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/l-you.cc:1849:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/l-you.cc:1954:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_TNIL [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/luaterp.cc:27:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_ERRSYNTAX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/luaterp.cc:91:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUA_MULTRET [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/maps.cc:36:3: error: #error BYTE_ORDER is not defined [preprocessorErrorDirective] stone_soup-0.34.1/source/nearby-danger.h:157:5: warning:inconclusive: Member variable 'coord_wrapper::test' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/maybe-bool.cc:28:17: style: Variable 'n' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/maybe-bool.cc:29:17: style: Variable 'y' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/maybe-bool.cc:30:23: style: Variable 'm' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/macro.cc:438:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/macro.cc:1033:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable remap_numpad [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/macro.cc:1239:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable remap_numpad [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/macro.cc:2224:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/macro.cc:2360:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/nearby-danger.h:97:10: style:inconclusive: Technically the member function 'path_less::operator()' can be const. [functionConst] stone_soup-0.34.1/source/nearby-danger.h:147:5: style: Struct 'coord_wrapper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/l-you.cc:1438:22: performance: Assigning the result of c_str() to a std::string is slow and redundant. [stlcstrAssignment] stone_soup-0.34.1/source/macro.cc:1151:12: style:inconclusive: Technically the member function 'MacroEditMenu::mode_name' can be const. [functionConst] stone_soup-0.34.1/source/macro.cc:1398:14: style: The function 'process_key' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/menu.h:391:18: note: Virtual function in base class stone_soup-0.34.1/source/macro.cc:1398:14: note: Function in derived class stone_soup-0.34.1/source/macro.cc:1418:78: style: Condition 'keyin==CK_MOUSE_B2' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/macro.cc:1450:78: style: Condition 'keyin==CK_MOUSE_B2' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/macro.cc:2174:17: style: Condition 'cmd==CMD_NO_CMD' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/macro.cc:2169:20: note: Assuming that condition 'CMD_NO_CMD<-key' is not redundant stone_soup-0.34.1/source/macro.cc:2171:51: note: Assignment 'cmd=static_cast(-key)', assigned value is greater than 2000 stone_soup-0.34.1/source/macro.cc:2174:17: note: Condition 'cmd==CMD_NO_CMD' is always false stone_soup-0.34.1/source/macro.cc:1082:28: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/macro.cc:602:12: style: The scope of the variable 'tmp' can be reduced. [variableScope] stone_soup-0.34.1/source/macro.cc:1690:12: style: The scope of the variable 's' can be reduced. [variableScope] stone_soup-0.34.1/source/losparam.cc:128:15: style: Variable 'cell' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/losparam.cc:141:15: style: Variable 'cell' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/losparam.cc:160:15: style: Variable 'cell' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/losparam.cc:179:15: style: Variable 'cell' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/losparam.cc:192:15: style: Variable 'cell' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/macro.cc:851:26: style:inconclusive: Function 'getchm' argument 1 names different: declaration 'context' definition 'mc'. [funcArgNamesDifferent] stone_soup-0.34.1/source/macro.h:43:26: note: Function 'getchm' argument 1 names different: declaration 'context' definition 'mc'. stone_soup-0.34.1/source/macro.cc:851:26: note: Function 'getchm' argument 1 names different: declaration 'context' definition 'mc'. stone_soup-0.34.1/source/macro.cc:2031:49: style:inconclusive: Function 'macro_userfn' argument 2 names different: declaration 'registryname' definition 'regname'. [funcArgNamesDifferent] stone_soup-0.34.1/source/macro.h:58:49: note: Function 'macro_userfn' argument 2 names different: declaration 'registryname' definition 'regname'. stone_soup-0.34.1/source/macro.cc:2031:49: note: Function 'macro_userfn' argument 2 names different: declaration 'registryname' definition 'regname'. stone_soup-0.34.1/source/macro.cc:398:28: performance: Function parameter 's' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/macro.cc:510:48: performance: Function parameter 'key' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/macro.cc:510:60: performance: Function parameter 'action' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/macro.cc:865:39: performance: Function parameter 'keys' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/macro.cc:1190:31: performance: Function parameter 'key' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/macro.cc:1531:30: performance: Function parameter 'key' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/macro.cc:2157:37: performance: Function parameter 'name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/macro.cc:993:43: style: Parameter 'action' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/macro.cc:2121:23: style: Variable 'data' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/macro.cc:2136:26: style: Variable 'data' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/macro.cc:165:15: style: Variable 'm' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/macro.cc:1220:17: style: Variable '_key_chosen' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/macro.cc:157:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/macro.cc:165:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/message-stream.cc:31:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable nounitbuf [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/macro.cc:1133:16: style: Unused variable: hint [unusedVariable] stone_soup-0.34.1/source/message-stream.cc:52:21: warning: Member variable 'mpr_stream_buf::internal_buf' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/message-stream.cc:48:41: style:inconclusive: Function 'capitalisation' argument 1 names different: declaration 'cap' definition 'capital'. [funcArgNamesDifferent] stone_soup-0.34.1/source/message.h:190:29: note: Function 'capitalisation' argument 1 names different: declaration 'cap' definition 'capital'. stone_soup-0.34.1/source/message-stream.cc:48:41: note: Function 'capitalisation' argument 1 names different: declaration 'cap' definition 'capital'. stone_soup-0.34.1/source/message-stream.cc:67:46: style:inconclusive: Function 'set_capitalise' argument 1 names different: declaration 'm' definition 'c'. [funcArgNamesDifferent] stone_soup-0.34.1/source/message.h:208:34: note: Function 'set_capitalise' argument 1 names different: declaration 'm' definition 'c'. stone_soup-0.34.1/source/message-stream.cc:67:46: note: Function 'set_capitalise' argument 1 names different: declaration 'm' definition 'c'. stone_soup-0.34.1/source/makeitem.cc:1943:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_OLGREB [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/random-pick.h:116:28: style: The member function 'random_picker < int , 11 >::rarity_at' can be static. [functionStatic] stone_soup-0.34.1/source/random-pick.h:38:9: note: The member function 'random_picker < int , 11 >::rarity_at' can be static. stone_soup-0.34.1/source/random-pick.h:116:28: note: The member function 'random_picker < int , 11 >::rarity_at' can be static. stone_soup-0.34.1/source/makeitem.h:33:51: style:inconclusive: Function 'is_weapon_brand_ok' argument 3 names different: declaration 'strict' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/makeitem.cc:2017:18: performance: Function parameter 'custom_name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/menu.cc:125:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable expand_h [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:227:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:245:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:306:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable row [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:320:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable row [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:589:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable y [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:670:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_text [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:798:63: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:902:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:1218:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:1669:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACT_EXECUTE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:2834:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CYCLE_NONE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:2917:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:2935:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:2969:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:2979:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:3008:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:3067:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:3107:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:3211:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:3589:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable margin [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/menu.cc:3708:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACT_EXECUTE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/message.cc:1376:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable _1 [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/message.cc:1439:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/message.cc:1532:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/message.cc:1668:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/message.cc:2221:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable channel [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/message.cc:2266:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable channel [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/mon-aura.cc:90:24: performance: Range variable 'aura' should be declared as const reference. [iterateByValue] stone_soup-0.34.1/source/mon-aura.cc:99:48: performance: Function parameter 'player_key' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/mon-aura.cc:101:24: performance: Range variable 'aura' should be declared as const reference. [iterateByValue] stone_soup-0.34.1/source/mon-aura.cc:129:24: performance: Range variable 'aura' should be declared as const reference. [iterateByValue] stone_soup-0.34.1/source/mon-aura.cc:146:24: performance: Range variable 'aura' should be declared as const reference. [iterateByValue] stone_soup-0.34.1/source/mon-aura.cc:92:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/mon-aura.cc:103:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/mon-aura.cc:129:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/mon-aura.cc:146:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-save-info.h:18:5: warning: Member variable 'player_save_info::explore' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/menu.cc:112:5: warning: Member variable 'UIMenu::m_height' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/menu.cc:112:5: warning: Member variable 'UIMenu::m_nat_column_width' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/menu.cc:112:5: warning: Member variable 'Widget::cached_sr' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/menu.cc:112:5: warning: Member variable 'Widget::cached_sr_pw' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/message.cc:120:9: performance: Variable 'messages' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] stone_soup-0.34.1/source/message.cc:394:9: style: The member function 'message_window::height' can be static. [functionStatic] stone_soup-0.34.1/source/message.cc:404:9: style: The member function 'message_window::width' can be static. [functionStatic] stone_soup-0.34.1/source/message.cc:456:10: style: The member function 'message_window::more_enabled' can be static. [functionStatic] stone_soup-0.34.1/source/message.cc:554:10: style: The member function 'message_window::first_col_more' can be static. [functionStatic] stone_soup-0.34.1/source/message.cc:559:10: style: The member function 'message_window::use_first_col' can be static. [functionStatic] stone_soup-0.34.1/source/message.cc:672:10: style:inconclusive: Technically the member function 'message_window::any_messages' can be const. [functionConst] stone_soup-0.34.1/source/message.cc:872:20: style:inconclusive: Technically the member function 'message_store::get_store' can be const. [functionConst] stone_soup-0.34.1/source/message.cc:276:9: style: The member function 'circ_vec < message_line , 1000 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/menu.cc:3614:23: style: The member function 'column_composer::strip_blank_lines' can be static. [functionStatic] stone_soup-0.34.1/source/menu.h:533:10: note: The member function 'column_composer::strip_blank_lines' can be static. stone_soup-0.34.1/source/menu.cc:3614:23: note: The member function 'column_composer::strip_blank_lines' can be static. stone_soup-0.34.1/source/menu.cc:143:9: style:inconclusive: Either there is a missing 'override', or the member function 'UIMenu::get_min_col_width' can be const. [functionConst] stone_soup-0.34.1/source/menu.cc:146:9: style:inconclusive: Either there is a missing 'override', or the member function 'UIMenu::get_scroll_context' can be const. [functionConst] stone_soup-0.34.1/source/menu.cc:311:14: style:inconclusive: Either there is a missing 'override', or the member function 'UIMenu::get_item_region' can be const. [functionConst] stone_soup-0.34.1/source/menu.cc:154:10: note: Either there is a missing 'override', or the member function 'UIMenu::get_item_region' can be const. stone_soup-0.34.1/source/menu.cc:311:14: note: Either there is a missing 'override', or the member function 'UIMenu::get_item_region' can be const. stone_soup-0.34.1/source/menu.cc:291:14: style:inconclusive: Either there is a missing 'override', or the member function 'UIMenu::get_item_gridpos' can be const. [functionConst] stone_soup-0.34.1/source/menu.cc:155:10: note: Either there is a missing 'override', or the member function 'UIMenu::get_item_gridpos' can be const. stone_soup-0.34.1/source/menu.cc:291:14: note: Either there is a missing 'override', or the member function 'UIMenu::get_item_gridpos' can be const. stone_soup-0.34.1/source/menu.cc:669:9: debug: CheckClass::isMemberVar found used member variable 'm_text' with varid 0 [varid0] stone_soup-0.34.1/source/message.cc:724:29: style: Condition 'is_tiles()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/message.cc:724:29: note: Calling function 'is_tiles' returns 0 stone_soup-0.34.1/source/message.cc:724:29: note: Condition 'is_tiles()' is always false stone_soup-0.34.1/source/menu.cc:1180:22: warning: Class 'Menu' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] stone_soup-0.34.1/source/menu.cc:1180:22: warning: Class 'Menu' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] stone_soup-0.34.1/source/menu.h:317:18: style: Virtual function 'set_flags' is called from constructor 'Menu(int flags=MF_MULTISELECT,const std::string&tagname="",KeymapContext kmc=KMC_MENU)' at line 1204. Dynamic binding is not used. [virtualCallInConstructor] stone_soup-0.34.1/source/menu.cc:1204:5: note: Calling set_flags stone_soup-0.34.1/source/menu.h:317:18: note: set_flags is a virtual function stone_soup-0.34.1/source/menu.cc:112:5: style: Class 'UIMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/menu.cc:128:6: style: The destructor '~UIMenu' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:292:14: note: Virtual destructor in base class stone_soup-0.34.1/source/menu.cc:128:6: note: Destructor in derived class stone_soup-0.34.1/source/menu.cc:653:14: style: The destructor '~UIMenuScroller' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:981:14: note: Virtual destructor in base class stone_soup-0.34.1/source/menu.cc:653:14: note: Destructor in derived class stone_soup-0.34.1/source/menu.cc:665:14: style: The destructor '~UIMenuMore' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:743:14: note: Virtual destructor in base class stone_soup-0.34.1/source/menu.cc:665:14: note: Destructor in derived class stone_soup-0.34.1/source/menu.cc:747:14: style: The destructor '~UIMenuPopup' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:561:14: note: Virtual destructor in base class stone_soup-0.34.1/source/menu.cc:747:14: note: Destructor in derived class stone_soup-0.34.1/source/menu.h:525:30: performance: Function 'formatted_lines()' should return member 'flines' by const reference. [returnByReference] stone_soup-0.34.1/source/message.cc:1269:25: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/menu.cc:1584:12: style: Condition 'alive' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/menu.cc:1581:13: note: Assignment 'alive=true', assigned value is 1 stone_soup-0.34.1/source/menu.cc:1584:12: note: Condition 'alive' is always true stone_soup-0.34.1/source/menu.cc:2385:12: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/message.h:123:63: style:inconclusive: Function 'append' argument 2 names different: declaration 'ch' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/message.cc:1110:32: style:inconclusive: Function 'msg_colour' argument 1 names different: declaration 'colour' definition 'col'. [funcArgNamesDifferent] stone_soup-0.34.1/source/mpr.h:99:32: note: Function 'msg_colour' argument 1 names different: declaration 'colour' definition 'col'. stone_soup-0.34.1/source/message.cc:1110:32: note: Function 'msg_colour' argument 1 names different: declaration 'colour' definition 'col'. stone_soup-0.34.1/source/message.cc:44:50: performance: Function parameter 'text' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/message.cc:877:31: performance: Function parameter 'store' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/message.cc:1613:34: performance: Function parameter 'prompt' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/message.cc:1623:27: performance: Function parameter 'prompt' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/message.cc:324:41: performance: Function parameter 'buf' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/message.cc:203:20: style: Variable 'msg' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/message.cc:217:20: style: Variable 'msg' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/menu.cc:3527:9: style: The scope of the variable 'lastcol' can be reduced. [variableScope] stone_soup-0.34.1/source/menu.cc:3546:9: style: The scope of the variable 'lastcol' can be reduced. [variableScope] stone_soup-0.34.1/source/message.cc:1834:13: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/menu.cc:1175:16: style:inconclusive: Function 'Menu' argument 1 names different: declaration 'flags' definition '_flags'. [funcArgNamesDifferent] stone_soup-0.34.1/source/menu.h:310:14: note: Function 'Menu' argument 1 names different: declaration 'flags' definition '_flags'. stone_soup-0.34.1/source/menu.cc:1175:16: note: Function 'Menu' argument 1 names different: declaration 'flags' definition '_flags'. stone_soup-0.34.1/source/menu.cc:1284:45: style:inconclusive: Function 'set_more' argument 1 names different: declaration 'more' definition 'fs'. [funcArgNamesDifferent] stone_soup-0.34.1/source/menu.h:324:43: note: Function 'set_more' argument 1 names different: declaration 'more' definition 'fs'. stone_soup-0.34.1/source/menu.cc:1284:45: note: Function 'set_more' argument 1 names different: declaration 'more' definition 'fs'. stone_soup-0.34.1/source/menu.cc:1457:45: style:inconclusive: Function 'set_highlighter' argument 1 names different: declaration 'h' definition 'mh'. [funcArgNamesDifferent] stone_soup-0.34.1/source/menu.h:332:43: note: Function 'set_highlighter' argument 1 names different: declaration 'h' definition 'mh'. stone_soup-0.34.1/source/menu.cc:1457:45: note: Function 'set_highlighter' argument 1 names different: declaration 'h' definition 'mh'. stone_soup-0.34.1/source/menu.cc:1604:27: style:inconclusive: Function 'pre_process' argument 1 names different: declaration 'key' definition 'k'. [funcArgNamesDifferent] stone_soup-0.34.1/source/menu.h:473:33: note: Function 'pre_process' argument 1 names different: declaration 'key' definition 'k'. stone_soup-0.34.1/source/menu.cc:1604:27: note: Function 'pre_process' argument 1 names different: declaration 'key' definition 'k'. stone_soup-0.34.1/source/menu.h:450:48: style:inconclusive: Function 'get_select_count_string' argument 1 names different: declaration 'count' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/menu.cc:2121:45: style:inconclusive: Function 'get_selected' argument 1 names different: declaration 'sel' definition 'selected'. [funcArgNamesDifferent] stone_soup-0.34.1/source/menu.h:340:43: note: Function 'get_selected' argument 1 names different: declaration 'sel' definition 'selected'. stone_soup-0.34.1/source/menu.cc:2121:45: note: Function 'get_selected' argument 1 names different: declaration 'sel' definition 'selected'. stone_soup-0.34.1/source/menu.cc:2181:26: style:inconclusive: Function 'is_hotkey' argument 1 names different: declaration 'index' definition 'i'. [funcArgNamesDifferent] stone_soup-0.34.1/source/menu.h:485:24: note: Function 'is_hotkey' argument 1 names different: declaration 'index' definition 'i'. stone_soup-0.34.1/source/menu.cc:2181:26: note: Function 'is_hotkey' argument 1 names different: declaration 'index' definition 'i'. stone_soup-0.34.1/source/menu.h:190:46: style:inconclusive: Function 'get_tiles' argument 1 names different: declaration 'tileset' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/menu.cc:2641:30: style:inconclusive: Function 'is_selectable' argument 1 names different: declaration 'index' definition 'item'. [funcArgNamesDifferent] stone_soup-0.34.1/source/menu.h:486:36: note: Function 'is_selectable' argument 1 names different: declaration 'index' definition 'item'. stone_soup-0.34.1/source/menu.cc:2641:30: note: Function 'is_selectable' argument 1 names different: declaration 'index' definition 'item'. stone_soup-0.34.1/source/menu.cc:2821:40: style:inconclusive: Function 'item_colour' argument 1 names different: declaration 'me' definition 'entry'. [funcArgNamesDifferent] stone_soup-0.34.1/source/menu.h:369:46: note: Function 'item_colour' argument 1 names different: declaration 'me' definition 'entry'. stone_soup-0.34.1/source/menu.cc:2821:40: note: Function 'item_colour' argument 1 names different: declaration 'me' definition 'entry'. stone_soup-0.34.1/source/menu.cc:3491:31: style:inconclusive: Function 'menu_colour' argument 1 names different: declaration 'itemtext' definition 'text'. [funcArgNamesDifferent] stone_soup-0.34.1/source/menu.h:91:31: note: Function 'menu_colour' argument 1 names different: declaration 'itemtext' definition 'text'. stone_soup-0.34.1/source/menu.cc:3491:31: note: Function 'menu_colour' argument 1 names different: declaration 'itemtext' definition 'text'. stone_soup-0.34.1/source/menu.cc:3518:38: style:inconclusive: Function 'column_composer' argument 1 names different: declaration 'ncols' definition 'cols'. [funcArgNamesDifferent] stone_soup-0.34.1/source/menu.h:514:25: note: Function 'column_composer' argument 1 names different: declaration 'ncols' definition 'cols'. stone_soup-0.34.1/source/menu.cc:3518:38: note: Function 'column_composer' argument 1 names different: declaration 'ncols' definition 'cols'. stone_soup-0.34.1/source/menu.cc:3563:51: style:inconclusive: Function 'add_formatted' argument 2 names different: declaration 'tagged_text' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/menu.h:519:27: note: Function 'add_formatted' argument 2 names different: declaration 'tagged_text' definition 's'. stone_soup-0.34.1/source/menu.cc:3563:51: note: Function 'add_formatted' argument 2 names different: declaration 'tagged_text' definition 's'. stone_soup-0.34.1/source/menu.cc:3614:67: style:inconclusive: Function 'strip_blank_lines' argument 1 names different: declaration '' definition 'fs'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/menu.cc:3627:13: style:inconclusive: Function 'compose_formatted_column' argument 2 names different: declaration 'start_col' definition 'startline'. [funcArgNamesDifferent] stone_soup-0.34.1/source/menu.h:531:17: note: Function 'compose_formatted_column' argument 2 names different: declaration 'start_col' definition 'startline'. stone_soup-0.34.1/source/menu.cc:3627:13: note: Function 'compose_formatted_column' argument 2 names different: declaration 'start_col' definition 'startline'. stone_soup-0.34.1/source/menu.cc:1292:34: performance: Function parameter 's' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/menu.cc:1631:79: performance: Function parameter 'help_tag' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/menu.cc:3540:56: performance: Function parameter 'widths' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/menu.cc:2718:26: style: Variable 'item' can be declared as pointer to const [constVariableReference] stone_soup-0.34.1/source/menu.cc:2731:22: style: Variable 'item' can be declared as pointer to const [constVariableReference] stone_soup-0.34.1/source/menu.cc:2852:32: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] stone_soup-0.34.1/source/menu.cc:270:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/menu.cc:2127:21: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/menu.cc:2213:13: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/menu.cc:2647:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/menu.cc:3581:18: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/message.cc:785:31: style: Variable 'orig_full_text' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/menu.cc:2935:19: style: Variable 'vph' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/menu.cc:3527:17: style: Variable 'lastcol' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/menu.cc:3533:17: style: Variable 'lastcol' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/menu.cc:3546:17: style: Variable 'lastcol' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/menu.cc:3552:17: style: Variable 'lastcol' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/mon-gear.cc:1258:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_ARC_BLADE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/mon-gear.cc:1692:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flags [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/mon-gear.cc:1725:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_DISPATER [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/mon-gear.cc:2079:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_DRAGON_KING [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/mon-pick.cc:84:48: style:inconclusive: Function 'pick_monster_from' argument 3 names different: declaration '' definition 'veto'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/mon-pick.cc:197:35: style:inconclusive: Function 'branch_zombie_cap' argument 1 names different: declaration 'branch' definition 'br'. [funcArgNamesDifferent] stone_soup-0.34.1/source/mon-pick.h:29:35: note: Function 'branch_zombie_cap' argument 1 names different: declaration 'branch' definition 'br'. stone_soup-0.34.1/source/mon-pick.cc:197:35: note: Function 'branch_zombie_cap' argument 1 names different: declaration 'branch' definition 'br'. stone_soup-0.34.1/source/mon-pick.cc:216:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/mon-pick.cc:221:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/mon-pick.cc:224:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/mon-pick.cc:228:13: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/mon-pick.cc:247:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/mon-pick.cc:259:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/mon-gear.cc:2348:15: style: The scope of the variable 'i' can be reduced. [variableScope] stone_soup-0.34.1/source/mon-gear.cc:304:35: style:inconclusive: Function 'make_mons_weapon' argument 1 names different: declaration 'mtyp' definition 'type'. [funcArgNamesDifferent] stone_soup-0.34.1/source/mon-gear.h:16:35: note: Function 'make_mons_weapon' argument 1 names different: declaration 'mtyp' definition 'type'. stone_soup-0.34.1/source/mon-gear.cc:304:35: note: Function 'make_mons_weapon' argument 1 names different: declaration 'mtyp' definition 'type'. stone_soup-0.34.1/source/mon-gear.cc:1908:35: style:inconclusive: Function 'make_mons_armour' argument 1 names different: declaration 'mtyp' definition 'type'. [funcArgNamesDifferent] stone_soup-0.34.1/source/mon-gear.h:18:35: note: Function 'make_mons_armour' argument 1 names different: declaration 'mtyp' definition 'type'. stone_soup-0.34.1/source/mon-gear.cc:1908:35: note: Function 'make_mons_armour' argument 1 names different: declaration 'mtyp' definition 'type'. stone_soup-0.34.1/source/mon-gear.cc:2377:27: style:inconclusive: Function 'give_weapon' argument 1 names different: declaration 'mon' definition 'mons'. [funcArgNamesDifferent] stone_soup-0.34.1/source/mon-gear.h:17:27: note: Function 'give_weapon' argument 1 names different: declaration 'mon' definition 'mons'. stone_soup-0.34.1/source/mon-gear.cc:2377:27: note: Function 'give_weapon' argument 1 names different: declaration 'mon' definition 'mons'. stone_soup-0.34.1/source/mon-gear.cc:2382:27: style:inconclusive: Function 'give_armour' argument 1 names different: declaration 'mon' definition 'mons'. [funcArgNamesDifferent] stone_soup-0.34.1/source/mon-gear.h:19:27: note: Function 'give_armour' argument 1 names different: declaration 'mon' definition 'mons'. stone_soup-0.34.1/source/mon-gear.cc:2382:27: note: Function 'give_armour' argument 1 names different: declaration 'mon' definition 'mons'. stone_soup-0.34.1/source/mon-gear.cc:2387:27: style:inconclusive: Function 'give_shield' argument 1 names different: declaration 'mon' definition 'mons'. [funcArgNamesDifferent] stone_soup-0.34.1/source/mon-gear.h:20:27: note: Function 'give_shield' argument 1 names different: declaration 'mon' definition 'mons'. stone_soup-0.34.1/source/mon-gear.cc:2387:27: note: Function 'give_shield' argument 1 names different: declaration 'mon' definition 'mons'. stone_soup-0.34.1/source/mon-gear.cc:2412:25: style:inconclusive: Function 'give_item' argument 1 names different: declaration 'mon' definition 'mons'. [funcArgNamesDifferent] stone_soup-0.34.1/source/mon-gear.h:15:25: note: Function 'give_item' argument 1 names different: declaration 'mon' definition 'mons'. stone_soup-0.34.1/source/mon-gear.cc:2412:25: note: Function 'give_item' argument 1 names different: declaration 'mon' definition 'mons'. stone_soup-0.34.1/source/mon-gear.cc:1461:18: performance:inconclusive: Use const reference for 'twin_weapon' to avoid unnecessary data copying. [redundantCopyLocalConst] stone_soup-0.34.1/source/mon-gear.cc:2520:23: style: Variable 'weapon' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/mon-gear.cc:219:9: style: struct member 'plus_range::min' is never used. [unusedStructMember] stone_soup-0.34.1/source/mon-gear.cc:219:14: style: struct member 'plus_range::max' is never used. [unusedStructMember] stone_soup-0.34.1/source/mon-gear.cc:1860:16: style: Variable 'shield' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/mon-poly.cc:101:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable props [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/mon-poly.cc:302:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/fixedarray.h:56:10: style: The member function 'FixedArray < noise_cell , 80 , 70 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:57:9: style: The member function 'FixedArray < noise_cell , 80 , 70 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:58:9: style: The member function 'FixedArray < noise_cell , 80 , 70 >::width' can be static. [functionStatic] stone_soup-0.34.1/source/fixedarray.h:59:9: style: The member function 'FixedArray < noise_cell , 80 , 70 >::height' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < FixedVector < noise_cell , 70 > , 80 >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < FixedVector < noise_cell , 70 > , 80 >::size' can be static. [functionStatic] stone_soup-0.34.1/source/noise.h:46:5: style: Struct 'noise_t' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedarray.h:38:5: style: Class 'FixedArray < noise_cell , 80 , 70 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < FixedVector < noise_cell , 70 > , 80 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/mon-project.cc:700:22: style: Condition '_iood_hit(mon,pos)' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/mon-project.cc:700:22: note: Calling function '_iood_hit' returns 1 stone_soup-0.34.1/source/mon-project.cc:700:22: note: Condition '_iood_hit(mon,pos)' is always true stone_soup-0.34.1/source/mon-speak.cc:128:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/mon-speak.cc:799:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/mon-project.cc:58:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] stone_soup-0.34.1/source/mon-project.cc:109:10: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] stone_soup-0.34.1/source/mon-project.cc:585:13: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] stone_soup-0.34.1/source/fixedarray.h:38:21: performance: Function parameter 'def' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/mon-project.cc:283:49: style: Parameter 'victim' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/mon-project.cc:640:23: style: Variable 'shield' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/mon-speak.cc:632:22: style: Condition 'msg.empty()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/mon-poly.cc:691:9: style: The if condition is the same as the previous if condition [duplicateCondition] stone_soup-0.34.1/source/mon-poly.cc:687:9: note: First condition stone_soup-0.34.1/source/mon-poly.cc:691:9: note: Second condition stone_soup-0.34.1/source/mon-speak.cc:46:10: style: Local variable 'silenced' shadows outer function [shadowFunction] stone_soup-0.34.1/source/areas.h:36:6: note: Shadowed declaration stone_soup-0.34.1/source/mon-speak.cc:46:10: note: Shadow variable stone_soup-0.34.1/source/mon-speak.cc:806:45: performance: Function parameter 'msg' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/mon-speak.cc:137:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/mon-speak.cc:222:19: style: Variable 'prefix' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/mon-poly.cc:644:18: style: Redundant initialization for 'verb'. The initialized value is overwritten before it is read. [redundantInitialization] stone_soup-0.34.1/source/mon-poly.cc:638:21: note: verb is initialized stone_soup-0.34.1/source/mon-poly.cc:644:18: note: verb is overwritten stone_soup-0.34.1/source/mon-poly.cc:737:31: style:inconclusive: Function 'slimify_monster' argument 1 names different: declaration 'mons' definition 'mon'. [funcArgNamesDifferent] stone_soup-0.34.1/source/mon-poly.h:39:31: note: Function 'slimify_monster' argument 1 names different: declaration 'mons' definition 'mon'. stone_soup-0.34.1/source/mon-poly.cc:737:31: note: Function 'slimify_monster' argument 1 names different: declaration 'mons' definition 'mon'. stone_soup-0.34.1/source/mon-poly.cc:564:45: style: Parameter 'mons' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/mon-poly.cc:191:35: style: Parameter 'mons' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/mon-poly.cc:303:20: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] stone_soup-0.34.1/source/ng-restr.cc:24:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_GLADIATOR [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ng-restr.cc:93:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_GLADIATOR [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:83:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:116:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_RANDOM [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:121:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_RANDOM [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:133:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_VIABLE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:138:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:155:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_RANDOM [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:170:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:194:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_HUMAN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:202:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:236:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:273:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_VIABLE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:306:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:331:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:380:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable VERT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:443:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_VIABLE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:603:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable VERT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:850:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable HORZ [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:1082:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_VIABLE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:1100:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable species_groups [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:1158:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:1172:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable VERT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:1374:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:1457:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_region [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:1490:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:1549:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:1597:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:1697:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:1834:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable VERT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:1936:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_FIGHTER [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:2013:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:2042:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:2211:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable VERT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:897:32: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] stone_soup-0.34.1/source/newgame.cc:1172:9: performance: Variable 'm_vbox' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] stone_soup-0.34.1/source/ng-wanderer.cc:913:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_WANDERER [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/newgame.cc:745:5: style: Class 'SeedTextEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/newgame.cc:287:10: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] stone_soup-0.34.1/source/newgame.cc:290:5: note: Found duplicate branches for 'if' and 'else'. stone_soup-0.34.1/source/newgame.cc:287:10: note: Found duplicate branches for 'if' and 'else'. stone_soup-0.34.1/source/newgame.cc:1541:39: style:inconclusive: Function 'attach' argument 3 names different: declaration 'menu' definition 'ng_menu'. [funcArgNamesDifferent] stone_soup-0.34.1/source/newgame.h:44:32: note: Function 'attach' argument 3 names different: declaration 'menu' definition 'ng_menu'. stone_soup-0.34.1/source/newgame.cc:1541:39: note: Function 'attach' argument 3 names different: declaration 'menu' definition 'ng_menu'. stone_soup-0.34.1/source/newgame.cc:1589:39: style:inconclusive: Function 'attach' argument 3 names different: declaration 'menu' definition 'ng_menu'. [funcArgNamesDifferent] stone_soup-0.34.1/source/newgame.h:56:32: note: Function 'attach' argument 3 names different: declaration 'menu' definition 'ng_menu'. stone_soup-0.34.1/source/newgame.cc:1589:39: note: Function 'attach' argument 3 names different: declaration 'menu' definition 'ng_menu'. stone_soup-0.34.1/source/newgame.cc:1273:40: performance: Function parameter 'item_name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/newgame.cc:356:41: style: Parameter 'ng' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/newgame.cc:725:46: style: Parameter 'ch' can be declared as reference to const. However it seems that '_keyfun_seed_input' is a callback function, if 'ch' is declared with const you might also need to cast function pointer(s). [constParameterCallback] stone_soup-0.34.1/source/newgame.cc:858:29: note: You might need to cast the function pointer here stone_soup-0.34.1/source/newgame.cc:725:46: note: Parameter 'ch' can be declared as reference to const stone_soup-0.34.1/source/newgame.cc:811:39: style: Parameter 'ng' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/newgame.cc:1270:39: style: Parameter 'letter' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/newgame.cc:1547:20: style: Variable 'job' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/newgame.cc:1595:24: style: Variable 'this_species' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/newgame.cc:1983:59: style: Parameter 'ng_choice' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/newgame.cc:897:21: style: Variable 'timeinfo' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/newgame.cc:944:14: style: Variable 'cur_focus' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/newgame.cc:1963:17: style: Variable 'startwep' can be declared as const array [constVariable] stone_soup-0.34.1/source/newgame.cc:474:25: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/newgame.cc:1673:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/newgame.cc:1718:24: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/ng-wanderer.cc:317:21: style: Condition 'sk>SK_LAST_MUNDANE' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/ng-wanderer.cc:315:16: note: Assuming that condition 'sk<=SK_LAST_MUNDANE' is not redundant stone_soup-0.34.1/source/ng-wanderer.cc:317:21: note: Condition 'sk>SK_LAST_MUNDANE' is always true stone_soup-0.34.1/source/ng-init.cc:74:51: performance: Function parameter 'temple_gods' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/ng-init.cc:101:14: style: Variable 'main_temple' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/ng-wanderer.cc:323:25: style: Variable 'selected' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/ng-init.cc:63:25: style: Variable 'b' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/package.cc:97:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_RDWR [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/package.cc:486:15: style: Unused private function: 'package::fsck' [unusedPrivateFunction] stone_soup-0.34.1/source/package.h:120:10: note: Unused private function: 'package::fsck' stone_soup-0.34.1/source/package.cc:486:15: note: Unused private function: 'package::fsck' stone_soup-0.34.1/source/package.cc:565:15: style:inconclusive: Technically the member function 'package::has_chunk' can be const. [functionConst] stone_soup-0.34.1/source/package.h:83:10: note: Technically the member function 'package::has_chunk' can be const. stone_soup-0.34.1/source/package.cc:565:15: note: Technically the member function 'package::has_chunk' can be const. stone_soup-0.34.1/source/package.cc:734:10: warning: Class 'chunk_writer' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] stone_soup-0.34.1/source/package.cc:734:10: warning: Class 'chunk_writer' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] stone_soup-0.34.1/source/package.cc:399:19: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/package.cc:699:31: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/package.cc:761:16: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/package.cc:786:19: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/package.cc:869:37: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/package.cc:898:15: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/package.cc:904:25: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/package.cc:919:20: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/package.cc:934:34: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/package.cc:939:26: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/package.cc:402:19: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] stone_soup-0.34.1/source/package.cc:595:16: style: Local variable 'end' shadows outer function [shadowFunction] stone_soup-0.34.1/source/end.h:14:15: note: Shadowed declaration stone_soup-0.34.1/source/package.cc:595:16: note: Shadow variable stone_soup-0.34.1/source/package.cc:289:17: style: Variable 'ch' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/package.cc:640:15: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/notes.cc:564:25: style:inconclusive: Function 'save_notes' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/notes.cc:572:25: style:inconclusive: Function 'load_notes' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/orb.cc:86:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_CHARLATANS_ORB [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/pattern.cc:76:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable REG_EXTENDED [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/pattern.cc:219:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/pattern.cc:227:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/pattern.cc:140:35: style: 'operator=' should return reference to 'this' instance. [operatorEqRetRefThis] stone_soup-0.34.1/source/pattern.cc:102:14: style: Variable 're' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/pattern.cc:111:14: style: Variable 're' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/pcg.cc:136:25: style:inconclusive: Technically the member function 'rng::PcgRNG::to_vector' can be const. [functionConst] stone_soup-0.34.1/source/pcg.h:13:21: note: Technically the member function 'rng::PcgRNG::to_vector' can be const. stone_soup-0.34.1/source/pcg.cc:136:25: note: Technically the member function 'rng::PcgRNG::to_vector' can be const. stone_soup-0.34.1/source/pcg.cc:68:50: style:inconclusive: Function 'get_bounded_uint32' argument 1 names different: declaration 'bound' definition 'range'. [funcArgNamesDifferent] stone_soup-0.34.1/source/pcg.h:15:46: note: Function 'get_bounded_uint32' argument 1 names different: declaration 'bound' definition 'range'. stone_soup-0.34.1/source/pcg.cc:68:50: note: Function 'get_bounded_uint32' argument 1 names different: declaration 'bound' definition 'range'. stone_soup-0.34.1/source/orb.cc:89:33: style:inconclusive: Function 'start_orb_run' argument 1 names different: declaration 'new_chapter' definition 'chapter'. [funcArgNamesDifferent] stone_soup-0.34.1/source/orb.h:8:33: note: Function 'start_orb_run' argument 1 names different: declaration 'new_chapter' definition 'chapter'. stone_soup-0.34.1/source/orb.cc:89:33: note: Function 'start_orb_run' argument 1 names different: declaration 'new_chapter' definition 'chapter'. stone_soup-0.34.1/source/ng-setup.cc:182:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_COGLIN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ng-setup.cc:231:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_HUNTER [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ng-setup.cc:294:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_CHAOS_KNIGHT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ng-setup.cc:357:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ng-setup.cc:608:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_SHAPESHIFTER [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/perlin.cc:296:25: style:inconclusive: Function 'noise' argument 1 names different: declaration 'xin' definition 'x'. [funcArgNamesDifferent] stone_soup-0.34.1/source/perlin.h:7:25: note: Function 'noise' argument 1 names different: declaration 'xin' definition 'x'. stone_soup-0.34.1/source/perlin.cc:296:25: note: Function 'noise' argument 1 names different: declaration 'xin' definition 'x'. stone_soup-0.34.1/source/perlin.cc:296:35: style:inconclusive: Function 'noise' argument 2 names different: declaration 'yin' definition 'y'. [funcArgNamesDifferent] stone_soup-0.34.1/source/perlin.h:7:37: note: Function 'noise' argument 2 names different: declaration 'yin' definition 'y'. stone_soup-0.34.1/source/perlin.cc:296:35: note: Function 'noise' argument 2 names different: declaration 'yin' definition 'y'. stone_soup-0.34.1/source/perlin.cc:296:45: style:inconclusive: Function 'noise' argument 3 names different: declaration 'zin' definition 'z'. [funcArgNamesDifferent] stone_soup-0.34.1/source/perlin.h:7:49: note: Function 'noise' argument 3 names different: declaration 'zin' definition 'z'. stone_soup-0.34.1/source/perlin.cc:296:45: note: Function 'noise' argument 3 names different: declaration 'zin' definition 'z'. stone_soup-0.34.1/source/perlin.cc:296:55: style:inconclusive: Function 'noise' argument 4 names different: declaration 'win' definition 'w'. [funcArgNamesDifferent] stone_soup-0.34.1/source/perlin.h:7:61: note: Function 'noise' argument 4 names different: declaration 'win' definition 'w'. stone_soup-0.34.1/source/perlin.cc:296:55: note: Function 'noise' argument 4 names different: declaration 'win' definition 'w'. stone_soup-0.34.1/source/perlin.cc:425:23: style:inconclusive: Function 'fBM' argument 1 names different: declaration 'xin' definition 'x'. [funcArgNamesDifferent] stone_soup-0.34.1/source/perlin.h:8:23: note: Function 'fBM' argument 1 names different: declaration 'xin' definition 'x'. stone_soup-0.34.1/source/perlin.cc:425:23: note: Function 'fBM' argument 1 names different: declaration 'xin' definition 'x'. stone_soup-0.34.1/source/perlin.cc:425:33: style:inconclusive: Function 'fBM' argument 2 names different: declaration 'yin' definition 'y'. [funcArgNamesDifferent] stone_soup-0.34.1/source/perlin.h:8:35: note: Function 'fBM' argument 2 names different: declaration 'yin' definition 'y'. stone_soup-0.34.1/source/perlin.cc:425:33: note: Function 'fBM' argument 2 names different: declaration 'yin' definition 'y'. stone_soup-0.34.1/source/perlin.cc:425:43: style:inconclusive: Function 'fBM' argument 3 names different: declaration 'zin' definition 'z'. [funcArgNamesDifferent] stone_soup-0.34.1/source/perlin.h:8:47: note: Function 'fBM' argument 3 names different: declaration 'zin' definition 'z'. stone_soup-0.34.1/source/perlin.cc:425:43: note: Function 'fBM' argument 3 names different: declaration 'zin' definition 'z'. stone_soup-0.34.1/source/perlin.cc:120:28: performance: Function parameter 'g' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/perlin.cc:124:28: performance: Function parameter 'g' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/perlin.cc:128:28: performance: Function parameter 'g' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/outer-menu.cc:88:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ops [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/outer-menu.cc:416:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/outer-menu.cc:207:5: performance: Variable 'm_grid' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] stone_soup-0.34.1/source/outer-menu.cc:321:17: style:inconclusive: Either there is a missing 'override', or the member function 'OuterMenu::scroll_button_into_view' can be const. [functionConst] stone_soup-0.34.1/source/outer-menu.h:88:10: note: Either there is a missing 'override', or the member function 'OuterMenu::scroll_button_into_view' can be const. stone_soup-0.34.1/source/outer-menu.cc:321:17: note: Either there is a missing 'override', or the member function 'OuterMenu::scroll_button_into_view' can be const. stone_soup-0.34.1/source/outer-menu.h:72:18: style: The function 'on_event' overrides a function in a base class but just delegates back to the base class. [uselessOverride] stone_soup-0.34.1/source/ui.h:404:18: note: Virtual function in base class stone_soup-0.34.1/source/outer-menu.h:72:18: note: Function in derived class stone_soup-0.34.1/source/outer-menu.cc:318:23: warning: Possible null pointer dereference: r [nullPointer] stone_soup-0.34.1/source/outer-menu.cc:314:17: note: Assignment 'r=nullptr', assigned value is 0 stone_soup-0.34.1/source/outer-menu.cc:315:33: note: Assuming condition is false stone_soup-0.34.1/source/outer-menu.cc:318:23: note: Null pointer dereference stone_soup-0.34.1/source/outer-menu.cc:247:50: style:inconclusive: Function '_get_preferred_size' argument 1 names different: declaration '' definition 'dim'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/outer-menu.cc:247:59: style:inconclusive: Function '_get_preferred_size' argument 2 names different: declaration '' definition 'prosp_width'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/outer-menu.cc:101:53: style: Parameter 'child' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/piety-info.cc:41:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/place-info.cc:136:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable branch [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/place-info.cc:158:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable num_visits [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ng-setup.cc:411:9: style: Statements following noreturn function 'die()' will never be executed. [unreachableCode] stone_soup-0.34.1/source/ng-setup.cc:47:9: style: The scope of the variable 'needed' can be reduced. [variableScope] stone_soup-0.34.1/source/ng-setup.cc:113:9: style: Local variable 'end' shadows outer function [shadowFunction] stone_soup-0.34.1/source/end.h:14:15: note: Shadowed declaration stone_soup-0.34.1/source/ng-setup.cc:113:9: note: Shadow variable stone_soup-0.34.1/source/place-info.cc:250:29: style: The member function 'player::get_all_xp_info' can be static. [functionStatic] stone_soup-0.34.1/source/player.h:1013:25: note: The member function 'player::get_all_xp_info' can be static. stone_soup-0.34.1/source/place-info.cc:250:29: note: The member function 'player::get_all_xp_info' can be static. stone_soup-0.34.1/source/ng-setup.cc:444:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/place-info.cc:141:39: style:inconclusive: Function 'set_place_info' argument 1 names different: declaration 'info' definition 'place_info'. [funcArgNamesDifferent] stone_soup-0.34.1/source/player.h:1006:35: note: Function 'set_place_info' argument 1 names different: declaration 'info' definition 'place_info'. stone_soup-0.34.1/source/place-info.cc:141:39: note: Function 'set_place_info' argument 1 names different: declaration 'info' definition 'place_info'. stone_soup-0.34.1/source/place-info.cc:175:42: style:inconclusive: Function 'LevelXPInfo' argument 1 names different: declaration 'level' definition 'lev'. [funcArgNamesDifferent] stone_soup-0.34.1/source/place-info.h:55:33: note: Function 'LevelXPInfo' argument 1 names different: declaration 'level' definition 'lev'. stone_soup-0.34.1/source/place-info.cc:175:42: note: Function 'LevelXPInfo' argument 1 names different: declaration 'level' definition 'lev'. stone_soup-0.34.1/source/place-info.cc:141:39: performance: Function parameter 'place_info' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/place-info.cc:280:45: style: Parameter 'xp_info' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/place.cc:31:46: style:inconclusive: Function 'absdungeon_depth' argument 2 names different: declaration 'depth' definition 'subdepth'. [funcArgNamesDifferent] stone_soup-0.34.1/source/place.h:25:46: note: Function 'absdungeon_depth' argument 2 names different: declaration 'depth' definition 'subdepth'. stone_soup-0.34.1/source/place.cc:31:46: note: Function 'absdungeon_depth' argument 2 names different: declaration 'depth' definition 'subdepth'. stone_soup-0.34.1/source/place.cc:60:33: style:inconclusive: Function 'is_level_on_stack' argument 1 names different: declaration 'id' definition 'lev'. [funcArgNamesDifferent] stone_soup-0.34.1/source/place.h:31:33: note: Function 'is_level_on_stack' argument 1 names different: declaration 'id' definition 'lev'. stone_soup-0.34.1/source/place.cc:60:33: note: Function 'is_level_on_stack' argument 1 names different: declaration 'id' definition 'lev'. stone_soup-0.34.1/source/playable.cc:31:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable job_type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/playable.cc:121:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/playable.cc:138:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_BASE_DRACONIAN [valueFlowBailoutIncompleteVar] levcomp.lpp:39:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable text [valueFlowBailoutIncompleteVar] levcomp.lpp:78:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable text [valueFlowBailoutIncompleteVar] levcomp.lpp:92:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable text [valueFlowBailoutIncompleteVar] levcomp.lpp:97:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable text [valueFlowBailoutIncompleteVar] levcomp.lpp:111:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable text [valueFlowBailoutIncompleteVar] levcomp.lex.cc:2121:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdin [valueFlowBailoutIncompleteVar] levcomp.lex.cc:2940:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EOF [valueFlowBailoutIncompleteVar] levcomp.lex.cc:3285:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] levcomp.lex.cc:3523:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] levcomp.lex.cc:2786:16: style: Condition 'yywrap()' is always true [knownConditionTrueFalse] levcomp.lex.cc:2786:16: note: Calling function 'yywrap' returns 1 levcomp.lex.cc:2786:16: note: Condition 'yywrap()' is always true levcomp.lex.cc:3135:17: style: Condition 'yywrap()' is always true [knownConditionTrueFalse] levcomp.lex.cc:3135:17: note: Calling function 'yywrap' returns 1 levcomp.lex.cc:3135:17: note: Condition 'yywrap()' is always true levcomp.lpp:120:16: warning:inconclusive: If memory allocation fails, then there is a possible null pointer dereference: newbuf [nullPointerOutOfMemory] levcomp.lpp:116:38: note: Assuming allocation function fails levcomp.lpp:116:24: note: Assignment 'newbuf=(char*)malloc(strlen(yylval.text)+strlen(yytext)+1)', assigned value is 0 levcomp.lpp:120:16: note: Null pointer dereference levcomp.lpp:121:16: warning:inconclusive: If memory allocation fails, then there is a possible null pointer dereference: newbuf [nullPointerOutOfMemory] levcomp.lpp:116:38: note: Assuming allocation function fails levcomp.lpp:116:24: note: Assignment 'newbuf=(char*)malloc(strlen(yylval.text)+strlen(yytext)+1)', assigned value is 0 levcomp.lpp:121:16: note: Null pointer dereference levcomp.lex.cc:3289:2: warning: Possible null pointer dereference: b [nullPointer] levcomp.lex.cc:3182:18: note: Calling function 'yy_init_buffer', 1st argument '(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL' value is 0 levcomp.lex.cc:3289:2: note: Null pointer dereference levcomp.lex.cc:3290:2: warning: Possible null pointer dereference: b [nullPointer] levcomp.lex.cc:3182:18: note: Calling function 'yy_init_buffer', 1st argument '(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL' value is 0 levcomp.lex.cc:3290:2: note: Null pointer dereference levcomp.lpp:25:14: style: C-style pointer casting [cstyleCast] levcomp.lpp:99:21: style: C-style pointer casting [cstyleCast] levcomp.lpp:116:24: style: C-style pointer casting [cstyleCast] levcomp.lpp:124:18: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:2916:20: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:2918:17: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:2968:41: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:2969:4: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:3154:7: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:3239:6: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:3248:17: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:3273:11: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:3275:10: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:3399:23: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:3418:23: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:3447:6: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:3496:8: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:3722:10: style: C-style pointer casting [cstyleCast] levcomp.lex.cc:2940:3: style: Redundant initialization for 'c'. The initialized value is overwritten before it is read. [redundantInitialization] levcomp.lex.cc:2940:3: note: c is initialized levcomp.lex.cc:2940:3: note: c is overwritten levcomp.lpp:156:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:198:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:206:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:223:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:237:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:276:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:281:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:320:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:325:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:364:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:382:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:387:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:392:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:397:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:402:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:407:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:412:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:417:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:422:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:427:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:432:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:437:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:442:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:447:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:462:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:467:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:472:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:477:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:482:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:487:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:492:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:497:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:502:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:507:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:512:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:517:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:522:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:527:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:532:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:537:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:542:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:547:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:552:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:557:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:562:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:567:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:572:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:577:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:606:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lpp:614:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] levcomp.lex.cc:3020:59: style:inconclusive: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. [funcArgNamesDifferent] levcomp.lex.cc:361:55: note: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. levcomp.lex.cc:3020:59: note: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. levcomp.lex.cc:3045:40: style:inconclusive: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. [funcArgNamesDifferent] levcomp.lex.cc:1977:40: note: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. levcomp.lex.cc:3045:40: note: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. levcomp.lex.cc:3474:46: style:inconclusive: Function 'yy_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. [funcArgNamesDifferent] levcomp.lex.cc:316:46: note: Function 'yy_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. levcomp.lex.cc:3474:46: note: Function 'yy_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. levcomp.lex.cc:3487:46: style:inconclusive: Function 'yy_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. [funcArgNamesDifferent] levcomp.lex.cc:317:45: note: Function 'yy_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. levcomp.lex.cc:3487:46: note: Function 'yy_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. levcomp.lex.cc:3487:60: style:inconclusive: Function 'yy_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. [funcArgNamesDifferent] levcomp.lex.cc:317:56: note: Function 'yy_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. levcomp.lex.cc:3487:60: note: Function 'yy_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. levcomp.lex.cc:3619:24: style:inconclusive: Function 'yyset_debug' argument 1 names different: declaration 'debug_flag' definition '_bdebug'. [funcArgNamesDifferent] levcomp.lex.cc:1941:24: note: Function 'yyset_debug' argument 1 names different: declaration 'debug_flag' definition '_bdebug'. levcomp.lex.cc:3619:24: note: Function 'yyset_debug' argument 1 names different: declaration 'debug_flag' definition '_bdebug'. levcomp.lex.cc:3702:27: style:inconclusive: Function 'yyalloc' argument 1 names different: declaration '' definition 'size'. [funcArgNamesDifferentUnnamed] levcomp.lex.cc:3707:26: style:inconclusive: Function 'yyrealloc' argument 1 names different: declaration '' definition 'ptr'. [funcArgNamesDifferentUnnamed] levcomp.lex.cc:3707:42: style:inconclusive: Function 'yyrealloc' argument 2 names different: declaration '' definition 'size'. [funcArgNamesDifferentUnnamed] levcomp.lex.cc:3720:21: style:inconclusive: Function 'yyfree' argument 1 names different: declaration '' definition 'ptr'. [funcArgNamesDifferentUnnamed] levcomp.lex.cc:2852:8: style: Variable 'source' can be declared as pointer to const [constVariablePointer] levcomp.lex.cc:3060:9: style: Variable 'source' can be declared as pointer to const [constVariablePointer] levcomp.ypp:24:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] levcomp.tab.cc:1200:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable YYEMPTY [valueFlowBailoutIncompleteVar] levcomp.tab.cc:1134:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] levcomp.tab.cc:1219:3: style: The comparison '0 <= yystate' is always true. [knownConditionTrueFalse] levcomp.tab.cc:1161:31: note: 'yystate' is assigned value '0' here. levcomp.tab.cc:1219:3: note: The comparison '0 <= yystate' is always true. levcomp.tab.cc:1134:11: style: Variable 'yymsg' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/output.cc:793:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable horiz_bar_width [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/output.cc:1464:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JOB_MONK [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/output.cc:2342:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_DEEP_DWARF [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/output.cc:2610:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_ETHERIC_CAGE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/output.cc:2714:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_SEVEN_LEAGUE_BOOTS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/output.cc:667:45: style: Condition '!_is_using_small_layout()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:667:68: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:667:45: note: Condition '!_is_using_small_layout()' is always true stone_soup-0.34.1/source/output.cc:676:9: style: Condition '!_is_using_small_layout()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:676:32: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:676:9: note: Condition '!_is_using_small_layout()' is always true stone_soup-0.34.1/source/output.cc:810:31: style: Condition '_is_using_small_layout()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:810:31: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:810:31: note: Condition '_is_using_small_layout()' is always false stone_soup-0.34.1/source/output.cc:859:9: style: Condition '!_is_using_small_layout()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:859:32: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:859:9: note: Condition '!_is_using_small_layout()' is always true stone_soup-0.34.1/source/output.cc:1025:9: style: Condition '!_is_using_small_layout()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1025:32: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1025:9: note: Condition '!_is_using_small_layout()' is always true stone_soup-0.34.1/source/output.cc:1418:53: style: Assigned value '_is_using_small_layout()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1418:53: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1418:53: note: Assigned value '_is_using_small_layout()' is always false stone_soup-0.34.1/source/output.cc:1420:9: style: Condition 'small_layout' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1418:53: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1418:53: note: Assignment 'small_layout=_is_using_small_layout()', assigned value is 0 stone_soup-0.34.1/source/output.cc:1420:9: note: Condition 'small_layout' is always false stone_soup-0.34.1/source/output.cc:1444:16: style: Condition 'small_layout' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1418:53: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1418:53: note: Assignment 'small_layout=_is_using_small_layout()', assigned value is 0 stone_soup-0.34.1/source/output.cc:1444:16: note: Condition 'small_layout' is always false stone_soup-0.34.1/source/output.cc:1446:23: style: Condition '!small_layout' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1418:53: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1418:53: note: Assignment 'small_layout=_is_using_small_layout()', assigned value is 0 stone_soup-0.34.1/source/output.cc:1446:23: note: Condition '!small_layout' is always true stone_soup-0.34.1/source/output.cc:1448:37: style: Condition '!small_layout' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1418:53: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1418:53: note: Assignment 'small_layout=_is_using_small_layout()', assigned value is 0 stone_soup-0.34.1/source/output.cc:1448:37: note: Condition '!small_layout' is always true stone_soup-0.34.1/source/output.cc:1450:29: style: Condition '!small_layout' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1418:53: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1418:53: note: Assignment 'small_layout=_is_using_small_layout()', assigned value is 0 stone_soup-0.34.1/source/output.cc:1450:29: note: Condition '!small_layout' is always true stone_soup-0.34.1/source/output.cc:1468:17: style: Condition 'small_layout' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1418:53: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1418:53: note: Assignment 'small_layout=_is_using_small_layout()', assigned value is 0 stone_soup-0.34.1/source/output.cc:1468:17: note: Condition 'small_layout' is always false stone_soup-0.34.1/source/output.cc:1472:17: style: Condition 'small_layout' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1418:53: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1418:53: note: Assignment 'small_layout=_is_using_small_layout()', assigned value is 0 stone_soup-0.34.1/source/output.cc:1472:17: note: Condition 'small_layout' is always false stone_soup-0.34.1/source/output.cc:1485:13: style: Condition 'small_layout' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1418:53: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1418:53: note: Assignment 'small_layout=_is_using_small_layout()', assigned value is 0 stone_soup-0.34.1/source/output.cc:1485:13: note: Condition 'small_layout' is always false stone_soup-0.34.1/source/output.cc:1498:13: style: Condition 'small_layout' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1418:53: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1418:53: note: Assignment 'small_layout=_is_using_small_layout()', assigned value is 0 stone_soup-0.34.1/source/output.cc:1498:13: note: Condition 'small_layout' is always false stone_soup-0.34.1/source/output.cc:1556:13: style: Condition '!_is_using_small_layout()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1556:36: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1556:13: note: Condition '!_is_using_small_layout()' is always true stone_soup-0.34.1/source/output.cc:1586:35: style: Condition '_is_using_small_layout()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1586:35: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1586:35: note: Condition '_is_using_small_layout()' is always false stone_soup-0.34.1/source/output.cc:1595:17: style: Condition '!_is_using_small_layout()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1595:40: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1595:17: note: Condition '!_is_using_small_layout()' is always true stone_soup-0.34.1/source/output.cc:1632:45: style: Condition '!_is_using_small_layout()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1632:68: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1632:45: note: Condition '!_is_using_small_layout()' is always true stone_soup-0.34.1/source/output.cc:1639:31: style: Condition '_is_using_small_layout()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1639:31: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1639:31: note: Condition '_is_using_small_layout()' is always false stone_soup-0.34.1/source/output.cc:1661:45: style: Condition '!_is_using_small_layout()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1661:68: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1661:45: note: Condition '!_is_using_small_layout()' is always true stone_soup-0.34.1/source/output.cc:1974:25: style: Condition 'i_print>=skip_lines' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1970:28: note: Assignment 'i_print=0', assigned value is 0 stone_soup-0.34.1/source/output.cc:1974:25: note: Condition 'i_print>=skip_lines' is always true stone_soup-0.34.1/source/output.cc:1823:9: style: Redundant initialization for 'msg'. The initialized value is overwritten before it is read. [redundantInitialization] stone_soup-0.34.1/source/output.cc:1798:16: note: msg is initialized stone_soup-0.34.1/source/output.cc:1823:9: note: msg is overwritten stone_soup-0.34.1/source/output.cc:1522:9: style: The scope of the variable 'ev_pos' can be reduced. [variableScope] stone_soup-0.34.1/source/output.cc:1841:18: style: Local variable 'end' shadows outer function [shadowFunction] stone_soup-0.34.1/source/end.h:14:15: note: Shadowed declaration stone_soup-0.34.1/source/output.cc:1841:18: note: Shadow variable stone_soup-0.34.1/source/output.cc:1232:32: performance: Function parameter 't' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/precision-menu.cc:112:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PRECISION_SINGLESELECT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/precision-menu.cc:353:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable _1 [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/precision-menu.cc:649:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/precision-menu.cc:1043:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable y [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/precision-menu.cc:1136:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INPUT_NO_ACTION [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/precision-menu.cc:1401:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/precision-menu.cc:1439:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/output.cc:2158:19: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/output.cc:2106:10: performance: Passing the result of c_str() to a function that takes std::string as argument no. 2 is slow and redundant. [stlcstrParam] stone_soup-0.34.1/source/output.cc:1009:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/output.cc:1845:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-stats.cc:45:13: style: The member function 'player::strength' can be static. [functionStatic] stone_soup-0.34.1/source/player.h:568:9: note: The member function 'player::strength' can be static. stone_soup-0.34.1/source/player-stats.cc:45:13: note: The member function 'player::strength' can be static. stone_soup-0.34.1/source/player-stats.cc:50:13: style: The member function 'player::intel' can be static. [functionStatic] stone_soup-0.34.1/source/player.h:569:9: note: The member function 'player::intel' can be static. stone_soup-0.34.1/source/player-stats.cc:50:13: note: The member function 'player::intel' can be static. stone_soup-0.34.1/source/player-stats.cc:55:13: style: The member function 'player::dex' can be static. [functionStatic] stone_soup-0.34.1/source/player.h:570:9: note: The member function 'player::dex' can be static. stone_soup-0.34.1/source/player-stats.cc:55:13: note: The member function 'player::dex' can be static. stone_soup-0.34.1/source/player-stats.cc:39:28: style:inconclusive: Function 'stat' argument 1 names different: declaration 'stat' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/player.h:567:24: note: Function 'stat' argument 1 names different: declaration 'stat' definition 's'. stone_soup-0.34.1/source/player-stats.cc:39:28: note: Function 'stat' argument 1 names different: declaration 'stat' definition 's'. stone_soup-0.34.1/source/player-stats.cc:272:15: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-stats.cc:374:18: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/precision-menu.cc:970:13: warning: Member variable 'MenuObject::m_visible' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/precision-menu.cc:1531:21: warning: Member variable 'BoxMenuHighlighter::m_old_bg_colour' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/player-equip.cc:125:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_OCTOPODE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/player-equip.cc:534:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_OCTOPODE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/player-equip.cc:598:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_START [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/player-equip.cc:2171:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_DEEP_DWARF [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/player-equip.cc:2347:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_SKULL_OF_ZONGULDROK [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/player-equip.cc:2396:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_NAGA [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/player-equip.cc:2754:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_DEEP_DWARF [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/precision-menu.h:434:18: style: Virtual function 'clear' is called from destructor '~PrecisionMenu()' at line 51. Dynamic binding is not used. [virtualCallInConstructor] stone_soup-0.34.1/source/precision-menu.cc:51:5: note: Calling clear stone_soup-0.34.1/source/precision-menu.h:434:18: note: clear is a virtual function stone_soup-0.34.1/source/precision-menu.h:55:18: style: Virtual function 'set_fg_colour' is called from constructor 'MenuItem()' at line 395. Dynamic binding is not used. [virtualCallInConstructor] stone_soup-0.34.1/source/precision-menu.cc:395:5: note: Calling set_fg_colour stone_soup-0.34.1/source/precision-menu.h:55:18: note: set_fg_colour is a virtual function stone_soup-0.34.1/source/precision-menu.h:56:18: style: Virtual function 'set_bg_colour' is called from constructor 'MenuItem()' at line 396. Dynamic binding is not used. [virtualCallInConstructor] stone_soup-0.34.1/source/precision-menu.cc:396:5: note: Calling set_bg_colour stone_soup-0.34.1/source/precision-menu.h:56:18: note: set_bg_colour is a virtual function stone_soup-0.34.1/source/precision-menu.h:53:18: style: Virtual function 'set_highlight_colour' is called from constructor 'MenuItem()' at line 397. Dynamic binding is not used. [virtualCallInConstructor] stone_soup-0.34.1/source/precision-menu.cc:397:5: note: Calling set_highlight_colour stone_soup-0.34.1/source/precision-menu.h:53:18: note: set_highlight_colour is a virtual function stone_soup-0.34.1/source/precision-menu.h:360:5: style: Class 'BoxMenuHighlighter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/precision-menu.h:122:14: style: The destructor '~TextItem' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/precision-menu.h:27:14: note: Virtual destructor in base class stone_soup-0.34.1/source/precision-menu.h:122:14: note: Destructor in derived class stone_soup-0.34.1/source/precision-menu.h:180:14: style: The destructor '~NoSelectTextItem' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/precision-menu.h:122:14: note: Virtual destructor in base class stone_soup-0.34.1/source/precision-menu.h:180:14: note: Destructor in derived class stone_soup-0.34.1/source/precision-menu.h:321:14: style: The destructor '~MenuFreeform' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/precision-menu.h:244:14: note: Virtual destructor in base class stone_soup-0.34.1/source/precision-menu.h:321:14: note: Destructor in derived class stone_soup-0.34.1/source/precision-menu.h:361:14: style: The destructor '~BoxMenuHighlighter' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/precision-menu.h:244:14: note: Virtual destructor in base class stone_soup-0.34.1/source/precision-menu.h:361:14: note: Destructor in derived class stone_soup-0.34.1/source/precision-menu.h:154:18: style: The function 'render' overrides a function in a base class but just delegates back to the base class. [uselessOverride] stone_soup-0.34.1/source/precision-menu.h:128:18: note: Virtual function in base class stone_soup-0.34.1/source/precision-menu.h:154:18: note: Function in derived class stone_soup-0.34.1/source/precision-menu.cc:1567:9: warning: Identical condition '!m_visible', second condition is always false [identicalConditionAfterEarlyExit] stone_soup-0.34.1/source/precision-menu.cc:1564:9: note: If condition '!m_visible' is true, the function will return/exit stone_soup-0.34.1/source/precision-menu.cc:1567:9: note: Testing identical condition '!m_visible' stone_soup-0.34.1/source/precision-menu.cc:640:12: style: The scope of the variable 'endline_pos' can be reduced. [variableScope] stone_soup-0.34.1/source/player-notices.cc:628:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_WYRMBANE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/precision-menu.h:49:42: style:inconclusive: Function 'select' argument 2 names different: declaration 'value' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/precision-menu.h:363:48: style:inconclusive: Function 'process_input' argument 1 names different: declaration 'key' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/precision-menu.cc:345:53: performance: Function parameter 'lookup' should be passed by const reference. However it seems that '_string_lookup' is a callback function. [passedByValueCallback] stone_soup-0.34.1/source/precision-menu.cc:353:28: note: Function pointer used here. stone_soup-0.34.1/source/precision-menu.cc:345:53: note: Function parameter 'lookup' should be passed by const reference. However it seems that '_string_lookup' is a callback function. stone_soup-0.34.1/source/precision-menu.cc:805:39: performance: Function parameter 't' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/precision-menu.cc:810:42: performance: Function parameter 'p' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/precision-menu.cc:165:19: style: Variable 'tmp' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/precision-menu.cc:345:40: style: Parameter 'item' can be declared as pointer to const. However it seems that '_string_lookup' is a callback function, if 'item' is declared with const you might also need to cast function pointer(s). [constParameterCallback] stone_soup-0.34.1/source/precision-menu.cc:353:28: note: You might need to cast the function pointer here stone_soup-0.34.1/source/precision-menu.cc:345:40: note: Parameter 'item' can be declared as pointer to const stone_soup-0.34.1/source/precision-menu.cc:91:17: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/precision-menu.cc:333:21: style: Consider using std::copy algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/precision-menu.cc:1059:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/precision-menu.cc:1078:19: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/precision-menu.cc:1151:17: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/potion.cc:316:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_FOLLY [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/potion.cc:630:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_KRYIAS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/precision-menu.cc:640:24: style: Variable 'endline_pos' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/random-var.cc:227:59: warning: Either the condition 'd<0' is redundant or there is division by zero at line 227. [zerodivcond] stone_soup-0.34.1/source/random-var.cc:218:11: note: Assuming that condition 'd<0' is not redundant stone_soup-0.34.1/source/random-var.cc:227:59: note: Division by zero stone_soup-0.34.1/source/random-var.cc:228:59: warning: Either the condition 'd<0' is redundant or there is division by zero at line 228. [zerodivcond] stone_soup-0.34.1/source/random-var.cc:218:11: note: Assuming that condition 'd<0' is not redundant stone_soup-0.34.1/source/random-var.cc:228:59: note: Division by zero stone_soup-0.34.1/source/skill-menu.h:73:5: warning:inconclusive: Member variable 'SkillMenuEntry::m_sk' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/skill-menu.h:73:5: warning:inconclusive: Member variable 'SkillMenuEntry::m_name' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/skill-menu.h:73:5: warning:inconclusive: Member variable 'SkillMenuEntry::m_level' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/skill-menu.h:73:5: warning:inconclusive: Member variable 'SkillMenuEntry::m_progress' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/skill-menu.h:73:5: warning:inconclusive: Member variable 'SkillMenuEntry::m_aptitude' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/random-var.cc:18:50: style:inconclusive: Function 'random_var' argument 3 names different: declaration 'w_' definition 'w'. [funcArgNamesDifferent] stone_soup-0.34.1/source/random-var.h:23:42: note: Function 'random_var' argument 3 names different: declaration 'w_' definition 'w'. stone_soup-0.34.1/source/random-var.cc:18:50: note: Function 'random_var' argument 3 names different: declaration 'w_' definition 'w'. stone_soup-0.34.1/source/random-var.cc:48:14: style: Local variable 'weight' shadows outer function [shadowFunction] stone_soup-0.34.1/source/random-var.h:31:9: note: Shadowed declaration stone_soup-0.34.1/source/random-var.cc:48:14: note: Shadow variable stone_soup-0.34.1/source/random-var.cc:60:23: style: Local variable 'weight' shadows outer function [shadowFunction] stone_soup-0.34.1/source/random-var.h:31:9: note: Shadowed declaration stone_soup-0.34.1/source/random-var.cc:60:23: note: Shadow variable stone_soup-0.34.1/source/random-var.cc:25:50: performance: Function parameter 'ws' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/random-var.cc:48:5: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/random-var.cc:61:24: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/random-var.cc:97:39: warning: Possible dereference of an invalid iterator: weights.begin()+last_nonzero [derefInvalidIterator] stone_soup-0.34.1/source/random-var.cc:83:29: note: Assignment 'last_nonzero=-1', assigned value is -1 stone_soup-0.34.1/source/random-var.cc:84:27: note: Assuming condition is false stone_soup-0.34.1/source/random-var.cc:97:39: note: Dereference of an invalid iterator stone_soup-0.34.1/source/random-var.cc:98:56: warning: Possible dereference of an invalid iterator: weights.begin()+first_nonzero [derefInvalidIterator] stone_soup-0.34.1/source/random-var.cc:82:30: note: Assignment 'first_nonzero=-1', assigned value is -1 stone_soup-0.34.1/source/random-var.cc:84:27: note: Assuming condition is false stone_soup-0.34.1/source/random-var.cc:98:56: note: Dereference of an invalid iterator stone_soup-0.34.1/source/player-equip.cc:1079:24: style:inconclusive: Technically the member function 'player_equip_set::is_melded' can be const. [functionConst] stone_soup-0.34.1/source/player-equip.h:99:10: note: Technically the member function 'player_equip_set::is_melded' can be const. stone_soup-0.34.1/source/player-equip.cc:1079:24: note: Technically the member function 'player_equip_set::is_melded' can be const. stone_soup-0.34.1/source/skill-menu.h:74:5: style: Class 'SkillMenuEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/player-equip.cc:352:19: style: Variable 'item' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/player-equip.cc:385:19: style: Variable 'item' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/player-equip.cc:426:50: style: Parameter '_item' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/player-equip.cc:1231:46: style: Variable 'overflow' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/player-equip.cc:1304:60: style: Parameter 'to_unmeld' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/player-equip.cc:1521:31: style: Parameter 'item' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/player-equip.cc:1580:29: style: Parameter 'item' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/player-equip.cc:1663:51: style: Parameter 'item' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/player-equip.cc:1858:44: style: Parameter 'item' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/player-equip.cc:2044:46: style: Parameter 'item' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/player-equip.cc:2220:44: style: Parameter 'arm' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/player-equip.cc:2353:46: style: Parameter 'item' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/player-equip.cc:2475:47: style: Parameter 'item' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/player-equip.cc:2584:47: style: Parameter 'item' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/player-equip.cc:754:15: style: Variable 'cursed_item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/player-equip.cc:778:40: style: Variable 'check' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/player-equip.cc:857:58: style: Parameter 'entry1' can be declared as pointer to const. However it seems that '_forced_removal_goodness' is a callback function, if 'entry1' is declared with const you might also need to cast function pointer(s). [constParameterCallback] stone_soup-0.34.1/source/player-equip.cc:945:64: note: You might need to cast the function pointer here stone_soup-0.34.1/source/player-equip.cc:857:58: note: Parameter 'entry1' can be declared as pointer to const stone_soup-0.34.1/source/player-equip.cc:857:86: style: Parameter 'entry2' can be declared as pointer to const. However it seems that '_forced_removal_goodness' is a callback function, if 'entry2' is declared with const you might also need to cast function pointer(s). [constParameterCallback] stone_soup-0.34.1/source/player-equip.cc:945:64: note: You might need to cast the function pointer here stone_soup-0.34.1/source/player-equip.cc:857:86: note: Parameter 'entry2' can be declared as pointer to const stone_soup-0.34.1/source/player-equip.cc:938:42: style: Variable 'entry' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/player-equip.cc:1133:24: style: Variable 'meld_item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/player-equip.cc:1138:23: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/player-equip.cc:1195:20: style: Variable 'meld_item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/player-equip.cc:1205:20: style: Variable 'meld_item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/player-equip.cc:1313:24: style: Variable 'unmeld_item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/player-equip.cc:1326:24: style: Variable 'meld_item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/player-equip.cc:1476:15: style: Variable 'wpn' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/player-notices.cc:405:63: performance: Function parameter 'monsters' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/player-notices.cc:516:50: performance: Function parameter 'monsters' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/player-notices.cc:425:23: style: Variable 'sp' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/player-notices.cc:467:44: style: Parameter 'monsters' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/player-notices.cc:467:72: style: Parameter 'to_announce' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/player-equip.cc:2801:13: performance: Passing the result of c_str() to a function that takes std::string as argument no. 2 is slow and redundant. [stlcstrParam] stone_soup-0.34.1/source/player-notices.cc:437:13: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream] stone_soup-0.34.1/source/potion.cc:50:46: style:inconclusive: Function 'PotionEffect' argument 1 names different: declaration '' definition 'pot'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/potion.h:19:36: style:inconclusive: Function 'can_quaff' argument 1 names different: declaration 'reason' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/potion.h:19:59: style:inconclusive: Function 'can_quaff' argument 2 names different: declaration 'temp' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/player-notices.cc:310:17: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-equip.cc:738:19: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-equip.cc:780:29: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-equip.cc:939:31: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-equip.cc:1041:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-equip.cc:1058:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-equip.cc:1072:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-equip.cc:1083:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-equip.cc:1196:18: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-equip.cc:1314:24: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-equip.cc:1400:18: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/player-equip.cc:1354:9: style: Unused variable: max [unusedVariable] stone_soup-0.34.1/source/prompt.cc:132:0: debug: Function::addArguments found argument 'map' with varid 0. [varid0] stone_soup-0.34.1/source/rltiles/tool/main.cc:6:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/rltiles/tool/main.cc:51:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/rltiles/tool/tile_colour.h:34:5: warning: Member variable 'tile_colour::r' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/rltiles/tool/tile_colour.h:34:5: warning: Member variable 'tile_colour::g' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/rltiles/tool/tile_colour.h:34:5: warning: Member variable 'tile_colour::b' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/rltiles/tool/tile_colour.h:34:5: warning: Member variable 'tile_colour::a' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/rltiles/tool/tile.cc:364:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ray.cc:522:9: style: The if condition is the same as the previous if condition [duplicateCondition] stone_soup-0.34.1/source/ray.cc:516:9: note: First condition stone_soup-0.34.1/source/ray.cc:522:9: note: Second condition stone_soup-0.34.1/source/rltiles/tool/tile.cc:322:12: style: The member function 'tile::compose' can be static. [functionStatic] stone_soup-0.34.1/source/rltiles/tool/tile.h:65:10: note: The member function 'tile::compose' can be static. stone_soup-0.34.1/source/rltiles/tool/tile.cc:322:12: note: The member function 'tile::compose' can be static. stone_soup-0.34.1/source/rltiles/tool/tile.cc:85:12: style:inconclusive: Technically the member function 'tile::shrink' can be const. [functionConst] stone_soup-0.34.1/source/rltiles/tool/tile.h:78:10: note: Technically the member function 'tile::shrink' can be const. stone_soup-0.34.1/source/rltiles/tool/tile.cc:85:12: note: Technically the member function 'tile::shrink' can be const. stone_soup-0.34.1/source/rltiles/tool/tile.cc:542:20: style: The member function 'tile::get_pixel' can be static. [functionStatic] stone_soup-0.34.1/source/rltiles/tool/tile.h:83:18: note: The member function 'tile::get_pixel' can be static. stone_soup-0.34.1/source/rltiles/tool/tile.cc:542:20: note: The member function 'tile::get_pixel' can be static. stone_soup-0.34.1/source/rltiles/tool/tile.cc:248:26: style: Variable 'mapped' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/rltiles/tool/tile.cc:531:40: style: Parameter 'find' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/rltiles/tool/tile.cc:531:59: style: Parameter 'replace' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/rltiles/tool/tile_colour.cc:87:36: style:inconclusive: Function 'set_from_hue' argument 1 names different: declaration 'hue' definition 'h'. [funcArgNamesDifferent] stone_soup-0.34.1/source/rltiles/tool/tile_colour.h:59:27: note: Function 'set_from_hue' argument 1 names different: declaration 'hue' definition 'h'. stone_soup-0.34.1/source/rltiles/tool/tile_colour.cc:87:36: note: Function 'set_from_hue' argument 1 names different: declaration 'hue' definition 'h'. stone_soup-0.34.1/source/rltiles/tool/tile_page.cc:137:17: style: The member function 'tile_page::write_image' can be static. [functionStatic] stone_soup-0.34.1/source/rltiles/tool/tile_page.h:17:10: note: The member function 'tile_page::write_image' can be static. stone_soup-0.34.1/source/rltiles/tool/tile_page.cc:137:17: note: The member function 'tile_page::write_image' can be static. stone_soup-0.34.1/source/rltiles/tool/tile_page.cc:67:24: style: Variable 'xmax' is assigned an expression that holds the same value. [redundantAssignment] stone_soup-0.34.1/source/rltiles/tool/tile_page.cc:66:22: note: xcur is assigned 'xmax' here. stone_soup-0.34.1/source/rltiles/tool/tile_page.cc:67:24: note: Variable 'xmax' is assigned an expression that holds the same value. stone_soup-0.34.1/source/rltiles/tool/tile_page.cc:113:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/rltiles/tool/tile_page.cc:122:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:114:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:366:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:1079:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/prompt.cc:191:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TILEG_PROMPT_YES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/randbook.cc:480:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/randbook.cc:782:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:318:11: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:333:26: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:41:27: style:inconclusive: Technically the member function 'tile_list_processor::load_image_from_tile' can be const. [functionConst] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.h:19:10: note: Technically the member function 'tile_list_processor::load_image_from_tile' can be const. stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:41:27: note: Technically the member function 'tile_list_processor::load_image_from_tile' can be const. stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:303:27: style:inconclusive: Technically the member function 'tile_list_processor::maybe_mirror' can be const. [functionConst] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.h:24:10: note: Technically the member function 'tile_list_processor::maybe_mirror' can be const. stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:303:27: note: Technically the member function 'tile_list_processor::maybe_mirror' can be const. stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:1031:27: style: The member function 'tile_list_processor::add_abstracts' can be static. [functionStatic] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.h:26:10: note: The member function 'tile_list_processor::add_abstracts' can be static. stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:1031:27: note: The member function 'tile_list_processor::add_abstracts' can be static. stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:38:16: warning: Class 'tile_list_processor' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:38:16: warning: Class 'tile_list_processor' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:1124:22: style: Local variable 'filename' shadows outer variable [shadowVariable] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:1114:18: note: Shadowed declaration stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:1124:22: note: Shadow variable stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:1468:35: style: Local variable 'c' shadows outer variable [shadowVariable] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:1463:22: note: Shadowed declaration stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:1468:35: note: Shadow variable stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:41:66: performance: Function parameter 'filename' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:991:43: style: Parameter 'img' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:495:23: style: Variable 'back' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:946:19: style: Variable 'back' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:213:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:239:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:577:17: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:769:17: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:804:17: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:1243:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/rltiles/tool/tile_list_processor.cc:1476:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] stone_soup-0.34.1/source/random.cc:44:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable uint64_t [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/randbook.cc:872:9: style: Condition '!god_gift' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/randbook.cc:868:9: note: Assuming that condition 'god_gift' is not redundant stone_soup-0.34.1/source/randbook.cc:872:9: note: Condition '!god_gift' is always true stone_soup-0.34.1/source/prompt.cc:37:9: style: Class 'message_scroller' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/randbook.cc:458:18: style: Local variable 'lookup' shadows outer function [shadowFunction] stone_soup-0.34.1/source/libutil.h:197:25: note: Shadowed declaration stone_soup-0.34.1/source/randbook.cc:458:18: note: Shadow variable stone_soup-0.34.1/source/randbook.cc:748:16: style: Local variable 'lookup' shadows outer function [shadowFunction] stone_soup-0.34.1/source/libutil.h:197:25: note: Shadowed declaration stone_soup-0.34.1/source/randbook.cc:748:16: note: Shadow variable stone_soup-0.34.1/source/randbook.cc:846:26: style: Local variable 'lookup' shadows outer function [shadowFunction] stone_soup-0.34.1/source/libutil.h:197:25: note: Shadowed declaration stone_soup-0.34.1/source/randbook.cc:846:26: note: Shadow variable stone_soup-0.34.1/source/randbook.cc:859:22: style: Local variable 'lookup' shadows outer function [shadowFunction] stone_soup-0.34.1/source/libutil.h:197:25: note: Shadowed declaration stone_soup-0.34.1/source/randbook.cc:859:22: note: Shadow variable stone_soup-0.34.1/source/randbook.cc:293:47: performance: Function parameter 'owner' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/randbook.cc:293:61: performance: Function parameter 'subject' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/randbook.cc:671:51: performance: Function parameter 'subject' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/randbook.cc:693:46: performance: Function parameter 'owner' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/randbook.cc:716:41: performance: Function parameter 'subject' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/randbook.cc:716:57: performance: Function parameter 'owner' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/randbook.cc:859:22: style: Variable 'lookup' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/randbook.cc:978:56: style: Parameter 'possible_spells' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/randbook.cc:43:21: style: Consider using std::copy algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/randbook.cc:73:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/randbook.cc:176:25: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/prompt.cc:132:0: style:inconclusive: Function 'yesno' argument 7 names different: declaration '' definition 'map'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/prompt.cc:346:11: style: Local variable 'end' shadows outer function [shadowFunction] stone_soup-0.34.1/source/end.h:14:15: note: Shadowed declaration stone_soup-0.34.1/source/prompt.cc:346:11: note: Shadow variable stone_soup-0.34.1/source/prompt.cc:364:11: style: Local variable 'end' shadows outer function [shadowFunction] stone_soup-0.34.1/source/end.h:14:15: note: Shadowed declaration stone_soup-0.34.1/source/prompt.cc:364:11: note: Shadow variable stone_soup-0.34.1/source/prompt.cc:37:33: performance: Function parameter 'text' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/prompt.cc:37:46: performance: Function parameter 'title' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/prompt.cc:37:63: performance: Function parameter 'prompt' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/prompt.cc:70:24: performance: Function parameter 'msg' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/prompt.cc:70:36: performance: Function parameter 'title' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/prompt.cc:70:50: performance: Function parameter 'prompt' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/prompt.cc:83:22: performance: Function parameter 'err' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/prompt.cc:444:21: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/prompt.cc:459:21: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/prompt.cc:445:19: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/randbook.cc:89:21: style: Variable 'seen.second' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/fixedvector.h:54:10: style: The member function 'FixedVector < PcgRNG , rng :: NUM_RNGS >::empty' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:55:12: style: The member function 'FixedVector < PcgRNG , rng :: NUM_RNGS >::size' can be static. [functionStatic] stone_soup-0.34.1/source/fixedvector.h:42:5: style: Class 'FixedVector < PcgRNG , rng :: NUM_RNGS >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/random.cc:170:36: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] stone_soup-0.34.1/source/random.cc:454:28: style:inconclusive: Function 'decimal_chance' argument 1 names different: declaration 'percent' definition 'chance'. [funcArgNamesDifferent] stone_soup-0.34.1/source/random.h:96:28: note: Function 'decimal_chance' argument 1 names different: declaration 'percent' definition 'chance'. stone_soup-0.34.1/source/random.cc:454:28: note: Function 'decimal_chance' argument 1 names different: declaration 'percent' definition 'chance'. stone_soup-0.34.1/source/random.cc:34:19: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/random.cc:46:20: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/random.cc:170:21: style: Variable 'seeded' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/scroller.cc:40:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_scroll [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/scroller.h:21:5: warning: Member variable 'formatted_scroller::m_scroll_dirty' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/scroller.h:27:5: warning: Member variable 'formatted_scroller::m_scroll_dirty' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/scroller.cc:38:5: style: Class 'UIHookedScroller' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/scroller.cc:16:71: style:inconclusive: Function 'add_formatted_string' argument 1 names different: declaration 's' definition 'fs'. [funcArgNamesDifferent] stone_soup-0.34.1/source/scroller.h:29:63: note: Function 'add_formatted_string' argument 1 names different: declaration 's' definition 'fs'. stone_soup-0.34.1/source/scroller.cc:16:71: note: Function 'add_formatted_string' argument 1 names different: declaration 's' definition 'fs'. stone_soup-0.34.1/source/scroller.cc:181:48: style:inconclusive: Function 'process_key' argument 1 names different: declaration 'keyin' definition 'ch'. [funcArgNamesDifferent] stone_soup-0.34.1/source/scroller.h:63:40: note: Function 'process_key' argument 1 names different: declaration 'keyin' definition 'ch'. stone_soup-0.34.1/source/scroller.cc:181:48: note: Function 'process_key' argument 1 names different: declaration 'keyin' definition 'ch'. stone_soup-0.34.1/source/shopping.cc:1042:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable show_background [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/shopping.cc:1055:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACT_EXAMINE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/shopping.cc:1169:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACT_EXECUTE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/shopping.cc:1423:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACT_EXECUTE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/shopping.cc:2577:74: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable id [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/skills.cc:266:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_HUMAN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/skills.cc:1909:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_COGLIN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/skills.cc:1964:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_FELID [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/skills.cc:2050:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_FELID [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/skills.cc:2561:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NUM_SPECIES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/skill-menu.cc:512:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_CHARLATANS_ORB [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/skill-menu.cc:522:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_HERMITS_PENDANT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/skill-menu.cc:532:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_HERMITS_PENDANT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/skill-menu.cc:1768:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/shout.cc:201:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/shout.cc:320:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/shout.cc:786:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UNRAND_THIEF [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/skill-menu.cc:76:17: warning: Member variable 'SkillMenuEntry::m_sk' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/skill-menu.cc:475:18: warning: Member variable 'SkillMenuSwitch::m_state' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/skill-menu.cc:746:12: warning: Member variable 'SkillMenu::m_ff' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/skill-menu.cc:746:12: warning: Member variable 'SkillMenu::m_highlighter' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/skill-menu.cc:746:12: warning: Member variable 'SkillMenu::m_flags' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/skill-menu.cc:746:12: warning: Member variable 'SkillMenu::m_title' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/skill-menu.cc:746:12: warning: Member variable 'SkillMenu::m_help' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/skill-menu.cc:746:12: warning: Member variable 'SkillMenu::m_middle_button' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/skill-menu.cc:746:12: warning: Member variable 'SkillMenu::m_clear_targets_button' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/skill-menu.cc:1728:5: warning: Member variable 'Widget::cached_sr' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/skill-menu.cc:1728:5: warning: Member variable 'Widget::cached_sr_pw' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/skill-menu.cc:109:21: style:inconclusive: Technically the member function 'SkillMenuEntry::get_id' can be const. [functionConst] stone_soup-0.34.1/source/skill-menu.h:75:9: note: Technically the member function 'SkillMenuEntry::get_id' can be const. stone_soup-0.34.1/source/skill-menu.cc:109:21: note: Technically the member function 'SkillMenuEntry::get_id' can be const. stone_soup-0.34.1/source/skill-menu.cc:137:22: style:inconclusive: Technically the member function 'SkillMenuEntry::is_selectable' can be const. [functionConst] stone_soup-0.34.1/source/skill-menu.h:78:10: note: Technically the member function 'SkillMenuEntry::is_selectable' can be const. stone_soup-0.34.1/source/skill-menu.cc:137:22: note: Technically the member function 'SkillMenuEntry::is_selectable' can be const. stone_soup-0.34.1/source/skill-menu.cc:155:22: style: The member function 'SkillMenuEntry::is_set' can be static. [functionStatic] stone_soup-0.34.1/source/skill-menu.h:79:10: note: The member function 'SkillMenuEntry::is_set' can be static. stone_soup-0.34.1/source/skill-menu.cc:155:22: note: The member function 'SkillMenuEntry::is_set' can be static. stone_soup-0.34.1/source/skill-menu.cc:295:24: style:inconclusive: Technically the member function 'SkillMenuEntry::get_prefix' can be const. [functionConst] stone_soup-0.34.1/source/skill-menu.h:102:12: note: Technically the member function 'SkillMenuEntry::get_prefix' can be const. stone_soup-0.34.1/source/skill-menu.cc:295:24: note: Technically the member function 'SkillMenuEntry::get_prefix' can be const. stone_soup-0.34.1/source/skill-menu.cc:551:25: style:inconclusive: Technically the member function 'SkillMenuSwitch::get_help' can be const. [functionConst] stone_soup-0.34.1/source/skill-menu.h:118:12: note: Technically the member function 'SkillMenuSwitch::get_help' can be const. stone_soup-0.34.1/source/skill-menu.cc:551:25: note: Technically the member function 'SkillMenuSwitch::get_help' can be const. stone_soup-0.34.1/source/skill-menu.cc:655:25: style: The member function 'SkillMenuSwitch::get_name' can be static. [functionStatic] stone_soup-0.34.1/source/skill-menu.h:119:12: note: The member function 'SkillMenuSwitch::get_name' can be static. stone_soup-0.34.1/source/skill-menu.cc:655:25: note: The member function 'SkillMenuSwitch::get_name' can be static. stone_soup-0.34.1/source/skill-menu.cc:487:35: style:inconclusive: Technically the member function 'SkillMenuSwitch::get_state' can be const. [functionConst] stone_soup-0.34.1/source/skill-menu.h:120:22: note: Technically the member function 'SkillMenuSwitch::get_state' can be const. stone_soup-0.34.1/source/skill-menu.cc:487:35: note: Technically the member function 'SkillMenuSwitch::get_state' can be const. stone_soup-0.34.1/source/skill-menu.cc:1094:16: style:inconclusive: Technically the member function 'SkillMenu::get_raw_skill_level' can be const. [functionConst] stone_soup-0.34.1/source/skill-menu.h:153:9: note: Technically the member function 'SkillMenu::get_raw_skill_level' can be const. stone_soup-0.34.1/source/skill-menu.cc:1094:16: note: Technically the member function 'SkillMenu::get_raw_skill_level' can be const. stone_soup-0.34.1/source/skill-menu.cc:1099:16: style:inconclusive: Technically the member function 'SkillMenu::get_saved_skill_level' can be const. [functionConst] stone_soup-0.34.1/source/skill-menu.h:154:9: note: Technically the member function 'SkillMenu::get_saved_skill_level' can be const. stone_soup-0.34.1/source/skill-menu.cc:1099:16: note: Technically the member function 'SkillMenu::get_saved_skill_level' can be const. stone_soup-0.34.1/source/skill-menu.cc:1660:17: style: The member function 'SkillMenu::show_description' can be static. [functionStatic] stone_soup-0.34.1/source/skill-menu.h:204:10: note: The member function 'SkillMenu::show_description' can be static. stone_soup-0.34.1/source/skill-menu.cc:1660:17: note: The member function 'SkillMenu::show_description' can be static. stone_soup-0.34.1/source/skill-menu.cc:81:5: warning: Class 'SkillMenuEntry' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] stone_soup-0.34.1/source/skill-menu.cc:81:5: warning: Class 'SkillMenuEntry' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] stone_soup-0.34.1/source/skill-menu.cc:1728:5: style: Class 'UISkillMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/skill-menu.cc:1729:6: style: The destructor '~UISkillMenu' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] stone_soup-0.34.1/source/ui.h:292:14: note: Virtual destructor in base class stone_soup-0.34.1/source/skill-menu.cc:1729:6: note: Destructor in derived class stone_soup-0.34.1/source/shopping.cc:2251:20: style:inconclusive: Technically the member function 'ShoppingList::move_things' can be const. [functionConst] stone_soup-0.34.1/source/shopping.h:104:10: note: Technically the member function 'ShoppingList::move_things' can be const. stone_soup-0.34.1/source/shopping.cc:2251:20: note: Technically the member function 'ShoppingList::move_things' can be const. stone_soup-0.34.1/source/shopping.cc:2223:38: style:inconclusive: Technically the member function 'ShoppingList::entries' can be const. [functionConst] stone_soup-0.34.1/source/shopping.h:114:28: note: Technically the member function 'ShoppingList::entries' can be const. stone_soup-0.34.1/source/shopping.cc:2223:38: note: Technically the member function 'ShoppingList::entries' can be const. stone_soup-0.34.1/source/shopping.cc:2416:20: style:inconclusive: Technically the member function 'ShoppingList::fill_out_menu' can be const. [functionConst] stone_soup-0.34.1/source/shopping.h:139:10: note: Technically the member function 'ShoppingList::fill_out_menu' can be const. stone_soup-0.34.1/source/shopping.cc:2416:20: note: Technically the member function 'ShoppingList::fill_out_menu' can be const. stone_soup-0.34.1/source/shopping.cc:2339:5: style: Class 'ShoppingListMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/shopping.cc:286:31: style: The if condition is the same as the previous if condition [duplicateCondition] stone_soup-0.34.1/source/shopping.cc:243:31: note: First condition stone_soup-0.34.1/source/shopping.cc:286:31: note: Second condition stone_soup-0.34.1/source/shopping.cc:424:31: style: The if condition is the same as the previous if condition [duplicateCondition] stone_soup-0.34.1/source/shopping.cc:355:31: note: First condition stone_soup-0.34.1/source/shopping.cc:424:31: note: Second condition stone_soup-0.34.1/source/shopping.cc:1011:21: style: Condition 'selected()' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/shopping.cc:1010:13: note: Assuming that condition '!selected()' is not redundant stone_soup-0.34.1/source/shopping.cc:1011:21: note: Condition 'selected()' is always true stone_soup-0.34.1/source/skill-menu.cc:1556:25: style: The scope of the variable 'skme' can be reduced. [variableScope] stone_soup-0.34.1/source/skill-menu.h:78:29: style:inconclusive: Function 'is_selectable' argument 1 names different: declaration 'keep_hotkey' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/skill-menu.cc:1732:60: style:inconclusive: Function '_get_preferred_size' argument 2 names different: declaration 'prosp_width' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/skill-menu.cc:475:41: performance: Function parameter 'name' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/skill-menu.cc:1531:33: performance: Function parameter 'msg' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/skill-menu.cc:901:48: style: Parameter 'ch' can be declared as reference to const. However it seems that '_keyfun_target_input' is a callback function, if 'ch' is declared with const you might also need to cast function pointer(s). [constParameterCallback] stone_soup-0.34.1/source/skill-menu.cc:941:46: note: You might need to cast the function pointer here stone_soup-0.34.1/source/skill-menu.cc:901:48: note: Parameter 'ch' can be declared as reference to const stone_soup-0.34.1/source/skill-menu.cc:909:17: style: Variable 'locale_data' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/showsymb.cc:216:29: style: Condition 'mi.attitude==ATT_HOSTILE' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/showsymb.cc:203:26: note: Assuming that condition 'mi.attitude!=ATT_HOSTILE' is not redundant stone_soup-0.34.1/source/showsymb.cc:216:29: note: Condition 'mi.attitude==ATT_HOSTILE' is always true stone_soup-0.34.1/source/shopping.cc:1475:22: style: The scope of the variable 'cost' can be reduced. [variableScope] stone_soup-0.34.1/source/skill-menu.cc:687:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/shopping.cc:1799:47: style:inconclusive: Function 'add_thing' argument 3 names different: declaration 'pos' definition '_pos'. [funcArgNamesDifferent] stone_soup-0.34.1/source/shopping.h:84:37: note: Function 'add_thing' argument 3 names different: declaration 'pos' definition '_pos'. stone_soup-0.34.1/source/shopping.cc:1799:47: note: Function 'add_thing' argument 3 names different: declaration 'pos' definition '_pos'. stone_soup-0.34.1/source/shopping.cc:1823:70: style:inconclusive: Function 'is_on_list' argument 2 names different: declaration 'pos' definition '_pos'. [funcArgNamesDifferent] stone_soup-0.34.1/source/shopping.h:86:60: note: Function 'is_on_list' argument 2 names different: declaration 'pos' definition '_pos'. stone_soup-0.34.1/source/shopping.cc:1823:70: note: Function 'is_on_list' argument 2 names different: declaration 'pos' definition '_pos'. stone_soup-0.34.1/source/shopping.cc:1830:61: style:inconclusive: Function 'is_on_list' argument 2 names different: declaration 'pos' definition '_pos'. [funcArgNamesDifferent] stone_soup-0.34.1/source/shopping.h:87:51: note: Function 'is_on_list' argument 2 names different: declaration 'pos' definition '_pos'. stone_soup-0.34.1/source/shopping.cc:1830:61: note: Function 'is_on_list' argument 2 names different: declaration 'pos' definition '_pos'. stone_soup-0.34.1/source/shopping.cc:1870:47: style:inconclusive: Function 'del_thing' argument 2 names different: declaration 'pos' definition '_pos'. [funcArgNamesDifferent] stone_soup-0.34.1/source/shopping.h:89:59: note: Function 'del_thing' argument 2 names different: declaration 'pos' definition '_pos'. stone_soup-0.34.1/source/shopping.cc:1870:47: note: Function 'del_thing' argument 2 names different: declaration 'pos' definition '_pos'. stone_soup-0.34.1/source/shopping.cc:1887:60: style:inconclusive: Function 'del_thing' argument 2 names different: declaration 'pos' definition '_pos'. [funcArgNamesDifferent] stone_soup-0.34.1/source/shopping.h:90:50: note: Function 'del_thing' argument 2 names different: declaration 'pos' definition '_pos'. stone_soup-0.34.1/source/shopping.cc:1887:60: note: Function 'del_thing' argument 2 names different: declaration 'pos' definition '_pos'. stone_soup-0.34.1/source/shopping.cc:2251:49: style:inconclusive: Function 'move_things' argument 1 names different: declaration 'src' definition '_src'. [funcArgNamesDifferent] stone_soup-0.34.1/source/shopping.h:104:39: note: Function 'move_things' argument 1 names different: declaration 'src' definition '_src'. stone_soup-0.34.1/source/shopping.cc:2251:49: note: Function 'move_things' argument 1 names different: declaration 'src' definition '_src'. stone_soup-0.34.1/source/shopping.cc:2251:72: style:inconclusive: Function 'move_things' argument 2 names different: declaration 'dst' definition '_dst'. [funcArgNamesDifferent] stone_soup-0.34.1/source/shopping.h:104:61: note: Function 'move_things' argument 2 names different: declaration 'dst' definition '_dst'. stone_soup-0.34.1/source/shopping.cc:2251:72: note: Function 'move_things' argument 2 names different: declaration 'dst' definition '_dst'. stone_soup-0.34.1/source/shopping.cc:2125:28: style: Local variable 'shop' shadows outer function [shadowFunction] stone_soup-0.34.1/source/shopping.h:30:6: note: Shadowed declaration stone_soup-0.34.1/source/shopping.cc:2125:28: note: Shadow variable stone_soup-0.34.1/source/shopping.cc:1830:38: performance: Function parameter 'desc' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/shopping.cc:1887:37: performance: Function parameter 'desc' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/shopping.cc:1314:19: style: Variable 'item' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/shopping.cc:1372:20: style: Variable 'entry' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/shopping.cc:2081:16: style: Variable 'p' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/shopping.cc:2144:26: style: Variable 'thing' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/shopping.cc:1092:18: style: Variable 'e' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/shopping.cc:1103:15: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/shopping.cc:1109:18: style: Variable 'e' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/shopping.cc:1249:18: style: Variable 'e' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/shopping.cc:886:15: performance: Passing the result of c_str() to a function that takes std::string as argument no. 4 is slow and redundant. [stlcstrParam] stone_soup-0.34.1/source/shopping.cc:2486:9: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] stone_soup-0.34.1/source/shopping.cc:854:13: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/shopping.cc:1087:14: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/shopping.cc:1104:14: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/shopping.cc:1373:19: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/shopping.cc:2230:22: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/shopping.cc:2422:17: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/shout.cc:734:14: style: Condition 'target' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/showsymb.cc:270:23: style: Variable 'gly' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/showsymb.cc:460:19: style: Variable 'weapon' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/shout.cc:735:46: warning: Either the condition 'target' is redundant or there is possible null pointer dereference: target. [nullPointerRedundantCheck] stone_soup-0.34.1/source/shout.cc:734:14: note: Assuming that condition 'target' is not redundant stone_soup-0.34.1/source/shout.cc:735:46: note: Null pointer dereference stone_soup-0.34.1/source/shout.cc:153:39: style:inconclusive: Function 'monster_shout' argument 2 names different: declaration 's_type' definition 'shout'. [funcArgNamesDifferent] stone_soup-0.34.1/source/shout.h:19:39: note: Function 'monster_shout' argument 2 names different: declaration 's_type' definition 'shout'. stone_soup-0.34.1/source/shout.cc:153:39: note: Function 'monster_shout' argument 2 names different: declaration 's_type' definition 'shout'. stone_soup-0.34.1/source/shout.cc:384:38: style:inconclusive: Function 'noisy_equipment' argument 1 names different: declaration 'item' definition 'weapon'. [funcArgNamesDifferent] stone_soup-0.34.1/source/shout.h:15:38: note: Function 'noisy_equipment' argument 1 names different: declaration 'item' definition 'weapon'. stone_soup-0.34.1/source/shout.cc:384:38: note: Function 'noisy_equipment' argument 1 names different: declaration 'item' definition 'weapon'. stone_soup-0.34.1/source/shout.cc:767:16: style:inconclusive: Function 'noisy' argument 1 names different: declaration 'loudness' definition 'original_loudness'. [funcArgNamesDifferent] stone_soup-0.34.1/source/shout.h:7:16: note: Function 'noisy' argument 1 names different: declaration 'loudness' definition 'original_loudness'. stone_soup-0.34.1/source/shout.cc:767:16: note: Function 'noisy' argument 1 names different: declaration 'loudness' definition 'original_loudness'. stone_soup-0.34.1/source/shout.cc:872:38: style:inconclusive: Function 'can_apply_noise' argument 1 names different: declaration 'noise_intensity_millis' definition '_noise_intensity_millis'. [funcArgNamesDifferent] stone_soup-0.34.1/source/noise.h:81:30: note: Function 'can_apply_noise' argument 1 names different: declaration 'noise_intensity_millis' definition '_noise_intensity_millis'. stone_soup-0.34.1/source/shout.cc:872:38: note: Function 'can_apply_noise' argument 1 names different: declaration 'noise_intensity_millis' definition '_noise_intensity_millis'. stone_soup-0.34.1/source/shout.cc:877:34: style:inconclusive: Function 'apply_noise' argument 1 names different: declaration 'noise_intensity_millis' definition '_noise_intensity_millis'. [funcArgNamesDifferent] stone_soup-0.34.1/source/noise.h:82:26: note: Function 'apply_noise' argument 1 names different: declaration 'noise_intensity_millis' definition '_noise_intensity_millis'. stone_soup-0.34.1/source/shout.cc:877:34: note: Function 'apply_noise' argument 1 names different: declaration 'noise_intensity_millis' definition '_noise_intensity_millis'. stone_soup-0.34.1/source/shout.cc:878:34: style:inconclusive: Function 'apply_noise' argument 2 names different: declaration 'noise_id' definition '_noise_id'. [funcArgNamesDifferent] stone_soup-0.34.1/source/noise.h:83:26: note: Function 'apply_noise' argument 2 names different: declaration 'noise_id' definition '_noise_id'. stone_soup-0.34.1/source/shout.cc:878:34: note: Function 'apply_noise' argument 2 names different: declaration 'noise_id' definition '_noise_id'. stone_soup-0.34.1/source/shout.cc:879:34: style:inconclusive: Function 'apply_noise' argument 3 names different: declaration 'travel_distance' definition '_noise_travel_distance'. [funcArgNamesDifferent] stone_soup-0.34.1/source/noise.h:84:26: note: Function 'apply_noise' argument 3 names different: declaration 'travel_distance' definition '_noise_travel_distance'. stone_soup-0.34.1/source/shout.cc:879:34: note: Function 'apply_noise' argument 3 names different: declaration 'travel_distance' definition '_noise_travel_distance'. stone_soup-0.34.1/source/shout.cc:880:47: style:inconclusive: Function 'apply_noise' argument 4 names different: declaration 'neighbour_delta' definition '_neighbour_delta'. [funcArgNamesDifferent] stone_soup-0.34.1/source/noise.h:85:39: note: Function 'apply_noise' argument 4 names different: declaration 'neighbour_delta' definition '_neighbour_delta'. stone_soup-0.34.1/source/shout.cc:880:47: note: Function 'apply_noise' argument 4 names different: declaration 'neighbour_delta' definition '_neighbour_delta'. stone_soup-0.34.1/source/shout.cc:1017:64: style:inconclusive: Function 'propagate_noise_to_neighbour' argument 4 names different: declaration 'pos' definition 'current_pos'. [funcArgNamesDifferent] stone_soup-0.34.1/source/noise.h:133:56: note: Function 'propagate_noise_to_neighbour' argument 4 names different: declaration 'pos' definition 'current_pos'. stone_soup-0.34.1/source/shout.cc:1017:64: note: Function 'propagate_noise_to_neighbour' argument 4 names different: declaration 'pos' definition 'current_pos'. stone_soup-0.34.1/source/shout.cc:1018:64: style:inconclusive: Function 'propagate_noise_to_neighbour' argument 5 names different: declaration 'next_position' definition 'next_pos'. [funcArgNamesDifferent] stone_soup-0.34.1/source/noise.h:134:56: note: Function 'propagate_noise_to_neighbour' argument 5 names different: declaration 'next_position' definition 'next_pos'. stone_soup-0.34.1/source/shout.cc:1018:64: note: Function 'propagate_noise_to_neighbour' argument 5 names different: declaration 'next_position' definition 'next_pos'. stone_soup-0.34.1/source/shout.cc:1105:65: style:inconclusive: Function 'noise_perceived_position' argument 2 names different: declaration 'affected_position' definition 'affected_pos'. [funcArgNamesDifferent] stone_soup-0.34.1/source/noise.h:140:57: note: Function 'noise_perceived_position' argument 2 names different: declaration 'affected_position' definition 'affected_pos'. stone_soup-0.34.1/source/shout.cc:1105:65: note: Function 'noise_perceived_position' argument 2 names different: declaration 'affected_position' definition 'affected_pos'. stone_soup-0.34.1/source/shopping.cc:1133:13: style: Unused variable: max [unusedVariable] stone_soup-0.34.1/source/shout.cc:302:46: style: Parameter 'act' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/shout.cc:924:17: style: Variable 'target_cell' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/shout.cc:244:33: style: Parameter 'mons' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/shout.cc:406:38: style: Parameter 'mon' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/shout.cc:624:14: style: Variable 'non_sinv_ally' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/shout.cc:1104:55: style: Parameter 'act' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/species.cc:33:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:64:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:83:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_UNKNOWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:120:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_BASE_DRACONIAN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:136:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_DEEP_ELF [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:155:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NUM_SPECIES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:316:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_GARGOYLE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:361:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_ARMATAUR [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:468:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_NAGA [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:490:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_FELID [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:507:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_COGLIN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:517:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_OCTOPODE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:573:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NUM_SPECIES [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:595:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_MOTTLED_DRACONIAN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:610:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable species_type [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:737:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_DEMONSPAWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/species.cc:49:47: style:inconclusive: Function 'name' argument 2 names different: declaration 'spname' definition 'spname_type'. [funcArgNamesDifferent] stone_soup-0.34.1/source/species.h:27:47: note: Function 'name' argument 2 names different: declaration 'spname' definition 'spname_type'. stone_soup-0.34.1/source/species.cc:49:47: note: Function 'name' argument 2 names different: declaration 'spname' definition 'spname_type'. stone_soup-0.34.1/source/species.cc:78:47: style:inconclusive: Function 'from_str_loose' argument 1 names different: declaration 'species_str' definition 'species'. [funcArgNamesDifferent] stone_soup-0.34.1/source/species.h:31:47: note: Function 'from_str_loose' argument 1 names different: declaration 'species_str' definition 'species'. stone_soup-0.34.1/source/species.cc:78:47: note: Function 'from_str_loose' argument 1 names different: declaration 'species_str' definition 'species'. stone_soup-0.34.1/source/species.cc:375:36: style:inconclusive: Function 'child_name' argument 1 names different: declaration 'species' definition 'sp'. [funcArgNamesDifferent] stone_soup-0.34.1/source/species.h:64:36: note: Function 'child_name' argument 1 names different: declaration 'species' definition 'sp'. stone_soup-0.34.1/source/species.cc:375:36: note: Function 'child_name' argument 1 names different: declaration 'species' definition 'sp'. stone_soup-0.34.1/source/species.cc:387:34: style:inconclusive: Function 'orc_name' argument 1 names different: declaration 'species' definition 'sp'. [funcArgNamesDifferent] stone_soup-0.34.1/source/species.h:65:34: note: Function 'orc_name' argument 1 names different: declaration 'species' definition 'sp'. stone_soup-0.34.1/source/species.cc:387:34: note: Function 'orc_name' argument 1 names different: declaration 'species' definition 'sp'. stone_soup-0.34.1/source/species.cc:399:42: style:inconclusive: Function 'orcification_msg' argument 1 names different: declaration 'species' definition 'sp'. [funcArgNamesDifferent] stone_soup-0.34.1/source/species.h:66:42: note: Function 'orcification_msg' argument 1 names different: declaration 'species' definition 'sp'. stone_soup-0.34.1/source/species.cc:399:42: note: Function 'orcification_msg' argument 1 names different: declaration 'species' definition 'sp'. stone_soup-0.34.1/source/species.cc:463:35: style:inconclusive: Function 'skin_name' argument 1 names different: declaration 'sp' definition 'species'. [funcArgNamesDifferent] stone_soup-0.34.1/source/species.h:69:35: note: Function 'skin_name' argument 1 names different: declaration 'sp' definition 'species'. stone_soup-0.34.1/source/species.cc:463:35: note: Function 'skin_name' argument 1 names different: declaration 'sp' definition 'species'. stone_soup-0.34.1/source/species.cc:122:20: style: Variable 'entry' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/species.cc:756:20: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/species.cc:123:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/sqldbm.cc:420:69: debug: Function::addArguments found argument 'key' with varid 0. [varid0] stone_soup-0.34.1/source/spl-zap.cc:217:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/spl-zap.cc:226:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/spl-zap.cc:235:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/sqldbm.cc:167:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SQLITE_TRANSIENT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/sqldbm.cc:210:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SQLITE_TRANSIENT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/sqldbm.cc:231:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SQLITE_TRANSIENT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/sqldbm.cc:422:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable key [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/sqldbm.cc:41:13: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] stone_soup-0.34.1/source/sqldbm.cc:24:5: style: Class 'sqlite_retry_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/sqldbm.cc:119:9: error: Resource leak: db [resourceLeak] stone_soup-0.34.1/source/sqldbm.cc:123:5: error: Resource leak: db [resourceLeak] stone_soup-0.34.1/source/sqldbm.cc:239:19: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/sqldbm.cc:277:28: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/sqldbm.cc:50:32: style:inconclusive: Function 'SQL_DBM' argument 1 names different: declaration 'db' definition 'dbname'. [funcArgNamesDifferent] stone_soup-0.34.1/source/sqldbm.h:50:27: note: Function 'SQL_DBM' argument 1 names different: declaration 'db' definition 'dbname'. stone_soup-0.34.1/source/sqldbm.cc:50:32: note: Function 'SQL_DBM' argument 1 names different: declaration 'db' definition 'dbname'. stone_soup-0.34.1/source/sqldbm.cc:50:45: style:inconclusive: Function 'SQL_DBM' argument 2 names different: declaration 'readonly' definition '_readonly'. [funcArgNamesDifferent] stone_soup-0.34.1/source/sqldbm.h:50:41: note: Function 'SQL_DBM' argument 2 names different: declaration 'readonly' definition '_readonly'. stone_soup-0.34.1/source/sqldbm.cc:50:45: note: Function 'SQL_DBM' argument 2 names different: declaration 'readonly' definition '_readonly'. stone_soup-0.34.1/source/sqldbm.cc:50:61: style:inconclusive: Function 'SQL_DBM' argument 3 names different: declaration 'open' definition 'do_open'. [funcArgNamesDifferent] stone_soup-0.34.1/source/sqldbm.h:50:63: note: Function 'SQL_DBM' argument 3 names different: declaration 'open' definition 'do_open'. stone_soup-0.34.1/source/sqldbm.cc:50:61: note: Function 'SQL_DBM' argument 3 names different: declaration 'open' definition 'do_open'. stone_soup-0.34.1/source/sqldbm.cc:80:33: style:inconclusive: Function 'open' argument 1 names different: declaration 'db' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/sqldbm.h:55:28: note: Function 'open' argument 1 names different: declaration 'db' definition 's'. stone_soup-0.34.1/source/sqldbm.cc:80:33: note: Function 'open' argument 1 names different: declaration 'db' definition 's'. stone_soup-0.34.1/source/sqldbm.cc:297:44: style:inconclusive: Function 'finalise_query' argument 1 names different: declaration 'query' definition 'q'. [funcArgNamesDifferent] stone_soup-0.34.1/source/sqldbm.h:70:39: note: Function 'finalise_query' argument 1 names different: declaration 'query' definition 'q'. stone_soup-0.34.1/source/sqldbm.cc:297:44: note: Function 'finalise_query' argument 1 names different: declaration 'query' definition 'q'. stone_soup-0.34.1/source/sqldbm.cc:309:43: style:inconclusive: Function 'prepare_query' argument 1 names different: declaration 'query' definition 'q'. [funcArgNamesDifferent] stone_soup-0.34.1/source/sqldbm.h:71:38: note: Function 'prepare_query' argument 1 names different: declaration 'query' definition 'q'. stone_soup-0.34.1/source/sqldbm.cc:309:43: note: Function 'prepare_query' argument 1 names different: declaration 'query' definition 'q'. stone_soup-0.34.1/source/sqldbm.cc:339:39: style:inconclusive: Function 'sql_datum' argument 1 names different: declaration 'other' definition 'dat'. [funcArgNamesDifferent] stone_soup-0.34.1/source/sqldbm.h:27:32: note: Function 'sql_datum' argument 1 names different: declaration 'other' definition 'dat'. stone_soup-0.34.1/source/sqldbm.cc:339:39: note: Function 'sql_datum' argument 1 names different: declaration 'other' definition 'dat'. stone_soup-0.34.1/source/sqldbm.cc:350:52: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'other' definition 'd'. [funcArgNamesDifferent] stone_soup-0.34.1/source/sqldbm.h:30:45: note: Function 'operator=' argument 1 names different: declaration 'other' definition 'd'. stone_soup-0.34.1/source/sqldbm.cc:350:52: note: Function 'operator=' argument 1 names different: declaration 'other' definition 'd'. stone_soup-0.34.1/source/sqldbm.cc:369:44: style:inconclusive: Function 'init_from' argument 1 names different: declaration 'other' definition 'd'. [funcArgNamesDifferent] stone_soup-0.34.1/source/sqldbm.h:42:37: note: Function 'init_from' argument 1 names different: declaration 'other' definition 'd'. stone_soup-0.34.1/source/sqldbm.cc:369:44: note: Function 'init_from' argument 1 names different: declaration 'other' definition 'd'. stone_soup-0.34.1/source/sqldbm.cc:396:45: style:inconclusive: Function 'dbm_open' argument 2 names different: declaration 'open_mode' definition 'mode'. [funcArgNamesDifferent] stone_soup-0.34.1/source/sqldbm.h:93:46: note: Function 'dbm_open' argument 2 names different: declaration 'open_mode' definition 'mode'. stone_soup-0.34.1/source/sqldbm.cc:396:45: note: Function 'dbm_open' argument 2 names different: declaration 'open_mode' definition 'mode'. stone_soup-0.34.1/source/sqldbm.h:93:61: style:inconclusive: Function 'dbm_open' argument 3 names different: declaration 'permissions' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/sqldbm.h:100:43: style:inconclusive: Function 'dbm_store' argument 4 names different: declaration 'overwrite' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/stringutil.cc:164:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/stringutil.cc:323:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/stringutil.cc:341:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/stringutil.cc:359:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/stringutil.cc:373:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/stringutil.cc:407:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/stringutil.cc:436:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/stringutil.cc:456:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/stringutil.cc:500:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/stringutil.cc:555:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/stringutil.cc:611:19: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] stone_soup-0.34.1/source/stringutil.cc:287:18: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/stringutil.cc:88:31: style:inconclusive: Function 'lowercase_first' argument 1 names different: declaration '' definition 's'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/stringutil.cc:99:31: style:inconclusive: Function 'uppercase_first' argument 1 names different: declaration '' definition 's'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/stringutil.cc:173:37: style:inconclusive: Function 'wordwrap_line' argument 2 names different: declaration 'cols' definition 'width'. [funcArgNamesDifferent] stone_soup-0.34.1/source/stringutil.h:37:37: note: Function 'wordwrap_line' argument 2 names different: declaration 'cols' definition 'width'. stone_soup-0.34.1/source/stringutil.cc:173:37: note: Function 'wordwrap_line' argument 2 names different: declaration 'cols' definition 'width'. stone_soup-0.34.1/source/stringutil.cc:277:34: style:inconclusive: Function 'vmake_stringf' argument 1 names different: declaration 'format' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/stringutil.h:42:34: note: Function 'vmake_stringf' argument 1 names different: declaration 'format' definition 's'. stone_soup-0.34.1/source/stringutil.cc:277:34: note: Function 'vmake_stringf' argument 1 names different: declaration 'format' definition 's'. stone_soup-0.34.1/source/stringutil.cc:297:33: style:inconclusive: Function 'make_stringf' argument 1 names different: declaration 'format' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/stringutil.h:43:21: note: Function 'make_stringf' argument 1 names different: declaration 'format' definition 's'. stone_soup-0.34.1/source/stringutil.cc:297:33: note: Function 'make_stringf' argument 1 names different: declaration 'format' definition 's'. stone_soup-0.34.1/source/stringutil.cc:317:44: style:inconclusive: Function 'replace_all' argument 2 names different: declaration 'tofind' definition 'find'. [funcArgNamesDifferent] stone_soup-0.34.1/source/stringutil.h:48:44: note: Function 'replace_all' argument 2 names different: declaration 'tofind' definition 'find'. stone_soup-0.34.1/source/stringutil.cc:317:44: note: Function 'replace_all' argument 2 names different: declaration 'tofind' definition 'find'. stone_soup-0.34.1/source/stringutil.cc:317:64: style:inconclusive: Function 'replace_all' argument 3 names different: declaration 'replacement' definition 'repl'. [funcArgNamesDifferent] stone_soup-0.34.1/source/stringutil.h:48:66: note: Function 'replace_all' argument 3 names different: declaration 'replacement' definition 'repl'. stone_soup-0.34.1/source/stringutil.cc:317:64: note: Function 'replace_all' argument 3 names different: declaration 'replacement' definition 'repl'. stone_soup-0.34.1/source/stringutil.cc:450:57: style:inconclusive: Function 'count_occurrences' argument 2 names different: declaration 'searchfor' definition 's'. [funcArgNamesDifferent] stone_soup-0.34.1/source/stringutil.h:59:57: note: Function 'count_occurrences' argument 2 names different: declaration 'searchfor' definition 's'. stone_soup-0.34.1/source/stringutil.cc:450:57: note: Function 'count_occurrences' argument 2 names different: declaration 'searchfor' definition 's'. stone_soup-0.34.1/source/stringutil.cc:543:63: style:inconclusive: Function 'split_string' argument 3 names different: declaration 'trim' definition 'trim_segments'. [funcArgNamesDifferent] stone_soup-0.34.1/source/stringutil.h:247:63: note: Function 'split_string' argument 3 names different: declaration 'trim' definition 'trim_segments'. stone_soup-0.34.1/source/stringutil.cc:543:63: note: Function 'split_string' argument 3 names different: declaration 'trim' definition 'trim_segments'. stone_soup-0.34.1/source/stringutil.cc:544:34: style:inconclusive: Function 'split_string' argument 4 names different: declaration 'accept_empties' definition 'accept_empty_segments'. [funcArgNamesDifferent] stone_soup-0.34.1/source/stringutil.h:248:34: note: Function 'split_string' argument 4 names different: declaration 'accept_empties' definition 'accept_empty_segments'. stone_soup-0.34.1/source/stringutil.cc:544:34: note: Function 'split_string' argument 4 names different: declaration 'accept_empties' definition 'accept_empty_segments'. stone_soup-0.34.1/source/stringutil.cc:113:23: performance: Function parameter 'str' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/stringutil.cc:70:12: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/stringutil.cc:118:15: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/stringutil.cc:376:38: style: Variable 'cap_end' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/syscalls.cc:98:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable F_RDLCK [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/syscalls.cc:113:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable F_UNLCK [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/syscalls.cc:418:44: style:inconclusive: Function 'get_dir_files' argument 1 names different: declaration 'dir' definition 'dirname'. [funcArgNamesDifferent] stone_soup-0.34.1/source/files.h:46:44: note: Function 'get_dir_files' argument 1 names different: declaration 'dir' definition 'dirname'. stone_soup-0.34.1/source/syscalls.cc:418:44: note: Function 'get_dir_files' argument 1 names different: declaration 'dir' definition 'dirname'. stone_soup-0.34.1/source/spl-book.cc:576:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable right [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/spl-book.cc:800:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable left [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/spl-book.cc:892:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable expand_v [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/spl-book.cc:738:14: style: The member function 'SpellLibraryMenu::entry_colour' can be static. [functionStatic] stone_soup-0.34.1/source/random-pick.h:116:28: style: The member function 'random_picker < int , 9 >::rarity_at' can be static. [functionStatic] stone_soup-0.34.1/source/random-pick.h:38:9: note: The member function 'random_picker < int , 9 >::rarity_at' can be static. stone_soup-0.34.1/source/random-pick.h:116:28: note: The member function 'random_picker < int , 9 >::rarity_at' can be static. stone_soup-0.34.1/source/spl-book.cc:53:5: style: Struct 'sortable_spell' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/spl-book.cc:162:28: style:inconclusive: Function 'book_exists' argument 1 names different: declaration 'which_book' definition 'bt'. [funcArgNamesDifferent] stone_soup-0.34.1/source/spl-book.h:23:28: note: Function 'book_exists' argument 1 names different: declaration 'which_book' definition 'bt'. stone_soup-0.34.1/source/spl-book.cc:162:28: note: Function 'book_exists' argument 1 names different: declaration 'which_book' definition 'bt'. stone_soup-0.34.1/source/spl-book.cc:1077:29: style:inconclusive: Function 'learn_spell' argument 1 names different: declaration 'spell' definition 'specspell'. [funcArgNamesDifferent] stone_soup-0.34.1/source/spl-book.h:36:29: note: Function 'learn_spell' argument 1 names different: declaration 'spell' definition 'specspell'. stone_soup-0.34.1/source/spl-book.cc:1077:29: note: Function 'learn_spell' argument 1 names different: declaration 'spell' definition 'specspell'. stone_soup-0.34.1/source/spl-book.cc:431:44: performance: Function parameter 'spells' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/spl-book.cc:524:15: performance: Range variable 's' should be declared as const reference. [iterateByValue] stone_soup-0.34.1/source/spl-book.cc:767:20: style: Variable 'spell' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/state.cc:471:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/spl-book.cc:121:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/spl-book.cc:230:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/spl-book.cc:324:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/spl-book.cc:525:16: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/spl-book.cc:1200:19: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/spl-book.cc:299:59: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] stone_soup-0.34.1/source/store.cc:1272:22: style: Either there is a missing 'override', or the member function 'CrawlHashTable::assert_validity' can be static. [functionStatic] stone_soup-0.34.1/source/store.h:254:10: note: Either there is a missing 'override', or the member function 'CrawlHashTable::assert_validity' can be static. stone_soup-0.34.1/source/store.cc:1272:22: note: Either there is a missing 'override', or the member function 'CrawlHashTable::assert_validity' can be static. stone_soup-0.34.1/source/store.cc:1336:34: style: Either there is a missing 'override', or the member function 'CrawlHashTable::get_value' can be static. [functionStatic] stone_soup-0.34.1/source/store.h:273:22: note: Either there is a missing 'override', or the member function 'CrawlHashTable::get_value' can be static. stone_soup-0.34.1/source/store.cc:1336:34: note: Either there is a missing 'override', or the member function 'CrawlHashTable::get_value' can be static. stone_soup-0.34.1/source/store.cc:1504:19: style: The member function 'CrawlVector::assert_validity' can be static. [functionStatic] stone_soup-0.34.1/source/store.h:317:20: note: The member function 'CrawlVector::assert_validity' can be static. stone_soup-0.34.1/source/store.cc:1504:19: note: The member function 'CrawlVector::assert_validity' can be static. stone_soup-0.34.1/source/store.cc:359:9: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:363:9: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:367:9: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:371:9: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:375:9: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:379:9: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:383:9: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:387:9: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:391:9: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:587:19: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:593:19: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:603:19: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:612:19: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:621:19: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:630:19: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:639:19: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:648:19: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:657:19: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:666:19: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:816:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:821:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:826:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:831:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:836:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:841:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:846:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:851:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:856:5: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:904:14: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:910:14: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:916:14: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:922:14: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:928:14: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:934:14: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:940:14: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:946:14: style: C-style pointer casting [cstyleCast] stone_soup-0.34.1/source/store.cc:49:52: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'flags' definition '_flags'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:232:39: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'flags' definition '_flags'. stone_soup-0.34.1/source/store.cc:49:52: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'flags' definition '_flags'. stone_soup-0.34.1/source/store.cc:50:55: style:inconclusive: Function 'CrawlStoreValue' argument 2 names different: declaration 'type' definition '_type'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:233:42: note: Function 'CrawlStoreValue' argument 2 names different: declaration 'type' definition '_type'. stone_soup-0.34.1/source/store.cc:50:55: note: Function 'CrawlStoreValue' argument 2 names different: declaration 'type' definition '_type'. stone_soup-0.34.1/source/store.cc:61:45: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:85:32: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:61:45: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:67:46: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:86:33: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:67:46: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:73:47: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:87:34: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:73:47: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:79:45: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:88:32: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:79:45: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:85:49: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:89:36: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:85:49: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:91:47: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:90:34: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:91:47: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:97:48: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:91:35: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:97:48: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:104:46: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:92:33: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:104:46: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:111:51: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:93:38: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:111:51: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:118:50: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:94:37: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:118:50: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:125:56: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:95:43: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:125:56: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:132:53: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:96:40: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:132:53: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:139:50: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:97:37: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:139:50: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:146:51: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:98:38: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:146:51: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:153:49: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:99:36: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:153:49: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:160:52: style:inconclusive: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:100:39: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:160:52: note: Function 'CrawlStoreValue' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:412:52: style:inconclusive: Function 'set_flags' argument 1 names different: declaration 'flags' definition '_flags'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:113:42: note: Function 'set_flags' argument 1 names different: declaration 'flags' definition '_flags'. stone_soup-0.34.1/source/store.cc:412:52: note: Function 'set_flags' argument 1 names different: declaration 'flags' definition '_flags'. stone_soup-0.34.1/source/store.cc:418:54: style:inconclusive: Function 'unset_flags' argument 1 names different: declaration 'flags' definition '_flags'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:114:44: note: Function 'unset_flags' argument 1 names different: declaration 'flags' definition '_flags'. stone_soup-0.34.1/source/store.cc:418:54: note: Function 'unset_flags' argument 1 names different: declaration 'flags' definition '_flags'. stone_soup-0.34.1/source/store.cc:431:37: style:inconclusive: Function 'write' argument 1 names different: declaration '' definition 'th'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/store.cc:548:36: style:inconclusive: Function 'read' argument 1 names different: declaration '' definition 'th'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/store.cc:688:54: style:inconclusive: Function 'new_vector' argument 1 names different: declaration 'flags' definition '_flags'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:119:41: note: Function 'new_vector' argument 1 names different: declaration 'flags' definition '_flags'. stone_soup-0.34.1/source/store.cc:688:54: note: Function 'new_vector' argument 1 names different: declaration 'flags' definition '_flags'. stone_soup-0.34.1/source/store.cc:694:57: style:inconclusive: Function 'new_vector' argument 1 names different: declaration 'type' definition '_type'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:120:44: note: Function 'new_vector' argument 1 names different: declaration 'type' definition '_type'. stone_soup-0.34.1/source/store.cc:694:57: note: Function 'new_vector' argument 1 names different: declaration 'type' definition '_type'. stone_soup-0.34.1/source/store.cc:695:54: style:inconclusive: Function 'new_vector' argument 2 names different: declaration 'flags' definition '_flags'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:120:62: note: Function 'new_vector' argument 2 names different: declaration 'flags' definition '_flags'. stone_soup-0.34.1/source/store.cc:695:54: note: Function 'new_vector' argument 2 names different: declaration 'flags' definition '_flags'. stone_soup-0.34.1/source/store.cc:1047:59: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:203:46: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1047:59: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1053:59: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:204:46: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1053:59: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1059:60: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:205:47: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1059:60: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1065:58: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:206:45: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1065:58: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1071:62: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:207:49: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1071:62: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1077:60: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:208:47: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1077:60: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1083:61: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:209:48: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1083:61: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1089:59: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:210:46: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1089:59: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1095:64: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:211:51: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1095:64: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1101:69: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:212:56: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1101:69: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1107:66: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:213:53: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1107:66: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1113:63: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:214:50: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1113:63: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1119:63: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:215:50: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1119:63: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1125:64: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:216:51: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1125:64: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1131:62: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:217:49: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1131:62: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1137:65: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:218:52: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1137:65: note: Function 'operator=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1201:53: style:inconclusive: Function 'operator+=' argument 1 names different: declaration 'val' definition '_val'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:221:40: note: Function 'operator+=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1201:53: note: Function 'operator+=' argument 1 names different: declaration 'val' definition '_val'. stone_soup-0.34.1/source/store.cc:1208:36: style:inconclusive: Function 'write' argument 1 names different: declaration '' definition 'th'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/store.cc:1228:35: style:inconclusive: Function 'read' argument 1 names different: declaration '' definition 'th'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/store.cc:1366:54: style:inconclusive: Function 'CrawlVector' argument 2 names different: declaration 'max_size' definition '_max_size'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:289:45: note: Function 'CrawlVector' argument 2 names different: declaration 'max_size' definition '_max_size'. stone_soup-0.34.1/source/store.cc:1366:54: note: Function 'CrawlVector' argument 2 names different: declaration 'max_size' definition '_max_size'. stone_soup-0.34.1/source/store.cc:1373:41: style:inconclusive: Function 'CrawlVector' argument 1 names different: declaration 'type' definition '_type'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:290:32: note: Function 'CrawlVector' argument 1 names different: declaration 'type' definition '_type'. stone_soup-0.34.1/source/store.cc:1373:41: note: Function 'CrawlVector' argument 1 names different: declaration 'type' definition '_type'. stone_soup-0.34.1/source/store.cc:1374:35: style:inconclusive: Function 'CrawlVector' argument 3 names different: declaration 'max_size' definition '_max_size'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:291:26: note: Function 'CrawlVector' argument 3 names different: declaration 'max_size' definition '_max_size'. stone_soup-0.34.1/source/store.cc:1374:35: note: Function 'CrawlVector' argument 3 names different: declaration 'max_size' definition '_max_size'. stone_soup-0.34.1/source/store.cc:1389:33: style:inconclusive: Function 'write' argument 1 names different: declaration '' definition 'th'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/store.cc:1412:32: style:inconclusive: Function 'read' argument 1 names different: declaration '' definition 'th'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/store.cc:1563:41: style:inconclusive: Function 'set_max_size' argument 1 names different: declaration 'size' definition '_size'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:318:42: note: Function 'set_max_size' argument 1 names different: declaration 'size' definition '_size'. stone_soup-0.34.1/source/store.cc:1563:41: note: Function 'set_max_size' argument 1 names different: declaration 'size' definition '_size'. stone_soup-0.34.1/source/store.cc:1694:41: style:inconclusive: Function 'resize' argument 1 names different: declaration 'size' definition '_size'. [funcArgNamesDifferent] stone_soup-0.34.1/source/store.h:342:32: note: Function 'resize' argument 1 names different: declaration 'size' definition '_size'. stone_soup-0.34.1/source/store.cc:1694:41: note: Function 'resize' argument 1 names different: declaration 'size' definition '_size'. stone_soup-0.34.1/source/store.cc:472:17: style: Variable 'str' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/store.cc:479:17: style: Variable 'str' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/store.cc:486:20: style: Variable 'coord' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/store.cc:493:19: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/store.cc:500:25: style: Variable 'hash' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/store.cc:507:22: style: Variable 'vec' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/store.cc:514:19: style: Variable 'id' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/store.cc:521:20: style: Variable 'pos' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/store.cc:528:18: style: Variable 'mon' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/store.cc:535:21: style: Variable 'chunk' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/store.cc:786:5: error: Overlapping read/write of union is undefined behavior [overlappingWriteUnion] stone_soup-0.34.1/source/store.cc:791:5: error: Overlapping read/write of union is undefined behavior [overlappingWriteUnion] stone_soup-0.34.1/source/store.cc:796:5: error: Overlapping read/write of union is undefined behavior [overlappingWriteUnion] stone_soup-0.34.1/source/store.cc:801:5: error: Overlapping read/write of union is undefined behavior [overlappingWriteUnion] stone_soup-0.34.1/source/store.cc:806:5: error: Overlapping read/write of union is undefined behavior [overlappingWriteUnion] stone_soup-0.34.1/source/store.cc:811:5: error: Overlapping read/write of union is undefined behavior [overlappingWriteUnion] stone_soup-0.34.1/source/state.cc:103:18: style: The member function 'game_state::is_replaying_keys' can be static. [functionStatic] stone_soup-0.34.1/source/state.h:186:10: note: The member function 'game_state::is_replaying_keys' can be static. stone_soup-0.34.1/source/state.cc:103:18: note: The member function 'game_state::is_replaying_keys' can be static. stone_soup-0.34.1/source/state.cc:636:18: style: The member function 'game_state::seed_is_known' can be static. [functionStatic] stone_soup-0.34.1/source/state.h:239:10: note: The member function 'game_state::seed_is_known' can be static. stone_soup-0.34.1/source/state.cc:636:18: note: The member function 'game_state::seed_is_known' can be static. stone_soup-0.34.1/source/state.cc:611:49: style:inconclusive: Function 'game_type_name_for' argument 1 names different: declaration 'gt' definition '_type'. [funcArgNamesDifferent] stone_soup-0.34.1/source/state.h:246:48: note: Function 'game_type_name_for' argument 1 names different: declaration 'gt' definition '_type'. stone_soup-0.34.1/source/state.cc:611:49: note: Function 'game_type_name_for' argument 1 names different: declaration 'gt' definition '_type'. stone_soup-0.34.1/source/state.cc:114:43: performance: Function parameter 'reason' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/state.cc:148:42: performance: Function parameter 'reason' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/state.cc:165:40: performance: Function parameter 'reason' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/state.cc:187:38: performance: Function parameter 'reason' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/state.cc:228:18: style: Variable 'mon' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/state.cc:433:42: style: Parameter 'mon' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/unicode.cc:186:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MB_LEN_MAX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/unicode.cc:232:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MB_LEN_MAX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/unicode.cc:304:16: warning: Class 'FileLineInput' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] stone_soup-0.34.1/source/unicode.cc:304:16: warning: Class 'FileLineInput' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] stone_soup-0.34.1/source/unicode.cc:448:16: warning: Class 'UTF8FileLineInput' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] stone_soup-0.34.1/source/unicode.cc:448:16: warning: Class 'UTF8FileLineInput' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] stone_soup-0.34.1/source/unicode.cc:501:33: style: Parameter 'start' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/util/fake_pty.c:41:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TIMEOUT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/fake_pty.c:63:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:38:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NUM_COLOURS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:84:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BROWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:169:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BROWN [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:239:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DNGN_FLOOR [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:255:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SPELL_IOOD [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:270:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SPELL_ANTIMAGIC_GAZE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:279:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SPELL_SLEETSTRIKE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:295:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SPELL_CHAIN_LIGHTNING [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:317:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SPELL_MAJOR_HEALING [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:323:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SPELL_SCORCH [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:329:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SPELL_IRRADIATE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:335:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SPELL_RESONANCE_STRIKE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:373:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ZAP_FOXFIRE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:411:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:451:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MON_SPELL_ANTIMAGIC_MASK [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:574:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MILEV_NAME [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:587:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BEH_SEEK [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:662:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MAX_MONSTERS [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:713:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_FORBID_EGO [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:751:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable test [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/util/monster/monster-main.cc:669:17: style: Condition 'mp' is always true [knownConditionTrueFalse] stone_soup-0.34.1/source/util/monster/monster-main.cc:795:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/version.cc:47:24: error: There is an unknown macro here somewhere. Configuration is required. If CRAWL_HOST is a macro then please configure it. [unknownMacro] stone_soup-0.34.1/source/uncancel.cc:44:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable second [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/uncancel.cc:44:23: warning: Either the condition 'act!=-1' is redundant, otherwise there is negative array index -1. [negativeContainerIndex] stone_soup-0.34.1/source/uncancel.cc:101:17: note: Assuming that condition 'act!=-1' is not redundant stone_soup-0.34.1/source/uncancel.cc:44:23: note: Negative array index stone_soup-0.34.1/source/uncancel.cc:47:21: warning: Either the condition 'act!=-1' is redundant, otherwise there is negative array index -1. [negativeContainerIndex] stone_soup-0.34.1/source/uncancel.cc:101:17: note: Assuming that condition 'act!=-1' is not redundant stone_soup-0.34.1/source/uncancel.cc:47:21: note: Negative array index stone_soup-0.34.1/source/skills.cc:177:16: warning: Either the condition 'you_skill_cost_level' is redundant or the array 'cost[27]' is accessed at index -1, which is out of bounds. [negativeIndex] stone_soup-0.34.1/source/skills.cc:1704:31: note: Assuming that condition 'you_skill_cost_level' is not redundant stone_soup-0.34.1/source/skills.cc:1707:42: note: Calling function 'calc_skill_cost', 1st argument 'you_skill_cost_level' value is 0 stone_soup-0.34.1/source/skills.cc:177:16: note: Negative array index stone_soup-0.34.1/source/skills.cc:2675:19: style:inconclusive: Technically the member function 'skill_state::restore_levels' can be const. [functionConst] stone_soup-0.34.1/source/skills.h:36:10: note: Technically the member function 'skill_state::restore_levels' can be const. stone_soup-0.34.1/source/skills.cc:2675:19: note: Technically the member function 'skill_state::restore_levels' can be const. stone_soup-0.34.1/source/skills.cc:2686:19: style:inconclusive: Technically the member function 'skill_state::restore_training' can be const. [functionConst] stone_soup-0.34.1/source/skills.h:37:10: note: Technically the member function 'skill_state::restore_training' can be const. stone_soup-0.34.1/source/skills.cc:2686:19: note: Technically the member function 'skill_state::restore_training' can be const. stone_soup-0.34.1/source/ui.cc:488:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STRETCH [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ui.cc:523:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STRETCH [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ui.cc:617:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STRETCH [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ui.cc:720:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable next_line [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ui.cc:1335:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable offset [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ui.cc:1366:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable pos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ui.cc:1435:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable size [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ui.cc:1483:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable pos [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ui.cc:1732:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable HORZ [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ui.cc:1805:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable HORZ [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/ui.cc:1818:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable VERT [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/skills.cc:896:10: style: The scope of the variable 'empty' can be reduced. [variableScope] stone_soup-0.34.1/source/skills.cc:728:16: style: Variable 'rest' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/skills.cc:268:19: style: Variable 'current_armour' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/skills.cc:2448:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/skills.cc:2611:16: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/skills.cc:1024:18: style: Unused variable: min [unusedVariable] stone_soup-0.34.1/source/skills.cc:1107:19: style: Variable 'min' is assigned a value that is never used. [unreadVariable] stone_soup-0.34.1/source/skills.cc:229:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] stone_soup-0.34.1/source/skills.cc:243:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] stone_soup-0.34.1/source/ui.cc:3390:9: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] stone_soup-0.34.1/source/ui.cc:627:7: warning:inconclusive: Member variable 'Text::hl_line' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/ui.cc:627:7: warning:inconclusive: Member variable 'Widget::cached_sr' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/ui.cc:627:7: warning:inconclusive: Member variable 'Widget::cached_sr_pw' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/ui.h:746:14: warning: Member variable 'Text::hl_line' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/ui.h:746:14: warning: Member variable 'Widget::cached_sr' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/ui.h:746:14: warning: Member variable 'Widget::cached_sr_pw' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/ui.cc:1875:12: warning: Member variable 'TextEntry::m_buffer' is not initialized in the constructor. [uninitMemberVar] stone_soup-0.34.1/source/ui.cc:1875:12: warning: Member variable 'Widget::cached_sr' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/ui.cc:1875:12: warning: Member variable 'Widget::cached_sr_pw' is not initialized in the constructor. Maybe it should be initialized directly in the class Widget? [uninitDerivedMemberVar] stone_soup-0.34.1/source/ui.cc:69:1: warning: Member variable 'UIRoot::needs_paint' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.cc:69:1: warning: Member variable 'UIRoot::needs_swap' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.cc:69:1: warning: Member variable 'UIRoot::m_w' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.cc:69:1: warning: Member variable 'UIRoot::m_h' has no initializer. [uninitMemberVarNoCtor] stone_soup-0.34.1/source/ui.cc:367:14: style:inconclusive: Either there is a missing 'override', or the member function 'ui::Widget::is_ancestor_of' can be const. [functionConst] stone_soup-0.34.1/source/ui.h:364:10: note: Either there is a missing 'override', or the member function 'ui::Widget::is_ancestor_of' can be const. stone_soup-0.34.1/source/ui.cc:367:14: note: Either there is a missing 'override', or the member function 'ui::Widget::is_ancestor_of' can be const. stone_soup-0.34.1/source/ui.cc:391:14: style:inconclusive: Either there is a missing 'override', or the member function 'ui::Widget::_unparent' can be const. [functionConst] stone_soup-0.34.1/source/ui.h:472:10: note: Either there is a missing 'override', or the member function 'ui::Widget::_unparent' can be const. stone_soup-0.34.1/source/ui.cc:391:14: note: Either there is a missing 'override', or the member function 'ui::Widget::_unparent' can be const. stone_soup-0.34.1/source/ui.cc:1065:13: style: Either there is a missing 'override', or the member function 'ui::Image::set_tile' can be static. [functionStatic] stone_soup-0.34.1/source/ui.h:821:10: note: Either there is a missing 'override', or the member function 'ui::Image::set_tile' can be static. stone_soup-0.34.1/source/ui.cc:1065:13: note: Either there is a missing 'override', or the member function 'ui::Image::set_tile' can be static. stone_soup-0.34.1/source/ui.cc:1382:12: style: Either there is a missing 'override', or the member function 'ui::Grid::set_track_offsets' can be static. [functionStatic] stone_soup-0.34.1/source/ui.h:943:10: note: Either there is a missing 'override', or the member function 'ui::Grid::set_track_offsets' can be static. stone_soup-0.34.1/source/ui.cc:1382:12: note: Either there is a missing 'override', or the member function 'ui::Grid::set_track_offsets' can be static. stone_soup-0.34.1/source/ui.cc:1740:13: style:inconclusive: Either there is a missing 'override', or the member function 'ui::Popup::get_max_child_size' can be const. [functionConst] stone_soup-0.34.1/source/ui.h:1032:10: note: Either there is a missing 'override', or the member function 'ui::Popup::get_max_child_size' can be const. stone_soup-0.34.1/source/ui.cc:1740:13: note: Either there is a missing 'override', or the member function 'ui::Popup::get_max_child_size' can be const. stone_soup-0.34.1/source/ui.cc:2104:34: style:inconclusive: Technically the member function 'ui::TextEntry::LineReader::get_edit_mode' can be const. [functionConst] stone_soup-0.34.1/source/ui.h:1157:19: note: Technically the member function 'ui::TextEntry::LineReader::get_edit_mode' can be const. stone_soup-0.34.1/source/ui.cc:2104:34: note: Technically the member function 'ui::TextEntry::LineReader::get_edit_mode' can be const. stone_soup-0.34.1/source/ui.cc:2176:29: style: The member function 'ui::TextEntry::LineReader::is_wordchar' can be static. [functionStatic] stone_soup-0.34.1/source/ui.h:1184:14: note: The member function 'ui::TextEntry::LineReader::is_wordchar' can be static. stone_soup-0.34.1/source/ui.cc:2176:29: note: The member function 'ui::TextEntry::LineReader::is_wordchar' can be static. stone_soup-0.34.1/source/ui.cc:3482:22: style: The member function 'ui::progress_popup::force_redraw' can be static. [functionStatic] stone_soup-0.34.1/source/ui.h:1308:10: note: The member function 'ui::progress_popup::force_redraw' can be static. stone_soup-0.34.1/source/ui.cc:3482:22: note: The member function 'ui::progress_popup::force_redraw' can be static. stone_soup-0.34.1/source/ui.cc:3511:34: style:inconclusive: Technically the member function 'ui::progress_popup::get_progress_string' can be const. [functionConst] stone_soup-0.34.1/source/ui.h:1315:22: note: Technically the member function 'ui::progress_popup::get_progress_string' can be const. stone_soup-0.34.1/source/ui.cc:3511:34: note: Technically the member function 'ui::progress_popup::get_progress_string' can be const. stone_soup-0.34.1/source/ui.cc:85:10: style:inconclusive: Technically the member function 'ui::UIRoot::widget_is_in_layout' can be const. [functionConst] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < KeymapContext >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/ui.h:1028:10: style: The function '_render' overrides a function in a base class but is identical to the overridden function [uselessOverride] stone_soup-0.34.1/source/ui.h:1014:10: note: Virtual function in base class stone_soup-0.34.1/source/ui.h:1028:10: note: Function in derived class stone_soup-0.34.1/source/ui.h:1100:18: style: The function '_allocate_region' overrides a function in a base class but is identical to the overridden function [uselessOverride] stone_soup-0.34.1/source/ui.h:314:18: note: Virtual function in base class stone_soup-0.34.1/source/ui.h:1100:18: note: Function in derived class stone_soup-0.34.1/source/ui.cc:612:14: style: The scope of the variable 'cr_cross_size' can be reduced. [variableScope] stone_soup-0.34.1/source/ui.cc:181:26: style:inconclusive: Function 'Event' argument 1 names different: declaration 'type' definition '_type'. [funcArgNamesDifferent] stone_soup-0.34.1/source/ui.h:165:25: note: Function 'Event' argument 1 names different: declaration 'type' definition '_type'. stone_soup-0.34.1/source/ui.cc:181:26: note: Function 'Event' argument 1 names different: declaration 'type' definition '_type'. stone_soup-0.34.1/source/ui.cc:185:32: style:inconclusive: Function 'KeyEvent' argument 1 names different: declaration 'type' definition '_type'. [funcArgNamesDifferent] stone_soup-0.34.1/source/ui.h:181:19: note: Function 'KeyEvent' argument 1 names different: declaration 'type' definition '_type'. stone_soup-0.34.1/source/ui.cc:185:32: note: Function 'KeyEvent' argument 1 names different: declaration 'type' definition '_type'. stone_soup-0.34.1/source/ui.cc:204:36: style:inconclusive: Function 'FocusEvent' argument 1 names different: declaration 'type' definition 'typ'. [funcArgNamesDifferent] stone_soup-0.34.1/source/ui.h:219:21: note: Function 'FocusEvent' argument 1 names different: declaration 'type' definition 'typ'. stone_soup-0.34.1/source/ui.cc:204:36: note: Function 'FocusEvent' argument 1 names different: declaration 'type' definition 'typ'. stone_soup-0.34.1/source/ui.h:313:51: style:inconclusive: Function '_get_preferred_size' argument 1 names different: declaration 'dim' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/ui.h:313:60: style:inconclusive: Function '_get_preferred_size' argument 2 names different: declaration 'prosp_width' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/ui.cc:418:31: style:inconclusive: Function 'set_visible' argument 1 names different: declaration '' definition 'visible'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/ui.cc:657:55: style:inconclusive: Function 'set_highlight_pattern' argument 2 names different: declaration 'hl_line' definition 'line'. [funcArgNamesDifferent] stone_soup-0.34.1/source/ui.h:763:53: note: Function 'set_highlight_pattern' argument 2 names different: declaration 'hl_line' definition 'line'. stone_soup-0.34.1/source/ui.cc:657:55: note: Function 'set_highlight_pattern' argument 2 names different: declaration 'hl_line' definition 'line'. stone_soup-0.34.1/source/ui.h:828:52: style:inconclusive: Function '_get_preferred_size' argument 2 names different: declaration 'prosp_width' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/ui.h:1099:60: style:inconclusive: Function '_get_preferred_size' argument 2 names different: declaration 'prosp_width' definition ''. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/ui.cc:2054:41: style:inconclusive: Function 'LineReader' argument 1 names different: declaration 'buffer' definition 'buf'. [funcArgNamesDifferent] stone_soup-0.34.1/source/ui.h:1145:26: note: Function 'LineReader' argument 1 names different: declaration 'buffer' definition 'buf'. stone_soup-0.34.1/source/ui.cc:2054:41: note: Function 'LineReader' argument 1 names different: declaration 'buffer' definition 'buf'. stone_soup-0.34.1/source/ui.cc:2054:53: style:inconclusive: Function 'LineReader' argument 2 names different: declaration 'bufsz' definition 'sz'. [funcArgNamesDifferent] stone_soup-0.34.1/source/ui.h:1145:41: note: Function 'LineReader' argument 2 names different: declaration 'bufsz' definition 'sz'. stone_soup-0.34.1/source/ui.cc:2054:53: note: Function 'LineReader' argument 2 names different: declaration 'bufsz' definition 'sz'. stone_soup-0.34.1/source/ui.cc:2076:45: style:inconclusive: Function 'set_text' argument 1 names different: declaration 's' definition 'text'. [funcArgNamesDifferent] stone_soup-0.34.1/source/ui.h:1151:30: note: Function 'set_text' argument 1 names different: declaration 's' definition 'text'. stone_soup-0.34.1/source/ui.cc:2076:45: note: Function 'set_text' argument 1 names different: declaration 's' definition 'text'. stone_soup-0.34.1/source/ui.cc:2084:62: style:inconclusive: Function 'set_input_history' argument 1 names different: declaration 'ih' definition 'i'. [funcArgNamesDifferent] stone_soup-0.34.1/source/ui.h:1153:47: note: Function 'set_input_history' argument 1 names different: declaration 'ih' definition 'i'. stone_soup-0.34.1/source/ui.cc:2084:62: note: Function 'set_input_history' argument 1 names different: declaration 'ih' definition 'i'. stone_soup-0.34.1/source/ui.cc:2442:44: style:inconclusive: Function 'push_child' argument 1 names different: declaration 'child' definition 'ch'. [funcArgNamesDifferent] stone_soup-0.34.1/source/ui.cc:71:40: note: Function 'push_child' argument 1 names different: declaration 'child' definition 'ch'. stone_soup-0.34.1/source/ui.cc:2442:44: note: Function 'push_child' argument 1 names different: declaration 'child' definition 'ch'. stone_soup-0.34.1/source/ui.cc:432:33: performance: Function parameter 'id' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/ui.cc:657:41: performance: Function parameter 'pattern' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/ui.cc:2076:45: performance: Function parameter 'text' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/ui.cc:2099:47: performance: Function parameter 'p' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/ui.cc:3344:33: performance: Function parameter 'event' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/ui.cc:3497:45: performance: Function parameter 'status' should be passed by const reference. [passedByValue] stone_soup-0.34.1/source/ui.cc:254:30: style: Variable 'child' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/ui.cc:305:10: style: Variable '_min_size' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/ui.cc:306:10: style: Variable '_max_size' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/ui.cc:517:53: style: Parameter 'ch_psz' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/ui.cc:622:14: style: Variable 'cr_main_size' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/ui.cc:736:20: style: Variable 'fs' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/ui.cc:1288:16: style: Variable 'child' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/ui.cc:1366:15: style: Variable 'cp' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/ui.cc:1367:15: style: Variable 'cs' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/ui.cc:1483:15: style: Variable 'cp' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/ui.cc:1484:15: style: Variable 'cs' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/ui.cc:2661:75: style: Parameter 'ch' can be declared as reference to const [constParameterReference] stone_soup-0.34.1/source/ui.cc:369:18: style: Variable 'w' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/ui.cc:2152:11: style: Variable 'c' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/ui.cc:2445:14: style: Variable 'popup' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/ui.cc:2679:16: style: Variable 'default_focus' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/ui.cc:2706:16: style: Variable 'default_focus' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/ui.cc:255:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/ui.cc:737:23: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/ui.cc:959:23: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/ui.cc:962:21: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/ui.cc:1444:27: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/ui.cc:1451:31: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/ui.cc:137:17: style: struct member 'UIRoot::cutoff_stack' is never used. [unusedStructMember] stone_soup-0.34.1/source/ui.cc:138:21: style: struct member 'UIRoot::default_focus_stack' is never used. [unusedStructMember] stone_soup-0.34.1/source/worley.cc:84:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DBL_MAX [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/worley.cc:201:16: style: The scope of the variable 'dx' can be reduced. [variableScope] stone_soup-0.34.1/source/worley.cc:201:20: style: The scope of the variable 'dy' can be reduced. [variableScope] stone_soup-0.34.1/source/worley.cc:201:24: style: The scope of the variable 'dz' can be reduced. [variableScope] stone_soup-0.34.1/source/worley.cc:201:28: style: The scope of the variable 'fx' can be reduced. [variableScope] stone_soup-0.34.1/source/worley.cc:201:32: style: The scope of the variable 'fy' can be reduced. [variableScope] stone_soup-0.34.1/source/worley.cc:201:36: style: The scope of the variable 'fz' can be reduced. [variableScope] stone_soup-0.34.1/source/worley.cc:201:40: style: The scope of the variable 'd2' can be reduced. [variableScope] stone_soup-0.34.1/source/worley.cc:202:30: style: The scope of the variable 'index' can be reduced. [variableScope] stone_soup-0.34.1/source/worley.cc:203:24: style: The scope of the variable 'this_id' can be reduced. [variableScope] stone_soup-0.34.1/source/worley.cc:199:43: style:inconclusive: Function 'AddSamples' argument 8 names different: declaration '' definition 'ID'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/worley.cc:73:32: style: Parameter 'at' can be declared as const array [constParameter] stone_soup-0.34.1/source/worley.cc:198:20: style: Parameter 'at' can be declared as const array [constParameter] stone_soup-0.34.1/source/transform.cc:158:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable formdata [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/transform.cc:684:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_DEEP_DWARF [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/transform.cc:1842:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_GARGOYLE [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/transform.cc:2462:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable formdata [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/transform.cc:2469:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable formdata [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/viewgeom.cc:97:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable valid [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/viewgeom.cc:173:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable valid [valueFlowBailoutIncompleteVar] stone_soup-0.34.1/source/viewgeom.cc:56:10: style: The member function '_layout::_assert_validity' can be static. [functionStatic] stone_soup-0.34.1/source/viewgeom.cc:332:66: style:inconclusive: Function 'set_player_at' argument 2 names different: declaration 'force_centre' definition 'centre'. [funcArgNamesDifferent] stone_soup-0.34.1/source/viewgeom.h:82:49: note: Function 'set_player_at' argument 2 names different: declaration 'force_centre' definition 'centre'. stone_soup-0.34.1/source/viewgeom.cc:332:66: note: Function 'set_player_at' argument 2 names different: declaration 'force_centre' definition 'centre'. stone_soup-0.34.1/source/transform.h:64:5: style: Class 'Form' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/unwind.h:15:5: style: Class 'unwind_var < int8_t >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] stone_soup-0.34.1/source/transform.cc:308:24: style:inconclusive: Function 'ev_bonus' argument 1 names different: declaration '' definition 'skill'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/transform.cc:324:32: style:inconclusive: Function 'get_body_ac_mult' argument 1 names different: declaration '' definition 'skill'. [funcArgNamesDifferentUnnamed] stone_soup-0.34.1/source/transform.cc:1433:37: style:inconclusive: Function 'get_form' argument 1 names different: declaration 'form' definition 'xform'. [funcArgNamesDifferent] stone_soup-0.34.1/source/transform.h:317:37: note: Function 'get_form' argument 1 names different: declaration 'form' definition 'xform'. stone_soup-0.34.1/source/transform.cc:1433:37: note: Function 'get_form' argument 1 names different: declaration 'form' definition 'xform'. stone_soup-0.34.1/source/transform.cc:1815:44: style:inconclusive: Function 'lifeless_prevents_form' argument 1 names different: declaration 'form' definition 'which_trans'. [funcArgNamesDifferent] stone_soup-0.34.1/source/transform.h:320:44: note: Function 'lifeless_prevents_form' argument 1 names different: declaration 'form' definition 'which_trans'. stone_soup-0.34.1/source/transform.cc:1815:44: note: Function 'lifeless_prevents_form' argument 1 names different: declaration 'form' definition 'which_trans'. stone_soup-0.34.1/source/transform.cc:1677:30: style: Variable 'entry' can be declared as reference to const [constVariableReference] stone_soup-0.34.1/source/transform.cc:1721:20: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/transform.cc:1788:20: style: Variable 'item' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/transform.cc:1905:50: style: Parameter 'weapon' can be declared as pointer to const [constParameterPointer] stone_soup-0.34.1/source/transform.cc:2046:22: style: Variable 'constrictor' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/transform.cc:2317:22: style: Variable 'constrictor' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/transform.cc:2557:18: style: Variable 'mon' can be declared as pointer to const [constVariablePointer] stone_soup-0.34.1/source/transform.cc:159:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] stone_soup-0.34.1/source/transform.cc:1788:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] diff: head levcomp.lex.cc:3702:27: style:inconclusive: Function 'yyalloc' argument 1 names different: declaration '' definition 'size'. [funcArgNamesDifferentUnnamed] head levcomp.lex.cc:3707:26: style:inconclusive: Function 'yyrealloc' argument 1 names different: declaration '' definition 'ptr'. [funcArgNamesDifferentUnnamed] head levcomp.lex.cc:3707:42: style:inconclusive: Function 'yyrealloc' argument 2 names different: declaration '' definition 'size'. [funcArgNamesDifferentUnnamed] head levcomp.lex.cc:3720:21: style:inconclusive: Function 'yyfree' argument 1 names different: declaration '' definition 'ptr'. [funcArgNamesDifferentUnnamed] 2.20.0 levcomp.lpp:53:18: error:inconclusive: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] levcomp.lpp:116:38: note: Assuming allocation function fails levcomp.lpp:116:24: note: Assignment 'newbuf=(char*)malloc(strlen(yylval.text)+strlen(yytext)+1)', assigned value is 0 levcomp.lpp:122:24: note: Calling function 'post_proc_text', 1st argument 'newbuf' value is 0 levcomp.lpp:53:18: note: Null pointer addition 2.20.0 levcomp.lpp:53:27: warning:inconclusive: If memory allocation fails, then there is a possible null pointer dereference: text [nullPointerOutOfMemory] levcomp.lpp:116:38: note: Assuming allocation function fails levcomp.lpp:116:24: note: Assignment 'newbuf=(char*)malloc(strlen(yylval.text)+strlen(yytext)+1)', assigned value is 0 levcomp.lpp:122:24: note: Calling function 'post_proc_text', 1st argument 'newbuf' value is 0 levcomp.lpp:53:27: note: Null pointer dereference head stone_soup-0.34.1/source/acquire.cc:1073:46: style:inconclusive: Function '_armour_slot_seen' argument 1 names different: declaration '' definition 'slot'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/acquire.cc:135:52: style:inconclusive: Function '_acquirement_armour_slot' argument 1 names different: declaration '' definition 'agent'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/acquire.cc:1453:29: style:inconclusive: Function 'get_keyhelp' argument 1 names different: declaration 'unused' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/acquire.cc:172:64: style:inconclusive: Function '_acquirement_armour_for_slot' argument 1 names different: declaration '' definition 'slot_type'. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/act-iter.cc:131:46: style:inconclusive: Technically the member function 'monster_near_iterator::begin' can be const. [functionConst] stone_soup-0.34.1/source/act-iter.h:46:27: note: Technically the member function 'monster_near_iterator::begin' can be const. stone_soup-0.34.1/source/act-iter.cc:131:46: note: Technically the member function 'monster_near_iterator::begin' can be const. 2.20.0 stone_soup-0.34.1/source/act-iter.cc:138:46: style:inconclusive: Technically the member function 'monster_near_iterator::end' can be const. [functionConst] stone_soup-0.34.1/source/act-iter.h:47:27: note: Technically the member function 'monster_near_iterator::end' can be const. stone_soup-0.34.1/source/act-iter.cc:138:46: note: Technically the member function 'monster_near_iterator::end' can be const. 2.20.0 stone_soup-0.34.1/source/arena.cc:337:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:10408:62: style:inconclusive: Function 'benchmarkStarting' argument 1 names different: declaration '' definition 'info'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:10417:62: style:inconclusive: Function 'benchmarkEnded' argument 1 names different: declaration '' definition 'benchmarkStats'. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4872:44: performance: Function parameter 'customOptions' should be passed by const reference. However it seems that 'ReporterSpec' is a callback function. [passedByValueCallback] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4862:16: note: Function pointer used here. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4872:44: note: Function parameter 'customOptions' should be passed by const reference. However it seems that 'ReporterSpec' is a callback function. head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:4872:44: performance: Function parameter 'customOptions' should be passed by const reference. [passedByValue] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5598:36: style: Condition 'uncaught_exceptions()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5598:36: note: Calling function 'uncaught_exceptions' returns 0 stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:5598:36: note: Condition 'uncaught_exceptions()' is always false 2.20.0 stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6856:25: style:inconclusive: Technically the member function 'Catch::TextFlow::Column::operator+' can be const. [functionConst] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:9873:21: note: Technically the member function 'Catch::TextFlow::Column::operator+' can be const. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6856:25: note: Technically the member function 'Catch::TextFlow::Column::operator+' can be const. 2.20.0 stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6868:26: style:inconclusive: Technically the member function 'Catch::TextFlow::Columns::operator+' can be const. [functionConst] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:9918:21: note: Technically the member function 'Catch::TextFlow::Columns::operator+' can be const. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.cc:6868:26: note: Technically the member function 'Catch::TextFlow::Columns::operator+' can be const. head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11692:50: style:inconclusive: Function 'testRunStarting' argument 1 names different: declaration '_testInfo' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11926:47: style:inconclusive: Function 'reportInvalidTestSpec' argument 1 names different: declaration 'unmatchedSpec' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11927:47: style:inconclusive: Function 'fatalErrorEncountered' argument 1 names different: declaration 'error' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11929:44: style:inconclusive: Function 'benchmarkPreparing' argument 1 names different: declaration 'name' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11930:54: style:inconclusive: Function 'benchmarkStarting' argument 1 names different: declaration 'benchmarkInfo' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11931:54: style:inconclusive: Function 'benchmarkEnded' argument 1 names different: declaration 'benchmarkStats' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11932:41: style:inconclusive: Function 'benchmarkFailed' argument 1 names different: declaration 'error' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11934:54: style:inconclusive: Function 'assertionStarting' argument 1 names different: declaration 'assertionInfo' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11935:52: style:inconclusive: Function 'assertionEnded' argument 1 names different: declaration 'assertionStats' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11938:53: style:inconclusive: Function 'listReporters' argument 1 names different: declaration 'descriptions' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11940:53: style:inconclusive: Function 'listListeners' argument 1 names different: declaration 'descriptions' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11941:60: style:inconclusive: Function 'listTests' argument 1 names different: declaration 'tests' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11942:52: style:inconclusive: Function 'listTags' argument 1 names different: declaration 'tagInfos' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11944:45: style:inconclusive: Function 'noMatchingTestCases' argument 1 names different: declaration 'unmatchedSpec' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11945:50: style:inconclusive: Function 'testRunStarting' argument 1 names different: declaration 'testRunInfo' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11946:52: style:inconclusive: Function 'testCaseStarting' argument 1 names different: declaration 'testInfo' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11947:59: style:inconclusive: Function 'testCasePartialStarting' argument 1 names different: declaration 'testInfo' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11948:48: style:inconclusive: Function 'testCasePartialStarting' argument 2 names different: declaration 'partNumber' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11949:50: style:inconclusive: Function 'sectionStarting' argument 1 names different: declaration 'sectionInfo' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11950:48: style:inconclusive: Function 'sectionEnded' argument 1 names different: declaration 'sectionStats' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11951:57: style:inconclusive: Function 'testCasePartialEnded' argument 1 names different: declaration 'testCaseStats' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11952:45: style:inconclusive: Function 'testCasePartialEnded' argument 2 names different: declaration 'partNumber' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11953:50: style:inconclusive: Function 'testCaseEnded' argument 1 names different: declaration 'testCaseStats' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11954:48: style:inconclusive: Function 'testRunEnded' argument 1 names different: declaration 'testRunStats' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:11955:44: style:inconclusive: Function 'skipTest' argument 1 names different: declaration 'testInfo' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:12357:50: style:inconclusive: Function 'testRunStarting' argument 1 names different: declaration 'testInfo' definition ''. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:1457:26: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] 2.20.0 stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4430:25: warning: The struct 'MessageBuilder' defines member function with name 'operator<<' also defined in its parent struct 'MessageStream'. [duplInheritedMember] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4414:24: note: Parent function 'MessageStream::operator<<' stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:4430:25: note: Derived function 'MessageBuilder::operator<<' head stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:6105:61: style:inconclusive: Function 'makeTestInvoker' argument 1 names different: declaration 'testAsFunction' definition 'testAsMethod'. [funcArgNamesDifferent] stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:6102:57: note: Function 'makeTestInvoker' argument 1 names different: declaration 'testAsFunction' definition 'testAsMethod'. stone_soup-0.34.1/source/catch2-tests/catch_amalgamated.hpp:6105:61: note: Function 'makeTestInvoker' argument 1 names different: declaration 'testAsFunction' definition 'testAsMethod'. head stone_soup-0.34.1/source/cio.cc:352:74: style:inconclusive: Function 'cancellable_get_line' argument 5 names different: declaration '' definition 'fill'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/cio.cc:353:39: style:inconclusive: Function 'cancellable_get_line' argument 6 names different: declaration '' definition 'tag'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/clua.cc:1130:35: style:inconclusive: Function '_clua_panic' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/clua.cc:1165:44: style:inconclusive: Function '_clua_throttle_hook' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/clua.cc:1165:59: style:inconclusive: Function '_clua_throttle_hook' argument 2 names different: declaration '' definition 'dbg'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/clua.cc:1237:43: style:inconclusive: Function '_clua_guarded_pcall' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/clua.cc:1269:38: style:inconclusive: Function '_clua_loadfile' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/clua.cc:127:36: style:inconclusive: Function '_getregistry' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/clua.cc:1293:37: style:inconclusive: Function '_clua_require' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/clua.cc:1314:36: style:inconclusive: Function '_clua_dofile' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/clua.cc:894:31: style:inconclusive: Function 'get_vm' argument 1 names different: declaration '' definition 'ls'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/clua.cc:912:57: style:inconclusive: Function 'add_shutdown_listener' argument 1 names different: declaration '' definition 'listener'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/clua.cc:921:60: style:inconclusive: Function 'remove_shutdown_listener' argument 1 names different: declaration '' definition 'listener'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/clua.h:65:25: style:inconclusive: Function 'shutdown' argument 1 names different: declaration 'lua' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/cluautil.cc:34:0: style:inconclusive: Function 'clua_push_map' argument 2 names different: declaration '' definition 'map'. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/cluautil.cc:37:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/colour.cc:308:36: style:inconclusive: Function 'dam_colour' argument 1 names different: declaration '' definition 'mi'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/colour.h:107:21: style:inconclusive: Function 'get_nth' argument 1 names different: declaration 'n' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/command.cc:354:67: performance: Concatenating the result of c_str() and a std::string is slow and redundant. [stlcstrConcat] 2.20.0 stone_soup-0.34.1/source/command.h:19:47: performance: Function parameter 'keys' should be passed by const reference. [passedByValue] head stone_soup-0.34.1/source/death-curse.cc:126:18: performance: Assigning the result of c_str() to a std::string is slow and redundant. [stlcstrAssignment] head stone_soup-0.34.1/source/dgn-event.cc:105:66: style:inconclusive: Function 'register_listener' argument 2 names different: declaration '' definition 'listener'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/dgn-event.cc:141:64: style:inconclusive: Function 'remove_listener' argument 1 names different: declaration '' definition 'listener'. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/dgn-irregular-box.cc:189:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/dgn-irregular-box.cc:225:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/dgn-irregular-box.cc:260:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/dgn-irregular-box.cc:296:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/dgn-irregular-box.cc:320:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/dgn-irregular-box.cc:380:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/dgn-irregular-box.cc:421:0: style:inconclusive: Function 'make_irregular_box' argument 1 names different: declaration '' definition 'map'. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/dgn-irregular-box.cc:474:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/dgn-overview.cc:123:22: performance: Assigning the result of c_str() to a std::string is slow and redundant. [stlcstrAssignment] head stone_soup-0.34.1/source/dlua.cc:145:32: style:inconclusive: Function 'check_op' argument 1 names different: declaration '' definition 'interp'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/dlua.cc:145:44: style:inconclusive: Function 'check_op' argument 2 names different: declaration '' definition 'err'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/dlua.cc:68:32: style:inconclusive: Function 'write' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/dlua.cc:91:31: style:inconclusive: Function 'read' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/domino.cc:58:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable uint32_t [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/end.cc:263:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/end.cc:263:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] 2.20.0 stone_soup-0.34.1/source/fixedp.h:246:44: style: Comparing expression of type 'unsigned char' against value 0. Condition is always true. [compareValueOutOfTypeRangeError] 2.20.0 stone_soup-0.34.1/source/fixedp.h:273:46: style: Comparing expression of type 'unsigned char' against value 0. Condition is always true. [compareValueOutOfTypeRangeError] 2.20.0 stone_soup-0.34.1/source/fixedp.h:290:31: style: Comparing expression of type 'const unsigned char' against value 0. Condition is always true. [compareValueOutOfTypeRangeError] 2.20.0 stone_soup-0.34.1/source/fixedp.h:295:31: style: Comparing expression of type 'const unsigned char' against value 0. Condition is always true. [compareValueOutOfTypeRangeError] 2.20.0 stone_soup-0.34.1/source/fixedp.h:511:35: style: Comparing expression of type 'unsigned char' against value 0. Condition is always true. [compareValueOutOfTypeRangeError] 2.20.0 stone_soup-0.34.1/source/fixedp.h:546:33: style: Variable 'cv_test4' is assigned a value that is never used. [unreadVariable] 2.20.0 stone_soup-0.34.1/source/fixedp.h:685:14: style: Variable 'test' is assigned a value that is never used. [unreadVariable] head stone_soup-0.34.1/source/game-options.cc:110:75: style:inconclusive: Function 'loadFromString' argument 2 names different: declaration '' definition 'ltyp'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/game-options.cc:120:75: style:inconclusive: Function 'loadFromString' argument 2 names different: declaration '' definition 'ltyp'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/game-options.cc:144:72: style:inconclusive: Function 'loadFromString' argument 2 names different: declaration '' definition 'ltyp'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/game-options.cc:157:75: style:inconclusive: Function 'loadFromString' argument 2 names different: declaration '' definition 'ltyp'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/game-options.cc:174:75: style:inconclusive: Function 'loadFromString' argument 2 names different: declaration '' definition 'ltyp'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/game-options.cc:96:73: style:inconclusive: Function 'loadFromString' argument 2 names different: declaration '' definition 'ltyp'. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/ghost.h:51:39: performance: Function parameter 'name' should be passed by const reference. [passedByValue] 2.20.0 stone_soup-0.34.1/source/hiscores.cc:1062:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/hiscores.cc:1792:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/hiscores.cc:1793:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable description [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/hiscores.cc:1841:56: style:inconclusive: Function 'game_time' argument 1 names different: declaration '' definition 'verbosity'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/hiscores.cc:2034:61: style:inconclusive: Function 'character_description' argument 1 names different: declaration '' definition 'verbosity'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/hiscores.cc:2134:58: style:inconclusive: Function 'death_place' argument 1 names different: declaration '' definition 'verbosity'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/hiscores.cc:2173:64: style:inconclusive: Function 'death_description' argument 1 names different: declaration '' definition 'verbosity'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/hiscores.cc:3070:45: style:inconclusive: Function 'str_field' argument 1 names different: declaration '' definition 's'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/hiscores.cc:3075:42: style:inconclusive: Function 'int_field' argument 1 names different: declaration '' definition 's'. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/hiscores.cc:535:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/hiscores.cc:753:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/hiscores.cc:94:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/initfile.cc:1118:34: style:inconclusive: Function 'str_to_channel' argument 1 names different: declaration '' definition 'str'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/initfile.cc:2028:60: style:inconclusive: Function 'remove_mon_glyph_override' argument 1 names different: declaration '' definition 'text'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/initfile.cc:2049:57: style:inconclusive: Function 'add_mon_glyph_override' argument 1 names different: declaration '' definition 'text'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/initfile.cc:2087:61: style:inconclusive: Function 'remove_item_glyph_override' argument 1 names different: declaration '' definition 'text'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/initfile.cc:2097:58: style:inconclusive: Function 'add_item_glyph_override' argument 1 names different: declaration '' definition 'text'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/initfile.cc:2116:58: style:inconclusive: Function 'remove_feature_override' argument 1 names different: declaration '' definition 'text'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/initfile.cc:2135:55: style:inconclusive: Function 'add_feature_override' argument 1 names different: declaration '' definition 'text'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/initfile.cc:2679:49: style:inconclusive: Function 'read_options' argument 1 names different: declaration '' definition 'il'. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/initfile.cc:321:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/initfile.cc:3776:42: style:inconclusive: Function 'split_parse' argument 4 names different: declaration '' definition 'remove'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/initfile.cc:3777:26: style:inconclusive: Function 'split_parse' argument 5 names different: declaration '' definition 'case_sensitive'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/initfile.cc:443:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tmp_seed [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/invent.cc:311:54: style:inconclusive: Function 'set_title_annotator' argument 1 names different: declaration 'fn' definition 'afn'. [funcArgNamesDifferent] stone_soup-0.34.1/source/invent.h:138:49: note: Function 'set_title_annotator' argument 1 names different: declaration 'fn' definition 'afn'. stone_soup-0.34.1/source/invent.cc:311:54: note: Function 'set_title_annotator' argument 1 names different: declaration 'fn' definition 'afn'. head stone_soup-0.34.1/source/invent.cc:873:0: style:inconclusive: Function 'init_item_sort_comparators' argument 2 names different: declaration '' definition 'set'. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/invent.cc:898:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable set [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/invent.h:118:46: style:inconclusive: Function 'get_tiles' argument 1 names different: declaration 'tiles' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/invent.h:177:40: style:inconclusive: Function 'get_select_count_string' argument 1 names different: declaration 'count' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/item-name.cc:1471:36: style: Condition 'testbits(weap.flags,ISFLAG_REPLICA)' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/item-name.cc:1471:36: note: Calling function 'testbits' returns 0 stone_soup-0.34.1/source/item-name.cc:1471:36: note: Condition 'testbits(weap.flags,ISFLAG_REPLICA)' is always false head stone_soup-0.34.1/source/kills.cc:181:40: style:inconclusive: Function 'add_kill_info' argument 1 names different: declaration '' definition 'killtext'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/kills.cc:182:50: style:inconclusive: Function 'add_kill_info' argument 2 names different: declaration '' definition 'kills'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/kills.cc:321:26: style:inconclusive: Function 'save' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/kills.cc:338:26: style:inconclusive: Function 'load' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/kills.cc:551:29: style:inconclusive: Function 'save' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/kills.cc:561:29: style:inconclusive: Function 'load' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/kills.cc:611:31: style:inconclusive: Function 'save' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/kills.cc:618:31: style:inconclusive: Function 'load' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/kills.cc:61:31: style:inconclusive: Function 'save' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/kills.cc:630:53: style:inconclusive: Function 'kill_monster_desc' argument 1 names different: declaration '' definition 'mon'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/kills.cc:659:58: style:inconclusive: Function 'kill_monster_desc' argument 1 names different: declaration '' definition 'mon'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/kills.cc:687:38: style:inconclusive: Function 'save' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/kills.cc:693:38: style:inconclusive: Function 'load' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/kills.cc:70:31: style:inconclusive: Function 'load' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/l-colour.cc:24:21: style:inconclusive: Function 'get_nth' argument 1 names different: declaration 'n' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/l-dgnmon.cc:173:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable random_mons [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/l-dgnmon.cc:52:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/l-dgntil.cc:40:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/l-dgntil.cc:42:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable rock_tile [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/l-dgntil.cc:48:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/l-dgntil.cc:50:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable floor_tile [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/l-file.cc:91:12: performance: Assigning the result of c_str() to a std::string is slow and redundant. [stlcstrAssignment] 2.20.0 stone_soup-0.34.1/source/l-mapgrd.cc:19:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/l-mapgrd.cc:45:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/l-subvault.cc:10:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/l-subvault.cc:18:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/l-subvault.cc:26:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/l-subvault.cc:37:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/l-you.cc:1438:22: performance: Assigning the result of c_str() to a std::string is slow and redundant. [stlcstrAssignment] 2.20.0 stone_soup-0.34.1/source/libunix.cc:1261:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable pair [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/libunix.cc:1280:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable pair [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/libunix.cc:1290:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COLOR_BLACK [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/libunix.cc:425:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable pair [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/macro.cc:1190:31: performance: Function parameter 'key' should be passed by const reference. [passedByValue] head stone_soup-0.34.1/source/macro.cc:2136:26: style: Variable 'data' can be declared as reference to const [constVariableReference] head stone_soup-0.34.1/source/makeitem.h:33:51: style:inconclusive: Function 'is_weapon_brand_ok' argument 3 names different: declaration 'strict' definition ''. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/mapdef.h:1322:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/menu.cc:3614:67: style:inconclusive: Function 'strip_blank_lines' argument 1 names different: declaration '' definition 'fs'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/menu.h:190:46: style:inconclusive: Function 'get_tiles' argument 1 names different: declaration 'tileset' definition ''. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/menu.h:325:32: performance: Function parameter 's' should be passed by const reference. [passedByValue] head stone_soup-0.34.1/source/menu.h:450:48: style:inconclusive: Function 'get_select_count_string' argument 1 names different: declaration 'count' definition ''. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/message.cc:1271:14: warning:inconclusive: If memory allocation fails, then there is a possible null pointer dereference: heapbuf [nullPointerOutOfMemory] stone_soup-0.34.1/source/message.cc:1269:38: note: Assuming allocation function fails stone_soup-0.34.1/source/message.cc:1269:25: note: Assignment 'heapbuf=(char*)std::malloc(len+1)', assigned value is 0 stone_soup-0.34.1/source/message.cc:1271:14: note: Null pointer dereference head stone_soup-0.34.1/source/message.cc:724:29: style: Condition 'is_tiles()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/message.cc:724:29: note: Calling function 'is_tiles' returns 0 stone_soup-0.34.1/source/message.cc:724:29: note: Condition 'is_tiles()' is always false head stone_soup-0.34.1/source/message.h:123:63: style:inconclusive: Function 'append' argument 2 names different: declaration 'ch' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/mon-pick.cc:84:48: style:inconclusive: Function 'pick_monster_from' argument 3 names different: declaration '' definition 'veto'. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/mon-poly.cc:552:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable set [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/mon-poly.cc:568:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable set [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/mon-poly.cc:625:18: style: The scope of the variable 'oldc' can be reduced. [variableScope] 2.20.0 stone_soup-0.34.1/source/newgame-def.h:27:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/newgame.cc:1023:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/newgame.cc:2102:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/newgame.cc:2302:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/newgame.cc:2326:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/ng-init.cc:101:14: style: Variable 'main_temple' can be declared as pointer to const [constVariablePointer] head stone_soup-0.34.1/source/ng-init.cc:74:51: performance: Function parameter 'temple_gods' should be passed by const reference. [passedByValue] 2.20.0 stone_soup-0.34.1/source/ng-setup.cc:395:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable map [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/notes.cc:564:25: style:inconclusive: Function 'save_notes' argument 1 names different: declaration '' definition 'outf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/notes.cc:572:25: style:inconclusive: Function 'load_notes' argument 1 names different: declaration '' definition 'inf'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/options.h:1011:54: style:inconclusive: Function 'add_mon_glyph_override' argument 2 names different: declaration 'prepend' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/options.h:1020:57: style:inconclusive: Function 'add_force_spell_targeter' argument 2 names different: declaration 'prepend' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/options.h:1022:59: style:inconclusive: Function 'add_force_ability_targeter' argument 2 names different: declaration 'prepend' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/options.h:1024:58: style:inconclusive: Function 'add_force_scroll_targeter' argument 2 names different: declaration 'prepend' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/options.h:334:54: style:inconclusive: Function 'read_custom_option' argument 1 names different: declaration 'state' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/options.h:334:66: style:inconclusive: Function 'read_custom_option' argument 2 names different: declaration 'runscripts' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/options.h:403:52: style:inconclusive: Function 'set_option_fragment' argument 2 names different: declaration 'prepend' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/options.h:982:52: style:inconclusive: Function 'add_feature_override' argument 2 names different: declaration 'prepend' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/outer-menu.cc:247:50: style:inconclusive: Function '_get_preferred_size' argument 1 names different: declaration '' definition 'dim'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/outer-menu.cc:247:59: style:inconclusive: Function '_get_preferred_size' argument 2 names different: declaration '' definition 'prosp_width'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/output.cc:1418:53: style: Assigned value '_is_using_small_layout()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1418:53: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1418:53: note: Assigned value '_is_using_small_layout()' is always false head stone_soup-0.34.1/source/output.cc:1586:35: style: Condition '_is_using_small_layout()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1586:35: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1586:35: note: Condition '_is_using_small_layout()' is always false head stone_soup-0.34.1/source/output.cc:1639:31: style: Condition '_is_using_small_layout()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:1639:31: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:1639:31: note: Condition '_is_using_small_layout()' is always false head stone_soup-0.34.1/source/output.cc:810:31: style: Condition '_is_using_small_layout()' is always false [knownConditionTrueFalse] stone_soup-0.34.1/source/output.cc:810:31: note: Calling function '_is_using_small_layout' returns 0 stone_soup-0.34.1/source/output.cc:810:31: note: Condition '_is_using_small_layout()' is always false head stone_soup-0.34.1/source/playable.cc:31:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable job_type [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/playable.cc:32:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NUM_JOBS [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/player-equip.cc:754:15: style: Variable 'cursed_item' can be declared as pointer to const [constVariablePointer] head stone_soup-0.34.1/source/potion.cc:50:46: style:inconclusive: Function 'PotionEffect' argument 1 names different: declaration '' definition 'pot'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/potion.h:19:36: style:inconclusive: Function 'can_quaff' argument 1 names different: declaration 'reason' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/potion.h:19:59: style:inconclusive: Function 'can_quaff' argument 2 names different: declaration 'temp' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/precision-menu.h:363:48: style:inconclusive: Function 'process_input' argument 1 names different: declaration 'key' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/precision-menu.h:49:42: style:inconclusive: Function 'select' argument 2 names different: declaration 'value' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/prompt.cc:132:0: style:inconclusive: Function 'yesno' argument 7 names different: declaration '' definition 'map'. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/quiver.h:127:32: performance: Function parameter 'key' should be passed by const reference. [passedByValue] head stone_soup-0.34.1/source/random-var.cc:18:50: style:inconclusive: Function 'random_var' argument 3 names different: declaration 'w_' definition 'w'. [funcArgNamesDifferent] stone_soup-0.34.1/source/random-var.h:23:42: note: Function 'random_var' argument 3 names different: declaration 'w_' definition 'w'. stone_soup-0.34.1/source/random-var.cc:18:50: note: Function 'random_var' argument 3 names different: declaration 'w_' definition 'w'. head stone_soup-0.34.1/source/random.cc:44:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable uint64_t [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/rltiles/tool/tile.cc:531:40: style: Parameter 'find' can be declared as reference to const [constParameterReference] head stone_soup-0.34.1/source/rltiles/tool/tile.cc:531:59: style: Parameter 'replace' can be declared as reference to const [constParameterReference] head stone_soup-0.34.1/source/skill-menu.cc:1732:60: style:inconclusive: Function '_get_preferred_size' argument 2 names different: declaration 'prosp_width' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/skill-menu.h:78:29: style:inconclusive: Function 'is_selectable' argument 1 names different: declaration 'keep_hotkey' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/species.cc:610:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable species_type [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/species.cc:611:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NUM_SPECIES [valueFlowBailoutIncompleteVar] head stone_soup-0.34.1/source/sqldbm.h:100:43: style:inconclusive: Function 'dbm_store' argument 4 names different: declaration 'overwrite' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/sqldbm.h:93:61: style:inconclusive: Function 'dbm_open' argument 3 names different: declaration 'permissions' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/store.cc:1208:36: style:inconclusive: Function 'write' argument 1 names different: declaration '' definition 'th'. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/store.cc:1228:22: style:inconclusive: Either there is a missing 'override', or the member function 'CrawlHashTable::read' can be const. [functionConst] stone_soup-0.34.1/source/store.h:250:10: note: Either there is a missing 'override', or the member function 'CrawlHashTable::read' can be const. stone_soup-0.34.1/source/store.cc:1228:22: note: Either there is a missing 'override', or the member function 'CrawlHashTable::read' can be const. head stone_soup-0.34.1/source/store.cc:1228:35: style:inconclusive: Function 'read' argument 1 names different: declaration '' definition 'th'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/store.cc:1389:33: style:inconclusive: Function 'write' argument 1 names different: declaration '' definition 'th'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/store.cc:1412:32: style:inconclusive: Function 'read' argument 1 names different: declaration '' definition 'th'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/store.cc:431:37: style:inconclusive: Function 'write' argument 1 names different: declaration '' definition 'th'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/store.cc:548:36: style:inconclusive: Function 'read' argument 1 names different: declaration '' definition 'th'. [funcArgNamesDifferentUnnamed] 2.20.0 stone_soup-0.34.1/source/stringutil.cc:291:16: warning:inconclusive: If memory allocation fails, then there is a possible null pointer dereference: buf2 [nullPointerOutOfMemory] stone_soup-0.34.1/source/stringutil.cc:287:31: note: Assuming allocation function fails stone_soup-0.34.1/source/stringutil.cc:287:18: note: Assignment 'buf2=(char*)std::malloc(len+1)', assigned value is 0 stone_soup-0.34.1/source/stringutil.cc:291:16: note: Null pointer dereference head stone_soup-0.34.1/source/stringutil.cc:88:31: style:inconclusive: Function 'lowercase_first' argument 1 names different: declaration '' definition 's'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/stringutil.cc:99:31: style:inconclusive: Function 'uppercase_first' argument 1 names different: declaration '' definition 's'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/transform.cc:308:24: style:inconclusive: Function 'ev_bonus' argument 1 names different: declaration '' definition 'skill'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/transform.cc:324:32: style:inconclusive: Function 'get_body_ac_mult' argument 1 names different: declaration '' definition 'skill'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/ui.cc:1366:15: style: Variable 'cp' can be declared as reference to const [constVariableReference] head stone_soup-0.34.1/source/ui.cc:1367:15: style: Variable 'cs' can be declared as reference to const [constVariableReference] head stone_soup-0.34.1/source/ui.cc:418:31: style:inconclusive: Function 'set_visible' argument 1 names different: declaration '' definition 'visible'. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/ui.cc:622:14: style: Variable 'cr_main_size' can be declared as reference to const [constVariableReference] head stone_soup-0.34.1/source/ui.cc:69:1: warning: Member variable 'UIRoot::m_h' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.cc:69:1: warning: Member variable 'UIRoot::m_w' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.cc:69:1: warning: Member variable 'UIRoot::needs_paint' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.cc:69:1: warning: Member variable 'UIRoot::needs_swap' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:1099:60: style:inconclusive: Function '_get_preferred_size' argument 2 names different: declaration 'prosp_width' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/ui.h:313:51: style:inconclusive: Function '_get_preferred_size' argument 1 names different: declaration 'dim' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/ui.h:313:60: style:inconclusive: Function '_get_preferred_size' argument 2 names different: declaration 'prosp_width' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/ui.h:545:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:545:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:552:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:552:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:559:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:559:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] 2.20.0 stone_soup-0.34.1/source/ui.h:590:14: style:inconclusive: Technically the member function 'ui::Bin::iterator::operator!=' can be const. [functionConst] head stone_soup-0.34.1/source/ui.h:607:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:607:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] 2.20.0 stone_soup-0.34.1/source/ui.h:664:14: style:inconclusive: Technically the member function 'ui::ContainerVec::iterator::operator!=' can be const. [functionConst] head stone_soup-0.34.1/source/ui.h:828:52: style:inconclusive: Function '_get_preferred_size' argument 2 names different: declaration 'prosp_width' definition ''. [funcArgNamesDifferentUnnamed] head stone_soup-0.34.1/source/ui.h:840:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:840:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:854:1: warning: Member variable 'Switcher::m_current' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:854:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:854:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:874:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:874:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:923:23: warning: Member variable 'track_info::offset' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:923:23: warning: Member variable 'track_info::size' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:923:23: warning: Member variable 'track_info::sr' has no initializer. [uninitMemberVarNoCtor] 2.20.0 stone_soup-0.34.1/source/ui.h:965:14: style:inconclusive: Technically the member function 'ui::Grid::iterator::operator!=' can be const. [functionConst] head stone_soup-0.34.1/source/ui.h:979:1: warning: Member variable 'Widget::cached_sr' has no initializer. [uninitMemberVarNoCtor] head stone_soup-0.34.1/source/ui.h:979:1: warning: Member variable 'Widget::cached_sr_pw' has no initializer. [uninitMemberVarNoCtor] 2.20.0 stone_soup-0.34.1/source/viewchar.cc:151:0: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable set [valueFlowBailoutIncompleteVar] 2.20.0 stone_soup-0.34.1/source/wiz-fsim.h:23:33: performance: Function parameter 'prefix' should be passed by const reference. [passedByValue] 2.20.0 stone_soup-0.34.1/source/wiz-fsim.h:49:33: performance: Function parameter 'prefix' should be passed by const reference. [passedByValue] head stone_soup-0.34.1/source/worley.cc:199:43: style:inconclusive: Function 'AddSamples' argument 8 names different: declaration '' definition 'ID'. [funcArgNamesDifferentUnnamed] DONE