2022-06-26 21:28 ftp://ftp.de.debian.org/debian/pool/main/c/cpl-plugin-fors/cpl-plugin-fors_5.5.7+dfsg.orig.tar.xz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --inline-suppr --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j4 platform: Linux-5.10.0-15-amd64-x86_64-with-glibc2.31 python: 3.9.2 client-version: 1.3.25 compiler: g++ (Debian 10.2.1-6) 10.2.1 20210110 cppcheck: head 2.8 head-info: 242afc3 (2022-06-25 21:42:55 +0200) count: 899 898 elapsed-time: 113.1 111.8 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: fors-5.5.7/fors/fors_calibrated_slits.cc:52:30: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_ccd_config.h:39:5: style: Class 'fiera_config' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fors-5.5.7/fors/fors_ccd_config.cc:86:20: style:inconclusive: Function 'ccd_config_read' argument 1 names different: declaration 'target' definition 'source'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_ccd_config.h:52:20: note: Function 'ccd_config_read' argument 1 names different: declaration 'target' definition 'source'. fors-5.5.7/fors/fors_ccd_config.cc:86:20: note: Function 'ccd_config_read' argument 1 names different: declaration 'target' definition 'source'. fors-5.5.7/fors/fors_bpm.cc:84:40: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bpm.cc:85:39: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bpm.cc:31:14: style:inconclusive: Function 'fors_bpm_create_combined_bpm' argument 1 names different: declaration 'non_linear_flat_masks' definition 'non_linear_masks'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_bpm.h:30:14: note: Function 'fors_bpm_create_combined_bpm' argument 1 names different: declaration 'non_linear_flat_masks' definition 'non_linear_masks'. fors-5.5.7/fors/fors_bpm.cc:31:14: note: Function 'fors_bpm_create_combined_bpm' argument 1 names different: declaration 'non_linear_flat_masks' definition 'non_linear_masks'. fors-5.5.7/fors/fors_bpm.cc:32:14: style:inconclusive: Function 'fors_bpm_create_combined_bpm' argument 2 names different: declaration 'saturated_flat_masks' definition 'saturated_masks'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_bpm.h:31:14: note: Function 'fors_bpm_create_combined_bpm' argument 2 names different: declaration 'saturated_flat_masks' definition 'saturated_masks'. fors-5.5.7/fors/fors_bpm.cc:32:14: note: Function 'fors_bpm_create_combined_bpm' argument 2 names different: declaration 'saturated_flat_masks' definition 'saturated_masks'. fors-5.5.7/fors/fors_bpm.cc:80:13: style:inconclusive: Function 'fors_bpm_create_combined_bpm' argument 1 names different: declaration 'non_linear_flat_mask' definition 'non_linear_mask'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_bpm.h:35:13: note: Function 'fors_bpm_create_combined_bpm' argument 1 names different: declaration 'non_linear_flat_mask' definition 'non_linear_mask'. fors-5.5.7/fors/fors_bpm.cc:80:13: note: Function 'fors_bpm_create_combined_bpm' argument 1 names different: declaration 'non_linear_flat_mask' definition 'non_linear_mask'. fors-5.5.7/fors/fors_bpm.cc:81:13: style:inconclusive: Function 'fors_bpm_create_combined_bpm' argument 2 names different: declaration 'saturated_flat_mask' definition 'saturated_mask'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_bpm.h:36:13: note: Function 'fors_bpm_create_combined_bpm' argument 2 names different: declaration 'saturated_flat_mask' definition 'saturated_mask'. fors-5.5.7/fors/fors_bpm.cc:81:13: note: Function 'fors_bpm_create_combined_bpm' argument 2 names different: declaration 'saturated_flat_mask' definition 'saturated_mask'. fors-5.5.7/fors/fors_detected_slits.cc:61:21: style: Redundant initialization for 'disp_bottom'. The initialized value is overwritten before it is read. [redundantInitialization] fors-5.5.7/fors/fors_detected_slits.cc:59:28: note: disp_bottom is initialized fors-5.5.7/fors/fors_detected_slits.cc:61:21: note: disp_bottom is overwritten fors-5.5.7/fors/fors_detected_slits.cc:64:18: style: Redundant initialization for 'disp_top'. The initialized value is overwritten before it is read. [redundantInitialization] fors-5.5.7/fors/fors_detected_slits.cc:62:28: note: disp_top is initialized fors-5.5.7/fors/fors_detected_slits.cc:64:18: note: disp_top is overwritten fors-5.5.7/fors/fors_dark_impl.cc:85:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_dark_impl.cc:134:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_dark_impl.cc:141:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_dark_impl.cc:146:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_dark_impl.cc:155:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_dark_impl.cc:162:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_dark_impl.cc:172:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_dark_impl.cc:221:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_dark_impl.cc:225:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_dark_impl.cc:243:4: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_dark_impl.cc:246:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:108:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:122:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:134:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:147:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:159:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:171:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:173:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:220:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:224:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:234:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:240:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:259:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:270:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:276:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:280:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:291:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_bias_impl.cc:294:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_dfs_idp.c:50:80: style:inconclusive: Function 'fors_dfs_idp_property_converter_delete' argument 1 names different: declaration 'conv' definition 'self'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_dfs_idp.h:54:80: note: Function 'fors_dfs_idp_property_converter_delete' argument 1 names different: declaration 'conv' definition 'self'. fors-5.5.7/fors/fors_dfs_idp.c:50:80: note: Function 'fors_dfs_idp_property_converter_delete' argument 1 names different: declaration 'conv' definition 'self'. fors-5.5.7/fors/fors_dfs_idp.c:136:87: style:inconclusive: Function 'fors_dfs_idp_property_converter_list_push_back' argument 1 names different: declaration 'list' definition 'self'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_dfs_idp.h:73:87: note: Function 'fors_dfs_idp_property_converter_list_push_back' argument 1 names different: declaration 'list' definition 'self'. fors-5.5.7/fors/fors_dfs_idp.c:136:87: note: Function 'fors_dfs_idp_property_converter_list_push_back' argument 1 names different: declaration 'list' definition 'self'. fors-5.5.7/fors/fors_dfs_idp.c:163:92: style:inconclusive: Function 'fors_dfs_idp_property_converter_list_get_size' argument 1 names different: declaration 'list' definition 'self'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_dfs_idp.h:77:92: note: Function 'fors_dfs_idp_property_converter_list_get_size' argument 1 names different: declaration 'list' definition 'self'. fors-5.5.7/fors/fors_dfs_idp.c:163:92: note: Function 'fors_dfs_idp_property_converter_list_get_size' argument 1 names different: declaration 'list' definition 'self'. fors-5.5.7/fors/fors_dfs_idp.c:175:93: style:inconclusive: Function 'fors_dfs_idp_property_converter_list_get_const' argument 1 names different: declaration 'list' definition 'self'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_dfs_idp.h:80:93: note: Function 'fors_dfs_idp_property_converter_list_get_const' argument 1 names different: declaration 'list' definition 'self'. fors-5.5.7/fors/fors_dfs_idp.c:175:93: note: Function 'fors_dfs_idp_property_converter_list_get_const' argument 1 names different: declaration 'list' definition 'self'. fors-5.5.7/fors/fors_dfs_idp.c:201:56: style:inconclusive: Function 'fors_dfs_idp_converter_delete' argument 1 names different: declaration 'idp_conv' definition 'self'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_dfs_idp.h:92:56: note: Function 'fors_dfs_idp_converter_delete' argument 1 names different: declaration 'idp_conv' definition 'self'. fors-5.5.7/fors/fors_dfs_idp.c:201:56: note: Function 'fors_dfs_idp_converter_delete' argument 1 names different: declaration 'idp_conv' definition 'self'. fors-5.5.7/fors/fors_double.c:85:10: warning: Redundant assignment of 'data' to itself. [selfAssignment] fors-5.5.7/fors/fors_double.c:85:10: style: Variable 'data' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/fors_grism.cc:48:20: style:inconclusive: Function 'fors_grism_config_from_table' argument 1 names different: declaration 'grism_table' definition 'table'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_grism.h:32:20: note: Function 'fors_grism_config_from_table' argument 1 names different: declaration 'grism_table' definition 'table'. fors-5.5.7/fors/fors_grism.cc:48:20: note: Function 'fors_grism_config_from_table' argument 1 names different: declaration 'grism_table' definition 'table'. fors-5.5.7/fors/fors_flat_normalise.h:95:18: performance:inconclusive: Technically the member function 'fors::flat_normaliser::get_normalization_weights_mos' can be static (but you may consider moving to unnamed namespace). [functionStatic] fors-5.5.7/fors/fors_flat_normalise.cc:677:37: note: Technically the member function 'fors::flat_normaliser::get_normalization_weights_mos' can be static (but you may consider moving to unnamed namespace). fors-5.5.7/fors/fors_flat_normalise.h:95:18: note: Technically the member function 'fors::flat_normaliser::get_normalization_weights_mos' can be static (but you may consider moving to unnamed namespace). fors-5.5.7/fors/fors_flat_normalise.h:102:18: performance:inconclusive: Technically the member function 'fors::flat_normaliser::get_normalization_weights_lss' can be static (but you may consider moving to unnamed namespace). [functionStatic] fors-5.5.7/fors/fors_flat_normalise.cc:707:37: note: Technically the member function 'fors::flat_normaliser::get_normalization_weights_lss' can be static (but you may consider moving to unnamed namespace). fors-5.5.7/fors/fors_flat_normalise.h:102:18: note: Technically the member function 'fors::flat_normaliser::get_normalization_weights_lss' can be static (but you may consider moving to unnamed namespace). fors-5.5.7/fors/fors_flat_normalise.cc:487:21: style: The scope of the variable 'func' can be reduced. [variableScope] fors-5.5.7/fors/fors_flat_normalise.cc:661:39: style: Variable 'ex' can be declared as reference to const [constVariable] fors-5.5.7/fors/fors_identify.c:256:47: style:inconclusive: Function 'fors_identify_method_delete' argument 1 names different: declaration 'im' definition 'em'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_identify.h:46:47: note: Function 'fors_identify_method_delete' argument 1 names different: declaration 'im' definition 'em'. fors-5.5.7/fors/fors_identify.c:256:47: note: Function 'fors_identify_method_delete' argument 1 names different: declaration 'im' definition 'em'. fors-5.5.7/fors/fors_identify.c:744:15: style: Local variable 'i' shadows outer variable [shadowVariable] fors-5.5.7/fors/fors_identify.c:624:26: note: Shadowed declaration fors-5.5.7/fors/fors_identify.c:744:15: note: Shadow variable fors-5.5.7/fors/fors_extract.c:391:9: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] fors-5.5.7/fors/fors_img_idp.cc:390:18: style: The scope of the variable 'zp_key' can be reduced. [variableScope] fors-5.5.7/fors/fors_img_idp.cc:391:18: style: The scope of the variable 'zp_e_key' can be reduced. [variableScope] fors-5.5.7/fors/fors_image.c:458:9: style: Same expression used in consecutive assignments of 'xstep' and 'ystep'. [duplicateAssignExpression] fors-5.5.7/fors/fors_image.c:465:9: note: Same expression used in consecutive assignments of 'xstep' and 'ystep'. fors-5.5.7/fors/fors_image.c:458:9: note: Same expression used in consecutive assignments of 'xstep' and 'ystep'. fors-5.5.7/fors/fors_image.c:102:44: style:inconclusive: Function 'fors_image_new' argument 2 names different: declaration 'weights' definition 'variance'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_image.h:75:56: note: Function 'fors_image_new' argument 2 names different: declaration 'weights' definition 'variance'. fors-5.5.7/fors/fors_image.c:102:44: note: Function 'fors_image_new' argument 2 names different: declaration 'weights' definition 'variance'. fors-5.5.7/fors/fors_image.c:966:54: style: Parameter 'dmean' can be declared as pointer to const [constParameter] fors-5.5.7/fors/fors_image.c:983:56: style: Parameter 'dmedian' can be declared as pointer to const [constParameter] fors-5.5.7/fors/fors_image.c:1373:55: style: Parameter 'dstdev' can be declared as pointer to const [constParameter] fors-5.5.7/fors/fors_image.c:1396:16: style: Parameter 'dstdev' can be declared as pointer to const [constParameter] fors-5.5.7/fors/fors_image.c:1437:60: style: Parameter 'dmean' can be declared as pointer to const [constParameter] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:78:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:133:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:140:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:145:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:156:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:163:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:168:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:174:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:179:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:205:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:125:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:211:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:137:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:216:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:149:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:239:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:161:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:258:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:164:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:266:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:220:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:295:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:224:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:298:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:229:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:128:12: style: The scope of the variable 'skylevel' can be reduced. [variableScope] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:240:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:129:12: style: The scope of the variable 'first_frame' can be reduced. [variableScope] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:247:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:251:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:257:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_sky_flat_impl.cc:227:18: style: Variable 'skylevel' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:262:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:288:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:294:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:299:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:303:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:311:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:317:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:323:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:329:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:332:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:376:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:390:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:401:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:489:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:499:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:551:27: style:inconclusive: Function 'write_qc' argument 2 names different: declaration 'first_raw' definition 'first_raw_frame'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_img_screen_flat_impl.cc:93:27: note: Function 'write_qc' argument 2 names different: declaration 'first_raw' definition 'first_raw_frame'. fors-5.5.7/fors/fors_img_screen_flat_impl.cc:551:27: note: Function 'write_qc' argument 2 names different: declaration 'first_raw' definition 'first_raw_frame'. fors-5.5.7/fors/fors_overscan.cc:126:35: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_paf.c:133:36: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] fors-5.5.7/fors/fors_img_science_impl.cc:122:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:138:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:152:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:154:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:231:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:238:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:243:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:248:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:251:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:252:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:258:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:264:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:269:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:285:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:288:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:301:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:305:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:312:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:317:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:323:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:328:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:353:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:359:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:368:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:375:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:380:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:383:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:388:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:396:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:527:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:533:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:585:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:612:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:618:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_img_science_impl.cc:621:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_point.c:87:37: style:inconclusive: Function 'fors_point_delete' argument 1 names different: declaration 'point' definition 'p'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_point.h:47:37: note: Function 'fors_point_delete' argument 1 names different: declaration 'point' definition 'p'. fors-5.5.7/fors/fors_point.c:87:37: note: Function 'fors_point_delete' argument 1 names different: declaration 'point' definition 'p'. fors-5.5.7/fors/fors_qc.c:240:27: warning: Either the condition 'instrument==NULL' is redundant or there is possible null pointer dereference: instrument. [nullPointerRedundantCheck] fors-5.5.7/fors/fors_qc.c:244:55: note: Assuming that condition 'instrument==NULL' is not redundant fors-5.5.7/fors/fors_qc.c:240:27: note: Null pointer dereference fors-5.5.7/fors/fors_qc.c:272:27: warning: Either the condition 'instrument==NULL' is redundant or there is possible null pointer dereference: instrument. [nullPointerRedundantCheck] fors-5.5.7/fors/fors_qc.c:276:55: note: Assuming that condition 'instrument==NULL' is not redundant fors-5.5.7/fors/fors_qc.c:272:27: note: Null pointer dereference fors-5.5.7/fors/fors_qc.c:327:27: warning: Either the condition 'instrument==NULL' is redundant or there is possible null pointer dereference: instrument. [nullPointerRedundantCheck] fors-5.5.7/fors/fors_qc.c:331:55: note: Assuming that condition 'instrument==NULL' is not redundant fors-5.5.7/fors/fors_qc.c:327:27: note: Null pointer dereference fors-5.5.7/fors/fors_qc.c:367:27: warning: Either the condition 'instrument==NULL' is redundant or there is possible null pointer dereference: instrument. [nullPointerRedundantCheck] fors-5.5.7/fors/fors_qc.c:371:55: note: Assuming that condition 'instrument==NULL' is not redundant fors-5.5.7/fors/fors_qc.c:367:27: note: Null pointer dereference fors-5.5.7/fors/fors_response.cc:44:39: style:inconclusive: Function 'fors_compute_response' argument 16 names different: declaration 'response_interp' definition 'response_obs_binning'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_response.h:42:39: note: Function 'fors_compute_response' argument 16 names different: declaration 'response_interp' definition 'response_obs_binning'. fors-5.5.7/fors/fors_response.cc:44:39: note: Function 'fors_compute_response' argument 16 names different: declaration 'response_interp' definition 'response_obs_binning'. fors-5.5.7/fors/fors_saturation_mos.cc:80:27: style: The scope of the variable 'this_flat' can be reduced. [variableScope] fors-5.5.7/fors/fors_star.c:184:24: style:inconclusive: Function 'fors_star_new_from_table' argument 13 names different: declaration 'flux_aper_max_col' definition 'flux_max_col'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_star.h:86:26: note: Function 'fors_star_new_from_table' argument 13 names different: declaration 'flux_aper_max_col' definition 'flux_max_col'. fors-5.5.7/fors/fors_star.c:184:24: note: Function 'fors_star_new_from_table' argument 13 names different: declaration 'flux_aper_max_col' definition 'flux_max_col'. fors-5.5.7/fors/fors_stats.c:57:74: style:inconclusive: Function 'fors_write_max_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_stats.h:37:74: note: Function 'fors_write_max_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:57:74: note: Function 'fors_write_max_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:80:74: style:inconclusive: Function 'fors_write_min_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_stats.h:40:74: note: Function 'fors_write_min_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:80:74: note: Function 'fors_write_min_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:102:75: style:inconclusive: Function 'fors_write_mean_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_stats.h:43:75: note: Function 'fors_write_mean_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:102:75: note: Function 'fors_write_mean_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:125:59: style:inconclusive: Function 'fors_write_stdev_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_stats.h:46:76: note: Function 'fors_write_stdev_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:125:59: note: Function 'fors_write_stdev_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:147:77: style:inconclusive: Function 'fors_write_median_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_stats.h:49:77: note: Function 'fors_write_median_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:147:77: note: Function 'fors_write_median_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:190:63: style:inconclusive: Function 'fors_write_num_bad_pixels_propertylist' argument 2 names different: declaration 'l' definition 'list'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_stats.h:53:63: note: Function 'fors_write_num_bad_pixels_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:190:63: note: Function 'fors_write_num_bad_pixels_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:227:66: style:inconclusive: Function 'fors_write_images_mean_mean_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_stats.h:57:61: note: Function 'fors_write_images_mean_mean_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:227:66: note: Function 'fors_write_images_mean_mean_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:264:68: style:inconclusive: Function 'fors_write_images_median_mean_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_stats.h:61:61: note: Function 'fors_write_images_median_mean_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:264:68: note: Function 'fors_write_images_median_mean_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:305:67: style:inconclusive: Function 'fors_write_images_mean_stddev_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_stats.h:65:61: note: Function 'fors_write_images_mean_stddev_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_stats.c:305:67: note: Function 'fors_write_images_mean_stddev_in_propertylist' argument 2 names different: declaration 'l' definition 'list'. fors-5.5.7/fors/fors_std_star.c:478:10: warning: Redundant assignment of 'data' to itself. [selfAssignment] fors-5.5.7/fors/fors_std_star.c:478:10: style: Variable 'data' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/fors_trimm_illum.cc:134:45: style:inconclusive: Function 'fors_trimm_non_illum' argument 4 names different: declaration 'illum_region' definition 'illum_regions'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_trimm_illum.h:39:45: note: Function 'fors_trimm_non_illum' argument 4 names different: declaration 'illum_region' definition 'illum_regions'. fors-5.5.7/fors/fors_trimm_illum.cc:134:45: note: Function 'fors_trimm_non_illum' argument 4 names different: declaration 'illum_region' definition 'illum_regions'. fors-5.5.7/fors/fors_trimm_illum.cc:171:45: style:inconclusive: Function 'fors_trimm_non_illum' argument 4 names different: declaration 'illum_region' definition 'illum_regions'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_trimm_illum.h:44:45: note: Function 'fors_trimm_non_illum' argument 4 names different: declaration 'illum_region' definition 'illum_regions'. fors-5.5.7/fors/fors_trimm_illum.cc:171:45: note: Function 'fors_trimm_non_illum' argument 4 names different: declaration 'illum_region' definition 'illum_regions'. fors-5.5.7/fors/fors_utils.c:125:0: error: #error CPL_VERSION_CODE not defined. CPL version too old [preprocessorErrorDirective] fors-5.5.7/fors/fors_std_cat.c:319:21: style: Variable 'out' is not assigned a value. [unassignedVariable] fors-5.5.7/fors/fors_std_cat.c:380:21: style: Variable 'out_offset' is not assigned a value. [unassignedVariable] fors-5.5.7/fors/fors_zeropoint_impl.cc:144:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:156:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:168:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:171:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:270:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:274:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:282:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:284:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:290:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:292:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:298:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:300:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:301:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:307:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:313:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:318:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:323:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:328:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:336:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:344:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:354:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:366:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:376:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:398:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:404:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:408:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:414:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:420:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:426:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:451:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:625:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:633:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:649:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:668:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:677:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:685:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:699:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:755:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:759:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:779:36: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:1266:46: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_zeropoint_impl.cc:1622:10: warning: Redundant assignment of 'self' to itself. [selfAssignment] fors-5.5.7/fors/fors_zeropoint_impl.cc:1623:11: warning: Redundant assignment of 'first' to itself. [selfAssignment] fors-5.5.7/fors/fors_zeropoint_impl.cc:1624:10: warning: Redundant assignment of 'last' to itself. [selfAssignment] fors-5.5.7/fors/fors_zeropoint_impl.cc:1622:10: style: Variable 'self' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/fors_zeropoint_impl.cc:1623:11: style: Variable 'first' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/fors_zeropoint_impl.cc:1624:10: style: Variable 'last' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/fors_dfs.c:1179:38: style:inconclusive: Function 'fors_dfs_save_image' argument 7 names different: declaration 'raw_frame' definition 'inherit_frame'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_dfs.h:137:31: note: Function 'fors_dfs_save_image' argument 7 names different: declaration 'raw_frame' definition 'inherit_frame'. fors-5.5.7/fors/fors_dfs.c:1179:38: note: Function 'fors_dfs_save_image' argument 7 names different: declaration 'raw_frame' definition 'inherit_frame'. fors-5.5.7/fors/fors_dfs.c:1306:38: style:inconclusive: Function 'fors_dfs_save_image_err' argument 8 names different: declaration 'raw_frame' definition 'inherit_frame'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_dfs.h:128:31: note: Function 'fors_dfs_save_image_err' argument 8 names different: declaration 'raw_frame' definition 'inherit_frame'. fors-5.5.7/fors/fors_dfs.c:1306:38: note: Function 'fors_dfs_save_image_err' argument 8 names different: declaration 'raw_frame' definition 'inherit_frame'. fors-5.5.7/fors/fors_dfs.c:1343:47: style:inconclusive: Function 'fors_dfs_save_image_err_mask' argument 8 names different: declaration 'raw_frame' definition 'inherit_frame'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_dfs.h:133:31: note: Function 'fors_dfs_save_image_err_mask' argument 8 names different: declaration 'raw_frame' definition 'inherit_frame'. fors-5.5.7/fors/fors_dfs.c:1343:47: note: Function 'fors_dfs_save_image_err_mask' argument 8 names different: declaration 'raw_frame' definition 'inherit_frame'. fors-5.5.7/fors/fors_dfs.c:1455:38: style:inconclusive: Function 'fors_dfs_save_table' argument 7 names different: declaration 'raw_frame' definition 'inherit_frame'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_dfs.h:150:22: note: Function 'fors_dfs_save_table' argument 7 names different: declaration 'raw_frame' definition 'inherit_frame'. fors-5.5.7/fors/fors_dfs.c:1455:38: note: Function 'fors_dfs_save_table' argument 7 names different: declaration 'raw_frame' definition 'inherit_frame'. fors-5.5.7/fors/tests/fors_zeropoint-test.c:125:5: style:inconclusive: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] fors-5.5.7/fors/tests/fors_zeropoint-test.c:118:29: style: Variable 'before' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/tests/list-test.c:71:10: warning: Redundant assignment of 'data' to itself. [selfAssignment] fors-5.5.7/fors/tests/list-test.c:78:10: warning: Redundant assignment of 'data' to itself. [selfAssignment] fors-5.5.7/fors/tests/list-test.c:71:10: style: Variable 'data' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/tests/list-test.c:78:10: style: Variable 'data' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_distortion.c:1003:31: error: There is an unknown macro here somewhere. Configuration is required. If CPL_STRINGIFY is a macro then please configure it. [unknownMacro] fors-5.5.7/irplib/irplib_calib.c:185:22: style: Parameter 'zone' can be declared as pointer to const [constParameter] fors-5.5.7/irplib/irplib_calib.c:209:17: style: Variable 'dit_ref' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_calib.c:210:21: style: Variable 'exptime_ref' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_calib.c:382:13: style: Variable 'dit' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/fors_photometry_impl.cc:398:5: error: Invalid sqrt() argument nr 1. The value is -1 but the valid values are '0.0:'. [invalidFunctionArg] fors-5.5.7/fors/fors_photometry_impl.cc:399:5: error: Invalid sqrt() argument nr 1. The value is -1 but the valid values are '0.0:'. [invalidFunctionArg] fors-5.5.7/fors/fors_photometry_impl.cc:412:5: error: Invalid sqrt() argument nr 1. The value is -1 but the valid values are '0.0:'. [invalidFunctionArg] fors-5.5.7/fors/fors_photometry_impl.cc:413:5: error: Invalid sqrt() argument nr 1. The value is -1 but the valid values are '0.0:'. [invalidFunctionArg] fors-5.5.7/fors/fors_photometry_impl.cc:2722:18: style: The if condition is the same as the previous if condition [duplicateCondition] fors-5.5.7/fors/fors_photometry_impl.cc:2704:18: note: First condition fors-5.5.7/fors/fors_photometry_impl.cc:2722:18: note: Second condition fors-5.5.7/irplib/irplib_flat.c:365:21: style: Parameter 'y' can be declared as pointer to const [constParameter] fors-5.5.7/fors/list.h:73:25: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:74:24: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:85:15: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:96:24: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:106:15: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:116:16: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:126:23: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:137:33: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:148:32: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:159:45: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:170:47: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:182:21: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:195:20: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:208:21: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:220:20: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:231:48: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:241:36: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:255:34: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:256:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:257:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:271:45: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:272:27: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:285:33: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:286:21: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:299:33: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:300:21: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:314:37: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:315:4: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:329:37: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:330:4: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:344:43: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:345:4: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:358:33: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:359:7: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:373:37: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:374:4: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:389:50: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:390:10: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:406:22: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:407:8: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:422:30: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:423:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:424:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:439:25: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:440:10: style: C-style pointer casting [cstyleCast] fors-5.5.7/irplib/irplib_ksigma_clip.c:239:5: error: There is an unknown macro here somewhere. Configuration is required. If CPL_STRINGIFY is a macro then please configure it. [unknownMacro] fors-5.5.7/fors/list.h:454:21: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/list.h:455:7: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:310:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:699:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:711:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:728:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:740:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:753:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:766:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:780:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:792:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:809:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:811:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:1214:19: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:1365:21: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:1907:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:1913:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:1919:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:1974:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:1995:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2032:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2098:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2104:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2108:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2115:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2121:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2124:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2157:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2165:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2175:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2184:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2209:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2237:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2294:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2302:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2309:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2326:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2354:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2368:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2447:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2486:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2492:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2498:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2504:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2510:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2513:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2520:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2523:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2524:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2542:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2552:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2555:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2559:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2647:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2671:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2686:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2696:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2718:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2729:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:2733:5: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:3141:45: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:3407:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:3682:20: style: C-style pointer casting [cstyleCast] fors-5.5.7/fors/fors_photometry_impl.cc:430:12: style: The scope of the variable 'e' can be reduced. [variableScope] fors-5.5.7/fors/fors_photometry_impl.cc:1071:26: style: The scope of the variable 'prop' can be reduced. [variableScope] fors-5.5.7/fors/fors_photometry_impl.cc:1893:26: style: The scope of the variable 'row' can be reduced. [variableScope] fors-5.5.7/fors/fors_photometry_impl.cc:2783:26: style: The scope of the variable 'f' can be reduced. [variableScope] fors-5.5.7/fors/fors_photometry_impl.cc:4090:16: style:inconclusive: Function 'add_qc_parameters_per_night' argument 2 names different: declaration 'qc_zeropoint' definition 'zeropoint'. [funcArgNamesDifferent] fors-5.5.7/fors/fors_photometry_impl.cc:285:16: note: Function 'add_qc_parameters_per_night' argument 2 names different: declaration 'qc_zeropoint' definition 'zeropoint'. fors-5.5.7/fors/fors_photometry_impl.cc:4090:16: note: Function 'add_qc_parameters_per_night' argument 2 names different: declaration 'qc_zeropoint' definition 'zeropoint'. fors-5.5.7/fors/fors_photometry_impl.cc:3186:66: style: Parameter 'obsl' can be declared as pointer to const [constParameter] fors-5.5.7/irplib/irplib_plugin.c:1052:26: error: There is an unknown macro here somewhere. Configuration is required. If CPL_STRINGIFY is a macro then please configure it. [unknownMacro] fors-5.5.7/fors/fors_photometry_impl.cc:2292:16: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/fors_photometry_impl.cc:2467:14: style: Variable 'i' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_mkmaster.c:383:16: style: Parameter 'qclog' can be declared as pointer to const [constParameter] fors-5.5.7/irplib/irplib_mkmaster.c:76:12: style: Variable 'size' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_mkmaster.c:77:9: style: Variable 'i' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_mkmaster.c:80:15: style: Variable 'mean' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_mkmaster.c:81:16: style: Variable 'stdev' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_mkmaster.c:243:26: style: Variable 'mean_of_medians' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_framelist.c:928:13: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] fors-5.5.7/irplib/irplib_framelist.c:941:13: note: Found duplicate branches for 'if' and 'else'. fors-5.5.7/irplib/irplib_framelist.c:928:13: note: Found duplicate branches for 'if' and 'else'. fors-5.5.7/irplib/irplib_framelist.c:454:5: style: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] fors-5.5.7/irplib/irplib_framelist.c:530:5: style: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] fors-5.5.7/irplib/irplib_polynomial.c:542:17: style: Variable 'resx' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_polynomial.c:572:20: style: Variable 'resx' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_polynomial.c:621:22: style: Variable 'is_first' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_polynomial.c:641:22: style: Variable 'is_first' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_spectrum.c:497:7: style: Variable 'j' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_stdstar.c:736:44: style: Expression 'exp(x) - 1' can be replaced by 'expm1(x)' to avoid loss of precision. [unpreciseMathCall] fors-5.5.7/irplib/irplib_utils.c:1427:33: style:inconclusive: Function 'irplib_polynomial_fit_1d_create_chiq' argument 4 names different: declaration 'rechiq' definition 'rechisq'. [funcArgNamesDifferent] fors-5.5.7/irplib/irplib_utils.h:530:33: note: Function 'irplib_polynomial_fit_1d_create_chiq' argument 4 names different: declaration 'rechiq' definition 'rechisq'. fors-5.5.7/irplib/irplib_utils.c:1427:33: note: Function 'irplib_polynomial_fit_1d_create_chiq' argument 4 names different: declaration 'rechiq' definition 'rechisq'. fors-5.5.7/irplib/irplib_utils.c:1482:28: style:inconclusive: Function 'quicksort' argument 1 names different: declaration 'index' definition 'iindex'. [funcArgNamesDifferent] fors-5.5.7/irplib/irplib_utils.c:72:28: note: Function 'quicksort' argument 1 names different: declaration 'index' definition 'iindex'. fors-5.5.7/irplib/irplib_utils.c:1482:28: note: Function 'quicksort' argument 1 names different: declaration 'index' definition 'iindex'. fors-5.5.7/irplib/irplib_wlxcorr.c:1189:24: style: Array index 'itt' is used before limits check. [arrayIndexThenCheck] fors-5.5.7/irplib/tests/irplib_plugin-test.c:166:73: style: Parameter 'self' can be declared as pointer to const [constParameter] fors-5.5.7/irplib/irplib_wlxcorr.c:871:11: style: Variable 'start' is reassigned a value before the old one has been used. [redundantAssignment] fors-5.5.7/irplib/irplib_wlxcorr.c:866:16: note: start is assigned fors-5.5.7/irplib/irplib_wlxcorr.c:871:11: note: start is overwritten fors-5.5.7/irplib/irplib_wlxcorr.c:874:10: style: Variable 'stop' is reassigned a value before the old one has been used. [redundantAssignment] fors-5.5.7/irplib/irplib_wlxcorr.c:867:42: note: stop is assigned fors-5.5.7/irplib/irplib_wlxcorr.c:874:10: note: stop is overwritten fors-5.5.7/irplib/irplib_wlxcorr.c:874:10: style: Variable 'stop' is reassigned a value before the old one has been used. [redundantAssignment] fors-5.5.7/irplib/irplib_wlxcorr.c:868:15: note: stop is assigned fors-5.5.7/irplib/irplib_wlxcorr.c:874:10: note: stop is overwritten fors-5.5.7/irplib/tests/irplib_strehl-test.c:182:18: error: There is an unknown macro here somewhere. Configuration is required. If CPL_STRINGIFY is a macro then please configure it. [unknownMacro] fors-5.5.7/irplib/irplib_wavecal.c:1326:41: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] fors-5.5.7/irplib/irplib_wavecal.c:281:74: style: Parameter 'model' can be declared as pointer to const [constParameter] fors-5.5.7/irplib/irplib_wavecal.c:282:63: style: Parameter 'filler' can be declared as pointer to const [constParameter] fors-5.5.7/irplib/irplib_wavecal.c:290:54: style: Parameter 'pxc' can be declared as pointer to const [constParameter] fors-5.5.7/irplib/irplib_wavecal.c:1490:76: style: Parameter 'model' can be declared as pointer to const [constParameter] fors-5.5.7/irplib/irplib_wavecal.c:1491:66: style: Parameter 'filler' can be declared as pointer to const [constParameter] fors-5.5.7/irplib/irplib_wavecal.c:1502:57: style: Parameter 'pxc' can be declared as pointer to const [constParameter] fors-5.5.7/irplib/irplib_sdp_spectrum.c:2835:65: style:inconclusive: Function 'irplib_sdp_spectrum_save' argument 4 names different: declaration 'extra_header' definition 'extra_theader'. [funcArgNamesDifferent] fors-5.5.7/irplib/irplib_sdp_spectrum.h:734:65: note: Function 'irplib_sdp_spectrum_save' argument 4 names different: declaration 'extra_header' definition 'extra_theader'. fors-5.5.7/irplib/irplib_sdp_spectrum.c:2835:65: note: Function 'irplib_sdp_spectrum_save' argument 4 names different: declaration 'extra_header' definition 'extra_theader'. fors-5.5.7/irplib/tests/irplib_polynomial-test.c:214:19: style: Condition 'nreal!=3' is always false [knownConditionTrueFalse] fors-5.5.7/irplib/tests/irplib_polynomial-test.c:170:19: note: Assuming that condition 'nreal<3' is not redundant fors-5.5.7/irplib/tests/irplib_polynomial-test.c:192:19: note: Assuming condition is false fors-5.5.7/irplib/tests/irplib_polynomial-test.c:214:19: note: Condition 'nreal!=3' is always false fors-5.5.7/irplib/tests/irplib_utils-test.c:188:50: style: Parameter 'self' can be declared as pointer to const [constParameter] fors-5.5.7/irplib/irplib_sdp_spectrum.c:763:12: style: Variable 'size' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_sdp_spectrum.c:768:12: style: Variable 'size' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_sdp_spectrum.c:773:12: style: Variable 'size' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_apline.c:59:28: style: Parameter 'smoothedc' can be declared as const array [constParameter] fors-5.5.7/irplib/irplib_sdp_spectrum.c:778:12: style: Variable 'size' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_apline.c:58:50: style: Parameter 'conf' can be declared as const array [constParameter] fors-5.5.7/irplib/irplib_sdp_spectrum.c:845:31: style: Variable 'nrows' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_apline.c:58:36: style: Parameter 'dat' can be declared as const array [constParameter] fors-5.5.7/irplib/irplib_sdp_spectrum.c:943:12: style: Variable 'size' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_apline.c:59:68: style: Parameter 'bpm' can be declared as pointer to const [constParameter] fors-5.5.7/irplib/irplib_sdp_spectrum.c:948:12: style: Variable 'size' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_sdp_spectrum.c:953:12: style: Variable 'size' is assigned a value that is never used. [unreadVariable] fors-5.5.7/irplib/irplib_sdp_spectrum.c:958:12: style: Variable 'size' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:493:32: style: Parameter 'core1' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:493:47: style: Parameter 'core2' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:493:62: style: Parameter 'core3' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:588:29: style: Parameter 'core' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:588:43: style: Parameter 'pkht' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:936:47: style: Parameter 'core2' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:936:32: style: Parameter 'core1' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:1259:37: style: Parameter 'mag1' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:1259:51: style: Parameter 'mag2' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_polynm.c:55:10: style: Parameter 'xdat' can be declared as const array [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_phopt.c:61:10: style: Parameter 'apertures' can be declared as const array [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_seeing.c:58:37: style: Parameter 'ellipt' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:54:47: style: Parameter 'cflux' can be declared as const array [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:54:30: style: Parameter 'rcores' can be declared as const array [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:132:60: style: Parameter 'cflux' can be declared as const array [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:169:59: style: Parameter 'cflux' can be declared as const array [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:226:55: style: Parameter 'rcores' can be declared as const array [constParameter] fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:226:72: style: Parameter 'rfluxes' can be declared as const array [constParameter] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_areals-test.c:33:14: style: Variable 'x' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_areals-test.c:42:14: style: Variable 'y' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_areals-test.c:51:14: style: Variable 'z' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_moments-test.c:35:14: style: Variable 'x' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_moments-test.c:44:14: style: Variable 'y' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_moments-test.c:53:13: style: Variable 'z' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_terminate-test.c:95:21: style: Variable 'ap.areal_offset' is reassigned a value before the old one has been used. [redundantAssignment] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_terminate-test.c:82:21: note: ap.areal_offset is assigned fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_terminate-test.c:95:21: note: ap.areal_offset is overwritten fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_radii-test.c:39:11: style: Variable 'x' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_terminate-test.c:35:14: style: Variable 'x' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_radii-test.c:48:11: style: Variable 'y' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_terminate-test.c:44:14: style: Variable 'y' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_radii-test.c:57:13: style: Variable 'z' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_terminate-test.c:53:13: style: Variable 'z' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/hdrl_parameter_defs.h:24:0: error: #error This file is not allowed to be included outside of hdrl [preprocessorErrorDirective] fors-5.5.7/mosca/hdrl/hdrl_elemop.h:31:0: error: #error This file is not allowed to be included outside of hdrl [preprocessorErrorDirective] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_overlp-test.c:151:11: style: Variable 'x' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_overlp-test.c:160:11: style: Variable 'y' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_overlp-test.c:169:13: style: Variable 'z' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/hdrl_imagelist_defs.h:24:0: error: #error This file is not allowed to be included outside of hdrl [preprocessorErrorDirective] fors-5.5.7/mosca/hdrl/hdrl_dar.c:103:21: style: Variable 'parang' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_dar.c:104:21: style: Variable 'posang' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_overscan_defs.h:24:0: error: #error This file is not allowed to be included outside of hdrl [preprocessorErrorDirective] fors-5.5.7/mosca/hdrl/hdrl_dar.c:105:21: style: Variable 'temp' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_dar.c:106:21: style: Variable 'rhum' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_dar.c:107:21: style: Variable 'pres' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_bpm_3d.c:131:45: style: Variable 'param_loc' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_conf-test.c:67:8: style: Variable 'dy' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_random.c:66:14: style: struct member 'hdrl_random_state_::state' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_buffer.c:67:15: style: struct member '_hdrl_buffer_::pools' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_random.c:67:14: style: struct member 'hdrl_random_state_::inc' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_buffer.c:68:15: style: struct member '_hdrl_buffer_::freelist' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_random.c:68:14: style: struct member 'hdrl_random_state_::has_normal' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_buffer.c:69:12: style: struct member '_hdrl_buffer_::pool_size' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_random.c:69:12: style: struct member 'hdrl_random_state_::normal' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_buffer.c:70:12: style: struct member '_hdrl_buffer_::total_size' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_buffer.c:71:12: style: struct member '_hdrl_buffer_::malloc_thresh' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_multiiter.c:51:26: style: struct member 'hdrl_multiiter_state::frames' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_buffer.c:87:20: style: struct member 'hdrl_pool_malloc::p' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_iter.c:51:24: style: struct member '_hdrl_iter_::next' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_iter.c:53:25: style: struct member '_hdrl_iter_::reset' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_iter.c:55:26: style: struct member '_hdrl_iter_::length' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_iter.c:57:17: style: struct member '_hdrl_iter_::destructor' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_iter.c:61:12: style: struct member '_hdrl_iter_::state' is never used. [unusedStructMember] fors-5.5.7/mosca/hdrl/hdrl_frameiter.c:113:31: style: Parameter 'axes' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/hdrl_frameiter.c:114:31: style: Parameter 'dims' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/hdrl_flat.c:130:43: style: Variable 'param_loc' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_flat.c:415:14: style: Variable 'lowf' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_lacosmics.c:135:47: style: Variable 'param_loc' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_sigclip.c:587:40: style: Parameter 'vec' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/hdrl_sigclip.c:627:40: style: Parameter 'vec' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/hdrl_fringe.c:214:22: style: Variable 'bkg_level' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_fringe.c:215:25: style: Variable 'fringe_level' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_fringe.c:394:22: style: Variable 'bkg_level' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_sigclip.c:398:14: style: Variable 'nlow_int' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_fringe.c:395:25: style: Variable 'fringe_level' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_sigclip.c:399:15: style: Variable 'nhigh_int' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_sigclip.c:761:24: style: Variable 'lower_bound' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_sigclip.c:762:24: style: Variable 'upper_bound' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_bpm_2d.c:235:45: style: Variable 'param_loc' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_prototyping.c:241:11: style: The statement 'if (errno!=0) errno=0' is logically equivalent to 'errno=0'. [duplicateConditionalAssign] fors-5.5.7/mosca/hdrl/hdrl_prototyping.c:242:9: note: Assignment 'errno=0' fors-5.5.7/mosca/hdrl/hdrl_prototyping.c:241:11: note: Condition 'errno!=0' is redundant fors-5.5.7/mosca/hdrl/hdrl_prototyping.c:181:10: style: Variable 'x' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_prototyping.c:182:17: style: Variable 'gaussval' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_spectrum_resample.c:958:25: style: Variable 'start_source' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_spectrum_resample.c:959:24: style: Variable 'stop_source' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_strehl.c:1092:14: style: Same expression used in consecutive assignments of 'nnx' and 'nny'. [duplicateAssignExpression] fors-5.5.7/mosca/hdrl/hdrl_strehl.c:1093:14: note: Same expression used in consecutive assignments of 'nnx' and 'nny'. fors-5.5.7/mosca/hdrl/hdrl_strehl.c:1092:14: note: Same expression used in consecutive assignments of 'nnx' and 'nny'. fors-5.5.7/mosca/hdrl/hdrl_strehl.c:1162:12: error: Uninitialized variables: r.star_x, r.star_y, r.computed_background_error, r.nbackground_pixels [uninitvar] fors-5.5.7/mosca/hdrl/hdrl_resample.c:735:40: style:inconclusive: Function 'hdrl_resample_compute' argument 1 names different: declaration 'restable' definition 'ResTable'. [funcArgNamesDifferent] fors-5.5.7/mosca/hdrl/hdrl_resample.h:88:40: note: Function 'hdrl_resample_compute' argument 1 names different: declaration 'restable' definition 'ResTable'. fors-5.5.7/mosca/hdrl/hdrl_resample.c:735:40: note: Function 'hdrl_resample_compute' argument 1 names different: declaration 'restable' definition 'ResTable'. fors-5.5.7/mosca/hdrl/hdrl_resample.c:849:51: style:inconclusive: Function 'hdrl_resample_result_delete' argument 1 names different: declaration 'resdata' definition 'aCube'. [funcArgNamesDifferent] fors-5.5.7/mosca/hdrl/hdrl_resample.h:94:51: note: Function 'hdrl_resample_result_delete' argument 1 names different: declaration 'resdata' definition 'aCube'. fors-5.5.7/mosca/hdrl/hdrl_resample.c:849:51: note: Function 'hdrl_resample_result_delete' argument 1 names different: declaration 'resdata' definition 'aCube'. fors-5.5.7/mosca/hdrl/hdrl_resample.c:3459:61: style:inconclusive: Function 'hdrl_resample_parameter_method_check' argument 1 names different: declaration 'hp' definition 'self'. [funcArgNamesDifferent] fors-5.5.7/mosca/hdrl/hdrl_resample.h:172:61: note: Function 'hdrl_resample_parameter_method_check' argument 1 names different: declaration 'hp' definition 'self'. fors-5.5.7/mosca/hdrl/hdrl_resample.c:3459:61: note: Function 'hdrl_resample_parameter_method_check' argument 1 names different: declaration 'hp' definition 'self'. fors-5.5.7/mosca/hdrl/hdrl_resample.c:1660:12: style: Variable 'dx' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_resample.c:3271:53: style: Variable 'param_loc' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/hdrl_resample.c:3360:52: style: Variable 'param_loc' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/hdrl/tests/hdrl_overscan-test.c:943:14: style: Variable 'any' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/tests/hdrl_strehl-test.c:62:12: style:inconclusive: Same expression used in consecutive assignments of 'psx' and 'psy'. [duplicateAssignExpression] fors-5.5.7/mosca/hdrl/tests/hdrl_strehl-test.c:63:12: note: Same expression used in consecutive assignments of 'psx' and 'psy'. fors-5.5.7/mosca/hdrl/tests/hdrl_strehl-test.c:62:12: note: Same expression used in consecutive assignments of 'psx' and 'psy'. fors-5.5.7/mosca/hdrl/tests/hdrl_strehl-test.c:197:12: style:inconclusive: Same expression used in consecutive assignments of 'psx' and 'psy'. [duplicateAssignExpression] fors-5.5.7/mosca/hdrl/tests/hdrl_strehl-test.c:198:12: note: Same expression used in consecutive assignments of 'psx' and 'psy'. fors-5.5.7/mosca/hdrl/tests/hdrl_strehl-test.c:197:12: note: Same expression used in consecutive assignments of 'psx' and 'psy'. fors-5.5.7/mosca/hdrl/tests/hdrl_strehl-test.c:241:12: style:inconclusive: Same expression used in consecutive assignments of 'psx' and 'psy'. [duplicateAssignExpression] fors-5.5.7/mosca/hdrl/tests/hdrl_strehl-test.c:242:12: note: Same expression used in consecutive assignments of 'psx' and 'psy'. fors-5.5.7/mosca/hdrl/tests/hdrl_strehl-test.c:241:12: note: Same expression used in consecutive assignments of 'psx' and 'psy'. fors-5.5.7/mosca/libmosca/mosca_image.h:56:5: style: Class 'image' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fors-5.5.7/mosca/libmosca/ccd_config.cpp:43:13: warning:inconclusive: Member variable 'ccd_config::m_pixel_size' is not initialized in the constructor. [uninitMemberVar] fors-5.5.7/mosca/libmosca/ccd_config.cpp:43:13: warning:inconclusive: Member variable 'ccd_config::m_binning_factor_x' is not initialized in the constructor. [uninitMemberVar] fors-5.5.7/mosca/libmosca/ccd_config.cpp:43:13: warning:inconclusive: Member variable 'ccd_config::m_binning_factor_y' is not initialized in the constructor. [uninitMemberVar] fors-5.5.7/mosca/libmosca/ccd_config.cpp:35:31: style:inconclusive: Function 'ccd_config' argument 2 names different: declaration 'pixel_size' definition 'pix_size'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/ccd_config.h:59:23: note: Function 'ccd_config' argument 2 names different: declaration 'pixel_size' definition 'pix_size'. fors-5.5.7/mosca/libmosca/ccd_config.cpp:35:31: note: Function 'ccd_config' argument 2 names different: declaration 'pixel_size' definition 'pix_size'. fors-5.5.7/mosca/libmosca/ccd_config.cpp:36:31: style:inconclusive: Function 'ccd_config' argument 3 names different: declaration 'binning_factor_x' definition 'bin_factor_x'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/ccd_config.h:60:23: note: Function 'ccd_config' argument 3 names different: declaration 'binning_factor_x' definition 'bin_factor_x'. fors-5.5.7/mosca/libmosca/ccd_config.cpp:36:31: note: Function 'ccd_config' argument 3 names different: declaration 'binning_factor_x' definition 'bin_factor_x'. fors-5.5.7/mosca/libmosca/ccd_config.cpp:37:31: style:inconclusive: Function 'ccd_config' argument 4 names different: declaration 'binning_factor_y' definition 'bin_factor_y'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/ccd_config.h:61:23: note: Function 'ccd_config' argument 4 names different: declaration 'binning_factor_y' definition 'bin_factor_y'. fors-5.5.7/mosca/libmosca/ccd_config.cpp:37:31: note: Function 'ccd_config' argument 4 names different: declaration 'binning_factor_y' definition 'bin_factor_y'. fors-5.5.7/mosca/libmosca/extinction.cpp:81:12: error:inconclusive: Returning object that points to local variable 'flux' that will be invalid when returning. [returnDanglingLifetime] fors-5.5.7/mosca/libmosca/extinction.cpp:79:36: note: Passed to constructor of 'spectrum'. fors-5.5.7/mosca/libmosca/extinction.cpp:67:25: note: Variable created here. fors-5.5.7/mosca/libmosca/extinction.cpp:81:12: note: Returning object that points to local variable 'flux' that will be invalid when returning. fors-5.5.7/mosca/libmosca/extinction.cpp:81:12: error:inconclusive: Returning object that points to local variable 'wave' that will be invalid when returning. [returnDanglingLifetime] fors-5.5.7/mosca/libmosca/extinction.cpp:79:42: note: Passed to constructor of 'spectrum'. fors-5.5.7/mosca/libmosca/extinction.cpp:68:25: note: Variable created here. fors-5.5.7/mosca/libmosca/extinction.cpp:81:12: note: Returning object that points to local variable 'wave' that will be invalid when returning. fors-5.5.7/mosca/libmosca/detected_slit.cpp:76:23: warning:inconclusive: Member variable 'detected_slit::m_trace_bottom_pol_coeffs' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] fors-5.5.7/mosca/libmosca/detected_slit.cpp:76:23: warning:inconclusive: Member variable 'detected_slit::m_trace_top_pol_coeffs' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] fors-5.5.7/mosca/libmosca/detected_slit.h:75:10: style:inconclusive: Technically the member function 'mosca::detected_slit::get_extent' can be const. [functionConst] fors-5.5.7/mosca/libmosca/detected_slit.cpp:98:28: note: Technically the member function 'mosca::detected_slit::get_extent' can be const. fors-5.5.7/mosca/libmosca/detected_slit.h:75:10: note: Technically the member function 'mosca::detected_slit::get_extent' can be const. fors-5.5.7/mosca/libmosca/grism_config.cpp:34:35: style:inconclusive: Function 'grism_config' argument 1 names different: declaration 'nominal_dispersion' definition 'nominal_disp'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/grism_config.h:30:25: note: Function 'grism_config' argument 1 names different: declaration 'nominal_dispersion' definition 'nominal_disp'. fors-5.5.7/mosca/libmosca/grism_config.cpp:34:35: note: Function 'grism_config' argument 1 names different: declaration 'nominal_dispersion' definition 'nominal_disp'. fors-5.5.7/mosca/libmosca/detected_slit.cpp:33:41: style:inconclusive: Function 'detected_slit' argument 1 names different: declaration 'slit_id' definition 'slit_ident'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/detected_slit.h:62:23: note: Function 'detected_slit' argument 1 names different: declaration 'slit_id' definition 'slit_ident'. fors-5.5.7/mosca/libmosca/detected_slit.cpp:33:41: note: Function 'detected_slit' argument 1 names different: declaration 'slit_id' definition 'slit_ident'. fors-5.5.7/mosca/libmosca/grism_config.cpp:35:35: style:inconclusive: Function 'grism_config' argument 2 names different: declaration 'start_wave' definition 'start_wavelength'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/grism_config.h:31:25: note: Function 'grism_config' argument 2 names different: declaration 'start_wave' definition 'start_wavelength'. fors-5.5.7/mosca/libmosca/grism_config.cpp:35:35: note: Function 'grism_config' argument 2 names different: declaration 'start_wave' definition 'start_wavelength'. fors-5.5.7/mosca/libmosca/grism_config.cpp:36:35: style:inconclusive: Function 'grism_config' argument 3 names different: declaration 'end_wave' definition 'end_wavelength'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/grism_config.h:32:25: note: Function 'grism_config' argument 3 names different: declaration 'end_wave' definition 'end_wavelength'. fors-5.5.7/mosca/libmosca/grism_config.cpp:36:35: note: Function 'grism_config' argument 3 names different: declaration 'end_wave' definition 'end_wavelength'. fors-5.5.7/mosca/libmosca/detected_slits.cpp:58:21: style: Redundant initialization for 'disp_bottom'. The initialized value is overwritten before it is read. [redundantInitialization] fors-5.5.7/mosca/libmosca/detected_slits.cpp:56:28: note: disp_bottom is initialized fors-5.5.7/mosca/libmosca/detected_slits.cpp:58:21: note: disp_bottom is overwritten fors-5.5.7/mosca/libmosca/extinction.h:39:5: style: Class 'extinction' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fors-5.5.7/mosca/libmosca/grism_config.cpp:37:35: style:inconclusive: Function 'grism_config' argument 4 names different: declaration 'wave_ref' definition 'wavelength_ref'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/grism_config.h:33:25: note: Function 'grism_config' argument 4 names different: declaration 'wave_ref' definition 'wavelength_ref'. fors-5.5.7/mosca/libmosca/grism_config.cpp:37:35: note: Function 'grism_config' argument 4 names different: declaration 'wave_ref' definition 'wavelength_ref'. fors-5.5.7/mosca/libmosca/detected_slits.cpp:61:18: style: Redundant initialization for 'disp_top'. The initialized value is overwritten before it is read. [redundantInitialization] fors-5.5.7/mosca/libmosca/detected_slits.cpp:59:28: note: disp_top is initialized fors-5.5.7/mosca/libmosca/detected_slits.cpp:61:18: note: disp_top is overwritten fors-5.5.7/mosca/libmosca/reduce_method.h:48:27: performance:inconclusive: Technically the member function 'mosca::reduce_mean::hdrl_reduce' can be static (but you may consider moving to unnamed namespace). [functionStatic] fors-5.5.7/mosca/libmosca/reduce_method.cpp:35:38: note: Technically the member function 'mosca::reduce_mean::hdrl_reduce' can be static (but you may consider moving to unnamed namespace). fors-5.5.7/mosca/libmosca/reduce_method.h:48:27: note: Technically the member function 'mosca::reduce_mean::hdrl_reduce' can be static (but you may consider moving to unnamed namespace). fors-5.5.7/mosca/libmosca/reduce_method.h:63:27: performance:inconclusive: Technically the member function 'mosca::reduce_median::hdrl_reduce' can be static (but you may consider moving to unnamed namespace). [functionStatic] fors-5.5.7/mosca/libmosca/reduce_method.cpp:44:41: note: Technically the member function 'mosca::reduce_median::hdrl_reduce' can be static (but you may consider moving to unnamed namespace). fors-5.5.7/mosca/libmosca/reduce_method.h:63:27: note: Technically the member function 'mosca::reduce_median::hdrl_reduce' can be static (but you may consider moving to unnamed namespace). fors-5.5.7/mosca/libmosca/reduce_method.h:100:27: performance:inconclusive: Technically the member function 'mosca::reduce_weighted_mean::hdrl_reduce' can be static (but you may consider moving to unnamed namespace). [functionStatic] fors-5.5.7/mosca/libmosca/reduce_method.cpp:53:48: note: Technically the member function 'mosca::reduce_weighted_mean::hdrl_reduce' can be static (but you may consider moving to unnamed namespace). fors-5.5.7/mosca/libmosca/reduce_method.h:100:27: note: Technically the member function 'mosca::reduce_weighted_mean::hdrl_reduce' can be static (but you may consider moving to unnamed namespace). fors-5.5.7/mosca/libmosca/spec_std_star.h:38:5: style: Class 'spec_std_star' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fors-5.5.7/mosca/libmosca/response.cpp:42:66: style: Parameter 'std_star' can be declared as reference to const [constParameter] fors-5.5.7/mosca/libmosca/slit_trace_distortion.h:33:5: style: Class 'slit_trace_distortion' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fors-5.5.7/mosca/libmosca/slit_trace_distortion.h:41:17: style: The function 'calibrate_spatial' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] fors-5.5.7/mosca/libmosca/spatial_distortion.h:37:25: note: Virtual function in base class fors-5.5.7/mosca/libmosca/slit_trace_distortion.h:41:17: note: Function in derived class fors-5.5.7/mosca/libmosca/slit_trace_distortion.h:46:10: style: The function 'to_distorted' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] fors-5.5.7/mosca/libmosca/spatial_distortion.h:43:18: note: Virtual function in base class fors-5.5.7/mosca/libmosca/slit_trace_distortion.h:46:10: note: Function in derived class fors-5.5.7/mosca/libmosca/slit_trace_distortion.h:51:10: style: The function 'to_undistorted' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] fors-5.5.7/mosca/libmosca/spatial_distortion.h:48:18: note: Virtual function in base class fors-5.5.7/mosca/libmosca/slit_trace_distortion.h:51:10: note: Function in derived class fors-5.5.7/mosca/libmosca/statistics.cpp:56:12: style: Local variable 'mean' shadows outer function [shadowFunction] fors-5.5.7/mosca/libmosca/statistics.h:27:8: note: Shadowed declaration fors-5.5.7/mosca/libmosca/statistics.cpp:56:12: note: Shadow variable fors-5.5.7/mosca/libmosca/statistics.cpp:75:12: style: Local variable 'variance' shadows outer function [shadowFunction] fors-5.5.7/mosca/libmosca/statistics.h:30:8: note: Shadowed declaration fors-5.5.7/mosca/libmosca/statistics.cpp:75:12: note: Shadow variable fors-5.5.7/mosca/libmosca/global_distortion.h:32:5: style: Class 'global_distortion' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fors-5.5.7/mosca/libmosca/global_distortion.h:40:17: style: The function 'calibrate_spatial' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] fors-5.5.7/mosca/libmosca/spatial_distortion.h:37:25: note: Virtual function in base class fors-5.5.7/mosca/libmosca/global_distortion.h:40:17: note: Function in derived class fors-5.5.7/mosca/libmosca/mosca_image.cpp:34:33: style:inconclusive: Function 'image' argument 4 names different: declaration 'dispersion_axis' definition 'disp_axis'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/mosca_image.h:54:16: note: Function 'image' argument 4 names different: declaration 'dispersion_axis' definition 'disp_axis'. fors-5.5.7/mosca/libmosca/mosca_image.cpp:34:33: note: Function 'image' argument 4 names different: declaration 'dispersion_axis' definition 'disp_axis'. fors-5.5.7/mosca/libmosca/spectrum.cpp:57:18: warning:inconclusive: Member variable 'spectrum::m_flux_nonzero' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] fors-5.5.7/mosca/libmosca/global_distortion.h:45:10: style: The function 'to_distorted' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] fors-5.5.7/mosca/libmosca/spatial_distortion.h:43:18: note: Virtual function in base class fors-5.5.7/mosca/libmosca/global_distortion.h:45:10: note: Function in derived class fors-5.5.7/mosca/libmosca/mosca_image.cpp:52:33: style:inconclusive: Function 'image' argument 1 names different: declaration 'image' definition 'ima'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/mosca_image.h:56:23: note: Function 'image' argument 1 names different: declaration 'image' definition 'ima'. fors-5.5.7/mosca/libmosca/mosca_image.cpp:52:33: note: Function 'image' argument 1 names different: declaration 'image' definition 'ima'. fors-5.5.7/mosca/libmosca/spectrum.cpp:57:18: warning:inconclusive: Member variable 'spectrum::m_wave_nonzero' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] fors-5.5.7/mosca/libmosca/global_distortion.h:50:10: style: The function 'to_undistorted' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] fors-5.5.7/mosca/libmosca/spatial_distortion.h:48:18: note: Virtual function in base class fors-5.5.7/mosca/libmosca/global_distortion.h:50:10: note: Function in derived class fors-5.5.7/mosca/libmosca/mosca_image.cpp:53:33: style:inconclusive: Function 'image' argument 3 names different: declaration 'dispersion_axis' definition 'disp_axis'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/mosca_image.h:57:16: note: Function 'image' argument 3 names different: declaration 'dispersion_axis' definition 'disp_axis'. fors-5.5.7/mosca/libmosca/mosca_image.cpp:53:33: note: Function 'image' argument 3 names different: declaration 'dispersion_axis' definition 'disp_axis'. fors-5.5.7/mosca/libmosca/mosca_image.cpp:62:33: style:inconclusive: Function 'image' argument 1 names different: declaration 'image' definition 'ima'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/mosca_image.h:59:23: note: Function 'image' argument 1 names different: declaration 'image' definition 'ima'. fors-5.5.7/mosca/libmosca/mosca_image.cpp:62:33: note: Function 'image' argument 1 names different: declaration 'image' definition 'ima'. fors-5.5.7/mosca/libmosca/global_distortion.cpp:152:21: style: The scope of the variable 'found' can be reduced. [variableScope] fors-5.5.7/mosca/libmosca/mosca_image.cpp:62:50: style:inconclusive: Function 'image' argument 2 names different: declaration 'image_err' definition 'ima_err'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/mosca_image.h:59:42: note: Function 'image' argument 2 names different: declaration 'image_err' definition 'ima_err'. fors-5.5.7/mosca/libmosca/mosca_image.cpp:62:50: note: Function 'image' argument 2 names different: declaration 'image_err' definition 'ima_err'. fors-5.5.7/mosca/libmosca/spectrum.cpp:49:48: style:inconclusive: Function 'spectrum' argument 1 names different: declaration 'flux' definition 'flux_vec'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/spectrum.h:44:35: note: Function 'spectrum' argument 1 names different: declaration 'flux' definition 'flux_vec'. fors-5.5.7/mosca/libmosca/spectrum.cpp:49:48: note: Function 'spectrum' argument 1 names different: declaration 'flux' definition 'flux_vec'. fors-5.5.7/mosca/libmosca/global_distortion.cpp:225:12: style: Variable 'nslits' is assigned a value that is never used. [unreadVariable] fors-5.5.7/mosca/libmosca/mosca_image.cpp:63:49: style:inconclusive: Function 'image' argument 4 names different: declaration 'dispersion_axis' definition 'disp_axis'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/mosca_image.h:60:16: note: Function 'image' argument 4 names different: declaration 'dispersion_axis' definition 'disp_axis'. fors-5.5.7/mosca/libmosca/mosca_image.cpp:63:49: note: Function 'image' argument 4 names different: declaration 'dispersion_axis' definition 'disp_axis'. fors-5.5.7/mosca/libmosca/spectrum.cpp:50:48: style:inconclusive: Function 'spectrum' argument 2 names different: declaration 'wave' definition 'wave_vec'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/spectrum.h:44:62: note: Function 'spectrum' argument 2 names different: declaration 'wave' definition 'wave_vec'. fors-5.5.7/mosca/libmosca/spectrum.cpp:50:48: note: Function 'spectrum' argument 2 names different: declaration 'wave' definition 'wave_vec'. fors-5.5.7/mosca/libmosca/fiera_config.h:41:5: style: Class 'fiera_config' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fors-5.5.7/mosca/libmosca/mosca_image.cpp:76:34: style:inconclusive: Function 'image' argument 1 names different: declaration 'other' definition 'rhs'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/mosca_image.h:64:24: note: Function 'image' argument 1 names different: declaration 'other' definition 'rhs'. fors-5.5.7/mosca/libmosca/mosca_image.cpp:76:34: note: Function 'image' argument 1 names different: declaration 'other' definition 'rhs'. fors-5.5.7/mosca/libmosca/mosca_image.cpp:98:41: style:inconclusive: Function 'set_axis' argument 1 names different: declaration 'dispersion_axis' definition 'disp_axis'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/mosca_image.h:121:24: note: Function 'set_axis' argument 1 names different: declaration 'dispersion_axis' definition 'disp_axis'. fors-5.5.7/mosca/libmosca/mosca_image.cpp:98:41: note: Function 'set_axis' argument 1 names different: declaration 'dispersion_axis' definition 'disp_axis'. fors-5.5.7/mosca/libmosca/mosca_image.cpp:110:60: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'other' definition 'rhs'. [funcArgNamesDifferent] fors-5.5.7/mosca/libmosca/mosca_image.h:66:36: note: Function 'operator=' argument 1 names different: declaration 'other' definition 'rhs'. fors-5.5.7/mosca/libmosca/mosca_image.cpp:110:60: note: Function 'operator=' argument 1 names different: declaration 'other' definition 'rhs'. fors-5.5.7/mosca/libmosca/wavelength_calibration.cpp:39:32: warning:inconclusive: Member variable 'wavelength_calibration::m_refwave' is not initialized in the constructor. [uninitMemberVar] fors-5.5.7/mosca/libmosca/wavelength_calibration.cpp:62:32: warning:inconclusive: Member variable 'wavelength_calibration::m_nlines' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] fors-5.5.7/mosca/libmosca/spatial_distortion.cpp:88:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/mosca/libmosca/spatial_distortion.cpp:102:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/mosca/libmosca/spatial_distortion.cpp:153:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/mosca/libmosca/spatial_distortion.cpp:64:21: style: The scope of the variable 'polytop' can be reduced. [variableScope] fors-5.5.7/mosca/libmosca/spatial_distortion.cpp:65:21: style: The scope of the variable 'polybot' can be reduced. [variableScope] fors-5.5.7/mosca/libmosca/spatial_distortion.cpp:76:21: style: The scope of the variable 'npseudo' can be reduced. [variableScope] fors-5.5.7/mosca/libmosca/spatial_distortion.cpp:82:41: style: The scope of the variable 'refpixel' can be reduced. [variableScope] fors-5.5.7/mosca/libmosca/spatial_distortion.cpp:82:51: style: The scope of the variable 'start_pixel' can be reduced. [variableScope] fors-5.5.7/mosca/libmosca/spatial_distortion.cpp:82:64: style: The scope of the variable 'end_pixel' can be reduced. [variableScope] fors-5.5.7/mosca/hdrl/tests/hdrl_spectrum1d-test.c:1387:14: style: Variable 'closer_idx' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/tests/hdrl_spectrum1d-test.c:1464:14: style: Variable 'closer_idx' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/tests/hdrl_spectrum1d-test.c:2116:38: style: Parameter 'idxes' can be declared as pointer to const [constParameter] fors-5.5.7/mosca/hdrl/tests/hdrl_spectrum1d-test.c:2561:12: style: Variable 'res_flx_e' can be declared as const array [constVariable] fors-5.5.7/mosca/hdrl/tests/hdrl_resample-test.c:1537:9: style: Redundant initialization for 'state'. The initialized value is overwritten before it is read. [redundantInitialization] fors-5.5.7/mosca/hdrl/tests/hdrl_resample-test.c:1518:24: note: state is initialized fors-5.5.7/mosca/hdrl/tests/hdrl_resample-test.c:1537:9: note: state is overwritten fors-5.5.7/mosca/hdrl/tests/hdrl_resample-test.c:2179:8: style: Variable 'pErr' is reassigned a value before the old one has been used. [redundantAssignment] fors-5.5.7/mosca/hdrl/tests/hdrl_resample-test.c:2177:8: note: pErr is assigned fors-5.5.7/mosca/hdrl/tests/hdrl_resample-test.c:2179:8: note: pErr is overwritten fors-5.5.7/recipes/fors_config.c:516:66: style: Parameter 'frameset' can be declared as pointer to const [constParameter] fors-5.5.7/recipes/fors_detect_spectra.c:822:24: style: Variable 'slit_ident' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_extract_slits.c:431:21: style: Variable 'lamp_lss' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_extract_slits.c:434:21: style: Variable 'scib_lss' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_extract_slits.c:437:21: style: Variable 'scif_lss' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_extract_slits.c:440:21: style: Variable 'stab_lss' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_extract_slits.c:443:21: style: Variable 'staf_lss' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_extract_slits.c:446:21: style: Variable 'sciu_lss' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_extract_slits.c:449:21: style: Variable 'stau_lss' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_extract_slits.c:452:21: style: Variable 'scis_lss' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_extract_slits.c:455:21: style: Variable 'stas_lss' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:3208:35: style: Condition 'mode==2' is always true [knownConditionTrueFalse] fors-5.5.7/fors/moses.c:3203:30: note: Assuming that condition 'mode==1' is not redundant fors-5.5.7/fors/moses.c:3097:26: note: Assuming that condition 'mode>2' is not redundant fors-5.5.7/fors/moses.c:3100:19: note: Assuming condition is false fors-5.5.7/fors/moses.c:3208:35: note: Condition 'mode==2' is always true fors-5.5.7/fors/moses.c:3281:27: style: Local variable 'p' shadows outer variable [shadowVariable] fors-5.5.7/fors/moses.c:3076:21: note: Shadowed declaration fors-5.5.7/fors/moses.c:3281:27: note: Shadow variable fors-5.5.7/fors/moses.c:5781:36: style: Local variable 'peaks_ident_used_fit' shadows outer variable [shadowVariable] fors-5.5.7/fors/moses.c:5646:32: note: Shadowed declaration fors-5.5.7/fors/moses.c:5781:36: note: Shadow variable fors-5.5.7/fors/moses.c:16732:24: style: Local variable 'obj_v' shadows outer variable [shadowVariable] fors-5.5.7/fors/moses.c:16625:27: note: Shadowed declaration fors-5.5.7/fors/moses.c:16732:24: note: Shadow variable fors-5.5.7/fors/moses.c:500:33: style: Parameter 'buffer' can be declared as pointer to const [constParameter] fors-5.5.7/fors/moses.c:532:33: style: Parameter 'buffer' can be declared as pointer to const [constParameter] fors-5.5.7/fors/moses.c:564:33: style: Parameter 'buffer' can be declared as pointer to const [constParameter] fors-5.5.7/fors/moses.c:13544:18: style: Variable 'sx' can be declared as const array [constVariable] fors-5.5.7/fors/moses.c:13545:18: style: Variable 'sy' can be declared as const array [constVariable] fors-5.5.7/fors/moses.c:18435:16: style: Variable 'bwave' can be declared as const array [constVariable] fors-5.5.7/fors/moses.c:1494:62: error: Uninitialized variable: poly_ccd [uninitvar] fors-5.5.7/fors/moses.c:1453:25: note: Assuming condition is false fors-5.5.7/fors/moses.c:1494:62: note: Uninitialized variable: poly_ccd fors-5.5.7/fors/moses.c:17010:53: error: Uninitialized variable: minpos [uninitvar] fors-5.5.7/fors/moses.c:16980:31: note: Assuming condition is false fors-5.5.7/fors/moses.c:17010:53: note: Uninitialized variable: minpos fors-5.5.7/fors/moses.c:15961:9: error: Uninitialized variable: nports [legacyUninitvar] fors-5.5.7/fors/moses.c:837:15: style: Variable 'f2' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:1866:23: style: Unused variable: yhig [unusedVariable] fors-5.5.7/fors/moses.c:4114:18: style: Variable 'start' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:4115:18: style: Variable 'end' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:6035:22: style: Variable 'last' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:7374:23: style: Variable 'positions' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:7485:13: style: Variable 'ytop' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:7486:13: style: Variable 'ybottom' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:7887:13: style: Variable 'ybottom' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:14512:25: style: Variable 'nobjects' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:15924:14: style: Variable 'nrows' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:15937:19: style: Variable 'nx' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:15938:19: style: Variable 'ny' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:15939:19: style: Variable 'px' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:15941:19: style: Variable 'ox' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:15995:14: style: Variable 'nrows' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:17970:19: style: Variable 'count' is assigned a value that is never used. [unreadVariable] fors-5.5.7/fors/moses.c:18607:12: style: Variable 'cwave' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_normalise_flat.cc:191:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:343:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:367:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:554:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:562:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:568:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:574:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:576:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:581:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:597:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:610:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:697:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:701:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:712:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:735:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:754:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:762:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:776:4: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:780:4: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:787:4: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_normalise_flat.cc:794:4: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_pmos_extract.c:1820:29: style: The if condition is the same as the previous if condition [duplicateCondition] fors-5.5.7/recipes/fors_pmos_extract.c:1737:29: note: First condition fors-5.5.7/recipes/fors_pmos_extract.c:1820:29: note: Second condition fors-5.5.7/recipes/fors_pmos_extract.c:844:9: style: Condition 'pmos' is always true [knownConditionTrueFalse] fors-5.5.7/recipes/fors_pmos_extract.c:1978:7: style: Local variable 'k' shadows outer variable [shadowVariable] fors-5.5.7/recipes/fors_pmos_extract.c:1892:10: note: Shadowed declaration fors-5.5.7/recipes/fors_pmos_extract.c:1978:7: note: Shadow variable fors-5.5.7/recipes/fors_pmos_extract.c:2439:7: style: Local variable 'k' shadows outer variable [shadowVariable] fors-5.5.7/recipes/fors_pmos_extract.c:2147:6: note: Shadowed declaration fors-5.5.7/recipes/fors_pmos_extract.c:2439:7: note: Shadow variable fors-5.5.7/recipes/fors_pmos_extract.c:2904:29: style: Parameter 'angles' can be declared as pointer to const [constParameter] fors-5.5.7/recipes/fors_pmos_extract.c:2004:3: error: Uninitialized variable: mean_vnull [legacyUninitvar] fors-5.5.7/recipes/fors_pmos_extract.c:2491:3: error: Uninitialized variable: mean_unull [legacyUninitvar] fors-5.5.7/recipes/fors_pmos_extract.c:2465:3: error: Uninitialized variable: mean_qnull [legacyUninitvar] fors-5.5.7/recipes/fors_pmos_extract.c:1177:12: style: Variable 'ccd_xsize' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_remove_bias.cc:275:14: style: Condition 'nbias==1' is always true [knownConditionTrueFalse] fors-5.5.7/recipes/fors_remove_bias.cc:261:15: note: Assuming that condition 'nbias!=1' is not redundant fors-5.5.7/recipes/fors_remove_bias.cc:269:16: note: Assuming condition is false fors-5.5.7/recipes/fors_remove_bias.cc:275:14: note: Condition 'nbias==1' is always true fors-5.5.7/recipes/fors_remove_bias.cc:147:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_remove_bias.cc:176:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_remove_bias.cc:212:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_remove_bias.cc:270:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_remove_bias.cc:286:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_remove_bias.cc:384:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_resample.c:428:14: style: Variable 'dispstd' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_resample.c:429:13: style: Variable 'dispstd' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_resample.c:430:13: style: Variable 'dispstd' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_calib.cc:3385:5: style: Struct 'contains_subtring' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fors-5.5.7/recipes/fors_calib.cc:441:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:815:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:851:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:993:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:996:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1001:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1004:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1007:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1010:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1014:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1017:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1020:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1023:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1026:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1029:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1032:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1036:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1040:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1042:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1047:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1056:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1058:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1063:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1065:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1067:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1071:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1099:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1102:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1179:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1182:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1185:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1188:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1217:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1226:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1239:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1248:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1253:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1268:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1279:21: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1326:21: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1361:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1366:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1384:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1397:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1458:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1479:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1486:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1508:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1516:10: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1529:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1557:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1568:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1574:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1596:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1636:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1647:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1650:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1667:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1709:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1712:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1900:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1915:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1924:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1938:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1956:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1967:14: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1982:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:1998:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2013:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2108:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2117:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2126:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2140:21: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2150:21: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2241:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2321:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2357:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2402:2: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2411:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2446:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2499:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2532:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2540:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2560:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2606:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2727:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2743:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2752:10: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2768:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2786:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2797:10: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2812:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2828:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:2843:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3019:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3028:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3038:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3080:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3093:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3105:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3172:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3180:6: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3197:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3203:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3240:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3254:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3931:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:3933:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_calib.cc:951:17: style: The scope of the variable 'global_distortion_tag' can be reduced. [variableScope] fors-5.5.7/recipes/fors_calib.cc:962:17: style: The scope of the variable 'data' can be reduced. [variableScope] fors-5.5.7/recipes/fors_calib.cc:976:17: style: The scope of the variable 'compute_central_wave' can be reduced. [variableScope] fors-5.5.7/recipes/fors_calib.cc:3441:23: style: The scope of the variable 'lambda' can be reduced. [variableScope] fors-5.5.7/recipes/fors_calib.cc:3432:72: style:inconclusive: Function 'fors_calib_get_reference_lines' argument 3 names different: declaration 'ignore_lines' definition 'ignored_lines'. [funcArgNamesDifferent] fors-5.5.7/recipes/fors_calib.cc:106:72: note: Function 'fors_calib_get_reference_lines' argument 3 names different: declaration 'ignore_lines' definition 'ignored_lines'. fors-5.5.7/recipes/fors_calib.cc:3432:72: note: Function 'fors_calib_get_reference_lines' argument 3 names different: declaration 'ignore_lines' definition 'ignored_lines'. fors-5.5.7/recipes/fors_calib.cc:3544:19: style: Local variable 'lambda' shadows outer variable [shadowVariable] fors-5.5.7/recipes/fors_calib.cc:3441:23: note: Shadowed declaration fors-5.5.7/recipes/fors_calib.cc:3544:19: note: Shadow variable fors-5.5.7/recipes/fors_calib.cc:3661:15: style: Unused variable: slit_width [unusedVariable] fors-5.5.7/recipes/fors_calib.cc:2216:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] fors-5.5.7/recipes/fors_calib.cc:3141:40: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] fors-5.5.7/recipes/fors_calib.cc:3658:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] fors-5.5.7/recipes/fors_pmos_calib.c:1441:21: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] fors-5.5.7/recipes/fors_pmos_calib.c:1396:13: note: outer condition: !j fors-5.5.7/recipes/fors_pmos_calib.c:1441:21: note: identical inner condition: !j fors-5.5.7/recipes/fors_pmos_calib.c:1488:21: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] fors-5.5.7/recipes/fors_pmos_calib.c:1396:13: note: outer condition: !j fors-5.5.7/recipes/fors_pmos_calib.c:1488:21: note: identical inner condition: !j fors-5.5.7/recipes/fors_pmos_calib.c:886:9: style: Condition 'pmos' is always true [knownConditionTrueFalse] fors-5.5.7/recipes/fors_pmos_calib.c:961:13: style: Variable 'alltime' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_pmos_calib.c:976:17: style: Variable 'alltime' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_pmos_calib.c:1619:24: style: Variable 'nslits' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_subtract_sky_lss.c:252:30: style: Variable 'treat_as_lss' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_spec_mflat.cc:163:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:278:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:314:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:405:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:446:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:469:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:473:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:475:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:490:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:492:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:499:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:524:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:552:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:563:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:568:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:582:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:590:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:592:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:602:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:619:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:624:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_spec_mflat.cc:668:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_subtract_sky.c:420:5: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] fors-5.5.7/recipes/fors_subtract_sky.c:422:5: note: Found duplicate branches for 'if' and 'else'. fors-5.5.7/recipes/fors_subtract_sky.c:420:5: note: Found duplicate branches for 'if' and 'else'. fors-5.5.7/recipes/fors_wave_calib_lss.c:438:30: style: Variable 'treat_as_lss' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_pmos_science.c:1988:23: style: The if condition is the same as the previous if condition [duplicateCondition] fors-5.5.7/recipes/fors_pmos_science.c:1906:23: note: First condition fors-5.5.7/recipes/fors_pmos_science.c:1988:23: note: Second condition fors-5.5.7/recipes/fors_pmos_science.c:776:9: style: Condition 'bagoo' is always false [knownConditionTrueFalse] fors-5.5.7/recipes/fors_pmos_science.c:764:21: note: Assignment 'bagoo=0', assigned value is 0 fors-5.5.7/recipes/fors_pmos_science.c:776:9: note: Condition 'bagoo' is always false fors-5.5.7/recipes/fors_pmos_science.c:963:9: style: Condition 'pmos' is always true [knownConditionTrueFalse] fors-5.5.7/recipes/fors_pmos_science.c:3593:29: style: Parameter 'angles' can be declared as pointer to const [constParameter] fors-5.5.7/recipes/fors_pmos_science.c:2291:17: error: Uninitialized variable: mean_vnull [legacyUninitvar] fors-5.5.7/recipes/fors_pmos_science.c:2902:17: error: Uninitialized variable: mean_unull [legacyUninitvar] fors-5.5.7/recipes/fors_pmos_science.c:2876:17: error: Uninitialized variable: mean_qnull [legacyUninitvar] fors-5.5.7/recipes/fors_pmos_science.c:2048:19: style: Variable 'total' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_pmos_science.c:2478:31: style: Variable 'total' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_science.cc:1789:51: warning: Either the condition 'norm_flat' is redundant or there is possible null pointer dereference: norm_flat. [nullPointerRedundantCheck] fors-5.5.7/recipes/fors_science.cc:1800:13: note: Assuming that condition 'norm_flat' is not redundant fors-5.5.7/recipes/fors_science.cc:1789:51: note: Null pointer dereference fors-5.5.7/recipes/fors_science.cc:1790:51: warning: Either the condition 'norm_flat' is redundant or there is possible null pointer dereference: norm_flat. [nullPointerRedundantCheck] fors-5.5.7/recipes/fors_science.cc:1800:13: note: Assuming that condition 'norm_flat' is not redundant fors-5.5.7/recipes/fors_science.cc:1790:51: note: Null pointer dereference fors-5.5.7/recipes/fors_science.cc:326:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:607:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:643:18: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:825:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:833:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:850:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:853:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:861:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:868:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:873:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:879:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:884:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:895:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:906:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:909:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:929:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:952:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:957:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:960:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:963:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1027:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1137:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1140:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1144:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1147:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1150:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1216:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1228:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1237:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1295:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1326:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1343:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1405:15: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1421:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1426:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1450:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1457:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1515:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1543:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1564:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1578:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1590:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1618:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1633:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1637:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1650:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1667:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1675:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1685:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1718:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1764:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1768:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1784:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1838:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1846:20: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1867:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1876:9: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1890:13: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:1924:17: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2203:25: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2393:21: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2417:21: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2448:25: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2478:29: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2486:29: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2498:29: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2504:29: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2515:29: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2540:25: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2549:29: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2556:29: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2566:25: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2573:25: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2596:21: style: C-style pointer casting [cstyleCast] fors-5.5.7/recipes/fors_science.cc:2122:13: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] fors-5.5.7/recipes/fors_science.cc:2126:13: note: Found duplicate branches for 'if' and 'else'. fors-5.5.7/recipes/fors_science.cc:2122:13: note: Found duplicate branches for 'if' and 'else'. fors-5.5.7/recipes/fors_science.cc:674:17: style: The scope of the variable 'wcolumn' can be reduced. [variableScope] fors-5.5.7/recipes/fors_science.cc:698:23: style: The scope of the variable 'images' can be reduced. [variableScope] fors-5.5.7/recipes/fors_science.cc:753:17: style: The scope of the variable 'wheel4' can be reduced. [variableScope] fors-5.5.7/recipes/fors_science.cc:793:17: style: The scope of the variable 'mxpos' can be reduced. [variableScope] fors-5.5.7/recipes/fors_science.cc:795:17: style: The scope of the variable 'nlines' can be reduced. [variableScope] fors-5.5.7/recipes/fors_science.cc:797:17: style: The scope of the variable 'line' can be reduced. [variableScope] fors-5.5.7/recipes/fors_science.cc:806:17: style: The scope of the variable 'wstart' can be reduced. [variableScope] fors-5.5.7/recipes/fors_science.cc:807:17: style: The scope of the variable 'wstep' can be reduced. [variableScope] fors-5.5.7/recipes/fors_science.cc:808:17: style: The scope of the variable 'wcount' can be reduced. [variableScope] fors-5.5.7/recipes/fors_science.cc:3087:15: style: Parameter 'resp_use_flat_sed' can be declared as reference to const [constParameter] fors-5.5.7/recipes/fors_science.cc:2028:14: style: Variable 'yhig' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_science.cc:3064:17: style: Unused variable: all_lines [unusedVariable] fors-5.5.7/recipes/fors_science.cc:3224:14: style: Variable 'nobjects' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_science.cc:3237:30: style: Variable 'success' is assigned a value that is never used. [unreadVariable] fors-5.5.7/recipes/fors_science.cc:3252:29: style: Variable 'success' is assigned a value that is never used. [unreadVariable] diff: head fors-5.5.7/fors/fors_flat_normalise.cc:661:39: style: Variable 'ex' can be declared as reference to const [constVariable] head fors-5.5.7/fors/fors_image.c:1373:55: style: Parameter 'dstdev' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/fors/fors_image.c:1373:55: style: Parameter 'dstdev' can be declared with const [constParameter] head fors-5.5.7/fors/fors_image.c:1396:16: style: Parameter 'dstdev' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/fors/fors_image.c:1396:16: style: Parameter 'dstdev' can be declared with const [constParameter] head fors-5.5.7/fors/fors_image.c:1437:60: style: Parameter 'dmean' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/fors/fors_image.c:1437:60: style: Parameter 'dmean' can be declared with const [constParameter] head fors-5.5.7/fors/fors_image.c:966:54: style: Parameter 'dmean' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/fors/fors_image.c:966:54: style: Parameter 'dmean' can be declared with const [constParameter] head fors-5.5.7/fors/fors_image.c:983:56: style: Parameter 'dmedian' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/fors/fors_image.c:983:56: style: Parameter 'dmedian' can be declared with const [constParameter] head fors-5.5.7/fors/fors_photometry_impl.cc:3186:66: style: Parameter 'obsl' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/fors/fors_photometry_impl.cc:3186:66: style: Parameter 'obsl' can be declared with const [constParameter] head fors-5.5.7/fors/moses.c:13544:18: style: Variable 'sx' can be declared as const array [constVariable] 2.8 fors-5.5.7/fors/moses.c:13544:18: style: Variable 'sx' can be declared with const [constVariable] head fors-5.5.7/fors/moses.c:13545:18: style: Variable 'sy' can be declared as const array [constVariable] 2.8 fors-5.5.7/fors/moses.c:13545:18: style: Variable 'sy' can be declared with const [constVariable] head fors-5.5.7/fors/moses.c:18435:16: style: Variable 'bwave' can be declared as const array [constVariable] 2.8 fors-5.5.7/fors/moses.c:18435:16: style: Variable 'bwave' can be declared with const [constVariable] head fors-5.5.7/fors/moses.c:500:33: style: Parameter 'buffer' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/fors/moses.c:500:33: style: Parameter 'buffer' can be declared with const [constParameter] head fors-5.5.7/fors/moses.c:532:33: style: Parameter 'buffer' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/fors/moses.c:532:33: style: Parameter 'buffer' can be declared with const [constParameter] head fors-5.5.7/fors/moses.c:564:33: style: Parameter 'buffer' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/fors/moses.c:564:33: style: Parameter 'buffer' can be declared with const [constParameter] head fors-5.5.7/irplib/irplib_calib.c:185:22: style: Parameter 'zone' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/irplib/irplib_calib.c:185:22: style: Parameter 'zone' can be declared with const [constParameter] head fors-5.5.7/irplib/irplib_flat.c:365:21: style: Parameter 'y' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/irplib/irplib_flat.c:365:21: style: Parameter 'y' can be declared with const [constParameter] head fors-5.5.7/irplib/irplib_mkmaster.c:383:16: style: Parameter 'qclog' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/irplib/irplib_mkmaster.c:383:16: style: Parameter 'qclog' can be declared with const [constParameter] head fors-5.5.7/irplib/irplib_wavecal.c:1490:76: style: Parameter 'model' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/irplib/irplib_wavecal.c:1490:76: style: Parameter 'model' can be declared with const [constParameter] head fors-5.5.7/irplib/irplib_wavecal.c:1491:66: style: Parameter 'filler' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/irplib/irplib_wavecal.c:1491:66: style: Parameter 'filler' can be declared with const [constParameter] head fors-5.5.7/irplib/irplib_wavecal.c:1502:57: style: Parameter 'pxc' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/irplib/irplib_wavecal.c:1502:57: style: Parameter 'pxc' can be declared with const [constParameter] head fors-5.5.7/irplib/irplib_wavecal.c:281:74: style: Parameter 'model' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/irplib/irplib_wavecal.c:281:74: style: Parameter 'model' can be declared with const [constParameter] head fors-5.5.7/irplib/irplib_wavecal.c:282:63: style: Parameter 'filler' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/irplib/irplib_wavecal.c:282:63: style: Parameter 'filler' can be declared with const [constParameter] head fors-5.5.7/irplib/irplib_wavecal.c:290:54: style: Parameter 'pxc' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/irplib/irplib_wavecal.c:290:54: style: Parameter 'pxc' can be declared with const [constParameter] head fors-5.5.7/irplib/tests/irplib_plugin-test.c:166:73: style: Parameter 'self' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/irplib/tests/irplib_plugin-test.c:166:73: style: Parameter 'self' can be declared with const [constParameter] head fors-5.5.7/irplib/tests/irplib_utils-test.c:188:50: style: Parameter 'self' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/irplib/tests/irplib_utils-test.c:188:50: style: Parameter 'self' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_apline.c:58:36: style: Parameter 'dat' can be declared as const array [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_apline.c:58:36: style: Parameter 'dat' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_apline.c:58:50: style: Parameter 'conf' can be declared as const array [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_apline.c:58:50: style: Parameter 'conf' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_apline.c:59:28: style: Parameter 'smoothedc' can be declared as const array [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_apline.c:59:28: style: Parameter 'smoothedc' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_apline.c:59:68: style: Parameter 'bpm' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_apline.c:59:68: style: Parameter 'bpm' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:1259:37: style: Parameter 'mag1' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:1259:37: style: Parameter 'mag1' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:1259:51: style: Parameter 'mag2' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:1259:51: style: Parameter 'mag2' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:493:32: style: Parameter 'core1' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:493:32: style: Parameter 'core1' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:493:47: style: Parameter 'core2' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:493:47: style: Parameter 'core2' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:493:62: style: Parameter 'core3' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:493:62: style: Parameter 'core3' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:588:29: style: Parameter 'core' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:588:29: style: Parameter 'core' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:588:43: style: Parameter 'pkht' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:588:43: style: Parameter 'pkht' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:936:32: style: Parameter 'core1' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:936:32: style: Parameter 'core1' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:936:47: style: Parameter 'core2' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_classify.c:936:47: style: Parameter 'core2' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_phopt.c:61:10: style: Parameter 'apertures' can be declared as const array [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_phopt.c:61:10: style: Parameter 'apertures' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_polynm.c:55:10: style: Parameter 'xdat' can be declared as const array [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_polynm.c:55:10: style: Parameter 'xdat' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:132:60: style: Parameter 'cflux' can be declared as const array [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:132:60: style: Parameter 'cflux' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:169:59: style: Parameter 'cflux' can be declared as const array [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:169:59: style: Parameter 'cflux' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:226:55: style: Parameter 'rcores' can be declared as const array [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:226:55: style: Parameter 'rcores' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:226:72: style: Parameter 'rfluxes' can be declared as const array [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:226:72: style: Parameter 'rfluxes' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:54:30: style: Parameter 'rcores' can be declared as const array [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:54:30: style: Parameter 'rcores' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:54:47: style: Parameter 'cflux' can be declared as const array [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_radii.c:54:47: style: Parameter 'cflux' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_seeing.c:58:37: style: Parameter 'ellipt' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/catalogue/hdrl_cat_seeing.c:58:37: style: Parameter 'ellipt' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_areals-test.c:33:14: style: Variable 'x' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_areals-test.c:33:14: style: Variable 'x' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_areals-test.c:42:14: style: Variable 'y' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_areals-test.c:42:14: style: Variable 'y' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_areals-test.c:51:14: style: Variable 'z' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_areals-test.c:51:14: style: Variable 'z' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_moments-test.c:35:14: style: Variable 'x' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_moments-test.c:35:14: style: Variable 'x' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_moments-test.c:44:14: style: Variable 'y' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_moments-test.c:44:14: style: Variable 'y' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_moments-test.c:53:13: style: Variable 'z' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_moments-test.c:53:13: style: Variable 'z' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_overlp-test.c:151:11: style: Variable 'x' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_overlp-test.c:151:11: style: Variable 'x' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_overlp-test.c:160:11: style: Variable 'y' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_overlp-test.c:160:11: style: Variable 'y' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_overlp-test.c:169:13: style: Variable 'z' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_overlp-test.c:169:13: style: Variable 'z' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_radii-test.c:39:11: style: Variable 'x' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_radii-test.c:39:11: style: Variable 'x' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_radii-test.c:48:11: style: Variable 'y' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_radii-test.c:48:11: style: Variable 'y' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_radii-test.c:57:13: style: Variable 'z' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_radii-test.c:57:13: style: Variable 'z' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_terminate-test.c:35:14: style: Variable 'x' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_terminate-test.c:35:14: style: Variable 'x' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_terminate-test.c:44:14: style: Variable 'y' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_terminate-test.c:44:14: style: Variable 'y' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_terminate-test.c:53:13: style: Variable 'z' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/catalogue/tests/hdrl_cat_terminate-test.c:53:13: style: Variable 'z' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/hdrl_frameiter.c:113:31: style: Parameter 'axes' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/hdrl_frameiter.c:113:31: style: Parameter 'axes' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/hdrl_frameiter.c:114:31: style: Parameter 'dims' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/hdrl_frameiter.c:114:31: style: Parameter 'dims' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/hdrl_sigclip.c:587:40: style: Parameter 'vec' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/hdrl_sigclip.c:587:40: style: Parameter 'vec' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/hdrl_sigclip.c:627:40: style: Parameter 'vec' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/hdrl_sigclip.c:627:40: style: Parameter 'vec' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/tests/hdrl_overscan-test.c:943:14: style: Variable 'any' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/tests/hdrl_overscan-test.c:943:14: style: Variable 'any' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/tests/hdrl_spectrum1d-test.c:1387:14: style: Variable 'closer_idx' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/tests/hdrl_spectrum1d-test.c:1387:14: style: Variable 'closer_idx' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/tests/hdrl_spectrum1d-test.c:1464:14: style: Variable 'closer_idx' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/tests/hdrl_spectrum1d-test.c:1464:14: style: Variable 'closer_idx' can be declared with const [constVariable] head fors-5.5.7/mosca/hdrl/tests/hdrl_spectrum1d-test.c:2116:38: style: Parameter 'idxes' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/mosca/hdrl/tests/hdrl_spectrum1d-test.c:2116:38: style: Parameter 'idxes' can be declared with const [constParameter] head fors-5.5.7/mosca/hdrl/tests/hdrl_spectrum1d-test.c:2561:12: style: Variable 'res_flx_e' can be declared as const array [constVariable] 2.8 fors-5.5.7/mosca/hdrl/tests/hdrl_spectrum1d-test.c:2561:12: style: Variable 'res_flx_e' can be declared with const [constVariable] head fors-5.5.7/mosca/libmosca/response.cpp:42:66: style: Parameter 'std_star' can be declared as reference to const [constParameter] 2.8 fors-5.5.7/mosca/libmosca/response.cpp:42:66: style: Parameter 'std_star' can be declared with const [constParameter] head fors-5.5.7/recipes/fors_config.c:516:66: style: Parameter 'frameset' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/recipes/fors_config.c:516:66: style: Parameter 'frameset' can be declared with const [constParameter] head fors-5.5.7/recipes/fors_pmos_extract.c:2904:29: style: Parameter 'angles' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/recipes/fors_pmos_extract.c:2904:29: style: Parameter 'angles' can be declared with const [constParameter] head fors-5.5.7/recipes/fors_pmos_science.c:3593:29: style: Parameter 'angles' can be declared as pointer to const [constParameter] 2.8 fors-5.5.7/recipes/fors_pmos_science.c:3593:29: style: Parameter 'angles' can be declared with const [constParameter] head fors-5.5.7/recipes/fors_science.cc:3087:15: style: Parameter 'resp_use_flat_sed' can be declared as reference to const [constParameter] 2.8 fors-5.5.7/recipes/fors_science.cc:3087:15: style: Parameter 'resp_use_flat_sed' can be declared with const [constParameter] DONE