2022-06-26 16:15 ftp://ftp.de.debian.org/debian/pool/main/c/citadel/citadel_917.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1 platform: Linux-5.4.0-121-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 cppcheck: head 2.8 head-info: 242afc3 (2022-06-25 21:42:55 +0200) count: 216 211 elapsed-time: 24.4 30.2 head-timing-info: Tokenizer::simplifyTokens1: 6.71666s (avg. 0.0839582s - 80 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 5.75288s (avg. 0.071911s - 80 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.51033s (avg. 0.00637912s - 80 result(s)) Check function usage::runChecks: 0.198544s (avg. 0.0024818s - 80 result(s)) Tokenizer::createTokens: 0.169194s (avg. 0.00155224s - 109 result(s)) Overall time: 14.0389s old-timing-info: Tokenizer::simplifyTokens1: 8.62628s (avg. 0.107829s - 80 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 7.58243s (avg. 0.0947803s - 80 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.571512s (avg. 0.0071439s - 80 result(s)) Check function usage::runChecks: 0.213861s (avg. 0.00267326s - 80 result(s)) Tokenizer::createTokens: 0.18003s (avg. 0.00165165s - 109 result(s)) Overall time: 17.8803s head results: citadel/auth.c:112:7: portability: Non reentrant function 'getpwuid' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwuid_r'. [prohibitedgetpwuidCalled] citadel/auth.c:150:14: portability: Non reentrant function 'crypt' called. For threadsafe applications it is recommended to use the reentrant replacement function 'crypt_r'. [prohibitedcryptCalled] citadel/typesize.h:40:0: error: #error Unable to find an 8-bit integer datatype [preprocessorErrorDirective] citadel/clientsocket.c:33:11: style: Variable 'sock' is assigned a value that is never used. [unreadVariable] citadel/database.c:41:0: error: #error Neither nor was found by configure. Install db5-devel. [preprocessorErrorDirective] citadel/sysdep_decls.h:17:0: error: #error Neither nor was found by configure. Install db4-devel. [preprocessorErrorDirective] citadel/modules/autocompletion/serv_autocompletion.c:162:5: error: Common realloc mistake: 'msglist' nulled but not freed upon failure [memleakOnRealloc] citadel/modules/autocompletion/serv_autocompletion.c:139:8: style: Variable 'i' is assigned a value that is never used. [unreadVariable] citadel/modules/autocompletion/serv_autocompletion.c:140:8: style: Variable 'j' is assigned a value that is never used. [unreadVariable] citadel/modules/autocompletion/serv_autocompletion.c:141:19: style: Variable 'search_match' is assigned a value that is never used. [unreadVariable] citadel/modules/bio/serv_bio.c:162:27: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] citadel/modules/bio/serv_bio.c:152:13: style: Variable 'd_type' is assigned a value that is never used. [unreadVariable] citadel/modules/calendar/serv_calendar.c:1435:19: style: Variable 'config_lines' is assigned a value that is never used. [unreadVariable] citadel/modules/ctdlproto/serv_file.c:725:15: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] citadel/modules/ctdlproto/serv_file.c:473:32: style: Checking if unsigned expression 'bytes' is less than zero. [unsignedLessThanZero] citadel/modules/ctdlproto/serv_file.c:226:26: error: Uninitialized variable: pathname [legacyUninitvar] citadel/modules/ctdlproto/serv_rooms.c:431:26: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] citadel/modules/ctdlproto/serv_rooms.c:372:17: warning:inconclusive: Either the condition 'cdbus!=NULL' is redundant or there is possible null pointer dereference: cdbus. [nullPointerRedundantCheck] citadel/modules/ctdlproto/serv_rooms.c:370:49: note: Assuming that condition 'cdbus!=NULL' is not redundant citadel/modules/ctdlproto/serv_rooms.c:372:17: note: Null pointer dereference citadel/modules/ctdlproto/serv_user.c:433:18: warning:inconclusive: Either the condition 'cdbus!=NULL' is redundant or there is possible null pointer dereference: cdbus. [nullPointerRedundantCheck] citadel/modules/ctdlproto/serv_user.c:431:49: note: Assuming that condition 'cdbus!=NULL' is not redundant citadel/modules/ctdlproto/serv_user.c:433:18: note: Null pointer dereference citadel/modules/expire/serv_expire.c:383:7: portability: Non reentrant function 'getpwuid' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwuid_r'. [prohibitedgetpwuidCalled] citadel/modules/expire/serv_expire.c:356:4: error: Common realloc mistake: 'transcript' nulled but not freed upon failure [memleakOnRealloc] citadel/modules/expire/serv_expire.c:492:4: error: Common realloc mistake: 'users_corrupt_msg' nulled but not freed upon failure [memleakOnRealloc] citadel/modules/expire/serv_expire.c:548:4: error: Common realloc mistake: 'transcript' nulled but not freed upon failure [memleakOnRealloc] citadel/modules/expire/serv_expire.c:615:17: warning:inconclusive: Either the condition 'cdbvisit!=NULL' is redundant or there is possible null pointer dereference: cdbvisit. [nullPointerRedundantCheck] citadel/modules/expire/serv_expire.c:613:54: note: Assuming that condition 'cdbvisit!=NULL' is not redundant citadel/modules/expire/serv_expire.c:615:17: note: Null pointer dereference citadel/modules/expire/serv_expire.c:616:7: warning:inconclusive: Either the condition 'cdbvisit!=NULL' is redundant or there is possible null pointer dereference: cdbvisit. [nullPointerRedundantCheck] citadel/modules/expire/serv_expire.c:613:54: note: Assuming that condition 'cdbvisit!=NULL' is not redundant citadel/modules/expire/serv_expire.c:616:7: note: Null pointer dereference citadel/modules/expire/serv_expire.c:617:22: warning:inconclusive: Either the condition 'cdbvisit!=NULL' is redundant or there is possible null pointer dereference: cdbvisit. [nullPointerRedundantCheck] citadel/modules/expire/serv_expire.c:613:54: note: Assuming that condition 'cdbvisit!=NULL' is not redundant citadel/modules/expire/serv_expire.c:617:22: note: Null pointer dereference citadel/modules/expire/serv_expire.c:106:22: style: struct member 'ctdlroomref::next' is never used. [unusedStructMember] citadel/modules/expire/serv_expire.c:107:7: style: struct member 'ctdlroomref::msgnum' is never used. [unusedStructMember] citadel/modules/fulltext/ft_wordbreaker.c:270:6: error: Common realloc mistake: 'wb_tokens' nulled but not freed upon failure [memleakOnRealloc] citadel/modules/fulltext/serv_fulltext.c:217:4: error: Common realloc mistake: 'ft_newmsgs' nulled but not freed upon failure [memleakOnRealloc] citadel/modules/fulltext/serv_fulltext.c:408:5: error: Common realloc mistake: 'all_msgs' nulled but not freed upon failure [memleakOnRealloc] citadel/modules/fulltext/serv_fulltext.c:429:8: error: Common realloc mistake: 'ret_msgs' nulled but not freed upon failure [memleakOnRealloc] citadel/modules/fulltext/serv_fulltext.c:485:29: style: Parameter 'room' can be declared as pointer to const [constParameter] citadel/modules/image/serv_image.c:293:27: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] citadel/modules/image/serv_image.c:283:13: style: Variable 'd_type' is assigned a value that is never used. [unreadVariable] citadel/modules/imap/imap_acl.c:186:17: warning:inconclusive: Either the condition 'cdbus!=NULL' is redundant or there is possible null pointer dereference: cdbus. [nullPointerRedundantCheck] citadel/modules/imap/imap_acl.c:183:49: note: Assuming that condition 'cdbus!=NULL' is not redundant citadel/modules/imap/imap_acl.c:186:17: note: Null pointer dereference citadel/modules/imap/imap_fetch.c:77:25: style: Condition 'num_flags_printed>0' is always false [knownConditionTrueFalse] citadel/modules/imap/imap_fetch.c:74:26: note: Assignment 'num_flags_printed=0', assigned value is 0 citadel/modules/imap/imap_fetch.c:77:25: note: Condition 'num_flags_printed>0' is always false citadel/modules/imap/imap_fetch.c:1330:34: style:inconclusive: Function 'imap_pick_range' argument 1 names different: declaration 'range' definition 'supplied_range'. [funcArgNamesDifferent] citadel/modules/imap/imap_fetch.h:13:34: note: Function 'imap_pick_range' argument 1 names different: declaration 'range' definition 'supplied_range'. citadel/modules/imap/imap_fetch.c:1330:34: note: Function 'imap_pick_range' argument 1 names different: declaration 'range' definition 'supplied_range'. citadel/modules/imap/imap_fetch.c:98:3: style: Variable 'num_flags_printed' is assigned a value that is never used. [unreadVariable] citadel/modules/imap/imap_list.c:320:27: style: Variable 'ImapFilter.num_patterns' is reassigned a value before the old one has been used. [redundantAssignment] citadel/modules/imap/imap_list.c:210:26: note: ImapFilter.num_patterns is assigned citadel/modules/imap/imap_list.c:320:27: note: ImapFilter.num_patterns is overwritten citadel/modules/imap/imap_list.c:86:8: style: Variable 'j' is assigned a value that is never used. [unreadVariable] citadel/modules/imap/imap_list.c:87:12: style: Variable 'match' is assigned a value that is never used. [unreadVariable] citadel/modules/imap/imap_list.c:125:8: style: Variable 'i' is assigned a value that is never used. [unreadVariable] citadel/modules/imap/imap_list.c:126:12: style: Variable 'match' is assigned a value that is never used. [unreadVariable] citadel/modules/imap/imap_list.c:199:18: style: Variable 'return_left' is assigned a value that is never used. [unreadVariable] citadel/modules/imap/imap_metadata.c:295:6: style: The if condition is the same as the previous if condition [duplicateCondition] citadel/modules/imap/imap_metadata.c:275:6: note: First condition citadel/modules/imap/imap_metadata.c:295:6: note: Second condition citadel/modules/imap/imap_misc.c:340:11: style: The comparison 'ret < 0' is always false. [knownConditionTrueFalse] citadel/modules/imap/imap_misc.c:282:12: note: 'ret' is assigned value '0' here. citadel/modules/imap/imap_misc.c:340:11: note: The comparison 'ret < 0' is always false. citadel/modules/imap/imap_tools.c:747:22: style: Array index 'i' is used before limits check. [arrayIndexThenCheck] citadel/modules/imap/imap_tools.c:754:19: style: Array index 'i' is used before limits check. [arrayIndexThenCheck] citadel/modules/imap/imap_tools.c:632:13: warning: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] citadel/modules/imap/imap_tools.c:640:13: warning: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] citadel/modules/imap/imap_tools.c:682:11: warning: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] citadel/modules/imap/imap_tools.c:607:25: style:inconclusive: Function 'imap_roomname' argument 1 names different: declaration 'buf' definition 'rbuf'. [funcArgNamesDifferent] citadel/modules/imap/imap_tools.h:29:25: note: Function 'imap_roomname' argument 1 names different: declaration 'buf' definition 'rbuf'. citadel/modules/imap/imap_tools.c:607:25: note: Function 'imap_roomname' argument 1 names different: declaration 'buf' definition 'rbuf'. citadel/modules/imap/imap_tools.c:215:40: style: Parameter 'destend' can be declared as pointer to const [constParameter] citadel/modules/imap/imap_tools.c:297:42: style: Parameter 'destend' can be declared as pointer to const [constParameter] citadel/modules/imap/serv_imap.c:445:21: style: Condition 'Imap->num_msgs>original_num_msgs' is always false [knownConditionTrueFalse] citadel/modules/imap/serv_imap.c:421:20: note: original_num_msgs is assigned 'Imap->num_msgs' here. citadel/modules/imap/serv_imap.c:445:21: note: Condition 'Imap->num_msgs>original_num_msgs' is always false citadel/modules/imap/serv_imap.c:713:11: style: Variable 'len' is assigned a value that is never used. [unreadVariable] citadel/modules/imap/serv_imap.c:1375:15: style: Variable 'newfloor' is assigned a value that is never used. [unreadVariable] citadel/modules/instmsg/serv_instmsg.c:346:4: error: Common realloc mistake: 'x_big_msgbuf' nulled but not freed upon failure [memleakOnRealloc] citadel/modules/instmsg/serv_instmsg.c:72:16: warning: Either the condition 'me' is redundant or there is possible null pointer dereference: me. [nullPointerRedundantCheck] citadel/modules/instmsg/serv_instmsg.c:104:7: note: Assuming that condition 'me' is not redundant citadel/modules/instmsg/serv_instmsg.c:72:16: note: Null pointer dereference citadel/modules/instmsg/serv_instmsg.c:73:16: warning: Either the condition 'them' is redundant or there is possible null pointer dereference: them. [nullPointerRedundantCheck] citadel/modules/instmsg/serv_instmsg.c:107:7: note: Assuming that condition 'them' is not redundant citadel/modules/instmsg/serv_instmsg.c:73:16: note: Null pointer dereference citadel/modules/managesieve/serv_managesieve.c:284:18: style: Condition '*username=='\0'' is always false [knownConditionTrueFalse] citadel/modules/migrate/serv_migrate.c:343:3: error: Common realloc mistake: 'encoded_msg' nulled but not freed upon failure [memleakOnRealloc] citadel/modules/migrate/serv_migrate.c:751:8: error: Common realloc mistake: 'msglist' nulled but not freed upon failure [memleakOnRealloc] citadel/modules/migrate/serv_migrate.c:268:17: warning:inconclusive: Either the condition 'cdbv!=NULL' is redundant or there is possible null pointer dereference: cdbv. [nullPointerRedundantCheck] citadel/modules/migrate/serv_migrate.c:266:47: note: Assuming that condition 'cdbv!=NULL' is not redundant citadel/modules/migrate/serv_migrate.c:268:17: note: Null pointer dereference citadel/modules/migrate/serv_migrate.c:269:12: warning:inconclusive: Either the condition 'cdbv!=NULL' is redundant or there is possible null pointer dereference: cdbv. [nullPointerRedundantCheck] citadel/modules/migrate/serv_migrate.c:266:47: note: Assuming that condition 'cdbv!=NULL' is not redundant citadel/modules/migrate/serv_migrate.c:269:12: note: Null pointer dereference citadel/modules/migrate/serv_migrate.c:270:20: warning:inconclusive: Either the condition 'cdbv!=NULL' is redundant or there is possible null pointer dereference: cdbv. [nullPointerRedundantCheck] citadel/modules/migrate/serv_migrate.c:266:47: note: Assuming that condition 'cdbv!=NULL' is not redundant citadel/modules/migrate/serv_migrate.c:270:20: note: Null pointer dereference citadel/modules/migrate/serv_migrate.c:395:19: warning:inconclusive: Either the condition 'cdbcfg!=NULL' is redundant or there is possible null pointer dereference: cdbcfg. [nullPointerRedundantCheck] citadel/modules/migrate/serv_migrate.c:393:52: note: Assuming that condition 'cdbcfg!=NULL' is not redundant citadel/modules/migrate/serv_migrate.c:395:19: note: Null pointer dereference citadel/modules/migrate/serv_migrate.c:396:9: warning:inconclusive: Either the condition 'cdbcfg!=NULL' is redundant or there is possible null pointer dereference: cdbcfg. [nullPointerRedundantCheck] citadel/modules/migrate/serv_migrate.c:393:52: note: Assuming that condition 'cdbcfg!=NULL' is not redundant citadel/modules/migrate/serv_migrate.c:396:9: note: Null pointer dereference citadel/modules/migrate/serv_migrate.c:397:11: warning:inconclusive: Either the condition 'cdbcfg!=NULL' is redundant or there is possible null pointer dereference: cdbcfg. [nullPointerRedundantCheck] citadel/modules/migrate/serv_migrate.c:393:52: note: Assuming that condition 'cdbcfg!=NULL' is not redundant citadel/modules/migrate/serv_migrate.c:397:11: note: Null pointer dereference citadel/modules/migrate/serv_migrate.c:682:47: warning:inconclusive: Either the condition 'ikey!=NULL' is redundant or there is possible null pointer dereference: ikey. [nullPointerRedundantCheck] citadel/modules/migrate/serv_migrate.c:684:12: note: Assuming that condition 'ikey!=NULL' is not redundant citadel/modules/migrate/serv_migrate.c:682:47: note: Null pointer dereference citadel/modules/migrate/serv_migrate.c:1087:12: style: Variable 'lastnum' is reassigned a value before the old one has been used. [redundantAssignment] citadel/modules/migrate/serv_migrate.c:1073:13: note: lastnum is assigned citadel/modules/migrate/serv_migrate.c:1087:12: note: lastnum is overwritten citadel/modules/migrate/serv_migrate.c:261:8: style: Local variable 'vbuf' shadows outer variable [shadowVariable] citadel/modules/migrate/serv_migrate.c:503:7: note: Shadowed declaration citadel/modules/migrate/serv_migrate.c:261:8: note: Shadow variable citadel/modules/migrate/serv_migrate.c:301:18: style: Local variable 'smi' shadows outer variable [shadowVariable] citadel/modules/migrate/serv_migrate.c:504:17: note: Shadowed declaration citadel/modules/migrate/serv_migrate.c:301:18: note: Shadow variable citadel/modules/migrate/serv_migrate.c:923:18: style: Local variable 'smi' shadows outer variable [shadowVariable] citadel/modules/migrate/serv_migrate.c:504:17: note: Shadowed declaration citadel/modules/migrate/serv_migrate.c:923:18: note: Shadow variable citadel/modules/migrate/serv_migrate.c:1013:18: style: Local variable 'smi' shadows outer variable [shadowVariable] citadel/modules/migrate/serv_migrate.c:504:17: note: Shadowed declaration citadel/modules/migrate/serv_migrate.c:1013:18: note: Shadow variable citadel/modules/migrate/serv_migrate.c:388:13: style: Variable 'keylen' is assigned a value that is never used. [unreadVariable] citadel/modules/migrate/serv_migrate.c:415:15: style: Variable 'progress' is assigned a value that is never used. [unreadVariable] citadel/modules/migrate/serv_migrate.c:661:14: style: Variable 'msgnum' is assigned a value that is never used. [unreadVariable] citadel/modules/migrate/serv_migrate.c:663:20: style: Variable 'msglist_alloc' is assigned a value that is never used. [unreadVariable] citadel/modules/migrate/serv_migrate.c:766:18: style: Variable 'msglist_alloc' is assigned a value that is never used. [unreadVariable] citadel/modules/network/serv_netfilter.c:132:15: style: Variable 'zap_user' is assigned a value that is never used. [unreadVariable] citadel/modules/network/serv_netfilter.c:133:15: style: Variable 'zap_room' is assigned a value that is never used. [unreadVariable] citadel/modules/network/serv_netfilter.c:134:15: style: Variable 'zap_node' is assigned a value that is never used. [unreadVariable] citadel/modules/network/serv_netmail.c:450:11: style: Variable 'bang' is assigned a value that is never used. [unreadVariable] citadel/modules/network/serv_netmail.c:451:11: style: Variable 'send' is assigned a value that is never used. [unreadVariable] citadel/modules/network/serv_netspool.c:829:27: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] citadel/modules/network/serv_netspool.c:926:27: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] citadel/modules/network/serv_netspool.c:1055:27: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] citadel/modules/network/serv_netspool.c:932:22: warning: Either the condition 'filedir_entry!=NULL' is redundant or there is possible null pointer dereference: filedir_entry. [nullPointerRedundantCheck] citadel/modules/network/serv_netspool.c:926:57: note: Assuming that condition 'filedir_entry!=NULL' is not redundant citadel/modules/network/serv_netspool.c:932:22: note: Null pointer dereference citadel/modules/network/serv_netspool.c:955:16: warning: Either the condition 'filedir_entry!=NULL' is redundant or there is possible null pointer dereference: filedir_entry. [nullPointerRedundantCheck] citadel/modules/network/serv_netspool.c:926:57: note: Assuming that condition 'filedir_entry!=NULL' is not redundant citadel/modules/network/serv_netspool.c:955:16: note: Null pointer dereference citadel/modules/network/serv_netspool.c:963:5: warning: Either the condition 'filedir_entry!=NULL' is redundant or there is possible null pointer dereference: filedir_entry. [nullPointerRedundantCheck] citadel/modules/network/serv_netspool.c:926:57: note: Assuming that condition 'filedir_entry!=NULL' is not redundant citadel/modules/network/serv_netspool.c:963:5: note: Null pointer dereference citadel/modules/network/serv_netspool.c:966:8: warning: Either the condition 'filedir_entry!=NULL' is redundant or there is possible null pointer dereference: filedir_entry. [nullPointerRedundantCheck] citadel/modules/network/serv_netspool.c:926:57: note: Assuming that condition 'filedir_entry!=NULL' is not redundant citadel/modules/network/serv_netspool.c:966:8: note: Null pointer dereference citadel/modules/network/serv_netspool.c:967:14: warning: Either the condition 'filedir_entry!=NULL' is redundant or there is possible null pointer dereference: filedir_entry. [nullPointerRedundantCheck] citadel/modules/network/serv_netspool.c:926:57: note: Assuming that condition 'filedir_entry!=NULL' is not redundant citadel/modules/network/serv_netspool.c:967:14: note: Null pointer dereference citadel/modules/network/serv_netspool.c:1061:22: warning: Either the condition 'filedir_entry!=NULL' is redundant or there is possible null pointer dereference: filedir_entry. [nullPointerRedundantCheck] citadel/modules/network/serv_netspool.c:1055:57: note: Assuming that condition 'filedir_entry!=NULL' is not redundant citadel/modules/network/serv_netspool.c:1061:22: note: Null pointer dereference citadel/modules/network/serv_netspool.c:1081:16: warning: Either the condition 'filedir_entry!=NULL' is redundant or there is possible null pointer dereference: filedir_entry. [nullPointerRedundantCheck] citadel/modules/network/serv_netspool.c:1055:57: note: Assuming that condition 'filedir_entry!=NULL' is not redundant citadel/modules/network/serv_netspool.c:1081:16: note: Null pointer dereference citadel/modules/network/serv_netspool.c:1086:8: warning: Either the condition 'filedir_entry!=NULL' is redundant or there is possible null pointer dereference: filedir_entry. [nullPointerRedundantCheck] citadel/modules/network/serv_netspool.c:1055:57: note: Assuming that condition 'filedir_entry!=NULL' is not redundant citadel/modules/network/serv_netspool.c:1086:8: note: Null pointer dereference citadel/modules/network/serv_netspool.c:1087:14: warning: Either the condition 'filedir_entry!=NULL' is redundant or there is possible null pointer dereference: filedir_entry. [nullPointerRedundantCheck] citadel/modules/network/serv_netspool.c:1055:57: note: Assuming that condition 'filedir_entry!=NULL' is not redundant citadel/modules/network/serv_netspool.c:1087:14: note: Null pointer dereference citadel/modules/network/serv_netspool.c:1093:4: warning: Either the condition 'filedir_entry!=NULL' is redundant or there is possible null pointer dereference: filedir_entry. [nullPointerRedundantCheck] citadel/modules/network/serv_netspool.c:1055:57: note: Assuming that condition 'filedir_entry!=NULL' is not redundant citadel/modules/network/serv_netspool.c:1093:4: note: Null pointer dereference citadel/modules/network/serv_netspool.c:1110:46: style:inconclusive: Function 'free_spoolcontrol_struct' argument 1 names different: declaration 'scc' definition 'sc'. [funcArgNamesDifferent] citadel/modules/network/netspool.h:60:46: note: Function 'free_spoolcontrol_struct' argument 1 names different: declaration 'scc' definition 'sc'. citadel/modules/network/serv_netspool.c:1110:46: note: Function 'free_spoolcontrol_struct' argument 1 names different: declaration 'scc' definition 'sc'. citadel/modules/network/serv_netspool.c:1117:53: style:inconclusive: Function 'free_spoolcontrol_struct_members' argument 1 names different: declaration 'scc' definition 'sc'. [funcArgNamesDifferent] citadel/modules/network/netspool.h:61:53: note: Function 'free_spoolcontrol_struct_members' argument 1 names different: declaration 'scc' definition 'sc'. citadel/modules/network/serv_netspool.c:1117:53: note: Function 'free_spoolcontrol_struct_members' argument 1 names different: declaration 'scc' definition 'sc'. citadel/modules/network/serv_netspool.c:802:13: style: Variable 'd_type' is assigned a value that is never used. [unreadVariable] citadel/modules/network/serv_netspool.c:912:13: style: Variable 'd_type' is assigned a value that is never used. [unreadVariable] citadel/modules/network/serv_network.c:461:10: style: Variable 'rv' is assigned a value that is never used. [unreadVariable] citadel/modules/networkclient/serv_networkclient.c:273:11: style: Variable 'poll' is assigned a value that is never used. [unreadVariable] citadel/modules/nntp/serv_nntp.c:997:2: style: Obsolescent function 'ctime_r' called. It is recommended to use 'strftime' instead. [prohibitedctime_rCalled] citadel/modules/nntp/serv_nntp.c:773:42: style: Variable 'must_change_currently_selected_article' is assigned a value that is never used. [unreadVariable] citadel/modules/nntp/serv_nntp.c:780:42: style: Variable 'must_change_currently_selected_article' is assigned a value that is never used. [unreadVariable] citadel/modules/nntp/serv_nntp.c:897:8: style: Variable 'i' is assigned a value that is never used. [unreadVariable] citadel/modules/openid/serv_openid_rp.c:392:6: error: Using pointer to local variable 'fullname' that is out of scope. [invalidLifetime] citadel/modules/openid/serv_openid_rp.c:388:15: note: Array decayed to pointer here. citadel/modules/openid/serv_openid_rp.c:384:9: note: Variable created here. citadel/modules/openid/serv_openid_rp.c:392:6: note: Using pointer to local variable 'fullname' that is out of scope. citadel/modules/openid/serv_openid_rp.c:510:29: style:inconclusive: Boolean expression 'href_start==NULL' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] citadel/modules/pop3client/serv_pop3client.c:158:10: style: Variable 'res' is assigned a value that is never used. [unreadVariable] citadel/modules/rwho/serv_rwho.c:92:14: style: Variable 'spoofed' is assigned a value that is never used. [unreadVariable] citadel/modules/rwho/serv_rwho.c:93:19: style: Variable 'user_spoofed' is assigned a value that is never used. [unreadVariable] citadel/modules/rwho/serv_rwho.c:94:19: style: Variable 'room_spoofed' is assigned a value that is never used. [unreadVariable] citadel/modules/rwho/serv_rwho.c:95:19: style: Variable 'host_spoofed' is assigned a value that is never used. [unreadVariable] citadel/modules/smtp/serv_smtp.c:885:9: style: Local variable 'i' shadows outer variable [shadowVariable] citadel/modules/smtp/serv_smtp.c:811:6: note: Shadowed declaration citadel/modules/smtp/serv_smtp.c:885:9: note: Shadow variable citadel/modules/smtp/serv_smtp.c:458:11: style: Variable 'len' is assigned a value that is never used. [unreadVariable] citadel/modules/smtp/serv_smtpclient.c:460:3: error: Common realloc mistake: 'smtpq' nulled but not freed upon failure [memleakOnRealloc] citadel/modules/smtp/serv_smtpclient.c:311:10: warning: Either the condition 'crlf!=NULL' is redundant or there is possible null pointer dereference: crlf. [nullPointerRedundantCheck] citadel/modules/smtp/serv_smtpclient.c:310:44: note: Assuming that condition 'crlf!=NULL' is not redundant citadel/modules/smtp/serv_smtpclient.c:311:10: note: Null pointer dereference citadel/modules/smtp/serv_smtpclient.c:311:20: warning: Either the condition 'crlf!=NULL' is redundant or there is pointer arithmetic with NULL pointer. [nullPointerArithmeticRedundantCheck] citadel/modules/smtp/serv_smtpclient.c:310:44: note: Assuming that condition 'crlf!=NULL' is not redundant citadel/modules/smtp/serv_smtpclient.c:311:20: note: Null pointer addition citadel/modules/smtp/serv_smtpclient.c:192:15: style: Variable 'res' is assigned a value that is never used. [unreadVariable] citadel/modules/smtp/serv_smtpclient.c:216:15: style: Variable 's.bytes_sent' is assigned a value that is never used. [unreadVariable] citadel/modules/smtp/smtp_util.c:96:18: style: Variable 'bounce_this' is assigned a value that is never used. [unreadVariable] citadel/modules/upgrade/serv_upgrade.c:220:3: error: Mismatching allocation and deallocation: fp [mismatchAllocDealloc] citadel/modules/upgrade/serv_upgrade.c:213:7: note: Mismatching allocation and deallocation: fp citadel/modules/upgrade/serv_upgrade.c:220:3: note: Mismatching allocation and deallocation: fp citadel/modules/upgrade/serv_upgrade.c:478:5: error: Common realloc mistake: 'm' nulled but not freed upon failure [memleakOnRealloc] citadel/modules/vcard/serv_vcard.c:347:6: style: The if condition is the same as the previous if condition [duplicateCondition] citadel/modules/vcard/serv_vcard.c:331:6: note: First condition citadel/modules/vcard/serv_vcard.c:347:6: note: Second condition citadel/modules/vcard/serv_vcard.c:817:24: style: Condition 'need_default_vcard!=0' is always true [knownConditionTrueFalse] citadel/modules/vcard/serv_vcard.c:761:22: note: Assignment 'need_default_vcard=1', assigned value is 1 citadel/modules/vcard/serv_vcard.c:767:8: note: Assuming condition is false citadel/modules/vcard/serv_vcard.c:817:24: note: Condition 'need_default_vcard!=0' is always true citadel/modules/vcard/serv_vcard.c:398:11: style: Local variable 'buf' shadows outer variable [shadowVariable] citadel/modules/vcard/serv_vcard.c:246:7: note: Shadowed declaration citadel/modules/vcard/serv_vcard.c:398:11: note: Shadow variable citadel/modules/vcard/serv_vcard.c:251:8: style: Variable 'i' is assigned a value that is never used. [unreadVariable] citadel/modules/vcard/serv_vcard.c:971:27: style: Variable 'num_secondary_emails' is assigned a value that is never used. [unreadVariable] citadel/modules/wiki/serv_wiki.c:211:19: style: Condition 'diffbuf_len=0' is always false [knownConditionTrueFalse] citadel/modules/wiki/serv_wiki.c:175:5: style: Variable 'rv' is reassigned a value before the old one has been used. [redundantAssignment] citadel/modules/wiki/serv_wiki.c:169:6: note: rv is assigned citadel/modules/wiki/serv_wiki.c:175:5: note: rv is overwritten citadel/modules/wiki/serv_wiki.c:185:5: style: Variable 'rv' is reassigned a value before the old one has been used. [redundantAssignment] citadel/modules/wiki/serv_wiki.c:175:5: note: rv is assigned citadel/modules/wiki/serv_wiki.c:185:5: note: rv is overwritten citadel/modules/wiki/serv_wiki.c:229:9: style: Local variable 'buf' shadows outer variable [shadowVariable] citadel/modules/wiki/serv_wiki.c:89:7: note: Shadowed declaration citadel/modules/wiki/serv_wiki.c:229:9: note: Shadow variable citadel/modules/wiki/serv_wiki.c:561:5: style: Variable 'r' is assigned a value that is never used. [unreadVariable] citadel/modules/xmpp/xmpp_presence.c:81:40: style:inconclusive: Function 'xmpp_is_visible' argument 1 names different: declaration 'from' definition 'cptr'. [funcArgNamesDifferent] citadel/modules/xmpp/serv_xmpp.h:78:40: note: Function 'xmpp_is_visible' argument 1 names different: declaration 'from' definition 'cptr'. citadel/modules/xmpp/xmpp_presence.c:81:40: note: Function 'xmpp_is_visible' argument 1 names different: declaration 'from' definition 'cptr'. citadel/modules/xmpp/xmpp_presence.c:373:17: style: Variable 'online_now' is assigned a value that is never used. [unreadVariable] citadel/modules/xmpp/xmpp_queue.c:99:3: warning: Possible null pointer dereference: last [nullPointer] citadel/modules/xmpp/xmpp_queue.c:58:28: note: Assignment 'last=NULL', assigned value is 0 citadel/modules/xmpp/xmpp_queue.c:94:32: note: Assuming condition is false citadel/modules/xmpp/xmpp_queue.c:99:3: note: Null pointer dereference y.tab.c:1093:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] parsedate.y:724:17: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData] parsedate.y:557:10: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] y.tab.c:1093:11: style: Variable 'yymsg' is assigned a value that is never used. [unreadVariable] citadel/utillib/citadel_dirs.c:114:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:114:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:122:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:122:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:123:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:123:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:132:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:132:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:140:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:140:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:148:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:148:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:156:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:156:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:157:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:157:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:158:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:158:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:159:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:159:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:160:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:160:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:161:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:161:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:162:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:162:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:177:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:177:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:178:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:178:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:179:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:179:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:180:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:180:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:181:2: style:inconclusive: Boolean expression '!relh' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:181:2: style:inconclusive: Boolean expression 'basedir!=ctdldir' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] citadel/utillib/citadel_dirs.c:114:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:122:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:123:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:132:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:140:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:148:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:156:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:157:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:158:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:159:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:160:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:161:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:162:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:177:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:178:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:179:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:180:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utillib/citadel_dirs.c:181:2: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] citadel/utils/aidepost.c:126:8: warning: Either the condition 'ch>=0' is redundant or putc() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'. [invalidFunctionArg] citadel/utils/aidepost.c:125:32: note: Assuming that condition 'ch>=0' is not redundant citadel/utils/aidepost.c:126:8: note: Invalid argument citadel/utils/chkpw.c:131:7: portability: Non reentrant function 'getpwnam' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwnam_r'. [prohibitedgetpwnamCalled] citadel/utils/chkpw.c:106:3: style: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] citadel/utils/citmail.c:105:33: warning: Either the condition 'bytes_written