2022-06-26 15:48 ftp://ftp.de.debian.org/debian/pool/main/c/chrony/chrony_4.2.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j6 platform: Linux-5.4.0-121-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 cppcheck: head 2.8 head-info: 242afc389 (2022-06-25 21:42:55 +0200) count: 138 138 elapsed-time: 116.4 157.1 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: chrony-4.2/addrfilt.c:354:23: style:inconclusive: Function 'ADF_IsAllowed' argument 2 names different: declaration 'ip' definition 'ip_addr'. [funcArgNamesDifferent] chrony-4.2/addrfilt.h:73:34: note: Function 'ADF_IsAllowed' argument 2 names different: declaration 'ip' definition 'ip_addr'. chrony-4.2/addrfilt.c:354:23: note: Function 'ADF_IsAllowed' argument 2 names different: declaration 'ip' definition 'ip_addr'. chrony-4.2/addrfilt.c:74:22: style: Parameter 'addr' can be declared as pointer to const [constParameter] chrony-4.2/clientlog.c:471:51: style: Condition '(int32_t)interval<0' is always false [knownConditionTrueFalse] chrony-4.2/clientlog.c:469:21: note: Assignment 'interval=now_ts-prev_hit', assigned value is greater than -1 chrony-4.2/clientlog.c:469:12: note: interval is assigned 'now_ts-prev_hit' here. chrony-4.2/clientlog.c:471:51: note: Condition '(int32_t)interval<0' is always false chrony-4.2/clientlog.c:339:22: style: Variable '*tokens_per_packet' is reassigned a value before the old one has been used. [redundantAssignment] chrony-4.2/clientlog.c:335:24: note: *tokens_per_packet is assigned chrony-4.2/clientlog.c:339:22: note: *tokens_per_packet is overwritten chrony-4.2/clientlog.c:588:31: style: Clarify calculation precedence for '%' and '?'. [clarifyCalculation] chrony-4.2/clientlog.c:521:19: style: Parameter 'record' can be declared as pointer to const [constParameter] chrony-4.2/md5.c:219:8: style: Parameter 'in' can be declared as pointer to const [constParameter] getdate.c:1101:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] getdate.y:906:9: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] getdate.y:1004:24: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] getdate.c:1185:3: style: The comparison '0 <= gd_state' is always true. [knownConditionTrueFalse] getdate.c:1128:31: note: 'gd_state' is assigned value '0' here. getdate.c:1185:3: note: The comparison '0 <= gd_state' is always true. getdate.c:1101:11: style: Variable 'yymsg' is assigned a value that is never used. [unreadVariable] chrony-4.2/local.c:371:37: style:inconclusive: Function 'LCL_ReadCookedTime' argument 1 names different: declaration 'ts' definition 'result'. [funcArgNamesDifferent] chrony-4.2/local.h:46:49: note: Function 'LCL_ReadCookedTime' argument 1 names different: declaration 'ts' definition 'result'. chrony-4.2/local.c:371:37: note: Function 'LCL_ReadCookedTime' argument 1 names different: declaration 'ts' definition 'result'. chrony-4.2/local.c:449:33: style:inconclusive: Function 'LCL_SetAbsoluteFrequency' argument 1 names different: declaration 'afreq' definition 'afreq_ppm'. [funcArgNamesDifferent] chrony-4.2/local.h:136:45: note: Function 'LCL_SetAbsoluteFrequency' argument 1 names different: declaration 'afreq' definition 'afreq_ppm'. chrony-4.2/local.c:449:33: note: Function 'LCL_SetAbsoluteFrequency' argument 1 names different: declaration 'afreq' definition 'afreq_ppm'. chrony-4.2/local.c:248:66: style: Parameter 'handler' can be declared as pointer to const [constParameter] chrony-4.2/local.c:248:81: style: Parameter 'anything' can be declared as pointer to const [constParameter] chrony-4.2/local.c:276:62: style: Parameter 'handler' can be declared as pointer to const [constParameter] chrony-4.2/local.c:325:68: style: Parameter 'handler' can be declared as pointer to const [constParameter] chrony-4.2/local.c:325:83: style: Parameter 'anything' can be declared as pointer to const [constParameter] chrony-4.2/logging.c:147:10: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] chrony-4.2/main.c:595:8: portability: Non reentrant function 'getpwnam' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwnam_r'. [prohibitedgetpwnamCalled] chrony-4.2/main.c:374:11: error: Return value of allocation function 'open' is not stored. [leakReturnValNotUsed] chrony-4.2/main.c:375:11: error: Return value of allocation function 'open' is not stored. [leakReturnValNotUsed] chrony-4.2/main.c:376:11: error: Return value of allocation function 'open' is not stored. [leakReturnValNotUsed] chrony-4.2/nameserv_async.c:129:0: error: #error [preprocessorErrorDirective] chrony-4.2/ntp_io_linux.c:263:39: style: Parameter 'conf_iface_all' can be declared as pointer to const [constParameter] chrony-4.2/ntp_signd.c:293:43: style: Parameter 'remote_addr' can be declared as pointer to const [constParameter] chrony-4.2/ntp_signd.c:293:75: style: Parameter 'local_addr' can be declared as pointer to const [constParameter] chrony-4.2/ntp_sources.c:1276:52: style:inconclusive: Function 'NSR_ModifyMaxdelaydevratio' argument 2 names different: declaration 'new_max_delay_ratio' definition 'new_max_delay_dev_ratio'. [funcArgNamesDifferent] chrony-4.2/ntp_sources.h:134:63: note: Function 'NSR_ModifyMaxdelaydevratio' argument 2 names different: declaration 'new_max_delay_ratio' definition 'new_max_delay_dev_ratio'. chrony-4.2/ntp_sources.c:1276:52: note: Function 'NSR_ModifyMaxdelaydevratio' argument 2 names different: declaration 'new_max_delay_ratio' definition 'new_max_delay_dev_ratio'. chrony-4.2/ntp_sources.c:487:60: style: Parameter 'ip_addrs' can be declared as pointer to const [constParameter] chrony-4.2/nts_ke_client.c:289:32: style: Parameter 'address' can be declared as pointer to const [constParameter] chrony-4.2/nts_ke_session.c:646:58: style: Parameter 'trusted_certs_ids' can be declared as pointer to const [constParameter] chrony-4.2/nts_ntp_client.c:175:56: style: Parameter 'negotiated_address' can be declared as pointer to const [constParameter] chrony-4.2/nts_ntp_client.c:523:46: style: Parameter 'address' can be declared as pointer to const [constParameter] chrony-4.2/privops.c:73:13: style: struct member 'ReqBindSocket::sa_len' is never used. [unusedStructMember] chrony-4.2/privops.c:74:23: style: struct member 'ReqBindSocket::sa' is never used. [unusedStructMember] chrony-4.2/privops.c:78:8: style: struct member 'ReqName2IPAddress::name' is never used. [unusedStructMember] chrony-4.2/privops.c:84:19: style: union member 'Anonymous10::adjust_time' is never used. [unusedStructMember] chrony-4.2/privops.c:88:16: style: union member 'Anonymous10::set_time' is never used. [unusedStructMember] chrony-4.2/privops.c:109:10: style: struct member 'ResName2IPAddress::addresses' is never used. [unusedStructMember] chrony-4.2/privops.c:122:19: style: union member 'Anonymous11::adjust_time' is never used. [unusedStructMember] chrony-4.2/refclock.c:428:59: style: Parameter 'sample_time' can be declared as pointer to const [constParameter] chrony-4.2/refclock.c:53:10: style: struct member 'FilterSample::offset' is never used. [unusedStructMember] chrony-4.2/refclock.c:54:10: style: struct member 'FilterSample::dispersion' is never used. [unusedStructMember] chrony-4.2/refclock.c:55:19: style: struct member 'FilterSample::sample_time' is never used. [unusedStructMember] chrony-4.2/refclock.c:59:7: style: struct member 'MedianFilter::length' is never used. [unusedStructMember] chrony-4.2/refclock.c:60:7: style: struct member 'MedianFilter::index' is never used. [unusedStructMember] chrony-4.2/refclock.c:61:7: style: struct member 'MedianFilter::used' is never used. [unusedStructMember] chrony-4.2/refclock.c:62:7: style: struct member 'MedianFilter::last' is never used. [unusedStructMember] chrony-4.2/refclock.c:63:7: style: struct member 'MedianFilter::avg_var_n' is never used. [unusedStructMember] chrony-4.2/refclock.c:64:10: style: struct member 'MedianFilter::avg_var' is never used. [unusedStructMember] chrony-4.2/refclock.c:65:10: style: struct member 'MedianFilter::max_var' is never used. [unusedStructMember] chrony-4.2/refclock.c:66:24: style: struct member 'MedianFilter::samples' is never used. [unusedStructMember] chrony-4.2/refclock.c:67:8: style: struct member 'MedianFilter::selected' is never used. [unusedStructMember] chrony-4.2/refclock.c:68:11: style: struct member 'MedianFilter::x_data' is never used. [unusedStructMember] chrony-4.2/refclock.c:69:11: style: struct member 'MedianFilter::y_data' is never used. [unusedStructMember] chrony-4.2/refclock.c:70:11: style: struct member 'MedianFilter::w_data' is never used. [unusedStructMember] chrony-4.2/refclock_sock.c:55:7: style: struct member 'sock_sample::_pad' is never used. [unusedStructMember] chrony-4.2/regress.c:392:24: style: Condition 'index>r' is always true [knownConditionTrueFalse] chrony-4.2/regress.c:388:17: note: Assuming that condition 'index==r' is not redundant chrony-4.2/regress.c:392:24: note: Condition 'index>r' is always true chrony-4.2/regress.c:41:10: style: Parameter 'x' can be declared as pointer to const [constParameter] chrony-4.2/regress.c:43:10: style: Parameter 'w' can be declared as pointer to const [constParameter] chrony-4.2/regress.c:42:10: style: Parameter 'y' can be declared as pointer to const [constParameter] chrony-4.2/regress.c:176:31: style: Parameter 'resid' can be declared as pointer to const [constParameter] chrony-4.2/regress.c:200:10: style: Parameter 'x' can be declared as pointer to const [constParameter] chrony-4.2/regress.c:202:10: style: Parameter 'w' can be declared as pointer to const [constParameter] chrony-4.2/regress.c:201:10: style: Parameter 'y' can be declared as pointer to const [constParameter] chrony-4.2/regress.c:456:10: style: Parameter 'y' can be declared as pointer to const [constParameter] chrony-4.2/regress.c:455:10: style: Parameter 'x' can be declared as pointer to const [constParameter] chrony-4.2/regress.c:657:10: style: Parameter 'x1' can be declared as pointer to const [constParameter] chrony-4.2/regress.c:658:10: style: Parameter 'x2' can be declared as pointer to const [constParameter] chrony-4.2/regress.c:659:10: style: Parameter 'y' can be declared as pointer to const [constParameter] chrony-4.2/reference.c:511:12: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] chrony-4.2/reference.c:580:9: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] chrony-4.2/reference.c:613:8: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] chrony-4.2/reference.c:316:27: style:inconclusive: Function 'REF_SetMode' argument 1 names different: declaration 'mode' definition 'new_mode'. [funcArgNamesDifferent] chrony-4.2/reference.h:61:34: note: Function 'REF_SetMode' argument 1 names different: declaration 'mode' definition 'new_mode'. chrony-4.2/reference.c:316:27: note: Function 'REF_SetMode' argument 1 names different: declaration 'mode' definition 'new_mode'. chrony-4.2/reference.c:1181:12: style:inconclusive: Function 'REF_GetReferenceParams' argument 3 names different: declaration 'leap' definition 'leap_status'. [funcArgNamesDifferent] chrony-4.2/reference.h:104:12: note: Function 'REF_GetReferenceParams' argument 3 names different: declaration 'leap' definition 'leap_status'. chrony-4.2/reference.c:1181:12: note: Function 'REF_GetReferenceParams' argument 3 names different: declaration 'leap' definition 'leap_status'. chrony-4.2/reference.c:965:43: style: Parameter 'ref_ip' can be declared as pointer to const [constParameter] chrony-4.2/rtc_linux.c:303:12: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] chrony-4.2/rtc_linux.c:305:12: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] chrony-4.2/rtc_linux.c:354:21: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] chrony-4.2/rtc_linux.c:354:35: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] chrony-4.2/rtc_linux.c:920:30: style:inconclusive: Function 'RTC_Linux_TimePreInit' argument 1 names different: declaration 'driftile_time' definition 'driftfile_time'. [funcArgNamesDifferent] chrony-4.2/rtc_linux.h:33:41: note: Function 'RTC_Linux_TimePreInit' argument 1 names different: declaration 'driftile_time' definition 'driftfile_time'. chrony-4.2/rtc_linux.c:920:30: note: Function 'RTC_Linux_TimePreInit' argument 1 names different: declaration 'driftile_time' definition 'driftfile_time'. chrony-4.2/rtc_linux.c:922:7: style: Local variable 'fd' shadows outer variable [shadowVariable] chrony-4.2/rtc_linux.c:67:12: note: Shadowed declaration chrony-4.2/rtc_linux.c:922:7: note: Shadow variable chrony-4.2/rtc_linux.c:177:48: style: Parameter 'sys' can be declared as pointer to const [constParameter] chrony-4.2/rtc_linux.c:344:23: style: Parameter 'stm' can be declared as pointer to const [constParameter] chrony-4.2/sched.c:323:33: style: Parameter 'ts' can be declared as pointer to const [constParameter] chrony-4.2/ntp_core.c:706:32: style:inconclusive: Function 'NCR_ResetInstance' argument 1 names different: declaration 'inst' definition 'instance'. [funcArgNamesDifferent] chrony-4.2/ntp_core.h:72:44: note: Function 'NCR_ResetInstance' argument 1 names different: declaration 'inst' definition 'instance'. chrony-4.2/ntp_core.c:706:32: note: Function 'NCR_ResetInstance' argument 1 names different: declaration 'inst' definition 'instance'. chrony-4.2/ntp_core.c:2857:35: style:inconclusive: Function 'NCR_GetRemoteAddress' argument 1 names different: declaration 'instance' definition 'inst'. [funcArgNamesDifferent] chrony-4.2/ntp_core.h:134:62: note: Function 'NCR_GetRemoteAddress' argument 1 names different: declaration 'instance' definition 'inst'. chrony-4.2/ntp_core.c:2857:35: note: Function 'NCR_GetRemoteAddress' argument 1 names different: declaration 'instance' definition 'inst'. chrony-4.2/ntp_core.c:2872:33: style:inconclusive: Function 'NCR_IsSyncPeer' argument 1 names different: declaration 'instance' definition 'inst'. [funcArgNamesDifferent] chrony-4.2/ntp_core.h:138:40: note: Function 'NCR_IsSyncPeer' argument 1 names different: declaration 'instance' definition 'inst'. chrony-4.2/ntp_core.c:2872:33: note: Function 'NCR_IsSyncPeer' argument 1 names different: declaration 'instance' definition 'inst'. chrony-4.2/ntp_core.c:1391:29: style: Parameter 'data' can be declared as pointer to const [constParameter] chrony-4.2/ntp_core.c:2913:49: style: Parameter 'addr' can be declared as pointer to const [constParameter] chrony-4.2/siv_nettle_int.c:172:24: style: Local variable 'const_zero' shadows outer variable [shadowVariable] chrony-4.2/siv_nettle_int.c:324:22: note: Shadowed declaration chrony-4.2/siv_nettle_int.c:172:24: note: Shadow variable chrony-4.2/smooth.c:300:31: style: Parameter 'now' can be declared as pointer to const [constParameter] chrony-4.2/smooth.c:312:28: style: Parameter 'now' can be declared as pointer to const [constParameter] chrony-4.2/socket.c:65:13: style: struct member 'Anonymous8::l234_headers' is never used. [unusedStructMember] chrony-4.2/socket.c:71:7: style: struct member 'Anonymous8::msg' is never used. [unusedStructMember] chrony-4.2/socket.c:67:18: style: union member 'Anonymous9::ntp_msg' is never used. [unusedStructMember] chrony-4.2/socket.c:68:22: style: union member 'Anonymous9::ptp_msg' is never used. [unusedStructMember] chrony-4.2/socket.c:69:19: style: union member 'Anonymous9::cmd_request' is never used. [unusedStructMember] chrony-4.2/socket.c:70:17: style: union member 'Anonymous9::cmd_reply' is never used. [unusedStructMember] chrony-4.2/sourcestats.c:765:8: style: Variable 'prev' is reassigned a value before the old one has been used. [redundantAssignment] chrony-4.2/sourcestats.c:759:10: note: prev is assigned chrony-4.2/sourcestats.c:765:8: note: prev is overwritten chrony-4.2/sourcestats.c:652:30: style:inconclusive: Function 'SST_GetSelectionData' argument 6 names different: declaration 'variance' definition 'std_dev'. [funcArgNamesDifferent] chrony-4.2/sourcestats.h:75:30: note: Function 'SST_GetSelectionData' argument 6 names different: declaration 'variance' definition 'std_dev'. chrony-4.2/sourcestats.c:652:30: note: Function 'SST_GetSelectionData' argument 6 names different: declaration 'variance' definition 'std_dev'. chrony-4.2/sourcestats.c:373:48: style: Parameter 'times_back' can be declared as pointer to const [constParameter] chrony-4.2/sys.c:72:0: error: #error Unknown system [preprocessorErrorDirective] chrony-4.2/stubs.c:306:52: style:inconclusive: Function 'NSR_ModifyMaxdelaydevratio' argument 2 names different: declaration 'new_max_delay_ratio' definition 'new_max_delay_dev_ratio'. [funcArgNamesDifferent] chrony-4.2/ntp_sources.h:134:63: note: Function 'NSR_ModifyMaxdelaydevratio' argument 2 names different: declaration 'new_max_delay_ratio' definition 'new_max_delay_dev_ratio'. chrony-4.2/stubs.c:306:52: note: Function 'NSR_ModifyMaxdelaydevratio' argument 2 names different: declaration 'new_max_delay_ratio' definition 'new_max_delay_dev_ratio'. chrony-4.2/sys_generic.c:109:30: style: Parameter 'raw' can be declared as pointer to const [constParameter] chrony-4.2/sys_linux.c:281:7: style: Condition '!hz' is always true [knownConditionTrueFalse] chrony-4.2/sys_linux.c:279:14: note: Assignment 'hz=get_hz()', assigned value is 0 chrony-4.2/sys_linux.c:281:7: note: Condition '!hz' is always true chrony-4.2/sources.c:380:31: style:inconclusive: Function 'SRC_UpdateStatus' argument 1 names different: declaration 'instance' definition 'inst'. [funcArgNamesDifferent] chrony-4.2/sources.h:91:43: note: Function 'SRC_UpdateStatus' argument 1 names different: declaration 'instance' definition 'inst'. chrony-4.2/sources.c:380:31: note: Function 'SRC_UpdateStatus' argument 1 names different: declaration 'instance' definition 'inst'. chrony-4.2/sources.c:404:35: style:inconclusive: Function 'SRC_AccumulateSample' argument 1 names different: declaration 'instance' definition 'inst'. [funcArgNamesDifferent] chrony-4.2/sources.h:94:47: note: Function 'SRC_AccumulateSample' argument 1 names different: declaration 'instance' definition 'inst'. chrony-4.2/sources.c:404:35: note: Function 'SRC_AccumulateSample' argument 1 names different: declaration 'instance' definition 'inst'. chrony-4.2/test/unit/addrfilt.c:21:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/test/unit/addrfilt.c:24:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/test/unit/hwclock.c:21:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/test/unit/hwclock.c:22:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/test/unit/regress.c:20:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/test/unit/regress.c:21:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/test/unit/samplefilt.c:22:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/test/unit/samplefilt.c:26:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/test/unit/smooth.c:21:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/test/unit/smooth.c:22:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/test/unit/sources.c:21:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/test/unit/sources.c:22:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/util.c:562:9: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] chrony-4.2/util.c:1492:9: warning: %hhX in format string (no. 1) requires 'unsigned char' but the argument type is 'char'. [invalidPrintfArgType_uint] chrony-4.2/util.c:253:36: style:inconclusive: Function 'UTI_Ntp64ToString' argument 1 names different: declaration 'ts' definition 'ntp_ts'. [funcArgNamesDifferent] chrony-4.2/util.h:103:49: note: Function 'UTI_Ntp64ToString' argument 1 names different: declaration 'ts' definition 'ntp_ts'. chrony-4.2/util.c:253:36: note: Function 'UTI_Ntp64ToString' argument 1 names different: declaration 'ts' definition 'ntp_ts'. chrony-4.2/util.c:284:30: style:inconclusive: Function 'UTI_IPToString' argument 1 names different: declaration 'ip' definition 'addr'. [funcArgNamesDifferent] chrony-4.2/util.h:109:43: note: Function 'UTI_IPToString' argument 1 names different: declaration 'ip' definition 'addr'. chrony-4.2/util.c:284:30: note: Function 'UTI_IPToString' argument 1 names different: declaration 'ip' definition 'addr'. chrony-4.2/util.c:900:30: style:inconclusive: Function 'UTI_FloatNetworkToHost' argument 1 names different: declaration 'x' definition 'f'. [funcArgNamesDifferent] chrony-4.2/util.h:173:44: note: Function 'UTI_FloatNetworkToHost' argument 1 names different: declaration 'x' definition 'f'. chrony-4.2/util.c:900:30: note: Function 'UTI_FloatNetworkToHost' argument 1 names different: declaration 'x' definition 'f'. chrony-4.2/test/unit/util.c:21:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/test/unit/util.c:22:0: error: #include nested too deeply [preprocessorErrorDirective] chrony-4.2/client.c:1620:43: warning: Either the condition 'i>=sizeof(buf)' is redundant or the array 'format[29]' is accessed at index 255, which is out of bounds. [arrayIndexOutOfBoundsCond] chrony-4.2/client.c:1623:11: note: Assuming that condition 'i>=sizeof(buf)' is not redundant chrony-4.2/client.c:1620:43: note: Array index out of bounds chrony-4.2/client.c:1620:63: warning: Either the condition 'i0' is always false [knownConditionTrueFalse] chrony-4.2/client.c:3027:17: note: Assignment 'cmac_length=0', assigned value is 0 chrony-4.2/client.c:3032:26: note: Condition 'cmac_length>0' is always false chrony-4.2/client.c:1705:44: style: Clarify calculation precedence for '^' and '?'. [clarifyCalculation] chrony-4.2/conf.c:381:20: style:inconclusive: Function 'CNF_Initialise' argument 1 names different: declaration 'restarted' definition 'r'. [funcArgNamesDifferent] chrony-4.2/conf.h:35:32: note: Function 'CNF_Initialise' argument 1 names different: declaration 'restarted' definition 'r'. chrony-4.2/conf.c:381:20: note: Function 'CNF_Initialise' argument 1 names different: declaration 'restarted' definition 'r'. chrony-4.2/conf.c:863:48: style: Local variable 'min_samples' shadows outer variable [shadowVariable] chrony-4.2/conf.c:168:12: note: Shadowed declaration chrony-4.2/conf.c:863:48: note: Shadow variable chrony-4.2/conf.c:863:61: style: Local variable 'max_samples' shadows outer variable [shadowVariable] chrony-4.2/conf.c:167:12: note: Shadowed declaration chrony-4.2/conf.c:863:61: note: Shadow variable diff: head chrony-4.2/addrfilt.c:74:22: style: Parameter 'addr' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/addrfilt.c:74:22: style: Parameter 'addr' can be declared with const [constParameter] head chrony-4.2/clientlog.c:521:19: style: Parameter 'record' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/clientlog.c:521:19: style: Parameter 'record' can be declared with const [constParameter] head chrony-4.2/local.c:248:66: style: Parameter 'handler' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/local.c:248:66: style: Parameter 'handler' can be declared with const [constParameter] head chrony-4.2/local.c:248:81: style: Parameter 'anything' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/local.c:248:81: style: Parameter 'anything' can be declared with const [constParameter] head chrony-4.2/local.c:276:62: style: Parameter 'handler' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/local.c:276:62: style: Parameter 'handler' can be declared with const [constParameter] head chrony-4.2/local.c:325:68: style: Parameter 'handler' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/local.c:325:68: style: Parameter 'handler' can be declared with const [constParameter] head chrony-4.2/local.c:325:83: style: Parameter 'anything' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/local.c:325:83: style: Parameter 'anything' can be declared with const [constParameter] head chrony-4.2/md5.c:219:8: style: Parameter 'in' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/md5.c:219:8: style: Parameter 'in' can be declared with const [constParameter] head chrony-4.2/ntp_core.c:1391:29: style: Parameter 'data' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/ntp_core.c:1391:29: style: Parameter 'data' can be declared with const [constParameter] head chrony-4.2/ntp_core.c:2913:49: style: Parameter 'addr' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/ntp_core.c:2913:49: style: Parameter 'addr' can be declared with const [constParameter] head chrony-4.2/ntp_io_linux.c:263:39: style: Parameter 'conf_iface_all' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/ntp_io_linux.c:263:39: style: Parameter 'conf_iface_all' can be declared with const [constParameter] head chrony-4.2/ntp_signd.c:293:43: style: Parameter 'remote_addr' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/ntp_signd.c:293:43: style: Parameter 'remote_addr' can be declared with const [constParameter] head chrony-4.2/ntp_signd.c:293:75: style: Parameter 'local_addr' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/ntp_signd.c:293:75: style: Parameter 'local_addr' can be declared with const [constParameter] head chrony-4.2/ntp_sources.c:487:60: style: Parameter 'ip_addrs' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/ntp_sources.c:487:60: style: Parameter 'ip_addrs' can be declared with const [constParameter] head chrony-4.2/nts_ke_client.c:289:32: style: Parameter 'address' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/nts_ke_client.c:289:32: style: Parameter 'address' can be declared with const [constParameter] head chrony-4.2/nts_ke_session.c:646:58: style: Parameter 'trusted_certs_ids' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/nts_ke_session.c:646:58: style: Parameter 'trusted_certs_ids' can be declared with const [constParameter] head chrony-4.2/nts_ntp_client.c:175:56: style: Parameter 'negotiated_address' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/nts_ntp_client.c:175:56: style: Parameter 'negotiated_address' can be declared with const [constParameter] head chrony-4.2/nts_ntp_client.c:523:46: style: Parameter 'address' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/nts_ntp_client.c:523:46: style: Parameter 'address' can be declared with const [constParameter] head chrony-4.2/refclock.c:428:59: style: Parameter 'sample_time' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/refclock.c:428:59: style: Parameter 'sample_time' can be declared with const [constParameter] head chrony-4.2/reference.c:965:43: style: Parameter 'ref_ip' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/reference.c:965:43: style: Parameter 'ref_ip' can be declared with const [constParameter] head chrony-4.2/regress.c:176:31: style: Parameter 'resid' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/regress.c:176:31: style: Parameter 'resid' can be declared with const [constParameter] head chrony-4.2/regress.c:200:10: style: Parameter 'x' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/regress.c:200:10: style: Parameter 'x' can be declared with const [constParameter] head chrony-4.2/regress.c:201:10: style: Parameter 'y' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/regress.c:201:10: style: Parameter 'y' can be declared with const [constParameter] head chrony-4.2/regress.c:202:10: style: Parameter 'w' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/regress.c:202:10: style: Parameter 'w' can be declared with const [constParameter] head chrony-4.2/regress.c:41:10: style: Parameter 'x' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/regress.c:41:10: style: Parameter 'x' can be declared with const [constParameter] head chrony-4.2/regress.c:42:10: style: Parameter 'y' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/regress.c:42:10: style: Parameter 'y' can be declared with const [constParameter] head chrony-4.2/regress.c:43:10: style: Parameter 'w' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/regress.c:43:10: style: Parameter 'w' can be declared with const [constParameter] head chrony-4.2/regress.c:455:10: style: Parameter 'x' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/regress.c:455:10: style: Parameter 'x' can be declared with const [constParameter] head chrony-4.2/regress.c:456:10: style: Parameter 'y' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/regress.c:456:10: style: Parameter 'y' can be declared with const [constParameter] head chrony-4.2/regress.c:657:10: style: Parameter 'x1' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/regress.c:657:10: style: Parameter 'x1' can be declared with const [constParameter] head chrony-4.2/regress.c:658:10: style: Parameter 'x2' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/regress.c:658:10: style: Parameter 'x2' can be declared with const [constParameter] head chrony-4.2/regress.c:659:10: style: Parameter 'y' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/regress.c:659:10: style: Parameter 'y' can be declared with const [constParameter] head chrony-4.2/rtc_linux.c:177:48: style: Parameter 'sys' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/rtc_linux.c:177:48: style: Parameter 'sys' can be declared with const [constParameter] head chrony-4.2/rtc_linux.c:344:23: style: Parameter 'stm' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/rtc_linux.c:344:23: style: Parameter 'stm' can be declared with const [constParameter] head chrony-4.2/sched.c:323:33: style: Parameter 'ts' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/sched.c:323:33: style: Parameter 'ts' can be declared with const [constParameter] head chrony-4.2/smooth.c:300:31: style: Parameter 'now' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/smooth.c:300:31: style: Parameter 'now' can be declared with const [constParameter] head chrony-4.2/smooth.c:312:28: style: Parameter 'now' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/smooth.c:312:28: style: Parameter 'now' can be declared with const [constParameter] head chrony-4.2/sourcestats.c:373:48: style: Parameter 'times_back' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/sourcestats.c:373:48: style: Parameter 'times_back' can be declared with const [constParameter] head chrony-4.2/sys_generic.c:109:30: style: Parameter 'raw' can be declared as pointer to const [constParameter] 2.8 chrony-4.2/sys_generic.c:109:30: style: Parameter 'raw' can be declared with const [constParameter] DONE