2025-12-26 17:00 ftp://ftp.de.debian.org/debian/pool/main/a/ayatana-indicator-display/ayatana-indicator-display_24.5.2.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=bsd --library=gtk --library=motif --library=googletest --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j1 platform: Linux-6.8.0-90-generic-x86_64-with-glibc2.39 python: 3.12.3 client-version: 1.3.69 compiler: g++ (Ubuntu 14.2.0-4ubuntu2~24.04) 14.2.0 cppcheck: head 2.19.0 head-info: a5ec929 (2025-12-24 09:21:38 +0100) count: 20 20 elapsed-time: 0.1 0.3 head-timing-info: old-timing-info: head results: ayatana-indicator-display-24.5.2/src/exporter.cpp:32:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_BUS_TYPE_SESSION [valueFlowBailoutIncompleteVar] ayatana-indicator-display-24.5.2/src/exporter.cpp:82:44: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] ayatana-indicator-display-24.5.2/src/exporter.cpp:116:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] ayatana-indicator-display-24.5.2/src/main.cpp:47:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_TYPE_DBUS_CONNECTION [valueFlowBailoutIncompleteVar] ayatana-indicator-display-24.5.2/src/service.cpp:1061:15: style: The member function 'Impl::create_phone_menu' can be static. [functionStatic] ayatana-indicator-display-24.5.2/src/service.cpp:180:17: warning: Class 'Impl' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] ayatana-indicator-display-24.5.2/src/service.cpp:180:17: warning: Class 'Impl' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] ayatana-indicator-display-24.5.2/src/service.cpp:312:53: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] ayatana-indicator-display-24.5.2/src/service.cpp:316:64: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] ayatana-indicator-display-24.5.2/src/service.cpp:985:20: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] ayatana-indicator-display-24.5.2/src/service.cpp:1046:25: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] ayatana-indicator-display-24.5.2/src/service.cpp:1069:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] ayatana-indicator-display-24.5.2/src/service.cpp:1106:37: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] ayatana-indicator-display-24.5.2/src/service.cpp:1203:42: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] ayatana-indicator-display-24.5.2/src/service.cpp:1217:15: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] ayatana-indicator-display-24.5.2/src/service.cpp:1228:15: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] ayatana-indicator-display-24.5.2/src/service.cpp:1229:17: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] ayatana-indicator-display-24.5.2/src/service.cpp:1079:42: style: Parameter 'pAction' can be declared as pointer to const. However it seems that 'onSettings' is a callback function, if 'pAction' is declared with const you might also need to cast function pointer(s). [constParameterCallback] ayatana-indicator-display-24.5.2/src/service.cpp:1045:9: note: You might need to cast the function pointer here ayatana-indicator-display-24.5.2/src/service.cpp:1079:42: note: Parameter 'pAction' can be declared as pointer to const ayatana-indicator-display-24.5.2/src/service.cpp:1079:61: style: Parameter 'pVariant' can be declared as pointer to const. However it seems that 'onSettings' is a callback function, if 'pVariant' is declared with const you might also need to cast function pointer(s). [constParameterCallback] ayatana-indicator-display-24.5.2/src/service.cpp:1045:9: note: You might need to cast the function pointer here ayatana-indicator-display-24.5.2/src/service.cpp:1079:61: note: Parameter 'pVariant' can be declared as pointer to const ayatana-indicator-display-24.5.2/src/service.cpp:1079:80: style: Parameter 'pData' can be declared as pointer to const. However it seems that 'onSettings' is a callback function, if 'pData' is declared with const you might also need to cast function pointer(s). [constParameterCallback] ayatana-indicator-display-24.5.2/src/service.cpp:1045:9: note: You might need to cast the function pointer here ayatana-indicator-display-24.5.2/src/service.cpp:1079:80: note: Parameter 'pData' can be declared as pointer to const diff: DONE