2024-03-26 10:32 ftp://ftp.de.debian.org/debian/pool/main/a/aptitude/aptitude_0.8.13.orig.tar.xz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --inline-suppr --disable=missingInclude --suppress=unmatchedSuppression --template=daca2 --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=valueFlowBailoutIncompleteVar -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.1.0-0.deb11.6-amd64-x86_64-with-glibc2.31 python: 3.9.2 client-version: 1.3.45 compiler: g++ (Debian 10.2.1-6) 10.2.1 20210110 cppcheck: head 2.13.0 head-info: 82f05c8 (2024-03-25 22:58:58 +0100) count: 1157 1064 elapsed-time: 4.8 3.3 head-timing-info: Tokenizer::simplifyTokens1::ValueFlow: 0.802202s (avg. 0.802202s - 1 result(s)) valueFlowContainerSize(tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 0.733113s (avg. 0.244371s - 3 result(s)) valueFlowAfterAssign(tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 0.043635s (avg. 0.014545s - 3 result(s)) valueFlowSymbolic(tokenlist, symboldatabase, errorLogger, settings): 0.013463s (avg. 0.013463s - 1 result(s)) Tokenizer::simplifyTokens1::simplifyTokenList1: 0.007557s (avg. 0.007557s - 1 result(s)) Overall time: 0.837665s old-timing-info: Tokenizer::simplifyTokens1::createSymbolDatabase: 0.019013s (avg. 0.019013s - 1 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 0.018637s (avg. 0.018637s - 1 result(s)) Tokenizer::simplifyTokens1::simplifyTokenList1: 0.014292s (avg. 0.014292s - 1 result(s)) Tokenizer::simplifyTokens1::setValueType: 0.013554s (avg. 0.013554s - 1 result(s)) Check function usage::runChecks: 0.00658s (avg. 0.00658s - 1 result(s)) Overall time: 0.096371s head results: aptitude-0.8.13/src/apt_config_widgets.h:69:8: style: The function 'commit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/apt_config_widgets.h:52:16: note: Virtual function in base class aptitude-0.8.13/src/apt_config_widgets.h:69:8: note: Function in derived class aptitude-0.8.13/src/apt_config_widgets.h:87:8: style: The function 'commit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/apt_config_widgets.h:52:16: note: Virtual function in base class aptitude-0.8.13/src/apt_config_widgets.h:87:8: note: Function in derived class aptitude-0.8.13/src/apt_config_widgets.h:109:8: style: The function 'commit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/apt_config_widgets.h:52:16: note: Virtual function in base class aptitude-0.8.13/src/apt_config_widgets.h:109:8: note: Function in derived class aptitude-0.8.13/src/apt_config_widgets.cc:87:10: style: The scope of the variable 'choice' can be reduced. [variableScope] aptitude-0.8.13/src/apt_config_widgets.cc:79:30: style:inconclusive: Function 'apt_radio_widget' argument 2 names different: declaration 'choices' definition '_choices'. [funcArgNamesDifferent] aptitude-0.8.13/src/apt_config_widgets.h:103:38: note: Function 'apt_radio_widget' argument 2 names different: declaration 'choices' definition '_choices'. aptitude-0.8.13/src/apt_config_widgets.cc:79:30: note: Function 'apt_radio_widget' argument 2 names different: declaration 'choices' definition '_choices'. aptitude-0.8.13/src/apt_undo_tree.h:40:41: warning: The class 'apt_undo_tree' defines member function with name 'create' also defined in its parent class 'menu_tree'. [duplInheritedMember] aptitude-0.8.13/src/menu_tree.h:103:44: note: Parent function 'menu_tree::create' aptitude-0.8.13/src/apt_undo_tree.h:40:41: note: Derived function 'apt_undo_tree::create' aptitude-0.8.13/src/menu_tree.h:110:4: style: The destructor '~menu_tree' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:165:12: note: Virtual destructor in base class aptitude-0.8.13/src/menu_tree.h:110:4: note: Destructor in derived class aptitude-0.8.13/src/menu_tree.h:113:8: style: The function 'package_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:45:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:113:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:116:8: style: The function 'package_install' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:51:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:116:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:119:8: style: The function 'package_reinstall' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:57:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:119:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:122:8: style: The function 'package_remove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:60:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:122:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:125:8: style: The function 'package_purge' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:63:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:125:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:128:8: style: The function 'package_keep' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:69:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:128:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:131:8: style: The function 'package_hold' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:66:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:131:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:134:8: style: The function 'package_mark_auto' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:72:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:134:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:137:8: style: The function 'package_unmark_auto' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:75:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:137:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:140:8: style: The function 'package_forbid_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:78:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:140:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:145:8: style: The function 'package_forbid' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:83:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:145:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:148:8: style: The function 'package_changelog_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:94:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:148:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:151:8: style: The function 'package_changelog' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:97:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:151:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:154:8: style: The function 'package_information_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:86:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:154:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:157:8: style: The function 'package_information' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:91:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:157:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:161:8: style: The function 'resolver_toggle_rejected' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:107:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:161:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:164:8: style: The function 'resolver_toggle_rejected_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:110:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:164:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:167:8: style: The function 'resolver_toggle_approved' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:101:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:167:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:170:8: style: The function 'resolver_toggle_approved_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:104:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:170:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:173:8: style: The function 'resolver_view_target' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:113:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:173:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:176:8: style: The function 'resolver_view_target_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:116:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:176:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:180:8: style: The function 'find_search_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:120:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:180:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:183:8: style: The function 'find_search_back_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:126:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:183:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:186:8: style: The function 'find_search' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:123:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:186:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:189:8: style: The function 'find_search_back' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:129:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:189:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:192:8: style: The function 'find_research_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:134:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:192:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:195:8: style: The function 'find_research' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:137:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:195:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:198:8: style: The function 'find_repeat_search_back_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:142:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:198:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:201:8: style: The function 'find_repeat_search_back' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:145:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:201:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:204:8: style: The function 'find_limit_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:148:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:204:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:207:8: style: The function 'find_limit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:151:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:207:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:210:8: style: The function 'find_reset_limit_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:154:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:210:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:213:8: style: The function 'find_reset_limit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:157:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:213:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:216:8: style: The function 'find_broken_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:160:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:216:8: note: Function in derived class aptitude-0.8.13/src/menu_tree.h:219:8: style: The function 'find_broken' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:163:16: note: Virtual function in base class aptitude-0.8.13/src/menu_tree.h:219:8: note: Function in derived class aptitude-0.8.13/src/apt_undo_tree.h:48:8: style: The function 'undo_undo_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:39:16: note: Virtual function in base class aptitude-0.8.13/src/apt_undo_tree.h:48:8: note: Function in derived class aptitude-0.8.13/src/apt_undo_tree.h:54:8: style: The function 'undo_undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:42:16: note: Virtual function in base class aptitude-0.8.13/src/apt_undo_tree.h:54:8: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:85:8: warning: The class 'pkg_item' defines member function with name 'dispatch_key' also defined in its parent class 'pkg_tree_node'. [duplInheritedMember] aptitude-0.8.13/src/pkg_node.h:67:8: note: Parent function 'pkg_tree_node::dispatch_key' aptitude-0.8.13/src/pkg_item.h:85:8: note: Derived function 'pkg_item::dispatch_key' aptitude-0.8.13/src/apt_options.cc:433:4: style: Class 'dummy_subtree' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/pkg_node.h:75:8: style: The function 'package_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:45:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_node.h:75:8: note: Function in derived class aptitude-0.8.13/src/pkg_node.h:76:8: style: The function 'package_install' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:51:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_node.h:76:8: note: Function in derived class aptitude-0.8.13/src/pkg_node.h:77:8: style: The function 'package_reinstall' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:57:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_node.h:77:8: note: Function in derived class aptitude-0.8.13/src/pkg_node.h:78:8: style: The function 'package_remove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:60:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_node.h:78:8: note: Function in derived class aptitude-0.8.13/src/pkg_node.h:79:8: style: The function 'package_purge' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:63:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_node.h:79:8: note: Function in derived class aptitude-0.8.13/src/pkg_node.h:80:8: style: The function 'package_hold' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:66:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_node.h:80:8: note: Function in derived class aptitude-0.8.13/src/pkg_node.h:81:8: style: The function 'package_keep' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:69:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_node.h:81:8: note: Function in derived class aptitude-0.8.13/src/pkg_node.h:82:8: style: The function 'package_mark_auto' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:72:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_node.h:82:8: note: Function in derived class aptitude-0.8.13/src/pkg_node.h:83:8: style: The function 'package_unmark_auto' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:75:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_node.h:83:8: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:67:16: style: The function 'select' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:54:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:67:16: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:68:16: style: The function 'hold' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:55:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:68:16: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:69:16: style: The function 'keep' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:56:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:69:16: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:70:16: style: The function 'remove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:57:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:70:16: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:71:16: style: The function 'purge' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:58:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:71:16: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:72:16: style: The function 'reinstall' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:59:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:72:16: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:73:16: style: The function 'set_auto' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:61:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:73:16: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:74:16: style: The function 'forbid_upgrade' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:62:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:74:16: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:97:8: style: The function 'package_forbid_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:78:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:97:8: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:98:8: style: The function 'package_forbid' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:83:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:98:8: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:99:8: style: The function 'package_changelog_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:94:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:99:8: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:100:8: style: The function 'package_changelog' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:97:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:100:8: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:101:8: style: The function 'package_information_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:86:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:101:8: note: Function in derived class aptitude-0.8.13/src/pkg_item.h:102:8: style: The function 'package_information' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:91:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item.h:102:8: note: Function in derived class aptitude-0.8.13/src/apt_options.cc:136:16: style: Local variable 'choice' shadows outer function [shadowFunction] aptitude-0.8.13/src/apt_options.cc:151:16: note: Shadowed declaration aptitude-0.8.13/src/apt_options.cc:136:16: note: Shadow variable aptitude-0.8.13/src/apt_options.cc:512:23: style: Variable 'configitem' can be declared as pointer to const [constVariablePointer] aptitude-0.8.13/src/apt_config_treeitems.cc:303:4: style: Class 'dummy_subtree' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/apt_config_treeitems.cc:94:16: style: The function 'get_long_description' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/apt_config_treeitems.h:55:29: note: Virtual function in base class aptitude-0.8.13/src/apt_config_treeitems.cc:94:16: note: Function in derived class aptitude-0.8.13/src/apt_config_treeitems.cc:203:18: style: The function 'get_long_description' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/apt_config_treeitems.h:55:29: note: Virtual function in base class aptitude-0.8.13/src/apt_config_treeitems.cc:203:18: note: Function in derived class aptitude-0.8.13/src/apt_config_treeitems.cc:372:16: style: The function 'get_long_description' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/apt_config_treeitems.h:55:29: note: Virtual function in base class aptitude-0.8.13/src/apt_config_treeitems.cc:372:16: note: Function in derived class aptitude-0.8.13/src/broken_indicator.cc:202:5: style: Struct 'update_event' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/broken_indicator.cc:360:17: style: Expression is always true because 'else if' condition is opposite to previous condition at line 358. [multiCondition] aptitude-0.8.13/src/broken_indicator.cc:358:12: note: first condition aptitude-0.8.13/src/broken_indicator.cc:360:17: note: else if condition is opposite to first condition aptitude-0.8.13/src/cmdline/cmdline_apt_proxy.cc:161:39: style: Parameter 'argv' can be declared as const array [constParameter] aptitude-0.8.13/src/cmdline/cmdline_apt_proxy.cc:201:7: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/cmdline/cmdline_util.h:219:2: performance: Variable 'tag' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] aptitude-0.8.13/src/cmdline/cmdline_util.h:220:2: performance: Variable 'pattern' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] aptitude-0.8.13/src/cmdline/cmdline_util.h:323:12: style:inconclusive: Technically the member function 'aptitude::cmdline::package_results_eq::operator()' can be const. [functionConst] aptitude-0.8.13/src/cmdline/cmdline_util.h:153:7: style: Class 'source_package' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/cmdline_util.h:301:7: style: Class 'package_results_lt' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/cmdline_util.h:338:7: style: Class 'compare_version_results3' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/cmdline_util.h:360:7: style: Class 'version_results_lt' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/cmdline_util.h:383:7: style: Class 'version_results_eq' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/cmdline_util.h:408:7: style: Class 'search_result_column_parameters' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/terminal.h:98:8: warning:inconclusive: Class 'terminal_input' which has virtual members does not have a virtual destructor. [virtualDestructor] aptitude-0.8.13/src/cmdline/terminal.h:124:8: warning:inconclusive: Class 'terminal_metrics' which has virtual members does not have a virtual destructor. [virtualDestructor] aptitude-0.8.13/src/cmdline/cmdline_clean.cc:125:3: style: Class 'LogCleaner' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/cmdline_changelog.cc:163:10: warning: The class 'changelog_download_callbacks' defines member function with name 'success' also defined in its parent class 'single_download_progress'. [duplInheritedMember] aptitude-0.8.13/src/cmdline/cmdline_changelog.cc:128:10: note: Parent function 'single_download_progress::success' aptitude-0.8.13/src/cmdline/cmdline_changelog.cc:163:10: note: Derived function 'changelog_download_callbacks::success' aptitude-0.8.13/src/cmdline/cmdline_changelog.cc:172:10: warning: The class 'changelog_download_callbacks' defines member function with name 'failure' also defined in its parent class 'single_download_progress'. [duplInheritedMember] aptitude-0.8.13/src/cmdline/cmdline_changelog.cc:138:10: note: Parent function 'single_download_progress::failure' aptitude-0.8.13/src/cmdline/cmdline_changelog.cc:172:10: note: Derived function 'changelog_download_callbacks::failure' aptitude-0.8.13/src/cmdline/cmdline_changelog.cc:106:29: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream] aptitude-0.8.13/src/cmdline/cmdline_download_progress_display.cc:287:14: performance:inconclusive: Technically the member function 'aptitude::cmdline::::dummy_status_display::display_status' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/cmdline/cmdline_download_progress_display.cc:295:34: note: Technically the member function 'aptitude::cmdline::::dummy_status_display::display_status' can be static (but you may consider moving to unnamed namespace). aptitude-0.8.13/src/cmdline/cmdline_download_progress_display.cc:287:14: note: Technically the member function 'aptitude::cmdline::::dummy_status_display::display_status' can be static (but you may consider moving to unnamed namespace). aptitude-0.8.13/src/cmdline/cmdline_download_progress_display.cc:379:9: style: Class 'append_worker_status' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/cmdline_extract_cache_subset.cc:55:46: style: Parameter 'argv' can be declared as const array [constParameter] aptitude-0.8.13/src/cmdline/cmdline_main_loop.cc:52:4: style: Class 'cancel_running_on_leave_scope' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/cmdline_moo.cc:11:33: style: Parameter 'argv' can be declared as const array [constParameter] aptitude-0.8.13/src/cmdline/cmdline_action.cc:306:24: style: Condition 'cands.size()==1' is always true [knownConditionTrueFalse] aptitude-0.8.13/src/cmdline/cmdline_action.cc:288:19: note: Assuming that condition 'cands.size()==0' is not redundant aptitude-0.8.13/src/cmdline/cmdline_action.cc:295:24: note: Assuming that condition 'cands.size()>1' is not redundant aptitude-0.8.13/src/cmdline/cmdline_action.cc:306:24: note: Condition 'cands.size()==1' is always true aptitude-0.8.13/src/cmdline/cmdline_mark.cc:318:11: style: Condition 'all_ok' is always true [knownConditionTrueFalse] aptitude-0.8.13/src/cmdline/cmdline_mark.cc:310:7: note: Assuming that condition '!all_ok' is not redundant aptitude-0.8.13/src/cmdline/cmdline_mark.cc:318:11: note: Condition 'all_ok' is always true aptitude-0.8.13/src/cmdline/cmdline_mark.cc:154:24: performance: Range variable 'pkgstr' should be declared as const reference. [iterateByValue] aptitude-0.8.13/src/cmdline/cmdline_action.cc:243:67: style:inconclusive: Function 'cmdline_applyaction' argument 14 names different: declaration 'term' definition 'term_metrics'. [funcArgNamesDifferent] aptitude-0.8.13/src/cmdline/cmdline_action.h:113:86: note: Function 'cmdline_applyaction' argument 14 names different: declaration 'term' definition 'term_metrics'. aptitude-0.8.13/src/cmdline/cmdline_action.cc:243:67: note: Function 'cmdline_applyaction' argument 14 names different: declaration 'term' definition 'term_metrics'. aptitude-0.8.13/src/cmdline/cmdline_mark.cc:149:14: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/cmdline/cmdline_action.cc:540:67: style:inconclusive: Function 'cmdline_applyaction' argument 12 names different: declaration 'term' definition 'term_metrics'. [funcArgNamesDifferent] aptitude-0.8.13/src/cmdline/cmdline_action.h:174:86: note: Function 'cmdline_applyaction' argument 12 names different: declaration 'term' definition 'term_metrics'. aptitude-0.8.13/src/cmdline/cmdline_action.cc:540:67: note: Function 'cmdline_applyaction' argument 12 names different: declaration 'term' definition 'term_metrics'. aptitude-0.8.13/src/cmdline/cmdline_action.cc:801:87: style:inconclusive: Function 'cmdline_parse_action' argument 11 names different: declaration 'term' definition 'term_metrics'. [funcArgNamesDifferent] aptitude-0.8.13/src/cmdline/cmdline_action.h:231:87: note: Function 'cmdline_parse_action' argument 11 names different: declaration 'term' definition 'term_metrics'. aptitude-0.8.13/src/cmdline/cmdline_action.cc:801:87: note: Function 'cmdline_parse_action' argument 11 names different: declaration 'term' definition 'term_metrics'. aptitude-0.8.13/src/cmdline/cmdline_action.cc:108:25: style: Local variable 'pkg' shadows outer argument [shadowArgument] aptitude-0.8.13/src/cmdline/cmdline_action.cc:37:52: note: Shadowed declaration aptitude-0.8.13/src/cmdline/cmdline_action.cc:108:25: note: Shadow variable aptitude-0.8.13/src/cmdline/cmdline_action.cc:125:29: style: Local variable 'pkg' shadows outer argument [shadowArgument] aptitude-0.8.13/src/cmdline/cmdline_action.cc:37:52: note: Shadowed declaration aptitude-0.8.13/src/cmdline/cmdline_action.cc:125:29: note: Shadow variable aptitude-0.8.13/src/cmdline/cmdline_action.cc:176:25: style: Local variable 'pkg' shadows outer argument [shadowArgument] aptitude-0.8.13/src/cmdline/cmdline_action.cc:37:52: note: Shadowed declaration aptitude-0.8.13/src/cmdline/cmdline_action.cc:176:25: note: Shadow variable aptitude-0.8.13/src/cmdline/cmdline_action.cc:532:38: performance: Function parameter 's' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/cmdline/cmdline_action.cc:794:39: performance: Function parameter 's' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/cmdline/cmdline_search.cc:184:36: performance: Function parameter 'width_cfg' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/cmdline/cmdline_search.cc:183:36: style: Parameter 'argv' can be declared as const array [constParameter] aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:653:5: warning: Member variable 'resolver_result::aborted' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:698:3: style: Class 'cmdline_resolver_continuation' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:734:3: style: Class 'CmdlineSearchAbortedException' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:747:3: style: Class 'CmdlineSearchDisabledException' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:802:51: style:inconclusive: Function 'calculate_current_solution' argument 1 names different: declaration 'print_resolving_dependencies' definition 'suppress_message'. [funcArgNamesDifferent] aptitude-0.8.13/src/cmdline/cmdline_resolver.h:94:69: note: Function 'calculate_current_solution' argument 1 names different: declaration 'print_resolving_dependencies' definition 'suppress_message'. aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:802:51: note: Function 'calculate_current_solution' argument 1 names different: declaration 'print_resolving_dependencies' definition 'suppress_message'. aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:364:38: style: Local variable 'found' shadows outer variable [shadowVariable] aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:337:53: note: Shadowed declaration aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:364:38: note: Shadow variable aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:309:16: warning: Either the condition 'i>(int)choices.size()' is redundant or 'i' can have the value choices.size(). Expression 'choices[i]' causes access out of bounds. [containerOutOfBounds] aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:306:41: note: Assuming that condition 'i>(int)choices.size()' is not redundant aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:309:16: note: Access out of bounds aptitude-0.8.13/src/cmdline/cmdline_show.cc:609:7: warning: Return value of function std::search() is not used. [ignoredReturnValue] aptitude-0.8.13/src/cmdline/cmdline_show.cc:617:7: style: Condition '!do_cmdline_show_target(it->first,source,sourcestr,verbose,has_explicit_source,term_metrics)' is always false [knownConditionTrueFalse] aptitude-0.8.13/src/cmdline/cmdline_show.cc:617:30: note: Calling function 'do_cmdline_show_target' returns 1 aptitude-0.8.13/src/cmdline/cmdline_show.cc:617:7: note: Condition '!do_cmdline_show_target(it->first,source,sourcestr,verbose,has_explicit_source,term_metrics)' is always false aptitude-0.8.13/src/cmdline/cmdline_show.cc:400:28: style: The scope of the variable 'state' can be reduced. [variableScope] aptitude-0.8.13/src/cmdline/cmdline_show.cc:635:34: style: Parameter 'argv' can be declared as const array [constParameter] aptitude-0.8.13/src/cmdline/cmdline_show.cc:168:17: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/cmdline/cmdline_show.cc:449:18: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/cmdline/cmdline_show.cc:454:14: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/cmdline/cmdline_show.cc:622:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/cmdline/cmdline_show.cc:610:7: style: Iterating over container 'matches' that is always empty. [knownEmptyContainer] aptitude-0.8.13/src/cmdline/cmdline_user_tag.cc:103:42: style: Variable 'term' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/cmdline/cmdline_util.cc:592:62: style:inconclusive: Function 'find_source_by_archive' argument 1 names different: declaration 'pkg' definition 'source_name'. [funcArgNamesDifferent] aptitude-0.8.13/src/cmdline/cmdline_util.h:179:62: note: Function 'find_source_by_archive' argument 1 names different: declaration 'pkg' definition 'source_name'. aptitude-0.8.13/src/cmdline/cmdline_util.cc:592:62: note: Function 'find_source_by_archive' argument 1 names different: declaration 'pkg' definition 'source_name'. aptitude-0.8.13/src/cmdline/cmdline_util.cc:634:31: style:inconclusive: Function 'find_source_package' argument 3 names different: declaration 'version_source_string' definition 'version_source_string_orig'. [funcArgNamesDifferent] aptitude-0.8.13/src/cmdline/cmdline_util.h:199:31: note: Function 'find_source_package' argument 3 names different: declaration 'version_source_string' definition 'version_source_string_orig'. aptitude-0.8.13/src/cmdline/cmdline_util.cc:634:31: note: Function 'find_source_package' argument 3 names different: declaration 'version_source_string' definition 'version_source_string_orig'. aptitude-0.8.13/src/cmdline/cmdline_util.cc:163:24: performance: Function parameter 'sourcestr' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/cmdline/cmdline_util.cc:126:41: style: Parameter 'items' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/cmdline/cmdline_util.cc:904:10: style: Consider using std::copy algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/cmdline/cmdline_util.cc:511:20: style: Variable 'final_stats' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/cmdline/mocks/teletype.h:60:7: error: syntax error [syntaxError] aptitude-0.8.13/src/cmdline/mocks/terminal.cc:131:89: warning: The class 'impl' defines member function with name 'create_default' also defined in its parent class 'combining_terminal_output'. [duplInheritedMember] aptitude-0.8.13/src/cmdline/mocks/terminal.cc:146:77: note: Parent function 'combining_terminal_output::create_default' aptitude-0.8.13/src/cmdline/mocks/terminal.cc:131:89: note: Derived function 'impl::create_default' aptitude-0.8.13/src/cmdline/mocks/terminal.cc:136:89: warning: The class 'impl' defines member function with name 'create_nice' also defined in its parent class 'combining_terminal_output'. [duplInheritedMember] aptitude-0.8.13/src/cmdline/mocks/terminal.cc:151:77: note: Parent function 'combining_terminal_output::create_nice' aptitude-0.8.13/src/cmdline/mocks/terminal.cc:136:89: note: Derived function 'impl::create_nice' aptitude-0.8.13/src/cmdline/mocks/terminal.cc:141:89: warning: The class 'impl' defines member function with name 'create_strict' also defined in its parent class 'combining_terminal_output'. [duplInheritedMember] aptitude-0.8.13/src/cmdline/mocks/terminal.cc:156:77: note: Parent function 'combining_terminal_output::create_strict' aptitude-0.8.13/src/cmdline/mocks/terminal.cc:141:89: note: Derived function 'impl::create_strict' aptitude-0.8.13/src/cmdline/cmdline_versions.h:62:3: style: Class 'GroupByParseException' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/cmdline_versions.cc:115:10: style: The function 'get_groups' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_versions.cc:103:18: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:115:10: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:122:17: style: The function 'format_header' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_versions.cc:108:25: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:122:17: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:132:10: style: The function 'get_groups' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_versions.cc:103:18: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:132:10: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:159:17: style: The function 'format_header' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_versions.cc:108:25: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:159:17: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:169:10: style: The function 'get_groups' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_versions.cc:103:18: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:169:10: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:208:17: style: The function 'format_header' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_versions.cc:108:25: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:208:17: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:218:10: style: The function 'get_groups' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_versions.cc:103:18: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:218:10: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:230:17: style: The function 'format_header' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_versions.cc:108:25: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:230:17: note: Function in derived class aptitude-0.8.13/src/cmdline/terminal.cc:63:14: style: The function 'output_is_a_terminal' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/terminal.h:69:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/terminal.cc:63:14: note: Function in derived class aptitude-0.8.13/src/cmdline/terminal.cc:64:14: style: The function 'write_text' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/terminal.h:72:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/terminal.cc:64:14: note: Function in derived class aptitude-0.8.13/src/cmdline/terminal.cc:65:14: style: The function 'move_to_beginning_of_line' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/terminal.h:80:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/terminal.cc:65:14: note: Function in derived class aptitude-0.8.13/src/cmdline/terminal.cc:66:14: style: The function 'flush' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/terminal.h:89:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/terminal.cc:66:14: note: Function in derived class aptitude-0.8.13/src/cmdline/terminal.cc:67:22: style: The function 'prompt_for_input' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/terminal.h:115:28: note: Virtual function in base class aptitude-0.8.13/src/cmdline/terminal.cc:67:22: note: Function in derived class aptitude-0.8.13/src/cmdline/terminal.cc:68:22: style: The function 'get_screen_width' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/terminal.h:135:28: note: Virtual function in base class aptitude-0.8.13/src/cmdline/terminal.cc:68:22: note: Function in derived class aptitude-0.8.13/src/cmdline/terminal.cc:69:13: style: The function 'wcwidth' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/terminal.h:154:19: note: Virtual function in base class aptitude-0.8.13/src/cmdline/terminal.cc:69:13: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_versions.cc:543:62: performance: Function parameter 'width_cfg' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/cmdline/cmdline_versions.cc:542:38: style: Parameter 'argv' can be declared as const array [constParameter] aptitude-0.8.13/src/cmdline/transient_message.cc:57:14: style: The function 'set_text' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/transient_message.h:43:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/transient_message.cc:57:14: note: Function in derived class aptitude-0.8.13/src/cmdline/transient_message.cc:61:14: style: The function 'display_and_advance' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/transient_message.h:49:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/transient_message.cc:61:14: note: Function in derived class aptitude-0.8.13/src/cmdline/transient_message.cc:101:14: style: The function 'set_text' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/transient_message.h:43:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/transient_message.cc:101:14: note: Function in derived class aptitude-0.8.13/src/cmdline/transient_message.cc:102:14: style: The function 'display_and_advance' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/transient_message.h:49:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/transient_message.cc:102:14: note: Function in derived class aptitude-0.8.13/src/cmdline/transient_message.cc:164:76: style:inconclusive: Function 'display_and_advance' argument 1 names different: declaration 'line' definition 'msg'. [funcArgNamesDifferent] aptitude-0.8.13/src/cmdline/transient_message.cc:102:54: note: Function 'display_and_advance' argument 1 names different: declaration 'line' definition 'msg'. aptitude-0.8.13/src/cmdline/transient_message.cc:164:76: note: Function 'display_and_advance' argument 1 names different: declaration 'line' definition 'msg'. aptitude-0.8.13/src/mine/board.h:103:3: warning: Member variable 'mine_board::minex' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/mine/board.h:103:3: warning: Member variable 'mine_board::miney' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/mine/board.h:103:3: warning: Member variable 'mine_board::starttime' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/mine/board.h:103:3: warning: Member variable 'mine_board::endtime' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/mine/board.h:140:7: style:inconclusive: Technically the member function 'mine_board::get_width' can be const. [functionConst] aptitude-0.8.13/src/mine/board.h:141:7: style:inconclusive: Technically the member function 'mine_board::get_height' can be const. [functionConst] aptitude-0.8.13/src/mine/board.h:142:14: style:inconclusive: Technically the member function 'mine_board::get_state' can be const. [functionConst] aptitude-0.8.13/src/mine/board.h:152:7: style:inconclusive: Technically the member function 'mine_board::get_nummines' can be const. [functionConst] aptitude-0.8.13/src/mine/board.h:153:7: style:inconclusive: Technically the member function 'mine_board::get_numflags' can be const. [functionConst] aptitude-0.8.13/src/mine/board.h:155:22: style:inconclusive: Technically the member function 'mine_board::get_square' can be const. [functionConst] aptitude-0.8.13/src/pkg_tree.h:114:4: style: The destructor '~pkg_tree' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_tree.h:110:4: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_tree.h:114:4: note: Destructor in derived class aptitude-0.8.13/src/pkg_tree.h:143:8: style: The function 'find_limit_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_tree.h:204:8: note: Virtual function in base class aptitude-0.8.13/src/pkg_tree.h:143:8: note: Function in derived class aptitude-0.8.13/src/pkg_tree.h:146:8: style: The function 'find_limit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_tree.h:207:8: note: Virtual function in base class aptitude-0.8.13/src/pkg_tree.h:146:8: note: Function in derived class aptitude-0.8.13/src/pkg_tree.h:149:8: style: The function 'find_reset_limit_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_tree.h:210:8: note: Virtual function in base class aptitude-0.8.13/src/pkg_tree.h:149:8: note: Function in derived class aptitude-0.8.13/src/pkg_tree.h:152:8: style: The function 'find_reset_limit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_tree.h:213:8: note: Virtual function in base class aptitude-0.8.13/src/pkg_tree.h:152:8: note: Function in derived class aptitude-0.8.13/src/desc_render.cc:134:9: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/download_item.h:48:3: warning: Member variable 'download_item::hit' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/download_item.h:48:3: warning: Member variable 'download_item::doneColor' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/download_item.h:48:3: style: Class 'download_item' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/download_list.h:131:3: style: Class 'download_list' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/download_list.cc:342:40: performance: Function parameter 'media' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/download_list.cc:342:54: performance: Function parameter 'drive' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/download_list.cc:343:26: style: Parameter 'manager' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/download_list.cc:362:50: style: Parameter 'itmdesc' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/download_list.cc:363:28: style: Parameter 'manager' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/download_list.cc:377:49: style: Parameter 'itmdesc' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/download_list.cc:378:27: style: Parameter 'manager' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/download_list.cc:382:48: style: Parameter 'itmdesc' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/download_list.cc:383:26: style: Parameter 'manager' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/download_list.cc:397:48: style: Parameter 'itmdesc' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/download_list.cc:398:26: style: Parameter 'manager' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/download_list.cc:435:48: style: Parameter 'manager' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/download_list.cc:475:51: style: Parameter 'manager' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/pkg_subtree.h:114:8: warning: The class 'pkg_subtree' defines member function with name 'dispatch_key' also defined in its parent class 'pkg_tree_node'. [duplInheritedMember] aptitude-0.8.13/src/pkg_node.h:67:8: note: Parent function 'pkg_tree_node::dispatch_key' aptitude-0.8.13/src/pkg_subtree.h:114:8: note: Derived function 'pkg_subtree::dispatch_key' aptitude-0.8.13/src/pkg_item_with_subtree.h:102:8: warning: The class 'pkg_item_with_subtree < pkg_ver_item , versort >' defines member function with name 'dispatch_key' also defined in its parent class 'pkg_item'. [duplInheritedMember] aptitude-0.8.13/src/pkg_item.h:85:8: note: Parent function 'pkg_item::dispatch_key' aptitude-0.8.13/src/pkg_item_with_subtree.h:102:8: note: Derived function 'pkg_item_with_subtree < pkg_ver_item , versort >::dispatch_key' aptitude-0.8.13/src/pkg_item_with_subtree.h:110:8: warning: The class 'pkg_item_with_subtree < pkg_ver_item , versort >' defines member function with name 'dispatch_mouse' also defined in its parent class 'pkg_item'. [duplInheritedMember] aptitude-0.8.13/src/pkg_item.h:86:8: note: Parent function 'pkg_item::dispatch_mouse' aptitude-0.8.13/src/pkg_item_with_subtree.h:110:8: note: Derived function 'pkg_item_with_subtree < pkg_ver_item , versort >::dispatch_mouse' aptitude-0.8.13/src/pkg_item_with_subtree.h:102:8: warning: The class 'pkg_item_with_subtree < pkg_ver_item , versort >' defines member function with name 'dispatch_key' also defined in its parent class 'pkg_tree_node'. [duplInheritedMember] aptitude-0.8.13/src/pkg_node.h:67:8: note: Parent function 'pkg_tree_node::dispatch_key' aptitude-0.8.13/src/pkg_item_with_subtree.h:102:8: note: Derived function 'pkg_item_with_subtree < pkg_ver_item , versort >::dispatch_key' aptitude-0.8.13/src/pkg_item_with_subtree.h:102:8: warning: The class 'pkg_item_with_subtree < cwidget :: widgets :: treeitem , cwidget :: widgets :: tag_sort_policy >' defines member function with name 'dispatch_key' also defined in its parent class 'pkg_item'. [duplInheritedMember] aptitude-0.8.13/src/pkg_item.h:85:8: note: Parent function 'pkg_item::dispatch_key' aptitude-0.8.13/src/pkg_item_with_subtree.h:102:8: note: Derived function 'pkg_item_with_subtree < cwidget :: widgets :: treeitem , cwidget :: widgets :: tag_sort_policy >::dispatch_key' aptitude-0.8.13/src/pkg_item_with_subtree.h:110:8: warning: The class 'pkg_item_with_subtree < cwidget :: widgets :: treeitem , cwidget :: widgets :: tag_sort_policy >' defines member function with name 'dispatch_mouse' also defined in its parent class 'pkg_item'. [duplInheritedMember] aptitude-0.8.13/src/pkg_item.h:86:8: note: Parent function 'pkg_item::dispatch_mouse' aptitude-0.8.13/src/pkg_item_with_subtree.h:110:8: note: Derived function 'pkg_item_with_subtree < cwidget :: widgets :: treeitem , cwidget :: widgets :: tag_sort_policy >::dispatch_mouse' aptitude-0.8.13/src/pkg_item_with_subtree.h:102:8: warning: The class 'pkg_item_with_subtree < cwidget :: widgets :: treeitem , cwidget :: widgets :: tag_sort_policy >' defines member function with name 'dispatch_key' also defined in its parent class 'pkg_tree_node'. [duplInheritedMember] aptitude-0.8.13/src/pkg_node.h:67:8: note: Parent function 'pkg_tree_node::dispatch_key' aptitude-0.8.13/src/pkg_item_with_subtree.h:102:8: note: Derived function 'pkg_item_with_subtree < cwidget :: widgets :: treeitem , cwidget :: widgets :: tag_sort_policy >::dispatch_key' aptitude-0.8.13/src/pkg_ver_item.h:106:8: warning: The class 'pkg_ver_item' defines member function with name 'dispatch_key' also defined in its parent class 'pkg_tree_node'. [duplInheritedMember] aptitude-0.8.13/src/pkg_node.h:67:8: note: Parent function 'pkg_tree_node::dispatch_key' aptitude-0.8.13/src/pkg_ver_item.h:106:8: note: Derived function 'pkg_ver_item::dispatch_key' aptitude-0.8.13/src/pkg_grouppolicy.h:179:3: style: Class 'pkg_grouppolicy_status_factory' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/pkg_grouppolicy.h:213:3: style: Class 'pkg_grouppolicy_mode_factory' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/pkg_grouppolicy.h:282:3: style: Class 'pkg_grouppolicy_priority_factory' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/pkg_grouppolicy.h:297:3: style: Class 'pkg_grouppolicy_task_factory' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/pkg_grouppolicy.h:381:3: style: Class 'pkg_grouppolicy_facet_tag_factory' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/pkg_grouppolicy.h:397:3: style: Class 'pkg_grouppolicy_source_factory' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/pkg_grouppolicy.h:411:3: style: Class 'pkg_grouppolicy_arch_factory' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/pkg_subtree.h:51:3: style: Class 'pkg_subtree' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/pkg_sortpolicy.h:77:3: style: Class 'pkg_sortpolicy_wrapper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/pkg_ver_item.h:181:3: style: Class 'pkg_ver_screen' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/pkg_grouppolicy.h:112:28: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.h:112:28: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:167:28: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.h:167:28: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:170:12: style: The destructor '~pkg_grouppolicy_section_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:170:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:181:28: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.h:181:28: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:184:12: style: The destructor '~pkg_grouppolicy_status_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:184:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:199:28: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.h:199:28: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:202:12: style: The destructor '~pkg_grouppolicy_filter_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:202:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:215:20: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.h:215:20: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:218:12: style: The destructor '~pkg_grouppolicy_mode_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:218:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:271:20: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.h:271:20: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:273:12: style: The destructor '~pkg_grouppolicy_firstchar_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:273:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:284:20: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.h:284:20: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:287:12: style: The destructor '~pkg_grouppolicy_priority_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:287:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:302:20: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.h:302:20: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:305:12: style: The destructor '~pkg_grouppolicy_task_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:305:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:351:20: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.h:351:20: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:354:4: style: The destructor '~pkg_grouppolicy_patterns_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:354:4: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:370:20: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.h:370:20: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:373:4: style: The destructor '~pkg_grouppolicy_tag_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:373:4: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:386:20: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.h:386:20: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:389:4: style: The destructor '~pkg_grouppolicy_facet_tag_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:389:4: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:399:20: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.h:399:20: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:402:12: style: The destructor '~pkg_grouppolicy_source_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:402:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:413:20: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.h:413:20: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.h:416:12: style: The destructor '~pkg_grouppolicy_arch_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:416:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_subtree.h:76:16: style: The function 'select' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:54:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_subtree.h:76:16: note: Function in derived class aptitude-0.8.13/src/pkg_subtree.h:77:16: style: The function 'hold' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:55:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_subtree.h:77:16: note: Function in derived class aptitude-0.8.13/src/pkg_subtree.h:78:16: style: The function 'keep' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:56:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_subtree.h:78:16: note: Function in derived class aptitude-0.8.13/src/pkg_subtree.h:79:16: style: The function 'remove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:57:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_subtree.h:79:16: note: Function in derived class aptitude-0.8.13/src/pkg_subtree.h:80:16: style: The function 'purge' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:58:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_subtree.h:80:16: note: Function in derived class aptitude-0.8.13/src/pkg_subtree.h:81:16: style: The function 'reinstall' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:59:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_subtree.h:81:16: note: Function in derived class aptitude-0.8.13/src/pkg_subtree.h:82:16: style: The function 'set_auto' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:61:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_subtree.h:82:16: note: Function in derived class aptitude-0.8.13/src/pkg_subtree.h:83:16: style: The function 'forbid_upgrade' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:62:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_subtree.h:83:16: note: Function in derived class aptitude-0.8.13/src/pkg_subtree.h:142:26: style: The function 'tag' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_subtree.h:73:26: note: Virtual function in base class aptitude-0.8.13/src/pkg_subtree.h:142:26: note: Function in derived class aptitude-0.8.13/src/dep_item.h:55:28: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/dep_item.h:55:28: note: Function in derived class aptitude-0.8.13/src/dep_item.h:62:31: style: The function 'setup_new_root' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/apt_info_tree.h:57:39: note: Virtual function in base class aptitude-0.8.13/src/dep_item.h:62:31: note: Function in derived class aptitude-0.8.13/src/dep_item.h:79:12: style: The destructor '~pkg_dep_screen' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_tree.h:110:4: note: Virtual destructor in base class aptitude-0.8.13/src/dep_item.h:79:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_ver_item.h:54:31: style: The function 'setup_column' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_columnizer.h:58:39: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:54:31: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:95:16: style: The function 'select' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:54:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:95:16: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:96:16: style: The function 'hold' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:55:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:96:16: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:97:16: style: The function 'keep' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:56:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:97:16: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:98:16: style: The function 'remove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:57:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:98:16: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:99:16: style: The function 'purge' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:58:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:99:16: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:100:16: style: The function 'reinstall' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:59:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:100:16: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:101:16: style: The function 'set_auto' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:61:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:101:16: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:102:16: style: The function 'forbid_upgrade' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_node.h:62:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:102:16: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:115:8: style: The function 'package_forbid_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:78:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:115:8: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:116:8: style: The function 'package_forbid' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:83:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:116:8: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:117:8: style: The function 'package_changelog_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:94:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:117:8: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:118:8: style: The function 'package_changelog' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:97:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:118:8: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:119:8: style: The function 'package_information_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:86:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:119:8: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:120:8: style: The function 'package_information' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:91:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:120:8: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:170:28: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:96:28: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:170:28: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.h:179:39: style: The function 'setup_new_root' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/apt_info_tree.h:57:39: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.h:179:39: note: Function in derived class aptitude-0.8.13/src/dep_item.cc:69:8: style: The function 'select' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_subtree.h:76:16: note: Virtual function in base class aptitude-0.8.13/src/dep_item.cc:69:8: note: Function in derived class aptitude-0.8.13/src/dep_item.cc:202:8: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/dep_item.cc:202:8: note: Function in derived class aptitude-0.8.13/src/dep_item.cc:218:12: style: The destructor '~pkg_grouppolicy_dep' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/dep_item.cc:218:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_item_with_subtree.h:82:16: style: The function 'paint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_item.h:61:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_item_with_subtree.h:82:16: note: Function in derived class aptitude-0.8.13/src/pkg_item_with_subtree.h:48:33: style: The function 'setup_column' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_columnizer.h:58:39: note: Virtual function in base class aptitude-0.8.13/src/pkg_item_with_subtree.h:48:33: note: Function in derived class aptitude-0.8.13/src/dep_item.cc:74:49: style:inconclusive: Function 'pkg_depitem' argument 1 names different: declaration '_first' definition 'first'. [funcArgNamesDifferent] aptitude-0.8.13/src/dep_item.cc:62:38: note: Function 'pkg_depitem' argument 1 names different: declaration '_first' definition 'first'. aptitude-0.8.13/src/dep_item.cc:74:49: note: Function 'pkg_depitem' argument 1 names different: declaration '_first' definition 'first'. aptitude-0.8.13/src/dep_item.cc:74:68: style:inconclusive: Function 'pkg_depitem' argument 2 names different: declaration '_sig' definition 'sig'. [funcArgNamesDifferent] aptitude-0.8.13/src/dep_item.cc:62:58: note: Function 'pkg_depitem' argument 2 names different: declaration '_sig' definition 'sig'. aptitude-0.8.13/src/dep_item.cc:74:68: note: Function 'pkg_depitem' argument 2 names different: declaration '_sig' definition 'sig'. aptitude-0.8.13/src/dep_item.cc:221:71: style:inconclusive: Function 'instantiate' argument 1 names different: declaration 'sig' definition '_sig'. [funcArgNamesDifferent] aptitude-0.8.13/src/dep_item.h:55:52: note: Function 'instantiate' argument 1 names different: declaration 'sig' definition '_sig'. aptitude-0.8.13/src/dep_item.cc:221:71: note: Function 'instantiate' argument 1 names different: declaration 'sig' definition '_sig'. aptitude-0.8.13/src/dep_item.cc:222:23: style:inconclusive: Function 'instantiate' argument 2 names different: declaration 'desc_sig' definition '_desc_sig'. [funcArgNamesDifferent] aptitude-0.8.13/src/dep_item.h:55:70: note: Function 'instantiate' argument 2 names different: declaration 'desc_sig' definition '_desc_sig'. aptitude-0.8.13/src/dep_item.cc:222:23: note: Function 'instantiate' argument 2 names different: declaration 'desc_sig' definition '_desc_sig'. aptitude-0.8.13/src/dep_item.cc:360:28: style: Local variable 'D' shadows outer variable [shadowVariable] aptitude-0.8.13/src/dep_item.cc:308:25: note: Shadowed declaration aptitude-0.8.13/src/dep_item.cc:360:28: note: Shadow variable aptitude-0.8.13/src/dep_item.cc:394:37: style: Local variable 'policy' shadows outer variable [shadowVariable] aptitude-0.8.13/src/dep_item.cc:386:35: note: Shadowed declaration aptitude-0.8.13/src/dep_item.cc:394:37: note: Shadow variable aptitude-0.8.13/src/pkg_subtree.h:126:39: performance: Function parameter 'name' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/pkg_subtree.h:126:58: performance: Function parameter 'description' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/pkg_subtree.h:135:39: performance: Function parameter 'name' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/dep_item.cc:282:32: style: Parameter 'child' can be declared as pointer to const [constParameterPointer] aptitude-0.8.13/src/dep_item.cc:282:52: style: Parameter 'parent' can be declared as pointer to const [constParameterPointer] aptitude-0.8.13/src/generic/apt/aptcache.h:219:5: warning: Member variable 'apt_state_snapshot::iUsrSize' is not initialized in the constructor. [uninitMemberVarPrivate] aptitude-0.8.13/src/generic/apt/aptcache.h:219:5: warning: Member variable 'apt_state_snapshot::iDownloadSize' is not initialized in the constructor. [uninitMemberVarPrivate] aptitude-0.8.13/src/generic/apt/aptcache.h:219:5: warning: Member variable 'apt_state_snapshot::iInstCount' is not initialized in the constructor. [uninitMemberVarPrivate] aptitude-0.8.13/src/generic/apt/aptcache.h:219:5: warning: Member variable 'apt_state_snapshot::iDelCount' is not initialized in the constructor. [uninitMemberVarPrivate] aptitude-0.8.13/src/generic/apt/aptcache.h:219:5: warning: Member variable 'apt_state_snapshot::iKeepCount' is not initialized in the constructor. [uninitMemberVarPrivate] aptitude-0.8.13/src/generic/apt/aptcache.h:219:5: warning: Member variable 'apt_state_snapshot::iBrokenCount' is not initialized in the constructor. [uninitMemberVarPrivate] aptitude-0.8.13/src/generic/apt/aptcache.h:219:5: warning: Member variable 'apt_state_snapshot::iBadCount' is not initialized in the constructor. [uninitMemberVarPrivate] aptitude-0.8.13/src/generic/apt/aptcache.h:584:8: style:inconclusive: Technically the member function 'aptitudeCacheFile::is_locked' can be const. [functionConst] aptitude-0.8.13/src/generic/apt/aptcache.h:305:3: style: Class 'aptitudeDepCache' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/aptcache.h:175:5: style: Class 'action_group' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:308:30: style: Comparison of a variable having boolean value using relational (<, >, <= or >=) operator. [comparisonOfBoolWithBoolError] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:395:3: warning: Member variable 'aptitude_resolver_dep::start' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:577:25: style:inconclusive: Technically the member function 'version_iterator::get_pkg' can be const. [functionConst] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:583:25: style:inconclusive: Technically the member function 'version_iterator::get_ver' can be const. [functionConst] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:776:3: style: Class 'dep_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:1126:3: style: Class 'aptitude_universe' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:1150:5: style: Class 'package_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:1218:5: style: Class 'dep_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:1303:5: style: Class 'broken_dep_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:55:3: style: Class 'rev_dep_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:75:3: style: Class 'rev_dep_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:516:8: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:683:26: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:778:22: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:793:22: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:877:25: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:906:71: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:1049:93: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:1305:49: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:56:41: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:57:37: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:58:31: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:76:41: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:77:37: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:78:31: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/apt.cc:819:83: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/apt.cc:1033:42: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:312:10: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:314:5: note: Found duplicate branches for 'if' and 'else'. aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:312:10: note: Found duplicate branches for 'if' and 'else'. aptitude-0.8.13/src/generic/apt/apt.cc:317:27: style:inconclusive: Function 'apt_init' argument 1 names different: declaration 'progess_bar' definition 'progress_bar'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/apt.h:71:27: note: Function 'apt_init' argument 1 names different: declaration 'progess_bar' definition 'progress_bar'. aptitude-0.8.13/src/generic/apt/apt.cc:317:27: note: Function 'apt_init' argument 1 names different: declaration 'progess_bar' definition 'progress_bar'. aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:339:25: style: Local variable 'pkg' shadows outer variable [shadowVariable] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:53:28: note: Shadowed declaration aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:339:25: note: Shadow variable aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:999:37: style: Local variable 'prv' shadows outer variable [shadowVariable] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:391:29: note: Shadowed declaration aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:999:37: note: Shadow variable aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:246:15: style: Variable 'pcache' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:273:15: style: Variable 'pcache' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/cmdline/cmdline_why.h:518:80: performance: Function parameter 'leaves' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/cmdline/cmdline_prompt.cc:66:47: style: Parameter 'reasons' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/cmdline/cmdline_prompt.cc:623:14: style: Parameter 'to_hold' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/cmdline/cmdline_prompt.cc:167:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/apt/aptitude_resolver.cc:783:95: error: There is an unknown macro here somewhere. Configuration is required. If PACKAGE is a macro then please configure it. [unknownMacro] aptitude-0.8.13/src/generic/apt/aptitude_resolver_cost_settings.cc:162:3: debug: Failed to parse 'typedef multi_index_container < entry , indexed_by < random_access < tag < ordered_t > > , hashed_unique < tag < name_t > , const_mem_fun < entry , const std :: string & , & entry :: get_name > > > > :: index < name_t > :: type by_name_index ;'. The checking continues anyway. [simplifyTypedef] aptitude-0.8.13/src/generic/apt/aptitude_resolver_cost_settings.cc:163:3: debug: Failed to parse 'typedef multi_index_container < entry , indexed_by < random_access < tag < ordered_t > > , hashed_unique < tag < name_t > , const_mem_fun < entry , const std :: string & , & entry :: get_name > > > > :: index < ordered_t > :: type ordered_index ;'. The checking continues anyway. [simplifyTypedef] aptitude-0.8.13/src/generic/apt/aptitude_resolver_cost_types.h:36:3: style: Class 'CostTypeCheckFailure' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/aptitude_resolver_cost_settings.h:119:8: performance:inconclusive: Technically the member function 'aptitude_resolver_cost_settings::is_component_relevant' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/generic/apt/aptitude_resolver_cost_settings.h:68:5: style: Class 'component' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/aptitude_resolver_cost_settings.cc:100:5: style: Class 'add_effect_f' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/aptitude_resolver_cost_settings.cc:123:5: style: Class 'merge_types_f' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/aptitude_resolver_cost_settings.cc:120:17: style: class member 'merge_types_f::name' is never used. [unusedStructMember] aptitude-0.8.13/src/generic/apt/aptitudepolicy.h:24:3: style: Class 'aptitudePolicy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.cc:592:29: performance:inconclusive: Technically the member function 'DummyEmptySolution::version_of' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.cc:492:10: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/changelog_parse.h:101:7: style: Class 'changelog_element_list' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/changelog_parse.h:213:7: style: Class 'changelog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/changelog_parse.cc:271:34: style:inconclusive: Function 'changelog' argument 1 names different: declaration 'file' definition 'digest'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/changelog_parse.h:213:25: note: Function 'changelog' argument 1 names different: declaration 'file' definition 'digest'. aptitude-0.8.13/src/generic/apt/changelog_parse.cc:271:34: note: Function 'changelog' argument 1 names different: declaration 'file' definition 'digest'. aptitude-0.8.13/src/generic/apt/changelog_parse.cc:279:32: style: Unused variable: fragments [unusedVariable] aptitude-0.8.13/src/generic/apt/config_file.cc:170:15: style: The scope of the variable 'content' can be reduced. [variableScope] aptitude-0.8.13/src/generic/apt/config_signal.cc:34:50: style:inconclusive: Function 'update_theme' argument 1 names different: declaration 'theme' definition 'newtheme'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/config_signal.h:70:33: note: Function 'update_theme' argument 1 names different: declaration 'theme' definition 'newtheme'. aptitude-0.8.13/src/generic/apt/config_signal.cc:34:50: note: Function 'update_theme' argument 1 names different: declaration 'theme' definition 'newtheme'. aptitude-0.8.13/src/generic/apt/config_signal.cc:73:47: style:inconclusive: Function 'SetNoUser' argument 1 names different: declaration 'name' definition 'Name'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/config_signal.h:167:30: note: Function 'SetNoUser' argument 1 names different: declaration 'name' definition 'Name'. aptitude-0.8.13/src/generic/apt/config_signal.cc:73:47: note: Function 'SetNoUser' argument 1 names different: declaration 'name' definition 'Name'. aptitude-0.8.13/src/generic/apt/config_signal.cc:34:50: performance: Function parameter 'newtheme' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/generic/apt/config_signal.cc:25:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/generic/apt/config_signal.cc:115:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/generic/apt/download_install_manager.h:117:4: style: The destructor '~download_install_manager' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_manager.h:61:12: note: Virtual destructor in base class aptitude-0.8.13/src/generic/apt/download_install_manager.h:117:4: note: Destructor in derived class aptitude-0.8.13/src/generic/apt/download_install_manager.h:135:8: style: The function 'prepare' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_manager.h:76:16: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/download_install_manager.h:135:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/download_install_manager.h:144:8: style: The function 'finish' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_manager.h:115:16: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/download_install_manager.h:144:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/download_install_manager.cc:114:90: style:inconclusive: Function 'finish_pre_dpkg' argument 1 names different: declaration 'result' definition 'res'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/download_install_manager.h:106:48: note: Function 'finish_pre_dpkg' argument 1 names different: declaration 'result' definition 'res'. aptitude-0.8.13/src/generic/apt/download_install_manager.cc:114:90: note: Function 'finish_pre_dpkg' argument 1 names different: declaration 'result' definition 'res'. aptitude-0.8.13/src/cmdline/cmdline_why.cc:644:5: warning:inconclusive: Member variable 'justification_search::search_info' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] aptitude-0.8.13/src/cmdline/cmdline_why.cc:662:27: warning:inconclusive: Member variable 'justification_search::search_info' is not assigned a value in 'justification_search::operator='. [operatorEqVarError] aptitude-0.8.13/src/cmdline/cmdline_why.cc:662:27: warning: 'operator=' should check for assignment to self to avoid problems with dynamic memory. [operatorEqToSelf] aptitude-0.8.13/src/cmdline/cmdline_why.cc:1498:7: style:inconclusive: Technically the member function 'aptitude::why::::compare_first_action::operator()' can be const. [functionConst] aptitude-0.8.13/src/cmdline/cmdline_why.cc:121:7: style: Class 'justification' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/cmdline/cmdline_why.cc:1063:14: style: The function 'examining_dep' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_why.h:440:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1063:14: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1072:14: style: The function 'skip_because_not_a_conflict' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_why.h:445:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1072:14: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1078:14: style: The function 'skip_because_is_a_conflict' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_why.h:450:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1078:14: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1084:14: style: The function 'skip_according_to_parameters' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_why.h:455:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1084:14: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1090:14: style: The function 'skip_because_not_from_selected_version' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_why.h:461:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1090:14: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1096:14: style: The function 'skip_because_satisfied_by_current_version' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_why.h:466:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1096:14: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1102:14: style: The function 'skip_because_already_seen' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_why.h:468:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1102:14: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1108:14: style: The function 'skip_because_version_check_failed' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_why.h:473:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1108:14: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1114:14: style: The function 'enqueued' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_why.h:476:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1114:14: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1120:14: style: The function 'enqueued' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_why.h:479:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1120:14: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1128:14: style: The function 'begin' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_why.h:482:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1128:14: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1135:14: style: The function 'start_target' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/cmdline/cmdline_why.h:487:20: note: Virtual function in base class aptitude-0.8.13/src/cmdline/cmdline_why.cc:1135:14: note: Function in derived class aptitude-0.8.13/src/cmdline/cmdline_why.cc:261:9: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/cmdline/cmdline_why.cc:264:9: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/cmdline/cmdline_why.cc:271:9: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/cmdline/cmdline_why.cc:274:9: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/cmdline/cmdline_why.cc:273:12: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] aptitude-0.8.13/src/cmdline/cmdline_why.cc:276:7: note: Found duplicate branches for 'if' and 'else'. aptitude-0.8.13/src/cmdline/cmdline_why.cc:273:12: note: Found duplicate branches for 'if' and 'else'. aptitude-0.8.13/src/cmdline/cmdline_why.cc:804:16: style: The comparison 'i == 0' is always true. [knownConditionTrueFalse] aptitude-0.8.13/src/cmdline/cmdline_why.cc:802:15: note: 'i' is assigned value '0' here. aptitude-0.8.13/src/cmdline/cmdline_why.cc:804:16: note: The comparison 'i == 0' is always true. aptitude-0.8.13/src/cmdline/cmdline_why.cc:1425:8: style: The scope of the variable 'is_removal' can be reduced. [variableScope] aptitude-0.8.13/src/cmdline/cmdline_why.cc:1383:54: style:inconclusive: Function 'do_why' argument 1 names different: declaration 'arguments' definition 'leaves'. [funcArgNamesDifferent] aptitude-0.8.13/src/cmdline/cmdline_why.h:557:59: note: Function 'do_why' argument 1 names different: declaration 'arguments' definition 'leaves'. aptitude-0.8.13/src/cmdline/cmdline_why.cc:1383:54: note: Function 'do_why' argument 1 names different: declaration 'arguments' definition 'leaves'. aptitude-0.8.13/src/cmdline/cmdline_why.cc:1400:8: style:inconclusive: Function 'cmdline_why' argument 6 names different: declaration 'why_not' definition 'is_why_not'. [funcArgNamesDifferent] aptitude-0.8.13/src/cmdline/cmdline_why.h:101:8: note: Function 'cmdline_why' argument 6 names different: declaration 'why_not' definition 'is_why_not'. aptitude-0.8.13/src/cmdline/cmdline_why.cc:1400:8: note: Function 'cmdline_why' argument 6 names different: declaration 'why_not' definition 'is_why_not'. aptitude-0.8.13/src/cmdline/cmdline_why.cc:1521:69: style:inconclusive: Function 'summarize_reasons' argument 1 names different: declaration 'actions' definition 'reasons'. [funcArgNamesDifferent] aptitude-0.8.13/src/cmdline/cmdline_why.h:576:69: note: Function 'summarize_reasons' argument 1 names different: declaration 'actions' definition 'reasons'. aptitude-0.8.13/src/cmdline/cmdline_why.cc:1521:69: note: Function 'summarize_reasons' argument 1 names different: declaration 'actions' definition 'reasons'. aptitude-0.8.13/src/cmdline/cmdline_why.cc:1523:33: style:inconclusive: Function 'summarize_reasons' argument 3 names different: declaration 'out' definition 'output'. [funcArgNamesDifferent] aptitude-0.8.13/src/cmdline/cmdline_why.h:578:33: note: Function 'summarize_reasons' argument 3 names different: declaration 'out' definition 'output'. aptitude-0.8.13/src/cmdline/cmdline_why.cc:1523:33: note: Function 'summarize_reasons' argument 3 names different: declaration 'out' definition 'output'. aptitude-0.8.13/src/cmdline/cmdline_why.cc:791:60: performance: Function parameter 'leaves' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/cmdline/cmdline_why.cc:1478:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/cmdline/cmdline_why.cc:1490:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/apt/download_signal_log.cc:56:51: performance: Function parameter 'Media' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/generic/apt/download_signal_log.cc:56:70: performance: Function parameter 'Drive' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/generic/apt/dpkg.cc:110:23: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/dpkg.cc:57:35: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] aptitude-0.8.13/src/generic/apt/download_queue.cc:1076:12: performance:inconclusive: Technically the member function 'aptitude::::download_thread::run' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/generic/apt/download_queue.cc:404:7: style: Class 'active_download_info' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/download_queue.cc:813:2: style: Class 'bootstrap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/download_queue.cc:485:12: style: The function 'cancel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_queue.h:105:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/download_queue.cc:485:12: note: Function in derived class aptitude-0.8.13/src/generic/apt/download_queue.cc:680:21: style: Condition 'w->CurrentItem' is always true [knownConditionTrueFalse] aptitude-0.8.13/src/generic/apt/download_queue.cc:681:14: style: Condition 'w->CurrentItem' is always true [knownConditionTrueFalse] aptitude-0.8.13/src/generic/apt/download_queue.cc:684:13: style: Condition 'w->CurrentItem' is always true [knownConditionTrueFalse] aptitude-0.8.13/src/generic/apt/download_queue.cc:685:13: style: Condition 'w->CurrentItem' is always true [knownConditionTrueFalse] aptitude-0.8.13/src/generic/apt/download_queue.cc:943:14: performance: Range variable 'sr' should be declared as const reference. [iterateByValue] aptitude-0.8.13/src/generic/apt/download_queue.cc:946:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/apt/dpkg_selections.h:83:8: style:inconclusive: Technically the member function 'aptitude::apt::dpkg::DpkgSelections::save_selections' can be const. [functionConst] aptitude-0.8.13/src/generic/apt/dpkg_selections.cc:57:22: note: Technically the member function 'aptitude::apt::dpkg::DpkgSelections::save_selections' can be const. aptitude-0.8.13/src/generic/apt/dpkg_selections.h:83:8: note: Technically the member function 'aptitude::apt::dpkg::DpkgSelections::save_selections' can be const. aptitude-0.8.13/src/generic/apt/download_update_manager.h:55:4: style: The destructor '~download_update_manager' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_manager.h:61:12: note: Virtual destructor in base class aptitude-0.8.13/src/generic/apt/download_update_manager.h:55:4: note: Destructor in derived class aptitude-0.8.13/src/generic/apt/download_update_manager.h:71:8: style: The function 'prepare' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_manager.h:76:16: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/download_update_manager.h:71:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/download_update_manager.h:75:8: style: The function 'finish' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_manager.h:115:16: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/download_update_manager.h:75:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/history/history_entry.h:379:5: style: The class 'entry' does not declare a constructor although it has private member variables which likely require initialization. [noConstructor] aptitude-0.8.13/src/generic/apt/history/history_entry.h:55:7: style: Class 'HistoryException' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/log.cc:87:26: error: There is an unknown macro here somewhere. Configuration is required. If VERSION is a macro then please configure it. [unknownMacro] aptitude-0.8.13/src/generic/apt/infer_reason.cc:148:9: style: Local variable 'state' shadows outer variable [shadowVariable] aptitude-0.8.13/src/generic/apt/infer_reason.cc:96:28: note: Shadowed declaration aptitude-0.8.13/src/generic/apt/infer_reason.cc:148:9: note: Shadow variable aptitude-0.8.13/src/generic/apt/infer_reason.cc:226:52: style: Parameter 'pkg' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/generic/apt/infer_reason.cc:284:18: performance: Searching before insertion is not necessary. [stlFindInsert] aptitude-0.8.13/src/generic/apt/matching/pattern.h:55:7: style: Class 'MatchingException' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/matching/pattern.h:69:7: style: Class 'arch_specification' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/matching/pattern.h:737:7: style: Class 'pattern' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/matching/pattern.h:628:2: style: Class 'regex_info' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/matching/compare_patterns.cc:86:6: style: Statements following 'return' will never be executed. [unreachableCode] aptitude-0.8.13/src/generic/apt/aptcache.cc:185:5: warning: Class 'action_group' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] aptitude-0.8.13/src/generic/apt/aptcache.cc:140:3: style: Class 'forget_undoer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/aptcache.cc:1172:47: style: The statement 'if (package_states[pkg->ID].selection_state!=pkgCache::State::Install) package_states[pkg->ID].selection_state=pkgCache::State::Install' is logically equivalent to 'package_states[pkg->ID].selection_state=pkgCache::State::Install'. [duplicateConditionalAssign] aptitude-0.8.13/src/generic/apt/aptcache.cc:1173:46: note: Assignment 'package_states[pkg->ID].selection_state=pkgCache::State::Install' aptitude-0.8.13/src/generic/apt/aptcache.cc:1172:47: note: Condition 'package_states[pkg->ID].selection_state!=pkgCache::State::Install' is redundant aptitude-0.8.13/src/generic/apt/aptcache.cc:1075:29: style: Condition 'package_states[i->ID].new_package' is always true [knownConditionTrueFalse] aptitude-0.8.13/src/generic/apt/aptcache.cc:1073:32: note: Assuming that condition 'package_states[i->ID].new_package' is not redundant aptitude-0.8.13/src/generic/apt/aptcache.cc:1075:29: note: Condition 'package_states[i->ID].new_package' is always true aptitude-0.8.13/src/generic/apt/aptcache.cc:549:19: style: The scope of the variable 'state' can be reduced. [variableScope] aptitude-0.8.13/src/generic/apt/aptcache.cc:199:46: style:inconclusive: Function 'aptitudeDepCache' argument 1 names different: declaration 'cache' definition 'Cache'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/aptcache.h:305:30: note: Function 'aptitudeDepCache' argument 1 names different: declaration 'cache' definition 'Cache'. aptitude-0.8.13/src/generic/apt/aptcache.cc:199:46: note: Function 'aptitudeDepCache' argument 1 names different: declaration 'cache' definition 'Cache'. aptitude-0.8.13/src/generic/apt/aptcache.cc:1517:65: style:inconclusive: Function 'set_candidate_version' argument 1 names different: declaration 'TargetVer' definition 'ver'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/aptcache.h:367:49: note: Function 'set_candidate_version' argument 1 names different: declaration 'TargetVer' definition 'ver'. aptitude-0.8.13/src/generic/apt/aptcache.cc:1517:65: note: Function 'set_candidate_version' argument 1 names different: declaration 'TargetVer' definition 'ver'. aptitude-0.8.13/src/generic/apt/aptcache.cc:1607:63: style:inconclusive: Function 'mark_single_install' argument 1 names different: declaration 'pkg' definition 'Pkg'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/aptcache.h:412:47: note: Function 'mark_single_install' argument 1 names different: declaration 'pkg' definition 'Pkg'. aptitude-0.8.13/src/generic/apt/aptcache.cc:1607:63: note: Function 'mark_single_install' argument 1 names different: declaration 'pkg' definition 'Pkg'. aptitude-0.8.13/src/generic/apt/aptcache.cc:1635:63: style:inconclusive: Function 'mark_auto_installed' argument 1 names different: declaration 'pkg' definition 'Pkg'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/aptcache.h:417:47: note: Function 'mark_auto_installed' argument 1 names different: declaration 'pkg' definition 'Pkg'. aptitude-0.8.13/src/generic/apt/aptcache.cc:1635:63: note: Function 'mark_auto_installed' argument 1 names different: declaration 'pkg' definition 'Pkg'. aptitude-0.8.13/src/generic/apt/aptcache.cc:2398:82: style:inconclusive: Function 'apply_solution' argument 1 names different: declaration 'solution' definition 'realSol'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/aptcache.h:473:66: note: Function 'apply_solution' argument 1 names different: declaration 'solution' definition 'realSol'. aptitude-0.8.13/src/generic/apt/aptcache.cc:2398:82: note: Function 'apply_solution' argument 1 names different: declaration 'solution' definition 'realSol'. aptitude-0.8.13/src/generic/apt/aptcache.cc:828:14: style: Local variable 'user_tags' shadows outer variable [shadowVariable] aptitude-0.8.13/src/generic/apt/aptcache.h:190:23: note: Shadowed declaration aptitude-0.8.13/src/generic/apt/aptcache.cc:828:14: note: Shadow variable aptitude-0.8.13/src/generic/apt/aptcache.cc:1096:73: style: Parameter 'state' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/generic/apt/aptcache.cc:1096:96: style: Parameter 'ext_state' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/generic/apt/aptcache.cc:1807:16: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/apt/aptcache.cc:154:88: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/generic/apt/dump_packages.cc:565:27: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] aptitude-0.8.13/src/generic/apt/dump_packages.cc:128:2: style: Class 'dep_element' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/dump_packages.cc:144:2: style: Class 'ParseException' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/dump_packages.cc:82:66: style:inconclusive: Function 'dump_versions' argument 1 names different: declaration 'versions' definition 'packages'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/dump_packages.h:65:66: note: Function 'dump_versions' argument 1 names different: declaration 'versions' definition 'packages'. aptitude-0.8.13/src/generic/apt/dump_packages.cc:82:66: note: Function 'dump_versions' argument 1 names different: declaration 'versions' definition 'packages'. aptitude-0.8.13/src/generic/apt/dump_packages.cc:789:55: style:inconclusive: Function 'make_truncated_state_copy' argument 1 names different: declaration 'out_dir' definition 'outDir'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/dump_packages.h:108:55: note: Function 'make_truncated_state_copy' argument 1 names different: declaration 'out_dir' definition 'outDir'. aptitude-0.8.13/src/generic/apt/dump_packages.cc:789:55: note: Function 'make_truncated_state_copy' argument 1 names different: declaration 'out_dir' definition 'outDir'. aptitude-0.8.13/src/generic/apt/dump_packages.cc:868:73: style:inconclusive: Function 'dump_truncated_packages' argument 1 names different: declaration 'versions' definition 'packages'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/dump_packages.h:76:73: note: Function 'dump_truncated_packages' argument 1 names different: declaration 'versions' definition 'packages'. aptitude-0.8.13/src/generic/apt/dump_packages.cc:868:73: note: Function 'dump_truncated_packages' argument 1 names different: declaration 'versions' definition 'packages'. aptitude-0.8.13/src/generic/apt/dump_packages.cc:571:40: performance: Function parameter 'visited_packages' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/generic/apt/parse_dpkg_status.cc:83:4: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] aptitude-0.8.13/src/generic/apt/parse_dpkg_status.h:39:7: style: Class 'DpkgStatusException' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/parse_dpkg_status.cc:99:76: style:inconclusive: Function 'operator<<' argument 2 names different: declaration 'mgs' definition 'msg'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/parse_dpkg_status.h:185:76: note: Function 'operator<<' argument 2 names different: declaration 'mgs' definition 'msg'. aptitude-0.8.13/src/generic/apt/parse_dpkg_status.cc:99:76: note: Function 'operator<<' argument 2 names different: declaration 'mgs' definition 'msg'. aptitude-0.8.13/src/generic/apt/parse_dpkg_status.cc:166:25: style: Variable 'msg' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1459:63: debug: Function::addArguments found argument 'action' with varid 0. [varid0] aptitude-0.8.13/src/generic/apt/pkg_changelog.cc:253:7: style: The function 'success' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_queue.h:52:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/pkg_changelog.cc:253:7: note: Function in derived class aptitude-0.8.13/src/generic/apt/pkg_changelog.cc:280:7: style: The function 'failure' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_queue.h:60:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/pkg_changelog.cc:280:7: note: Function in derived class aptitude-0.8.13/src/generic/apt/pkg_changelog.cc:331:7: style: The function 'partial_download' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_queue.h:73:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/pkg_changelog.cc:331:7: note: Function in derived class aptitude-0.8.13/src/generic/apt/pkg_changelog.cc:350:7: style: The function 'cancel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_queue.h:105:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/pkg_changelog.cc:350:7: note: Function in derived class aptitude-0.8.13/src/generic/apt/pkg_changelog.cc:664:10: style: The function 'success' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_queue.h:52:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/pkg_changelog.cc:664:10: note: Function in derived class aptitude-0.8.13/src/generic/apt/pkg_changelog.cc:669:10: style: The function 'failure' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_queue.h:60:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/pkg_changelog.cc:669:10: note: Function in derived class aptitude-0.8.13/src/generic/apt/tags.cc:76:10: style:inconclusive: Technically the member function 'tag_list::const_iterator::operator==' can be const. [functionConst] aptitude-0.8.13/src/generic/apt/tags.cc:83:10: style:inconclusive: Technically the member function 'tag_list::const_iterator::operator!=' can be const. [functionConst] aptitude-0.8.13/src/generic/apt/tags.cc:373:14: style: The scope of the variable 'facet' can be reduced. [variableScope] aptitude-0.8.13/src/generic/apt/tasks.cc:187:16: style: The scope of the variable 'task_set' can be reduced. [variableScope] aptitude-0.8.13/src/generic/apt/tasks.cc:438:33: style: Local variable 'desc' shadows outer variable [shadowVariable] aptitude-0.8.13/src/generic/apt/tasks.cc:419:18: note: Shadowed declaration aptitude-0.8.13/src/generic/apt/tasks.cc:438:33: note: Shadow variable aptitude-0.8.13/src/generic/apt/tasks.cc:293:37: performance: Function parameter 'textdomain' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/generic/apt/tasks.cc:293:56: performance: Function parameter 'msgid' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/generic/apt/matching/match.h:65:7: warning:inconclusive: Member variable 'matchable::pkg' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/generic/apt/matching/match.h:65:7: warning:inconclusive: Member variable 'matchable::ver' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/generic/apt/matching/match.h:81:7: style: Class 'matchable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/matching/match.h:207:2: style: Class 'regexp_match' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/matching/match.h:541:9: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/matching/match.h:542:9: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/matching/match.h:565:9: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/matching/match.h:566:9: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/matching/match.cc:2016:12: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/matching/match.cc:2017:12: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/generic/apt/matching/match.h:117:7: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] aptitude-0.8.13/src/generic/apt/matching/match.h:119:2: note: Found duplicate branches for 'if' and 'else'. aptitude-0.8.13/src/generic/apt/matching/match.h:117:7: note: Found duplicate branches for 'if' and 'else'. aptitude-0.8.13/src/generic/controllers/acquire_download_progress.cc:238:70: style: Parameter 'manager' can be declared as reference to const. However it seems that 'start' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/generic/controllers/acquire_download_progress.cc:97:58: note: You might need to cast the function pointer here aptitude-0.8.13/src/generic/controllers/acquire_download_progress.cc:238:70: note: Parameter 'manager' can be declared as reference to const aptitude-0.8.13/src/generic/apt/matching/match.cc:3063:32: style:inconclusive: Function 'setup' argument 2 names different: declaration 'pattern' definition 'p'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/matching/match.cc:196:30: note: Function 'setup' argument 2 names different: declaration 'pattern' definition 'p'. aptitude-0.8.13/src/generic/apt/matching/match.cc:3063:32: note: Function 'setup' argument 2 names different: declaration 'pattern' definition 'p'. aptitude-0.8.13/src/generic/apt/matching/match.cc:1353:35: style: Local variable 'ver' shadows outer variable [shadowVariable] aptitude-0.8.13/src/generic/apt/matching/match.cc:1335:25: note: Shadowed declaration aptitude-0.8.13/src/generic/apt/matching/match.cc:1353:35: note: Shadow variable aptitude-0.8.13/src/generic/apt/matching/match.h:510:15: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/apt/matching/match.h:514:15: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/apt/matching/match.cc:2276:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/apt/matching/match.cc:2313:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/apt/matching/match.cc:2403:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/apt/matching/match.cc:2435:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/controllers/search_input.cc:62:9: style: Class 'search_input_impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/controllers/search_input.cc:79:14: style: The function 'enter_text' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/controllers/search_input.h:64:20: note: Virtual function in base class aptitude-0.8.13/src/generic/controllers/search_input.cc:79:14: note: Function in derived class aptitude-0.8.13/src/generic/controllers/search_input.cc:82:9: style: The function 'connect_activated' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/controllers/search_input.h:73:7: note: Virtual function in base class aptitude-0.8.13/src/generic/controllers/search_input.cc:82:9: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/exceptions.h:58:3: style: Class 'InterruptedException' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/exceptions.h:78:3: style: Class 'ResolverInternalErrorException' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/cost.h:344:16: warning: Identical condition 'index<0', second condition is always false [identicalConditionAfterEarlyExit] aptitude-0.8.13/src/generic/problemresolver/cost.h:337:16: note: If condition 'index<0' is true, the function will return/exit aptitude-0.8.13/src/generic/problemresolver/cost.h:344:16: note: Testing identical condition 'index<0' aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1277:5: performance: Variable 'msg' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] aptitude-0.8.13/src/generic/apt/resolver_manager.cc:231:3: style: Class 'background_suspender' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/resolver_manager.cc:702:3: style: Struct 'background_thread_bootstrap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1275:3: style: Class 'SolutionSearchAbortException' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1228:8: style: The function 'success' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:95:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1228:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1236:8: style: The function 'no_more_time' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:102:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1236:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1244:8: style: The function 'no_more_solutions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:99:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1244:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1251:8: style: The function 'interrupted' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:107:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1251:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1257:8: style: The function 'aborted' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:110:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1257:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1411:8: style: The function 'success' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:95:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1411:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1422:8: style: The function 'no_more_solutions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:99:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1422:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1431:8: style: The function 'no_more_time' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:102:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1431:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1438:8: style: The function 'interrupted' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:107:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1438:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1446:8: style: The function 'aborted' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:110:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1446:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1802:8: style: The function 'success' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:95:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1802:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1895:8: style: The function 'no_more_solutions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:99:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1895:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1919:8: style: The function 'no_more_time' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:102:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1919:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1943:8: style: The function 'interrupted' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:107:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1943:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1952:8: style: The function 'aborted' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/resolver_manager.h:110:18: note: Virtual function in base class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1952:8: note: Function in derived class aptitude-0.8.13/src/generic/apt/resolver_manager.cc:169:55: style:inconclusive: Function 'resolver_manager' argument 1 names different: declaration 'cache_file' definition '_cache_file'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/resolver_manager.h:488:39: note: Function 'resolver_manager' argument 1 names different: declaration 'cache_file' definition '_cache_file'. aptitude-0.8.13/src/generic/apt/resolver_manager.cc:169:55: note: Function 'resolver_manager' argument 1 names different: declaration 'cache_file' definition '_cache_file'. aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1150:63: style:inconclusive: Function 'do_get_solution' argument 2 names different: declaration 'solution_number' definition 'solution_num'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/apt/resolver_manager.h:432:47: note: Function 'do_get_solution' argument 2 names different: declaration 'solution_number' definition 'solution_num'. aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1150:63: note: Function 'do_get_solution' argument 2 names different: declaration 'solution_number' definition 'solution_num'. aptitude-0.8.13/src/generic/apt/resolver_manager.cc:801:32: style: Local variable 'l' shadows outer variable [shadowVariable] aptitude-0.8.13/src/generic/apt/resolver_manager.cc:795:33: note: Shadowed declaration aptitude-0.8.13/src/generic/apt/resolver_manager.cc:801:32: note: Shadow variable aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1465:15: style: Local variable 'undo' shadows outer function [shadowFunction] aptitude-0.8.13/src/generic/apt/resolver_manager.h:698:8: note: Shadowed declaration aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1465:15: note: Shadow variable aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1484:31: style: Local variable 'undo' shadows outer function [shadowFunction] aptitude-0.8.13/src/generic/apt/resolver_manager.h:698:8: note: Shadowed declaration aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1484:31: note: Shadow variable aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1603:31: style: Local variable 'undo' shadows outer function [shadowFunction] aptitude-0.8.13/src/generic/apt/resolver_manager.h:698:8: note: Shadowed declaration aptitude-0.8.13/src/generic/apt/resolver_manager.cc:1603:31: note: Shadow variable aptitude-0.8.13/src/generic/apt/resolver_manager.cc:824:6: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:27:16: warning: Member variable 'dummy_package::cur' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:659:8: performance:inconclusive: Technically the member function 'dummy_universe::is_candidate_for_initial_set' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:715:6: warning: Value of pointer 'rep', which points to allocated memory, is copied in copy constructor instead of allocating new memory. [copyCtorPointerCopying] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:318:5: style: Class 'package' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:380:5: style: Class 'version' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:440:5: style: Class 'dep' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:722:3: style: Class 'dummy_universe_ref' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:691:5: style: Struct '_rep' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:820:3: style: Class 'ParseError' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:61:3: style: Class 'wrap_ptr_iter < dummy_version , version >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:61:3: style: Class 'wrap_ptr_iter < dummy_dep , dep >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:61:3: style: Class 'wrap_ptr_iter < dummy_package , package >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:87:52: style:inconclusive: Function 'solved_by' argument 1 names different: declaration 'other' definition 'ver'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:507:35: note: Function 'solved_by' argument 1 names different: declaration 'other' definition 'ver'. aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:87:52: note: Function 'solved_by' argument 1 names different: declaration 'other' definition 'ver'. aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:136:14: style:inconclusive: Function 'add_dep' argument 6 names different: declaration 'candidate_for_initial_set' definition 'is_candidate_for_initial_set'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:632:46: note: Function 'add_dep' argument 6 names different: declaration 'candidate_for_initial_set' definition 'is_candidate_for_initial_set'. aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:136:14: note: Function 'add_dep' argument 6 names different: declaration 'candidate_for_initial_set' definition 'is_candidate_for_initial_set'. aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:141:48: style: Local variable 'packages' shadows outer variable [shadowVariable] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:562:32: note: Shadowed declaration aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:141:48: note: Shadow variable aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:146:22: style: Local variable 'pkg' shadows outer variable [shadowVariable] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:138:18: note: Shadowed declaration aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:146:22: note: Shadow variable aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:762:28: performance: Function parameter 'pkg_name' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:762:50: performance: Function parameter 'pkg_ver' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:114:21: performance: Function parameter 'the_versions' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:138:18: style: Variable 'pkg' can be declared as pointer to const [constVariablePointer] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:573:36: style: Parameter 'p1' can be declared as pointer to const [constParameterPointer] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:573:55: style: Parameter 'p2' can be declared as pointer to const [constParameterPointer] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:581:36: style: Parameter 'v1' can be declared as pointer to const [constParameterPointer] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:581:55: style: Parameter 'v2' can be declared as pointer to const [constParameterPointer] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.h:501:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:41:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/problemresolver/dummy_universe.cc:81:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:64:3: style: Class 'expression_weak_ref_generic' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:359:3: style: Class 'expression_wrapper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:512:3: style: Class 'var_e' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:645:3: style: Class 'not_e' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:286:3: style: Class 'expression_box < bool >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:238:5: style: Class 'parent_equals_weak_ref' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:103:3: style: Class 'expression_weak_ref < expression_container < bool > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:104:3: style: Class 'expression_weak_ref < expression_container < bool > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:573:8: style: The function 'child_modified' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:272:16: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:573:8: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:577:8: style: The function 'add_child' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:416:16: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:577:8: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:578:8: style: The function 'remove_child' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:422:16: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:578:8: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:608:8: style: The function 'get_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:255:13: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:608:8: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:609:15: style: The function 'get_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:434:23: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:609:15: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:639:8: style: The function 'get_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:255:13: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:639:8: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:640:15: style: The function 'get_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:434:23: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:640:15: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:657:8: style: The function 'child_modified' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:272:16: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:657:8: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:660:8: style: The function 'get_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:331:5: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:660:8: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:661:8: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:344:8: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:661:8: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:436:8: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:256:16: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:436:8: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:300:4: style: The destructor '~expression_box < bool >' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:213:12: note: Virtual destructor in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:300:4: note: Destructor in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:331:5: style: The function 'get_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:255:13: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:331:5: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:344:8: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:256:16: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:344:8: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.cc:54:82: style:inconclusive: Function 'add_child' argument 1 names different: declaration 'new_child' definition 'child'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:577:67: note: Function 'add_child' argument 1 names different: declaration 'new_child' definition 'child'. aptitude-0.8.13/src/generic/problemresolver/incremental_expression.cc:54:82: note: Function 'add_child' argument 1 names different: declaration 'new_child' definition 'child'. aptitude-0.8.13/src/generic/util/sqlite.h:125:7: debug: Failed to parse 'typedef boost :: multi_index_container < statement_cache_entry , boost :: multi_index :: indexed_by < boost :: multi_index :: hashed_non_unique < boost :: multi_index :: member < statement_cache_entry , std :: string , & statement_cache_entry :: sql > > , boost :: multi_index :: sequenced < > > > :: nth_index < statement_cache_hash_index_N > :: type statement_cache_hash_index ;'. The checking continues anyway. [simplifyTypedef] aptitude-0.8.13/src/generic/util/sqlite.h:126:7: debug: Failed to parse 'typedef boost :: multi_index_container < statement_cache_entry , boost :: multi_index :: indexed_by < boost :: multi_index :: hashed_non_unique < boost :: multi_index :: member < statement_cache_entry , std :: string , & statement_cache_entry :: sql > > , boost :: multi_index :: sequenced < > > > :: nth_index < statement_cache_mru_N > :: type statement_cache_mru ;'. The checking continues anyway. [simplifyTypedef] aptitude-0.8.13/src/generic/problemresolver/cost.cc:246:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/util/sqlite.h:383:12: style:inconclusive: Technically the member function 'aptitude::sqlite::statement::require_data' can be const. [functionConst] aptitude-0.8.13/src/generic/util/temp.h:53:5: style: Class 'TemporaryCreationFailure' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/util/temp.h:106:5: style: Class 'dir' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/util/temp.h:162:5: style: Class 'impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/util/temp.h:257:5: style: Class 'name' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/util/temp.h:297:5: style: Class 'impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/util/file_cache.h:38:7: style: Class 'FileCacheException' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/util/sqlite.h:157:2: style: Class 'statement_proxy_impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/util/sqlite.h:182:2: style: Class 'lock' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/util/sqlite.h:263:2: style: Class 'statement_proxy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/util/sqlite.h:327:2: style: Class 'execution' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/util/file_cache.cc:381:7: style: The function 'putItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/file_cache.h:67:20: note: Virtual function in base class aptitude-0.8.13/src/generic/util/file_cache.cc:381:7: note: Function in derived class aptitude-0.8.13/src/generic/util/file_cache.cc:662:13: style: The function 'getItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/file_cache.h:96:26: note: Virtual function in base class aptitude-0.8.13/src/generic/util/file_cache.cc:662:13: note: Function in derived class aptitude-0.8.13/src/generic/util/file_cache.cc:842:7: style: The function 'putItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/file_cache.h:67:20: note: Virtual function in base class aptitude-0.8.13/src/generic/util/file_cache.cc:842:7: note: Function in derived class aptitude-0.8.13/src/generic/util/file_cache.cc:850:13: style: The function 'getItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/file_cache.h:96:26: note: Virtual function in base class aptitude-0.8.13/src/generic/util/file_cache.cc:850:13: note: Function in derived class aptitude-0.8.13/src/generic/util/file_cache.cc:506:14: style: The scope of the variable 'first' can be reduced. [variableScope] aptitude-0.8.13/src/generic/util/file_cache.cc:688:10: style: The scope of the variable 'found' can be reduced. [variableScope] aptitude-0.8.13/src/generic/util/file_cache.cc:599:12: style: Local variable 'buf' shadows outer variable [shadowVariable] aptitude-0.8.13/src/generic/util/file_cache.cc:449:20: note: Shadowed declaration aptitude-0.8.13/src/generic/util/file_cache.cc:599:12: note: Shadow variable aptitude-0.8.13/src/generic/util/logging.cc:190:9: debug: Failed to parse 'typedef multi_index_container < std :: shared_ptr < Logger :: Impl > , indexed_by < boost :: multi_index :: hashed_unique < boost :: multi_index :: tag < by_category_tag > , const_mem_fun < Logger :: Impl , const std :: string & , & Logger :: Impl :: getCategory > > , hashed_non_unique < boost :: multi_index :: tag < by_parent_tag > , const_mem_fun < Logger :: Impl , const std :: shared_ptr < Logger :: Impl > & , & Logger :: Impl :: getParent > > > > :: index < by_category_tag > :: type by_category_index ;'. The checking continues anyway. [simplifyTypedef] aptitude-0.8.13/src/generic/util/logging.cc:191:9: debug: Failed to parse 'typedef multi_index_container < std :: shared_ptr < Logger :: Impl > , indexed_by < boost :: multi_index :: hashed_unique < boost :: multi_index :: tag < by_category_tag > , const_mem_fun < Logger :: Impl , const std :: string & , & Logger :: Impl :: getCategory > > , hashed_non_unique < boost :: multi_index :: tag < by_parent_tag > , const_mem_fun < Logger :: Impl , const std :: shared_ptr < Logger :: Impl > & , & Logger :: Impl :: getParent > > > > :: index < by_parent_tag > :: type by_parent_index ;'. The checking continues anyway. [simplifyTypedef] aptitude-0.8.13/src/generic/util/logging.cc:88:14: style: The function 'log' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/logging.h:125:22: note: Virtual function in base class aptitude-0.8.13/src/generic/util/logging.cc:88:14: note: Function in derived class aptitude-0.8.13/src/generic/util/logging.cc:93:28: style: The function 'getCategory' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/logging.h:131:36: note: Virtual function in base class aptitude-0.8.13/src/generic/util/logging.cc:93:28: note: Function in derived class aptitude-0.8.13/src/generic/util/logging.cc:96:14: style: The function 'setLevel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/logging.h:147:22: note: Virtual function in base class aptitude-0.8.13/src/generic/util/logging.cc:96:14: note: Function in derived class aptitude-0.8.13/src/generic/util/logging.cc:99:9: style: The function 'connect_message_logged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/logging.h:172:9: note: Virtual function in base class aptitude-0.8.13/src/generic/util/logging.cc:99:9: note: Function in derived class aptitude-0.8.13/src/generic/util/logging.cc:252:19: style: The function 'getLogger' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/logging.h:251:27: note: Virtual function in base class aptitude-0.8.13/src/generic/util/logging.cc:252:19: note: Function in derived class aptitude-0.8.13/src/generic/util/progress_info.h:61:7: style: Class 'progress_info' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/util/progress_info.h:68:7: style: Class 'progress_info' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/util/temp.cc:265:14: warning: Member variable 'impl::forceful_delete' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/generic/util/sqlite.cc:190:2: style: Struct 'free_on_destroy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/util/temp.cc:147:38: style:inconclusive: Function 'initialize' argument 1 names different: declaration 'prefix' definition 'initial_prefix'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/util/temp.h:72:38: note: Function 'initialize' argument 1 names different: declaration 'prefix' definition 'initial_prefix'. aptitude-0.8.13/src/generic/util/temp.cc:147:38: note: Function 'initialize' argument 1 names different: declaration 'prefix' definition 'initial_prefix'. aptitude-0.8.13/src/generic/util/temp.cc:225:47: style:inconclusive: Function 'init_dir' argument 1 names different: declaration 'prefix' definition 'initial_prefix'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/util/temp.h:146:38: note: Function 'init_dir' argument 1 names different: declaration 'prefix' definition 'initial_prefix'. aptitude-0.8.13/src/generic/util/temp.cc:225:47: note: Function 'init_dir' argument 1 names different: declaration 'prefix' definition 'initial_prefix'. aptitude-0.8.13/src/generic/util/temp.cc:282:39: style:inconclusive: Function 'impl' argument 1 names different: declaration 'filename' definition '_filename'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/util/temp.h:297:29: note: Function 'impl' argument 1 names different: declaration 'filename' definition '_filename'. aptitude-0.8.13/src/generic/util/temp.cc:282:39: note: Function 'impl' argument 1 names different: declaration 'filename' definition '_filename'. aptitude-0.8.13/src/generic/util/sqlite.cc:463:46: style:inconclusive: Function 'write' argument 2 names different: declaration 'in' definition 'out'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/util/sqlite.h:613:42: note: Function 'write' argument 2 names different: declaration 'in' definition 'out'. aptitude-0.8.13/src/generic/util/sqlite.cc:463:46: note: Function 'write' argument 2 names different: declaration 'in' definition 'out'. aptitude-0.8.13/src/generic/problemresolver/resolver_undo.h:52:21: debug: Function::addArguments found argument '_reverse_action' with varid 0. [varid0] aptitude-0.8.13/src/generic/util/throttle.cc:61:14: style: The function 'update_required' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/throttle.h:41:20: note: Virtual function in base class aptitude-0.8.13/src/generic/util/throttle.cc:61:14: note: Function in derived class aptitude-0.8.13/src/generic/util/throttle.cc:66:14: style: The function 'reset_timer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/throttle.h:46:20: note: Virtual function in base class aptitude-0.8.13/src/generic/util/throttle.cc:66:14: note: Function in derived class aptitude-0.8.13/src/generic/util/undo.h:46:8: style:inconclusive: Technically the member function 'undo_group::empty' can be const. [functionConst] aptitude-0.8.13/src/generic/util/undo.h:75:16: style:inconclusive: Technically the member function 'undo_list::size' can be const. [functionConst] aptitude-0.8.13/src/generic/util/undo.h:35:16: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/undo.h:23:16: note: Virtual function in base class aptitude-0.8.13/src/generic/util/undo.h:35:16: note: Function in derived class aptitude-0.8.13/src/generic/util/undo.h:48:12: style: The destructor '~undo_group' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/undo.h:26:12: note: Virtual destructor in base class aptitude-0.8.13/src/generic/util/undo.h:48:12: note: Destructor in derived class aptitude-0.8.13/src/generic/util/undo.h:37:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/generic/util/undo.h:50:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/generic/util/undo.h:92:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/generic/util/undo.cc:27:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/generic/apt/matching/parse.cc:657:40: performance: Function parameter 'terminators' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/generic/views/download_progress.cc:80:7: style: Class 'show_worker_status' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/views/download_progress.cc:107:40: performance:inconclusive: Use const reference for 'active_downloads' to avoid unnecessary data copying. [redundantCopyLocalConst] aptitude-0.8.13/src/generic/apt/matching/parse.cc:1308:13: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] aptitude-0.8.13/src/generic/apt/matching/parse.cc:567:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/generic/util/util.cc:424:27: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] aptitude-0.8.13/src/gtk/areas.cc:87:34: warning: The class 'areas_impl' defines member function with name 'get_areas' also defined in its parent class 'areas'. [duplInheritedMember] aptitude-0.8.13/src/gtk/areas.h:48:50: note: Parent function 'areas::get_areas' aptitude-0.8.13/src/gtk/areas.cc:87:34: note: Derived function 'areas_impl::get_areas' aptitude-0.8.13/src/gtk/areas.cc:88:34: warning: The class 'areas_impl' defines member function with name 'get_browse' also defined in its parent class 'areas'. [duplInheritedMember] aptitude-0.8.13/src/gtk/areas.h:51:50: note: Parent function 'areas::get_browse' aptitude-0.8.13/src/gtk/areas.cc:88:34: note: Derived function 'areas_impl::get_browse' aptitude-0.8.13/src/gtk/areas.cc:89:34: warning: The class 'areas_impl' defines member function with name 'get_go' also defined in its parent class 'areas'. [duplInheritedMember] aptitude-0.8.13/src/gtk/areas.h:54:50: note: Parent function 'areas::get_go' aptitude-0.8.13/src/gtk/areas.cc:89:34: note: Derived function 'areas_impl::get_go' aptitude-0.8.13/src/gtk/areas.cc:90:34: warning: The class 'areas_impl' defines member function with name 'get_preferences' also defined in its parent class 'areas'. [duplInheritedMember] aptitude-0.8.13/src/gtk/areas.h:57:50: note: Parent function 'areas::get_preferences' aptitude-0.8.13/src/gtk/areas.cc:90:34: note: Derived function 'areas_impl::get_preferences' aptitude-0.8.13/src/gtk/areas.cc:91:34: warning: The class 'areas_impl' defines member function with name 'get_search' also defined in its parent class 'areas'. [duplInheritedMember] aptitude-0.8.13/src/gtk/areas.h:60:50: note: Parent function 'areas::get_search' aptitude-0.8.13/src/gtk/areas.cc:91:34: note: Derived function 'areas_impl::get_search' aptitude-0.8.13/src/gtk/areas.cc:92:34: warning: The class 'areas_impl' defines member function with name 'get_upgrade' also defined in its parent class 'areas'. [duplInheritedMember] aptitude-0.8.13/src/gtk/areas.h:63:50: note: Parent function 'areas::get_upgrade' aptitude-0.8.13/src/gtk/areas.cc:92:34: note: Derived function 'areas_impl::get_upgrade' aptitude-0.8.13/src/generic/util/util.cc:502:17: performance: Range variable 'd' should be declared as const reference. [iterateByValue] aptitude-0.8.13/src/generic/util/util.cc:424:20: style: Variable 'dent' can be declared as pointer to const [constVariablePointer] aptitude-0.8.13/src/generic/util/util.cc:275:13: style: Variable 'done' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/generic/util/util.cc:324:13: style: Variable 'done' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/generic/util/util.cc:135:15: error: va_list 'ap2' was opened but not closed by va_end(). [va_end_missing] aptitude-0.8.13/src/gtk/progress.h:46:50: warning: The class 'guiOpProgress' defines member function with name 'create' also defined in its parent class 'refcounted_progress'. [duplInheritedMember] aptitude-0.8.13/src/ui_download_manager.h:71:54: note: Parent function 'refcounted_progress::create' aptitude-0.8.13/src/gtk/progress.h:46:50: note: Derived function 'guiOpProgress::create' aptitude-0.8.13/src/gtk/packagestab.h:208:7: style: Class 'PackagesTab' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/dependency_chains_tab.h:60:5: style: Class 'DependencyChainsTab' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/entityview.h:96:5: style: Class 'HeaderEntity' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/pkgview.h:60:7: style: Class 'PkgEntity' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/pkgview.h:253:7: style: Class 'background_build_store' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/pkgview.h:335:7: style: Class 'Generator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/ui_download_manager.h:157:5: style: Class 'generic_refcounted' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/dependency_chains_tab.cc:161:5: style: Class 'DependencyChainActionEntity' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/packagestab.h:213:32: style: The function 'get_package_menu_actions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/tab.h:124:40: note: Virtual function in base class aptitude-0.8.13/src/gtk/packagestab.h:213:32: note: Function in derived class aptitude-0.8.13/src/gtk/packagestab.h:214:12: style: The function 'dispatch_package_menu_action' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/tab.h:132:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/packagestab.h:214:12: note: Function in derived class aptitude-0.8.13/src/gtk/packagestab.h:215:12: style: The function 'get_undo_available' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/tab.h:138:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/packagestab.h:215:12: note: Function in derived class aptitude-0.8.13/src/gtk/packagestab.h:216:12: style: The function 'dispatch_undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/tab.h:144:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/packagestab.h:216:12: note: Function in derived class aptitude-0.8.13/src/gtk/packagestab.h:219:12: style: The function 'get_edit_columns_available' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/tab.h:150:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/packagestab.h:219:12: note: Function in derived class aptitude-0.8.13/src/gtk/packagestab.h:220:12: style: The function 'dispatch_edit_columns' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/tab.h:156:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/packagestab.h:220:12: note: Function in derived class aptitude-0.8.13/src/gtk/entityview.h:98:10: style: The function 'fill_row' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/entityview.h:58:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/entityview.h:98:10: note: Function in derived class aptitude-0.8.13/src/gtk/entityview.h:99:10: style: The function 'add_packages' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/entityview.h:73:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/entityview.h:99:10: note: Function in derived class aptitude-0.8.13/src/gtk/entityview.h:100:10: style: The function 'activated' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/entityview.h:61:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/entityview.h:100:10: note: Function in derived class aptitude-0.8.13/src/gtk/entityview.h:103:10: style: The function 'add_actions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/entityview.h:75:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/entityview.h:103:10: note: Function in derived class aptitude-0.8.13/src/gtk/entityview.h:104:10: style: The function 'dispatch_action' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/entityview.h:87:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/entityview.h:104:10: note: Function in derived class aptitude-0.8.13/src/gtk/pkgview.h:62:12: style: The function 'activated' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/entityview.h:61:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/pkgview.h:62:12: note: Function in derived class aptitude-0.8.13/src/gtk/pkgview.h:76:12: style: The function 'fill_row' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/entityview.h:58:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/pkgview.h:76:12: note: Function in derived class aptitude-0.8.13/src/gtk/pkgview.h:77:12: style: The function 'add_packages' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/entityview.h:73:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/pkgview.h:77:12: note: Function in derived class aptitude-0.8.13/src/gtk/pkgview.h:78:12: style: The function 'add_actions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/entityview.h:75:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/pkgview.h:78:12: note: Function in derived class aptitude-0.8.13/src/gtk/pkgview.h:79:12: style: The function 'dispatch_action' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/entityview.h:87:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/pkgview.h:79:12: note: Function in derived class aptitude-0.8.13/src/gtk/pkgview.h:316:14: style: The destructor '~PkgViewBase' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/entityview.h:238:16: note: Virtual destructor in base class aptitude-0.8.13/src/gtk/pkgview.h:316:14: note: Destructor in derived class aptitude-0.8.13/src/gtk/dependency_chains_tab.cc:169:10: style: The function 'fill_row' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/pkgview.h:76:12: note: Virtual function in base class aptitude-0.8.13/src/gtk/dependency_chains_tab.cc:169:10: note: Function in derived class aptitude-0.8.13/src/gtk/notify.h:61:7: style: Class 'Notification' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/download.cc:171:27: style:inconclusive: Function 'Fail' argument 2 names different: declaration 'manager' definition 'log'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/download.h:96:63: note: Function 'Fail' argument 2 names different: declaration 'manager' definition 'log'. aptitude-0.8.13/src/gtk/download.cc:171:27: note: Function 'Fail' argument 2 names different: declaration 'manager' definition 'log'. aptitude-0.8.13/src/gtk/download.cc:190:58: style:inconclusive: Function 'IMSHit' argument 1 names different: declaration 'itemdesc' definition 'Itm'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/download.h:93:39: note: Function 'IMSHit' argument 1 names different: declaration 'itemdesc' definition 'Itm'. aptitude-0.8.13/src/gtk/download.cc:190:58: note: Function 'IMSHit' argument 1 names different: declaration 'itemdesc' definition 'Itm'. aptitude-0.8.13/src/gtk/download.cc:151:56: style: Parameter 'manager' can be declared as reference to const. However it seems that 'Start' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:148:71: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:151:56: note: Parameter 'manager' can be declared as reference to const aptitude-0.8.13/src/gtk/download.cc:155:55: style: Parameter 'manager' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/gtk/download.cc:164:28: style: Parameter 'manager' can be declared as reference to const. However it seems that 'Pulse' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:147:71: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:164:28: note: Parameter 'manager' can be declared as reference to const aptitude-0.8.13/src/gtk/download.cc:170:56: style: Parameter 'Itm' can be declared as reference to const. However it seems that 'Fail' is a callback function, if 'Itm' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:146:70: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:170:56: note: Parameter 'Itm' can be declared as reference to const aptitude-0.8.13/src/gtk/download.cc:171:27: style: Parameter 'log' can be declared as reference to const. However it seems that 'Fail' is a callback function, if 'log' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:146:70: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:171:27: note: Parameter 'log' can be declared as reference to const aptitude-0.8.13/src/gtk/download.cc:190:58: style: Parameter 'Itm' can be declared as reference to const. However it seems that 'IMSHit' is a callback function, if 'Itm' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:143:72: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:190:58: note: Parameter 'Itm' can be declared as reference to const aptitude-0.8.13/src/gtk/download.cc:191:29: style: Parameter 'manager' can be declared as reference to const. However it seems that 'IMSHit' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:143:72: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:191:29: note: Parameter 'manager' can be declared as reference to const aptitude-0.8.13/src/gtk/download.cc:196:57: style: Parameter 'Itm' can be declared as reference to const. However it seems that 'Fetch' is a callback function, if 'Itm' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:144:71: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:196:57: note: Parameter 'Itm' can be declared as reference to const aptitude-0.8.13/src/gtk/download.cc:197:28: style: Parameter 'manager' can be declared as reference to const. However it seems that 'Fetch' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:144:71: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:197:28: note: Parameter 'manager' can be declared as reference to const aptitude-0.8.13/src/gtk/download.cc:201:56: style: Parameter 'Itm' can be declared as reference to const. However it seems that 'Done' is a callback function, if 'Itm' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:145:70: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:201:56: note: Parameter 'Itm' can be declared as reference to const aptitude-0.8.13/src/gtk/download.cc:202:27: style: Parameter 'manager' can be declared as reference to const. However it seems that 'Done' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:145:70: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:202:27: note: Parameter 'manager' can be declared as reference to const aptitude-0.8.13/src/gtk/download.cc:429:39: style: Parameter 'Itm' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/gtk/download.cc:430:24: style: Parameter 'log' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/gtk/download.cc:436:31: style: Parameter 'manager' can be declared as reference to const. However it seems that 'MediaChange' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:420:33: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:436:31: note: Parameter 'manager' can be declared as reference to const aptitude-0.8.13/src/gtk/download.cc:529:38: style: Parameter 'manager' can be declared as reference to const. However it seems that 'Stop' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:426:33: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:529:38: note: Parameter 'manager' can be declared as reference to const aptitude-0.8.13/src/gtk/download.cc:64:26: style: Variable 'Item' can be declared as pointer to const [constVariablePointer] aptitude-0.8.13/src/gtk/dashboardtab.h:255:5: style: Class 'DashboardTab' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/dashboardtab.h:147:7: style: Class 'redirect_from_background' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/info.h:68:7: style: Class 'InfoTab' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/resolver.h:366:7: style: Class 'ResolverTab' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/resolver.h:342:7: style: Class 'suppress_toggle_signals' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/dashboardtab.h:256:6: style: The destructor '~DashboardTab' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/tab.h:108:16: note: Virtual destructor in base class aptitude-0.8.13/src/gtk/dashboardtab.h:256:6: note: Destructor in derived class aptitude-0.8.13/src/gtk/dashboardtab.h:258:10: style: The function 'get_edit_columns_available' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/tab.h:150:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/dashboardtab.h:258:10: note: Function in derived class aptitude-0.8.13/src/gtk/dashboardtab.h:259:10: style: The function 'dispatch_edit_columns' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/tab.h:156:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/dashboardtab.h:259:10: note: Function in derived class aptitude-0.8.13/src/gtk/dashboardtab.h:162:32: performance: Function parameter 'errmsg' should be passed by const reference. However it seems that 'aborted' is a callback function. [passedByValueCallback] aptitude-0.8.13/src/gtk/dashboardtab.cc:512:77: note: Function pointer used here. aptitude-0.8.13/src/gtk/dashboardtab.h:162:32: note: Function parameter 'errmsg' should be passed by const reference. However it seems that 'aborted' is a callback function. aptitude-0.8.13/src/gtk/dashboardtab.cc:684:59: performance: Function parameter 'errmsg' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/gtk/dpkg_terminal.cc:363:3: debug: SymbolDatabase couldn't resolve all user defined types. [debug] aptitude-0.8.13/src/gtk/dpkg_terminal.cc:444:3: debug: SymbolDatabase couldn't resolve all user defined types. [debug] aptitude-0.8.13/src/gtk/dpkg_terminal.cc:335:5: style: Class 'TemporarySocketFail' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/dpkg_terminal.cc:453:5: style: Class 'temporary_client_socket' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/dpkg_terminal.cc:196:18: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/gtk/dpkg_terminal.cc:206:33: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/gtk/dpkg_terminal.cc:395:35: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/gtk/dpkg_terminal.cc:476:29: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/gtk/entitysummary.cc:191:7: style: Class 'InfoTabButtons' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/entitysummary.cc:367:28: style: Variable 'longdesc' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/gtk/errortab.cc:95:7: warning:inconclusive: Possible null pointer dereference: errors_treeview [nullPointer] aptitude-0.8.13/src/gtk/errortab.cc:87:38: note: Assignment 'errors_treeview=NULL', assigned value is 0 aptitude-0.8.13/src/gtk/errortab.cc:95:7: note: Null pointer dereference aptitude-0.8.13/src/gtk/errortab.cc:98:5: warning:inconclusive: Possible null pointer dereference: errors_treeview [nullPointer] aptitude-0.8.13/src/gtk/errortab.cc:87:38: note: Assignment 'errors_treeview=NULL', assigned value is 0 aptitude-0.8.13/src/gtk/errortab.cc:98:5: note: Null pointer dereference aptitude-0.8.13/src/gtk/errortab.cc:106:7: warning:inconclusive: Possible null pointer dereference: errors_treeview [nullPointer] aptitude-0.8.13/src/gtk/errortab.cc:87:38: note: Assignment 'errors_treeview=NULL', assigned value is 0 aptitude-0.8.13/src/gtk/errortab.cc:106:7: note: Null pointer dereference aptitude-0.8.13/src/gtk/errortab.cc:108:5: warning:inconclusive: Possible null pointer dereference: errors_treeview [nullPointer] aptitude-0.8.13/src/gtk/errortab.cc:87:38: note: Assignment 'errors_treeview=NULL', assigned value is 0 aptitude-0.8.13/src/gtk/errortab.cc:108:5: note: Null pointer dereference aptitude-0.8.13/src/gtk/errortab.cc:110:5: warning:inconclusive: Possible null pointer dereference: errors_treeview [nullPointer] aptitude-0.8.13/src/gtk/errortab.cc:87:38: note: Assignment 'errors_treeview=NULL', assigned value is 0 aptitude-0.8.13/src/gtk/errortab.cc:110:5: note: Null pointer dereference aptitude-0.8.13/src/gtk/filesview.cc:275:14: warning: Member variable 'FilesView::tree' is not initialized in the constructor. [uninitMemberVarPrivate] aptitude-0.8.13/src/gtk/filesview.cc:275:14: warning: Member variable 'FilesView::Type' is not initialized in the constructor. [uninitMemberVarPrivate] aptitude-0.8.13/src/gtk/filesview.cc:275:14: warning: Member variable 'FilesView::File' is not initialized in the constructor. [uninitMemberVarPrivate] aptitude-0.8.13/src/gtk/filesview.h:81:7: style: Class 'FilesView' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/filesview.cc:275:39: style:inconclusive: Function 'FilesView' argument 1 names different: declaration 'treeview' definition '_treeview'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/filesview.h:81:32: note: Function 'FilesView' argument 1 names different: declaration 'treeview' definition '_treeview'. aptitude-0.8.13/src/gtk/filesview.cc:275:39: note: Function 'FilesView' argument 1 names different: declaration 'treeview' definition '_treeview'. aptitude-0.8.13/src/gtk/filesview.cc:142:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/gtk/entityview.cc:46:52: style:inconclusive: Function 'fill_row' argument 1 names different: declaration 'columns' definition 'cols'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/entityview.h:98:40: note: Function 'fill_row' argument 1 names different: declaration 'columns' definition 'cols'. aptitude-0.8.13/src/gtk/entityview.cc:46:52: note: Function 'fill_row' argument 1 names different: declaration 'columns' definition 'cols'. aptitude-0.8.13/src/gtk/entityview.cc:711:116: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/gtk/entityview.cc:719:47: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/gtk/entityview.cc:738:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/gtk/hyperlink.cc:135:7: style: Class 'HyperlinkTag' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/hyperlink.cc:58:91: style: C-style pointer casting [cstyleCast] aptitude-0.8.13/src/gtk/changelog.cc:128:7: style: Class 'TextBufferUserAction' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/changelog.cc:800:7: style: Class 'check_cache_for_parsed_changelogs_job' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/mainwindow.cc:82:20: style: The function 'get_window' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/mainwindow.h:60:26: note: Virtual function in base class aptitude-0.8.13/src/gtk/mainwindow.cc:82:20: note: Function in derived class aptitude-0.8.13/src/gtk/mainwindow.cc:83:30: style: The function 'get_areas' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/mainwindow.h:63:36: note: Virtual function in base class aptitude-0.8.13/src/gtk/mainwindow.cc:83:30: note: Function in derived class aptitude-0.8.13/src/gtk/mainwindow.cc:94:51: style:inconclusive: Function 'create_mainwindow' argument 3 names different: declaration 'areas' definition 'all_areas'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/mainwindow.h:77:51: note: Function 'create_mainwindow' argument 3 names different: declaration 'areas' definition 'all_areas'. aptitude-0.8.13/src/gtk/mainwindow.cc:94:51: note: Function 'create_mainwindow' argument 3 names different: declaration 'areas' definition 'all_areas'. aptitude-0.8.13/src/gtk/notify.cc:77:51: style:inconclusive: Function 'prepend_widget' argument 1 names different: declaration 'w' definition 'widget'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/notify.h:87:40: note: Function 'prepend_widget' argument 1 names different: declaration 'w' definition 'widget'. aptitude-0.8.13/src/gtk/notify.cc:77:51: note: Function 'prepend_widget' argument 1 names different: declaration 'w' definition 'widget'. aptitude-0.8.13/src/gtk/info.cc:138:7: style: Class 'VersionEntity' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/info.cc:253:7: style: Class 'NotAvailableEntity' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/info.cc:294:7: style: Class 'DependencyEntity' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/info.cc:440:39: style: Local variable 'ver' shadows outer argument [shadowArgument] aptitude-0.8.13/src/gtk/info.cc:379:39: note: Shadowed declaration aptitude-0.8.13/src/gtk/info.cc:440:39: note: Shadow variable aptitude-0.8.13/src/gtk/info.cc:271:58: style: Parameter 'packages' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/gtk/info.cc:281:50: style: Parameter 'actions' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/gtk/info.cc:712:27: style: Variable 'longdesc' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/gtk/post_event.cc:66:9: style: Class 'set_bool_in_scope' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/post_event.cc:96:45: style:inconclusive: Function 'post_event' argument 1 names different: declaration 'thunk' definition 'event'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/post_event.h:38:45: note: Function 'post_event' argument 1 names different: declaration 'thunk' definition 'event'. aptitude-0.8.13/src/gtk/post_event.cc:96:45: note: Function 'post_event' argument 1 names different: declaration 'thunk' definition 'event'. aptitude-0.8.13/src/gtk/previewtab.h:59:7: style: Class 'Generator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/previewtab.h:84:7: style: Class 'PreviewTab' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/previewtab.cc:42:58: style:inconclusive: Function 'Generator' argument 1 names different: declaration 'columns' definition '_entity_columns'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/previewtab.h:59:38: note: Function 'Generator' argument 1 names different: declaration 'columns' definition '_entity_columns'. aptitude-0.8.13/src/gtk/previewtab.cc:42:58: note: Function 'Generator' argument 1 names different: declaration 'columns' definition '_entity_columns'. aptitude-0.8.13/src/gtk/previewtab.cc:48:79: style:inconclusive: Function 'create' argument 1 names different: declaration 'columns' definition 'entity_columns'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/previewtab.h:60:53: note: Function 'create' argument 1 names different: declaration 'columns' definition 'entity_columns'. aptitude-0.8.13/src/gtk/previewtab.cc:48:79: note: Function 'create' argument 1 names different: declaration 'columns' definition 'entity_columns'. aptitude-0.8.13/src/gtk/previewtab.cc:236:35: style: Variable 'longdesc' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/gtk/pkgview.cc:375:5: performance: Variable 'generatorK' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] aptitude-0.8.13/src/gtk/pkgview.cc:376:5: performance: Variable 'limit' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] aptitude-0.8.13/src/gtk/pkgview.cc:438:7: style: Class 'ensure_done_callback' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/pkgview.cc:280:27: style: Redundant condition: state.Status==2. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] aptitude-0.8.13/src/gtk/pkgview.cc:146:49: style:inconclusive: Function 'fill_row' argument 1 names different: declaration 'columns' definition 'cols'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/pkgview.h:76:42: note: Function 'fill_row' argument 1 names different: declaration 'columns' definition 'cols'. aptitude-0.8.13/src/gtk/pkgview.cc:146:49: note: Function 'fill_row' argument 1 names different: declaration 'columns' definition 'cols'. aptitude-0.8.13/src/gtk/pkgview.cc:370:28: style:inconclusive: Function 'PkgViewBase' argument 5 names different: declaration 'limit' definition '_limit'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/pkgview.h:313:24: note: Function 'PkgViewBase' argument 5 names different: declaration 'limit' definition '_limit'. aptitude-0.8.13/src/gtk/pkgview.cc:370:28: note: Function 'PkgViewBase' argument 5 names different: declaration 'limit' definition '_limit'. aptitude-0.8.13/src/gtk/pkgview.cc:768:90: style:inconclusive: Function 'set_limit' argument 1 names different: declaration 'limit' definition '_limit'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/pkgview.h:322:79: note: Function 'set_limit' argument 1 names different: declaration 'limit' definition '_limit'. aptitude-0.8.13/src/gtk/pkgview.cc:768:90: note: Function 'set_limit' argument 1 names different: declaration 'limit' definition '_limit'. aptitude-0.8.13/src/gtk/pkgview.cc:774:54: style:inconclusive: Function 'Generator' argument 1 names different: declaration 'columns' definition '_columns'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/pkgview.h:335:38: note: Function 'Generator' argument 1 names different: declaration 'columns' definition '_columns'. aptitude-0.8.13/src/gtk/pkgview.cc:774:54: note: Function 'Generator' argument 1 names different: declaration 'columns' definition '_columns'. aptitude-0.8.13/src/gtk/gui.cc:148:7: style: Class 'set_bool_in_scope' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/gui.cc:319:7: style: Class 'DpkgTerminalTab' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/gui.cc:807:2: style: Class 'DpkgTerminalNotification' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/gui.cc:1066:5: style: Class 'BrokenPackagesNotification' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/gui.cc:1139:5: style: Class 'NotificationInstallRemove' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/gui.cc:1615:24: warning: Either the condition 'tab!=NULL' is redundant or there is possible null pointer dereference: tab. [nullPointerRedundantCheck] aptitude-0.8.13/src/gtk/gui.cc:1610:12: note: Assuming that condition 'tab!=NULL' is not redundant aptitude-0.8.13/src/gtk/gui.cc:1615:24: note: Null pointer dereference aptitude-0.8.13/src/gtk/gui.cc:185:43: style:inconclusive: Function 'post_event' argument 1 names different: declaration 'thunk' definition 'event'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/gui.h:82:43: note: Function 'post_event' argument 1 names different: declaration 'thunk' definition 'event'. aptitude-0.8.13/src/gtk/gui.cc:185:43: note: Function 'post_event' argument 1 names different: declaration 'thunk' definition 'event'. aptitude-0.8.13/src/gtk/gui.cc:219:32: style:inconclusive: Function 'start_download' argument 4 names different: declaration 'download_progress' definition 'progress_mode'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/gui.h:276:32: note: Function 'start_download' argument 4 names different: declaration 'download_progress' definition 'progress_mode'. aptitude-0.8.13/src/gtk/gui.cc:219:32: note: Function 'start_download' argument 4 names different: declaration 'download_progress' definition 'progress_mode'. aptitude-0.8.13/src/gtk/gui.cc:1606:78: style:inconclusive: Function 'update_package_menu' argument 2 names different: declaration 'package_menu' definition 'menu'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/gui.h:184:73: note: Function 'update_package_menu' argument 2 names different: declaration 'package_menu' definition 'menu'. aptitude-0.8.13/src/gtk/gui.cc:1606:78: note: Function 'update_package_menu' argument 2 names different: declaration 'package_menu' definition 'menu'. aptitude-0.8.13/src/gtk/gui.cc:887:25: style: Local variable 'tab' shadows outer variable [shadowVariable] aptitude-0.8.13/src/gtk/gui.cc:539:24: note: Shadowed declaration aptitude-0.8.13/src/gtk/gui.cc:887:25: note: Shadow variable aptitude-0.8.13/src/gtk/gui.cc:1682:35: style: Parameter 'argv' can be declared as const array [constParameter] aptitude-0.8.13/src/gtk/screenshot_cache.cc:498:7: debug: Failed to parse 'typedef multi_index_container < std :: shared_ptr < screenshot_cache_entry > , indexed_by < hashed_unique < tag < by_screenshot_tag > , const_mem_fun < screenshot_cache_entry , const screenshot_key & , & screenshot_cache_entry :: get_key > > , sequenced < tag < ordered_tag > > > > :: index < ordered_tag > :: type ordered_index ;'. The checking continues anyway. [simplifyTypedef] aptitude-0.8.13/src/gtk/screenshot_cache.cc:499:7: debug: Failed to parse 'typedef multi_index_container < std :: shared_ptr < screenshot_cache_entry > , indexed_by < hashed_unique < tag < by_screenshot_tag > , const_mem_fun < screenshot_cache_entry , const screenshot_key & , & screenshot_cache_entry :: get_key > > , sequenced < tag < ordered_tag > > > > :: index < by_screenshot_tag > :: type by_screenshot_index ;'. The checking continues anyway. [simplifyTypedef] aptitude-0.8.13/src/gtk/screenshot_cache.cc:247:7: style: Class 'screenshot_cache_entry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/screenshot_cache.cc:271:8: style: The destructor '~screenshot_cache_entry' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/screenshot_cache.h:63:14: note: Virtual destructor in base class aptitude-0.8.13/src/gtk/screenshot_cache.cc:271:8: note: Destructor in derived class aptitude-0.8.13/src/gtk/screenshot_cache.cc:309:33: style: The function 'get_screenshot' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/screenshot_cache.h:99:39: note: Virtual function in base class aptitude-0.8.13/src/gtk/screenshot_cache.cc:309:33: note: Function in derived class aptitude-0.8.13/src/gtk/screenshot_cache.cc:310:12: style: The function 'cancel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/screenshot_cache.h:102:18: note: Virtual function in base class aptitude-0.8.13/src/gtk/screenshot_cache.cc:310:12: note: Function in derived class aptitude-0.8.13/src/gtk/screenshot_cache.cc:744:46: style: Local variable 'rval' shadows outer variable [shadowVariable] aptitude-0.8.13/src/gtk/screenshot_cache.cc:728:42: note: Shadowed declaration aptitude-0.8.13/src/gtk/screenshot_cache.cc:744:46: note: Shadow variable aptitude-0.8.13/src/gtk/toplevel/model.cc:72:21: warning: The class 'area_list_impl' defines member function with name 'get_areas' also defined in its parent class 'area_list'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:92:49: note: Parent function 'area_list::get_areas' aptitude-0.8.13/src/gtk/toplevel/model.cc:72:21: note: Derived function 'area_list_impl::get_areas' aptitude-0.8.13/src/gtk/toplevel/model.cc:142:33: warning: The class 'area_info_impl' defines member function with name 'get_tabs' also defined in its parent class 'area_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:125:41: note: Parent function 'area_info::get_tabs' aptitude-0.8.13/src/gtk/toplevel/model.cc:142:33: note: Derived function 'area_info_impl::get_tabs' aptitude-0.8.13/src/gtk/toplevel/model.cc:143:42: warning: The class 'area_info_impl' defines member function with name 'get_notifications' also defined in its parent class 'area_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:127:50: note: Parent function 'area_info::get_notifications' aptitude-0.8.13/src/gtk/toplevel/model.cc:143:42: note: Derived function 'area_info_impl::get_notifications' aptitude-0.8.13/src/gtk/toplevel/model.cc:216:19: warning: The class 'tab_info_impl' defines member function with name 'get_name' also defined in its parent class 'tab_display_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:160:27: note: Parent function 'tab_display_info::get_name' aptitude-0.8.13/src/gtk/toplevel/model.cc:216:19: note: Derived function 'tab_info_impl::get_name' aptitude-0.8.13/src/gtk/toplevel/model.cc:218:12: warning: The class 'tab_info_impl' defines member function with name 'get_tooltip' also defined in its parent class 'tab_display_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:173:20: note: Parent function 'tab_display_info::get_tooltip' aptitude-0.8.13/src/gtk/toplevel/model.cc:218:12: note: Derived function 'tab_info_impl::get_tooltip' aptitude-0.8.13/src/gtk/toplevel/model.cc:248:33: warning: The class 'tab_info_impl' defines member function with name 'get_icon' also defined in its parent class 'tab_display_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:177:41: note: Parent function 'tab_display_info::get_icon' aptitude-0.8.13/src/gtk/toplevel/model.cc:248:33: note: Derived function 'tab_info_impl::get_icon' aptitude-0.8.13/src/gtk/toplevel/model.cc:250:21: warning: The class 'tab_info_impl' defines member function with name 'get_progress' also defined in its parent class 'tab_display_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:180:45: note: Parent function 'tab_display_info::get_progress' aptitude-0.8.13/src/gtk/toplevel/model.cc:250:21: note: Derived function 'tab_info_impl::get_progress' aptitude-0.8.13/src/gtk/toplevel/model.cc:260:20: warning: The class 'tab_info_impl' defines member function with name 'get_widget' also defined in its parent class 'tab_display_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:186:28: note: Parent function 'tab_display_info::get_widget' aptitude-0.8.13/src/gtk/toplevel/model.cc:260:20: note: Derived function 'tab_info_impl::get_widget' aptitude-0.8.13/src/gtk/toplevel/model.cc:261:12: warning: The class 'tab_info_impl' defines member function with name 'reset_widget' also defined in its parent class 'tab_display_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:200:20: note: Parent function 'tab_display_info::reset_widget' aptitude-0.8.13/src/gtk/toplevel/model.cc:261:12: note: Derived function 'tab_info_impl::reset_widget' aptitude-0.8.13/src/gtk/toplevel/model.cc:264:12: warning: The class 'tab_info_impl' defines member function with name 'set_active' also defined in its parent class 'tab_display_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:193:20: note: Parent function 'tab_display_info::set_active' aptitude-0.8.13/src/gtk/toplevel/model.cc:264:12: note: Derived function 'tab_info_impl::set_active' aptitude-0.8.13/src/gtk/toplevel/model.cc:274:7: warning: The class 'tab_info_impl' defines member function with name 'connect_tooltip_changed' also defined in its parent class 'tab_display_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:216:7: note: Parent function 'tab_display_info::connect_tooltip_changed' aptitude-0.8.13/src/gtk/toplevel/model.cc:274:7: note: Derived function 'tab_info_impl::connect_tooltip_changed' aptitude-0.8.13/src/gtk/toplevel/model.cc:282:7: warning: The class 'tab_info_impl' defines member function with name 'connect_progress_changed' also defined in its parent class 'tab_display_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:223:7: note: Parent function 'tab_display_info::connect_progress_changed' aptitude-0.8.13/src/gtk/toplevel/model.cc:282:7: note: Derived function 'tab_info_impl::connect_progress_changed' aptitude-0.8.13/src/gtk/toplevel/model.cc:291:7: warning: The class 'tab_info_impl' defines member function with name 'connect_activate_tab' also defined in its parent class 'tab_display_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:230:7: note: Parent function 'tab_display_info::connect_activate_tab' aptitude-0.8.13/src/gtk/toplevel/model.cc:291:7: note: Derived function 'tab_info_impl::connect_activate_tab' aptitude-0.8.13/src/gtk/toplevel/model.cc:327:12: warning: The class 'tab_info_impl' defines member function with name 'force_close' also defined in its parent class 'tab_display_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:207:20: note: Parent function 'tab_display_info::force_close' aptitude-0.8.13/src/gtk/toplevel/model.cc:327:12: note: Derived function 'tab_info_impl::force_close' aptitude-0.8.13/src/gtk/toplevel/model.cc:321:12: warning: The class 'tab_info_impl' defines member function with name 'request_close' also defined in its parent class 'tab_info_base'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:146:20: note: Parent function 'tab_info_base::request_close' aptitude-0.8.13/src/gtk/toplevel/model.cc:321:12: note: Derived function 'tab_info_impl::request_close' aptitude-0.8.13/src/gtk/toplevel/model.cc:205:12: warning: The class 'tab_info_impl' defines member function with name 'add_sibling' also defined in its parent class 'tab_controller_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:282:20: note: Parent function 'tab_controller_info::add_sibling' aptitude-0.8.13/src/gtk/toplevel/model.cc:205:12: note: Derived function 'tab_info_impl::add_sibling' aptitude-0.8.13/src/gtk/toplevel/model.cc:225:12: warning: The class 'tab_info_impl' defines member function with name 'set_tooltip' also defined in its parent class 'tab_controller_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:245:20: note: Parent function 'tab_controller_info::set_tooltip' aptitude-0.8.13/src/gtk/toplevel/model.cc:225:12: note: Derived function 'tab_info_impl::set_tooltip' aptitude-0.8.13/src/gtk/toplevel/model.cc:236:12: warning: The class 'tab_info_impl' defines member function with name 'set_tooltip' also defined in its parent class 'tab_controller_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:252:20: note: Parent function 'tab_controller_info::set_tooltip' aptitude-0.8.13/src/gtk/toplevel/model.cc:236:12: note: Derived function 'tab_info_impl::set_tooltip' aptitude-0.8.13/src/gtk/toplevel/model.cc:252:12: warning: The class 'tab_info_impl' defines member function with name 'set_progress' also defined in its parent class 'tab_controller_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:258:20: note: Parent function 'tab_controller_info::set_progress' aptitude-0.8.13/src/gtk/toplevel/model.cc:252:12: note: Derived function 'tab_info_impl::set_progress' aptitude-0.8.13/src/gtk/toplevel/model.cc:263:12: warning: The class 'tab_info_impl' defines member function with name 'get_active' also defined in its parent class 'tab_controller_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:270:20: note: Parent function 'tab_controller_info::get_active' aptitude-0.8.13/src/gtk/toplevel/model.cc:263:12: note: Derived function 'tab_info_impl::get_active' aptitude-0.8.13/src/gtk/toplevel/model.cc:303:7: warning: The class 'tab_info_impl' defines member function with name 'connect_active_changed' also defined in its parent class 'tab_controller_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:291:7: note: Parent function 'tab_controller_info::connect_active_changed' aptitude-0.8.13/src/gtk/toplevel/model.cc:303:7: note: Derived function 'tab_info_impl::connect_active_changed' aptitude-0.8.13/src/gtk/toplevel/model.cc:310:7: warning: The class 'tab_info_impl' defines member function with name 'connect_request_close' also defined in its parent class 'tab_controller_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:305:7: note: Parent function 'tab_controller_info::connect_request_close' aptitude-0.8.13/src/gtk/toplevel/model.cc:310:7: note: Derived function 'tab_info_impl::connect_request_close' aptitude-0.8.13/src/gtk/toplevel/model.cc:315:12: warning: The class 'tab_info_impl' defines member function with name 'activate' also defined in its parent class 'tab_controller_info'. [duplInheritedMember] aptitude-0.8.13/src/gtk/toplevel/model.h:276:20: note: Parent function 'tab_controller_info::activate' aptitude-0.8.13/src/gtk/toplevel/model.cc:315:12: note: Derived function 'tab_info_impl::activate' aptitude-0.8.13/src/gtk/toplevel/model.cc:55:7: style: Class 'area_list_impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/toplevel/model.cc:60:11: style: The function 'get_size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/model.h:86:19: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/model.cc:60:11: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/model.cc:139:19: style: The function 'get_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/model.h:109:27: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/model.cc:139:19: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/model.cc:140:19: style: The function 'get_description' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/model.h:112:27: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/model.cc:140:19: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/model.cc:141:33: style: The function 'get_icon' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/model.h:115:41: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/model.cc:141:33: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/model.cc:195:12: style: The function 'set_parent_area' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/model.h:334:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/model.cc:195:12: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/model.cc:297:24: style: The function 'connect_closed' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/model.h:326:7: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/model.cc:297:24: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/model.cc:365:19: style: The function 'get_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/model.h:354:27: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/model.cc:365:19: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/model.cc:366:19: style: The function 'get_description' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/model.h:357:27: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/model.cc:366:19: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/model.cc:367:33: style: The function 'get_icon' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/model.h:360:41: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/model.cc:367:33: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/model.cc:369:21: style: The function 'get_progress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/model.h:366:45: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/model.cc:369:21: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/model.cc:370:12: style: The function 'set_progress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/model.h:373:20: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/model.cc:370:12: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/model.cc:377:7: style: The function 'connect_progress_changed' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/model.h:384:7: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/model.cc:377:7: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/model.cc:384:7: style: The function 'connect_clicked' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/model.h:390:7: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/model.cc:384:7: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/tabs_notebook.cc:295:7: style: Class 'tabs_notebook_view' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/toplevel/tabs_notebook.cc:300:20: style: The function 'get_widget' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/view.h:53:28: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/tabs_notebook.cc:300:20: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/tabs_notebook.cc:301:41: style: The function 'get_active_tab' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/view.h:60:49: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/tabs_notebook.cc:301:41: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/tabs_notebook.cc:303:7: style: The function 'connect_active_tab_changed' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/toplevel/view.h:68:32: note: Virtual function in base class aptitude-0.8.13/src/gtk/toplevel/tabs_notebook.cc:303:7: note: Function in derived class aptitude-0.8.13/src/gtk/toplevel/tabs_notebook.cc:107:109: style:inconclusive: Function 'set_tabs' argument 1 names different: declaration 'tabs' definition 'new_tabs'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/toplevel/tabs_notebook.cc:85:96: note: Function 'set_tabs' argument 1 names different: declaration 'tabs' definition 'new_tabs'. aptitude-0.8.13/src/gtk/toplevel/tabs_notebook.cc:107:109: note: Function 'set_tabs' argument 1 names different: declaration 'tabs' definition 'new_tabs'. aptitude-0.8.13/src/gtk/view-impls/search_input_entry.cc:149:9: style: Statements following 'return' will never be executed. [unreachableCode] aptitude-0.8.13/src/load_config.cc:103:30: performance: Function parameter 'group' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/load_config.cc:156:32: performance: Function parameter 'group' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/load_pkgview.cc:25:56: performance: Function parameter 'cfggroup' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/gtk/resolver.h:152:5: style: Class 'ResolverView' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/resolver.cc:79:7: style: Class 'gui_resolver_continuation' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/gtk/resolver.cc:1349:20: style: Expression is always true because 'else if' condition is opposite to previous condition at line 1347. [multiCondition] aptitude-0.8.13/src/gtk/resolver.cc:1347:15: note: first condition aptitude-0.8.13/src/gtk/resolver.cc:1349:20: note: else if condition is opposite to first condition aptitude-0.8.13/src/gtk/resolver.cc:586:45: style:inconclusive: Function 'ResolverView' argument 1 names different: declaration 'view' definition '_view'. [funcArgNamesDifferent] aptitude-0.8.13/src/gtk/resolver.h:152:33: note: Function 'ResolverView' argument 1 names different: declaration 'view' definition '_view'. aptitude-0.8.13/src/gtk/resolver.cc:586:45: note: Function 'ResolverView' argument 1 names different: declaration 'view' definition '_view'. aptitude-0.8.13/src/load_sortpolicy.cc:153:41: performance: Function parameter 's' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/main.cc:187:22: error: There is an unknown macro here somewhere. Configuration is required. If VERSION is a macro then please configure it. [unknownMacro] aptitude-0.8.13/src/menu_text_layout.h:56:3: style: Class 'menu_text_layout' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/menu_text_layout.h:77:8: style: The function 'find_search_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:120:16: note: Virtual function in base class aptitude-0.8.13/src/menu_text_layout.h:77:8: note: Function in derived class aptitude-0.8.13/src/menu_text_layout.h:78:8: style: The function 'find_search' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:123:16: note: Virtual function in base class aptitude-0.8.13/src/menu_text_layout.h:78:8: note: Function in derived class aptitude-0.8.13/src/menu_text_layout.h:79:8: style: The function 'find_search_back_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:126:16: note: Virtual function in base class aptitude-0.8.13/src/menu_text_layout.h:79:8: note: Function in derived class aptitude-0.8.13/src/menu_text_layout.h:80:8: style: The function 'find_search_back' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:129:16: note: Virtual function in base class aptitude-0.8.13/src/menu_text_layout.h:80:8: note: Function in derived class aptitude-0.8.13/src/menu_text_layout.h:81:8: style: The function 'find_research_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:134:16: note: Virtual function in base class aptitude-0.8.13/src/menu_text_layout.h:81:8: note: Function in derived class aptitude-0.8.13/src/menu_text_layout.h:82:8: style: The function 'find_research' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:137:16: note: Virtual function in base class aptitude-0.8.13/src/menu_text_layout.h:82:8: note: Function in derived class aptitude-0.8.13/src/menu_text_layout.h:83:8: style: The function 'find_repeat_search_back_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:142:16: note: Virtual function in base class aptitude-0.8.13/src/menu_text_layout.h:83:8: note: Function in derived class aptitude-0.8.13/src/menu_text_layout.h:84:8: style: The function 'find_repeat_search_back' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:145:16: note: Virtual function in base class aptitude-0.8.13/src/menu_text_layout.h:84:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:163:8: warning: The class 'solution_act_item' defines member function with name 'dispatch_key' also defined in its parent class 'solution_item'. [duplInheritedMember] aptitude-0.8.13/src/solution_item.h:88:8: note: Parent function 'solution_item::dispatch_key' aptitude-0.8.13/src/solution_item.h:163:8: note: Derived function 'solution_act_item::dispatch_key' aptitude-0.8.13/src/solution_item.h:187:8: warning: The class 'solution_act_item_bare' defines member function with name 'paint' also defined in its parent class 'solution_act_item'. [duplInheritedMember] aptitude-0.8.13/src/solution_item.h:165:8: note: Parent function 'solution_act_item::paint' aptitude-0.8.13/src/solution_item.h:187:8: note: Derived function 'solution_act_item_bare::paint' aptitude-0.8.13/src/solution_item.h:91:8: style: The function 'resolver_toggle_approved' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:101:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:91:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:92:8: style: The function 'resolver_toggle_approved_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:104:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:92:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:93:8: style: The function 'resolver_toggle_rejected' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:107:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:93:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:94:8: style: The function 'resolver_toggle_rejected_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:110:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:94:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:144:8: style: The function 'is_rejected' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/solution_item.h:53:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:144:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:146:8: style: The function 'is_mandatory' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/solution_item.h:56:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:146:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:148:8: style: The function 'reject' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/solution_item.h:59:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:148:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:150:8: style: The function 'unreject' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/solution_item.h:62:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:150:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:152:8: style: The function 'mandate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/solution_item.h:65:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:152:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:154:8: style: The function 'unmandate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/solution_item.h:68:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:154:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:213:8: style: The function 'is_rejected' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/solution_item.h:53:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:213:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:214:8: style: The function 'is_mandatory' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/solution_item.h:56:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:214:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:215:8: style: The function 'reject' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/solution_item.h:59:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:215:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:216:8: style: The function 'unreject' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/solution_item.h:62:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:216:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:217:8: style: The function 'mandate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/solution_item.h:65:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:217:8: note: Function in derived class aptitude-0.8.13/src/solution_item.h:218:8: style: The function 'unmandate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/solution_item.h:68:16: note: Virtual function in base class aptitude-0.8.13/src/solution_item.h:218:8: note: Function in derived class aptitude-0.8.13/src/mine/board.h:91:3: warning: Member variable 'mine_board::minex' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/mine/board.h:91:3: warning: Member variable 'mine_board::miney' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/mine/board.h:91:3: warning: Member variable 'mine_board::endtime' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/mine/board.h:97:3: warning: Member variable 'mine_board::minex' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/mine/board.h:97:3: warning: Member variable 'mine_board::miney' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/mine/board.h:97:3: warning: Member variable 'mine_board::endtime' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/load_grouppolicy.cc:254:3: style: Class 'list_policy_parser' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/load_grouppolicy.cc:189:3: style: Class 'policy_node1 < pkg_grouppolicy_filter_factory , cwidget :: util :: ref_ptr < aptitude :: matching :: pattern > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/load_grouppolicy.cc:189:3: style: Class 'policy_node1 < pkg_grouppolicy_filter_factory , ref_ptr < aptitude :: matching :: pattern > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/load_grouppolicy.cc:189:3: style: Class 'policy_node1 < pkg_grouppolicy_firstchar_factory , pkg_grouppolicy_firstchar_factory :: package_name_mode_type >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/load_grouppolicy.cc:189:3: style: Class 'policy_node1 < pkg_grouppolicy_tag_factory , string >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/load_grouppolicy.cc:189:3: style: Class 'policy_node1 < pkg_grouppolicy_patterns_factory , vector < pkg_grouppolicy_patterns_factory :: match_entry > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/load_grouppolicy.cc:154:8: style: The function 'terminal' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:90:16: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:154:8: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:159:4: style: The destructor '~group_policy_pair_node' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:79:12: note: Virtual destructor in base class aptitude-0.8.13/src/load_grouppolicy.cc:159:4: note: Destructor in derived class aptitude-0.8.13/src/load_grouppolicy.cc:165:28: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:96:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:165:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:226:28: style: The function 'parse' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:108:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:226:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:265:28: style: The function 'parse' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:108:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:265:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:352:28: style: The function 'parse' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:108:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:352:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:396:28: style: The function 'create_node' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:350:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:396:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:439:28: style: The function 'create_node' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:350:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:439:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:451:28: style: The function 'parse' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:108:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:451:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:519:28: style: The function 'create_node' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:350:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:519:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:530:28: style: The function 'create_node' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:350:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:530:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:567:28: style: The function 'create_node' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:350:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:567:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:578:28: style: The function 'create_node' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:350:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:578:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:589:28: style: The function 'create_node' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:350:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:589:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:600:28: style: The function 'create_node' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:350:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:600:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:611:28: style: The function 'create_node' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:350:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:611:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:622:28: style: The function 'create_node' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:350:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:622:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:635:28: style: The function 'parse' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:108:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:635:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:769:28: style: The function 'create_node' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:350:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:769:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:210:28: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:96:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:210:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:193:28: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:96:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:193:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:178:28: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:96:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:178:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:126:8: style: The function 'terminal' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:90:16: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:126:8: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:131:28: style: The function 'instantiate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:96:36: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:131:28: note: Function in derived class aptitude-0.8.13/src/load_grouppolicy.cc:154:8: style: The function 'terminal' overrides a function in a base class but just delegates back to the base class. [uselessOverride] aptitude-0.8.13/src/load_grouppolicy.cc:90:16: note: Virtual function in base class aptitude-0.8.13/src/load_grouppolicy.cc:154:8: note: Function in derived class aptitude-0.8.13/src/pkg_columnizer.cc:721:3: style: Class 'pkg_genheaders' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/load_grouppolicy.cc:341:13: warning: Possible null pointer dereference: rval [nullPointer] aptitude-0.8.13/src/load_grouppolicy.cc:339:89: note: Assignment 'rval.release(),new policy_terminal_node0 < pkg_grouppolicy_end_factory >', assigned value is 0 aptitude-0.8.13/src/load_grouppolicy.cc:341:13: note: Null pointer dereference aptitude-0.8.13/src/pkg_columnizer.cc:302:7: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] aptitude-0.8.13/src/pkg_columnizer.cc:304:2: note: Found duplicate branches for 'if' and 'else'. aptitude-0.8.13/src/pkg_columnizer.cc:302:7: note: Found duplicate branches for 'if' and 'else'. aptitude-0.8.13/src/pkg_columnizer.cc:333:7: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] aptitude-0.8.13/src/pkg_columnizer.cc:335:2: note: Found duplicate branches for 'if' and 'else'. aptitude-0.8.13/src/pkg_columnizer.cc:333:7: note: Found duplicate branches for 'if' and 'else'. aptitude-0.8.13/src/pkg_columnizer.cc:128:43: style:inconclusive: Function 'setup_column' argument 2 names different: declaration 'ver' definition 'visible_ver'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_columnizer.h:55:38: note: Function 'setup_column' argument 2 names different: declaration 'ver' definition 'visible_ver'. aptitude-0.8.13/src/pkg_columnizer.cc:128:43: note: Function 'setup_column' argument 2 names different: declaration 'ver' definition 'visible_ver'. aptitude-0.8.13/src/pkg_columnizer.cc:315:36: style: Variable 'estate' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1092:34: style: Comparison of two functions returning boolean value using relational (<, >, <= or >=) operator. [comparisonOfTwoFuncsReturningBoolError] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1094:39: style: Comparison of two functions returning boolean value using relational (<, >, <= or >=) operator. [comparisonOfTwoFuncsReturningBoolError] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1100:31: style: Comparison of two functions returning boolean value using relational (<, >, <= or >=) operator. [comparisonOfTwoFuncsReturningBoolError] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1102:31: style: Comparison of two functions returning boolean value using relational (<, >, <= or >=) operator. [comparisonOfTwoFuncsReturningBoolError] aptitude-0.8.13/src/pkg_info_screen.h:53:31: style: The function 'setup_new_root' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/apt_info_tree.h:57:39: note: Virtual function in base class aptitude-0.8.13/src/pkg_info_screen.h:53:31: note: Function in derived class aptitude-0.8.13/src/pkg_info_screen.cc:61:8: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_info_screen.cc:61:8: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/search_graph.h:932:5: warning: Member variable 'step::step_num' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:932:5: warning: Member variable 'step::score' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:932:5: warning: Member variable 'step::action_score' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:954:5: warning: Member variable 'step::step_num' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:979:5: warning: Member variable 'step::step_num' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:393:3: warning: Member variable 'generic_dep_solvers < dummy_universe_ref >::hash_cache' is not initialized in the constructor. [uninitMemberVar] aptitude-0.8.13/src/mine/cmine.cc:89:3: style: Class 'update_header_event' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/mine/cmine.cc:160:34: style:inconclusive: Function 'do_load_game' argument 1 names different: declaration 's' definition 'ws'. [funcArgNamesDifferent] aptitude-0.8.13/src/mine/cmine.h:78:34: note: Function 'do_load_game' argument 1 names different: declaration 's' definition 'ws'. aptitude-0.8.13/src/mine/cmine.cc:160:34: note: Function 'do_load_game' argument 1 names different: declaration 's' definition 'ws'. aptitude-0.8.13/src/mine/cmine.cc:200:34: style:inconclusive: Function 'do_save_game' argument 1 names different: declaration 's' definition 'ws'. [funcArgNamesDifferent] aptitude-0.8.13/src/mine/cmine.h:79:34: note: Function 'do_save_game' argument 1 names different: declaration 's' definition 'ws'. aptitude-0.8.13/src/mine/cmine.cc:200:34: note: Function 'do_save_game' argument 1 names different: declaration 's' definition 'ws'. aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:544:16: style:inconclusive: Member variable 'generic_problem_resolver < dummy_universe_ref >::graph' uses an uninitialized argument 'promotions' due to the order of declarations. [initializerList] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:3749:6: note: Member variable 'generic_problem_resolver < dummy_universe_ref >::graph' uses an uninitialized argument 'promotions' due to the order of declarations. aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:544:16: note: Member variable 'generic_problem_resolver < dummy_universe_ref >::graph' uses an uninitialized argument 'promotions' due to the order of declarations. aptitude-0.8.13/src/generic/problemresolver/search_graph.h:784:16: style:inconclusive: Member variable 'step::actions' is in the wrong place in the initializer list. [initializerList] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:965:2: note: Member variable 'step::actions' is in the wrong place in the initializer list. aptitude-0.8.13/src/generic/problemresolver/search_graph.h:784:16: note: Member variable 'step::actions' is in the wrong place in the initializer list. aptitude-0.8.13/src/generic/problemresolver/search_graph.h:784:16: style:inconclusive: Member variable 'step::actions' is in the wrong place in the initializer list. [initializerList] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:992:2: note: Member variable 'step::actions' is in the wrong place in the initializer list. aptitude-0.8.13/src/generic/problemresolver/search_graph.h:784:16: note: Member variable 'step::actions' is in the wrong place in the initializer list. aptitude-0.8.13/src/mine/cmine.cc:739:21: style: Variable 'stname' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/mine/cmine.cc:740:14: style: Variable 'stname' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/mine/cmine.cc:767:18: style: Variable 'stname' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/mine/cmine.cc:768:11: style: Variable 'stname' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1150:8: performance:inconclusive: Technically the member function 'generic_problem_resolver < dummy_universe_ref >::sanity_check_not_deferred' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1228:8: performance:inconclusive: Technically the member function 'generic_problem_resolver < dummy_universe_ref >::sanity_check_promotions' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1328:8: performance:inconclusive: Technically the member function 'generic_problem_resolver < dummy_universe_ref >::is_discard_cost' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1834:8: performance:inconclusive: Technically the member function 'generic_problem_resolver < dummy_universe_ref >::process_pending_promotions' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:3709:8: style:inconclusive: Technically the member function 'generic_problem_resolver < dummy_universe_ref >::do_log' can be const. [functionConst] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:3834:7: style:inconclusive: Technically the member function 'generic_problem_resolver < dummy_universe_ref >::get_step_score' can be const. [functionConst] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:3835:7: style:inconclusive: Technically the member function 'generic_problem_resolver < dummy_universe_ref >::get_broken_score' can be const. [functionConst] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:3836:7: style:inconclusive: Technically the member function 'generic_problem_resolver < dummy_universe_ref >::get_unresolved_soft_dep_score' can be const. [functionConst] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:3837:7: style:inconclusive: Technically the member function 'generic_problem_resolver < dummy_universe_ref >::get_infinity' can be const. [functionConst] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:3838:7: style:inconclusive: Technically the member function 'generic_problem_resolver < dummy_universe_ref >::get_full_solution_score' can be const. [functionConst] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:4720:8: style:inconclusive: Technically the member function 'generic_problem_resolver < dummy_universe_ref >::dump_scores' can be const. [functionConst] aptitude-0.8.13/src/generic/problemresolver/solution.h:504:9: performance:inconclusive: Technically the member function 'generic_solution < dummy_universe_ref >::ver_name_lt::cmp' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:3765:6: warning: Class 'generic_problem_resolver < dummy_universe_ref >' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:3765:6: warning: Class 'generic_problem_resolver < dummy_universe_ref >' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] aptitude-0.8.13/src/generic/problemresolver/solution.h:772:6: warning: Struct 'solution_weights < dummy_universe_ref >' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] aptitude-0.8.13/src/generic/problemresolver/solution.h:772:6: warning: Struct 'solution_weights < dummy_universe_ref >' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] aptitude-0.8.13/src/generic/problemresolver/solution.h:381:6: warning: Value of pointer 'real_soln', which points to allocated memory, is copied in copy constructor instead of allocating new memory. [copyCtorPointerCopying] aptitude-0.8.13/src/generic/problemresolver/promotion_set.h:2039:7: warning: Class 'generic_promotion_set < dummy_universe_ref >' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] aptitude-0.8.13/src/generic/problemresolver/promotion_set.h:2039:7: warning: Class 'generic_promotion_set < dummy_universe_ref >' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] aptitude-0.8.13/src/generic/problemresolver/choice_indexed_map.h:466:3: style: Class 'generic_choice_indexed_set' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/choice_indexed_map.h:518:5: style: Struct 'for_each_set' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:568:5: style: Struct 'step_goodness_compare' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:656:5: style: Class 'step_contents' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:622:7: style: Struct 'combine_hashes' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:699:5: style: Class 'instance_tracker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1487:5: style: Class 'promotion_adder' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1920:5: style: Class 'add_to_structural_reasons' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:2668:5: style: Class 'find_solvers_cost_lower_bound' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:1411:3: style: Class 'generic_search_graph < dummy_universe_ref >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:1032:5: style: Class 'choice_mapping_info' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:335:5: style: Class 'hash_choices' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:381:5: style: Class 'find_solver' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:285:3: style: Class 'generic_dump_solvers < dummy_universe_ref >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:65:5: style: Class 'combine_reason_hashes' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:92:5: style: Class 'choice_set_with_hash' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/solution.h:346:3: style: Class 'generic_solution < dummy_universe_ref >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/solution.h:609:5: style: Struct 'accumulate_1st' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/solution.h:110:7: style: Struct 'do_map_package' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/promotion_set.h:341:5: style: Struct 'entry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/promotion_set.h:844:5: style: Struct 'increment_entry_count_op' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/promotion_set.h:883:5: style: Class 'find_entry_subset_op' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/promotion_set.h:1916:5: style: Struct 'entry_ref_in_dropped_set_pred' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/choice_indexed_map.h:288:5: style: Struct 'for_each_break_soft_dep' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/choice_indexed_map.h:308:5: style: Class 'for_each_version_info' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:512:3: style: Class 'var_e < bool >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:359:3: style: Class 'expression_wrapper < bool >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:103:3: style: Class 'expression_weak_ref < expression_box < bool > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:104:3: style: Class 'expression_weak_ref < expression_box < bool > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/choice_set.h:162:5: style: Struct 'for_each_choice_pair' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/choice_set.h:200:5: style: Struct 'insert_choice_narrow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/promotion_set.h:571:5: style: Class 'iterator_base < std :: list < entry > :: const_iterator >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/promotion_set.h:571:5: style: Class 'iterator_base < std :: list < entry > :: iterator >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/solution.h:592:5: style: Struct 'accumulate < generic_choice < dummy_universe_ref > >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1824:8: style: The function 'promotion_retracted' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/promotion_set.h:244:16: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1824:8: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:522:5: style: The function 'get_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:255:13: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:522:5: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:540:8: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:256:16: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:540:8: note: Function in derived class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:382:8: style: The function 'child_modified' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:272:16: note: Virtual function in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:382:8: note: Function in derived class aptitude-0.8.13/src/pkg_item.cc:63:42: performance: Function parameter 's' should be passed by const reference. However it seems that 'try_delete_essential' is a callback function. [passedByValueCallback] aptitude-0.8.13/src/pkg_item.cc:91:47: note: Function pointer used here. aptitude-0.8.13/src/pkg_item.cc:63:42: note: Function parameter 's' should be passed by const reference. However it seems that 'try_delete_essential' is a callback function. aptitude-0.8.13/src/pkg_sortpolicy.cc:128:1: performance:inconclusive: Technically the member function 'pkg_sortpolicy_name_impl::do_compare' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/pkg_sortpolicy.cc:139:1: performance:inconclusive: Technically the member function 'pkg_sortpolicy_installed_size_impl::do_compare' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/pkg_sortpolicy.cc:154:1: performance:inconclusive: Technically the member function 'pkg_sortpolicy_installed_size_change_impl::do_compare' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/pkg_sortpolicy.cc:180:1: performance:inconclusive: Technically the member function 'pkg_sortpolicy_priority_impl::do_compare' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/pkg_sortpolicy.cc:191:1: performance:inconclusive: Technically the member function 'pkg_sortpolicy_debsize_impl::do_compare' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/pkg_sortpolicy.cc:206:1: performance:inconclusive: Technically the member function 'pkg_sortpolicy_ver_impl::do_compare' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/pkg_sortpolicy.cc:128:1: style: The function 'compare' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_sortpolicy.h:51:15: note: Virtual function in base class aptitude-0.8.13/src/pkg_sortpolicy.cc:128:1: note: Function in derived class aptitude-0.8.13/src/pkg_sortpolicy.cc:139:1: style: The function 'compare' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_sortpolicy.h:51:15: note: Virtual function in base class aptitude-0.8.13/src/pkg_sortpolicy.cc:139:1: note: Function in derived class aptitude-0.8.13/src/pkg_sortpolicy.cc:154:1: style: The function 'compare' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_sortpolicy.h:51:15: note: Virtual function in base class aptitude-0.8.13/src/pkg_sortpolicy.cc:154:1: note: Function in derived class aptitude-0.8.13/src/pkg_sortpolicy.cc:180:1: style: The function 'compare' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_sortpolicy.h:51:15: note: Virtual function in base class aptitude-0.8.13/src/pkg_sortpolicy.cc:180:1: note: Function in derived class aptitude-0.8.13/src/pkg_sortpolicy.cc:191:1: style: The function 'compare' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_sortpolicy.h:51:15: note: Virtual function in base class aptitude-0.8.13/src/pkg_sortpolicy.cc:191:1: note: Function in derived class aptitude-0.8.13/src/pkg_sortpolicy.cc:206:1: style: The function 'compare' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_sortpolicy.h:51:15: note: Virtual function in base class aptitude-0.8.13/src/pkg_sortpolicy.cc:206:1: note: Function in derived class aptitude-0.8.13/src/pkg_sortpolicy.cc:78:41: style: Parameter 'item' can be declared as pointer to const [constParameterPointer] aptitude-0.8.13/src/generic/problemresolver/sanity_check_universe.h:160:15: style: Redundant assignment of 'solverpkg' to itself. [selfAssignment] aptitude-0.8.13/src/generic/problemresolver/sanity_check_universe.h:160:38: style: Redundant assignment of 'solverver' to itself. [selfAssignment] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:1533:45: style: Unsigned expression 'canonicalParentPromotionsList.size()' can't be negative so it is unnecessary to test it. [unsignedPositive] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:1559:52: style: Checking if unsigned expression 'canonicalParentPromotionsList.size()' is less than zero. [unsignedLessThanZero] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:292:97: style:inconclusive: Function 'operator<<' argument 2 names different: declaration 'solvers' definition 'dump_solvers'. [funcArgNamesDifferent] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:272:90: note: Function 'operator<<' argument 2 names different: declaration 'solvers' definition 'dump_solvers'. aptitude-0.8.13/src/generic/problemresolver/search_graph.h:292:97: note: Function 'operator<<' argument 2 names different: declaration 'solvers' definition 'dump_solvers'. aptitude-0.8.13/src/generic/problemresolver/search_graph.h:1283:44: style: Local variable 'steps' shadows outer variable [shadowVariable] aptitude-0.8.13/src/generic/problemresolver/search_graph.h:1065:20: note: Shadowed declaration aptitude-0.8.13/src/generic/problemresolver/search_graph.h:1283:44: note: Shadow variable aptitude-0.8.13/src/generic/problemresolver/promotion_set.h:1194:37: style: Local variable 'entries' shadows outer variable [shadowVariable] aptitude-0.8.13/src/generic/problemresolver/promotion_set.h:409:18: note: Shadowed declaration aptitude-0.8.13/src/generic/problemresolver/promotion_set.h:1194:37: note: Shadow variable aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1136:11: style: Variable 's' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:1814:13: style: Variable 's' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:2970:43: style: Parameter 's' can be declared as reference to const [constParameterReference] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:3982:32: style: Variable 'inf' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:4001:32: style: Variable 'inf' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:4016:32: style: Variable 'inf' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:4032:32: style: Variable 'inf' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:4083:32: style: Variable 'inf' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:4100:32: style: Variable 'inf' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:4129:32: style: Variable 'inf' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:4146:32: style: Variable 'inf' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:4671:8: style: Variable 'best_future_solution_step' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/choice_set.h:222:11: style: Variable 'existing_choice' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/choice_set.h:394:16: style: Variable 'existing_choice' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/choice_set.h:443:16: style: Variable 'existing_choice' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/pkg_ver_item.h:179:39: style: Virtual function 'setup_new_root' is called from constructor 'pkg_ver_screen(const pkgCache::PkgIterator&pkg)' at line 664. Dynamic binding is not used. [virtualCallInConstructor] aptitude-0.8.13/src/pkg_ver_item.cc:664:12: note: Calling setup_new_root aptitude-0.8.13/src/pkg_ver_item.h:179:39: note: setup_new_root is a virtual function aptitude-0.8.13/src/pkg_ver_item.cc:399:8: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_ver_item.cc:399:8: note: Function in derived class aptitude-0.8.13/src/pkg_ver_item.cc:285:36: style: Variable 'estate' can be declared as reference to const [constVariableReference] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:4307:49: error: Uninitialized variable: action_hits [uninitvar] aptitude-0.8.13/src/generic/problemresolver/sanity_check_universe.h:160:15: style: Variable 'solverpkg' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/generic/problemresolver/sanity_check_universe.h:160:38: style: Variable 'solverver' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/pkg_tree.cc:73:39: style:inconclusive: Function 'pkg_tree' argument 1 names different: declaration 'groupingstr' definition 'def_grouping'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_tree.h:77:31: note: Function 'pkg_tree' argument 1 names different: declaration 'groupingstr' definition 'def_grouping'. aptitude-0.8.13/src/pkg_tree.cc:73:39: note: Function 'pkg_tree' argument 1 names different: declaration 'groupingstr' definition 'def_grouping'. aptitude-0.8.13/src/pkg_tree.cc:75:26: style:inconclusive: Function 'pkg_tree' argument 3 names different: declaration 'limitstr' definition 'def_limit'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_tree.h:79:25: note: Function 'pkg_tree' argument 3 names different: declaration 'limitstr' definition 'def_limit'. aptitude-0.8.13/src/pkg_tree.cc:75:26: note: Function 'pkg_tree' argument 3 names different: declaration 'limitstr' definition 'def_limit'. aptitude-0.8.13/src/pkg_tree.cc:87:39: style:inconclusive: Function 'pkg_tree' argument 1 names different: declaration 'groupingstr' definition 'def_grouping'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_tree.h:81:31: note: Function 'pkg_tree' argument 1 names different: declaration 'groupingstr' definition 'def_grouping'. aptitude-0.8.13/src/pkg_tree.cc:87:39: note: Function 'pkg_tree' argument 1 names different: declaration 'groupingstr' definition 'def_grouping'. aptitude-0.8.13/src/qt/package.cc:54:55: style: Struct 'make_shared_enabler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/qt/package_pool.cc:69:28: warning: The class 'package_pool_impl' defines member function with name 'get_instance' also defined in its parent class 'package_pool'. [duplInheritedMember] aptitude-0.8.13/src/qt/package_pool.cc:167:35: note: Parent function 'package_pool::get_instance' aptitude-0.8.13/src/qt/package_pool.cc:69:28: note: Derived function 'package_pool_impl::get_instance' aptitude-0.8.13/src/qt/package_pool.cc:66:11: style: The destructor '~package_pool_impl' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/package_pool.h:50:11: note: Virtual destructor in base class aptitude-0.8.13/src/qt/package_pool.cc:66:11: note: Destructor in derived class aptitude-0.8.13/src/qt/package_pool.cc:72:6: style: The function 'get_packages_count' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/package_pool.h:65:14: note: Virtual function in base class aptitude-0.8.13/src/qt/package_pool.cc:72:6: note: Function in derived class aptitude-0.8.13/src/qt/package_pool.cc:75:14: style: The function 'get_package_at_index' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/package_pool.h:75:22: note: Virtual function in base class aptitude-0.8.13/src/qt/package_pool.cc:75:14: note: Function in derived class aptitude-0.8.13/src/qt/package_pool.cc:82:19: style: The function 'connect_cache_reloaded' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/package_pool.h:82:27: note: Virtual function in base class aptitude-0.8.13/src/qt/package_pool.cc:82:19: note: Function in derived class aptitude-0.8.13/src/qt/package_pool.cc:85:19: style: The function 'connect_cache_closed' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/package_pool.h:89:27: note: Virtual function in base class aptitude-0.8.13/src/qt/package_pool.cc:85:19: note: Function in derived class aptitude-0.8.13/src/qt/package_pool.cc:88:19: style: The function 'connect_cache_state_changed' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/package_pool.h:94:27: note: Virtual function in base class aptitude-0.8.13/src/qt/package_pool.cc:88:19: note: Function in derived class aptitude-0.8.13/src/qt/package_pool.cc:143:11: style: Unsigned expression 'index' can't be negative so it is unnecessary to test it. [unsignedPositive] aptitude-0.8.13/src/pkg_grouppolicy.cc:1105:11: performance:inconclusive: Technically the member function 'pkg_grouppolicy_patterns::substitute' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/src/pkg_grouppolicy.cc:984:15: warning: The class 'task_subtree' defines member function with name 'tag' also defined in its parent class 'pkg_subtree'. [duplInheritedMember] aptitude-0.8.13/src/pkg_subtree.h:73:26: note: Parent function 'pkg_subtree::tag' aptitude-0.8.13/src/pkg_grouppolicy.cc:984:15: note: Derived function 'task_subtree::tag' aptitude-0.8.13/src/pkg_grouppolicy.cc:69:16: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:69:16: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:119:16: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:119:16: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:121:12: style: The destructor '~pkg_grouppolicy_section' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:121:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:451:16: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:451:16: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:453:12: style: The destructor '~pkg_grouppolicy_status' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:453:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:539:16: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:539:16: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:545:12: style: The destructor '~pkg_grouppolicy_filter' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:545:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:580:8: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:580:8: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:681:12: style: The destructor '~pkg_grouppolicy_mode' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:681:12: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:732:4: style: The destructor '~pkg_grouppolicy_firstchar' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:732:4: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:738:8: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:738:8: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:827:4: style: The destructor '~pkg_grouppolicy_priority' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:827:4: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:833:8: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:833:8: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:935:4: style: The destructor '~pkg_grouppolicy_task' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:935:4: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:937:8: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:937:8: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:1197:4: style: The destructor '~pkg_grouppolicy_patterns' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1197:4: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:1205:8: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1205:8: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:1288:16: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1288:16: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:1349:4: style: The destructor '~pkg_grouppolicy_tag' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1349:4: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:1397:16: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1397:16: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:1511:4: style: The destructor '~pkg_grouppolicy_facet_tag' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1511:4: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:1559:4: style: The destructor '~pkg_grouppolicy_source' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1559:4: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:1565:8: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1565:8: note: Function in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:1637:4: style: The destructor '~pkg_grouppolicy_arch' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1637:4: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:1643:8: style: The function 'add_package' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:88:16: note: Virtual function in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1643:8: note: Function in derived class aptitude-0.8.13/src/qt/widgets/tab_widget.h:51:15: error: There is an unknown macro here somewhere. Configuration is required. If Q_SLOTS is a macro then please configure it. [unknownMacro] aptitude-0.8.13/src/pkg_grouppolicy.cc:798:77: style:inconclusive: Function 'instantiate' argument 1 names different: declaration '_sig' definition 'sig'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_grouppolicy.h:271:44: note: Function 'instantiate' argument 1 names different: declaration '_sig' definition 'sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:798:77: note: Function 'instantiate' argument 1 names different: declaration '_sig' definition 'sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:799:22: style:inconclusive: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_grouppolicy.h:271:63: note: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:799:22: note: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:895:76: style:inconclusive: Function 'instantiate' argument 1 names different: declaration '_sig' definition 'sig'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_grouppolicy.h:284:44: note: Function 'instantiate' argument 1 names different: declaration '_sig' definition 'sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:895:76: note: Function 'instantiate' argument 1 names different: declaration '_sig' definition 'sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:896:28: style:inconclusive: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_grouppolicy.h:285:24: note: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:896:28: note: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:1067:24: style:inconclusive: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_grouppolicy.h:303:24: note: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:1067:24: note: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:1358:71: style:inconclusive: Function 'instantiate' argument 1 names different: declaration 'sig' definition 'pkg_sig'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_grouppolicy.h:370:44: note: Function 'instantiate' argument 1 names different: declaration 'sig' definition 'pkg_sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:1358:71: note: Function 'instantiate' argument 1 names different: declaration 'sig' definition 'pkg_sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:1609:74: style:inconclusive: Function 'instantiate' argument 1 names different: declaration '_sig' definition 'sig'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_grouppolicy.h:399:44: note: Function 'instantiate' argument 1 names different: declaration '_sig' definition 'sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:1609:74: note: Function 'instantiate' argument 1 names different: declaration '_sig' definition 'sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:1610:26: style:inconclusive: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_grouppolicy.h:400:24: note: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:1610:26: note: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:1677:72: style:inconclusive: Function 'instantiate' argument 1 names different: declaration '_sig' definition 'sig'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_grouppolicy.h:413:44: note: Function 'instantiate' argument 1 names different: declaration '_sig' definition 'sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:1677:72: note: Function 'instantiate' argument 1 names different: declaration '_sig' definition 'sig'. aptitude-0.8.13/src/qt/widgets/changes_preview_tab.h:43:11: style: The destructor '~changes_preview_tab' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/widgets/tab.h:74:11: note: Virtual destructor in base class aptitude-0.8.13/src/qt/widgets/changes_preview_tab.h:43:11: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:1678:24: style:inconclusive: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. [funcArgNamesDifferent] aptitude-0.8.13/src/pkg_grouppolicy.h:414:24: note: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:1678:24: note: Function 'instantiate' argument 2 names different: declaration '_desc_sig' definition 'desc_sig'. aptitude-0.8.13/src/pkg_grouppolicy.cc:1165:24: style: Local variable 'i' shadows outer variable [shadowVariable] aptitude-0.8.13/src/pkg_grouppolicy.cc:1110:29: note: Shadowed declaration aptitude-0.8.13/src/pkg_grouppolicy.cc:1165:24: note: Shadow variable aptitude-0.8.13/src/qt/version.cc:52:55: style: Struct 'make_shared_enabler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/pkg_grouppolicy.cc:1031:5: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/qt/widgets/package_info_tab.h:42:11: style: The destructor '~package_info_tab' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/widgets/tab.h:74:11: note: Virtual destructor in base class aptitude-0.8.13/src/qt/widgets/package_info_tab.h:42:11: note: Destructor in derived class aptitude-0.8.13/src/qt/widgets/packages_tab.h:62:15: error: There is an unknown macro here somewhere. Configuration is required. If Q_SLOTS is a macro then please configure it. [unknownMacro] aptitude-0.8.13/src/pkg_view.cc:88:3: style: Class 'pkg_handling_label' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/qt/widgets/perform_changes_tab.h:43:11: style: The destructor '~perform_changes_tab' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/widgets/tab.h:74:11: note: Virtual destructor in base class aptitude-0.8.13/src/qt/widgets/perform_changes_tab.h:43:11: note: Destructor in derived class aptitude-0.8.13/src/qt/widgets/resolver_tab.h:42:11: style: The destructor '~resolver_tab' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/widgets/tab.h:74:11: note: Virtual destructor in base class aptitude-0.8.13/src/qt/widgets/resolver_tab.h:42:11: note: Destructor in derived class aptitude-0.8.13/src/pkg_grouppolicy.cc:123:72: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/pkg_grouppolicy.cc:734:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/pkg_grouppolicy.cc:829:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/pkg_grouppolicy.cc:1639:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/pkg_view.cc:154:53: performance: Function parameter 'the_default' should be passed by const reference. However it seems that 'do_set_column_format' is a callback function. [passedByValueCallback] aptitude-0.8.13/src/pkg_view.cc:636:30: note: Function pointer used here. aptitude-0.8.13/src/pkg_view.cc:154:53: note: Function parameter 'the_default' should be passed by const reference. However it seems that 'do_set_column_format' is a callback function. aptitude-0.8.13/src/qt/widgets/status_widget.h:76:15: error: There is an unknown macro here somewhere. Configuration is required. If Q_SLOTS is a macro then please configure it. [unknownMacro] aptitude-0.8.13/src/pkg_view.cc:765:6: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] aptitude-0.8.13/src/qt/widgets/tab.cc:28:25: style:inconclusive: Function 'tab' argument 1 names different: declaration 'type' definition '_type'. [funcArgNamesDifferent] aptitude-0.8.13/src/qt/widgets/tab.h:72:24: note: Function 'tab' argument 1 names different: declaration 'type' definition '_type'. aptitude-0.8.13/src/qt/widgets/tab.cc:28:25: note: Function 'tab' argument 1 names different: declaration 'type' definition '_type'. aptitude-0.8.13/src/pkg_view.cc:613:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/pkg_view.cc:758:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/pkg_view.cc:762:4: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] aptitude-0.8.13/src/solution_screen.cc:389:1: debug: SymbolDatabase couldn't resolve all user defined types. [debug] aptitude-0.8.13/src/solution_screen.cc:370:48: warning: The class 'solution_undo_tree' defines member function with name 'create' also defined in its parent class 'menu_tree'. [duplInheritedMember] aptitude-0.8.13/src/menu_tree.h:103:44: note: Parent function 'menu_tree::create' aptitude-0.8.13/src/solution_screen.cc:370:48: note: Derived function 'solution_undo_tree::create' aptitude-0.8.13/src/solution_screen.cc:127:3: style: Class 'label_tree' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/solution_screen.cc:377:8: style: The function 'undo_undo_enabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:39:16: note: Virtual function in base class aptitude-0.8.13/src/solution_screen.cc:377:8: note: Function in derived class aptitude-0.8.13/src/solution_screen.cc:382:8: style: The function 'undo_undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:42:16: note: Virtual function in base class aptitude-0.8.13/src/solution_screen.cc:382:8: note: Function in derived class aptitude-0.8.13/src/solution_screen.cc:127:22: performance: Function parameter '_label' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/solution_fragment.cc:380:14: style: Expression is always true because 'else if' condition is opposite to previous condition at line 378. [multiCondition] aptitude-0.8.13/src/solution_fragment.cc:378:9: note: first condition aptitude-0.8.13/src/solution_fragment.cc:380:14: note: else if condition is opposite to first condition aptitude-0.8.13/src/solution_fragment.cc:47:51: style:inconclusive: Function 'archives_text' argument 1 names different: declaration 'v' definition 'ver'. [funcArgNamesDifferent] aptitude-0.8.13/src/solution_fragment.h:69:56: note: Function 'archives_text' argument 1 names different: declaration 'v' definition 'ver'. aptitude-0.8.13/src/solution_fragment.cc:47:51: note: Function 'archives_text' argument 1 names different: declaration 'v' definition 'ver'. aptitude-0.8.13/src/solution_fragment.cc:158:38: style:inconclusive: Function 'conflict_text' argument 2 names different: declaration 'p' definition 'prv'. [funcArgNamesDifferent] aptitude-0.8.13/src/solution_fragment.h:93:36: note: Function 'conflict_text' argument 2 names different: declaration 'p' definition 'prv'. aptitude-0.8.13/src/solution_fragment.cc:158:38: note: Function 'conflict_text' argument 2 names different: declaration 'p' definition 'prv'. aptitude-0.8.13/src/solution_fragment.cc:556:67: style:inconclusive: Function 'solution_fragment_with_ids' argument 1 names different: declaration 'solution' definition 'sol'. [funcArgNamesDifferent] aptitude-0.8.13/src/solution_fragment.h:55:90: note: Function 'solution_fragment_with_ids' argument 1 names different: declaration 'solution' definition 'sol'. aptitude-0.8.13/src/solution_fragment.cc:556:67: note: Function 'solution_fragment_with_ids' argument 1 names different: declaration 'solution' definition 'sol'. aptitude-0.8.13/src/solution_fragment.cc:563:58: style:inconclusive: Function 'solution_fragment' argument 1 names different: declaration 'solution' definition 'sol'. [funcArgNamesDifferent] aptitude-0.8.13/src/solution_fragment.h:45:81: note: Function 'solution_fragment' argument 1 names different: declaration 'solution' definition 'sol'. aptitude-0.8.13/src/solution_fragment.cc:563:58: note: Function 'solution_fragment' argument 1 names different: declaration 'solution' definition 'sol'. aptitude-0.8.13/src/safe_slot_event.h:33:5: style: Class 'safe_slot_event' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/view_changelog.cc:209:3: style: Class 'pkg_changelog_screen' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/view_changelog.cc:272:17: performance: Function parameter 'pkgname' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/view_changelog.cc:273:17: performance: Function parameter 'curverstr' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/view_changelog.cc:392:18: style: Variable 'pkgname' is assigned a value that is never used. [unreadVariable] aptitude-0.8.13/src/pkg_tree.h:143:8: warning: The class 'pkg_tree' defines member variable with name 'find_limit_enabled' also defined in its parent class 'menu_tree'. [duplInheritedMember] aptitude-0.8.13/src/menu_tree.h:204:8: note: Parent variable 'menu_tree::find_limit_enabled' aptitude-0.8.13/src/pkg_tree.h:143:8: note: Derived variable 'pkg_tree::find_limit_enabled' aptitude-0.8.13/src/pkg_tree.h:146:8: warning: The class 'pkg_tree' defines member variable with name 'find_limit' also defined in its parent class 'menu_tree'. [duplInheritedMember] aptitude-0.8.13/src/menu_tree.h:207:8: note: Parent variable 'menu_tree::find_limit' aptitude-0.8.13/src/pkg_tree.h:146:8: note: Derived variable 'pkg_tree::find_limit' aptitude-0.8.13/src/ui.cc:2239:3: style: Class 'interactive_continuation' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/ui.cc:2183:5: style: Class 'success_event' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/ui.cc:2198:5: style: Class 'no_more_solutions_event' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/ui.cc:3488:3: style: Class 'self_destructing_layout' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/src/ui.cc:3460:39: style:inconclusive: Function 'prompt_yesno_popup' argument 1 names different: declaration 'f' definition 'prompt'. [funcArgNamesDifferent] aptitude-0.8.13/src/ui.h:296:44: note: Function 'prompt_yesno_popup' argument 1 names different: declaration 'f' definition 'prompt'. aptitude-0.8.13/src/ui.cc:3460:39: note: Function 'prompt_yesno_popup' argument 1 names different: declaration 'f' definition 'prompt'. aptitude-0.8.13/src/ui.cc:551:20: style: Local variable 'tmp' shadows outer variable [shadowVariable] aptitude-0.8.13/src/ui.cc:513:12: note: Shadowed declaration aptitude-0.8.13/src/ui.cc:551:20: note: Shadow variable aptitude-0.8.13/src/ui.cc:452:34: performance: Function parameter 'args' should be passed by const reference. However it seems that 'do_su_to_root' is a callback function. [passedByValueCallback] aptitude-0.8.13/src/ui.cc:2592:102: note: Function pointer used here. aptitude-0.8.13/src/ui.cc:452:34: note: Function parameter 'args' should be passed by const reference. However it seems that 'do_su_to_root' is a callback function. aptitude-0.8.13/src/ui.cc:1219:47: performance: Function parameter 'old_tmpdir' should be passed by const reference. However it seems that 'do_kill_old_tmp' is a callback function. [passedByValueCallback] aptitude-0.8.13/src/ui.cc:1255:49: note: Function pointer used here. aptitude-0.8.13/src/ui.cc:1219:47: note: Function parameter 'old_tmpdir' should be passed by const reference. However it seems that 'do_kill_old_tmp' is a callback function. aptitude-0.8.13/src/ui.cc:1225:51: performance: Function parameter 'old_tmpdir' should be passed by const reference. However it seems that 'cancel_kill_old_tmp' is a callback function. [passedByValueCallback] aptitude-0.8.13/src/ui.cc:1256:49: note: Function pointer used here. aptitude-0.8.13/src/ui.cc:1225:51: note: Function parameter 'old_tmpdir' should be passed by const reference. However it seems that 'cancel_kill_old_tmp' is a callback function. aptitude-0.8.13/src/ui.cc:2221:19: performance: Function parameter '_msg' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/ui.cc:2886:33: performance: Function parameter 'base' should be passed by const reference. [passedByValue] aptitude-0.8.13/src/ui.cc:916:31: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] aptitude-0.8.13/src/ui.cc:991:33: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] aptitude-0.8.13/src/ui.cc:1011:33: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] aptitude-0.8.13/src/ui.cc:1493:37: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] aptitude-0.8.13/src/ui.cc:1493:37: performance: Passing the result of c_str() to a function that takes std::wstring as argument no. 3 is slow and redundant. [stlcstrParam] aptitude-0.8.13/tests/test_dynamic_list.cc:165:5: style: Class 'list_signal < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_dynamic_list.cc:170:5: style: Class 'list_signal < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_dynamic_list.cc:175:5: style: Class 'list_signal < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_dynamic_list.cc:180:5: style: Class 'list_signal < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_dynamic_list.cc:753:49: style: Parameter 'list' can be declared as reference to const [constParameterReference] aptitude-0.8.13/tests/test_choice_set.cc:75:5: style: Struct 'contents_extractor' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_choice_set.cc:94:5: style: Struct 'contents_enumerator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_choice_set.cc:182:24: style: Local variable 'u' shadows outer variable [shadowVariable] aptitude-0.8.13/tests/test_choice_set.cc:177:29: note: Shadowed declaration aptitude-0.8.13/tests/test_choice_set.cc:182:24: note: Shadow variable aptitude-0.8.13/tests/test_dynamic_set.cc:127:5: style: Class 'set_signal < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_dynamic_set.cc:132:5: style: Class 'set_signal < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_dynamic_set.cc:137:5: style: Class 'set_signal < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_dynamic_set.cc:86:5: style: Class 'removed_call < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_dynamic_set.cc:50:5: style: Class 'inserted_call < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_dynamic_set.cc:249:22: style: struct member 'set_test::expected' is never used. [unusedStructMember] aptitude-0.8.13/tests/test_incremental_expression.cc:92:5: style: Class 'get_value_call' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_incremental_expression.cc:165:5: style: Class 'changed_call' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_incremental_expression.cc:190:5: style: Class 'fake_wrapper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_incremental_expression.cc:120:5: style: Class 'fake_container < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_incremental_expression.cc:120:5: style: Class 'fake_container < bool >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_file_cache.cc:84:3: style: Class 'raw_istream_iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_matching.cc:836:9: warning: Class 'intArray2d' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] aptitude-0.8.13/tests/test_sqlite.cc:243:5: performance: Variable 'get_C_statement' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] aptitude-0.8.13/tests/test_sqlite.cc:239:20: style: struct member 'parameter_binding_test::test_A' is never used. [unusedStructMember] aptitude-0.8.13/tests/test_teletype_mock.cc:114:26: style: Unsigned expression 'widechar.size()' can't be negative so it is unnecessary to test it. [unsignedPositive] aptitude-0.8.13/tests/test_teletype_mock.cc:116:46: warning: Either the condition 'widechar.size()>=0' is redundant or expression 'widechar[0]' causes access out of bounds. [containerOutOfBounds] aptitude-0.8.13/tests/test_teletype_mock.cc:114:26: note: Assuming that condition 'widechar.size()>=0' is not redundant aptitude-0.8.13/tests/test_teletype_mock.cc:116:46: note: Access out of bounds aptitude-0.8.13/tests/test_teletype_mock.cc:117:53: warning: Either the condition 'widechar.size()>=0' is redundant or expression 'widechar[0]' causes access out of bounds. [containerOutOfBounds] aptitude-0.8.13/tests/test_teletype_mock.cc:114:26: note: Assuming that condition 'widechar.size()>=0' is not redundant aptitude-0.8.13/tests/test_teletype_mock.cc:117:53: note: Access out of bounds aptitude-0.8.13/tests/test_teletype_mock.cc:67:17: style: struct member 'TeletypeTest::previous_lc_ctype' is never used. [unusedStructMember] aptitude-0.8.13/tests/test_temp.cc:175:13: warning: Either the condition 'fd==-1' is redundant or close() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'. [invalidFunctionArg] aptitude-0.8.13/tests/test_temp.cc:171:13: note: Assuming that condition 'fd==-1' is not redundant aptitude-0.8.13/tests/test_temp.cc:175:13: note: Invalid argument aptitude-0.8.13/tests/test_temp.cc:242:11: warning: Either the condition 'fd==-1' is redundant or close() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'. [invalidFunctionArg] aptitude-0.8.13/tests/test_temp.cc:238:11: note: Assuming that condition 'fd==-1' is not redundant aptitude-0.8.13/tests/test_temp.cc:242:11: note: Invalid argument aptitude-0.8.13/tests/test_temp.cc:295:11: warning: Either the condition 'fd==-1' is redundant or close() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'. [invalidFunctionArg] aptitude-0.8.13/tests/test_temp.cc:291:11: note: Assuming that condition 'fd==-1' is not redundant aptitude-0.8.13/tests/test_temp.cc:295:11: note: Invalid argument aptitude-0.8.13/tests/test_temp.cc:346:11: warning: Either the condition 'fd==-1' is redundant or close() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'. [invalidFunctionArg] aptitude-0.8.13/tests/test_temp.cc:342:11: note: Assuming that condition 'fd==-1' is not redundant aptitude-0.8.13/tests/test_temp.cc:346:11: note: Invalid argument aptitude-0.8.13/tests/test_temp.cc:363:9: style: Statements following noreturn function 'exit()' will never be executed. [unreachableCode] aptitude-0.8.13/tests/test_parsers.cc:1293:5: style: Class 'lessThan_f' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_parsers.cc:427:27: style: Variable 'ex' can be declared as reference to const [constVariableReference] aptitude-0.8.13/tests/test_wtree.cc:771:9: performance:inconclusive: Technically the member function 'WTreeTest::maxAccumOps::empty' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/tests/test_wtree.cc:772:9: performance:inconclusive: Technically the member function 'WTreeTest::maxAccumOps::project' can be static (but you may consider moving to unnamed namespace). [functionStatic] aptitude-0.8.13/tests/test_wtree.cc:1263:5: style: Struct 'set_or_break' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] aptitude-0.8.13/tests/test_wtree.cc:492:9: style: Variable 'tmp' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:987:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1002:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1008:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1015:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1031:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1038:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1045:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1052:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1059:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1066:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1072:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1078:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1085:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1092:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1099:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1107:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_wtree.cc:1115:12: style: Variable 'vals' can be declared as pointer to const [constVariablePointer] aptitude-0.8.13/tests/test_wtree.cc:1135:11: style: Variable 'vals' can be declared as const array [constVariable] aptitude-0.8.13/tests/test_resolver.cc:1325:25: style: Local variable 'initial_state' shadows outer variable [shadowVariable] aptitude-0.8.13/tests/test_resolver.cc:1303:32: note: Shadowed declaration aptitude-0.8.13/tests/test_resolver.cc:1325:25: note: Shadow variable aptitude-0.8.13/tests/test_resolver.cc:1344:22: style: Local variable 'initial_state' shadows outer variable [shadowVariable] aptitude-0.8.13/tests/test_resolver.cc:1303:32: note: Shadowed declaration aptitude-0.8.13/tests/test_resolver.cc:1344:22: note: Shadow variable diff: head aptitude-0.8.13/src/cmdline/cmdline_extract_cache_subset.cc:55:46: style: Parameter 'argv' can be declared as const array [constParameter] head aptitude-0.8.13/src/cmdline/cmdline_moo.cc:11:33: style: Parameter 'argv' can be declared as const array [constParameter] head aptitude-0.8.13/src/cmdline/cmdline_prompt.cc:623:14: style: Parameter 'to_hold' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/cmdline/cmdline_prompt.cc:66:47: style: Parameter 'reasons' can be declared as reference to const [constParameterReference] 2.13.0 aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:309:16: warning: Either the condition 'i>(int)choices.size()' is redundant or 'i' can have the value choices.size(). Expression 'choices[i]' cause access out of bounds. [containerOutOfBounds] aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:306:41: note: Assuming that condition 'i>(int)choices.size()' is not redundant aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:309:16: note: Access out of bounds head aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:309:16: warning: Either the condition 'i>(int)choices.size()' is redundant or 'i' can have the value choices.size(). Expression 'choices[i]' causes access out of bounds. [containerOutOfBounds] aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:306:41: note: Assuming that condition 'i>(int)choices.size()' is not redundant aptitude-0.8.13/src/cmdline/cmdline_resolver.cc:309:16: note: Access out of bounds head aptitude-0.8.13/src/cmdline/cmdline_search.cc:183:36: style: Parameter 'argv' can be declared as const array [constParameter] head aptitude-0.8.13/src/cmdline/cmdline_versions.cc:542:38: style: Parameter 'argv' can be declared as const array [constParameter] head aptitude-0.8.13/src/cmdline/cmdline_why.cc:261:9: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/cmdline/cmdline_why.cc:264:9: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/cmdline/cmdline_why.cc:271:9: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/cmdline/cmdline_why.cc:274:9: style: C-style pointer casting [cstyleCast] 2.13.0 aptitude-0.8.13/src/dep_item.cc:185:11: style:inconclusive: Boolean expression 'last_or' is used in bitwise operation. [bitwiseOnBoolean] head aptitude-0.8.13/src/dep_item.cc:218:12: style: The destructor '~pkg_grouppolicy_dep' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/dep_item.cc:218:12: note: Destructor in derived class head aptitude-0.8.13/src/dep_item.cc:282:32: style: Parameter 'child' can be declared as pointer to const [constParameterPointer] head aptitude-0.8.13/src/dep_item.cc:282:52: style: Parameter 'parent' can be declared as pointer to const [constParameterPointer] head aptitude-0.8.13/src/dep_item.h:79:12: style: The destructor '~pkg_dep_screen' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_tree.h:110:4: note: Virtual destructor in base class aptitude-0.8.13/src/dep_item.h:79:12: note: Destructor in derived class head aptitude-0.8.13/src/download_list.cc:343:26: style: Parameter 'manager' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/download_list.cc:363:28: style: Parameter 'manager' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/download_list.cc:377:49: style: Parameter 'itmdesc' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/download_list.cc:378:27: style: Parameter 'manager' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/download_list.cc:383:26: style: Parameter 'manager' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/download_list.cc:398:26: style: Parameter 'manager' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/download_list.cc:435:48: style: Parameter 'manager' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/download_list.cc:475:51: style: Parameter 'manager' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/generic/apt/apt.cc:1033:42: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/apt.cc:819:83: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.cc:492:10: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:1049:93: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:1305:49: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:516:8: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:683:26: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:778:22: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:793:22: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:877:25: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/aptitude_resolver_universe.h:906:71: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/download_install_manager.h:117:4: style: The destructor '~download_install_manager' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_manager.h:61:12: note: Virtual destructor in base class aptitude-0.8.13/src/generic/apt/download_install_manager.h:117:4: note: Destructor in derived class head aptitude-0.8.13/src/generic/apt/download_update_manager.h:55:4: style: The destructor '~download_update_manager' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/apt/download_manager.h:61:12: note: Virtual destructor in base class aptitude-0.8.13/src/generic/apt/download_update_manager.h:55:4: note: Destructor in derived class 2.13.0 aptitude-0.8.13/src/generic/apt/dump_packages.cc:536:2: error: Resource leak: infd [resourceLeak] 2.13.0 aptitude-0.8.13/src/generic/apt/dump_packages.cc:542:4: error: Resource leak: infd [resourceLeak] 2.13.0 aptitude-0.8.13/src/generic/apt/dump_packages.cc:546:2: error: Resource leak: infd [resourceLeak] 2.13.0 aptitude-0.8.13/src/generic/apt/dump_packages.cc:549:2: error: Resource leak: infd [resourceLeak] 2.13.0 aptitude-0.8.13/src/generic/apt/dump_packages.cc:553:2: error: Resource leak: infd [resourceLeak] 2.13.0 aptitude-0.8.13/src/generic/apt/dump_packages.cc:556:5: error: Resource leak: infd [resourceLeak] 2.13.0 aptitude-0.8.13/src/generic/apt/dump_packages.cc:670:2: error: Resource leak: infd [resourceLeak] 2.13.0 aptitude-0.8.13/src/generic/apt/dump_packages.cc:674:2: error: Resource leak: infd [resourceLeak] head aptitude-0.8.13/src/generic/apt/matching/match.cc:2016:12: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/matching/match.cc:2017:12: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/matching/match.h:541:9: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/matching/match.h:542:9: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/matching/match.h:565:9: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/matching/match.h:566:9: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:56:41: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:57:37: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:58:31: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:76:41: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:77:37: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/rev_dep_iterator.h:78:31: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/generic/apt/tasks.cc:293:56: performance: Function parameter 'msgid' should be passed by const reference. [passedByValue] head aptitude-0.8.13/src/generic/controllers/acquire_download_progress.cc:238:70: style: Parameter 'manager' can be declared as reference to const. However it seems that 'start' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/generic/controllers/acquire_download_progress.cc:97:58: note: You might need to cast the function pointer here aptitude-0.8.13/src/generic/controllers/acquire_download_progress.cc:238:70: note: Parameter 'manager' can be declared as reference to const head aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:300:4: style: The destructor '~expression_box < bool >' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:213:12: note: Virtual destructor in base class aptitude-0.8.13/src/generic/problemresolver/incremental_expression.h:300:4: note: Destructor in derived class head aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:4307:49: error: Uninitialized variable: action_hits [uninitvar] head aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:544:16: style:inconclusive: Member variable 'generic_problem_resolver < dummy_universe_ref >::graph' uses an uninitialized argument 'promotions' due to the order of declarations. [initializerList] aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:3749:6: note: Member variable 'generic_problem_resolver < dummy_universe_ref >::graph' uses an uninitialized argument 'promotions' due to the order of declarations. aptitude-0.8.13/src/generic/problemresolver/problemresolver.h:544:16: note: Member variable 'generic_problem_resolver < dummy_universe_ref >::graph' uses an uninitialized argument 'promotions' due to the order of declarations. head aptitude-0.8.13/src/generic/problemresolver/sanity_check_universe.h:160:15: style: Redundant assignment of 'solverpkg' to itself. [selfAssignment] 2.13.0 aptitude-0.8.13/src/generic/problemresolver/sanity_check_universe.h:160:15: warning: Redundant assignment of 'solverpkg' to itself. [selfAssignment] head aptitude-0.8.13/src/generic/problemresolver/sanity_check_universe.h:160:38: style: Redundant assignment of 'solverver' to itself. [selfAssignment] 2.13.0 aptitude-0.8.13/src/generic/problemresolver/sanity_check_universe.h:160:38: warning: Redundant assignment of 'solverver' to itself. [selfAssignment] head aptitude-0.8.13/src/generic/util/undo.h:48:12: style: The destructor '~undo_group' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/generic/util/undo.h:26:12: note: Virtual destructor in base class aptitude-0.8.13/src/generic/util/undo.h:48:12: note: Destructor in derived class head aptitude-0.8.13/src/gtk/dashboardtab.h:256:6: style: The destructor '~DashboardTab' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/tab.h:108:16: note: Virtual destructor in base class aptitude-0.8.13/src/gtk/dashboardtab.h:256:6: note: Destructor in derived class head aptitude-0.8.13/src/gtk/download.cc:151:56: style: Parameter 'manager' can be declared as reference to const. However it seems that 'Start' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:148:71: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:151:56: note: Parameter 'manager' can be declared as reference to const head aptitude-0.8.13/src/gtk/download.cc:155:55: style: Parameter 'manager' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/gtk/download.cc:164:28: style: Parameter 'manager' can be declared as reference to const. However it seems that 'Pulse' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:147:71: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:164:28: note: Parameter 'manager' can be declared as reference to const head aptitude-0.8.13/src/gtk/download.cc:171:27: style: Parameter 'log' can be declared as reference to const. However it seems that 'Fail' is a callback function, if 'log' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:146:70: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:171:27: note: Parameter 'log' can be declared as reference to const head aptitude-0.8.13/src/gtk/download.cc:191:29: style: Parameter 'manager' can be declared as reference to const. However it seems that 'IMSHit' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:143:72: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:191:29: note: Parameter 'manager' can be declared as reference to const head aptitude-0.8.13/src/gtk/download.cc:196:57: style: Parameter 'Itm' can be declared as reference to const. However it seems that 'Fetch' is a callback function, if 'Itm' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:144:71: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:196:57: note: Parameter 'Itm' can be declared as reference to const head aptitude-0.8.13/src/gtk/download.cc:197:28: style: Parameter 'manager' can be declared as reference to const. However it seems that 'Fetch' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:144:71: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:197:28: note: Parameter 'manager' can be declared as reference to const head aptitude-0.8.13/src/gtk/download.cc:202:27: style: Parameter 'manager' can be declared as reference to const. However it seems that 'Done' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:145:70: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:202:27: note: Parameter 'manager' can be declared as reference to const head aptitude-0.8.13/src/gtk/download.cc:429:39: style: Parameter 'Itm' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/gtk/download.cc:430:24: style: Parameter 'log' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/gtk/download.cc:436:31: style: Parameter 'manager' can be declared as reference to const. However it seems that 'MediaChange' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:420:33: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:436:31: note: Parameter 'manager' can be declared as reference to const head aptitude-0.8.13/src/gtk/download.cc:529:38: style: Parameter 'manager' can be declared as reference to const. However it seems that 'Stop' is a callback function, if 'manager' is declared with const you might also need to cast function pointer(s). [constParameterCallback] aptitude-0.8.13/src/gtk/download.cc:426:33: note: You might need to cast the function pointer here aptitude-0.8.13/src/gtk/download.cc:529:38: note: Parameter 'manager' can be declared as reference to const 2.13.0 aptitude-0.8.13/src/gtk/dpkg_terminal.cc:198:14: style: C-style pointer casting [cstyleCast] head aptitude-0.8.13/src/gtk/gui.cc:1682:35: style: Parameter 'argv' can be declared as const array [constParameter] head aptitude-0.8.13/src/gtk/info.cc:271:58: style: Parameter 'packages' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/gtk/info.cc:281:50: style: Parameter 'actions' can be declared as reference to const [constParameterReference] head aptitude-0.8.13/src/gtk/pkgview.h:316:14: style: The destructor '~PkgViewBase' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/entityview.h:238:16: note: Virtual destructor in base class aptitude-0.8.13/src/gtk/pkgview.h:316:14: note: Destructor in derived class 2.13.0 aptitude-0.8.13/src/gtk/screenshot_cache.cc:186:6: error: Resource leak: fdnum [resourceLeak] head aptitude-0.8.13/src/gtk/screenshot_cache.cc:271:8: style: The destructor '~screenshot_cache_entry' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/gtk/screenshot_cache.h:63:14: note: Virtual destructor in base class aptitude-0.8.13/src/gtk/screenshot_cache.cc:271:8: note: Destructor in derived class head aptitude-0.8.13/src/load_grouppolicy.cc:159:4: style: The destructor '~group_policy_pair_node' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/load_grouppolicy.cc:79:12: note: Virtual destructor in base class aptitude-0.8.13/src/load_grouppolicy.cc:159:4: note: Destructor in derived class head aptitude-0.8.13/src/menu_tree.h:110:4: style: The destructor '~menu_tree' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_redirect.h:165:12: note: Virtual destructor in base class aptitude-0.8.13/src/menu_tree.h:110:4: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.cc:1197:4: style: The destructor '~pkg_grouppolicy_patterns' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1197:4: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.cc:121:12: style: The destructor '~pkg_grouppolicy_section' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:121:12: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.cc:1349:4: style: The destructor '~pkg_grouppolicy_tag' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1349:4: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.cc:1511:4: style: The destructor '~pkg_grouppolicy_facet_tag' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1511:4: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.cc:1559:4: style: The destructor '~pkg_grouppolicy_source' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1559:4: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.cc:1637:4: style: The destructor '~pkg_grouppolicy_arch' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:1637:4: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.cc:453:12: style: The destructor '~pkg_grouppolicy_status' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:453:12: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.cc:545:12: style: The destructor '~pkg_grouppolicy_filter' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:545:12: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.cc:681:12: style: The destructor '~pkg_grouppolicy_mode' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:681:12: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.cc:732:4: style: The destructor '~pkg_grouppolicy_firstchar' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:732:4: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.cc:827:4: style: The destructor '~pkg_grouppolicy_priority' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:827:4: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.cc:935:4: style: The destructor '~pkg_grouppolicy_task' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:86:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.cc:935:4: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.h:170:12: style: The destructor '~pkg_grouppolicy_section_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:170:12: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.h:184:12: style: The destructor '~pkg_grouppolicy_status_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:184:12: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.h:202:12: style: The destructor '~pkg_grouppolicy_filter_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:202:12: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.h:218:12: style: The destructor '~pkg_grouppolicy_mode_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:218:12: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.h:273:12: style: The destructor '~pkg_grouppolicy_firstchar_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:273:12: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.h:287:12: style: The destructor '~pkg_grouppolicy_priority_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:287:12: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.h:305:12: style: The destructor '~pkg_grouppolicy_task_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:305:12: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.h:354:4: style: The destructor '~pkg_grouppolicy_patterns_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:354:4: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.h:373:4: style: The destructor '~pkg_grouppolicy_tag_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:373:4: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.h:389:4: style: The destructor '~pkg_grouppolicy_facet_tag_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:389:4: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.h:402:12: style: The destructor '~pkg_grouppolicy_source_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:402:12: note: Destructor in derived class head aptitude-0.8.13/src/pkg_grouppolicy.h:416:12: style: The destructor '~pkg_grouppolicy_arch_factory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/pkg_grouppolicy.h:99:12: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_grouppolicy.h:416:12: note: Destructor in derived class head aptitude-0.8.13/src/pkg_tree.h:114:4: style: The destructor '~pkg_tree' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/menu_tree.h:110:4: note: Virtual destructor in base class aptitude-0.8.13/src/pkg_tree.h:114:4: note: Destructor in derived class head aptitude-0.8.13/src/qt/package_pool.cc:66:11: style: The destructor '~package_pool_impl' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/package_pool.h:50:11: note: Virtual destructor in base class aptitude-0.8.13/src/qt/package_pool.cc:66:11: note: Destructor in derived class head aptitude-0.8.13/src/qt/widgets/changes_preview_tab.h:43:11: style: The destructor '~changes_preview_tab' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/widgets/tab.h:74:11: note: Virtual destructor in base class aptitude-0.8.13/src/qt/widgets/changes_preview_tab.h:43:11: note: Destructor in derived class head aptitude-0.8.13/src/qt/widgets/package_info_tab.h:42:11: style: The destructor '~package_info_tab' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/widgets/tab.h:74:11: note: Virtual destructor in base class aptitude-0.8.13/src/qt/widgets/package_info_tab.h:42:11: note: Destructor in derived class head aptitude-0.8.13/src/qt/widgets/perform_changes_tab.h:43:11: style: The destructor '~perform_changes_tab' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/widgets/tab.h:74:11: note: Virtual destructor in base class aptitude-0.8.13/src/qt/widgets/perform_changes_tab.h:43:11: note: Destructor in derived class head aptitude-0.8.13/src/qt/widgets/resolver_tab.h:42:11: style: The destructor '~resolver_tab' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] aptitude-0.8.13/src/qt/widgets/tab.h:74:11: note: Virtual destructor in base class aptitude-0.8.13/src/qt/widgets/resolver_tab.h:42:11: note: Destructor in derived class head aptitude-0.8.13/tests/test_dynamic_list.cc:753:49: style: Parameter 'list' can be declared as reference to const [constParameterReference] 2.13.0 aptitude-0.8.13/tests/test_teletype_mock.cc:116:46: warning: Either the condition 'widechar.size()>=0' is redundant or expression 'widechar[0]' cause access out of bounds. [containerOutOfBounds] aptitude-0.8.13/tests/test_teletype_mock.cc:114:26: note: Assuming that condition 'widechar.size()>=0' is not redundant aptitude-0.8.13/tests/test_teletype_mock.cc:116:46: note: Access out of bounds head aptitude-0.8.13/tests/test_teletype_mock.cc:116:46: warning: Either the condition 'widechar.size()>=0' is redundant or expression 'widechar[0]' causes access out of bounds. [containerOutOfBounds] aptitude-0.8.13/tests/test_teletype_mock.cc:114:26: note: Assuming that condition 'widechar.size()>=0' is not redundant aptitude-0.8.13/tests/test_teletype_mock.cc:116:46: note: Access out of bounds 2.13.0 aptitude-0.8.13/tests/test_teletype_mock.cc:117:53: warning: Either the condition 'widechar.size()>=0' is redundant or expression 'widechar[0]' cause access out of bounds. [containerOutOfBounds] aptitude-0.8.13/tests/test_teletype_mock.cc:114:26: note: Assuming that condition 'widechar.size()>=0' is not redundant aptitude-0.8.13/tests/test_teletype_mock.cc:117:53: note: Access out of bounds head aptitude-0.8.13/tests/test_teletype_mock.cc:117:53: warning: Either the condition 'widechar.size()>=0' is redundant or expression 'widechar[0]' causes access out of bounds. [containerOutOfBounds] aptitude-0.8.13/tests/test_teletype_mock.cc:114:26: note: Assuming that condition 'widechar.size()>=0' is not redundant aptitude-0.8.13/tests/test_teletype_mock.cc:117:53: note: Access out of bounds DONE